RE: Confusing entity names

2018-04-17 Thread Gareth Carter
It was an idea and maybe the development required outweighs the value to the project. Adding a deprecated flag may be useful but you have that with the existing process (prepend Old to entity name) For such a small change, this can have a major impact for existing installations Gareth Carter

RE: Confusing entity names

2018-04-17 Thread Gareth Carter
the risk for custom components/plugins upgrading to a newer release and give developers time to make the changes Just a thought, I know for a fact that if OrderItemShipGroup and others are renamed, we would have a lot of refactoring to do Gareth Carter Software Development Analyst Stannah

RE: Confusing entity names

2018-04-17 Thread Gareth Carter
physical table? Gareth Carter Software Development Analyst Stannah Management Services Ltd IT Department Ext: 7036 DDI: 01264 364311 Please consider the environment before printing this email. -Original Message- From: Rajesh Mallah [mailto:mallah.raj...@gmail.com] Sent: 12 April 2018 2:47 PM

RE: Updates to EntityQuery

2017-10-27 Thread Gareth Carter
Hi Paul Problem with that, it's all or nothing. We only need this for specific use cases. Having forUpdate in EntityQuery gives us that flexibility. It could be changed to use either method which depends on the scenario you use it for Gareth Carter Software Development Analyst Stannah

RE: Updates to EntityQuery

2017-10-26 Thread Gareth Carter
on services but I believe you need something at entity level Gareth Carter Software Development Analyst Stannah Management Services Ltd IT Department Ext: 7036 DDI: 01264 364311 Please consider the environment before printing this email. -Original Message- From: Taher Alkhateeb

Re: Updates to EntityQuery

2017-10-25 Thread Gareth Carter
Ok I will create a Jira with patch for review. Sent from my Samsung Galaxy smartphone. Gareth Carter Software Development Analyst Stannah Management Services Ltd IT Department Ext: 7036 DDI: 01264 364311 [http://logos.stannah.co.uk/stan150.jpg] [http://logos.stannah.co.uk

RE: Updates to EntityQuery

2017-10-25 Thread Gareth Carter
e (eg queryIterator(), while loop and close) Example: EntityQuery.use(delegator).from("Foobar") .forEach(item -> Debug.logInfo(item.toString(), module); ); A further update could be to provide stream capabilities Hope this helps, I can provide a patch aswell Gareth Carter Sof

Updates to EntityQuery

2017-10-24 Thread Gareth Carter
for creating cache map objects for lookup - Support forUpdate - forEach method to accept Consumer We have found these useful and believe the project can benefit, let me know what you think Regards Gareth Carter Software Development Analyst Stannah Management Services Ltd IT Department

Re: Keep javaScriptEnabled manage on the framework ?

2017-09-01 Thread Gareth Carter
though it shouldn't have. Get rid of it and let the themes handle if JavaScript is used Gareth Sent from my Samsung Galaxy smartphone. Gareth Carter Software Development Analyst Stannah Management Services Ltd IT Department Ext: 7036 DDI: 01264 364311 [http

[jira] [Commented] (OFBIZ-7346) connection pooling not working

2016-06-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335932#comment-15335932 ] Gareth Carter commented on OFBIZ-7346: -- We have this patched in our dev environment, will be pushed

[jira] [Commented] (OFBIZ-7346) connection pooling not working

2016-06-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335867#comment-15335867 ] Gareth Carter commented on OFBIZ-7346: -- I think most db drivers set autoCommit = true on new

[jira] [Commented] (OFBIZ-6386) compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not compare certain values correctly

2016-06-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335691#comment-15335691 ] Gareth Carter commented on OFBIZ-6386: -- Jacopo beat me to it! > compareBigDecim

[jira] [Commented] (OFBIZ-6386) compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not compare certain values correctly

2016-06-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335689#comment-15335689 ] Gareth Carter commented on OFBIZ-6386: -- {quote} Mini-language is a scripting language. One

[jira] [Commented] (OFBIZ-7346) connection pooling not working

2016-06-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335635#comment-15335635 ] Gareth Carter commented on OFBIZ-7346: -- setRollbackOnReturn fixed the actual issue, when a connection

[jira] [Comment Edited] (OFBIZ-7344) db connections remain open and unused on startup

2016-06-15 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331543#comment-15331543 ] Gareth Carter edited comment on OFBIZ-7344 at 6/15/16 11:13 AM: I tested

[jira] [Commented] (OFBIZ-7344) db connections remain open and unused on startup

2016-06-15 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331543#comment-15331543 ] Gareth Carter commented on OFBIZ-7344: -- I tested again. Without the patch, the connections stayed

[jira] [Updated] (OFBIZ-7346) connection pooling not working

2016-06-14 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-7346: - Attachment: DBCPConnectionFactory.patch Here is a patch we have put on our trunk server which

[jira] [Updated] (OFBIZ-7346) connection pooling not working

2016-06-14 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-7346: - Description: Connection pooling does not seem to work. Connections are created fine

[jira] [Created] (OFBIZ-7346) connection pooling not working

2016-06-14 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-7346: Summary: connection pooling not working Key: OFBIZ-7346 URL: https://issues.apache.org/jira/browse/OFBIZ-7346 Project: OFBiz Issue Type: Bug

[jira] [Updated] (OFBIZ-7344) db connections remain open and unused on startup

2016-06-14 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-7344: - Attachment: DatabaseUtil.patch This patch removes the need for getDatabaseMetaData to create

[jira] [Created] (OFBIZ-7344) db connections remain open and unused on startup

2016-06-14 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-7344: Summary: db connections remain open and unused on startup Key: OFBIZ-7344 URL: https://issues.apache.org/jira/browse/OFBIZ-7344 Project: OFBiz Issue Type

Connection pooling issue

2016-06-14 Thread Gareth Carter
Hi Is anyone having issues with connection pooling in ofbiz? I have noticed on our systems (production, test and local) that after startup, 3 connections are created (for each db), stay in idle and are never reused. As the systems are used, connections are created and closed after use. I

RE: Question on multiple starting ofbiz

2016-06-02 Thread Gareth Carter
We have a server with multiple instances of ofbiz running using port offset. But these are completely separate java processes, separate classloaders and locks etc You would not even be able to start the same instance multiple times (maybe POS?), port numbers would be in use unless you change

[jira] [Commented] (OFBIZ-3847) Entity ECAs not triggered correctly when using Delegator.storeAll() method

2016-05-12 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281317#comment-15281317 ] Gareth Carter commented on OFBIZ-3847: -- When I highlighted the line, I meant that oldValue is null

[jira] [Commented] (OFBIZ-3847) Entity ECAs not triggered correctly when using Delegator.storeAll() method

2016-05-12 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281293#comment-15281293 ] Gareth Carter commented on OFBIZ-3847: -- Hi Paul Thanks for the quick response! My guess

[jira] [Commented] (OFBIZ-3847) Entity ECAs not triggered correctly when using Delegator.storeAll() method

2016-05-11 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279901#comment-15279901 ] Gareth Carter commented on OFBIZ-3847: -- Hi I have just encountered an issue caused by the patch

[jira] [Commented] (OFBIZ-5732) Error in sendMailHiddenInLog service

2016-04-28 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261727#comment-15261727 ] Gareth Carter commented on OFBIZ-5732: -- I would, we've applied this as a patch in our production

[jira] [Commented] (OFBIZ-6686) The following required parameter is missing: [IN] [sendMailMultiPart.bodyParts] (The following required parameter is missing: [IN] [sendMailMultiPart.bodyParts])

2016-04-25 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256067#comment-15256067 ] Gareth Carter commented on OFBIZ-6686: -- I believe this is an issue with sendFailureNotification - see

[jira] [Commented] (OFBIZ-5732) Error in sendMailHiddenInLog service

2016-04-25 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256066#comment-15256066 ] Gareth Carter commented on OFBIZ-5732: -- Also I think OFBiz-6686 is related. A report of a similar

[jira] [Commented] (OFBIZ-5732) Error in sendMailHiddenInLog service

2016-04-25 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256064#comment-15256064 ] Gareth Carter commented on OFBIZ-5732: -- We've just encountered this problem. Testing

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-13 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238973#comment-15238973 ] Gareth Carter commented on OFBIZ-6705: -- Yes, we should change it for consistency > some files

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-13 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238792#comment-15238792 ] Gareth Carter commented on OFBIZ-6705: -- Sorry Jacques but this Jira hasn't actually been fixed

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-11 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235067#comment-15235067 ] Gareth Carter commented on OFBIZ-6705: -- His views are reasonable and we were in a similar scenario

[jira] [Commented] (OFBIZ-6985) New Theme sponsored by Provolve and Stannah

2016-04-11 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234864#comment-15234864 ] Gareth Carter commented on OFBIZ-6985: -- I have submitted my ICLA today > New Theme sponso

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-11 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234863#comment-15234863 ] Gareth Carter commented on OFBIZ-6705: -- Thanks for reviewing, please provide any suggestions

[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-07 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6705: - Attachment: OFBIZ-6705.patch patch with some javadoc > some files set viewIndex to 1 by defa

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-06 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228125#comment-15228125 ] Gareth Carter commented on OFBIZ-6705: -- Yes I can add javadoc, I initially didn't add so

[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-06 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6705: - Attachment: OFBIZ-6705_sample.patch Here is a sample of using it. > some files set viewIn

[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-06 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6705: - Attachment: OFBIZ-6705.patch OFBIZ-6705.patch contains suggested changes, I wasn't 100% sure

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-05 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226142#comment-15226142 ] Gareth Carter commented on OFBIZ-6705: -- I will provide a patch of what we have done internally

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2016-04-05 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226050#comment-15226050 ] Gareth Carter commented on OFBIZ-6705: -- Its been a few months that anyone has posted on this jira, I

[jira] [Created] (OFBIZ-6983) Change default type for view-map to something more appropriate

2016-04-04 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-6983: Summary: Change default type for view-map to something more appropriate Key: OFBIZ-6983 URL: https://issues.apache.org/jira/browse/OFBIZ-6983 Project: OFBiz

[jira] [Created] (OFBIZ-6848) Add getFieldList method to EntityQuery

2016-01-22 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-6848: Summary: Add getFieldList method to EntityQuery Key: OFBIZ-6848 URL: https://issues.apache.org/jira/browse/OFBIZ-6848 Project: OFBiz Issue Type: Improvement

[jira] [Updated] (OFBIZ-6848) Add getFieldList method to EntityQuery

2016-01-22 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6848: - Attachment: EntityQuery.patch > Add getFieldList method to EntityQu

[jira] [Commented] (OFBIZ-6697) CommunicationServices.createAttachmentContent duplicates attachments for existing CommunicationEvents

2016-01-04 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080885#comment-15080885 ] Gareth Carter commented on OFBIZ-6697: -- We have been using this patch in production for about 2

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2016-01-04 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080873#comment-15080873 ] Gareth Carter commented on OFBIZ-5608: -- Thats the thing isn't it? There is no case. For date only

[jira] [Issue Comment Deleted] (OFBIZ-6655) Add session tracking mode and make cookie secure

2015-12-16 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6655: - Comment: was deleted (was: FYI, most of the local DTD/schemas are found in servlet-api-3.0.jar

[jira] [Commented] (OFBIZ-6655) Add session tracking mode and make cookie secure

2015-12-16 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059766#comment-15059766 ] Gareth Carter commented on OFBIZ-6655: -- FYI, most of the local DTD/schemas are found in servlet-api

[jira] [Commented] (OFBIZ-6655) Add session tracking mode and make cookie secure

2015-12-16 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059767#comment-15059767 ] Gareth Carter commented on OFBIZ-6655: -- FYI, most of the local DTD/schemas are found in servlet-api

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008520#comment-15008520 ] Gareth Carter commented on OFBIZ-5608: -- Actually from what I remember, we had to change

[jira] [Comment Edited] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008920#comment-15008920 ] Gareth Carter edited comment on OFBIZ-5608 at 11/17/15 4:18 PM: I have

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008920#comment-15008920 ] Gareth Carter commented on OFBIZ-5608: -- I have created a person on trunk with locale set to en-US

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008773#comment-15008773 ] Gareth Carter commented on OFBIZ-5608: -- Ok I tried on trunk, it seems to be working though

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008690#comment-15008690 ] Gareth Carter commented on OFBIZ-5608: -- Yes the tooltip doesn't but what if you select a date from

[jira] [Comment Edited] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008380#comment-15008380 ] Gareth Carter edited comment on OFBIZ-5608 at 11/17/15 9:44 AM: I

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-17 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008380#comment-15008380 ] Gareth Carter commented on OFBIZ-5608: -- I was under the impression that ofbiz will always render date

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-16 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006473#comment-15006473 ] Gareth Carter commented on OFBIZ-5608: -- It is expected that when is used the displayed data comes

[jira] [Comment Edited] (OFBIZ-6210) Replace EntityUtilProperties with EntityClassLoader

2015-11-06 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993533#comment-14993533 ] Gareth Carter edited comment on OFBIZ-6210 at 11/6/15 11:32 AM: I have

[jira] [Commented] (OFBIZ-6210) Replace EntityUtilProperties with EntityClassLoader

2015-11-06 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993533#comment-14993533 ] Gareth Carter commented on OFBIZ-6210: -- I have found a few minor issues with this implementation. 1

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-06 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993659#comment-14993659 ] Gareth Carter commented on OFBIZ-5608: -- Patch works. To test: - Set timezone to Europe/London

[jira] [Updated] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-11-05 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6702: - Attachment: OFBIZ-6702-2.patch See slight mod to SimpleContentViewHandler > Upd

[jira] [Commented] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-11-05 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991887#comment-14991887 ] Gareth Carter commented on OFBIZ-6702: -- I should mention I mean this only from

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-05 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991952#comment-14991952 ] Gareth Carter commented on OFBIZ-5608: -- I need to test again, OFBIZ-6537 prevented me but now

[jira] [Commented] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-11-05 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991822#comment-14991822 ] Gareth Carter commented on OFBIZ-6702: -- Patch seems to work. May have found a slight security issue

[jira] [Commented] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-11-04 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989221#comment-14989221 ] Gareth Carter commented on OFBIZ-6702: -- Here is an interesting link about security https

[jira] [Updated] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-11-02 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6702: - Attachment: ContentDisposition.patch I use the requestHandler properties file to store

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2015-11-02 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984994#comment-14984994 ] Gareth Carter commented on OFBIZ-6705: -- I only noticed this because we have a custom service

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2015-11-02 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985131#comment-14985131 ] Gareth Carter commented on OFBIZ-6705: -- applications/order/webapp/ordermgr/WEB-INF/actions/order

[jira] [Commented] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-10-30 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982218#comment-14982218 ] Gareth Carter commented on OFBIZ-6702: -- Seems like firefox will honour Content-Disposition

[jira] [Commented] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-10-30 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982555#comment-14982555 ] Gareth Carter commented on OFBIZ-6702: -- I initially said content because of SimpleContentViewHandler

[jira] [Commented] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-10-30 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982482#comment-14982482 ] Gareth Carter commented on OFBIZ-6702: -- general.properties it is then > Upd

[jira] [Created] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2015-10-29 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-6705: Summary: some files set viewIndex to 1 by default rather than 0 Key: OFBIZ-6705 URL: https://issues.apache.org/jira/browse/OFBIZ-6705 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2015-10-29 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6705: - Description: The following files set viewIndex to 1 {noformat} ./applications/order/src/org

[jira] [Commented] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-10-29 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980182#comment-14980182 ] Gareth Carter commented on OFBIZ-6702: -- The inline change is not super important. I just felt

[jira] [Updated] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-10-28 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6702: - Attachment: UtilHttp.java.patch SimpleContentViewHandler.java.patch > Upd

[jira] [Created] (OFBIZ-6702) Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition

2015-10-28 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-6702: Summary: Update SimpleContentViewHandler to return mime type on file extension and use inline for content-disposition Key: OFBIZ-6702 URL: https://issues.apache.org/jira/browse

[jira] [Updated] (OFBIZ-6697) CommunicationServices.createAttachmentContent duplicates attachments for existing CommunicationEvents

2015-10-23 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6697: - Attachment: FixDuplicateCommEventAttachments.patch

[jira] [Commented] (OFBIZ-6698) sendCommEventAsEmail does not filter CommEventContentAssoc

2015-10-23 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970699#comment-14970699 ] Gareth Carter commented on OFBIZ-6698: -- Would it be worth changing to use EntityQuery rather than

[jira] [Commented] (OFBIZ-6664) Enhance theme js and css settings with caching and other parameters.

2015-10-08 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948677#comment-14948677 ] Gareth Carter commented on OFBIZ-6664: -- What about combining and minifying css/js used for all

[jira] [Commented] (OFBIZ-6621) MapContext.entrySet() slows down when ByteBuffer objects are in the context

2015-09-18 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14838431#comment-14838431 ] Gareth Carter commented on OFBIZ-6621: -- Also, we have deployed this to our live servers as our users

[jira] [Updated] (OFBIZ-6621) MapContext.entrySet() slows down when ByteBuffer objects are in the context

2015-09-18 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6621: - Attachment: MapContext-v2.patch New patch with ListSet as private inner class

[jira] [Created] (OFBIZ-6621) MapContext.entrySet() slows down when ByteBuffer objects are in the context

2015-09-16 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-6621: Summary: MapContext.entrySet() slows down when ByteBuffer objects are in the context Key: OFBIZ-6621 URL: https://issues.apache.org/jira/browse/OFBIZ-6621 Project

[jira] [Updated] (OFBIZ-6621) MapContext.entrySet() slows down when ByteBuffer objects are in the context

2015-09-16 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6621: - Attachment: MapContext.patch Patch uses a Set backed by a List instead. Currently testing

[jira] [Commented] (OFBIZ-6621) MapContext.entrySet() slows down when ByteBuffer objects are in the context

2015-09-16 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790556#comment-14790556 ] Gareth Carter commented on OFBIZ-6621: -- I wouldn't be against this idea but there are 2 source files

[jira] [Updated] (OFBIZ-6619) PurgeJob.java does not delete RecurrenceRule because it is still referenced by RecurrenceInfo

2015-09-14 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6619: - Summary: PurgeJob.java does not delete RecurrenceRule because it is still referenced

[jira] [Updated] (OFBIZ-6619) PurgeJob.java does not delete RecurrenceRule because it is still referenced RecurrenceInfo

2015-09-14 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6619: - Attachment: PurgeJob.patch > PurgeJob.java does not delete RecurrenceRule because it is st

[jira] [Created] (OFBIZ-6619) PurgeJob.java does not delete RecurrenceRule because it is still referenced RecurrenceInfo

2015-09-14 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-6619: Summary: PurgeJob.java does not delete RecurrenceRule because it is still referenced RecurrenceInfo Key: OFBIZ-6619 URL: https://issues.apache.org/jira/browse/OFBIZ-6619

[jira] [Commented] (OFBIZ-6567) Wrong percent encoding in Webtool/SQL Processor

2015-08-03 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652538#comment-14652538 ] Gareth Carter commented on OFBIZ-6567: -- I was looking for that link. I completely

[jira] [Commented] (OFBIZ-6567) Wrong percent encoding in Webtool/SQL Processor

2015-07-31 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648995#comment-14648995 ] Gareth Carter commented on OFBIZ-6567: -- I dislike modifying UtilCodec in this way

[jira] [Comment Edited] (OFBIZ-6567) Wrong percent encoding in Webtool/SQL Processor

2015-07-31 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648995#comment-14648995 ] Gareth Carter edited comment on OFBIZ-6567 at 7/31/15 9:56 AM

[jira] [Commented] (OFBIZ-6504) how to Create PDF with password Protected in Ofbiz

2015-07-29 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14646241#comment-14646241 ] Gareth Carter commented on OFBIZ-6504: -- MacroFormRenderer is creating adhoc

[jira] [Commented] (OFBIZ-6504) how to Create PDF with password Protected in Ofbiz

2015-07-29 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645666#comment-14645666 ] Gareth Carter commented on OFBIZ-6504: -- Seems to me like you have to escape special

[jira] [Created] (OFBIZ-6537) Unable to change users timezone for session

2015-06-26 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-6537: Summary: Unable to change users timezone for session Key: OFBIZ-6537 URL: https://issues.apache.org/jira/browse/OFBIZ-6537 Project: OFBiz Issue Type: Bug

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-26 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602628#comment-14602628 ] Gareth Carter commented on OFBIZ-5608: -- Can't test due to https://issues.apache.org

[jira] [Created] (OFBIZ-6536) The Create new link under partymgr has disappeared

2015-06-26 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-6536: Summary: The Create new link under partymgr has disappeared Key: OFBIZ-6536 URL: https://issues.apache.org/jira/browse/OFBIZ-6536 Project: OFBiz Issue Type

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-25 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600990#comment-14600990 ] Gareth Carter commented on OFBIZ-5608: -- I do not know if it does rounding

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-25 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600994#comment-14600994 ] Gareth Carter commented on OFBIZ-5608: -- It looks fine. I have concerns though about

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-25 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601429#comment-14601429 ] Gareth Carter commented on OFBIZ-5608: -- I will confirm and get back to you

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-24 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600235#comment-14600235 ] Gareth Carter commented on OFBIZ-5608: -- Forgot to mention, I have observed

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-24 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600241#comment-14600241 ] Gareth Carter commented on OFBIZ-5608: -- I believe it would have to be systems

  1   2   >