Re: [ofbiz-framework] branch trunk updated: Improved: no functional change, labels improvements

2022-02-03 Thread Michael Brohl
ichael, Jacques Le 02/02/2022 à 23:33, Michael Brohl a écrit : If I see it right, he has corrected wrong indentations. Nothing wrong with that... Michael Am 02.02.22 um 18:00 schrieb Pierre Smits: Hi Jacques, With this commit 8a9596be849f6709cb17c24a598c4862e8df867c you deleted and reinserted

Re: [ofbiz-framework] branch trunk updated: Improved: no functional change, labels improvements

2022-02-02 Thread Michael Brohl
If I see it right, he has corrected wrong indentations. Nothing wrong with that... Michael Am 02.02.22 um 18:00 schrieb Pierre Smits: Hi Jacques, With this commit 8a9596be849f6709cb17c24a598c4862e8df867c you deleted and reinserted a lot of german translations (without any changes in the tran

Re: Guideline translation definition and the application there of in service functions and widget element, o.a.

2022-02-01 Thread Michael Brohl
Pierre, this will be my last response to this thread to clear some points and let the interested readers draw their own conclusions. See my responses inline. Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 30.01.22 um 18:32 schrieb Pierre Smits: Thanks Michael, for your opinion

Re: [ofbiz-framework] branch trunk updated: Improved: Recruitment screens updated to use Grid rather than list forms (OFBIZ-11345)

2022-01-31 Thread Michael Brohl
ntial benefit of already existing generic translations from the common label set. Of course there will be exceptions to every rule, but in this case I thought the changes appropriate and an improvement. Thanks, Dan. On Fri, 28 Jan 2022 at 14:38, Michael Brohl wrote: Hi Dan, is this c

Re: Guideline translation definition and the application there of in service functions and widget element, o.a.

2022-01-30 Thread Michael Brohl
guidelines, should not be merged to the codebase. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de [1] https://cwiki.apache.org/confluence/display/OFBIZ/Internationalization?src=contextnavchildmode [2] https://issues.apache.org/jira/browse/OFBIZ-10772 (and subtasks) [3] https

Re: [ofbiz-framework] branch trunk updated: Improved: Recruitment screens updated to use Grid rather than list forms (OFBIZ-11345)

2022-01-28 Thread Michael Brohl
Hi Dan, is this commit intentional? It still has unwanted changes introducing titles with common labels instead of specific labels (e.g. CommonLocation for jobLocation). Regards, Michael Am 28.01.22 um 08:49 schrieb danwatf...@apache.org: This is an automated email from the ASF dual-hoste

Re: IDEA plugin for OFBiz

2022-01-24 Thread Michael Brohl
e what others in the community think about it. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 24.01.22 um 17:24 schrieb Michael Brohl: Hi Gaetan, great effort! I'll respond in more detail this evening, sounds like this warrants it's own OFBiz repository. For the forma

Re: IDEA plugin for OFBiz

2022-01-24 Thread Michael Brohl
Hi Gaetan, great effort! I'll respond in more detail this evening, sounds like this warrants it's own OFBiz repository. For the formal details, I think Jacopo also might have some insights. Best regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 24.01.22 um 17:07 schr

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.09

2022-01-11 Thread Michael Brohl
processing files for release apache-ofbiz-17.12.09 Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 10.01.22 um 18:56 schrieb Jacopo Cappellato: This is the vote thread to release a new bug fix release for the release17.12 branch. This new release, "Apache OFBiz 17.12.09" supe

Re: OFBiz releases EOL (End Of Life) announcement [was Re: [ofbiz-site] branch master updated: More information about security and EOL (End Of Life)]

2022-01-04 Thread Michael Brohl
7;s a discussion for past-22.x Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 04.01.22 um 16:04 schrieb Jacques Le Roux: Hi All, I'd like to discuss about OFBiz releases EOL (End Of Life) announcement. For instance R17.12 is EOL with 17.12.08. I suggest to make it clear o

Re: [apache/ofbiz-framework] Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498) (PR #355)

2022-01-03 Thread Michael Brohl
://directory.apache.org>, PMC Member* On Mon, Jan 3, 2022 at 9:06 AM Michael Brohl wrote: Hi @gilPts <https://github.com/gilPts> , we already have such a centralized configuration mechanism in production for several years now. Maybe we should share this and let him check if it fits the nee

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-02 Thread Michael Brohl
for release apache-ofbiz-18.12.05 Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 02.01.22 um 12:29 schrieb Jacopo Cappellato: This is the second vote thread to release a new bug fix release for the release18.12 branch. This new release, "Apache OFBiz 18.12.05" supersed

Re: [ofbiz-framework] branch trunk updated: Improved: Migrate Ofbiz bb 0.8 config to 3.2 (OFBIZ-12456)

2021-12-29 Thread Michael Brohl
Jacques, you still commit those changes. We now have lots of those dummy commits (> 20!) in the codebase. Is there no way of testing buildbot without cluttering the history so much? That looks really bad. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 27.12.21 um 15:53 schr

Re: [ofbiz-framework] branch trunk updated: Improved: Migrate Ofbiz bb 0.8 config to 3.2 (OFBIZ-12456)

2021-12-27 Thread Michael Brohl
Hi Jacques, do we really need those dummy changes to test buildbot? Is there no mechanism to manually start a build? It seems a bit odd to read those changes in the project history. Thanks, Michael Am 27.12.21 um 14:42 schrieb jler...@apache.org: This is an automated email from the ASF du

Re: OFBiz re-architecture thoughts

2021-12-27 Thread Michael Brohl
uld become unreadable soon with more participants. Also writing up the outcome of the discussions and the further roadmap in the wiki might help. Let's see how it works. Michael Brohl ecomify GmbH - www.ecomify.de Am 22.12.21 um 18:23 schrieb Taher Alkhateeb: Problems ... _1. Lack of Cod

Re: Add CHANGELOG.md file

2021-12-21 Thread Michael Brohl
I think we'll need a process to fill it, the file alone will obviously not be sufficient. Michael Am 21.12.21 um 11:46 schrieb Jacques Le Roux: Hi All, OK we have a CHANGELOG file now for 10 months, but nothing in it, so? Jacques Le 19/06/2020 à 12:19, Deepak Dixit a écrit : Here is the l

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.04 (third attempt)

2021-12-19 Thread Michael Brohl
-wrapper.properties: OK gradlew: OK Running tests... Starting a Gradle Daemon (subsequent builds will be faster) ... BUILD SUCCESSFUL in 4m 43s 27 actionable tasks: 22 executed, 5 up-to-date Done processing files for release apache-ofbiz-18.12.04 === Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.04

2021-12-18 Thread Michael Brohl
: OK gradlew: OK Running tests... ... BUILD SUCCESSFUL in 4m 59s 27 actionable tasks: 22 executed, 5 up-to-date Done processing files for release apache-ofbiz-18.12.04 Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 17.12.21 um 10:32 schrieb Jacopo Cappellato: This is the vote thread to

Re: [ofbiz-framework] branch release18.12 updated: Improved: Apache Log4j2 (OFBIZ-12449)

2021-12-16 Thread Michael Brohl
+1 Thanks, Michael Am 16.12.21 um 17:58 schrieb Jacques Le Roux: Hi Jacopo, +1, with now also Solr and Lucene Jacques Le 16/12/2021 à 17:13, Jacopo Cappellato a écrit : I think it would be a good idea to prepare a new release with this change. WDYT? Jacopo On Tue, Dec 14, 2021 at 12:30

Re: lib/README file and .DS_Store in .gitignore

2021-12-16 Thread Michael Brohl
Thanks Jacques! Michael Am 16.12.21 um 08:11 schrieb Jacques Le Roux: Thanks Michael, I add a doubt, fixed Jacques Le 15/12/2021 à 20:43, Michael Brohl a écrit : Hi Jacques, thanks for bringing this up. The lib dir is a mechanism which allows users to use and load external libs which

Re: lib/README file and .DS_Store in .gitignore

2021-12-15 Thread Michael Brohl
Hi Jacques, thanks for bringing this up. The lib dir is a mechanism which allows users to use and load external libs which can not (or should not) be loaded from external repositories through the Gradle mechanism. It is used in build.gradle at the end of the dependencies section. We do not

Re: [ANNOUNCE] Apache OFBiz 18.12.02 released

2021-11-25 Thread Michael Brohl
Thanks, Jacopo! Michael > Am 24.11.2021 um 11:49 schrieb Jacopo Cappellato : > > The Apache OFBiz community is pleased to announce the new release "Apache > OFBiz 18.12.02". > > Apache OFBiz® is an open source product for the automation of enterprise > processes that includes framework compone

Re: Freeze branch release21

2021-11-24 Thread Michael Brohl
I am also in favor of a 22.01. branch and releasing a first stable version during the year 2022. Let's wait those few weeks an be up-to-date with the release name. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 22.11.21 um 12:44 schrieb Jacques Le Roux: Hi, I agree Pierre, l

Re: [Conclusion] PartyRole usage in OFBiz

2021-11-20 Thread Michael Brohl
+1 Thanks Scott, Michael Am 20.11.21 um 02:47 schrieb Scott Gray: (Removing the private list since the discussion has no place there) I don't think this topic needs any further debate at this stage. Pierre objects to having the tickets closed, so we can leave them open since that is the eas

Re: [VOTE] Apache OFBiz 18.12.02 (second attempt)

2021-11-17 Thread Michael Brohl
[ultimate] ... Initializing Gradle wrapper... ... Running tests... ... BUILD SUCCESSFUL in 4m 40s 27 actionable tasks: 22 executed, 5 up-to-date Done processing files for release apache-ofbiz-18.12.02 Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 16.11.21 um 17:26 schrieb Jacopo

Re: PartyRole usage in OFBiz

2021-11-12 Thread Michael Brohl
Hi Gil, thanks for the summary and links to previous discussions and issues. In my opinion, the conclusion is still valid and I agree to close the pending issues as "Won't do". Thanks and best regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 12.11.21 um 10

Validating a release with verify-ofbiz-release.sh was: [VOTE] Apache OFBiz 18.12.02

2021-11-03 Thread Michael Brohl
Best regards, Michael Brohl ecomify GmbH - www.ecomify.de [1] https://gitbox.apache.org/repos/asf/ofbiz-tools.git Am 03.11.21 um 15:03 schrieb Giulio Speri - MpStyle Srl: Hi everyone, I have to revert my previous +1 (I just tested the checksums, not the build and I apologize for that), sinc

Re: [VOTE] Apache OFBiz 18.12.02

2021-11-03 Thread Michael Brohl
-1 I agree with Wiebke: it seems that the reason for the new release was not backported to the release branch. I also recommend to have a look at Wiebke's PR [1] as a permanent fix for the problem. Best regards, Michael Brohl ecomify GmbH - www.ecomify.de [1] https://github.com/a

Rework OFBiz Committers Roles and Responsibilities

2021-11-02 Thread Michael Brohl
Hi team, the Confluence page [1] contains a lot of references to the long outdated use of SVN. I think it's time to get rid of those references and put in the Git / GitHub informations. What do you think? Best regards, Michael Brohl ecomify GmbH - www.ecomify.de [1]

Re: Release 18.12.02

2021-11-01 Thread Michael Brohl
+1 Thanks, Michael Am 01.11.21 um 09:15 schrieb Jacques Le Roux: Hi, Because of OFBIZ-12351 "Builds fail due to unauthorized access to repo.spring.io/plugins-release" I think we should release 18.12.02. The reasons is, even if it's not our fault, not everybody like Mart Naum will report o

Re: [VOTE] Apache OFBiz 18.12.01

2021-10-23 Thread Michael Brohl
[ultimate] Unpacking release file archive $ZIP... ... Initializing Gradle wrapper... ... Running tests... BUILD SUCCESSFUL in 6m 14s 27 actionable tasks: 22 executed, 5 up-to-date Done processing files for release apache-ofbiz-18.12.01 Thanks and regards, Michael Brohl ecomify GmbH - www.

Re: [DISCUSSION] Do we start the R18 publish process ?

2021-10-15 Thread Michael Brohl
reproduce the problem and I would say it is solved. It's just a bit confusing that now you have at least one remaining problem. But given the Gradle statement you mentioned, we should be good to go. Thanks for checking and best regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 15.10.

Re: [DISCUSSION] Do we start the R18 publish process ?

2021-10-12 Thread Michael Brohl
Hi Nicolas, all, I just checked the jcenter problem [1] and it still remains when you deactivate access to jcenter.bintray.com as shown in [2] and clean the gradle cache. According to [1], we'll have to upgrade Gradle itself for the branch. Best regards, Michael Brohl ecomify

Re: [DISCUSSION] Do we start the R18 publish process ?

2021-10-07 Thread Michael Brohl
om my part I didn't see any issue but sure I missed something Concerning the DiskFileItem, I tried to work on it, but without success to spot the problem. If you have some time to work on it together by VC it would be a pleasure ! Nicolas On 28/09/2021 18:29, Michael Brohl wrote: Hi Nicolas

Re: Reserved words

2021-10-07 Thread Michael Brohl
Correcting myself: only DATABASE is a reserved name in MySQL, the other two are keywords. Michael Brohl ecomify GmbH - www.ecomify.de Am 07.10.21 um 17:28 schrieb Michael Brohl: Hi Pierre, those words are reserved names in different databases, please check yourself: https

Re: Reserved words

2021-10-07 Thread Michael Brohl
database. For MySQL, all three words are reserved. Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 07.10.21 um 11:06 schrieb Pierre Smits: Hi all, While working on a solution that involves bringing existing tables from a postgresql database into the entity group and model

Re: [DISCUSSION] Do we start the R18 publish process ?

2021-09-28 Thread Michael Brohl
Hi Nicolas, there a issues which I think should be fixed before an 18.12 release, for example the JCenter migration problem [1] or the DiskFileItem topic [2]. There are many more bugs also which I didn't check. Regards, Michael [1] https://issues.apache.org/jira/browse/OFBIZ-12171 [2] htt

Re: [VOTE] Apache OFBiz 17.12.08

2021-08-08 Thread Michael Brohl
8 executed, 4 up-to-date Done processing files for release apache-ofbiz-17.12.08 Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 02.08.21 um 11:22 schrieb Jacopo Cappellato: This is the vote thread to release a new bug fix release for the release17.12 branch. This new release, &qu

Re: how to add repository for plugin dependency? how to plugins using private repositories?

2021-06-22 Thread Michael Brohl
Hi Stan, I think this should be a change/mod in your custom repository. We should not add custom dependencies to the build file which are not used by the project itself. Best regards, Michael Am 22.06.21 um 10:58 schrieb Eugen Stan: Hello Jacques, I've created an issue and a PR for this

Re: GitHub/GitBox synch problems?

2021-06-22 Thread Michael Brohl
It also seems that the commits from GitBox do not get synched to GitHub (see latest commit from Jacques). Am 21.06.21 um 12:23 schrieb Michael Brohl: Hi devs, I have merged https://github.com/apache/ofbiz-framework/pull/303 this morning and until now, the commit does not appear in the git

GitHub/GitBox synch problems?

2021-06-21 Thread Michael Brohl
Hi devs, I have merged https://github.com/apache/ofbiz-framework/pull/303 this morning and until now, the commit does not appear in the git log and there was also no commit notification in the mailing list. Are you aware of any problems with the synchronization? Thanks Michael Brohl

Re: Improve rainbowstone theme

2021-05-15 Thread Michael Brohl
Hi Nicolas, great work, thanks for sharing! I'd vote for a new theme in case of users relying on the rainbowstone theme as it is now. Thanks, Michael Am 14.05.21 um 16:55 schrieb Nicolas Malin: Hi all, A small update to keep you informed on our progress on the reorganization of the scree

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.07 - second attempt

2021-04-18 Thread Michael Brohl
+1 ~/Projects/apache-ofbiz/dist  ../ofbiz-tools/verify-ofbiz-release.sh -a  apache-ofbiz-17.12.07 shows everything is OK, the build also passes at the first attempt. Thanks, Michael Am 17.04.21 um 11:29 schrieb Jacopo Cappellato: This is the second vote thread to release a new bug fix re

Re: [ofbiz-framework] branch release17.12 updated: Improved: Replace Bintray by a new place to upload the Gradle Wrapper (OFBIZ-12192)

2021-04-12 Thread Michael Brohl
#x27;t see the necessity. Please do as you please. Thanks, Michael Am 12.04.21 um 11:43 schrieb Jacques Le Roux: Hi Michael, Le 11/04/2021 à 23:01, Michael Brohl a écrit : As a user, I would find it annoying if the files would be deleted just because I have not the right tools installed on t

Re: [ofbiz-framework] branch release17.12 updated: Improved: Replace Bintray by a new place to upload the Gradle Wrapper (OFBIZ-12192)

2021-04-11 Thread Michael Brohl
aded file could be dangerous and should be deleted (disclaimer: I did not check if it's done,  just reported Vladimir's concern) My 2cts Le 11/04/2021 à 15:31, Michael Brohl a écrit : Hi Jacques, why should we change the checksum algorithm now, for this release? I would leave it as

Re: [ofbiz-framework] branch release17.12 updated: Improved: Replace Bintray by a new place to upload the Gradle Wrapper (OFBIZ-12192)

2021-04-11 Thread Michael Brohl
states that when shasum is missing. I see no problem with that. Best regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 10.04.21 um 14:16 schrieb jler...@apache.org: Hi, I think we should at least discuss the 2 points below before releasing 17.12.07 Thanks Jacques Le 10/04/2021 à

Re: Comment out the SOAP and HTTP engines?

2021-03-25 Thread Michael Brohl
+1 Michael > Am 25.03.2021 um 18:35 schrieb Jacques Le Roux : > > Hi, > > After the recent fix for the CVE-2021-26295[1] we discussed with the security > team about the opportunity need to comment out the SOAP and HTTP engines > like we did in the past for RMI[2], this obviously for securit

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-15 Thread Michael Brohl
+1 I've checked again while testing the verify script and this time all tests pass on the 1st attempt. Thanks, Michael Am 14.03.21 um 10:39 schrieb Jacopo Cappellato: This is the vote thread (second attempt) to release a new bug fix release for the release17.12 branch. This new release, "A

Enhanced OFBiz release verification script

2021-03-14 Thread Michael Brohl
like ./verify-ofbiz-release.sh -a apache-ofbiz-17.12.06  2>&1 | tee verify.log This is tested on Mac OS, hope this works on other Linux systems and hopefully on terminal emulations on Windows accordingly. Hope this is helpful. Any feedback or improvement is welcome. Regards, Michae

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-14 Thread Michael Brohl
dle/wrapper/gradle-wrapper.jar: OK gradle/wrapper/gradle-wrapper.properties: OK gradlew: OK ./gradlew cleanAll loadAll testIntegration ... first pass failes 2nd pass worked. Thanks, Michael Am 14.03.21 um 12:19 schrieb Jacopo Cappellato: weird, I didn't notice the errors and all test

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-14 Thread Michael Brohl
-1 Unfortunately I get several Freemarker errors during ./gradlew cleanAll loadAll testIntegration like this 2021-03-14 11:34:49,334 |main |ServiceDispatcher |T| Sync service [test-dispatcher-R437fRXV8X/getPartyEmail] finished in [2] milliseconds 2021-03-14 11:34:49,336 |main |F

Re: Welcome to Priya Sharma as new committer!

2021-03-11 Thread Michael Brohl
Congratulations and welcome aboard, Priya! Happy committing, Michael Am 11.03.21 um 14:01 schrieb Pawan Verma: The OFBiz PMC has invited Priya to become a new committer and we are pleased to announce that she has accepted the nomination. Welcome onboard Priya, more power to you! Pawan

Re: JFrog to shut down jcenter

2021-03-10 Thread Michael Brohl
ct to jcenter.bintray.com:443 [jcenter.bintray.com/127.0.0.1] failed: Connection refused (Connection refused) * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://h

Re: JFrog to shut down jcenter

2021-03-10 Thread Michael Brohl
I have reopened https://issues.apache.org/jira/browse/OFBIZ-12171 for necessary changes in the documentation (README.adoc) which references JCenter. Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 22.02.21 um 17:47 schrieb Michael Brohl: Hi everyone, please help testing the

Re: [SECURITY] Dependency Confusion

2021-02-22 Thread Michael Brohl
Hi Jacques, all, we should try to publish the Gradle Wrapper to Maven Central, right? Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 22.02.21 um 14:08 schrieb Jacques Le Roux: Hi, I created https://issues.apache.org/jira/browse/OFBIZ-12186 for that. It's much more simple t

Re: JFrog to shut down jcenter

2021-02-22 Thread Michael Brohl
objections, I will merge the pull requests for all branches coming weekend (after Friday, 26. February). Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 19.02.21 um 10:42 schrieb Jacques Le Roux: +1, works for me Jacques Le 18/02/2021 à 22:18, Michael Brohl a écrit : I think I have

Re: [OFBIZ-12181] I suggest to enlarge the "more-app" menu in Rainbow Stome theme

2021-02-21 Thread Michael Brohl
+1 Thanks, Michael > Am 21.02.2021 um 14:16 schrieb Jacques Le Roux : > > Done for trunk, if nobody oppose I'll backport to R18 in 3 days > >> Le 19/02/2021 à 11:21, Jacques Le Roux a écrit : >> I even propose to backport, at least to R18... >> >>> Le 18/02/2021 à 17:13, Jacques Le Roux

Re: JFrog to shut down jcenter

2021-02-18 Thread Michael Brohl
or ideas for optimization, thanks! See pull requests https://github.com/apache/ofbiz-plugins/pull/59 https://github.com/apache/ofbiz-framework/pull/278 Michael Brohl ecomify GmbH - www.ecomify.de Am 18.02.21 um 17:53 schrieb Michael Brohl: Hi Nicolas, not yet. I'll provide a pull re

Re: GString to String

2021-02-18 Thread Michael Brohl
Ok, +1 from my side then. Thanks Jacques and Nicolas, Michael Brohl ecomify GmbH - www.ecomify.de Am 18.02.21 um 22:07 schrieb Jacques Le Roux: There is none, because, as shown in the log below    <org.codehaus.groovy.runtime.GStringImpl to String, returning object.toString(). >>

Re: JFrog to shut down jcenter

2021-02-18 Thread Michael Brohl
Hi Nicolas, not yet. I'll provide a pull request with the latest changes soon. Thanks, Michael Am 17.02.21 um 17:27 schrieb Nicolas Malin: Michael, Do you have a patch or git branch to be sure that can reproduce the same state from my part ? Nicolas On 16/02/2021 23:49, Michael

Re: GString to String

2021-02-18 Thread Michael Brohl
What impact does this change have? Thanks, Michael Am 18.02.21 um 17:33 schrieb Jacques Le Roux: Thanks Nicolas, Since nobody seems against I'll do so with https://issues.apache.org/jira/browse/OFBIZ-12182 Jacques Le 15/02/2021 à 18:33, Nicolas Malin a écrit : I'm agree Jacques with tha

Re: JFrog to shut down jcenter

2021-02-16 Thread Michael Brohl
://www.jfrog.com/jira/browse/RTFACT-24621 causing compile errors because UOUtils cannot be found. I'm at it but it won't go as fast as I'd wish it would. Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 16.02.21 um 11:26 schrieb Jacques Le Roux: Done Le 16/02/2021 à 10:33,

Re: JFrog to shut down jcenter

2021-02-16 Thread Michael Brohl
set the fixed version because it is missing. I assigned the release branch instead and would change that when we have the version. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 16.02.21 um 09:17 schrieb Jacques Le Roux: Hi, I'd say that 17.12.06 is a bit apart. It's most

Re: JFrog to shut down jcenter

2021-02-15 Thread Michael Brohl
Hi Michel, > > Thanks for your works, I will check If I found a solution with Gradle > 3.2.1. I keep in my that a solution would be increase the Gradle > version for the 17.12 > > Nicolas > >> On 14/02/2021 16:51, Michael Brohl wrote: >> For those who

Re: buildbot exception in on ofbizBranch18Framework

2021-02-15 Thread Michael Brohl
... fixed. Michael Am 15.02.21 um 18:38 schrieb Michael Brohl: checking... Michael Am 15.02.21 um 18:26 schrieb build...@apache.org: The Buildbot has detected a build exception on builder ofbizBranch18Framework while building ofbiz-framework. Full details are available at: https

Re: buildbot exception in on ofbizBranch18Framework

2021-02-15 Thread Michael Brohl
checking... Michael Am 15.02.21 um 18:26 schrieb build...@apache.org: The Buildbot has detected a build exception on builder ofbizBranch18Framework while building ofbiz-framework. Full details are available at: https://ci.apache.org/builders/ofbizBranch18Framework/builds/450 Buildbot UR

Re: JFrog to shut down jcenter

2021-02-14 Thread Michael Brohl
I was used for trunk and r18.12. Or does someone know a way to pull artefacts/jars from a repository without a valid pom in Gradle 3.2.1? Any help is appreciated, thanks! Michael Brohl ecomify GmbH - www.ecomify.de Am 10.02.21 um 16:44 schrieb Michael Brohl: Ah, yes, thanks

Re: Checkstyle and Openrewrite or/and Spotless

2021-02-13 Thread Michael Brohl
from learning. If you are being forced to manually change the code after checkstyle has found an error during build, you'll learn on the way. So better use the project formatter settings for the IDE and let people deal with checkstyle errors during their implementation. My 2 cts, Mic

Re: FYI: 18.12.01 release and more

2021-02-11 Thread Michael Brohl
pick up some work to get finished for the release. Every bit helps. Thanks and regards, Michael Brohl ecomify GmbH - www.ecomify.de [1] https://issues.apache.org/jira/browse/OFBIZ-12173?jql=project%20%3D%20OFBIZ%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened%2C%20%22Patch

Re: FYI: 18.12.01 release and more

2021-02-11 Thread Michael Brohl
please report the issues in the corresponding Jira for the jCenter handling here: https://issues.apache.org/jira/browse/OFBIZ-12171 I will work on making the tests pass. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 11.02.21 um 10:44 schrieb Jacques Le Roux: Le 11/02/2021 à 10:13

Re: UPDATE, was:Re: JFrog to shut down jcenter

2021-02-10 Thread Michael Brohl
+bintray Will no longer be available Jacques Le 10/02/2021 à 11:17, Michael Brohl a écrit : jFrog announced in an update that jCenter is going to serve artefacts until February 1st 2022, see https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ Regards, Michael

Re: UPDATE, was:Re: JFrog to shut down jcenter

2021-02-10 Thread Michael Brohl
Yes, this will cease soon. I think we'll have to move to mavenCentral with this. There is documentation about the process here: https://maven.apache.org/repository/guide-central-repository-upload.html Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 10.02.21 um 16:24 sc

Re: JFrog to shut down jcenter

2021-02-10 Thread Michael Brohl
Ah, yes, thanks Jacques. See https://issues.apache.org/jira/browse/OFBIZ-12171 for the issue and links to the pull requests. Thanks, Michael Am 10.02.21 um 16:22 schrieb Jacques Le Roux: Le 10/02/2021 à 11:06, Michael Brohl a écrit : I think I've got it solved for trunk, please see

UPDATE, was:Re: JFrog to shut down jcenter

2021-02-10 Thread Michael Brohl
jFrog announced in an update that jCenter is going to serve artefacts until February 1st 2022, see https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 05.02.21 um 22:04 schrieb Taher Alkhateeb: Hello

Re: JFrog to shut down jcenter

2021-02-10 Thread Michael Brohl
o set up a wiki page to describe the problem and provide informations for the different releases. The mentioned patch could go there too. Thoughts? Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 06.02.21 um 13:52 schrieb Jacques Le Roux: That's a good news, thanks Michael Let&

Re: JFrog to shut down jcenter

2021-02-06 Thread Michael Brohl
more information and make a plan when we have more insight of the real impact (technically). Best regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 06.02.21 um 12:01 schrieb Taher Alkhateeb: Hi Folks. I need to stress something very important here. The problem is not at all future ver

Re: JFrog to shut down jcenter

2021-02-06 Thread Michael Brohl
Infra is also at it, see https://issues.apache.org/jira/browse/INFRA-21376 Michael Brohl ecomify GmbH - www.ecomify.de Am 06.02.21 um 11:29 schrieb Michael Brohl: Hi Taher, thanks for bringing this up! This is indeed something we should care about quite soon. It will affect the upcoming

Re: JFrog to shut down jcenter

2021-02-06 Thread Michael Brohl
libraries which might not be maintained actively. Will think about how to handle this and come back here. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de [1] https://issues.apache.org/jira/browse/OFBIZ-12171 PS: great to hear from you again, it's been a while, Taher. Am 05.02.21 um

Re: Checkstyle pre-push hook not used when merging PR's

2021-02-05 Thread Michael Brohl
Ah, thanks Jacques. I have just added a new subtask to the checkstyle Jira to fix more errors: https://issues.apache.org/jira/browse/OFBIZ-12169 Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 05.02.21 um 12:33 schrieb Jacques Le Roux: No worries, yes it's there

Re: Checkstyle pre-push hook not used when merging PR's

2021-02-05 Thread Michael Brohl
taking care, Michael Brohl ecomify GmbH - www.ecomify.de Am 05.02.21 um 11:15 schrieb Jacques Le Roux: OK, I need it right now, so I'm taking care of it, not a big deal anyway Le 05/02/2021 à 09:57, Jacques Le Roux a écrit : Hi Michael, It's better but we have still a small issue. The

Re: Checkstyle pre-push hook not used when merging PR's

2021-02-04 Thread Michael Brohl
possible to specify folder groups or packages to check separately so that the framework build could check against one counter for the framework code and another counter for the plugins code? Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 04.02.21 um 13:00 schrieb Aditya Sharma: Hi

Re: Checkstyle pre-push hook not used when merging PR's

2021-02-04 Thread Michael Brohl
repository and closes the gap. I will create a Jira issue for this. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 04.02.21 um 11:42 schrieb Girish Vasmatkar: Hi Michael/Jacques +1 for the proposal. However, I do not face this issue on my local, partly because I never tried to push to the

Re: Checkstyle pre-push hook not used when merging PR's

2021-02-03 Thread Michael Brohl
I just found that the error count in my local repository was higher because of integrated plugins so it seems the codebase is clean. To my understanding, the described gap with the missing hooks on local repositories still exists. Michael Am 03.02.21 um 17:59 schrieb Michael Brohl: Hi all

Checkstyle pre-push hook not used when merging PR's

2021-02-03 Thread Michael Brohl
l repository. What do you think? Regards, Michael Brohl ecomify GmbH - www.ecomify.de

Re: [OPTIONS] Java 11 and Java JDK origin

2021-02-03 Thread Michael Brohl
until September and gain one more year of support. What do you think? Michael Brohl ecomify GmbH - www.ecomify.de Am 19.04.19 um 23:09 schrieb Jacques Le Roux: Ah OK Le 19/04/2019 à 21:16, Taher Alkhateeb a écrit : It's already done. I'm suggesting future actions for future JDKs

Re: Welcome Girish Vasmatkar as new PMC member

2021-02-01 Thread Michael Brohl
Congratualations and welcome aboard, Girish! Michael Am 28.01.21 um 17:38 schrieb Jacques Le Roux: The OFBiz PMC has invited Girish Vasmatkar to become member of the committee and we are glad to announce he has accepted the nomination. On behalf of the OFBiz PMC, welcome Girish!

Re: Welcome Akash Jain as new PMC member

2021-02-01 Thread Michael Brohl
Congratualations and welcome aboard, Akash! Michael Am 28.01.21 um 17:38 schrieb Jacques Le Roux: The OFBiz PMC has invited Akash Jain to become member of the committee and we are glad to announce he has accepted the nomination. On behalf of the OFBiz PMC, welcome Akash!

Re: Blacklist and whitelist replacements

2021-02-01 Thread Michael Brohl
y overlooked search-replace routine, to complete this task. And it would be a shame, if we scared of users, just because we were to reluctant to do so. Benjamin Jugl ecomify GmbH - www.ecomify.de <http://www.ecomify.de> Am 30.01.21 um 20:36 schrieb Michael Brohl: Hi Jacques, if not u

Re: Blacklist and whitelist replacements

2021-01-30 Thread Michael Brohl
Hi Jacques, if not used in a context with 'slave', I don't see any problem using the word 'master'. It's word with many different meanings in English and I do not see any sense in changing all occurences per se. Michael Brohl ecomify GmbH - www.ecomify.de

Re: [ofbiz-framework] branch trunk updated: Improved: Updated tasks.checkstyleMain.maxErrors to 278

2021-01-22 Thread Michael Brohl
Hi James, I see. It was not clear from the commit message that you fixed checkstyle errors and then reduced the count. I could have recognized it, though. Thanks, Michael Am 22.01.21 um 04:21 schrieb James Yong: -public class StringUtil { +public final class StringUtil {

Re: [ofbiz-framework] branch trunk updated: Improved: Updated tasks.checkstyleMain.maxErrors to 278

2021-01-21 Thread Michael Brohl
Hi James, the commit contains more changes than mentioned in the  commit message. It would be more transparent to separate those changes in separate commits to make it more clear and easier for reviewers. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 21.01.21 um 14:22 schrieb

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.05 - Second attempt

2021-01-06 Thread Michael Brohl
=== gradle/wrapper/gradle-wrapper.jar: OK gradle/wrapper/gradle-wrapper.properties: OK gradlew: OK ~/Projects/apache-ofbiz/dist/apache-ofbiz-17.12.05  ./gradlew loadAll testIntegration ... BUILD SUCCESSFUL Total time: 7 mins 6.855 secs Thanks, Michael Brohl ecomify GmbH - www.ecomify.de A

Re: Remove JQuery UI from OFBiz website

2021-01-04 Thread Michael Brohl
+1 Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 04.01.21 um 16:02 schrieb Deepak Dixit: Hi Aditya, I don't see any issue in removing jquery ui, It was added at initial commit. If everything works fine we can remove this. Thanks & Regards -- Deepak Dixit ofbiz.apache

Re: Releasing 17.12.05, 18.12.01 and freezing R20

2020-12-21 Thread Michael Brohl
in 2021... What do you think? Also +1 for 3 years support of r17 and 5 years support starting with r18. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 21.12.20 um 10:54 schrieb Jacques Le Roux: Hi Deepak, The reason I propose that is because it's more and more difficult to bac

Re: Change ${...} to [=...] for freemarker template

2020-12-14 Thread Michael Brohl
both ways, leaving it up to the developer to use the [=...] Syntax where necessary? Best regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 12.12.20 um 10:43 schrieb James Yong: Hi all, Currently interpolation syntax used for freemarker template is ${...}. This is the same a

Re: buildbot exception in on ofbizTrunkFramework

2020-12-02 Thread Michael Brohl
swing:batik-all:1.8pre-r1084380' I know from custom projects that the batik package structure has changed from 1.8 to current versions. We changed 222 to runtime 'org.apache.xmlgraphics:batik-all:1.13' and everything worked fine. Best regards, Michael Brohl ecomify GmbH - w

Re: Remove datejs

2020-11-20 Thread Michael Brohl
Are you sure that this is not needed anymore. I have in mind that it is somehow related to the datepicker. Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 19.11.20 um 18:07 schrieb Jacques Le Roux: Hi James, Though I did not find when it was removed, sounds good to me Thanks

Re: [PROPOSAL] Separate login service for API calls

2020-09-29 Thread Michael Brohl
+1 With an addition: we should do the implementation in a way that the user/password matching is implemented only once and used in both login methods (not just copy & paste into another method). It might take some refactoring to pull these part out of the login event. Best regards, Mic

Re: Add border and file name on content rendered from ftl

2020-09-13 Thread Michael Brohl
Hi James, this should be a feature which is configurable *additionally* to the existing rendering in the page source. As a developer, you should be able to deploy in a testing environment where the page displays exactly as it would be in a production environment. Rendered borders/comments sh

Re: [VOTE] to use Lombok inside OFBiz

2020-09-08 Thread Michael Brohl
-1 Thanks, Michael Am 08.09.20 um 09:36 schrieb Jacques Le Roux: Hi, Following our discussions about using Lombok inside OFBiz, as it's not clear if we should, here is a vote to decide about that. The question is: "should we use Lombok inside OFBiz?" Please cast your vote: [+1]    to us

<    1   2   3   4   5   6   7   8   9   10   >