Re: [PROPOSAL] Environment variable configuration

Hi Gil, good feedback, inline ... On Mon, Jul 24, 2017 at 10:17 AM, gil portenseigne <gil.portensei...@nereide.fr> wrote: > Hello Taher, > > My thoughts inline :) > > > On 20/07/2017 09:05, Taher Alkhateeb wrote: >> >> Hello Gil, >> >> Thank yo

Re: Usage of setServiceFields method in ServiceUtil.java file.

Hi Ujjawal, Sorry maybe I lost track, but what are you recommending? On Sat, Jul 22, 2017 at 3:26 PM, Ujjawal Solanki wrote: > Hello all, > I was going through ServiceUtil.java and found that there is a method > called setServiceFields ( whose purpose is to

Re: svn commit: r1802655 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java

Interesting I didn't know that! Makes the code less verbose. If this is safe to use then maybe it's better to adopt it in all the code base On Jul 22, 2017 12:27 PM, "Deepak Dixit" wrote: > Hi Arun, > > I think its not typo, java8 provide type interface for

Re: [Proposal] - Using CommonErrorUiLabels.xml for common UiLabels

+1 DRY is my favorite principle. Sometimes I wish if the keyboard would zap developer fingers when performing a copy-paste :) On Jul 22, 2017 10:33 AM, "Vaibhav Jain" wrote: > Hello Pallavi, > > Yes, we can create error message UI labels in

Re: [Proposal] moving all data in applications to the data-model component

; On Thu, Jul 20, 2017 at 12:15 PM, Taher Alkhateeb < > slidingfilame...@gmail.com> wrote: > >> Thank you all for your feedback and votes. I just counted 12 positive >> votes to go ahead. >> >> I have created a JIRA [1] for this task and I will work on it, but it &

Re: [Proposal] moving all data in applications to the data-model component

t Regards, > Swapnil M Mane > www.hotwaxsystems.com > www.hotwax.co > > On Thu, Jul 20, 2017 at 12:15 PM, Taher Alkhateeb < > slidingfilame...@gmail.com> wrote: > >> Thank you all for your feedback and votes. I just counted 12 positive >> votes to go ahead. >> >>

Re: [PROPOSAL] Environment variable configuration

Hello Gil, Thank you for working on this. I have reviewed the patch and I have a few notes: First for gradle, I don't think you need to fetch environment variables. You can do whatever you want by passing flags, which might be a simpler solution. So you create your own script and modify gradle

Re: [Proposal] moving all data in applications to the data-model component

any volunteers to commit or provide patches are more than welcomed. [1] https://issues.apache.org/jira/browse/OFBIZ-9501 On Tue, Jul 18, 2017 at 6:57 PM, Nicolas Malin <nicolas.ma...@nereide.fr> wrote: > +1 > > > > Le 14/07/2017 à 11:59, Taher Alkhateeb a écrit : >> >

Re: [Discussion] Failing the build if data loading fails

eed to be discussed. > It would be good for instance for a type of exception and a type of file > (service, event, helper/handler/test/etc.) to use and adopt a same type of > exception handling." > > Having patterns would help everybody, when creating, reviewing, refactoring, > e

Re: Restore common-theme with ofbiz-framework

Hi Nicolas, Great stuff, I'm not sure what everyone thinks but I prefer if we can try to get your work incorporated back into the code base as early as possible and to start completing the work from there. On Tue, Jul 18, 2017 at 5:38 PM, Nicolas Malin wrote: >

Re: [Proposal] moving all data in applications to the data-model component

ense to me. > > Would any plugin defining custom entities also have a similar /data tree? > > Cheers > > Paul > > > On 14 July 2017 at 19:59, Taher Alkhateeb <slidingfilame...@gmail.com> > wrote: > >> Hello Everyone, >> >> Data loading i

[Proposal] moving all data in applications to the data-model component

oposal? Does it sound reasonable? Also given the size of what I'm proposing I think we need multiple people to work on this. So is anyone interested in taking part in this initiative? Cheers, Taher Alkhateeb [1] https://issues.apache.org/jira/browse/OFBIZ-9322 [2] https://lists.apache.org/threa

Re: Deadlock on InventoryItem during load test

If there is a JIRA with exact repeat steps then I would be interested in working on this issue as it sounds like a good place to do some proper refactoring on many moving parts. On Wed, Jul 12, 2017 at 12:08 PM, Arun Patidar wrote: > Hello All, > > I was trying to

Re: [Discussion] Failing the build if data loading fails

> I'll refrain to speak about swallowed exceptions ;) > > I still want to continue on OFBIZ-8341 but accepted to get sidetracked in > multi ways :) > > Jacques > > > > Le 10/07/2017 à 21:36, Taher Alkhateeb a écrit : >> >> Fixed it in the JIRA, the EntitySa

Re: [Discussion] Failing the build if data loading fails

17 at 8:14 PM, Taher Alkhateeb <slidingfilame...@gmail.com> wrote: > Quick update, to my surprise an exception is swallowed > dp in the call stack. So getting this > feature might require some intrusive changes. I'm still working on it > and will keep you

Re: [Discussion] Failing the build if data loading fails

tinue-on-failure" On Mon, Jul 10, 2017 at 2:14 PM, Taher Alkhateeb <slidingfilame...@gmail.com> wrote: > Thank you everyone for your feedback, I will let this discussion > continue for a few days before committing anything (testing is going > to take some time anyway). > >

Re: [Discussion] Failing the build if data loading fails

, 2017 at 1:45 PM, Devanshu Vyas <vyas.devansh...@gmail.com> wrote: > I agree with option #3 and the 'continue-on-failure' flag with default > value=false. :) > > Thanks & Regards, > Devanshu Vyas. > > On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb <slidingfilame...

Re: [Discussion] Failing the build if data loading fails

gt; >> > Hi all, >> > >> > I agree with option 3. I recall in my own work I once needed to add a >> throw >> > where there was none to track down a problem. >> > >> > However ignore-failure leads to a double negative. How about >

Re: [Discussion] Failing the build if data loading fails

; wrote: Hi all, I agree with option 3. I recall in my own work I once needed to add a throw where there was none to track down a problem. However ignore-failure leads to a double negative. How about "stop-on-failure", default value true? Cheers Paul Foxworthy On 10 July 2017 at 05:27, Taher A

Re: [Discussion] Failing the build if data loading fails

Correction: on item (2) in my post: fail immediately, not after loading all files, otherwise there's no point. On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb <slidingfilame...@gmail.com> wrote: > Hello Everyone, > > For a long time I was annoyed by something in OFBiz: the buil

[Discussion] Failing the build if data loading fails

Hello Everyone, For a long time I was annoyed by something in OFBiz: the build system does not fail if data loading fails for some files. I spend hours hunting bugs only to discover that the data simply did not load. Given that I'm working on refactoring the data loading container, I believe

Re: svn commit: r1801365 - /ofbiz/tools/demo-backup/trunk-manual.sh

t; > > > Le 09/07/2017 à 12:49, Taher Alkhateeb a écrit : >> >> Hi Jacques, >> >> Can you elaborate on this a little bit? Maybe there is a bug we can >> fix. What happens exactly? it never shuts down? takes a while? error >> logs? >> >> On

Re: svn commit: r1801365 - /ofbiz/tools/demo-backup/trunk-manual.sh

Hi Jacques, Can you elaborate on this a little bit? Maybe there is a bug we can fix. What happens exactly? it never shuts down? takes a while? error logs? On Sun, Jul 9, 2017 at 1:40 PM, wrote: > Author: jleroux > Date: Sun Jul 9 10:40:36 2017 > New Revision: 1801365 > >

Re: [PROPOSAL] Replace Inline Javascript with External Javascript

Big +1, thank you for the initiative. I wish everyone reading this to take an active role too, there is so much refactoring needed in the project and we need your help. It's not hard to find an area you're comfortable with and start cleaning it up a bit. On Sat, Jul 8, 2017 at 12:16 PM, Michael

Re: Auto read on View Communication Event page

Hello Pallavi, All good questions, but I think it's better to start this thread in the user ML as it is more appropriate to ask that question over there. Cheers, On Sat, Jul 8, 2017 at 12:08 PM, Pallavi Goyal wrote: > Hello Devs, > > I was exploring the Communication

Re: Call to action: fixing defects reported by code analysis tools

Fantastic initiative Michael, +1 I think a simple attachment in jira or a wiki page will suffice. A one-time scan would provide more than enough information for everyone who needs to work on stuff. We can run it again in the future when enough bugs have been tackled. On Fri, Jul 7, 2017 at 1:43

Re: [PROPOSAL] Environment variable configuration

I faced something similar in the past (Not related to OFBiz). Many systems require different paths of configuration depending on different deployment scenarios. There are multiple types of configurations I can think of including: - platform dependent configurations (it depends on your server and

Re: [DISCUSSION] Improving the OFBiz User Interface

de the framework/applications? Regards, Michael Am 04.07.17 um 23:50 schrieb Taher Alkhateeb: Hi Michael, > > I think we agree, just a difference in semantics. What I mean by web > is anything CSS, JavaScript, or HTML, not FreeMarker (for now). The > smaller the effort the bigger the cha

Re: [DISCUSSION] Improving the OFBiz User Interface

valuating if we can set a team on it to > implement a new UI. It will be a lot of work and a big effort for us but I > think it's worth it. We'll see how this will work out and how we can > contribute this back to the project. > > Best regards, > > Michael Brohl > ecomify Gm

Re: [DISCUSSION] Improving the OFBiz User Interface

I agree with Michael, baby steps for the win. I propose we perhaps just postpone "big ideas" for now and focus on things that can get results quickly to put life back into this initiative. Maybe next actions could be the following: - Create a base theme - Move all artifacts from framework/images

Re: buildbot failure in on ofbiz-trunk-framework-plugins

This is a classic "hidden dependency" because of some sort of "global state". I'm glad we're facing this problem because it shows the value of separating the project into two repos. I checked the logs and I think it would take a while to see exactly where that null reference is coming from. So I

Re: Fun with Gource

Very cool, thanks for sharing. Maybe we should link this to the OFBiz youtube channel. It was kind of emotional to see Adrian Crum's name in there. On Jul 2, 2017 4:37 AM, "Michael Brohl" wrote: > I played with Gource and made a video of 11 years of OFBiz, from 2006 >

Re: OFBiz Dev List and Deepak Dixit mentioned in ASF Annual Report

Yeah I saw that too. Awesome work Deepak On Jun 30, 2017 10:34 AM, "Sharan Foga" wrote: > Hi Everyone > > I'm not sure if you saw the announcement for the ASF Annual Report that > was published. I took a quick look through it and saw that on page 25 our > OFBiz dev list has

Re: Reducing excessive and improperly studied commits

(disputed) commit followed by one or more commits >> to fix/improve the original one. >> >> Regards, >> >> Jacopo >> >> On Wed, Jun 21, 2017 at 12:37 PM, Taher Alkhateeb < >> slidingfilame...@gmail.com> wrote: >> >>> Hello Everyo

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

ll of you. Cheers, [1] https://cwiki.apache.org/confluence/display/OFBIZ/Re-Factor+To-Do+List [2] https://s.apache.org/jB5f Taher Alkhateeb On Thu, Jun 29, 2017 at 1:13 AM, Scott Gray <scott.g...@hotwaxsystems.com> wrote: > Hi Taher, > > I can understand your frustration

Re: svn commit: r1800137 - in /ofbiz/branches/ofbiz-new-website: index.html template/page/index.tpl.php

Hi Sharan, All I think at some point we should consider maybe ignoring the generated HTML files from the repository given that these are just generated replaceable documents. The real important documents are the templates. On Wed, Jun 28, 2017 at 12:39 PM, wrote: > Author:

Re: the price of a product and the cart object

Hi, I believe this email is better asked on the user mailing list. On Tue, Jun 27, 2017 at 8:13 PM, Heidi Dehaes - Olagos wrote: > Hello, > > Can anyone give me a hint on how the price which is visualised at a product > in the ecommerce site comes into the cart object for

Re: A problem with terminateOfbiz Gradle task (was [Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle)

de a patch for review > > Jacques > > > Le 26/06/2017 à 09:37, Jacques Le Roux a écrit : >> >> OK, the shutdown command is somehow our SIGTERM, makes sense >> >> Jacques >> >> >> Le 26/06/2017 à 08:45, Taher Alkhateeb a écrit : >>>

Re: buildbot failure in on ofbiz-branch16

I think the buildbot scripts might be faulty. I'll work on refactoring it to at least start using the embedded gradle wrapper with --no-daemon flag. We need to slowly isolate all causes On Mon, Jun 26, 2017 at 11:29 AM, Michael Brohl wrote: > Done in

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

2 operations. So SIGTERM fails. I'd really like to send SIGTERM before killing the process and only kill it if it's necessary (ie if SIGTERM did not terminate the process) So we need to catch the SIGTERM exec and send SIGKILL if it fails, right? Jacques Le 25/06/2017 à 16:05, Taher Alkhateeb a

Re: New Website Branch Created

+1 for switching the website to the new one and completing it as we go. We should try to automate publishing the website. One solution is to publish the website as is. Another solution is to restructure the website so that only the "generated" stuff gets published to the server. So the directory

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

, this shows you how poor the quality of this code is. It introduces a subtle bug, it repeats an if condition unnecessarily, and the comments are wrong "Only kill if needed" On Sun, Jun 25, 2017 at 4:22 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > I'm c

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

> 1. revert the change as requested >> >> 2. provide a Jira with patch and review/discuss it there (what's the >> problem, how should it be solved etc.) >> >> 3. come to a conclusion and a thumbsup by other committers >> >> 4. commit the solution. >>

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

t; the 1st "if" try to terminate it. >>> >>> If it worked the 2nd "if" does not execute. This is better than before >>> because it allows the "'start" process "a chance to clean up after itself" >>> (cf unix.stackexchan

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

inated then it's killed by the 2nd >> "if", like it was done before. >> >> As I said it cleanly worked with 2 OFBiz instances running in the >> background. >> >> Now tell me what's wrong? >> >> Thanks >> >> Jacques >> >&g

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

wrong: Execution failed for task ':ofbiz'. > Process 'command '/usr/lib/jvm/java-8-oracle/bin/java'' finished with non-zero exit value 137 Which I believe is OK because Java does not expect to be killed! Jacques Le 24/06/2017 à 20:04, Taher Alkhateeb a écrit : > This commit is wrong and

Re: buildbot failure in on ofbiz-trunk-framework-plugins

I suspect we did something wrong in the buildbot scripts lately and that is why we're having these weird consistent crashes. We need to review these files. On Sat, Jun 24, 2017 at 11:30 PM, wrote: > The Buildbot has detected a new failure on builder >

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

This commit is wrong and bad on multiple levels. Please revert On Sat, Jun 24, 2017 at 10:56 AM, wrote: > Author: jleroux > Date: Sat Jun 24 07:56:45 2017 > New Revision: 1799736 > > URL: http://svn.apache.org/viewvc?rev=1799736=rev > Log: > No functional change > > Improves

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03 - second attempt

Tests running, Basic smoke tests reveal nothing from my side. +1 On Wed, Jun 21, 2017 at 9:45 PM, Deepak Dixit < deepak.di...@hotwaxsystems.com> wrote: > +1 > > Thanks & Regards > -- > Deepak Dixit > > On Wednesday, June 21, 2017, Michael Brohl > wrote: > > > +1 > > >

Reducing excessive and improperly studied commits

Hello Everyone, I am starting this thread because of the latest unexpected release thread [1] due to a major bug introduced by Jacques Le Roux in [2]. We had multiple discussion with Jacques, one such discussion [3] was due to a bad commit in which I made a recommendation to stop doing bulk

Re: Help in reviewing my refactoring of CatalinaContainer

Hey Folks. I know everyone's probably preoccupied. It would be great to get some feedback on OFBIZ-9392 though given how critical this piece of code is. I'd feel much better about committing after a few reviews. On Thu, Jun 15, 2017 at 9:22 PM, Taher Alkhateeb <slidingfilame...@gmail.com >

Re: svn commit: r1798912 - /ofbiz/tools/demo-backup/trunk-manual-only.sh

Why would you add 30 sec sleep! The right way to do this is to change the command as follows: ./gradlew "ofbiz --shutdown" In other words, don't send the shutdown command to the background. On Jun 16, 2017 2:34 PM, wrote: Author: jleroux Date: Fri Jun 16 11:34:38 2017 New

Re: Help in reviewing my refactoring of CatalinaContainer

://tomcat.apache.org/tomcat-8.0-doc/cluster-howto.html Cheers, -- Taher Alkhateeb On Wed, Jun 14, 2017 at 11:07 PM, Michael Brohl <michael.br...@ecomify.de> wrote: > Hi Taher, > > Am 14.06.17 um 19:56 schrieb Taher Alkhateeb: > >> Okay, after a little bit of investigation I

Re: Help in reviewing my refactoring of CatalinaContainer

conflicting with my local LAN setup. After doing the above and testing the cluster, everything worked. Bug again, given that I'm treading in new territory, appreciate all the help. The new patch is available at https://issues.apache.org/jira/browse/OFBIZ-9392 Cheers, Taher Alkhateeb On Tue, Jun

Re: Help in reviewing my refactoring of CatalinaContainer

tendency to crash ofbiz during startup if you don't > have it configured correctly. > > Definitely a -1 for removal. > > Regards > Scott > > On 13 June 2017 at 08:57, Taher Alkhateeb <slidingfilame...@gmail.com> > wrote: > > > Hi Everyone, > > > > I

Re: Help in reviewing my refactoring of CatalinaContainer

OS, I'll try this tomorrow. It would be great if others could check if OFBiz runs on their machine with configured cluster support. Regards, Michael Am 13.06.17 um 01:01 schrieb Taher Alkhateeb: A compile dependency is also a runtime dependency in gradle (as opposed to > compileOnly). >

Re: Help in reviewing my refactoring of CatalinaContainer

el Am 13.06.17 um 00:11 schrieb Taher Alkhateeb: Hi Michael, > > Hmmm, I didn't know that it is actively used. Essentially, you get > exceptions / crashes when you uncomment the clustering section in > catalina's ofbiz-component.xml. > > Also, I could be wrong, but I

Re: Help in reviewing my refactoring of CatalinaContainer

and a manager and a few other things. Cheers, Taher Alkhateeb On 13/06/17 01:03, Michael Brohl wrote: Hi Taher, clustering support is an important feature for enterprise installations and it worked in the past. It should be fixed if it is broken. What makes you think that clustering is broken? How

Re: Information on Design and Structure of Camel Website and Wiki

ortunity to see if we can try something. >> If fixing docbook doesn't work then we know loud and clear that we need >> to remove it and use something else. Either way we have progress and for me >> that's what we need. >> >> So you can probably see that I'd lik

Re: Help in reviewing my refactoring of CatalinaContainer

of code. WDYT [1] https://issues.apache.org/jira/browse/OFBIZ-9392 On Thu, Jun 8, 2017 at 3:38 PM, Taher Alkhateeb <slidingfilame...@gmail.com> wrote: > Hey folks, > > It was very painful and slow, but I finally got a working almost > full-rewrite of the CatalinaContainer. I need

Re: svn commit: r1798353 - in /ofbiz/ofbiz-framework/trunk/applications: content/src/main/java/org/apache/ofbiz/content/survey/SurveyWrapper.java product/src/main/java/org/apache/ofbiz/product/product

Hi Jacques, the build is still crashing, and I suspect this is from your commit r1798335. Again, this means you're committing without testing and doing "gradlew cleanAll loadDefault testIntegration". I also think this mass searching for try blocks in the code base and changing them to

Re: buildbot failure in on ofbiz-trunk-framework

I don't want to sound like a broken record, but at a minimum I would suggest to apply "svn up" followed by "./gradlew cleanAll loadDefault testIntegration" before committing. Depending on buildbot to catch errors is not an ideal solution because it slows down other committers who are trying to

Re: svn commit: r1798104 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntityListIterator.java

I think this log message looks bad in addition to being platform dependent with EOL character. Perhaps it should be properly formatted as it looks off and 220 characters wide for no good reason. On Thu, Jun 8, 2017 at 9:39 PM, wrote: > Author: jleroux > Date: Thu Jun 8

Help in reviewing my refactoring of CatalinaContainer

] https://issues.apache.org/jira/browse/OFBIZ-9392 Cheers, Taher Alkhateeb

Failing tests due to bad commits

committing? Cheers, Taher Alkhateeb

Re: Information on Design and Structure of Camel Website and Wiki

Reading through the threads provided by Paul reminded me of the reason why we suffered in making a decision. Documentation is very important, and very boring! I think we all agree now (more-or-less) that documentation inside the code base is probably better. The question to raise (again!) is

Re: [DOCUMENTATION] Fixing our End User Documentation Problem

+1 Fantastic initiative. On Tue, May 30, 2017 at 12:10 PM, Sharan Foga wrote: > Excellent and thanks for the link Michael! > > Thanks > Sharan > > > On 30/05/17 11:07, Michael Brohl wrote: > >> Hi Sharan, Craig, >> >> this is great and will fit well into the Wiki

Re: [PROPOSAL] Restructure OFBiz Wiki

I see this mind-map and think to myself there is good effort done in thinking about it. +1 to proceed with changes based on what's there. In my opinion, we shouldn't worry too much about agreeing on structure. Our current wiki is in a bad shape and any work done on it is better than keeping it as

Re: [DISCUSSION] migrate mini lang to Java and/or groovy

. Cheers, Taher Alkhateeb On Sun, May 28, 2017 at 1:34 PM, Michael Brohl <michael.br...@ecomify.de> wrote: > Thanks all for your opinions! > > It seems that most of us are in favor of using Groovy instead of Java for > services, events and tests. > > Discussing this in

Progress bar suppression on OFBiz server tasks

Hello Everyone, I noticed lately that some users got confused on the progress bar in Gradle (percent complete) when starting OFBiz from Gradle. I thought of a quick solution that would simply suppress the progress bar and colored output if the gradlew command contained the word "ofbiz" anywhere

Re: [DISCUSSION] migrate mini lang to Java and/or groovy

ration from poor designed minilang (beside the technical interest :) ) could lead to have a lot of bad java with a lot of cleaning required. Gil Le 19/05/2017 à 15:15, Taher Alkhateeb a écrit : > My recommendation if you want to achieve something significant for this > task is the follow

Re: [DISCUSSION] migrate mini lang to Java and/or groovy

My recommendation if you want to achieve something significant for this task is the following: - Focus first on services and tests, the bulk of messy minilang is living there - Maybe we shouldn't reinvent the wheel. We already have the minilang parsing logic, why not just use it to convert

Re: Lucene and Solr loggin

The master build.gradle file should not point to any plugins On Fri, May 19, 2017 at 1:10 PM, Shi Jinghai wrote: > Hi Jacques, > > In ${ofbiz.home}/build.gradle, adding solr.log.dir and solr.log.level can > remove this error message, i.e.: > def jvmArguments = ['-Xms128M',

Restarting discussion on removing dead Java files

Hello Everyone, We had a discussion thread [1] in which we agreed that some Java files should be removed from the framework. Some individuals suggested to move them to plugins and started a JIRA [2] for that. It has been a long time since this thread started and the hack we have in build.gradle

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.02

gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) < jaco...@apache.org>" +1 On Tue, May 16, 2017 at 11:11 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > This is the vote thread to release a new bug fix release for the > release16.11 branch. This new release,

Re: Removing and renaming redundant tasks from Gradle

com> wrote: > Hi Taher, > > I regularly use copyDtds to update our XSDs on our site which are used as > references by our XML files. > > We could also move it to copyDtds if you prefer. > > Jacques > > > > Le 14/05/2017 à 07:41, Taher Alkhateeb a éc

Removing and renaming redundant tasks from Gradle

Hello everyone, I propose the following actions to update and cleanup build.gradle - remove copyDtds (almost never used, and not related to building OFBiz) - remove the "committerGroup" label - change the group label for "svnInfoFooter" and "gitInfoFooter" to "sysadminGroup" WDYT

Re: Removing failing tests from framework

th also data at correct plac. > > Is that not the case? Do we really want to remove them definitely? > > Jacques > > > Le 10/05/2017 à 12:18, Taher Alkhateeb a écrit : > >> Hi Jacques, why do you want to reintroduce the tests? >> >> On Wed, May 10, 2017 at 12:52 PM, Ja

Re: Preparing the new release 16.11.02

split the tools folder from 16.11? This kind of change belongs in Trunk no? On Thu, May 11, 2017 at 12:45 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > I'd like to split the tools folder, I planned it for months but delayed :/ > > It's of course not blocking and I have nothing

Re: Preparing the new release 16.11.02

- All tests pass on my computer - Smoke tests on the system show normal operation across the accounting screens and webtools. - I got an error on https://localhost:8443/accounting/control/PaymentAcctgTransEntriesPdf?paymentId=8003 HTTP 500, but I believe it also existed on the first release.

Re: Removing failing tests from framework

t;>> Hi Taher, >>> >>> Please give me an hour to review, I did not look at it yet >>> >>> Thanks >>> >>> Jacques >>> >>> >>> Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit : >>> >>>> Hey folks

Re: Loading standard web application

Jacopo summarized this very nicely. So yeah I would say the code quality of code in this feature is good and can go to the code base, but let's stay open to the idea of refactoring which may affect it in the future. I am already doing some low level work in that area BTW Cheers, Taher Alkhateeb

Re: Loading standard web application

it, then it might be worth introducing. Either way, again thank you for all the work James! :) Cheers, Taher Alkhateeb On Sun, May 7, 2017 at 5:14 PM, Michael Brohl <michael.br...@ecomify.de> wrote: > Hi James, hi Taher, > > in general, I think it's helpful to have the possibility to load

Re: Loading standard web application

other Tomcat instance. > But I won't commit the patch if others doesn't need it. > > Regards, > James Yong > > PS: I can run standard web application in earlier OFBiz versions. > > On 2017-05-07 14:09 (+0800), Taher Alkhateeb <slidingfilame...@gmail.com> > wro

Re: Loading standard web application

, need to work on the smaller issues. > > So I will start with the patch for the loading of standard web > application. > > > > Regards, > > James Yong > > > > On 2017-05-06 18:48 (+0800), Taher Alkhateeb <slidingfilame...@gmail.com> > wrote: > > >

Re: Loading standard web application

Hi James, I guess we can start discussing this at a more detailed level once you have a PoC or more elaborate exploration of the exact "why" and "how". All good initiatives ! Cheers, Taher Alkhateeb On Sat, May 6, 2017 at 7:41 AM, James Yong <jamesy...@apache.org> wro

Re: Loading standard web application

deploying the > Camunda workflow engine (published as a WAR) on his/her own, as the WAR > file can be downloaded automatically via gradle script during OFBiz > starting up. > > Regards, > James Yong > > On 2017-05-05 18:07 (+0800), Taher Alkhateeb <slidingfila

Re: svn commit: r1793170 - in /ofbiz/ofbiz-framework/trunk/applications: accounting/data/DemoPaymentsInvoices.xml party/data/PartyDemoData.xml

I know I'm stating the obvious, but just to confirm tests are passing on framework-alone right? On Fri, May 5, 2017 at 9:30 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Done at r1794092 > > Jacques > > > > Le 02/05/2017 à 13:28, Taher Alkhatee

Re: Loading standard web application

This topic is very much linked to the previous thread that you started earleri "Tomcat SSO" so they might as well be one topic. I think I answered most stuff in that thread. However, I would add that in my opinion, maybe it would be simpler if we avoid implementing it in this fashion (ofbiz

Re: Tomcat SSO

I've been contemplating this for a while, but it is not an easy task. Essentially, we need to fully refactor the Catalina Container and do a lot of cleanup to reverse the way OFBiz is deployed to be a single web application, not multiple web applications mapped to a single servlet container as is

OFBiz creating an unwanted directory

Hey folks, I'm not sure but I think this might be related to a commit for Solr? Essentially the framework now creates a directory "$OFBIZ_HOME/home/solrdefault/runtime" whenever I run OFBiz. Whoever knows about this or committed code, can you please look at it and fix it?

Re: Removing failing tests from framework

nks for the effort and kudos for the progress made so far. >> >> Jacopo >> >> On Sat, Apr 29, 2017 at 9:32 AM, Taher Alkhateeb < >> slidingfilame...@gmail.com >> >>> wrote: >>> Hello Everyone, >>> >>> I've been doin

Re: Guest Access Link for OFBiz HipChat Room

The domain name changed from apache.hipchat.com to www.hipchat.com, is this related to the security issue? On Tue, May 2, 2017 at 2:35 PM, Swapnil Mane wrote: > Hello team, > > After HipChat security notice >

Re: svn commit: r1793170 - in /ofbiz/ofbiz-framework/trunk/applications: accounting/data/DemoPaymentsInvoices.xml party/data/PartyDemoData.xml

Hi Jacques, Again, feel free to change the data. My objective was simply to get tests running successfully on framework-alone and I would actually appreciate your help since you already did the viewing and testing? On Tue, May 2, 2017 at 2:22 PM, Jacques Le Roux < jacques.le.r...@les7arts.com>

Re: svn commit: r1792866 [2/3] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/ accounting/data/ marketing/data/ order/ order/data/ party/testdef/data/ product/data/ workeffort/minilang/tes

Hi Jacques, All I did was move data that already existed. Cleanup is another issue altogether and I had multiple comments that the data is quite messy. I would rather focus on finalizing the split, and would appreciate your help in fixing this data. On Tue, May 2, 2017 at 2:13 PM, Jacques Le

Re: svn commit: r1792866 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/ accounting/data/ marketing/data/ order/ order/data/ party/testdef/data/ product/data/ workeffort/minilang/tes

Yup, good catch. Naturally, the second one should be removed. I'll take care of it. On Tue, May 2, 2017 at 2:06 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Taher, > > statusDate="2001-01-01 12:00:00.0"/> > > is duplicated below, not sure which one to remove because of

Re: Removing failing tests from framework

gt; WDYT? > > [1] https://issues.apache.org/jira/browse/OFBIZ-9322 > [2] https://s.apache.org/DlGE > [3] https://issues.apache.org/jira/secure/attachment/ > 12865667/OFBIZ-9322.patch > > Cheers, > > Taher Alkhateeb >

Re: New ASF Members from OFBiz Community

gt; > We have now 12 ASF members among our committers with new 7 ASF members this > year: Anil, Ashish, Bilgin, Michael, Nicolas, Scott and Taher! > > I have updated the PMC page regarding ASF members, please check that all is > alright. > > Thanks > > Jacques > > >

Re: New ASF Members from OFBiz Community

and Taher! > > > > I have updated the PMC page regarding ASF members, please check that all > > is alright. > > > > Thanks > > > > Jacques > > > > > > > > > > Le 08/04/2017 à 11:13, Taher Alkhateeb a écrit : > > > >&g

Re: svn commit: r1793254 - /ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/entity/FindGeneric.groovy

Whoa! That was painful to read, this file It is creating dynamic models for XML documents and then parsing them for stuff like entities and widgets and hard-coding XML attributes and then shoving everything back to the context. Phew! If anyone has the time and would like to review this, I would

<    1   2   3   4   5   6   7   8   9   10   >