Re: Ideas about OFBiz servlet filters

2016-09-19 Thread Shi Jinghai
时间: 2016年9月19日 14:38 收件人: dev@ofbiz.apache.org 主题: Re: Ideas about OFBiz servlet filters Hi Jinghai, during the weekend I committed a series of changes to leverage the new ControlFilter (and simplify the ContextFilter and other filters) in all the OFBiz applications. It would be great if you

Re: Ideas about OFBiz servlet filters

2016-09-19 Thread Jacopo Cappellato
In rev. 1761424 I did some additional cleanup. Please test and report any issues you may find. Thanks, Jacopo On Mon, Sep 19, 2016 at 8:44 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Thank you Carsten, > > this is exactly the feedback I was looking for, very

Re: Ideas about OFBiz servlet filters

2016-09-19 Thread Jacopo Cappellato
Thank you Carsten, this is exactly the feedback I was looking for, very interesting. During the weekend I have committed additional cleanups/fixes and it would be great if you could test your applications with them and report any issues you may find. Over the years, several layers of changes

Re: Ideas about OFBiz servlet filters

2016-09-19 Thread Jacopo Cappellato
> -邮件原件- > 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] > 发送时间: 2016年9月17日 22:25 > 收件人: dev@ofbiz.apache.org > 主题: Re: Ideas about OFBiz servlet filters > > Hi Jinghai, > > please see inline: > > On Sat, Sep 17, 2016 at 3:16 PM, Shi

Re: Ideas about OFBiz servlet filters

2016-09-17 Thread Carsten Schinzer
Great proposal, I had quite some headaches with this 2-3 years ago when I was diving deep into the multitenancy with several (mini) shops and content sites for different tenants.. ContextFilter handles it well, but the others don't for the reasons you mention. I was hesitating to propose anything

Re: Ideas about OFBiz servlet filters

2016-09-17 Thread Shi Jinghai
Thanks Jacopo! I'll try to change the SEO filter next Monday. -邮件原件- 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] 发送时间: 2016年9月17日 22:25 收件人: dev@ofbiz.apache.org 主题: Re: Ideas about OFBiz servlet filters Hi Jinghai, please see inline: On Sat, Sep 17, 2016

Re: Ideas about OFBiz servlet filters

2016-09-17 Thread Jacopo Cappellato
think? Thanks, Jacopo > > Anyway, please do leave a message here if you have further changes on the > filters. > > Kind Regards, > > Shi Jinghai > > > -邮件原件- > 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] > 发送时间: 2016年9月14日 23:

Re: Ideas about OFBiz servlet filters

2016-09-17 Thread Shi Jinghai
have further changes on the filters. Kind Regards, Shi Jinghai -邮件原件- 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] 发送时间: 2016年9月14日 23:34 收件人: dev@ofbiz.apache.org 主题: Re: Ideas about OFBiz servlet filters In rev. 1760725 I have committed the new ControlFilter

Re: Ideas about OFBiz servlet filters

2016-09-15 Thread Jacques Le Roux
] 发送时间: 2016年9月13日 16:30 收件人: dev@ofbiz.apache.org 主题: Re: Ideas about OFBiz servlet filters Thank you Jinghai, I agree we should separate the concerns and split the ContextFilter into two filters; I am going to work on this and I am planning to separate the "controller" related concerns

Re: Ideas about OFBiz servlet filters

2016-09-14 Thread Jacopo Cappellato
邮件原件- > 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] > 发送时间: 2016年9月13日 16:30 > 收件人: dev@ofbiz.apache.org > 主题: Re: Ideas about OFBiz servlet filters > > Thank you Jinghai, > > I agree we should separate the concerns and split the ContextFi

Re: Ideas about OFBiz servlet filters

2016-09-13 Thread Shi Jinghai
to change SEO and solr filters to follow your update. Kind Regards, Shi Jinghai -邮件原件- 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] 发送时间: 2016年9月13日 16:30 收件人: dev@ofbiz.apache.org 主题: Re: Ideas about OFBiz servlet filters Thank you Jinghai, I agree we should

Re: Ideas about OFBiz servlet filters

2016-09-13 Thread Jacopo Cappellato
ellato [mailto:jacopo.cappell...@hotwaxsystems.com] > 发送时间: 2016年9月9日 16:07 > 收件人: dev@ofbiz.apache.org > 主题: Ideas about OFBiz servlet filters > > A web application, in order to leverage the OFBiz framework, requires that > a series of objects are in its contexts (servlet context,

Re: Ideas about OFBiz servlet filters

2016-09-11 Thread Shi Jinghai
: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] 发送时间: 2016年9月9日 16:07 收件人: dev@ofbiz.apache.org 主题: Ideas about OFBiz servlet filters A web application, in order to leverage the OFBiz framework, requires that a series of objects are in its contexts (servlet context, session

Re: Ideas about OFBiz servlet filters

2016-09-09 Thread Jacopo Cappellato
I prefer to start the discussion in this list and consider to move to Jira only in a second phase if a more structured coordination of tasks will be useful. Jacopo On Fri, Sep 9, 2016 at 10:25 AM, Pierre Smits wrote: > I hope the proposal for actionable items will

Re: Ideas about OFBiz servlet filters

2016-09-09 Thread Pierre Smits
I hope the proposal for actionable items will materialise rather sooner than later in our JIRA. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Fri, Sep 9, 2016 at 10:23 AM, Jacopo

Re: Ideas about OFBiz servlet filters

2016-09-09 Thread Jacopo Cappellato
And here is a proposal for some actionable items to contribute to this effort: 1) review and document the current usage (by application) of filters (classes and their order) 2) review the logic in the filters and compare it to the one of ContextFilter (what is different, what is added, what is

Re: Ideas about OFBiz servlet filters

2016-09-09 Thread Pierre Smits
I like the concept. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Fri, Sep 9, 2016 at 10:07 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > A web application,

Re: Ideas about OFBiz servlet filters

2016-09-09 Thread Jacques Le Roux
Thanks Jacopo, This sounds like a plan to me. I see Jinghai is already working on the most culprits, I hope he will get this message ASAP, to avoid doing useless work. Then we can work together to clean the stuff Jacques Le 09/09/2016 à 10:07, Jacopo Cappellato a écrit : A web application,

Ideas about OFBiz servlet filters

2016-09-09 Thread Jacopo Cappellato
A web application, in order to leverage the OFBiz framework, requires that a series of objects are in its contexts (servlet context, session and request) such as "delegator", "delegatorName", "dispatcher", "security" etc. etc... This setup is performed by the logic contained in the servlet filter