Re: svn commit: r1841675 - /ofbiz/tools/verify-ofbiz-release.sh

2018-09-22 Thread Michael Brohl

Hi Mathieu,

thanks for the hint!

There is no portability requirement, I once wrote this script to ease 
the release checks and shared it with the community.


I changed the code so that there is no need for exporting the setting 
anymore.


Regards,

Michael


Am 22.09.18 um 14:41 schrieb Mathieu Lirzin:

Hello Michael,

mbr...@apache.org writes:


  # use english gpg output
-LC_MESSAGES=en_EN.UTF-8
+export LC_MESSAGES=en_EN.UTF-8

This syntax is a bashism.  I don't know the portability requirements for
this script, but I would recommend using this syntax instead:

   LC_MESSAGES=en_EN.UTF-8
   export LC_MESSAGES

Thanks.






smime.p7s
Description: S/MIME Cryptographic Signature


Re: svn commit: r1841675 - /ofbiz/tools/verify-ofbiz-release.sh

2018-09-22 Thread Mathieu Lirzin
Hello Michael,

mbr...@apache.org writes:

>  # use english gpg output
> -LC_MESSAGES=en_EN.UTF-8
> +export LC_MESSAGES=en_EN.UTF-8

This syntax is a bashism.  I don't know the portability requirements for
this script, but I would recommend using this syntax instead:

  LC_MESSAGES=en_EN.UTF-8
  export LC_MESSAGES

Thanks.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.05

2018-09-22 Thread Michael Brohl

+1

Everything is ok:

$ ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-16.11.05.zip
sha check of file: apache-ofbiz-16.11.05.zip
Using sha file: apache-ofbiz-16.11.05.zip.sha512
apache-ofbiz-16.11.05.zip: 9D0C613C C3D88C37 A5A41F53 55F0D6A0 A465AB29 
00987DF6 5070BBA6 4DCA43B4 1C8C44DB E7A1BBA5 4528AE17 04B45DE8 722F702E 
9C13508A 0CD900A1 3F1D3B1B
apache-ofbiz-16.11.05.zip: 9D0C613C C3D88C37 A5A41F53 55F0D6A0 A465AB29 
00987DF6 5070BBA6 4DCA43B4 1C8C44DB E7A1BBA5 4528AE17 04B45DE8 722F702E 
9C13508A 0CD900A1 3F1D3B1B

sha checksum OK

GPG verification output
gpg: Signature made Mon Sep 17 11:02:30 2018 CEST using RSA key ID 847AF9E0
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) 
" [ultimate]



$ ./gradlew loadDefault testIntegration

...

BUILD SUCCESSFUL


Thanks Jacopo,

Michael

Am 21.09.18 um 16:26 schrieb Jacopo Cappellato:

  This is the vote thread to release a new bug fix release for the
release16.11 branch. This new release, "Apache OFBiz 16.11.05" will
supersede all the previous releases from the same branch.

The release files can be downloaded from here:

https://dist.apache.org/repos/dist/dev/ofbiz/

and are:

* apache-ofbiz-16.11.05.zip
* KEYS: text file with keys
* apache-ofbiz-16.11.05.zip.asc: the detached signature file
* apache-ofbiz-16.11.05.zip.sha512: checksum file

Please download and test the zip file and its signatures (for instructions
on testing the signatures see http://www.apache.org/info/verification.html).

Vote:

[ +1] release as Apache OFBiz 16.11.05
[ -1] do not release

This vote will be open for at least 5 days.

For more details about this process please read
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo






smime.p7s
Description: S/MIME Cryptographic Signature


Relation type in SecurityGroupPermission entity

2018-09-22 Thread Deepak Nigam
Hi Folks,

In the definition of 'SecurityGroupPermission' entity, the relation type
with 'SecurityPermission' entity is 'one-nofk'. Hence the system is
allowing to use the permissions not defined anywhere. (ex.
ORDERMGR_CRQ_ADMIN/ORDERMGR_CRQ_UPDATE).
Do we have any use case for this type of relation?

IMO, here the relation type should be 'one' here to maintain
the referential integrity. WDYT?


Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


Re: Upgrading the Authorize.net AIM API

2018-09-22 Thread Pierre Smits
I believe first the discussion on how we’re going to deal with these kind
of 3rd party solution integrations, whether they be fintech, logistic or
other,  should be completed first.

Many times aspects regarding this has been brought forward in other threads
and in tickets.



Best regards,

Pierre Smits

*Apache Trafodion , Vice President*
*Apache Directory , PMC Member*
Apache Incubator , committer
*Apache OFBiz , contributor (without privileges)
since 2008*
Apache Steve , committer

On Sat, Sep 22, 2018 at 1:39 PM, Nameet Jain  wrote:

> Hello Team,
>
> While researching around Advanced Integration Method (AIM) Authorize.net
> API, I found that the AIM API has now been deprecated. Authorize.net
> suggest upgrading the AIM support to XML or JSON based support. Please let
> me know your thoughts.
>
> Here is the link for your reference
> https://developer.authorize.net/api/upgrade_guide/
> https://developer.authorize.net/api/reference/index.html
>
> Thanks
> --
> Regards,
> Nameet Jain
>


Upgrading the Authorize.net AIM API

2018-09-22 Thread Nameet Jain
Hello Team,

While researching around Advanced Integration Method (AIM) Authorize.net
API, I found that the AIM API has now been deprecated. Authorize.net
suggest upgrading the AIM support to XML or JSON based support. Please let
me know your thoughts.

Here is the link for your reference
https://developer.authorize.net/api/upgrade_guide/
https://developer.authorize.net/api/reference/index.html

Thanks
--
Regards,
Nameet Jain


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.05

2018-09-22 Thread Aditya Sharma
+1

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Commerce  by HotWax Systems

[image: https://www.linkedin.com/in/aditya-p-sharma/]



On Sat, Sep 22, 2018 at 4:06 PM Rishi Solanki 
wrote:

> +1
>
> Thanks!
> --
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>
>
> On Sat, Sep 22, 2018 at 4:01 PM Swapnil Mane <
> swapnil.m...@hotwaxsystems.com>
> wrote:
>
> > +1
> >
> >
> > - Best Regards,
> > Swapnil M Mane
> >
> > On Fri, Sep 21, 2018 at 7:56 PM Jacopo Cappellato <
> > jacopo.cappell...@hotwaxsystems.com> wrote:
> >
> > >  This is the vote thread to release a new bug fix release for the
> > > release16.11 branch. This new release, "Apache OFBiz 16.11.05" will
> > > supersede all the previous releases from the same branch.
> > >
> > > The release files can be downloaded from here:
> > >
> > > https://dist.apache.org/repos/dist/dev/ofbiz/
> > >
> > > and are:
> > >
> > > * apache-ofbiz-16.11.05.zip
> > > * KEYS: text file with keys
> > > * apache-ofbiz-16.11.05.zip.asc: the detached signature file
> > > * apache-ofbiz-16.11.05.zip.sha512: checksum file
> > >
> > > Please download and test the zip file and its signatures (for
> > instructions
> > > on testing the signatures see
> > http://www.apache.org/info/verification.html
> > > ).
> > >
> > > Vote:
> > >
> > > [ +1] release as Apache OFBiz 16.11.05
> > > [ -1] do not release
> > >
> > > This vote will be open for at least 5 days.
> > >
> > > For more details about this process please read
> > > http://www.apache.org/foundation/voting.html
> > >
> > > Kind Regards,
> > >
> > > Jacopo
> > >
> >
>


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.05

2018-09-22 Thread Rishi Solanki
+1

Thanks!
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Sep 22, 2018 at 4:01 PM Swapnil Mane 
wrote:

> +1
>
>
> - Best Regards,
> Swapnil M Mane
>
> On Fri, Sep 21, 2018 at 7:56 PM Jacopo Cappellato <
> jacopo.cappell...@hotwaxsystems.com> wrote:
>
> >  This is the vote thread to release a new bug fix release for the
> > release16.11 branch. This new release, "Apache OFBiz 16.11.05" will
> > supersede all the previous releases from the same branch.
> >
> > The release files can be downloaded from here:
> >
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> >
> > * apache-ofbiz-16.11.05.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-16.11.05.zip.asc: the detached signature file
> > * apache-ofbiz-16.11.05.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html
> > ).
> >
> > Vote:
> >
> > [ +1] release as Apache OFBiz 16.11.05
> > [ -1] do not release
> >
> > This vote will be open for at least 5 days.
> >
> > For more details about this process please read
> > http://www.apache.org/foundation/voting.html
> >
> > Kind Regards,
> >
> > Jacopo
> >
>


Re: Demo Trunk NPE

2018-09-22 Thread Swapnil Mane
Hi team,

We have already Jira for this [1].

[1] https://issues.apache.org/jira/browse/OFBIZ-10342


- Best Regards,
Swapnil M Mane

On Sat, Sep 22, 2018 at 3:48 PM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Hi Rishi/Mohammad
>
> This looks an intermittent issue as I could not reproduce it. However, in
> webtools, under Fetch Logs, I tried searching for "NullPointer" in the
> error.log file and it did return some instances of NullPointerException.
>
> java.lang.IllegalArgumentException: Error running script at location
> [component://webtools/groovyScripts/service/Services.groovy]:
> java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
> java.lang.IllegalArgumentException: Error running script at location
> [component://webtools/groovyScripts/service/Services.groovy]:
> java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
> java.lang.IllegalArgumentException: Error running script at location
> [component://webtools/groovyScripts/service/Services.groovy]:
> java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
> java.lang.IllegalArgumentException: Error running script at location
> [component://webtools/groovyScripts/service/Services.groovy]:
> java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
> java.lang.IllegalArgumentException: Error running script at location
> [component://webtools/groovyScripts/service/Services.groovy]:
> java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
> java.lang.IllegalArgumentException: Error running script at location
> [component://webtools/groovyScripts/service/Services.groovy]:
> java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
> java.lang.IllegalArgumentException: Error running script at location
> [component://webtools/groovyScripts/service/Services.groovy]:
> java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
> java.lang.IllegalArgumentException: Error running script at location
> [component://webtools/groovyScripts/service/Services.groovy]:
> java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
>
> Best,
> Girish Vasmatkar
> HotWax Systems
>
> On Sat, Sep 22, 2018 at 3:02 PM Mohammad Kathawala <
> mohammad.kathaw...@hotwaxsystems.com> wrote:
>
> > Working for me.
> > Regards*,*
> > *Mohammad Kathawala* | Sr. Technical Consultant
> > *HotWax Commerce* by *HotWax Systems*
> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > Indore,
> > M.P 452010
> > Cell phone: 7772858789
> >
> > HotWax Systems recently received 8 mentions in *The Gartner Digital
> > Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
> > research and advisory company. Learn more about our research here
> > <
> >
> https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html
> > >
> > .
> >
> >
> > On Sat, Sep 22, 2018 at 2:19 PM Rishi Solanki 
> > wrote:
> >
> > > Hello Team,
> > > Browse to Webtools >> Logging >> Service Log on demo trunk returns NPE.
> > >
> > > Quick Reference:
> > > https://demo-trunk.ofbiz.apache.org/webtools/control/ServiceLog
> > >
> > > Not able to replicate it on local setup, anyone face the same issue
> then
> > > please revert back. Will log Jira Ticket for that.
> > >
> > > Regards,
> > > --
> > > Rishi Solanki
> > > Sr Manager, Enterprise Software Development
> > > HotWax Systems Pvt. Ltd.
> > > Direct: +91-9893287847
> > > http://www.hotwaxsystems.com
> > > www.hotwax.co
> > >
> >
>


Re: Shipping data duplicated

2018-09-22 Thread Rishi Solanki
Jacques,
Thanks for more insights.
IMO, we should rename the files as you suggested and also add some
description in the file so that we won't confuse by this in future. And
also we should keep the duplicate data as well, because when ofbizsetup app
set the data for store I assume we don't load the demo data.
About the ofbizsetup app uses, right now I could not think of it. But will
get back on it soon with details and get the inputs from community. For now
my understanding is to rename the setup files and let duplicate data exists
in the setup files.
Let me know if we can proceed with the above plan then will rename the
files and do the needful changes in the setup code. On ofbizsetup app we
will discuss once I come with more details.

Thanks!

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Sep 22, 2018 at 2:10 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Rishi,
>
> Thanks for your feedback.
>
> Looking closely at history, ShippingData.xml was put in 9 years ago with
> http://svn.apache.org/viewvc?view=revision&revision=816083, so for the
> ofbizsetup app, which is a bit weirdo in OFBiz.
>
> Then was modified with OFBIZ-5890 and OFBIZ-7673
>
> Rest inline...
>
>
> Le 22/09/2018 à 09:27, Rishi Solanki a écrit :
> > Hi Jacques,
> > I dig into it today and found that the data exists in the
> > "applications/datamodel/data/demo/OrderDemoData.xml" was moved from
> > "applications/order/data/DemoShipping.xml"
> > Also the data claimed as duplicate in
> > "applications/commonext/data/ShippingData.xml" is similar but not exact
> > matches with OrderDemoData.xml.
> Yes, I was only speaking about "Shipping data", ie:
> ShipmentMethodType
> CarrierShipmentMethod
> QuantityBreak
> ShipmentBoxType
>
> Those are real duplicate
> > The ShippingData.xml  file has no entry in
> > any ofbiz-component.xml.
> Indeed, they are only used by the setup app. In SetupEvents.xml there is
>
> 
>  value="${sys:getProperty('ofbiz.home')}/applications/commonext/data/ShippingData.xml"/>
>
> Reading that, now I think we should not only keep the "Shipping data" in
> ShippingData.xml but also the file. I would rather rename this file and
> other ofbizsetup related files (at least data files) with a Setup prefix
> to clearly signal they are  part of this app.
> But I also wonder if the ofbizsetup app is still alive, maintained and
> used by users. Last time I tried I crossed issues (not biggie IIRW). I
> found
> this https://issues.apache.org/jira/issues/?filter=12344840
>
> What do you think?
>
> Jacques
> >
> > So here we can decide weather we should keep that data in
> ShippingData.xml
> > (if someone introduce the file intentionally) or we can remove it from
> > trunk. In case no objection I would like to remove it as most data is
> > duplicate.
> >
> > --
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> >
> > On Sat, Aug 18, 2018 at 1:17 AM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Thanks Rishi!
> >>
> >> Jacques
> >>
> >>
> >> Le 17/08/2018 à 15:19, Rishi Solanki a écrit :
> >>> This should be part of effort when we were moving all the seed, ext,
> demo
> >>> data to datamodel component. I see there is no entry to load the
> >>> ShippingData.xml.
> >>> I will check this in next week and fix the duplicate data exists in the
> >>> system, or share the the reason of having this.
> >>>
> >>> Probably, data moved but not removed from commonext. But I'll confirm
> and
> >>> get back.
> >>>
> >>> Thanks!
> >>>
> >>>
> >>>
> >>> Rishi Solanki
> >>> Sr Manager, Enterprise Software Development
> >>> HotWax Systems Pvt. Ltd.
> >>> Direct: +91-9893287847
> >>> http://www.hotwaxsystems.com
> >>> www.hotwax.co
> >>>
> >>> On Wed, Aug 15, 2018 at 10:10 PM, Jacques Le Roux <
> >>> jacques.le.r...@les7arts.com> wrote:
> >>>
>  Hi,
> 
>  Is there a reason why Shipping data are now duplicated in trunk at
> 
>    applications/commonext/data/ShippingData.xml
> 
>  and
> 
>    /applications/datamodel/data/demo/OrderDemoData.xml
> 
>  This is not the case with current stable
> 
>  Jacques
> 
> 
> >>
>
>


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.05

2018-09-22 Thread Swapnil Mane
+1


- Best Regards,
Swapnil M Mane

On Fri, Sep 21, 2018 at 7:56 PM Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

>  This is the vote thread to release a new bug fix release for the
> release16.11 branch. This new release, "Apache OFBiz 16.11.05" will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
>
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
>
> * apache-ofbiz-16.11.05.zip
> * KEYS: text file with keys
> * apache-ofbiz-16.11.05.zip.asc: the detached signature file
> * apache-ofbiz-16.11.05.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html
> ).
>
> Vote:
>
> [ +1] release as Apache OFBiz 16.11.05
> [ -1] do not release
>
> This vote will be open for at least 5 days.
>
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
>
> Kind Regards,
>
> Jacopo
>


Re: Demo Trunk NPE

2018-09-22 Thread Girish Vasmatkar
Hi Rishi/Mohammad

This looks an intermittent issue as I could not reproduce it. However, in
webtools, under Fetch Logs, I tried searching for "NullPointer" in the
error.log file and it did return some instances of NullPointerException.

java.lang.IllegalArgumentException: Error running script at location
[component://webtools/groovyScripts/service/Services.groovy]:
java.lang.NullPointerException
Caused by: java.lang.NullPointerException
java.lang.IllegalArgumentException: Error running script at location
[component://webtools/groovyScripts/service/Services.groovy]:
java.lang.NullPointerException
Caused by: java.lang.NullPointerException
java.lang.IllegalArgumentException: Error running script at location
[component://webtools/groovyScripts/service/Services.groovy]:
java.lang.NullPointerException
Caused by: java.lang.NullPointerException
java.lang.IllegalArgumentException: Error running script at location
[component://webtools/groovyScripts/service/Services.groovy]:
java.lang.NullPointerException
Caused by: java.lang.NullPointerException
java.lang.IllegalArgumentException: Error running script at location
[component://webtools/groovyScripts/service/Services.groovy]:
java.lang.NullPointerException
Caused by: java.lang.NullPointerException
java.lang.IllegalArgumentException: Error running script at location
[component://webtools/groovyScripts/service/Services.groovy]:
java.lang.NullPointerException
Caused by: java.lang.NullPointerException
java.lang.IllegalArgumentException: Error running script at location
[component://webtools/groovyScripts/service/Services.groovy]:
java.lang.NullPointerException
Caused by: java.lang.NullPointerException
java.lang.IllegalArgumentException: Error running script at location
[component://webtools/groovyScripts/service/Services.groovy]:
java.lang.NullPointerException
Caused by: java.lang.NullPointerException

Best,
Girish Vasmatkar
HotWax Systems

On Sat, Sep 22, 2018 at 3:02 PM Mohammad Kathawala <
mohammad.kathaw...@hotwaxsystems.com> wrote:

> Working for me.
> Regards*,*
> *Mohammad Kathawala* | Sr. Technical Consultant
> *HotWax Commerce* by *HotWax Systems*
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P 452010
> Cell phone: 7772858789
>
> HotWax Systems recently received 8 mentions in *The Gartner Digital
> Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
> research and advisory company. Learn more about our research here
> <
> https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html
> >
> .
>
>
> On Sat, Sep 22, 2018 at 2:19 PM Rishi Solanki 
> wrote:
>
> > Hello Team,
> > Browse to Webtools >> Logging >> Service Log on demo trunk returns NPE.
> >
> > Quick Reference:
> > https://demo-trunk.ofbiz.apache.org/webtools/control/ServiceLog
> >
> > Not able to replicate it on local setup, anyone face the same issue then
> > please revert back. Will log Jira Ticket for that.
> >
> > Regards,
> > --
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
>


Re: svn commit: r1841664 - /ofbiz/branches/release16.11/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java

2018-09-22 Thread Mathieu Lirzin
Hello Suraj,

sur...@apache.org writes:

> Author: surajk
> Date: Sat Sep 22 09:26:34 2018
> New Revision: 1841664
>
> URL: http://svn.apache.org/viewvc?rev=1841664&view=rev
> Log:
> Fixed: Update regex used for validating credit cards.
> (OFBIZ-9761)
> Thanks Amit Gadaley for providing a patch for 16.11
>
> Modified:
> 
> ofbiz/branches/release16.11/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
>
> Modified: 
> ofbiz/branches/release16.11/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
> URL: 
> http://svn.apache.org/viewvc/ofbiz/branches/release16.11/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java?rev=1841664&r1=1841663&r2=1841664&view=diff
> ==
> --- 
> ofbiz/branches/release16.11/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
>  (original)
> +++ 
> ofbiz/branches/release16.11/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
>  Sat Sep 22 09:26:34 2018
> @@ -1042,14 +1042,14 @@ public final class UtilValidate {
>  
>  /** Checks to see if the cc number is a valid Master Card number
>   *
> - * @param cc a string representing a credit card number; Sample number: 
> 5500   0004(16 digits)
> + * @param cc a string representing a credit card number; MasterCard 
> numbers either start with the numbers 51 through 55 or with the numbers 2221 
> through 2720. All have 16 digits; Sample number: 5500   0004(16 
> digits)
>   * @return true, if the credit card number is a valid MasterCard  
> number, false otherwise
>   */

Next time, please follow OFBiz standards by not adding lines longer than
120 Characters.

Thanks.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37


Re: Demo Trunk NPE

2018-09-22 Thread Mohammad Kathawala
Working for me.
Regards*,*
*Mohammad Kathawala* | Sr. Technical Consultant
*HotWax Commerce* by *HotWax Systems*
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Cell phone: 7772858789

HotWax Systems recently received 8 mentions in *The Gartner Digital
Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
research and advisory company. Learn more about our research here

.


On Sat, Sep 22, 2018 at 2:19 PM Rishi Solanki 
wrote:

> Hello Team,
> Browse to Webtools >> Logging >> Service Log on demo trunk returns NPE.
>
> Quick Reference:
> https://demo-trunk.ofbiz.apache.org/webtools/control/ServiceLog
>
> Not able to replicate it on local setup, anyone face the same issue then
> please revert back. Will log Jira Ticket for that.
>
> Regards,
> --
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>


Demo Trunk NPE

2018-09-22 Thread Rishi Solanki
Hello Team,
Browse to Webtools >> Logging >> Service Log on demo trunk returns NPE.

Quick Reference:
https://demo-trunk.ofbiz.apache.org/webtools/control/ServiceLog

Not able to replicate it on local setup, anyone face the same issue then
please revert back. Will log Jira Ticket for that.

Regards,
--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


Re: Shipping data duplicated

2018-09-22 Thread Jacques Le Roux

Hi Rishi,

Thanks for your feedback.

Looking closely at history, ShippingData.xml was put in 9 years ago with http://svn.apache.org/viewvc?view=revision&revision=816083, so for the 
ofbizsetup app, which is a bit weirdo in OFBiz.


Then was modified with OFBIZ-5890 and OFBIZ-7673

Rest inline...


Le 22/09/2018 à 09:27, Rishi Solanki a écrit :

Hi Jacques,
I dig into it today and found that the data exists in the
"applications/datamodel/data/demo/OrderDemoData.xml" was moved from
"applications/order/data/DemoShipping.xml"
Also the data claimed as duplicate in
"applications/commonext/data/ShippingData.xml" is similar but not exact
matches with OrderDemoData.xml.

Yes, I was only speaking about "Shipping data", ie:
ShipmentMethodType
CarrierShipmentMethod
QuantityBreak
ShipmentBoxType

Those are real duplicate

The ShippingData.xml  file has no entry in
any ofbiz-component.xml.

Indeed, they are only used by the setup app. In SetupEvents.xml there is

   
   

Reading that, now I think we should not only keep the "Shipping data" in  ShippingData.xml but also the file. I would rather rename this file and 
other ofbizsetup related files (at least data files) with a Setup prefix to clearly signal they are  part of this app.
But I also wonder if the ofbizsetup app is still alive, maintained and used by users. Last time I tried I crossed issues (not biggie IIRW). I found 
this https://issues.apache.org/jira/issues/?filter=12344840


What do you think?

Jacques


So here we can decide weather we should keep that data in ShippingData.xml
(if someone introduce the file intentionally) or we can remove it from
trunk. In case no objection I would like to remove it as most data is
duplicate.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Aug 18, 2018 at 1:17 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Thanks Rishi!

Jacques


Le 17/08/2018 à 15:19, Rishi Solanki a écrit :

This should be part of effort when we were moving all the seed, ext, demo
data to datamodel component. I see there is no entry to load the
ShippingData.xml.
I will check this in next week and fix the duplicate data exists in the
system, or share the the reason of having this.

Probably, data moved but not removed from commonext. But I'll confirm and
get back.

Thanks!



Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Wed, Aug 15, 2018 at 10:10 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Hi,

Is there a reason why Shipping data are now duplicated in trunk at

  applications/commonext/data/ShippingData.xml

and

  /applications/datamodel/data/demo/OrderDemoData.xml

This is not the case with current stable

Jacques








Re: Shipping data duplicated

2018-09-22 Thread Rishi Solanki
Hi Jacques,
I dig into it today and found that the data exists in the
"applications/datamodel/data/demo/OrderDemoData.xml" was moved from
"applications/order/data/DemoShipping.xml"
Also the data claimed as duplicate in
"applications/commonext/data/ShippingData.xml" is similar but not exact
matches with OrderDemoData.xml. The ShippingData.xml  file has no entry in
any ofbiz-component.xml.

So here we can decide weather we should keep that data in ShippingData.xml
(if someone introduce the file intentionally) or we can remove it from
trunk. In case no objection I would like to remove it as most data is
duplicate.

--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Sat, Aug 18, 2018 at 1:17 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Rishi!
>
> Jacques
>
>
> Le 17/08/2018 à 15:19, Rishi Solanki a écrit :
> > This should be part of effort when we were moving all the seed, ext, demo
> > data to datamodel component. I see there is no entry to load the
> > ShippingData.xml.
> > I will check this in next week and fix the duplicate data exists in the
> > system, or share the the reason of having this.
> >
> > Probably, data moved but not removed from commonext. But I'll confirm and
> > get back.
> >
> > Thanks!
> >
> >
> >
> > Rishi Solanki
> > Sr Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> > www.hotwax.co
> >
> > On Wed, Aug 15, 2018 at 10:10 PM, Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Hi,
> >>
> >> Is there a reason why Shipping data are now duplicated in trunk at
> >>
> >>  applications/commonext/data/ShippingData.xml
> >>
> >> and
> >>
> >>  /applications/datamodel/data/demo/OrderDemoData.xml
> >>
> >> This is not the case with current stable
> >>
> >> Jacques
> >>
> >>
>
>


Issue: Additional shipping charge editable on shipment even after shipment is packed and invoice is generated

2018-09-22 Thread Mohammad Kathawala
Hello Devs,

I need to confirm if the following scenario is valid or not:
At the time of packing an order, an additional shipping charge can be added
from the packing screen which is stored in the shipment entity.
When package/s are completed, the shipment is marked as packed and an
invoice is generated for the order in ready for posting status. Also, an
invoice line item is created from the additional shipping charge added in
the shipment. Now, since the invoice is in ready for posting status, it
cannot be edited. But, the additional shipping charge on the shipment is
still editable. Is this a valid scenario?

My second concern is if someone has entered wrong shipping charge at the
time of packing then how can it be corrected since the invoice gets
generated as soon as shipment is packed.

Thanks.
Regards*,*
*Mohammad Kathawala* | Sr. Technical Consultant
*HotWax Commerce* by *HotWax Systems*
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Cell phone: 7772858789

HotWax Systems recently received 8 mentions in *The Gartner Digital
Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
research and advisory company. Learn more about our research here

.