Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Gil Portenseigne
Hello Pierre, If you are talking about impersonation feature, that is not in the 17.12 branch. In either way, administrative tools, if we got access to it, allow what your are saying. But there is no security issue that grant these privilege we are aware of. If you do, please share to the

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Swapnil M Mane
+1 Best regards, Swapnil M Mane, ofbiz.apache.org On Thu, Feb 27, 2020 at 3:20 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the vote thread (3nd attempt) to release "Apache OFBiz 17.12.01": > this is the first release, containing the framework, applications and all >

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana www.hotwax.co On Thu, Feb 27, 2020 at 3:20 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the vote thread (3nd attempt) to release "Apache OFBiz 17.12.01": > this is the first release, containing the framework, applications and all > the

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Pawan Verma
+1 -- Thanks & Regards Pawan Verma On Fri, Feb 28, 2020 at 7:30 AM Pierre Smits wrote: > And/or contains elements that provide criminal parties information to > impersonate valid users. > > Met vriendelijke groet, > > Pierre Smits > *Proud* *contributor** of* Apache OFBiz

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Pierre Smits
And/or contains elements that provide criminal parties information to impersonate valid users. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion , Vice

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Pierre Smits
-1 As this release contains software elements that will enable criminal parties to gain access to the implemented OFBiz system of a user (a business organisation) and impersonate valid users with the intent to bring harm to the aforementioned business organisation through transactions registered

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Nicola Mazzoni
+1 Il gio 27 feb 2020, 18:40 Jacques Le Roux ha scritto: > +1 > > Jacques > > Le 27/02/2020 à 18:09, Michael Brohl a écrit : > > +1 > > > > ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01  > ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.01.zip > > sha check of file:

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Jacques Le Roux
+1 Jacques Le 27/02/2020 à 18:09, Michael Brohl a écrit : +1 ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01  ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.01.zip sha check of file: apache-ofbiz-17.12.01.zip Using sha file: apache-ofbiz-17.12.01.zip.sha512

Re: OFBiz and WooCommerce

2020-02-27 Thread Jacques Le Roux
Hi Prisca, Your message has been moderated. Please subscribe to the user ML for such questions and then use your email client. See why here http://ofbiz.apache.org/mailing-lists.html. You will get a better support, people can answer you on the ML. The wider the audience the better the

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Michael Brohl
+1 ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01  ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.01.zip sha check of file: apache-ofbiz-17.12.01.zip Using sha file: apache-ofbiz-17.12.01.zip.sha512 apache-ofbiz-17.12.01.zip: 3E92DF0F 92E71B33 0FEF2B7C FBEE2E51 88F98E3B

Re: [ofbiz-framework] branch trunk updated: Improved: Convert ProductServices.xml mini lang to groovy (OFBIZ-10231)

2020-02-27 Thread Michael Brohl
Hi Nicolas, great, thanks for reviewing and improving the code! Please go ahead and commit, thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 27.02.20 um 16:22 schrieb Nicolas Malin: Michael, I have lot of improvement to share with your commit (groovy syntax, code simplification) Do

Re: [TEST] Test "POC for CSRF Token"

2020-02-27 Thread Jacques Le Roux
Forgot to say that w/ or w/o test I'll commit in 1 month... Jacques Le 27/02/2020 à 15:08, Jacques Le Roux a écrit : Hi, After working with James, who initiated the "POC for CSRF Token" effort, on https://issues.apache.org/jira/browse/OFBIZ-11306 I have created OFBIZ-11425 to ask for all

OFBiz and WooCommerce

2020-02-27 Thread UP Digital Studio
Hello, I’m a web developer and I’m currently building an e-commerce website using WooCommerce+WordPress. I’m writing on behalf of my client who is willing to have an ERP connected to the website. She’s hesitating with Dolibarr and OFBiz. We’d like to know if OFbiz could work with WooCommerce

Re: [ofbiz-framework] branch trunk updated: Improved: Convert ProductServices.xml mini lang to groovy (OFBIZ-10231)

2020-02-27 Thread Nicolas Malin
Michael, I have lot of improvement to share with your commit (groovy syntax, code simplification) Do you prefer keep the hand, or I commit directly ? You can find some diff on my starting work here  [1] Cheers, Nicolas [1]

Re: [DISCUSSION] Should we clean labels?

2020-02-27 Thread Jacques Le Roux
Weird, I don't get it as you can check at https://issues.apache.org/jira/secure/attachment/12994793/OFBIZ-9352-not-used.png Jacques Le 27/02/2020 à 15:03, Michael Brohl a écrit : Jacques, I know and used this feature on demo-trunk. If you select the AccountingUiLabels.xml and search for

Re: [DISCUSSION] Should we clean labels?

2020-02-27 Thread Michael Brohl
Saying is not proving IMO. The contributor should at least provide information *how* he did the checks along with the patch to help the committer decide. That is very reasonable to ask for. Low hanging fruits can also be foul. It does not help anyone to commit a patch to remove labels and

[TEST] Test "POC for CSRF Token"

2020-02-27 Thread Jacques Le Roux
Hi, After working with James, who initiated the "POC for CSRF Token" effort, on https://issues.apache.org/jira/browse/OFBIZ-11306 I have created OFBIZ-11425 to ask for all possible help to review and test. TIA Jacques

Re: [DISCUSSION] Should we clean labels?

2020-02-27 Thread Michael Brohl
Jacques, I know and used this feature on demo-trunk. If you select the AccountingUiLabels.xml and search for unused labels, you get AccountingDeleteRateAmount among others. Using a find for *all* files with the unused labels checkbox did not display any results for me. Did not dig further

Re: [DISCUSSION] Should we clean labels?

2020-02-27 Thread Jacques Le Roux
Michael, Inline, Le 27/02/2020 à 13:35, Michael Brohl a écrit : You simply cannot rely on the LabelManager itself. It shows unused labels which are used [1]. Example: AccountingErrorUiLabels.xml#AccountingDeleteRateAmount is shown as unused on demo-trunk but is used in RateServices.groovy.

Re: [DISCUSSION] Should we clean labels?

2020-02-27 Thread Pierre Smits
Re: IMO this check cannot be burdened upon the committer (if another contributor provided the patch).The responsibility to thoroughly check if a removed label is in fact unused should be on the contributor. Which means he should prove which steps he took to check each removed label [2]. We can

Re: [DISCUSSION] Should we clean labels?

2020-02-27 Thread Pierre Smits
Whatever the participation and the outcome of this discussion will be... In the past complaints (relating to the subject of labels) have been raised about: - patches too big (because of too much work to investigate, merges leading to conflicts in local repos), and - patches too small

Re: [DISCUSSION] Should we clean labels?

2020-02-27 Thread Pierre Smits
Given that the OFBiz community consists of more than just a handful of active PMC Members, Committers and other contributors, the question should *not* just be: Should we clean labels'. But rather: Should we welcome contributions that only address the cleaning of unused labels, and if so get them

Re: [DISCUSSION] Should we clean labels?

2020-02-27 Thread Michael Brohl
You simply cannot rely on the LabelManager itself. It shows unused labels which are used [1]. Example: AccountingErrorUiLabels.xml#AccountingDeleteRateAmount is shown as unused on demo-trunk but is used in RateServices.groovy. So steps 1 and 2 are necessary because changes should not

[DISCUSSION] Should we clean labels?

2020-02-27 Thread Jacques Le Roux
Hi, With OFBIZ-9352 (under OFBIZ-10565) Pierre Smits propose to remove unused labels from AccountingUiLabels.xml This morning I looked at the related PR (17) and, using Label Manager (in Webtools) found that there are much more unused labels than those Pierre proposes to remove. I checked

Re: [apache/ofbiz-framework] OFBIZ-10565 Removing unused UI labels (#17)

2020-02-27 Thread Pierre Smits
Jacques, all, I am confident there are way more labels unused across the total of components in both the base and the plugins repository than the number you mentioned. And typos, and pieces of code not used. That should not lead to *not* merging cleanups as they are presented. Some of your peers

[VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Jacopo Cappellato
This is the vote thread (3nd attempt) to release "Apache OFBiz 17.12.01": this is the first release, containing the framework, applications and all the plugins from the 17.12 release branches. The release files can be downloaded from here: https://dist.apache.org/repos/dist/dev/ofbiz/ and are: *

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Pierre Smits
Good advice, Michael. But that don't always happen. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion , Vice President* *Apache Directory

Fwd: [apache/ofbiz-framework] OFBIZ-10565 Removing unused UI labels (#17)

2020-02-27 Thread Pierre Smits
Jacques, Be happy with what you got! I would not want to burden you (or others) with patches too large to check. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Michael Brohl
Every Git PR also needs a Jira, for which the notifications go to the notifications mailing list. If people want to contribute and follow, they should subscribe to notifications. Maybe we should send a reminder and encourage them to do so instead of mixing notifications and dev again.

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Suraj Khurana
+1 to move these git notifications. We can use notificati...@ofbiz.apache.org for sure, at the same time, we can have a separate list, if required. -- Best Regards, Suraj Khurana www.hotwax.co On Thu, Feb 27, 2020 at 1:48 PM Swapnil M Mane wrote: > Hi team, > Should we move these Git

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Deepak Dixit
+1 Swapnil Thanks & Regards -- Deepak Dixit ofbiz.apache.org On Thu, Feb 27, 2020 at 1:48 PM Swapnil M Mane wrote: > Hi team, > Should we move these Git notification to notificati...@ofbiz.apache.org > list [1] that we created in the past to avoid notification traffic on dev > list, thoughts?

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Pierre Smits
With modern day mail clients people can filter what and however they like. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion , Vice President* *Apache Directory

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Pierre Smits
With the great difference between the numbers of subscribers of dev@ and notifications@ (last time I checked notifications@ had around 50), I advise against it. If we want more people to contribute we need more than just the handful of active committers/contributors and employees of system

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #2

2020-02-27 Thread Michael Brohl
Hi Jacopo, ok to proceed from my side. We should move the open 17.12.01 issues to 17.12.02 then. Thanks, Michael Am 27.02.20 um 09:21 schrieb Jacopo Cappellato: Hi Michael, all, please ping me when you want me to prepare the dist files for the new vote. Thanks, Jacopo On Tue, Feb 25,

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Michael Brohl
+1, Thanks Swapnil! Michael Am 27.02.20 um 09:17 schrieb Swapnil M Mane: Hi team, Should we move these Git notification to notificati...@ofbiz.apache.org list [1] that we created in the past to avoid notification traffic on dev list, thoughts? [1] https://s.apache.org/0jdhc Best regards,

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Jacques Le Roux
Hi Swapnil, Makes sense to me Jacques Le 27/02/2020 à 09:17, Swapnil M Mane a écrit : Hi team, Should we move these Git notification to notificati...@ofbiz.apache.org list [1] that we created in the past to avoid notification traffic on dev list, thoughts? [1] https://s.apache.org/0jdhc

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #2

2020-02-27 Thread Jacopo Cappellato
Hi Michael, all, please ping me when you want me to prepare the dist files for the new vote. Thanks, Jacopo On Tue, Feb 25, 2020 at 1:24 PM Michael Brohl wrote: > We should wait with the preparation of a new dist at least until > tomorrow, the Community Days will end today and I am planning

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Swapnil M Mane
Hi team, Should we move these Git notification to notificati...@ofbiz.apache.org list [1] that we created in the past to avoid notification traffic on dev list, thoughts? [1] https://s.apache.org/0jdhc Best regards, Swapnil M Mane, ofbiz.apache.org On Wed, Feb 26, 2020 at 3:24 PM GitBox