Re: Themes components should be loaded after the applications

2009-02-23 Thread David E Jones
/ load-components parent-directory=specialpurpose/ load-components parent-directory=themes/ load-components parent-directory=hot-deploy/ /component-loader Thank you, Bruno 2009/2/22 David E Jones david.jo...@hotwaxmedia.com: It sounds like there is some sort of conflict between the theme

Re: svn commit: r748144 - in /ofbiz/trunk: applications/ applications/accounting/widget/ applications/accounting/widget/ap/ applications/accounting/widget/ar/ applications/applicationext/ applications

2009-02-26 Thread David E Jones
Yeah, something like appcommon or commonext would be clear and consistent with stuff. Thanks for getting this started Hans. -David On Feb 26, 2009, at 10:15 AM, Adrian Crum wrote: In previous discussions, appcommon was used. -Adrian Jacques Le Roux wrote: I thought that, for the sake

[jira] Commented: (OFBIZ-2201) Theme component should be loaded after applications component

2009-02-26 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677221#action_12677221 ] David E. Jones commented on OFBIZ-2201: --- Don't worry too much about something

Re: svn commit: r748683 - in /ofbiz/trunk/applications: content/entitydef/entitymodel.xml order/entitydef/entitymodel.xml party/entitydef/entitymodel.xml

2009-02-27 Thread David E Jones
Are the entity field labels actually used for all of these entities? Generally this feature ONLY makes sense for things that are part of seed data, things that may be entered by users should use other patterns for i18n. The suspect entities that are included here include: - Content (has

[jira] Commented: (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

2009-02-28 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677729#action_12677729 ] David E. Jones commented on OFBIZ-2208: --- Karim: could you verify that you are using

Re: svn commit: r748683 - in /ofbiz/trunk/applications: content/entitydef/entitymodel.xml order/entitydef/entitymodel.xml party/entitydef/entitymodel.xml

2009-02-28 Thread David E Jones
of it ? Thanks Marco Il giorno 27/feb/09, alle ore 22:29, David E Jones ha scritto: Are the entity field labels actually used for all of these entities? Generally this feature ONLY makes sense for things that are part of seed data, things that may be entered by users should use other patterns for i18n

[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-04 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678685#action_12678685 ] David E. Jones commented on OFBIZ-2227: --- BJ: This issue is about CC capture

Re: svn commit: r750296 - in /ofbiz/trunk/framework/testtools: dtd/test-suite.xsd src/org/ofbiz/testtools/ModelTestSuite.java src/org/ofbiz/testtools/TestListContainer.java

2009-03-04 Thread David E Jones
Why not just use different test-suite elements for this? Why have an hierarchy in this? Actually... I'm not even sure what this is, ie what is the point of a group? Maybe we should discuss that first... -David On Mar 4, 2009, at 7:40 PM, doo...@apache.org wrote: Author: doogie Date:

Test Practices and Patterns (was Re: svn commit: r750296 - in /ofbiz/trunk/framework/testtools: dtd/test-suite.xsd src/org/ofbiz/testtools/ModelTestSuite.java src/org/ofbiz/testtools/TestListContainer

2009-03-04 Thread David E Jones
On Mar 4, 2009, at 8:03 PM, Adam Heath wrote: David E Jones wrote: Why not just use different test-suite elements for this? Why have an hierarchy in this? Actually... I'm not even sure what this is, ie what is the point of a group? Maybe we should discuss that first... The service

Re: Test Practices and Patterns (was Re: svn commit: r750296 - in /ofbiz/trunk/framework/testtools: dtd/test-suite.xsd src/org/ofbiz/testtools/ModelTestSuite.java src/org/ofbiz/testtools/TestListConta

2009-03-04 Thread David E Jones
*** First off Adam: it's great to see you working on this stuff, the testing stuff in general needs a LOT more work and hasn't seen much attention, so yeah... this is great. On Mar 4, 2009, at 9:25 PM, Adam Heath wrote: The service engine tests define several different test cases. The

[jira] Commented: (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

2009-03-05 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679215#action_12679215 ] David E. Jones commented on OFBIZ-2208: --- This patches substantially changes an entity

Re: svn commit: r749959 - in /ofbiz/trunk: applications/ecommerce/webapp/ecommerce/WEB-INF/ framework/common/webcommon/WEB-INF/ framework/common/webcommon/includes/ framework/webapp/dtd/ framework/web

2009-03-05 Thread David E Jones
I wrote this stuff and what you wrote still doesn't make any sense to me... Are you saying this is an issue with the latest version? Are you using the second commit which fixed these issues or are you saying that somehow you don't want to use that and we should fix it in a different

Re: svn commit: r749959 - in /ofbiz/trunk: applications/ecommerce/webapp/ecommerce/WEB-INF/ framework/common/webcommon/WEB-INF/ framework/common/webcommon/includes/ framework/webapp/dtd/ framework/web

2009-03-05 Thread David E Jones
On Mar 5, 2009, at 11:35 AM, David E Jones wrote: I wrote this stuff and what you wrote still doesn't make any sense to me... Are you saying this is an issue with the latest version? Are you using the second commit which fixed these issues or are you saying that somehow you don't want to use

Cross-Site Request Forging (XSRF)

2009-03-05 Thread David E Jones
I've been thinking more about the XSRF problem and what we can do to make OFBiz more secure from this sort of attack. This is related to OFBIZ-1959 and there is more discussion and introduction to it there. The trick is that we want to allow certain things: 1. the client's IP address can

[jira] Commented: (OFBIZ-1235) Create the theme for the form widget

2009-03-05 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679502#action_12679502 ] David E. Jones commented on OFBIZ-1235: --- You might want to wait until Jacopo posts

Re: Cross-Site Request Forging (XSRF)

2009-03-05 Thread David E Jones
Yes, AJAX calls are an interesting point... If AJAX requests used the random token even a single call would reset the token and break things. If they did not use the random token they are a gaping security hole. I don't think we're going to do the random token thing, unless someone

Re: svn commit: r750878 - in /ofbiz/trunk: applications/product/webapp/catalog/WEB-INF/controller.xml applications/product/webapp/catalog/product/ProductForms.xml framework/webapp/src/org/ofbiz/webapp

2009-03-06 Thread David E Jones
Please revert this patch: 1. the ServiceVariantEventHandler is in the framework and is dependent on the applications/product component 2. creating an event handler for this is pure silliness in the first place and should simply be done with a custom event -David On Mar 6, 2009, at

Re: svn commit: r750799 - in /ofbiz/trunk/framework: common/data/CommonTypeData.xml webtools/webapp/webtools/WEB-INF/web.xml

2009-03-06 Thread David E Jones
I looks like it comes from the original one in the ecommerce web.xml file. -David On Mar 6, 2009, at 9:21 AM, Jacques Le Roux wrote: Mmm, it seems that there is much more than that : 29 occurrences of the same string in OFBiz, not sure all are correct... descriptionA unique ID used to

Re: svn commit: r750799 - in /ofbiz/trunk/framework: common/data/CommonTypeData.xml webtools/webapp/webtools/WEB-INF/web.xml

2009-03-06 Thread David E Jones
the WebSite entity/ description If you are OK I will update it. -Bruno 2009/3/6 David E Jones david.jo...@hotwaxmedia.com: I looks like it comes from the original one in the ecommerce web.xml file. -David On Mar 6, 2009, at 9:21 AM, Jacques Le Roux wrote: Mmm, it seems

[jira] Commented: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679756#action_12679756 ] David E. Jones commented on OFBIZ-2231: --- What does this have to do with encoding

[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-06 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679794#action_12679794 ] David E. Jones commented on OFBIZ-2227: --- When you're working on this make sure you

Re: how to write a test case

2009-03-07 Thread David E Jones
I'm still for running tests as a set for each suite. If you disagree with me, take a look at some of the current test suite XML files and explain to me how it makes sense, or is even possible, to run most of them with 100% independent tests. You can't even load or assert data if you run

Re: how to write a test case

2009-03-07 Thread David E Jones
this is just my ignorance on this particular data setup or if my assumptions above are incorrect. Cheers, Tim -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 - David E Jones david.jo...@hotwaxmedia.com wrote: I'm still for running tests as a set for each

[jira] Commented: (OFBIZ-2220) Add new field for Cancel Back Orders Date, like others for OrderItem. Show these on Purchase order PDF.

2009-03-08 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679987#action_12679987 ] David E. Jones commented on OFBIZ-2220: --- Why do you say it is misleading

Re: Cross-Site Request Forging (XSRF)

2009-03-08 Thread David E Jones
On Mar 5, 2009, at 2:55 PM, David E Jones wrote: One thing that we could do to help with this problem, at least for secure pages, is to tighten things up a bit. I'm thinking of 2 things: 1. if a request has https=true then we will not accept http requests AT ALL, we will just return

[jira] Commented: (OFBIZ-2186) OutOfMemory provoked by Cache overflow

2009-03-08 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680011#action_12680011 ] David E. Jones commented on OFBIZ-2186: --- What are the 2 different objects? I

[jira] Commented: (OFBIZ-2186) OutOfMemory provoked by Cache overflow

2009-03-09 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680088#action_12680088 ] David E. Jones commented on OFBIZ-2186: --- Thank you for the additional information

[jira] Commented: (OFBIZ-2233) If Inventory Mover finds needed inventory in another location then he can do a quick Stock Move for that inventory from the higher shelf to the main pick location

2009-03-09 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680331#action_12680331 ] David E. Jones commented on OFBIZ-2233: --- This patch does not do what is described

Re: Unable to change VisualTheme (security)

2009-03-10 Thread David E Jones
This is one of the new security constraints that we were discussing over the last week. All data going into secure requests should be in the body so it is actually secure, and NOT in the URL where it is not encrypted. This is a good general practice, and now we're playing with enforcing

Re: Unable to change VisualTheme (security)

2009-03-10 Thread David E Jones
I did write some message and sent them to this list, one to propose these changes and another to communicate that they were in place... :) Of course, now that people are seeing the downside to security, maybe opinions won't be so in favor of it? ;) -David On Mar 10, 2009, at 4:28 PM,

Re: Unable to change VisualTheme (security)

2009-03-10 Thread David E Jones
is working again but...how people was able to change the theme? I tried to use party/visits and webtools/logs in order to discover the hack but no way. I would be interesting to know how to track the user activity that took to this. How to? -Bruno 2009/3/10 David E Jones david.jo...@hotwaxmedia.com: I

Re: Unable to change VisualTheme (security)

2009-03-10 Thread David E Jones
with it. I wasn't sure what to do about it. Your other reply was helpful. -Adrian David E Jones wrote: I did write some message and sent them to this list, one to propose these changes and another to communicate that they were in place... :) Of course, now that people are seeing

Re: Unable to change VisualTheme (security)

2009-03-11 Thread David E Jones
think we'll need to introduce a new field type, like a form-backed link that we can use instead of the hyperlink field type that we currently use to pass parameters in the URL. -David On Mar 10, 2009, at 11:38 PM, David E Jones wrote: Actually, I'm starting to wonder if we should revert

Re: Unable to change VisualTheme (security)

2009-03-11 Thread David E Jones
On Mar 11, 2009, at 4:53 AM, Bilgin Ibryam wrote: On Mar 11, 2009, at 9:43 AM, David E Jones wrote: So, until then... To get there with the form widget I think we'll need to introduce a new field type, like a form-backed link that we can use instead of the hyperlink field type that we

[jira] Closed: (OFBIZ-2238) mount-point=/ results in the disappearing of the hostname in the URL's of categories, products, etc.

2009-03-12 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David E. Jones closed OFBIZ-2238. - Resolution: Fixed Fix Version/s: SVN trunk Assignee: David E. Jones Thanks

Moving ecommerce to specialpurpose

2009-03-13 Thread David E Jones
This was discussed a while back around the time that specialpurpose was introduce, and pos and other things were moved there, but we decided on not doing it at the time because of concerns about non- backward-compatible impact. Since we are getting ready to do a release branch, probably

Board Report Mar 2009

2009-03-13 Thread David E Jones
I wrote an early rough draft for the Board Report for Mar 2009. It is available here: http://docs.ofbiz.org/display/OFBADMIN/ASF+Board+Report+2009-03 This is not finalized yet and there are a couple of days left before I have to submit it, so please send comments and thoughts to make it

Re: Board Report Mar 2009

2009-03-13 Thread David E Jones
Bakker wrote: You might want to mention the issue i raised about the Apache infrastructure: https://issues.apache.org/jira/browse/INFRA-1877 On Fri, 2009-03-13 at 00:57 -0600, David E Jones wrote: I wrote an early rough draft for the Board Report for Mar 2009. It is available here: http

Re: Board Report Mar 2009

2009-03-13 Thread David E Jones
...@ofbiz.apache.org list on Jan25. My intention was to first move and then change the installation to what we wanted. At that time i did not see any problems from our end. Do we have them now? Regards, Hans On Fri, 2009-03-13 at 01:38 -0600, David E Jones wrote: That's an interesting link

Re: Board Report Mar 2009

2009-03-13 Thread David E Jones
On Mar 13, 2009, at 1:35 PM, Adam Heath wrote: Adam Heath wrote: David E Jones wrote: I wrote an early rough draft for the Board Report for Mar 2009. It is available here: http://docs.ofbiz.org/display/OFBADMIN/ASF+Board+Report+2009-03 This is not finalized yet and there are a couple

Re: Moving ecommerce to specialpurpose

2009-03-14 Thread David E Jones
Okay, this is now moved... -David On Mar 13, 2009, at 12:56 AM, David E Jones wrote: This was discussed a while back around the time that specialpurpose was introduce, and pos and other things were moved there, but we decided on not doing it at the time because of concerns about non

More Security: Hidden forms instead of links in the form widget

2009-03-15 Thread David E Jones
I have implemented an improvement to the form widget (still needs introduction in other places in the form and other widgets). For an example see the UpdateProductPrice form in the ProductForms.xml file, namely the deleteLink field which now looks like this: field name=deleteLink

Re: svn commit: r754657 - /ofbiz/trunk/applications/party/entitydef/entitymodel.xml

2009-03-15 Thread David E Jones
On Mar 15, 2009, at 7:09 AM, Hans Bakker wrote: I am sorry but i do not agree with this. The roleTypes on a communication event is a big problem. did you ever send an email stating you are a customer or an employee? You do however know if you are the originator and which parties you

CommunicationEvent and Role (was: Re: svn commit: r754657 - /ofbiz/trunk/applications/party/entitydef/entitymodel.xml)

2009-03-15 Thread David E Jones
to come up with requirements for this data model (only saying this or that design is the way to go)... there it is. -David On Mar 15, 2009, at 11:57 AM, David E Jones wrote: On Mar 15, 2009, at 7:09 AM, Hans Bakker wrote: I am sorry but i do not agree with this. The roleTypes

Re: Unable to change VisualTheme (security)

2009-03-15 Thread David E Jones
On Mar 11, 2009, at 10:52 AM, David E Jones wrote: On Mar 11, 2009, at 4:53 AM, Bilgin Ibryam wrote: On Mar 11, 2009, at 9:43 AM, David E Jones wrote: So, until then... To get there with the form widget I think we'll need to introduce a new field type, like a form-backed link that we

Re: CommunicationEvent and Role (was: Re: svn commit: r754657 - /ofbiz/trunk/applications/party/entitydef/entitymodel.xml)

2009-03-16 Thread David E Jones
? so finally Jacques succeeded to get this slowly resolved :-) Regards, Hans On Sun, 2009-03-15 at 12:04 -0600, David E Jones wrote: Since we seem to be back to this issue... What you're saying Hans is an over-simplification of the issue as I explained before. If you want to properly model

Re: Unable to change VisualTheme (security)

2009-03-16 Thread David E Jones
On Mar 16, 2009, at 3:03 AM, Bilgin Ibryam wrote: I haven't implemented this in the screen widget or in the menu or tree widgets yet either. Actually, after implementing it for the sub-hyperlink element in the form widget I couldn't find any places where a request that calls a service was

Re: More Security: Hidden forms instead of links in the form widget

2009-03-17 Thread David E Jones
On Mar 17, 2009, at 5:59 AM, Bilgin Ibryam wrote: On Mar 15, 2009, at 11:30 AM, David E Jones wrote: In short all of the hyperlink fields need to be updated with these two changes. As soon as the framework is extended so that this is supported for the sub-hyperlink element in the form

[jira] Commented: (OFBIZ-2243) In hyperlink element, replacement of target parameters by link-type=hidden-form and parameter sub-elements

2009-03-17 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682724#action_12682724 ] David E. Jones commented on OFBIZ-2243: --- As a follow-up to the mailing list comment

[jira] Commented: (OFBIZ-2243) In hyperlink element, replacement of target parameters by link-type=hidden-form and parameter sub-elements

2009-03-17 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682749#action_12682749 ] David E. Jones commented on OFBIZ-2243: --- Yes, I agree Adam. One trend I've been

[jira] Commented: (OFBIZ-2243) In hyperlink element, replacement of target parameters by link-type=hidden-form and parameter sub-elements

2009-03-17 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682753#action_12682753 ] David E. Jones commented on OFBIZ-2243: --- Adrian: you're right that this could

[jira] Commented: (OFBIZ-2243) In hyperlink element, replacement of target parameters by link-type=hidden-form and parameter sub-elements

2009-03-17 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682778#action_12682778 ] David E. Jones commented on OFBIZ-2243: --- Okay, done in SVN rev 755377. In hyperlink

Re: Override events

2009-03-17 Thread David E Jones
On Mar 17, 2009, at 9:08 AM, Bilgin Ibryam wrote: On Mar 17, 2009, at 4:31 PM, Adrian Crum wrote: It would be better to fix the Java code that reads the XML files so this doesn't happen. Yes thats true, but I still think we need also a way for overriding the events as it is with

[jira] Commented: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-18 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682943#action_12682943 ] David E. Jones commented on OFBIZ-2231: --- Jacques: if you're going to have a look

[jira] Closed: (OFBIZ-2244) Enable the use of component:// style URL pattern for map processor

2009-03-18 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David E. Jones closed OFBIZ-2244. - Resolution: Fixed Fix Version/s: SVN trunk Thanks Ashish, this looks good and is in SVN

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

2009-03-18 Thread David E Jones
This would be great to have done before the release. It would allow us to get a LOT of stuff off the classpath, which can be a painful part of deployment. -David On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote: I had a closer look service

Re: understanding the Ofbiz framework

2009-03-18 Thread David E Jones
My personal favorite (I am admittedly biased), including diagrams and videos, is: http://docs.ofbiz.org/display/OFBTECH/Framework+Introduction+Videos+and+Diagrams More generally a good read through this page and the documents it links to will help you a lot:

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

2009-03-19 Thread David E Jones
path=org/ofbiz/ecommerce/customer/ CustomerEvents.xml invoke=processCustomerSettings/ WDYT ? -- Ashish Jacques Le Roux wrote: Done at revision: 755977 Jacques From: David E Jones david.jo...@hotwaxmedia.com This would be great to have done before the release. It would allow us to get

Re: Why never-cache on OrderHeader and OrderItem?

2009-03-19 Thread David E Jones
On Mar 19, 2009, at 3:04 PM, Adam Heath wrote: David E Jones wrote: Stepping back a little, why do you want to cache data from those entities? Two steps forward, one step back Why would you *not* want to? Sorry, I asked first and I want to hear someone's understand of when it's

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

2009-03-19 Thread David E Jones
On Mar 19, 2009, at 3:06 PM, Adam Heath wrote: David E Jones wrote: It should be supported now, but yeah it would be a good idea to test it before doing a mass change. And yes, a mass change there would be great too. Once those are done we could probably remove the ${component-dir

Re: Why never-cache on OrderHeader and OrderItem?

2009-03-19 Thread David E Jones
On Mar 19, 2009, at 7:03 PM, Adam Heath wrote: David E Jones wrote: On Mar 19, 2009, at 3:04 PM, Adam Heath wrote: David E Jones wrote: Stepping back a little, why do you want to cache data from those entities? Two steps forward, one step back Why would you *not* want to? Sorry

Re: Why never-cache on OrderHeader and OrderItem?

2009-03-19 Thread David E Jones
. Would we be better off to create another entity, keyed by orderId and orderItemSeqId, just for this purpose? -Al On Thu, Mar 19, 2009 at 2:24 PM, David E Jones david.jo...@hotwaxmedia.comwrote: Stepping back a little, why do you want to cache data from those entities? -David On Mar 19

Re: svn commit: r756754 - /ofbiz/trunk/framework/webslinger/lib/

2009-03-21 Thread David E Jones
Since it has been about 12 hours and no word from Adam I disabled the webslinger build and component load in SVN rev 756990. For now at least we can build and run everything else (only the webslinger component and webapp should be affected by this). I looked around a little for the

[jira] Closed: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-22 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David E. Jones closed OFBIZ-2231. - Resolution: Fixed Assignee: David E. Jones (was: Jacques Le Roux) Escaped ampersands

[jira] Commented: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-22 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688211#action_12688211 ] David E. Jones commented on OFBIZ-2231: --- This should be fixed along with related

Re: Unit Testing - Controller/Screen/Form consistency

2009-03-24 Thread David E Jones
On Mar 24, 2009, at 10:08 AM, Bob Morley wrote: One thing that has come up is situations where we have entries in our controller that reference missing screens and/or screens that reference missing widgets (mostly forms). What I wanted to do was create a unit tester that would walk the

[jira] Commented: (OFBIZ-2252) Exception occurs while changing the order status

2009-03-24 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12688809#action_12688809 ] David E. Jones commented on OFBIZ-2252: --- This looks good in general Deepesh

Re: Unit Testing - Controller/Screen/Form consistency

2009-03-24 Thread David E Jones
bad stuff people had checked in. David E Jones-3 wrote: The WebTools ArtifactInfo stuff does something like this (not sure if it will meet your needs). It does parse and load all of the various artifacts in OFBiz and in the initialization log shows warnings about missing things (bad references

Re: svn commit: r757671 - in /ofbiz/trunk: ./ framework/common/servicedef/ framework/example/testdef/assertdata/ framework/service/src/org/ofbiz/service/ framework/service/src/org/ofbiz/service/jms/ f

2009-03-25 Thread David E Jones
On Mar 25, 2009, at 11:37 AM, Adam Heath wrote: jone...@apache.org wrote: Author: jonesde Date: Tue Mar 24 06:27:03 2009 New Revision: 757671 URL: http://svn.apache.org/viewvc?rev=757671view=rev Log: Removed some more references to applications stuff from framework, including small cleanup

Press Release for Release Branch 9.3

2009-03-25 Thread David E Jones
I've started putting together some ideas for the press release for our upcoming release branch. The time is a little tight... I had planned on doing this last week but it got lost among other things. To facilitate collaboration on this I've created a confluence page for it here:

[jira] Assigned: (OFBIZ-2252) Exception occurs while changing the order status

2009-03-25 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David E. Jones reassigned OFBIZ-2252: - Assignee: David E. Jones Exception occurs while changing the order status

[jira] Closed: (OFBIZ-2252) Exception occurs while changing the order status

2009-03-25 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David E. Jones closed OFBIZ-2252. - Resolution: Fixed I'm applying this patch and making some changes right away since this really

Delaying Release Branch 9.3 for about 2 weeks (was: Press Release for Release Branch 9.3)

2009-03-26 Thread David E Jones
. Comments more than welcome. In fact, I demand that you comment right now! ;) -David On Mar 25, 2009, at 4:32 PM, David E Jones wrote: I've started putting together some ideas for the press release for our upcoming release branch. The time is a little tight... I had planned on doing this last

Re: Press Release for Release Branch 9.3

2009-03-26 Thread David E Jones
in Chinese. :) Or 9.5? Shi Yusen/Beijing Langhua Ltd. 在 2009-03-25三的 16:32 -0600,David E Jones写道: I've started putting together some ideas for the press release for our upcoming release branch. The time is a little tight... I had planned on doing this last week but it got lost among other things

Re: Delaying Release Branch 9.3 for about 2 weeks

2009-03-26 Thread David E Jones
creating jiras for all these then someone can be pointed to it as things they can do to help. David E Jones sent the following on 3/26/2009 9:19 AM: I'm thinking we should delay the release branch for a couple of weeks. Some reasons: 1. more opportunity to collaborate with the PRC on the press

Re: Error while tring to change theme

2009-03-26 Thread David E Jones
On Mar 26, 2009, at 12:58 PM, Bruno Busco wrote: Hi, when trying to select a different theme in the backoffice I get this. The Following Errors Occurred: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [userPrefTypeId] passed to secure (https)

Re: demo.ofbiz.org certificate

2009-03-26 Thread David E Jones
It might be better to stick with a self-signed certificate for now. We don't know where these demo servers will be in the future. There are two main options being pursued (as has been discussed on the private list): 1. host on ASF infra controlled by the current infra team and on

Re: Error while tring to change theme

2009-03-26 Thread David E Jones
the last time. -Adrian David E Jones wrote: On Mar 26, 2009, at 12:58 PM, Bruno Busco wrote: Hi, when trying to select a different theme in the backoffice I get this. The Following Errors Occurred: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter

Re: Delaying Release Branch 9.3 for about 2 weeks (was: Press Release for Release Branch 9.3)

2009-03-26 Thread David E Jones
do not quite understand what idea you have moving the myportal into the framework because it think most of it is already there? regards Hans On Thu, 2009-03-26 at 10:19 -0600, David E Jones wrote: I'm thinking we should delay the release branch for a couple of weeks. Some reasons: 1. more

Re: Massive changes for hyperlinks

2009-03-28 Thread David E Jones
Thanks for your work on that Jacques, it's a great improvement. -David On Mar 28, 2009, at 11:36 AM, Jacques Le Roux wrote: I have recently done some massive changes using Eclipse S/R with regexp. As it was a bit complex I had have my hand dirty. So maybe some typos slipped in Also I

[jira] Commented: (OFBIZ-2256) Secure URLs

2009-03-29 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12693641#action_12693641 ] David E. Jones commented on OFBIZ-2256: --- We might want to leave this open for the FTL

[jira] Commented: (OFBIZ-2243) In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements

2009-03-29 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12693646#action_12693646 ] David E. Jones commented on OFBIZ-2243: --- Wow... that's quite the set of regexps

Re: What about moving payment.properties to an entity ?

2009-03-30 Thread David E Jones
This has been discussed a few times and I think is on a few of the lists around were people have brainstormed on things they'd like to add/change/etc. I'm personally very in favor of it and I do believe it has been needed for a long time. As for the design, I'm very against the concept

[jira] Commented: (OFBIZ-2259) Testing - Rollback database changes after each test-suite using the GenericDelegator

2009-03-30 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12693978#action_12693978 ] David E. Jones commented on OFBIZ-2259: --- This looks pretty good in general. One

[jira] Commented: (OFBIZ-2259) Testing - Rollback database changes after each test-suite using the GenericDelegator

2009-03-30 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12693980#action_12693980 ] David E. Jones commented on OFBIZ-2259: --- Thinking about this more I like the idea

Re: What about moving payment.properties to an entity ?

2009-03-30 Thread David E Jones
On Mar 30, 2009, at 9:38 PM, Adam Heath wrote: David E Jones wrote: This has been discussed a few times and I think is on a few of the lists around were people have brainstormed on things they'd like to add/change/etc. I'm personally very in favor of it and I do believe it has been

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

2009-03-31 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694260#action_12694260 ] David E. Jones commented on OFBIZ-2260: --- Yes, JavaScript is kind of the only way

Re: What about moving payment.properties to an entity ?

2009-04-01 Thread David E Jones
Yes, this looks much better Marco, and is just the direction I was trying to communicate. There are a few things you could do to clarify the structure, and make it more consistent with other sets of entities that are using the type/ etc pattern: 1. make a PaymentGatewayConfigType entity

Re: Override events

2009-04-01 Thread David E Jones
On Apr 1, 2009, at 3:13 AM, Bilgin Ibryam wrote: On Mar 17, 2009, at 10:55 PM, David E Jones wrote: A name or some sort of an identifier on each might be a good way to go... -David David, thanks for the advice. Do you mean a new optional name attribute on event element, so

Re: What about moving payment.properties to an entity ?

2009-04-01 Thread David E Jones
Adding a prefix would make finding these entities easier. We didn't do that with others like Party/Person and ContactMech/PostalAddress, but yes we certainly could. -David On Apr 1, 2009, at 3:38 AM, mrisal...@libero.it wrote: Ok, thanks a lot for those important clarification. I will

Re: Secure URLs question

2009-04-01 Thread David E Jones
This is kind of a bad pattern since it puts presentation-specific code in the data preparation, ie the CMSContentFindQueryString variable is a presentation-specific parameter string that is prepared in a the data preparation code. While not a terrible thing to do, it does reduce

[jira] Commented: (OFBIZ-2269) Move payment.properties to PaymentGatewayConfig entities

2009-04-04 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695682#action_12695682 ] David E. Jones commented on OFBIZ-2269: --- Looks like a great start Marco. One small

Re: hot-deploy or specialpurpose

2009-04-04 Thread David E Jones
There should never be any OOTB components in hot-deploy. It is just an empty directory that is a placeholder for custom extensions that people want to use (either their own or from somewhere else outside of the main ofbiz project). -David On Apr 4, 2009, at 6:46 AM, Jacques Le Roux

Re: Secure URLs, sequel...

2009-04-05 Thread David E Jones
On Apr 5, 2009, at 5:11 AM, Jacques Le Roux wrote: We have also targets with params in forms : look for form(.*)target=(.*)\?(.*)=(.*) and form.(*)\R(.*)target=(.*)\? (.*)=(.*). So I think we should extend the param-name scheme for forms also... If it is a parameter on the form target it

[jira] Commented: (OFBIZ-2269) Move payment.properties to PaymentGatewayConfig entities

2009-04-05 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695884#action_12695884 ] David E. Jones commented on OFBIZ-2269: --- In this case the paymentService field should

Re: Code quality

2009-04-05 Thread David E Jones
The easiest thing to do is have Log4J send the emails with a little setting in the log4j.xml file. We could do this for all ERROR and FATAL level messages. Where to send them is another issue. I suppose if we really wanted people to get on these then having them go to the dev list would

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

2009-04-05 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695965#action_12695965 ] David E. Jones commented on OFBIZ-2260: --- A couple of quick notes: 1

Re: svn commit: r762207 - /ofbiz/trunk/framework/common/config/general.properties

2009-04-05 Thread David E Jones
Some of these settings should NOT go in the trunk, especially those that enable mail notifications and send them to a specific IP address. -David On Apr 5, 2009, at 10:36 PM, jler...@apache.org wrote: Author: jleroux Date: Mon Apr 6 04:36:28 2009 New Revision: 762207 URL:

Re: svn commit: r762224 - /ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/order/orderitems.ftl

2009-04-06 Thread David E Jones
This is another weird one... why is the action set in the JavaScript? It makes the javascript unnecessarily complex as the action should be defined on the form element. In general there is no need for the href to contain anything other than: javascript:document.${formName}.submit() In

[jira] Commented: (OFBIZ-2275) /framework/common/servicedef/services.xml does not have correct location for PeriodServices.xml

2009-04-06 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12696409#action_12696409 ] David E. Jones commented on OFBIZ-2275: --- Thanks for reporting this CJ. I must have

<    1   2   3   4   5   6   7   8   9   10   >