Re: Should be keep the multitenant feature even if broken?

2017-03-03 Thread Taher Alkhateeb
In my opinion, the multi-tenancy feature can be reasonably replaced with non-java databases like mysql and postgres combined with docker. Both instances share the same code base but with two different runtime volumes and two databases. This would actually reduce the complexity of the code base,

port mapping 8080 to 8443 is broken

2017-03-02 Thread Taher Alkhateeb
I'm not sure who committed what, but now the automatic redirection from 8080 to 8443 ssl is broken. Jacques is this related to your work on port offset stuff?

Re: [PROPOSAL] Allow Blog Posts from Community Members on Official OFBiz Blog

2017-02-27 Thread Taher Alkhateeb
Hi Sharan, You folks are doing a great job with the blog, so thank you. I would like to make a distinction like you hinted between two categories of information: 1- News / success stories / community and project promotion 2- Advertisement / forks promotion / vendor promotion Naturally I think

Re: [SECURITY] Google announced first SHA-1 collision - how to we deal with it in OFBiz?

2017-02-24 Thread Taher Alkhateeb
In reference to earlier threads and discussions, I propose the following: 1- Make the encryption algorithm a parameter, not hard-coded into the system. 2- Implement a new stronger encryption algorithm. 3- Set the new algorithm as default. 4- Update our documentation to point existing users to

Re: Welcome Deepak Dixit as a new PMC member

2017-02-24 Thread Taher Alkhateeb
Happy to welcome and congratulate Deepak. I have fond memories of our work together and hope to get more done. Roll you sleeves :) On Feb 24, 2017 4:32 PM, "Pritam Kute" wrote: > Many congratulations Deepak!! > > Thanks & Regards, > -- > *Pritam Kute* > *HotWax

Re: OFBIZ-3972

2017-02-24 Thread Taher Alkhateeb
I think I would prefer DATETIME. Some reasons are found here -> http://stackoverflow.com/questions/409286/should-i-use-field-datetime-or-timestamp. Given that OFBiz takes care of conversions, DATETIME seems like a more appropriate choice On Fri, Feb 24, 2017 at 12:13 PM, Jacques Le Roux <

Re: [PROPOSAL] deprecate mini lang

2017-02-18 Thread Taher Alkhateeb
+1 let's maintain but not add more to the pile, and try to replace everything written in minilang with other languages over time. I think your arguments and proposal are well founded and would really improve the health of this project. On Feb 18, 2017 12:17 PM, "Michael Brohl"

Re: Inconsistent String Comparisons

2017-02-17 Thread Taher Alkhateeb
+1 On Feb 18, 2017 8:16 AM, "Ratnesh Upadhyay" wrote: +1 for the initiation, also we can enforce it as best practice for future implementations and patches. Thanks!! Regards, Ratnesh Upadhyay HotWax Systems www.hotwaxsystems.com On Mon, Jan 9, 2017 at 2:52 PM,

Re: About https://github.com/apache/ofbiz

2017-02-17 Thread Taher Alkhateeb
+1 On Feb 17, 2017 5:57 PM, "Julien NICOLAS" wrote: > +1 > > > On 17/02/2017 14:21, Jacques Le Roux wrote: > >> I think we should remove a lot of useless and old confusing branches in >> svn >> > >

Re: Improve FindGeneric on webtools

2017-02-17 Thread Taher Alkhateeb
Great initiative Nicolas. I remember once trying to extend the functionality of performFind but it contained so much logic that I couldn't reuse it in any reasonable way. The entire implementation of find services needs heavy refactoring or replacement because it tries to do everything

Re: Tests after the framework and plugins split

2017-02-14 Thread Taher Alkhateeb
, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Yes sure: https://svn.apache.org/repos/infra/infrastructure/buildbot/a > egis/buildmaster/master1/projects/ofbiz.conf > > Jacques > > > > Le 14/02/2017 à 11:28, Taher Alkhateeb a écrit : > >&

Re: Welcome Swapnil Shah as a New Committer!

2017-02-14 Thread Taher Alkhateeb
Congratulations Swapnil. Looking forward to working with you. On Tue, Feb 14, 2017 at 2:20 PM, Michael Brohl wrote: > Congratulations and welcome aboard, Swapnil! > > Cheers, > > Michael > > Am 14.02.17 um 12:00 schrieb Sharan Foga: > > The OFBiz PMC has invited

Re: Tests after the framework and plugins split

2017-02-14 Thread Taher Alkhateeb
Hi Jacques, I'm a little lost on the entire build process, can you please explain how the whole thing is structured? how many buildbot instances for each project and how the whole thing is structured. Better yet, can we take a look at the buildbot scripts? Regards, Taher Alkhateeb On Tue, Feb

Re: Eclipse plugins project

2017-02-14 Thread Taher Alkhateeb
I think no need. It's just a subfolder within the framework On Tue, Feb 14, 2017 at 12:47 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > I don't know how it can be handled in IntellIJ; but as is we have nothing > to easily create and Eclipse plugins project > > Do I miss

Re: [DISCUSSION] Plugins: svn:external or Gradle Task?

2017-02-13 Thread Taher Alkhateeb
I don't think we should commit in several branches at once. This again brings us back to the same problem, we are trying to treat separate projects as one project. On Mon, Feb 13, 2017 at 1:06 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 13/02/2017 à 10:56, Jacques Le Roux a

Re: [DISCUSSION] Plugins: svn:external or Gradle Task?

2017-02-13 Thread Taher Alkhateeb
, > > inline... > > Am 13.02.17 um 06:33 schrieb Taher Alkhateeb: > >> Hi Michael, All >> >> All good points, thank you for your thoughts. So a solution that I >> proposed >> in jira to easily manage and maintain our official plugins is to have a >>

Re: [DISCUSSION] Plugins: svn:external or Gradle Task?

2017-02-12 Thread Taher Alkhateeb
other hand we should keep it lean and simple per default. > > Not sure if I could make my viewpoint clear enough, I'm currently too > tired to concentrate on better words :-) > > Best regards, > > Michael > > > Am 12.02.17 um 20:59 schrieb Taher Alkhateeb: > >&g

Re: [DISCUSSION] Plugins: svn:external or Gradle Task?

2017-02-12 Thread Taher Alkhateeb
> > > > Will plugins follow the framework trend? > > > > This is a very important community decision. > > I hope everybody will (try to) understand the consequences and > participate to this discussion, before it will be too late... > > > > Jacques > > &g

Re: [DISCUSSION] Plugins: svn:external or Gradle Task?

2017-02-12 Thread Taher Alkhateeb
hread so I "created a > clean new thread to have it more prominent." > > We should rather focus on the questions... > > Jacques > > > Le 12/02/2017 à 18:42, Taher Alkhateeb a écrit : > >> Why did you start a new thread? What's wrong with the other thread? >> &

Re: [DISCUSSION] Plugins: svn:external or Gradle Task?

2017-02-12 Thread Taher Alkhateeb
pate > to this discussion, before it will be too late... > > Jacques > > > Le 12/02/2017 à 13:32, Taher Alkhateeb a écrit : > >> Let's take a look at the big picture for a moment before we decide. We >> have >> broken OFBiz into essentially two products:

Re: Proposal to create a separate svn repository for the OFBiz official plugins

2017-02-12 Thread Taher Alkhateeb
quot;fiasco" Jacques Le 12/02/2017 à 13:15, Deepak Dixit a écrit : > I think we can setup svn:ignore similar to hot-deploy. > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > > On Sun, Feb 12, 2017 at 5:31 PM, Taher Alkhateeb < > slidingfil

Re: [DISCUSSION] Plugins: svn:external or Gradle Task? (was Re: Proposal to create a separate svn repository for the OFBiz official plugins)

2017-02-12 Thread Taher Alkhateeb
Let's take a look at the big picture for a moment before we decide. We have broken OFBiz into essentially two products: framework and plugins. Why did we break it up? Why did we go through the trouble of creating two different repositories? I hope the answer is something like "because it is too

Re: Proposal to create a separate svn repository for the OFBiz official plugins

2017-02-12 Thread Taher Alkhateeb
I'm not sure, but I think we should set up subversion to ignore the plugins directory except for the README file. On Sun, Feb 12, 2017 at 2:30 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > Great work Deepak! Thank you. > > On Sun, Feb 12, 2017 at 2:00 PM,

Re: Proposal to create a separate svn repository for the OFBiz official plugins

2017-02-12 Thread Taher Alkhateeb
t? How else committers will >>>>> easily >>>>> >>>>>> maintain the plugins? >>>>>> >>>>>> Jacques >>>>>> >>>>>> >>>>>> Le 12/02/2017 à 10:25, Deepak Dixit a écrit : &

Re: Proposal to create a separate svn repository for the OFBiz official plugins

2017-02-12 Thread Taher Alkhateeb
the actual restructuring, putting the commands and your thoughts in place on how to do it exactly. [1] http://stackoverflow.com/questions/360758/moving-a-subversion-repository-to-another-server#360829 Cheers, Taher Alkhateeb On Sun, Feb 12, 2017 at 11:15 AM, Deepak Dixit < deepak.di...@hotw

Re: Proposal to create a separate svn repository for the OFBiz official plugins

2017-02-11 Thread Taher Alkhateeb
repository in http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk - Update the references in the website https://ofbiz.apache.org/source-repositories.html - Update the buildbot scripts (we might as well figure out why it fails constantly lately) Any volunteers to help? Cheers, Taher Alkhateeb

Re: svn commit: r1782577 - /ofbiz/trunk/plugins/component-load.xml

2017-02-11 Thread Taher Alkhateeb
This breaks the entire plugin management API in gradle. A proper solution is to work on the subversion restructure instead and handle whatever data loading sequence needed. On Sat, Feb 11, 2017 at 1:16 PM, wrote: > Author: jleroux > Date: Sat Feb 11 10:16:02 2017 > New

Re: Invoice Item type copied into GL Account type?

2017-02-10 Thread Taher Alkhateeb
Looks very wrong to me. Two different type sets should not be just copied over. While we're at, it might be better to rewrite this in Java or Groovy On Feb 10, 2017 11:05 AM, "Paul Foxworthy" wrote: > Hi all, > > As you might guess if you've been looking at Jira and the dev

Re: [DISCUSSION] Widget refactoring, create a new configuration object ?

2017-02-08 Thread Taher Alkhateeb
Hi Nicolas, Why do you need to resolve some configurations dynamically? Can you provide a concrete example to something you are facing which requires this? Cheers, Taher Alkhateeb On Wed, Feb 8, 2017 at 12:06 AM, Nicolas Malin <nicolas.ma...@nereide.fr> wrote: > Hi, > > Aft

Re: Dynamic field

2017-02-07 Thread Taher Alkhateeb
My recommedation is to use the DynamicViewEntity, link below https://ci.apache.org/projects/ofbiz/site/javadocs/org/ofbiz/entity/model/DynamicViewEntity.html On Feb 7, 2017 4:05 PM, "Ahmad Rabab’ah" wrote: > Hello Dear, > > I can adding dynamic field to my entityDef.xml

Re: sub menu permission

2017-02-07 Thread Taher Alkhateeb
In addition to the great answer from Anchit, I think also there are different solutions depending on what you want to achieve (maybe hide / show things, make different structures, etc ..). So here is another idea: - You create a screen which would hold your menus - You test for a condition in to

Re: Restarting ofbiz

2017-02-07 Thread Taher Alkhateeb
Hi Ahmad, First of all, my recommendation is to use unit tests (not integration tests) where ever you can for a quick feedback loop while developing. Also I could be wrong, but you can sort of take this as a general guideline on what requires a restart (for now, hopefully we'll fix this) #

Re: tutorial for new version

2017-02-07 Thread Taher Alkhateeb
The README.md file is also a comprehensive documentation on how to use the system On Tue, Feb 7, 2017 at 12:43 PM, Pranay Pandey < pranay.pan...@hotwaxsystems.com> wrote: > Hi Ahmad, > > The existing OFBiz beginners tutorial >

Re: Proposal to create a separate svn repository for the OFBiz official plugins

2017-01-31 Thread Taher Alkhateeb
gt; the zip file under plugins and then it can work, or even better, don't >>> unzip it, let it work similar to an android apk file. >>> >>> >>> -邮件原件- >>> 发件人: Taher Alkhateeb [mailto:slidingfilame...@gmail.com] >>> 发送时间: 2017年1月11日 23

Re: svn commit: r1780790 - in /ofbiz/trunk: common.gradle plugins/component-load.xml plugins/ebaystore/ofbiz-component.xml

2017-01-29 Thread Taher Alkhateeb
The ebaystore component was commented out in component-load.xml. Since this file is removed we need another mechanism to disable the component, therefore the build scripts now ignore components that are disabled in ofbiz-component.xml. This is not only a workaround but a cleaner solution that is

Re: buildbot failure in on ofbiz-trunk

2017-01-29 Thread Taher Alkhateeb
rts are used(?)/blocked when running tests in post > Gradle versions. > I believe the best for us is to remove that, if it's possible. I'll have a > look in Config.java. I'll not feel offended if someone beats me on it... > > Thanks > > Jacques > > > Le 29/01/2017 à

Re: buildbot failure in on ofbiz-trunk

2017-01-29 Thread Taher Alkhateeb
s, IOW to remove this regression > introduced with Gradle. > > Before anything else, I will though ask infra why Tomcat is always running > on these hosts... > > Jacques > > > Le 27/01/2017 à 18:15, Taher Alkhateeb a écrit : > >> Why do we need to run the tests o

Re: buildbot failure in on ofbiz-trunk

2017-01-27 Thread Taher Alkhateeb
Why do we need to run the tests on portoffset? On Fri, Jan 27, 2017 at 7:48 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Ah, I forgot to say, that I have dropped BuildBot support for R12 and R13. > > Also that the pre-Gradle versions don't need portoffset > > > > Le 27/01/2017 à

Re: Use ecomseo on demo rather than ecommerce

2017-01-25 Thread Taher Alkhateeb
are discussing? On Wed, Jan 25, 2017 at 11:17 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Taher, > > Le 25/01/2017 à 08:03, Taher Alkhateeb a écrit : > >> Hi Jacques, >> >> I think you might be mixing up "multiple webapps" with "

Re: Use ecomseo on demo rather than ecommerce

2017-01-24 Thread Taher Alkhateeb
apache.org/jira/browse/OFBIZ-5312?focusedComm > entId=13939116=com.atlassian.jira.plugin.system.issueta > bpanels:comment-tabpanel#comment-13939116 > [3] https://issues.apache.org/jira/browse/OFBIZ-5312?focusedComm > entId=13942316=com.atlassian.jira.plugin.system.issueta > bpanels:comm

Re: Use ecomseo on demo rather than ecommerce

2017-01-24 Thread Taher Alkhateeb
Small correction, I meant one component with two webapps On Jan 24, 2017 11:21 PM, "Taher Alkhateeb" <slidingfilame...@gmail.com> wrote: > I have to agree with Scott, the approach here is wrong in my opinion. My > definition of mess is simple: you should not have t

Re: Use ecomseo on demo rather than ecommerce

2017-01-24 Thread Taher Alkhateeb
I have to agree with Scott, the approach here is wrong in my opinion. My definition of mess is simple: you should not have two components with two webapps. A real root solution is to unify the ecommerce component with one webapp exposed instead of having all this hairy code and interdependencies.

Re: potential problem to stop ofbiz with gradle

2017-01-21 Thread Taher Alkhateeb
gt;>> instances with Gradle. I documented it there >>>> >>>> https://issues.apache.org/jira/browse/OFBIZ-7796?page=com. >>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane >>>> l=15758707#comment-15758707 >>>

Re: potential problem to stop ofbiz with gradle

2017-01-19 Thread Taher Alkhateeb
Hi Nicolas, I cannot repeat this behavior. OFBiz is shutting down normally when I start it with ./gradlew ofbizBackground followed by ./gradlew "ofbiz --shutdown". Are you sure you got the environment setup correctly? Cheers, Taher Alkhateeb On Thu, Jan 19, 2017 at 2:00 PM, Nic

Re: Proposal to create a separate svn repository for the OFBiz official plugins

2017-01-18 Thread Taher Alkhateeb
Thank you all very much for your votes and participation. I think this request pretty much got approval from everyone who participated. I will apply everything in the proposal with a minor change in reference to a related discussion here -> https://s.apache.org/yLpE The change is to relocate

Re: Issue when using cleanGradle task

2017-01-14 Thread Taher Alkhateeb
Hi Jacques, My suspicion is that the upgrade to gradle 3+ (which automatically starts the daemon) leads to locking the above mentioned file and hence the problem that you're facing. I think it is safe to remove cleanGradle and also while we are at it cleanAnt tasks from build.gradle On Sat,

Re: What is the "Apache OFBiz" product?

2017-01-14 Thread Taher Alkhateeb
> On Sat, Jan 14, 2017 at 11:21 AM, Taher Alkhateeb < > slidingfilame...@gmail.com> wrote: > > > [...] > > But if we break the code similar to the way it > > was discussed in the above thread, then maybe we should have multiple > > names: > > > > I ag

Re: What is the "Apache OFBiz" product?

2017-01-14 Thread Taher Alkhateeb
Very interesting, Michael's work actually made me realize that we should think about the name differently. Given our discussion in another thread about breaking down the repositories into multiple chunks (http://markmail.org/message/bjvqu23ofwzuk57y) I think we should consider multiple names for

Re: Proposal to create a separate svn repository for the OFBiz official plugins

2017-01-13 Thread Taher Alkhateeb
to define dependencies from plugins on other plugins, unless I understood you incorrectly. Regards, On Fri, Jan 13, 2017 at 12:31 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 11/01/2017 à 16:01, Taher Alkhateeb a écrit : > >> 3- Remove /plugins/component-load.xm

Re: Proposal to create a separate svn repository for the OFBiz official plugins

2017-01-11 Thread Taher Alkhateeb
I like the idea of ofbiz-core Nicolas On Jan 12, 2017 9:49 AM, "Nicolas Malin" <nicolas.ma...@nereide.fr> wrote: > Hi Taher > > > Le 11/01/2017 à 16:01, Taher Alkhateeb a écrit : > >> Hello Folks >> >> This is a proposal to the comm

Re: What is the "Apache OFBiz" product?

2017-01-11 Thread Taher Alkhateeb
Agreed Jacopo, My preference would be The "Apache OFBiz" ERP suite. The reason is that the term ERP is very popular and understandable to business folks. It also conveys the heart of what this product is all about. Yes it is not yet refined for immediate consumption by end users, but that does

Proposal to create a separate svn repository for the OFBiz official plugins

2017-01-11 Thread Taher Alkhateeb
d in: http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk/birt This would allow us to have in the future the ability to provide releases not only for the framework but the plugins as well as two separate products. What do you think? Cheers, Taher Alkhateeb

Re: Defining the "Mission Statement" of the Apache OFBiz project

2017-01-11 Thread Taher Alkhateeb
+1 On 11/01/17 13:57, Pranay Pandey wrote: +1 Sounds great. Best regards, Pranay Pandey HotWax Systems http://www.hotwaxsystems.com/ On Wed, Jan 11, 2017 at 2:40 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: Hi all, I think it would be great if we could write a

Re: Proposal to rename specialpurpose to plugins

2017-01-11 Thread Taher Alkhateeb
Okay Folks, Done in r1778271. Thank you all for your patience, and you can continue your work on /plugins (the new directory replacing /specialpurpose) Cheers, Taher Alkhateeb On 11/01/17 10:48, Taher Alkhateeb wrote: Hello everyone, Minor correction, sorry for the miscount, the total

Re: Proposal to rename specialpurpose to plugins

2017-01-10 Thread Taher Alkhateeb
Hello everyone, Minor correction, sorry for the miscount, the total number of binding +1 votes is 5 and total number of +1 non-binding votes is 4 Cheers, Taher Alkhateeb On Wed, Jan 11, 2017 at 10:28 AM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > +1 > > Thank you ev

Re: Proposal to rename specialpurpose to plugins

2017-01-10 Thread Taher Alkhateeb
the rename is complete? Cheers, Taher Alkhateeb On Mon, Jan 9, 2017 at 5:07 PM, Gavin Mabie <kwikst...@gmail.com> wrote: > +1 to rename as plugins > > On Mon, Jan 9, 2017 at 12:23 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Thanks for t

Re: AccountingQuantity, COGS method and inventory valuation

2017-01-06 Thread Taher Alkhateeb
in createAcctgTransForShipmentReceipt right? I'm not an expert in this area but your proposition sounds reasonable both in the accountingQuantity field and changing the report design to aggregate on average value. Thank you again for this info! Cheers, Taher Alkhateeb On Sat, Jan 7, 2017 at 6:05

Re: NPE in R16 demo

2017-01-05 Thread Taher Alkhateeb
Hi Jacques, This seems to be a bug in java.util.concurrent related logic. Perhaps you can provide more context in a Jira to try and tackle it? On Jan 5, 2017 8:12 PM, "Jacques Le Roux" wrote: Hi Devs, Thought you could be interested by this bug 2017-01-05

Re: Issue with Gradle [was Re: Proposal to rename specialpurpose to plugins]

2017-01-03 Thread Taher Alkhateeb
Perhaps this might be relevant? https://issues.gradle.org/browse/GRADLE-1801 On Tue, Jan 3, 2017 at 2:50 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Moving Gradle to another location worked for "gradlew eclipse" but again > not for "gradlew cleanGradle " > > Microsoft Windows

Re: Proposal to rename specialpurpose to plugins

2017-01-03 Thread Taher Alkhateeb
03/01/2017 à 10:38, Jacques Le Roux a écrit : > >> Moreover while svn updating I just got a merge issue with recent lucene >> changes, then an Eclipse issue (I had it open) and then it seems I have to >> remove all Gradle caches, got this >> >> https://stackoverflow.com/

Re: Proposal to rename specialpurpose to plugins

2017-01-03 Thread Taher Alkhateeb
Roux a écrit : > >> +1 >> >> Jacques >> >> >> Le 02/01/2017 à 17:45, Taher Alkhateeb a écrit : >> >>> Hello Everyone, >>> >>> In reference to earlier discussions and threads on the above subject, I >>> am >>&

Re: Proposal to rename specialpurpose to plugins

2017-01-02 Thread Taher Alkhateeb
't want to get in the way of change but at the same time I'm > not sure the benefits outweigh the potential confusion. > > Regards > Scott > > On 3 January 2017 at 09:11, Taher Alkhateeb <slidingfilame...@gmail.com> > wrote: > > > Hi Scott, > > > > I don't kn

Re: Proposal to rename specialpurpose to plugins

2017-01-02 Thread Taher Alkhateeb
is to rename and prepare a mechanism for handling plugins. Perhaps we can start aanother thread to discuss the next steps moving forward. Cheers, Taher Alkhateeb On Jan 2, 2017 11:02 PM, "Scott Gray" <scott.g...@hotwaxsystems.com> wrote: > What's the plan for the hot-dep

Proposal to rename specialpurpose to plugins

2017-01-02 Thread Taher Alkhateeb
ache.org/thread.html/9bb4fba6ec56bd52a5bc55e44ba1672f088ec33eeb8a1af4d16fd6d2@%3Cdev.ofbiz.apache.org%3E Cheers, Taher Alkhateeb

Re: Proposal to upgrade Gradle to version 3.2.1

2016-12-30 Thread Taher Alkhateeb
7/12/2016 à 21:45, Taher Alkhateeb a écrit : > >> Hello everyone, >> >> I've upgraded gradle to version 3.2.1 on my machine and tested most >> functionality which seems to be operating well. The experience is pleasant >> because by default version 3+ automatical

Re: svn commit: r1776243 - /ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/Model Service.java

2016-12-30 Thread Taher Alkhateeb
;>> >>>> I agreed that this clock of code is not needed in isValid() and removed >>>> it in my proposition. >>>> Because isValid() does not makes sense to be called with a context with >>>> a >>>> RESPONSE_MESSAGE which could be

Re: svn commit: r1776243 - /ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/Model Service.java

2016-12-28 Thread Taher Alkhateeb
I tend to also prefer a response message. Adding something new like a boolean flag puts more information for people to process needlessly. Less is more I think. On Dec 29, 2016 12:55 AM, "Jacques Le Roux" wrote: > Yes, I wondered about that. > > In my case the

Re: Review the configuration of the OFBiz forums at Nabble

2016-12-27 Thread Taher Alkhateeb
about how to configure nabble, so perhaps someone here can help us with this information to see what to do next. Taher Alkhateeb On Tue, Dec 27, 2016 at 10:53 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > I am starting this thread to review and discuss th

Proposal to upgrade Gradle to version 3.2.1

2016-12-27 Thread Taher Alkhateeb
. They deprecated the shift operator "<<" but it still works and we can refactor that later. We might need some work on buildbot to upgrade the version, but other than that it seems to be a smooth experience. What do you think? Is it a good time to upgrade? Taher Alkhateeb

Re: Apache Logo in Twitter header logo for OFBiz

2016-12-23 Thread Taher Alkhateeb
The background looks nice and clean while ours looks cluttered. So yeah it would be nice to adapt it. On Fri, Dec 23, 2016 at 7:35 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > > > > [...] > > To create this I took the SVG from [2], cropped it, and converted it > > to a

Re: Replace password encryption SHA-1 by SHA-512

2016-12-14 Thread Taher Alkhateeb
er 2016 at 02:17, Taher Alkhateeb <slidingfilame...@gmail.com> wrote: > I think the best solution in here is to actually parameterize the > encryption algorithm with a default backwards compatible choice (SHA1). > > However, I'm not sure that we do need that. SHA1 is okay I think,

Help in refactoring javadocs

2016-12-14 Thread Taher Alkhateeb
. Ultimately, it will be compliant if running ./gradlew javadoc does not generate errors for the thing you're fixing anymore. Cheers, Taher Alkhateeb

Re: Call to action: fixing defects reported by code analysis tools

2016-12-13 Thread Taher Alkhateeb
Thank you Jacopo, this is an excellent idea and would substantially improve our code base. I strongly urge anyone willing to help to speak up or start issuing JIRAs. If anyone needs help in setting up the plugins or has any questions please feel free to discuss them on this ML or HipChat. On Tue,

Re: svn commit: r1773338 - in /ofbiz/trunk/framework: base/src/main/java/org/apache/ofbiz/base/container/ base/src/main/java/org/apache/ofbiz/base/util/ base/src/main/java/org/apache/ofbiz/base/util/c

2016-12-09 Thread Taher Alkhateeb
gt; Thank you Taher!!! > In rev 1773354 I have removed also the diamond operator because my IDE was > considering it illegal for Javadoc; let me know if you have suggestions and > I will fix it (or feel free to modify it if you are working on the same). > > Jacopo > > On Fri,

Re: Replace password encryption SHA-1 by SHA-512

2016-12-09 Thread Taher Alkhateeb
I think the best solution in here is to actually parameterize the encryption algorithm with a default backwards compatible choice (SHA1). However, I'm not sure that we do need that. SHA1 is okay I think, and it has the most support out there in terms of libraries. Do we have any history of people

Re: svn commit: r1773338 - in /ofbiz/trunk/framework: base/src/main/java/org/apache/ofbiz/base/container/ base/src/main/java/org/apache/ofbiz/base/util/ base/src/main/java/org/apache/ofbiz/base/util/c

2016-12-09 Thread Taher Alkhateeb
Great work Jacopo! minor note: - * @see org.apache.ofbiz.base.start.StartupLoader#load(Config, String[]) + * @see org.apache.ofbiz.base.start.StartupLoader#load(Config, List[]) There is still an array set of brackets "[]" which should go away It's funny but I'm actually working on the

Re: svn commit: r1772879 - in /ofbiz/trunk: ./ framework/base/src/main/java/org/apache/ofbiz/base/container/ framework/start/src/main/java/org/apache/ofbiz/base/start/

2016-12-08 Thread Taher Alkhateeb
Hi Jacques, actually I entered a type, that "." before Labels.xml should not be there. So I already excluded all the label files, I'll fix this shortly. As to why include other XML files, it's because the classpath logic changed and we need to define things in Gradle (no longer loaded from OFBiz,

Re: [DISCUSSION] Improving the OFBiz User Interface

2016-12-07 Thread Taher Alkhateeb
hard work to get this done. We leave that for the community to decide. I certainly agree with Michael though that we should do this work in a careful manner to minimize the transition pain for adopters of earlier versions. Cheers, Taher Alkhateeb On Dec 7, 2016 6:30 PM, "Michael Bro

Re: buildbot failure in on ofbiz-trunk

2016-12-06 Thread Taher Alkhateeb
Okay, I'm not sure if this is a passing fluke, but all tests pass locally. On Tue, Dec 6, 2016 at 3:49 PM, wrote: > The Buildbot has detected a new failure on builder ofbiz-trunk while > building . Full details are available at: >

Re: Proposal to remove excess runtime libraries

2016-12-06 Thread Taher Alkhateeb
Thank you folks. Committed in r1772839. On Mon, Dec 5, 2016 at 4:13 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 05/12/2016 à 14:04, Jacopo Cappellato a écrit : > >> On Sat, Dec 3, 2016 at 8:28 AM, Taher Alkhateeb < >> slidingfilame...@gmail.com>

Re: [DISCUSSION] Defining an OFBiz Project Strategy

2016-12-03 Thread Taher Alkhateeb
encourage the community members, active or staying in the > background to speak up and let us hear their point of view to the further > development of OFBiz. > > Every voice is appreciated. > > Best regards, > > Michael > > > Am 03.12.16 um 06:55 schrieb Taher Alkhateeb: &

Proposal to remove excess runtime libraries

2016-12-02 Thread Taher Alkhateeb
that we missed. They seem to be mostly things that had a PoC from the past like bean mappers or so. Should I go ahead? opinions? Taher Alkhateeb

Re: [DISCUSSION] Defining an OFBiz Project Strategy

2016-12-02 Thread Taher Alkhateeb
.) Cheers, and sorry for the long blinding post :) Taher Alkhateeb On Sat, Dec 3, 2016 at 2:03 AM, Scott Gray <scott.g...@hotwaxsystems.com> wrote: > I don't think it's really our UI that inhibits adoption. With any > reasonably sized project there is going to be a large amount of UI

Re: Need feedback and testing

2016-12-02 Thread Taher Alkhateeb
. Cheers, Taher Alkhateeb On Sun, Nov 27, 2016 at 3:40 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > Hi Everyone, > > I just finished refactoring some of the messiest code I've ever seen. > Again, I have a new patch in https://issues.apache.org/jira/browse/OFBIZ- &g

Re: [DISCUSSION] Organising OFBiz Events or Meetups

2016-12-02 Thread Taher Alkhateeb
A strategy without follow up is just a statement. So yeah I really think we need some form of regular meetings to see where we are and whether we are going on the right direction. Perhaps something like once a month? Maybe for one hour or so, we can gather on HipChat or have some form of voice

Re: OFBiz Delegator that uses JPA

2016-12-01 Thread Taher Alkhateeb
Hi Paul, Please stop hijacking threads and discussions about OFBiz to promote your fork. This is not the first time someone asks a question or makes a comment about OFBiz in which you switch the thread towards your fork. Regards, Taher Alkhateeb On Dec 1, 2016 4:02 PM, "Paul Pipe

Re: Some questions on plugin system

2016-12-01 Thread Taher Alkhateeb
> ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Thu, Dec 1, 2016 at 11:39 AM, Taher Alkhateeb < > slidingfilame...@gmail.com > > wrote: > > > Hi Pierre,

Re: Some questions on plugin system

2016-12-01 Thread Taher Alkhateeb
Hi Pierre, What is the load order in /specialpurpose, what depends on what? Also what should we revisit about loadDefault and load readers? Taher Alkhateeb On Thu, Dec 1, 2016 at 1:31 PM, Pierre Smits <pierre.sm...@gmail.com> wrote: > Taher, all, > > If we all are in f

Re: [DISCUSSION] Improving the OFBiz User Interface

2016-12-01 Thread Taher Alkhateeb
work, in a Jira? > > Jacques > > > > Le 01/12/2016 à 10:53, Taher Alkhateeb a écrit : > >> I am working on this >> >> On Dec 1, 2016 12:48 PM, "Jacques Le Roux" <jacques.le.r...@les7arts.com> >> wrote: >> >> Totally agreed! >>>

Re: [DISCUSSION] Improving the OFBiz User Interface

2016-12-01 Thread Taher Alkhateeb
l try to contact him > about that. Has anybody else begun to work on that? > > Jacques > > > Le 01/12/2016 à 10:38, Taher Alkhateeb a écrit : > >> Hi Jacques, >> >> That was already discussed. My opinion is still not to allow it BUT, you >> can create a

Re: [DISCUSSION] Improving the OFBiz User Interface

2016-12-01 Thread Taher Alkhateeb
l with form > widgets (at least as is now). Could be allowed on certain component for > instance or using properties. > > Jacques > > > > Le 01/12/2016 à 09:56, Taher Alkhateeb a écrit : > >> I think by introducing a new DSL we can enforce no leakage of HTML / FTL &

Re: Some questions on plugin system

2016-12-01 Thread Taher Alkhateeb
uot; and 2) if a component directory does not have a component-load.xml then load everything Ideas? Taher Alkhateeb On Thu, Nov 24, 2016 at 1:02 AM, Nicolas Malin <nicolas.ma...@nereide.fr> wrote: > Hello Taher, > > Your svn reorganization look fine, I just a doubt if in the futur

Re: [DISCUSSION] Improving the OFBiz User Interface

2016-12-01 Thread Taher Alkhateeb
I think by introducing a new DSL we can enforce no leakage of HTML / FTL into any widgets (I'm assuming this is what you guys are talking about) On Thu, Dec 1, 2016 at 11:49 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Nicely said, thanks Julien :) > > Jacques > > > > Le

Re: [DISCUSSION] Defining an OFBiz Project Strategy

2016-11-30 Thread Taher Alkhateeb
infrastructure seems like a good middle solution. Cheers, Taher Alkhateeb On Nov 30, 2016 3:44 PM, "Jacopo Cappellato" < jacopo.cappell...@hotwaxsystems.com> wrote: On Wed, Nov 30, 2016 at 11:52 AM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > [...] > Instead

Re: [DISCUSSION] Improving the OFBiz User Interface

2016-11-30 Thread Taher Alkhateeb
Good point Jacopo. We need a place to collaborate and get down to business. I would prefer an interactive HipChat session to get rolling and decide what to do next, then maybe create a wiki page or something like that based on the initial plan. On Wed, Nov 30, 2016 at 1:07 PM, Jacopo Cappellato <

Re: [DISCUSSION] Defining an OFBiz Project Strategy

2016-11-30 Thread Taher Alkhateeb
that. It's not a big deal to publish it to JCenter or similar repository providers because we will always have that exact copy available in our source code system. Cheers, Taher Alkhateeb On Wed, Nov 30, 2016 at 1:37 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > On We

Re: [DISCUSSION] Improving the OFBiz User Interface

2016-11-28 Thread Taher Alkhateeb
remain a pure DSL. The current user interface is full of tags for dropping in freemarker templates. So refactoring would be a huge pain. A fresh start makes sense and that's why I make the above proposition. Ideas? Thoughts? Cheers, Taher Alkhateeb On Tue, Nov 29, 2016 at 12:25 AM, gil

Re: [DISCUSSION] Defining an OFBiz Project Strategy

2016-11-28 Thread Taher Alkhateeb
? Cheers, Taher Alkhateeb On Mon, Nov 28, 2016 at 1:35 PM, Sharan Foga <sha...@apache.org> wrote: > There was a bit that I missed - and this is a common thing that keeps > coming back up when we get together and talk: > > OFBiz could deliver more than one product. We could have more

Re: Draft message to announce the new release Apache OFBiz 16.11.01

2016-11-28 Thread Taher Alkhateeb
+1 On Mon, Nov 28, 2016 at 2:53 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Thanks for your feedback. > Are we good with the current version of the announcement? I am planning to > send the announcement today and then move on with a few other steps > required to

Re: Updated website with (minimal) information about the new release

2016-11-27 Thread Taher Alkhateeb
Hi Jacopo, I think it might be better to remove the direct links to release OFBiz 11.04.06 and OFBiz 12.04.06 from this page no? Taher Alkhateeb On Mon, Nov 28, 2016 at 10:28 AM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > A few seconds ago, in rev. 177168

<    3   4   5   6   7   8   9   10   11   12   >