Re: Start.java Issue

2015-04-20 Thread Adam Heath
My freetime has been aimed at ofbiz. That change is on my list. On 04/18/2015 03:20 PM, Adrian Crum wrote: RTC will bring the project to a screeching halt - because no one reviews anything. I'm still waiting for feedback on the entity cache fix I committed a while ago. Adrian Crum Sandglass

Re: Start.java Issue

2015-04-19 Thread Jacopo Cappellato
On Apr 18, 2015, at 7:38 PM, Adrian Crum adrian.c...@sandglass-software.com wrote: I checked the commit logs - the double parsing was introduced in rev 1633182. yes, and no. I did that commit and it was a good enhancement: before that, the start component, was parsing the filesystem and

Re: Start.java Issue

2015-04-19 Thread Adrian Crum
I will create a Jira issue and supply a patch for review. Adrian Crum Sandglass Software www.sandglass-software.com On 4/19/2015 7:13 AM, Jacopo Cappellato wrote: On Apr 18, 2015, at 7:38 PM, Adrian Crum adrian.c...@sandglass-software.com wrote: I checked the commit logs - the double

Re: Start.java Issue

2015-04-19 Thread Adrian Crum
https://issues.apache.org/jira/browse/OFBIZ-6268 Adrian Crum Sandglass Software www.sandglass-software.com On 4/19/2015 7:22 AM, Adrian Crum wrote: I will create a Jira issue and supply a patch for review. Adrian Crum Sandglass Software www.sandglass-software.com On 4/19/2015 7:13 AM, Jacopo

Re: Start.java Issue

2015-04-18 Thread Adrian Crum
There have been many Start.java refactorings in the past that did not require review. Why is this one different? Adrian Crum Sandglass Software www.sandglass-software.com On 4/18/2015 6:24 PM, Jacques Le Roux wrote: Le 18/04/2015 19:12, Adrian Crum a écrit : I spent the day looking through

Re: Start.java Issue

2015-04-18 Thread Adrian Crum
I checked the commit logs - the double parsing was introduced in rev 1633182. Adrian Crum Sandglass Software www.sandglass-software.com On 4/18/2015 6:12 PM, Adrian Crum wrote: I spent the day looking through the OFBiz startup code to see if there is any way we can shorten the startup time.

Start.java Issue

2015-04-18 Thread Adrian Crum
I spent the day looking through the OFBiz startup code to see if there is any way we can shorten the startup time. Something I noticed that seems odd... Start.java searches the OFBiz folders for all instances of ofbiz-component.xml files, parses them, and builds a class path based on their

Re: Start.java Issue

2015-04-18 Thread Jacques Le Roux
Le 18/04/2015 19:12, Adrian Crum a écrit : I spent the day looking through the OFBiz startup code to see if there is any way we can shorten the startup time. Something I noticed that seems odd... Start.java searches the OFBiz folders for all instances of ofbiz-component.xml files, parses

Re: Start.java Issue

2015-04-18 Thread Pierre Smits
We should learn from the past, not repeat it. RTC would have brought this aspect of the improvement in r1633182 earlier to our attention than CTR. Best regards, Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail

Re: Start.java Issue

2015-04-18 Thread Adrian Crum
RTC will bring the project to a screeching halt - because no one reviews anything. I'm still waiting for feedback on the entity cache fix I committed a while ago. Adrian Crum Sandglass Software www.sandglass-software.com On 4/18/2015 8:08 PM, Pierre Smits wrote: We should learn from the

Re: Start.java Issue

2015-04-18 Thread Pierre Smits
'no one reviews anything' is misleading because not true. We do what we can. Seeking collaboration and consensus is a far better attitude than putting Code over Community. CTR regarding improvements is putting Code over Community. Is creating an improvement issue, attaching patches and seeking

Re: Start.java Issue

2015-04-18 Thread Jacques Le Roux
Le 18/04/2015 22:20, Adrian Crum a écrit : RTC will bring the project to a screeching halt - because no one reviews anything. I'm still waiting for feedback on the entity cache fix I committed a while ago. no one reviews anything. That's *almost* right Adrian, we review some I believe ;) and