Re: geronimo_jpa dependency and java11

Le sam. 29 févr. 2020 à 16:58, Mark Struberg a écrit : > > 1. There is this 1 for 1000 users of jpms so even if a failure, we should > > comply with it today > > Yes, we should just pimp all our specs to also include module names. > But please no module-info class which kills Java8 projects. > >

Re: geronimo_jpa dependency and java11

Tomcat still has an ancient code structure. They still use ant. And they still have all the stuff checked in to their own project https://github.com/apache/tomcat/tree/master/java/jakarta So they just renamed the package, but the sourc

Re: geronimo_jpa dependency and java11

> 1. There is this 1 for 1000 users of jpms so even if a failure, we should > comply with it today Yes, we should just pimp all our specs to also include module names. But please no module-info class which kills Java8 projects. An easy way to resolve this is to have this 1 out of 1000 (rather 10.

Re: geronimo_jpa dependency and java11

package means folders in which classes are, not jar. For ref: https://github.com/apache/tomcat/tree/master/java/jakarta Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: geronimo_jpa dependency and java11

This is from tomcat.apache.org Users of Tomcat 10 onwards should be aware that, as a result of the move from Java EE to Jakarta EE as part of the transfer of Java EE to the Eclipse Foundation, the primary package for all implemented APIs has changed from javax.* to jakarta.*. This will almost cert

Re: geronimo_jpa dependency and java11

Le sam. 29 févr. 2020 à 16:48, Maxim Solodovnik a écrit : > I'm OK with reverting if Automatic-Module-Name will be specified > > What is wrong with Jakarta licensing? > Tomcat-10-M1 was just released with jakarta jars > Dont think, they host the code as geronimo does. > On Sat, 29 Feb 20

Re: geronimo_jpa dependency and java11

I'm OK with reverting if Automatic-Module-Name will be specified What is wrong with Jakarta licensing? Tomcat-10-M1 was just released with jakarta jars On Sat, 29 Feb 2020 at 22:23, Romain Manni-Bucau wrote: > > Le sam. 29 févr. 2020 à 16:17, Mark Struberg a > écrit : > > > Btw, the whole

Re: geronimo_jpa dependency and java11

Le sam. 29 févr. 2020 à 16:17, Mark Struberg a écrit : > Btw, the whole module system is a big fail. > There are right now discussions in BIG projects to skip all that and > revert to just plain jars again. > > The point is that we right now have our own sources and are fine with it. > I really d

Re: geronimo_jpa dependency and java11

Le sam. 29 févr. 2020 à 16:09, Mark Struberg a écrit : > Sorry that this slipped. This imo needs further discussion. > The license aspect is not clear imo. > We also break many downstream openjpa users which had their whole toolset > tailored for geronimo-specs. > Hmm, should not, concretely spe

Re: geronimo_jpa dependency and java11

Btw, the whole module system is a big fail. There are right now discussions in BIG projects to skip all that and revert to just plain jars again. The point is that we right now have our own sources and are fine with it. I really don't understand the point of changing this in a minor version. Lie

Re: geronimo_jpa dependency and java11

Sorry that this slipped. This imo needs further discussion. The license aspect is not clear imo. We also break many downstream openjpa users which had their whole toolset tailored for geronimo-specs. I'm +1 for a revert and cleanup of geronimo-jpa-spec. LieGrue, strub > Am 25.12.2019 um 12:40 s

Re: geronimo_jpa dependency and java11

You are right this change breaks java8 build OK, my PR will stay the same :)) On Wed, 25 Dec 2019 at 16:14, Romain Manni-Bucau wrote: > > Does not change the fact it is a j11 feature and our compile baseline is j8 > so nogo until it is a profile ;). > > Side note: dont think we must compile with

Re: geronimo_jpa dependency and java11

Does not change the fact it is a j11 feature and our compile baseline is j8 so nogo until it is a profile ;). Side note: dont think we must compile with j11, just run. Le mer. 25 déc. 2019 à 09:57, Maxim Solodovnik a écrit : > https://bugs.openjdk.java.net/browse/JDK-8212636 > > On Wed, 25 Dec

Re: geronimo_jpa dependency and java11

https://bugs.openjdk.java.net/browse/JDK-8212636 On Wed, 25 Dec 2019 at 15:56, Romain Manni-Bucau wrote: > > Release? Source=target=8 should be enough otherwise you will not build on > java 8. > > Le mer. 25 déc. 2019 à 09:48, Maxim Solodovnik a > écrit : > > > It seems adding > > 8 > > to maven

Re: geronimo_jpa dependency and java11

Release? Source=target=8 should be enough otherwise you will not build on java 8. Le mer. 25 déc. 2019 à 09:48, Maxim Solodovnik a écrit : > It seems adding > 8 > to maven-compiler-plugin config seems to fix java11 build for me > Will add this change to PR as soon build will be successful > > On

Re: geronimo_jpa dependency and java11

It seems adding 8 to maven-compiler-plugin config seems to fix java11 build for me Will add this change to PR as soon build will be successful On Wed, 25 Dec 2019 at 15:22, Romain Manni-Bucau wrote: > > +1 > > Le mer. 25 déc. 2019 à 06:17, Maxim Solodovnik a > écrit : > > > Can I merge this PR?

Re: geronimo_jpa dependency and java11

+1 Le mer. 25 déc. 2019 à 06:17, Maxim Solodovnik a écrit : > Can I merge this PR? > I can additionally check compilation issues under java11 > > On Tue, 17 Dec 2019 at 14:29, Maxim Solodovnik > wrote: > > > > Both fixed :) > > > > On Tue, 17 Dec 2019 at 13:53, Romain Manni-Bucau > wrote:

Re: geronimo_jpa dependency and java11

Can I merge this PR? I can additionally check compilation issues under java11 On Tue, 17 Dec 2019 at 14:29, Maxim Solodovnik wrote: > > Both fixed :) > > On Tue, 17 Dec 2019 at 13:53, Romain Manni-Bucau > wrote: > > > > Except one missing indent and probably the move from "stats" to > > "s

Re: geronimo_jpa dependency and java11

Both fixed :) On Tue, 17 Dec 2019 at 13:53, Romain Manni-Bucau wrote: > > Except one missing indent and probably the move from "stats" to > "statistics" it looks good to me, wdyt @Mark Struberg ? > > Romain Manni-Bucau > @rmannibucau | Blog >

Re: geronimo_jpa dependency and java11

Except one missing indent and probably the move from "stats" to "statistics" it looks good to me, wdyt @Mark Struberg ? Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: geronimo_jpa dependency and java11

https://github.com/apache/openjpa/pull/57 On Tue, 17 Dec 2019 at 13:19, Maxim Solodovnik wrote: > > Great, > > will do > I'm going to add Automatic-Module-Name > `org.apache.openja.` > And we can discuss changes in "review" mode :) > > On Tue, 17 Dec 2019 at 13:13, Romain Manni-Bucau > wrote: >

Re: geronimo_jpa dependency and java11

Great, will do I'm going to add Automatic-Module-Name `org.apache.openja.` And we can discuss changes in "review" mode :) On Tue, 17 Dec 2019 at 13:13, Romain Manni-Bucau wrote: > > Hmm, not exactly what i expected but it should work, not just as > transparent and integrated as i thought. > > Th

Re: geronimo_jpa dependency and java11

Hmm, not exactly what i expected but it should work, not just as transparent and integrated as i thought. The end of the dependency mess is still key for me and only this jar can justify the scope compile you spoke about, all G one should be provides IMHO. Dont think osgi is a blocker while you d

Re: geronimo_jpa dependency and java11

This is part of MANIFEST.MF Bundle-ManifestVersion: 2 Bundle-Vendor: Eclipse.org - EclipseLink Project Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version>=1.8) )" Import-Package: javax.sql;resolution:=optional,org.osgi.framework;reso lution:=optional,org.osgi.service.jpa;version="1

Re: geronimo_jpa dependency and java11

Hmmm, looks like old style, doesnt it have Provide-Capability somewhere (sorry i dont have a computer handy right now)? Maybe reopen a thread @g Mark if you want to do that, but we should also include micrporofile in that thread to enforce our consistence IMHO. Romain Manni-Bucau @rmannibucau

Re: geronimo_jpa dependency and java11

I'm not familiar with OSGI jakarta.jas has `Activator implements org.osgi.framework.BundleActivator` and `OSGiProviderResolver implements PersistenceProviderResolver, PersistenceProvider` Please let me know if I should proceed with my PR, or if it would be better to dismiss it :) On Tue, 17 Dec 2

Re: geronimo_jpa dependency and java11

Le lun. 16 déc. 2019 à 22:13, Mark Struberg a écrit : > jakarta persistence is EPL. It's not a problem to add it but would love to > avoid it. > The simplest way would be to add those module information to Geronimo-jpa. > Could do a mass release of those specs then. > We should stick to a single

Re: geronimo_jpa dependency and java11

jakarta persistence is EPL. It's not a problem to add it but would love to avoid it. The simplest way would be to add those module information to Geronimo-jpa. Could do a mass release of those specs then. LieGrue, strub > Am 16.12.2019 um 14:39 schrieb Maxim Solodovnik : > > Here is the diff >

Re: geronimo_jpa dependency and java11

Here is the diff https://github.com/apache/openjpa/compare/OPENJPA-2798-java11-friendly On Mon, 16 Dec 2019 at 20:38, Maxim Solodovnik wrote: > > Current status: In my branch I have changed jpa_spec with > jakarta.persistence and the build is green > I can drop this branch if there is better way

Re: geronimo_jpa dependency and java11

Current status: In my branch I have changed jpa_spec with jakarta.persistence and the build is green I can drop this branch if there is better way to achieve java11 compatibility :) I always thought modules is like dependencies I only have openjpa dependency right now and do have all transitive ja

Re: geronimo_jpa dependency and java11

I'm not sure what the status is right now. But one of the big pros over the standard jpa api has always been that it works even with OSGi. LieGrue, strub > Am 16.12.2019 um 14:24 schrieb Romain Manni-Bucau : > > Not "compile time dependencies" but "spec jars". Mainly because the user > must i

Re: geronimo_jpa dependency and java11

Not "compile time dependencies" but "spec jars". Mainly because the user must import it himself (this is what he use to code so it should be a first level dep + to avoid the exclusion mess since there are like 6-7 spec jars libs use and conflict). Romain Manni-Bucau @rmannibucau

Re: geronimo_jpa dependency and java11

BTW why compile time dependency should't be transitive? On Mon, 16 Dec 2019 at 20:12, Maxim Solodovnik wrote: > > I can create PR in a minute (based on OPENJPA-2798-java11-friendly branch) > Was planning to add "Automatic-Module-Name"s to manifest > > On Mon, 16 Dec 2019 at 20:03, Romain Manni-Bu

Re: geronimo_jpa dependency and java11

I can create PR in a minute (based on OPENJPA-2798-java11-friendly branch) Was planning to add "Automatic-Module-Name"s to manifest On Mon, 16 Dec 2019 at 20:03, Romain Manni-Bucau wrote: > > Nobody uses it but adding them breaks apps ;), yeah. > Anyway openjpa shouldnt have jpa api transitive an

Re: geronimo_jpa dependency and java11

Nobody uses it but adding them breaks apps ;), yeah. Anyway openjpa shouldnt have jpa api transitive anyway IMHO so not a big deal while we dont break OSGi case in the feature.xml. Romain Manni-Bucau @rmannibucau | Blog | Old B

Re: geronimo_jpa dependency and java11

I'd go with fixing our module info in geronimo-jpa. But otoh nobody is using modules anyway it seems ... LieGrue, strub > Am 11.12.2019 um 06:39 schrieb Romain Manni-Bucau : > > Yes this one > > For openjpa the challenge will likely to not have module-info in main > artifacts - guess we can du

Re: geronimo_jpa dependency and java11

Yes this one For openjpa the challenge will likely to not have module-info in main artifacts - guess we can duplicate artifacts with a classifier jpms or so - to avoid to break some servers and env. Last thing to take care: all osgi integration, i didnt check jakarta jar supports it as well as ou

Re: geronimo_jpa dependency and java11

Do you mean this one: org.eclipse.persistence jakarta.persistence 2.2.2 Looks good to me! Shall I create PR? (the task seems to be doable for me :))) On Wed, 11 Dec 2019 at 01:03, Romain Manni-Bucau wrote: > Hi > > I proposed some time ago to rename them all but since jakarta is

Re: geronimo_jpa dependency and java11

Hi I proposed some time ago to rename them all but since jakarta is at eclipse now, i guess well more move to their bundles. Wdyt? Le mar. 10 déc. 2019 à 18:18, Maxim Solodovnik a écrit : > Hello All, > > not sure which list should I ask, so will start here > > I have started to add module-inf