Re: [dev] warnings01: -Wnon-virtual-dtor

2006-02-13 Thread Stephan Bergmann
Nikolai Pretzell wrote: Hi Stephan and all, The consensus back then was to keep -Wnon-virtual-dtor switched on globally, and only switch it off (together with all other warnings) within cppumaker-generated headers, on the grounds that -Wnon-virtual-dtor was considered a useful tool to find

Re: [dev] warnings01: -Wnon-virtual-dtor

2006-02-05 Thread Nikolai Pretzell
Hi Stephan and all, The consensus back then was to keep -Wnon-virtual-dtor switched on globally, and only switch it off (together with all other warnings) within cppumaker-generated headers, on the grounds that -Wnon-virtual-dtor was considered a useful tool to find errors. However, trying

Re: [dev] warnings01: -Wnon-virtual-dtor

2006-02-01 Thread Stephan Bergmann
On Nov 2, 2005, Stephan Bergmann wrote: Hi all, http://www.openoffice.org/issues/show_bug.cgi?id=56995 shows the following problem: On compilers later than the GCC 3.4.1 we use at Hamburg (e.g., GCC 4.0.2, but from looking at the documentation also GCC 3.4.4), -Wall implies a new

Re: [dev] warnings01: -Wnon-virtual-dtor

2006-02-01 Thread Thorsten Behrens
Stephan Bergmann [EMAIL PROTECTED] writes: The only solution I see is to bite the bullet and globally disable -Wnon-virtual-dtor. Opinions? Hi Stephan, yes, I think so. But I'd still like to have this (and possibly other) warnings in an optional pedantic mode - to be run after warnings01 is

Re: [dev] warnings01: -Wnon-virtual-dtor

2006-02-01 Thread Stephan Bergmann
Stephan Bergmann wrote: On Nov 2, 2005, Stephan Bergmann wrote: Hi all, http://www.openoffice.org/issues/show_bug.cgi?id=56995 shows the following problem: On compilers later than the GCC 3.4.1 we use at Hamburg (e.g., GCC 4.0.2, but from looking at the documentation also GCC 3.4.4),

Re: [dev] warnings01: -Wnon-virtual-dtor

2006-02-01 Thread Eike Rathke
Hi Malte, On Wed, Feb 01, 2006 at 13:00:24 +0100, Malte Timmermann wrote: When we are done with warnings01, we should have most warnings in the default warning level. People don't have to use wall=tr anymore, so this one could be a candidate for some extra warning in wall=tr +1 Eike

Re: [dev] warnings01: -Wnon-virtual-dtor

2006-02-01 Thread Stephan Bergmann
Eike Rathke wrote: Hi Malte, On Wed, Feb 01, 2006 at 13:00:24 +0100, Malte Timmermann wrote: When we are done with warnings01, we should have most warnings in the default warning level. People don't have to use wall=tr anymore, so this one could be a candidate for some extra warning in

Re: [dev] warnings01: -Wnon-virtual-dtor

2005-11-03 Thread Malte Timmermann
Also +1 for switching this warning off from within idlc-generated headers only Malte. Tino Rachui - Sun Germany - Development - Software Engineer wrote: Stephan Bergmann wrote: Thus, we can either switch off -Wnon-virtual-dtor globally, or switch off *all* warnings from within

Re: [dev] warnings01: -Wnon-virtual-dtor

2005-11-03 Thread Jürgen Schmidt
Stephan Bergmann wrote: Hi all, http://www.openoffice.org/issues/show_bug.cgi?id=56995 shows the following problem: On compilers later than the GCC 3.4.1 we use at Hamburg (e.g., GCC 4.0.2, but from looking at the documentation also GCC 3.4.4), -Wall implies a new -Wnon-virtual-dtor which

Re: [dev] warnings01: -Wnon-virtual-dtor

2005-11-03 Thread Thorsten Behrens
Stephan Bergmann [EMAIL PROTECTED] writes: On such compilers, this warning will occur for each idlc-generated UNO header (com/sun/star/uno/XInterface.hpp etc.). For reasons of compatibility, it is not an option to change those idlc-generated headers and add a virtual destructor to them. Is

Re: [dev] warnings01: -Wnon-virtual-dtor

2005-11-03 Thread Stephan Bergmann
Thorsten Behrens wrote: Stephan Bergmann [EMAIL PROTECTED] writes: On such compilers, this warning will occur for each idlc-generated UNO header (com/sun/star/uno/XInterface.hpp etc.). For reasons of compatibility, it is not an option to change those idlc-generated headers and add a virtual

[dev] warnings01: -Wnon-virtual-dtor

2005-11-02 Thread Stephan Bergmann
Hi all, http://www.openoffice.org/issues/show_bug.cgi?id=56995 shows the following problem: On compilers later than the GCC 3.4.1 we use at Hamburg (e.g., GCC 4.0.2, but from looking at the documentation also GCC 3.4.4), -Wall implies a new -Wnon-virtual-dtor which warns about classes with

Re: [dev] warnings01: -Wnon-virtual-dtor

2005-11-02 Thread Daniel Boelzle
On such compilers, this warning will occur for each idlc-generated UNO header (com/sun/star/uno/XInterface.hpp etc.). For reasons of compatibility, it is not an option to change those idlc-generated headers and add a virtual destructor to them. Should be sufficient using this pragma only

Re: [dev] warnings01: -Wnon-virtual-dtor

2005-11-02 Thread Kohei Yoshida
On 11/2/05, Stephan Bergmann [EMAIL PROTECTED] wrote: Thus, we can either switch off -Wnon-virtual-dtor globally, or switch off *all* warnings from within idlc-generated headers (#pragma GCC system_header). The second option is probably preferable, as -Wnon-virtual-dtor might point to real

Re: [dev] warnings01: -Wnon-virtual-dtor

2005-11-02 Thread Tino Rachui - Sun Germany - Development - Software Engineer
Stephan Bergmann wrote: Thus, we can either switch off -Wnon-virtual-dtor globally, or switch off *all* warnings from within idlc-generated headers (#pragma GCC system_header). The second option is probably preferable, as -Wnon-virtual-dtor might point to real issues in other places of the