Re: [OSM-dev] How to check if a user has entered valid openstreetmap username/password pair using php?
On 12/03/2013 09:53, Derick Rethans wrote: You should *not* be asking for their username and password WHS in Spades. It's incredibly bad practice, isn't very robust and I for one wouldn't trust any application these days that asked me for plain credentials. J. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Changesets API call (date interval)
On 22/06/2012 09:39, Fernando Ribeiro wrote: Reading thru API documentation, I did not check any mention to get changesets by date interval. You need to look at the diffs -- the changeset XML only contains metadata, not the actual changes to the map data. See: http://wiki.openstreetmap.org/wiki/Planet.osm/diffs However, diff production is suspended at present, so you won't see any new ones appearing. J. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [josm-dev] Changed presets, contact
On 18/12/2011 13:46, Dirk Stöcker wrote: Working together with the autors of other editors also would be a good idea, but until today all such tries failed miserably. I suspect what this needs is for one person to just go ahead and implement something, and for the other editor coders to see what they've done -- similar to how MapCSS got adopted. J. ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Changed presets, contact
On 18/12/2011 15:12, Frederik Ramm wrote: But I admit that this is a kind of romantic view because it assumes that everyone easily has a server available where they could publish their styles, Github FTW. ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [OSM-dev] ER Diagram of OSM Database
On 12/12/2011 18:50, Parveen Arora wrote: Hi All, I was searching for ER Diagram of OpenStreetMap's Database to understand completely, So I would like to know If there is any available or not? http://git.openstreetmap.org/?p=rails.git;a=tree;f=db/migrate -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Where is the code that checks if the user is logged in before serving the request?
On 18/11/2011 10:42, Alexandru wrote: That's very helpful! Thanks. I looked over the code but couldn't find easily what i was looking for (i'm a java dev)... can you give me a hint on how to make any request filtered by authorization? pls As you've been told before, the OSM server stack is built using Ruby on Rails. To understand how the server works, you need to understand how Rails works -- you can't just dip into the code without knowing how the framework it's built with works. There's no real shortcut here. There are plenty of resources available: http://rubyonrails.org/documentation ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Where is the code that checks if the user is logged in before serving the request?
On 18/11/2011 12:34, Alexandru wrote: You mean there is no way to just tell the controller to ask for authorization on a specific request pattern, say like: /personal/* ; (because that's how i was thinking it would be.) Maybe if you bothered to follow the advice you've now been given several times, you'd know. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [Potlatch-dev] Potlatch2 can't contact my private osm server
On 27/10/2011 15:37, Alexandru wrote: Perhaps potlatch is not configured to contact my server, i don't know. And i don't know how to check that. http://wiki.openstreetmap.org/wiki/Potlatch_2/Deploying_Potlatch_2 tells you everything you need to know. ___ Potlatch-dev mailing list potlatch-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [OSM-dev] open source mapping with polygons?
On 17/02/2011 15:54, nittyG wrote: What I am envisioning is something where a user can create and/or manipulate polygons to show everything from population density, to rainfall and climate change, to market flows, to historical maps that can be animated. A bit like GeoCommons, then? http://geocommons.com/ -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Can't login to https://trac.openstreetmap.org/login
On 17/01/2011 20:30, Martin Ždila wrote: Hello I can't login to https://trac.openstreetmap.org/login with my username mar...@zdila.sk mailto:mar...@zdila.sk and correct password. These credentials works on the http://www.openstreetmap.org site. Have you tried logging in with your display name rather than your email address? Trac is working fine here, and I can log in. Also, there's no HTTPS support on trac, but you should get redirected if you try. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Minutely Mapnik
On 18/11/2010 21:24, Frederik Ramm wrote: I forgot what exactly it was, but there will be some cases where a node is moved from the inside to the outside or so where things foul up. The usual example is: * Way and all nodes fall outside initial bounding box of extract * One or more nodes of the way are moved inside the bounding box, but the way itself isn't changed * Way should now appear in bounding box, but doesn't. One workaround is to maintain an extract larger than you need, apply the diffs to that, then extract the true area you need. Not foolproof, but less likely to screw up. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] API 0.7+: Split node concept?
On 12/10/2010 20:45, Chris Browet wrote: I am wondering (I wonder a lot lately ;-)) if some have already given a thought to the fact that nodes actually represent 2 different concepts in the current api: - a node in the geometrical sense, i.e. used to define a linestring/way - a POI True, but the difference between the two is just the presence or lack of tags. It's not a complex technical difference. Seems to me that it would: - be less confusing, both for consumers and editors An untagged node that's a member of a way is easy to test for, and can be represented differently in any editing application just as easily as a different primitive. - save db space I'm not convinced this would be the case -- can you expand on how? - save memory/CPU cycle on the consumer side Again, I can't immediately see this. Can you explain further? I'd rather we (re-)implemented a proper area primitive in the next API version -- I think that solves more problems. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Data source for robot
On 12/10/2010 20:54, Alan Millar wrote: You can't equate the need for improvement in the data with the method used to improve it. Well, apparently you can, but it is a specious argument. Saying that data needs some improvement doesn't prove that a particular method *will* improve it either. Obviously Mr Budny cares about the data and wants to improve it, or he wouldn't be here discussing it. I'm with him on this. The road to hell is paved with good intentions. Nobody is doubting good faith here, but they are trying to warn that making automated edits to as complex a data structure as OSM isn't as simple as it seems. People need to stop shooting down every automated edit without listening to the reasoning. Are you willing to check, by hand, every single change made by this bot? If not, how can you be sure it hasn't created as many problems as it has solved? That's the problem with automated edits -- people assume they're 100% correct when experience has shown this not to be true. What's getting missed in all this is that it's far less important that OSM uses a particular data structure (that's probably isomorphic to the alternative anyway) than that the data is an accurate representation of what's on the ground. That needs people to check it, and it's a far greater job than a quick tag fix-up. By all means run the experiment offline and publish the results, just don't assume you've thought of everything, and nothing can go wrong. Jonathan. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Getting the last Element-IDs
On 11/10/2010 10:50, Peter Körner wrote: Hi Is there an API to get the highest User (and possibly Node, Way and Relation) ID? No, because it would be useless. Seconds after you got your result (if not sooner), it would be invalid. Stuff would have been created and numbers you have would no longer be the highest. Jonathan ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] How to get non-technical users easily editing (offline)?
On 22/09/2010 06:52, Sam Wilson wrote: I'm currently thinking of changing this mud-map to use the relevant OSM tile as a starting point, and getting the users to sketch in their notes and modifications over the top, and then uploading these modified tiles to our server from where I can use them as backgrounds in JOSM. I'm just wondering whether anyone's done anything like this before. Take a look at Walking Papers: http://walking-papers.org/ This does a similar thing, but with printouts that can be given to non-technical mappers to make notes on. You then scan the annotated map back into Walking Papers, which makes it available as a background in Potlatch (or JOSM, if you like). The printouts are just PDFs, so you may already be able to hack something together using Walking Papers, but certain take a look and talk to Michal. Jonathan ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] How to get non-technical users easily editing (offline)?
On 22/09/2010 11:10, Sam Wilson wrote: Unfortunately, this all has to work offline, so Potlatch can't help me. But really, that idea of limiting an editor to a specific set of tags (etc.) seems great; anyone know if one of the offline editors would lend itself to that sort of thing? As with JOSM, Merkaartor can take custom tag templates, which make entering data for specific tags easier, and they appear above the free-form tag entry fields. Merkaartor also allows you to customise the map rendering from within the application (no file editing). However, it does need installing, as opposed to JOSM's drop-in operation. If you're interested in trying Merkaartor, I can come up with a couple of simple examples, or pop into the Merkaartor mailing list. Jonathan ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
[OSM-dev] Fwd: Using OSM material for our online tool
Forwarding to the developer and legal-talk lists. Original Message Subject:Using OSM material for our online tool Date: Tue, 31 Aug 2010 11:54:38 +0200 From: Ole Brandenburg o...@stepmap.de To: annou...@openstreetmap.org CC: 'Thomas Gottfried' tho...@stepmap.de, v...@stepmap.de To whom it may concern, I would be thankful if someone can point me in the right direction. We plan to use the OSM API for our map tool (at stepmap.de). We currently have a list of roughly 1,500 pre-defined maps and a zoom-feature that enables users to create their own map/region. The OSM maps would be a great addition because of the detailed city and regional data. We would like to enable our users to access part of the OSM material and therefore plan to make use of the OSM API. Of course, we will respect the CC license and make sure that the copyrights, etc. are upheld. The technical part is pretty straight forward but I was wondering if there are any additional legal/copyright issues. Is there anything we need to discuss before going ahead? Any official guidelines that we need to consider? Thanks for your help. Best regards Ole Brandenburg Managing Director StepMap GmbH ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] OSM on Mobile
On 20/05/2010 10:52, Aditya Vikram Thoomati wrote: Any thoughts on the dev of OSM for the mobile phones?? You should probably read: http://wiki.openstreetmap.org/wiki/Software/Mobile_phones -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] XAPI compressed
On 07/04/2010 21:36, Christian H. Bruhn wrote: Is there a way to get compressed data (e.g. bz2) when I start a XAPI-query? My internet connection is not that fast, but the OSM-data can be easily compressed to 10% of the original size. As far as I'm aware, the data is output as soon as it's retrieved from the database, which makes compression somewhat difficult. You wouldn't get the data any *faster* anyway -- net bandwidth isn't the bottleneck. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] [Talk-GB] OSM shortlinks problem
On 29/03/2010 10:52, Gregory wrote: I understand avoiding the ending character from being non-alphanumeric(not letters or numbers) would mean a serious rewrite of how the shortlinks are made/decoded. How much longer would short links be if all digits were alphanumeric only? It's also allowed behaviour. '-' is a valid URI character, so any user agent that chops them off the end of a URI is broken. I realise that doesn't help the people using them, but it would be better to fix the problem in the correct place. Having said that, it looks like geohashes use [a-z0-9] which would avoid these problems. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [josm-dev] self-intersecting ways
On 26/03/2010 11:57, Frederik Ramm wrote: 1. Draw areas using same nodes as road - wrong because it suggests the area is larger than it really is. Sometimes this is the only option. Not all ways are two-lane, asphalt roads; sometimes they're narrow footpaths. If you look here: http://osm.org/go/eurTZdy5p- you'll see a residential area that shares nodes with a highway=footway. The path in question is less than a metre wide, so using separate nodes for the landuse=residential and highway=footway would be messy and just as hard to edit. Besides, the edge of the residential area *is* the footpath. If at some point I resurvey the area and find I got the position of the path wrong and decide to move it, the boundary of the residential area should move too. -- Jonathan (Jonobennett) ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [OSM-dev] Doing street names from aerial imagery
On 24/03/2010 10:52, John Smith wrote: This is a routing problem, hopefully someone has already solved it. If there is a suburb of streets mapped from aerial imagery and you have several volunteers how do you work out the most efficient path for all the voluneteers to take to grab street names with minimal overlap etc. You need to bear in mind that there will be errors in the tracing anyway -- roads marked that aren't there, and some paths missed that are there. Your volunteers will need to take this into account as well, so sticking to a pre-defined route won't work very well. Use a cake. Cake is good. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] I converted the rails port to Git
On 22/02/2010 22:01, Andy Allan wrote: ... have a few of us throwing ideas around and mixing and merging between branches without pissing off TomH by doing it in trunk and without confusing anyone by having branches like gravitystorm-and-zere-and-shauns-new-thing that are only around for a day or two. That's a very good argument for the move to Git (or another distributed SCM) -- I can see how that's useful straight away. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] I converted the rails port to Git
On 21/02/2010 22:30, Ævar Arnfjörð Bjarmason wrote: We were discussing maybe moving over to Git in #osm and I thought I'd do a quick conversion just to show how easy it is: Sorry I missed the original conversation. Can you, for the benefit of those of us not present, give a few bullet points of the benefits to OSM as a project of a move to Git (or any other SCM)? I'm interested in what problems this move would solve, not what features Git has that SVN doesn't. For what it's worth, I have nothing particularly against Git, or for SVN, but change has its cost. And I'd prefer Mercurial, purely because I use NetBeans, and it has better hg support. Not against the move, but just want to know what the project would gain. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [josm-dev] shocking - unsecure password sending!
ste...@binaervarianz.de wrote: Could someone kindly recap why good old HTTPS is not an option? A certificate costs $400 per year, that's why. ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] shocking - unsecure password sending!
ste...@binaervarianz.de wrote: HTTPS can be done with certificates free of charge, as well as self signed certificates as well as without certificates at all. The original question asked for encryption, not authentication. Of course. There wouldn't be any problem with non-technical people not understanding what's going on when their browser starts screaming about a security problem at them when they try to register at openstreetmap.org. Oh no. ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [OSM-dev] Scale markings on maps
andrzej zaborowski wrote: Also it's one of those things that should be really easy to fix Great! When do you think you'll have it done? -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Excessive version count
Ian Dees wrote: Perhaps the API should ignore (i.e. not increase rev #'s) changes that don't actually change anything? The idea isn't a bad one, but the implementation would need to be slick as to avoid bogging down the server -- it would double the number of DB queries per upload. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Excessive version count
Shaun McDonald wrote: Both the old and new nodes/ways/relations are loaded before saving the changes. So the time is how long it would take to compare the old and new values. Cool. That's the answer I was looking for. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] what server next?
Iván Sánchez Ortega wrote: Supposing that we get the rack space, what kind of machine and services would you like us to host here? Just a mapnik renderer to balance load and improve tile serving uptime? I'd suggest: * A localised front page * Cacheing proxy of the main Mapnik render * A localised render -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Planet File Change Request
Matt Amos wrote: yup. but this doesn't change the fact that, if you find something that's broken and you fix it, it'll stay fixed. ;-) You've clearly never owned a Fiat. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] how many api calls/time for an app allowed?
Gary68 wrote: - touch checks (nearly touching nodes/ways, improperly not connected) - cross checks (crossings of highways on same layer, without bridge, tunnel etc.) - roundabout check, direction - maybe more... Just checking, have you seen: http://keepright.ipax.at/ ? -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] building A openstreetmap server
Sam Mor wrote: I would to comment about I read: is it correct that everyone can build his openstreet map server? if yes , what are the needs of hardwares and softwares? Yes, you can set up your own OSM server -- the software is all open source. See http://wiki.openstreetmap.org/wiki/The_Rails_Port for more information. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [josm-dev] Combine and Merge
Ævar Arnfjörð Bjarmason wrote: If you're rewriting this perhaps you could also make it support merging two (or more) nodes two the location of a specific node, currently merge will merge to the oldest node, which isn't always what you want. +1 -- Jonathan (Jonobennett) ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [OSM-dev] [bug] direction of GPS traces
Johnny Rose Carlsen wrote: Does that mean that my non-public traces are still available to others?, I thought that they would only be shown to me. The individual points from private traces are shown when someone asks for an area download, but there's no way of telling which points in that area are from which trace, or who uploaded them. It's not possible to reconstruct a trace from just the points. -- Jonathan (Jonobennett) ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [josm-dev] JOSM version detect
Dirk Stöcker wrote: You should update. What do you think how I did compile the server stats? I generally do keep up with SVN, and that wasn't the problem. The problem was that I wasn't expecting to find the code to set the header in the file for the About box. I can see why it's been done that way, but it's still a bit ugly. It looks possible to move the generation of the version string to the build script and have the string attached to the JAR. I'll look into this, unless anyone has a violent objection? -- Jonathan (Jonobennett) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM version detect
Dirk Stöcker wrote: I think it should already be possible to display a special message inside the StartUp page when old versions are used. Writing a Trac-Plugin to analyze the HTTP headers would be required for this. I notice JOSM doesn't appear to send a custom User-Agent header at the moment -- I'll see if I can produce a patch. What were the reasons for hanging onto sun.net.www.protocol.http.Handler again? -- Jonathan (Jonobennett) ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] restrict mass-editing?
Frederik Ramm wrote: currently it is possible to select all and then set a tag for tens of thousands of objects at the same time. Do you think we should do an alert box saying you are editing 12.345 objects. are you sure you want this? - or maybe just disallow it altogether? Or remove Select All completely? Are there any legitimate uses for this? I've only ever used it to find out how much of an area I've contributed :) -- Jonathan (Jonobennett) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] restrict mass-editing?
Matt Amos wrote: indeed. i don't think frederik was suggesting that features are removed, just warn the user that they might have selected more objects than they thought. Seriously though, can you think of a legitimate use for Select All in JOSM? If removing it would prevent some editing errors without preventing anyone doing anything they need to, why not? I realise it's something people expect to find in an editing application, but if it serves no useful purpose, we shouldn't be afraid to ditch it. -- Jonathan (Jonobennett) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] [PATCH] Allow line drawing for local GPX files only
Dirk Stöcker wrote: Please attach it to a Trac ticket. Done - #2370 ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] [PATCH] Allow line drawing for local GPX files only
The attached patch modifies the options for GPX line drawing to allow
lines to be drawn only for files loaded from a local drive, and not for
layers downloaded from the OSM server. Per-layer/file preferences still
override this behaviour.
--
Jonathan (Jonobennett)
# This patch file was generated by NetBeans IDE
# Following Index: paths are relative to: Z:\Projects\JOSM\src
# This patch can be applied using context Tools: Patch action on respective
folder.
# It uses platform neutral UTF-8 encoding and \n newlines.
# Above lines and this line are ignored by the patching process.
Index: org/openstreetmap/josm/actions/OpenFileAction.java
--- org/openstreetmap/josm/actions/OpenFileAction.java Base (BASE)
+++ org/openstreetmap/josm/actions/OpenFileAction.java Locally Modified (Based
On LOCAL)
@@ -116,7 +116,7 @@
}
r = new GpxReader(is,file.getAbsoluteFile().getParentFile());
r.data.storageFile = file;
-GpxLayer gpxLayer = new GpxLayer(r.data, fn);
+GpxLayer gpxLayer = new GpxLayer(r.data, fn, true);
Main.main.addLayer(gpxLayer);
if (Main.pref.getBoolean(marker.makeautomarkers, true)) {
MarkerLayer ml = new MarkerLayer(r.data, tr(Markers from
{0}, fn), file, gpxLayer);
@@ -154,7 +154,7 @@
NmeaReader r = new NmeaReader(new FileInputStream(file),
file.getAbsoluteFile().getParentFile());
if(r.getNumberOfCoordinates()0) {
r.data.storageFile = file;
-GpxLayer gpxLayer = new GpxLayer(r.data, fn);
+GpxLayer gpxLayer = new GpxLayer(r.data, fn, true);
Main.main.addLayer(gpxLayer);
if (Main.pref.getBoolean(marker.makeautomarkers, true)) {
MarkerLayer ml = new MarkerLayer(r.data, tr(Markers from
{0}, fn), file, gpxLayer);
Index: org/openstreetmap/josm/gui/layer/GpxLayer.java
--- org/openstreetmap/josm/gui/layer/GpxLayer.java Base (BASE)
+++ org/openstreetmap/josm/gui/layer/GpxLayer.java Locally Modified (Based On
LOCAL)
@@ -82,6 +82,7 @@
private Color computeCacheColorUsed;
private colorModes computeCacheColored;
private int computeCacheColorTracksTune;
+ private boolean isLocalFile;
public GpxLayer(GpxData d) {
super((String) d.attr.get(name));
@@ -95,6 +96,12 @@
this.name = name;
}
+ public GpxLayer(GpxData d, String name, boolean isLocal) {
+ this(d);
+ this.name = name;
+ this.isLocalFile = isLocal;
+ }
+
@Override public Icon getIcon() {
return ImageProvider.get(layer, gpx_small);
}
@@ -389,7 +396,7 @@
// don't draw lines if longer than x meters
int maxLineLength =
Main.pref.getInteger(draw.rawgps.max-line-length, -1);
// draw line between points, global setting
-boolean lines = Main.pref.getBoolean(draw.rawgps.lines);
+boolean lines = (Main.pref.getBoolean(draw.rawgps.lines) ||
(Main.pref.getBoolean(draw.rawgps.lines.localfiles) this.isLocalFile));
String linesKey = draw.rawgps.lines.layer +name;
// draw lines, per-layer setting
if (Main.pref.hasKey(linesKey))
Index: org/openstreetmap/josm/gui/preferences/DrawingPreference.java
--- org/openstreetmap/josm/gui/preferences/DrawingPreference.java Base (BASE)
+++ org/openstreetmap/josm/gui/preferences/DrawingPreference.java Locally
Modified (Based On LOCAL)
@@ -26,7 +26,11 @@
public class DrawingPreference implements PreferenceSetting {
-private JCheckBox drawRawGpsLines = new JCheckBox(tr(Draw lines between
raw gps points.));
+private ButtonGroup gpsLinesGroup;
+ private JRadioButton drawRawGpsLinesAll = new JRadioButton(tr(All));
+private JRadioButton drawRawGpsLinesLocal = new JRadioButton(tr(Local
files));
+ private JRadioButton drawRawGpsLinesNone = new JRadioButton(tr(None));
+ private ActionListener drawRawGpsLinesActionListener;
private JTextField drawRawGpsMaxLineLength = new JTextField(8);
private JCheckBox forceRawGpsLines = new JCheckBox(tr(Force lines if no
segments imported.));
private JCheckBox largeGpsPoints = new JCheckBox(tr(Draw large GPS
points.));
@@ -53,30 +57,49 @@
panel.setBorder(BorderFactory.createEmptyBorder(5,5,5,5));
// drawRawGpsLines
-drawRawGpsLines.addActionListener(new ActionListener(){
+ gpsLinesGroup = new ButtonGroup();
+ gpsLinesGroup.add(drawRawGpsLinesNone);
+ gpsLinesGroup.add(drawRawGpsLinesLocal);
+ gpsLinesGroup.add(drawRawGpsLinesAll);
+
+ if(Main.pref.getBoolean(draw.rawgps.lines)) {
+ drawRawGpsLinesAll.setSelected(true);
+ } else if
(Main.pref.getBoolean(draw.rawgps.lines.localfiles)) {
+ drawRawGpsLinesLocal.setSelected(true);
+ } else {
+
Re: [josm-dev] [PATCH] Allow line drawing for local GPX files only
Jonathan Bennett wrote: The method used in this patch is based on the origin of the data, not what it happens to be named at the time. It's far more robust. ...plus it's better usability. With my patch, the user can see that this functionality is possible, explicitly. The other method requires them to figure out that it's possible, and the several steps needed to achieve the same thing -- not everyone using JOSM is a techie. J. -- Jonathan (Jonobennett) ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Difference between JOSM and JOSM-NG
Petr Nejedly wrote: When thinking of it now, I don't think starting josm-ng was a bad idea. It allowed me to prototype my ideas quickly and some of the ideas can still be taken from josm-ng and ported to josm. Petr, just out of interest, why didn't you base josm-ng on the NetBeans platform, given your day job? -- Jonathan (Jonobennett) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
