Re: [josm-dev] How to ask for confirmation at layer deletion or exit?
Holger Mappt writes: > If we never ask for confirmations then you would be able to quit JOSM > while it has modified data. Indeed, and you'll get the notice about having modified data before JOSM quits. The whole point of this is to avoid the "oh crap I just discarded my edits" moment. When people make that mistake, they usually realize it within 30 seconds. The trouble is that if you give them the option of discarding their data, they will take it! -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] How to ask for confirmation at layer deletion or exit?
Never ask for confirmations. It's never the right thing to do unless you're very short of resources, which we never are these days. Instead, provide an undo of a layer delete. When they ask to delete a layer that has changes in it, simply delete it, and pop up a non-confirmation notice that says "This layer has changes and may be restored using File/Open Recent". The problem with a confirmation is that it *really* deletes the data, which may be the wrong thing. If you're ever at a confirmation point, clearly somebody might not be thinking correctly, and their answer to the confirmation might *also* be wrong. Undo, undo, undo! Never confirm! Holger Mappt writes: > Hi, > > See https://josm.openstreetmap.de/ticket/12075. > The idea is to ask for confirmation if a GeoImageLayer with modified > image properties is deleted. What is the best/right way to do that? > > The AbstractModifiableLayer seems to serve that purpose. GeoImageLayer > could extend AbstractModifiableLayer instead of Layer. But there is not > a single file associated with the layer but one file per modified image. > There is not really a "recommended action" for the SaveLayersDialog. > The AbstractModifiableLayer would need to be extended to have something > like isAbleToUploadToServer() and isAbleToSaveToFile() to disable the > according check-boxes of the SaveLayersDialog. The logic in > Main.saveUnsavedModifications() would need to be changed to consider the > layer if neither requiresSaveToFile() nor requiresUploadToServer() > returns true. Would it make sense to add something like > requiresSomeAction() to AbstractModifiableLayer and > Main.saveUnsavedModifications()? The "action" could be a string that is > displayed in the SaveLayersDialog. > > Thanks, > Holger > > ___ > josm-dev mailing list > josm-dev@openstreetmap.org > https://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Thank You Note?
Frederik Ramm writes: Sure, even nicer to get encouraging emails from others in the project but how likely is that? I've done it. Follow #osm-us, look for users in NY (just to limit the quantity and so there's some hope of my having been in the town where the edit was), review the edit, and send a thank-you note which makes it clear that I looked at the edit. Nice job with the Lobster House, thanks! It doesn't scale well. But it would be easier if I could say to osmbot-test on #osm-us Hey, send me a DM when somebody makes an edit within these bboxes: -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Thank You Note?
Maarten Deen writes: On 2013-06-14 12:53, Frederik Ramm wrote: Hi, at the FOSSGIS conference, someone said in a presentation that the user experience in OSM could be improved if the editor were to give a simple thank you message after you have uploaded something. Thank yo for contributing to OpenStreetMap or so. Not if it requires an extra action to click the message away. All of those merely advisory messages should be 1) transparent, 2) not focus-intercepting, and 3) go away a few seconds after your next click. The reason it shouldn't go away after a period of time is in case you stepped out to get a coffee. The reason it shouldn't go away after a first click is because you might be clicking ahead of the message, and it would disappear without you getting a chance to see it. Maybe even before it finished getting rendered. That would be bad. Instead, it should wait for a click, and then wait a few seconds more. This is harmless since it doesn't interfere with editing. A prime example is No data found in this area. It's not an error. It's not even a warning. It just tells you that Yeah, I got a valid response from the OSM server which had nothing in it. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Adding your own imagery
kristy van putten writes: This is my first time on this list, so apologies if I am asking the same question as someone else. I have a team of GIS people digitising in OpenStreetMap and we have found that there is no imagery for a section of the area we really need to digitise. I have got imagery from a LiDAR survey that we (Australian Government) has full IP rights to. The format of the imagery is ECW. It's been a day since you asked this question, and nobody has responded. I suspect that's because of the image file format. I'm pretty sure that it's a proprietary image format. According to this Wiki page: http://en.wikipedia.org/wiki/ECW_%28file_format%29 , there's an SDK which is open source. It's likely to be possible to use that SDK to convert the images into bigger files in a more standard file format. Or ... use the SDK to add support to MapProxy so it can read the files and re-encode in a more generally usable file format. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Please do not change long established shortcuts
Alan Mintz writes: I don't use it every day, but those who draw buildings do (or should). Draw the roof of a tall building. Drag (usually somewhat diagonally) the whole (closed) way to move it to the correct ground position, based on whichever corner is visible at ground level. A, yes, of course. I wonder if shift-drag might not be appropriate for such uses, to split out that functionality from selection? I mean, how many times have you tried to draw a box around something, and found yourself dragging a way?? Given that the behavior is pernicious enough to warrant a protection warning, maybe it shouldn't be on the bare drag action? -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Please do not change long established shortcuts
Dirk Stöcker writes: On Mon, 30 Apr 2012, Martin Koppenhoefer wrote: is also not planned I think). There's just one big annoyance introduced: the key for delete mode. This now is impossible to select with just one hand, so you have to get the other hand off the mouse which really disturbs workflow. The D key removal was actually requested, as too many people accidentially deleted stuff. Oh, good, then can we get rid of the drag to move things feature for ways? Most of what I would call vandalism turns out to be somebody who dragged a whole way when they meant to move a single node. This problem has become worse since the ability to move a node which is part of a selected way was taken away. I don't mean to whine, because JOSM really is *that* good, but do you do ANY usability testing at all? For example, having the motion targets pop up and disappear on the right (e.g. you can't see Add in the Properties box until you've moved the cursor into the properties box) seems to break every usability principle that I know of. Fortunately, you added the feature which takes that misfeature away, so one hand giveth and the other taketh away. I think you should take Delete mode away. It's just fine for people to have to select the things they want to delete and then hit the 'delete' key. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Please do not change long established shortcuts
Toby Murray writes: Partially because of this I tend to just use the w mode to move nodes that are part of a way. OH YEAH BABY! 'w' mode is the cat's meow. Kudos to everybody who worked on that. I do most of my editing in 'w' mode now. But I do get hit by this every once in a while and usually it produces an expletive :) I'm just wondering how often you move an entire way, as opposed to a single node? You can get the same effect by selecting the way, searching for child selected, and then moving any one of the nodes. About once a month I need to move an entire way. I don't understand the use case for this feature. Can somebody (preferably somebody who uses it every day) explain it to me? -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug or Intentional
Kate Chapman writes: Hey All, When drawing ways there is no longer a line between the last point drawn and the mouse cursor. I found this useful in being able to follow where things connected as I drew. Is this a bug or intentional? If a bug I will happily fill out a ticket, I didn't see anything logged for this. Under Display Settings / Look and Feel is an option: Draw rubber-band helper line. Make sure it's still checked. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Plugin for Karlsruhe schema
Pieren writes: I don't think it is a good idea. As the relation is called, all addresses between start and end are just ... interpolation. We've had this discussion before. Here in my part of the USA, street addresses were renumbered for the convenience of the fire, police, and rescue squads. Cuz, well, everybody wants them to be able to find your house. They were renumbered according to the linear distance down your road. So ... if you know an address at the beginning of the road, and at the end of the road, you know the addresses of all the houses using linear interpolation. If you doubt me, feel free to test this theory on Pleasant Valley Road, Potsdam NY. I've entered addresses by hand AND added addresses via an import of cadastral data. Those line up very well, and I predict that if you try linearly interpolating, you'll get the same results. But don't trust my prediction ... try it for yourself. If I'm wrong, then you can prove it to me! -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] validator question, multipolygons
hbogner writes: We who use it for years know what to do, but new useras are confused. I agree. What might work for better nannying is to only run the validator on things they've changed. Otherwise they get asked to fix everything within the bounding box they downloaded. Even better than that would be to do validation continuously. Much better to catch an error right away. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] validator question, multipolygons
Dirk Stöcker writes: So a note to these of you trying to convince me that we have a major problem with validator: This opinion does not match the statistical data that we have. Especially as validator had 80% installation count even before it moved into core. Not valid data because people were told to install the validator. Better data would be How often do people click No? -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Sticky Tags Feature
Ian Dees writes: Hi JOSM Devs, I'd like to implement a feature in JOSM that applies the tags from the clipboard to every new way or node created. I think this would be useful for creating powerlines (apply power=tower to every new node in the way) or for a set of buildings along a street (addr:street=* to every new building). Does anyone have any ideas for how the interface for this might work? Maybe a menu with toggles in it? Perhaps you could select one of the presets to be default? Have a checkbox in the preset dialog which says Apply this preset automatically. When you create a new node/way/relation, if the default preset is not unsuitable, apply its values to the new item just as if the user had clicked Apply Preset while not selecting anything in the dialog. At the end of the Presets drop-down menu could be a Default Preset which would pop up the preset whose checkbox is currently selected. Would ordinarily be greyed out if nothing had been checked. Only thing wrong I see with this is that you have to create a new preset if no existing preset will set the attributes you want. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Sticky Tags Feature
Frederik Ramm writes: I'd like to implement a feature in JOSM that applies the tags from the clipboard to every new way or node created. I think this would be useful for creating powerlines (apply power=tower to every new node in the way) or for a set of buildings along a street (addr:street=* to every new building). A graphics program i used to use, maybe it was dia?, worked like this: whenever an object was selected and you changed properties, you were changing the properties of that object. When no object was selected, you were changing the default properties for new objects. Oooh! Ooooh! Much simpler than my Presets proposal. Only problem is that it might confuse newbies. Maybe put it in a different color or font to let them know that they're setting a different kind of property? -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bing imagery now available in JOSM
Stephan Knauss writes: On 01.12.2010 12:26, Sebastian Klein wrote: thanks to fast development by Ian Dees, Bing imagery can now be used in JOSM. great job, thanks to Ian for the fast response. I really like the fast loading speed of the tiles compared to WMS solutions. In contrast to the WMS I miss the possibility to correctly align the aerial images. Our data in OSM is comparable to the tracks on Bing, both match the GPS tracks. But the image is shifted south-west. In the few areas I've looked at, the Bing imagery is fine, and matches the USGS DOQ. Very happy to have it, even if in certain areas, the USGS has better data. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Geotagged Images
Hey! It's been over a year since I last used Geotagged Images, and I'm VERY impressed. The user interface has pretty much everything I want in it. It has an automatic guess, manual tuning, and time-from-photo. Well done! Now ... if only we could get it to OCR the image, look for the word Garmin and input the time from the display, we'd be all set! /me ducks. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Question about audio file mapping/synchronization
activityworkshop writes: If I convert them to waypoints in Prune and then re-export the gpx file, then JOSM shows the audio files properly. That's my experience. I wrote a converter from Columbus voice record's whack data format (BOTH CSV AND columnular data, using nulls to pad) to GPS format. Had to create waypoints for the voice data. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Major rework of the presets menu layout
What abouut this design, selected to habituate, pace Jef Raskin? Have shift-P start an incremental search through the keys, values, synonyms, and descriptions. With every key you type, it shows you the first ten ones that match. If you then type a digit corresponding to one of the matches, it immediately selects that preset. So if you're entering a bunch of railway=level_crossing, you could type Ple3 (or whatever it worked out to be). A particularly clever implementation would preserve the habituation by remembering every string that you accepted, and ensure that the same preset was always put into the appropriately numbered slot. Shaun MS McDonald writes: What I'd love to see as part of the presets, is a search, which includes synonyms, thus making it faster to access the presets than going through all of the menus. It needs synonyms as you'll often not know exactly what the preset is called, thus you could miss it, when in fact it is there, just with a different name to what you are expecting. Shaun On 24 Aug 2010, at 09:23, Ulf Lamping wrote: Hi! I've just done a major rework of the presets menu layout (SVN 3460). Hope you'll find it useful. The trigger for this work was a talk with a local mapper, who wasn't even aware that a preset for the address input actually exists ;-) Goals were: - add lot's of missing icons from mappaint (bring presets and mappaint icons closer together) - trying to group stuff together that belongs together (making it easier to find things) - split very long menus (to better fit on low resolution screens) - add some stuff I was missing In detail: - (slight) relayout of waypoints entries - add a new transport/motorcycle section - whole relayout of water menu entries (water vs. shipping) - (slight) relayout of travel/tourism entries - add a new sport/motorsport section - add a new man_made/food section (selected items from shop section go here) - relayout of man_made/shop section - whole relayout of places entries - add a new annotation section - add some entries came to mind - other minor changes I'm still a bit unhappy with the travel and man_made menu layout, but even after thinking about it for a while, I couldn't find a better alternative layout. If I'll find some time, I'll continue to bring presets and mappaint icons closer together. IMHO it's a bad idea to have different icons in the presets and mappaint for the same stuff. If interested, please review ... Regards, ULFL ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] WMS and remote-control
Frederik Ramm writes: I am however wary at how people seem to use the remote control plugin for more and more stuff... where will it end? A special request where you can send some Java code to JOSM and it will execute that ;)? Every program expands until it can send email. JOSM?? Not there yet! -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Mailing list configuration - reply address
Sebastian Klein writes: who is managing the mailing list? I would appreciate, if mails sent to the list would have Reply-To: josm-dev@openstreetmap.org in the header. This way you can answer more easily to the list. Sigh. http://russnelson.com/rt.html -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Manual zoom JOSM
Paul Johnson writes: Ctrl-= doesn't do anything, and ctrl-shift-= (to get a plus) doesn't work. Ctrl-- works, but that only zooms me out. For whatever reason, it has to be Ctrl-KP+ even though Ctrl-- also works. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Manual zoom JOSM
Keypad+ and Keypad- zoom in and out. Whether that's easy or not is another question. Shaun McDonald writes: Heh, this has just come up as a usability issue discussion at SOTM, as there is no way to be able to be able to easily zoom without a scroll wheel. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM-Tested
Matthias Julius writes: I am not saying we should hold development until all translations are complete. I would just like to give translators a chance to get their translation into a released JOSM. JOSM has never been released. Or, to put it another way, the JOSM release process is broken. JOSM is never released. People are simply told that a certain SVN version is better than other versions, and that version gets compiled for them. That's IT. As a former release manager for several projects, this frustrates the bejeezus out of me. JOSM is under constant development is not a substitute for having releases. EVERYBODY works on their open source project every day. Don't think you're so special that you don't have to release code. So, if JOSM had a standard release process, then the developers would confer amongst themselves to decide if there are any major changes underway. If not, and the code is working reasonably well, then you fork it off into a release version and a development version. The clock starts ticking. Translators are told Please check your translation. Users are told Please download and test this. Contributors are told Check the documentation and bug reports. Developers keep working, but as they fix bugs, they check them into both the release version and the development version. This works. It's a pain, but it works. You have to have somebody who acts as a release manager. They have to be willing to prod people into action, to follow up, to make the announcements everywhere, to check and double-check. If you don't do this, then you don't have a project. You just have code. Just as an extra thought, Mark Shuttleworth is trying to push open source folks into coordinating releases by date rather than by feature completion. Makes it MUCH easier for users because they get a big chunk of code, all of which is compatible with the other chunks and all of it is the latest and greatest. Anybody know what version of JOSM is in Ubuntu right now? And if we don't have a user focus, then we have no focus at all. NONE. ZERO. ZIPPO. NIL. NADA. Why am I so adament? Because except for the few projects we contribute to, WE ARE ALL USERS. Anybody here hacked on the Linux kernel? gcc? gtk? java? X? gpsd? Maybe you've contributed a little bit, but for the most part, for most things, we choose to be users. Drop by drop, the mill is turned, but if we don't make sure that OUR drop is the finest, the best, the most rounded drop ever, why should anybody else? -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM-Tested
Ævar Arnfjörð Bjarmason writes: I think JOSM's release process is awesome. Projects like JOSM that do monthly releases tend to constantly keep the code in what's basically a ready-to-release state. I actually don't use the releases, I just track trunk. And how was trunk for you when undo didn't? But the releases aren't just an arbitrary monthly snapshot. The devs make an effort to close any remaining blocker bugs before a release, but of course with everyone being a volunteer that doesn't always get done optimally. There's a lot of grunt work to be done in a release, and ... it's not happening with JOSM. I'm not volunteering, but I AM trying to point out what is missing, since some people don't seem to understand why translations don't just magically appear. Of course there are some things that could be done better, like a translation freeze a few days before release. A few days? That's optimistic. A month is a minimum. In my experience. Of course, Dirk thinks I have no experience, so that's kinda wasted breath. Small-ish projects like JOSM can actually become much worse for their users if they do proper releases. I.e. something where there's a maintenance branch that gets maintained in paralell, and things only get merged there once they're sure to work. Doing stuff like that takes a lot of manpower. My point exactly. It's hard to do releases. Don't call what JOSM does a release. JOSM does snapshots. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] JOSM unreliable network connections
Hi. My Internet connection is very unreliable lately. The leaves have come back on the trees and they're now tall enough to seriously interfere with my wifi connection. That hasn't stopped me from wanting to edit OSM, of course. Unfortunately, JOSM's behavior in the face of an unreliable connection HAS made me want to stop editing. Cancel doesn't work if you're at the step where it says Downloading OSM data... 1KB. And if you've made edits? They're lost. I'd file a bug, but see the subject of this email. This email will eventually get sent, but interactive use is frustrating at best. I think a workaround is to constantly save before hitting the 'net, but it's a workaround, not a fix. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Java Applet
Richard Fairhurst writes: jamesmikedupont at googlemail.com wrote: what a great idea, i have considered this as well. it would be a welcome replacement for potlatch What do you mean, replacement? Channelling FakeSteveC, I've finally decided to ban Potlatch, but we want to keep the Flash UI, so we're replacing it with Cloudmade's Mapzen. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-600-8815 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM Changesets?
andrzej zaborowski writes: 2009/12/29 Russ Nelson nel...@crynwr.com: Is JOSM's Changeset support not quite right? I'm thinking that the way it should work instead is NOT close Changesets ever. Instead, it should keep (all) the changeset(s) open, and if you make another edit which is within the bounding box of an open changeset, it should default to adding it to that changeset. My opinion is probably skewed by using source code repositories but imho changes should not be grouped by bboxes, instead they should be grouped logically under the changeset whose comment best fits the type of change out of those you have open. Grouping by location carries very little information, is an easy task that could be done automatically and is only slightly better than having no changesets at all. Rule #1 of HCI: have sensible defaults. If you were just editing somewhere, and noticed something you missed, and go back and fix it, it should be in the same changeset, no? So, the default should be don't close changesets and upload using a recent changeset that covers the same area. Defaults, not fixed policy. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] JOSM Changesets?
Is JOSM's Changeset support not quite right? I'm thinking that the way it should work instead is NOT close Changesets ever. Instead, it should keep (all) the changeset(s) open, and if you make another edit which is within the bounding box of an open changeset, it should default to adding it to that changeset. With this change, you don't need to ever worry about closing your changesets (they close automatically after about two hours), nor about planning ahead to make more edits to a changeset. I'm just concerned that the current design promotes excessive changeset creation. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] [PATCH 1/2] QuadBuckets (using quad tiling) for node storage in JOSM
Dave Hansen writes: So, I went and implemented it. I call it QuadBuckets, and it's basically an unbalanced 4-way radix tree structure. Well done, Dave! -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] why the new question?
Why does JOSM now prompt me to save something which I've already uploaded, even though it was never saved in the past? Seems to me that this new change solves a problem I wasn't experiencing. Here's how I think it should work, which is how it used to work (as far as I know): 0) If I load a layer and don't change it, I should never be asked if I want to delete it. 1) If I download a layer from the web, change it, and upload it, I shouldn't be asked if I want to save it. If I don't upload it, I should be prompted You haven't uploaded these changes yet: UploadDelete, Discard Changes, Cancel 2) If I load a layer from a file, change it, and save it, I shouldn't be asked if I want to save it. If I don't save it, I should be prompted You haven't uploaded these changes yet: SaveDelete, Discard Changes, Cancel 3) If I load a layer from a file, and upload it, that will remove the internal modification marks. That counts as a change. See #2. 4) If I load a layer from the web, change it, and save it as a file, I shouldn't be asked if I want to upload it. -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] WMS not working lately?
Is it just me, or has WMS not been working lately? Can anyone report success? -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] WMS not working lately?
Michael Kugelmann writes: But after deleting my old preferences and some minor tweaking at the parameters and the configuration it now works very fine again, I think, that the problems I had were caused by a very big step in updating the used versions of JOSM and plugins. That's the solution! Can we put something into the News page about If you're having trouble with WMS, try deleting your ~/.josm folder ? -- --my blog is athttp://blog.russnelson.com Crynwr supports open source software 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[OSM-dev] shortlink
We now have shortlinks on osm.org, e.g. http://osm.org/go/WKW5SAtP Can the code which does the expansion into a full openstreetmap.org URL look at the Referer: header? And if the Referer: field is the openstreetmap.org page from which the URL was created, show the user a page which has the shortlink URL? I'm at least nominally on vacation until SOTM. Bonus points if you can cause it to be pre-highlighted like tinyurl does. Double bonus points and a free beer at SOTM if we can shortlink to Wiki pages, too! -- Russ Nelson - http://community.cloudmade.com/blog - http://wiki.openstreetmap.org/wiki/User:RussNelson r...@cloudmade.com - Twitter: Russ_OSM - http://openstreetmap.org/user/RussNelson ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] Deleting TIGER node tags
On Jun 27, 2009, at 10:16 AM, Stellan Lagerstrom wrote: Greg Stark wrote: Also, are ways actually entirely in one county or another? It seems to me they would often span borders. That is how they are reported to the census bureau. Every county reports on the parts of roads that lie within its borders. They rarely match up exactly enough at the boundary for the import to be able to join them up. Where the TIGER data is in good shape, they do line up exactly. I can point you to some examples. Can you point me to some examples where they don't line up? -- Russ Nelson - http://community.cloudmade.com/blog - http://wiki.openstreetmap.org/wiki/User:RussNelson r...@cloudmade.com - Twitter: Russ_OSM - http://openstreetmap.org/user/RussNelson ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] A new take on the mutable idea
On Jun 21, 2009, at 6:49 AM, Richard Fairhurst wrote: Frederik Ramm wrote: However, we'll have more and more imports like boundaries, seamarks and so on, which I like to consider mutable for people who know exactly what they're doing. Is this actually a real-world problem right now, or something we think might possibly one day become one? Legal boundaries *aren't* a real-world problem right now? We need to have them in OSM otherwise people will start adding them. And yet, if the data came from an import from the governmental body responsible for maintaining the legal description, what justification could anybody have for changing them (pace anarchists, but even anarchists will recognize land registries as long as they're voluntary). -- Russ Nelson - http://community.cloudmade.com/blog - http://wiki.openstreetmap.org/wiki/User:RussNelson r...@cloudmade.com - Twitter: Russ_OSM - http://openstreetmap.org/user/RussNelson ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] A new take on the mutable idea
On Jun 21, 2009, at 10:15 AM, Matt Amos wrote: we went over this before: if it isn't editable, it shouldn't be in OSM. And yet state and county borders are already in OSM. You seem to not be paying attention to my point: that if we DON'T have these important legal boundaries in OSM, people will add them. Don't believe me? Try deleting the New York State border with Pennsylvania, and see how long it takes for somebody to revert your edit, or worse, add it back in as a new set of nodes and ways. Yes, I acknowledge your point about people being able to edit things, and being able to verify things on the ground. If (as I assert) it's not possible to keep these things out of the map, shouldn't we take steps to ensure that when they're in the map, they're as correct as they can be? -- Russ Nelson - http://community.cloudmade.com/blog - http://wiki.openstreetmap.org/wiki/User:RussNelson r...@cloudmade.com - Twitter: Russ_OSM - http://openstreetmap.org/user/RussNelson ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] A new take on the mutable idea
On Jun 19, 2009, at 6:49 PM, Frederik Ramm wrote: or alternatively make it easy to spot whether such data may have been changed by accident. There are a lot of reasons to have this facility. It matches in concept with Wikipedia's watchlist. -- Russ Nelson - http://community.cloudmade.com/blog - http://wiki.openstreetmap.org/wiki/User:RussNelson r...@cloudmade.com - Twitter: Russ_OSM - http://openstreetmap.org/user/RussNelson ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] finding OSM users by their home locations
On May 31, 2009, at 3:50 PM, Paul Johnson wrote: Matt Amos wrote: in my opinion it's evil to contact users who haven't opted in to be contacted. it's a valid point of view that they implicitly opted in, but i don't think this is what most users intended when they added a home location - it's certainly not what i intended. I'm not sure it's a valid point of view beyond the current assumption: You want to hear from other OSM users trying to contact you, without necessarily revealing contact information. It's generally OK to assume people want to hear from other humans, but not OK to assume they want automated or bulk messages without them opting in first. I think trying to push beyond that might result in folks reporting OSM messages as spam, which is an annoying and sometimes expensive problem to fix. Err on the conservative side of sending things en masse or automatically unless it's been specifically requested. On the other hand, OSM is a community and it's fair to contact OSM users about OSM events. So, what I've been doing to err on the conservative side, as Paul suggests, is to send email only to people who have 1) edited near 2) their home as they've marked it in OSM. The intersection of 1) editors near the party and 2) home users near the party is about 1/8th as large as the union. I think that's reasonably conservative. Unless we have a consensus for me to stop, I will continue this practice and help my fellow ambassies (it's a new word. If nobody ever makes up new words, and we keep wearing out the old ones, we'll end up just grunting at each other) use it too. It will result in less email sent, so is an overall decrease in any evil as Matt describes it. -- Russ Nelson - http://community.cloudmade.com/blog - http://wiki.openstreetmap.org/wiki/User:RussNelson r...@cloudmade.com - Twitter: Russ_OSM - http://openstreetmap.org/user/RussNelson ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] finding OSM users by their home locations
On May 31, 2009, at 7:00 AM, Matt Amos wrote: if we want to keep the map on the users' pages showing the nearest other users to them, we might as well offer this data publicly. as russ said, it's one script and a bunch of server load away from being public anyway. Right. If we want to protect people's privacy, then we should change the map on the users' pages. We shouldn't claim to protect people's privacy and then do so ineffectually. in my opinion it's evil to contact users who haven't opted in to be contacted. it's a valid point of view that they implicitly opted in, but i don't think this is what most users intended when they added a home location - it's certainly not what i intended. By this principle, nobody -- not any individual editor, not the OSMF -- can send email to any user. And yet, OSM has an email system, and people are encouraged to use it to ask users about their edits. i like jochen's idea of being able to additionally put in a bbox (or maybe several) that are areas of interest - please contact me about OSM activities in this area. we could then make the users' home locations private, +1 And then create a way to Send an email to a location which gets archived so that people who come along later can see earlier messages posted to that location. If we could get those bounding boxes (to protect privacy, without usernames), that could also let us find the places in which nobody (or few people) are interested. If there are holes in the interest level, then the map isn't going to be very good in those locations. -- Russ Nelson - http://community.cloudmade.com/blog - http://wiki.openstreetmap.org/wiki/User:RussNelson r...@cloudmade.com - Twitter: Russ_OSM - http://openstreetmap.org/user/RussNelson ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
[OSM-dev] finding OSM users by their home locations
The OSM webserver will tell you the ten people with home locations closest to your home location. It would be useful to be able to get more than that, for the purpose of inviting people to attend mapping parties so they can become more effective and enthusiastic OSM contributors. If you move your home location to the location of the mapping party, you can get ten people, and if you move it around some more, you can get more than just those ten. So, being intolerant of boring, repetitive activities, I've written a program to find OSM users by their home location. You give it a lat,lon, and the radius in degrees of the circle in which you want to find people, and it repeatedly changes your home location until it's gotten everyone. Is this program a good thing or a bad thing? If it's a good thing, then great, I'll use it. If it's a bad thing, then how do we stop other people less cooperative than myself from writing the same program? -- Russ Nelson - http://community.cloudmade.com/blog - http://wiki.openstreetmap.org/wiki/User:RussNelson r...@cloudmade.com - Twitter: Russ_OSM - http://openstreetmap.org/user/RussNelson ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [josm-dev] trac overcautios spam filter
Dirk Stöcker writes: You had IP 127.0.0.1 and thus the same as the spammer who tried to fill the Trac yesterday. GAH! I say you should ping-flood him, and if that doesn't bring him down, hack into his machine and delete all his files. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] [OSM-newbies] Upload error
Andy Robinson \(blackadder-lists\) writes: Should perhaps JOSM be able to detect ways with too many nodes and offer to split them on download? It's very easy to shift a whole way and then end up needing to upload a huge changeset that bombs on the 2k limit. YES! JOSM shouldn't let you create an edit which can't be uploaded. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] New GPX implementation
Frederik Ramm writes: I don't, however, see a pressing need to support any and all extended GPX features. Actually, JOSM makes a fine GPX editor. Great for removing those birds nests when you stopped for lunch. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] New GPX implementation
Henrik Niehaus writes: No one interested? Is JAXB a separate library? How does this extra code affect the portability? -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] New GPX implementation
Henrik Niehaus writes: Russ Nelson schrieb: Henrik Niehaus writes: No one interested? Is JAXB a separate library? How does this extra code affect the portability? If you use Java = 1.5, JAXB is a separate library. Java 1.6 includes a JAXB implementation. Portability in terms of runnable on Win, Mac, Linux? JAXB is pure Java and depends on Java 1.5, so it should run on any platform, which supports Java 1.5 or better. Sounds like this patch would cause JOSM to not work under Java 1.5. I suggest that we not use it, sorry. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Combine and Merge
Greg Troxel writes: I don't actually care which node controls the resulting location, but it seems obvious the first one added to the selection should be it. Yup. The nodes seem to get sorted numerically by id. That's correct for display purposes, but not for the purpose of choosing the code to hold the location. I'll take a look at it. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Commit message not empty
Frederik Ramm writes: The leave empty if unsure makes it easy for users to ignore the concept and I don't want to make this easy for them. I agree with Fred. I also agree with other people who say that it's annoying. It *is* annoying AND necessary. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Combine and Merge
Can we combine and merge Combine and Merge? Combine: combines ways. Merge: combines nodes. If there's no objection, I'll write the patch. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Split Way / UnGlue Ways
Can we combine Split Way and UnGlue Ways? They operate on distinct selections except in the case of having one node selected. Then, UnGlue Ways creates two nodes, whereas Split Way creates two ways. This is easily resolved by eliminating the Split Way case -- you have to say which way you want split and where you want it split. The new command would be named Separate. *UnGlue Ways(one node) - assigns original node to one way, and creates a new node for other ways. Copies tags. If the node only belongs to one way, the tags aren't copied to the node which is left in the way. UnGlue Ways(one way) - creates new nodes for all nodes shared with another way. UnGlue Ways(multiple nodes) - error (but why not just iterate?) UnGlue Ways(one node, one way) - same as UnGlue Ways(one node) *Split Way(one or more nodes) - locates the way to which the node(s) is a member and splits it. Split Way(one way) - silently ignored (greyed out in menu). Split Way(one way, one or more nodes) - splits way at each node. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Combine and Merge
Russ Nelson writes: Can we combine and merge Combine and Merge? No, I suggest this instead: Can we combine, join, and merge Combine, Join Node to Way, and Merge? Combine Way(two or more ways) - combines ways. Combine Way(two or more ways with any number of node selections) - combines ways, ignores node selection. Merge(two or more nodes) - combines nodes. Merge(two or more nodes with any number of ways) - ignored (greyed out) Join Node(one node) - joins node into one or more of the nearest ways. Join Node(one way) - ignored but not greyed out. Join Node(multiple nodes) - ignored but not greyed out. We make a new command called Join (which is the mirror of Separate): Join(two or more ways) - combines ways. Join(two or more nodes) - combines nodes. Join(one node and one way) - inserts the node into the way at the nearest point. If it's not near, throw a message saying Not near enough Join(one node and multiple ways) - for each way: Join(node, way) Join(one way and multiple nodes) - for each node: Join(node, way) Join(multiple ways and multiple nodes) - error: Too many things selected -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Combine and Merge
Ævar Arnfjörð Bjarmason writes: On Thu, Apr 23, 2009 at 6:58 PM, Russ Nelson nel...@crynwr.com wrote: Can we combine and merge Combine and Merge? Combine: combines ways. Merge: combines nodes. If there's no objection, I'll write the patch. If you're rewriting this perhaps you could also make it support merging two (or more) nodes two the location of a specific node, currently merge will merge to the oldest node, which isn't always what you want. I recall that the resultant node used to have the average location of both nodes, but now it seems to use the first node listed in the Current Selection box. Seems like if you don't like this behavior, Perhaps the combine way has this problem as well? Not really. The ways are already touching, so nothing needs to get moved. The tags from both ways get piled into the new way. If there are any tags with different values in the different ways, you get asked which value to use. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Commit message not empty
Pieren writes: like to describe my changes but not always. But when I see that I have to do it, it makes me so angry that I write anything excepted what I could kindly write otherwise. Does it make you angry that you have to click in the Upload button to commit your changes? OSM has been fairly free of vandalism and griefing, but as the project grows, it will happen. We need to have procedures in place to deal with hurtful people. -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] style TIGER
I've made a slight change to my style file so that ways which have tiger:reviewed are rendered specially. It's important that people review the TIGER data because it's not so reliable. I'd like to get this into JOSM. Should I just submit a patch? -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Nicely done!
So, I found this nifty-neato GPS receiver which will record an audio file and georeference it: http://community.cloudmade.com/blog/?p=340 I had to write a Python program to turn its goofy pseudo-CSV file into a proper GPX file which JOSM understands. I can now drag-and-drop this file into JOSM, and it will show me the tracks and waypoints, whether audio or plain. If audio, I see a speech bubble, which I can click on and have it play back the audio I recorded. Excellent! Well done! It Just Works(tm). -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Add nodes functionality changed?
Stefan Breunig writes: So far, only 4 people are complaining. Doesn't sound heavily used to me. Oh, I thought that proper functionality was going to be restored, so I didn't bother complaining. :-) I can see that the functionality is still there -- just hit escape between every click -- but the use case of shift-click, shift-click, shift-click, shift-click to create a bunch of unconnected nodes -- is not satisfied by needing to hit escape every time. How often do I do that? When I've got a bunch of POIs to create from waymarks and want to create them at once, and then tag them en mass (e.g. churches). -- --my blog is athttp://blog.russnelson.com Cloudmade supports http://openstreetmap.org/ 521 Pleasant Valley Rd. | +1 315-323-1241 Potsdam, NY 13676-3213 | Sheepdog ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] further missing nodes patch
A few improvements to my earlier missing nodes patch:
o Add a missing call to parseDataSetOsm
o Don't report *every* error, just the first five.
Index: src/org/openstreetmap/josm/io/OsmServerObjectReader.java
===
--- src/org/openstreetmap/josm/io/OsmServerObjectReader.java(revision 1442)
+++ src/org/openstreetmap/josm/io/OsmServerObjectReader.java(working copy)
@@ -10,6 +10,8 @@
import org.openstreetmap.josm.data.osm.DataSet;
import org.xml.sax.SAXException;
+import javax.swing.JOptionPane;
+
public class OsmServerObjectReader extends OsmServerReader {
public final static String TYPE_WAY = way;
@@ -46,11 +48,16 @@
if (in == null)
return null;
Main.pleaseWaitDlg.currentAction.setText(tr(Downloading OSM
data...));
-final DataSet data = OsmReader.parseDataSet(in, null,
Main.pleaseWaitDlg);
+final OsmReader osm = OsmReader.parseDataSetOsm(in, null,
Main.pleaseWaitDlg);
+final DataSet data = osm.getDs();
+
// String origin =
Main.pref.get(osm-server.url)+/+Main.pref.get(osm-server.version, 0.5);
// Bounds bounds = new Bounds(new LatLon(lat1, lon1), new
LatLon(lat2, lon2));
// DataSource src = new DataSource(bounds, origin);
// data.dataSources.add(src);
+if (osm.getParseNotes().length() != 0) {
+JOptionPane.showMessageDialog(Main.parent,
osm.getParseNotes());
+}
in.close();
activeConnection = null;
return data;
Index: src/org/openstreetmap/josm/io/OsmReader.java
===
--- src/org/openstreetmap/josm/io/OsmReader.java(revision 1442)
+++ src/org/openstreetmap/josm/io/OsmReader.java(working copy)
@@ -74,6 +74,7 @@
* a newline-terminated string.
*/
private String parseNotes = new String();
+ private int parseNotesCount = 0;
public String getParseNotes() {
return parseNotes;
}
@@ -372,7 +373,12 @@
for (long id : e.getValue()) {
Node n = findNode(id);
if (n == null) {
- parseNotes += tr(Skipping a way because it includes
a node that doesn''t exist: {0}\n, id);
+ /* don't report ALL of them, just a few */
+ if (parseNotesCount++ 6) {
+ parseNotes += tr(Skipping a way because it
includes a node that doesn''t exist: {0}\n, id);
+ } else if (parseNotesCount == 6) {
+ parseNotes += ...\n;
+ }
failed = true;
break;
}
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Download area from slippy map
Maarten Deen writes: I just came across something: how do you zoom out on the slippymap download option when you don't have a mousewheel? E.g. on a laptop? Get a better laptop? In the meantime, you can use the Map tab to select a larger area. Perhaps not the greatest solution, but it works. Did I just say perhaps? -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Cloudmade supports http://openstreetmap.org/| slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Josm wiki macros?
Does this construct work correctly in the JOSM Trac system:
[[{Josmimage(download.png)}]]
In theory it goes to the JOSM svn, pulls out images/download.png, and
displays it using img src=whatever/.
I'm trying to edit the Introduction page and insert icons directly
from the source, but not having any luck.
--
--my blog is athttp://blog.russnelson.com | Delegislation is a slippery
Cloudmade supports http://openstreetmap.org/| slope to prosperity.
521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom.
Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter).
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Josm wiki macros?
Russ Nelson writes: I'm trying to edit the Introduction page and insert icons directly from the source, but not having any luck. AHA! Discovered an alternate method for specifying the path to the image: [[Image(source:trunk/images/download.png)]] I'll fix the other two instances of [[Josmimage(...)]] which aren't working. -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Cloudmade supports http://openstreetmap.org/| slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM Fail
Petr Nejedly writes: Well, as long as Undo is reliable, making useful feature harder to use/discover is a nonsense. I helped her find Undo. scares me a bit, though. Ctrl+Z works all around the world and it's even listed in the Edit menu as usual. She moved the way back where it was. (but of course she didn't move it *exactly* back where it was.) But while we can teach people, we need to understand that they have a certain level of computer skillset, and need to work with them at their level. ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
Shaun McDonald writes: One option might be to manually make one and use one of the development test servers at http://apis.dev.openstreetmap.org to test it. (Yes it will mean messing with XML manually). This sounds like the best way to test it. Unfortunately, I don't know how to do what you suggest. Could you go into more detail, or else just set it up yourself? Is it sufficient to simply pick a node out of a way and then delete it manually by calling the API directly? -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Crynwr sells support for free software | PGPok | slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
Dirk Stöcker writes: http://josm.openstreetmap.de/ticket/1712 Incomplete ways are discarded without notice Could you go ahead and apply the patch in this email? http://lists.openstreetmap.org/pipermail/josm-dev/2008-December/002293.html I may never get around to improving it beyond it's current state, but for now it's an improvement over the current code and is worth using. At least having it there prevents bit rot and allows somebody else to pitch in and improve it. -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Crynwr sells support for free software | PGPok | slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
Dirk Stöcker writes: On Mon, 29 Dec 2008, Russ Nelson wrote: I'm not certain it's correct to change the other calls: In io/OsmServerObjectReader.java, it's reading from the API. Will the API ever hand out ways without their nodes? Same for io/OsmServerLocationReader.java and io/BoundingBoxDownloader.java. I think so. If I remember correctly I added that report because the API didn't give me a certain way. But as I cannot be sure probably adding the request at all places is the best. Hrm. I don't like submitting a patch that I haven't tested. Does anybody know of a way which is missing a node? -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Crynwr sells support for free software | PGPok | slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
Dirk Stöcker writes:
http://josm.openstreetmap.de/ticket/1712
Incomplete ways are discarded without notice
This is a minimal patch. I didn't want to make too many changes
because somebody else is going to have to read this patch before they
apply it. I don't know Java very well, so if anybody spots anything
un-Javanic, please tell me.
Potential improvements:
o convert all invocations of OsmReader.parseDataSet() to
OsmReader.parseDataSetOsm() to gain access to getParseNotes().
o Doing something more sensible with the output presentation if
there are too many warnings than can fit on the screen (or will it
switch to a scrollbox?)
o It's possible that DataSet ought to be the entity that has
parseNotes. That would make for a simpler patch, but not
necessarily more correct.
Index: src/org/openstreetmap/josm/actions/OpenFileAction.java
===
--- src/org/openstreetmap/josm/actions/OpenFileAction.java (revision 1180)
+++ src/org/openstreetmap/josm/actions/OpenFileAction.java (working copy)
@@ -74,10 +74,14 @@
private void openAsData(File file) throws SAXException, IOException,
FileNotFoundException {
String fn = file.getName();
if
(ExtensionFileFilter.filters[ExtensionFileFilter.OSM].acceptName(fn)) {
-DataSet dataSet = OsmReader.parseDataSet(new
FileInputStream(file), null, Main.pleaseWaitDlg);
+OsmReader osm = OsmReader.parseDataSetOsm(new
FileInputStream(file), null, Main.pleaseWaitDlg);
+DataSet dataSet = osm.getDs();
OsmDataLayer layer = new OsmDataLayer(dataSet, file.getName(),
file);
Main.main.addLayer(layer);
layer.fireDataChange();
+if (osm.getParseNotes().length() != 0) {
+JOptionPane.showMessageDialog(Main.parent,
osm.getParseNotes());
+}
}
else
JOptionPane.showMessageDialog(Main.parent, fn+: +tr(Unknown
file extension: {0}, fn.substring(file.getName().lastIndexOf('.')+1)));
Index: src/org/openstreetmap/josm/io/OsmReader.java
===
--- src/org/openstreetmap/josm/io/OsmReader.java(revision 1180)
+++ src/org/openstreetmap/josm/io/OsmReader.java(working copy)
@@ -59,8 +59,18 @@
* The dataset to add parsed objects to.
*/
private DataSet ds = new DataSet();
+ public DataSet getDs() { return ds; }
/**
+ * Record warnings. If there were any data inconsistencies, append
+ * a newline-terminated string.
+ */
+ private String parseNotes = new String();
+ public String getParseNotes() {
+ return parseNotes;
+ }
+
+ /**
* The visitor to use to add the data to the set.
*/
private AddVisitor adder = new AddVisitor(ds);
@@ -332,6 +342,7 @@
for (long id : e.getValue()) {
Node n = findNode(id);
if (n == null) {
+ parseNotes += Skipping a way because it includes a
node that doesn't exist: + id + \n;
failed = true;
break;
}
@@ -434,6 +445,10 @@
* elemet found there is returned.
*/
public static DataSet parseDataSet(InputStream source, DataSet ref,
PleaseWaitDialog pleaseWaitDlg) throws SAXException, IOException {
+ return parseDataSetOsm(source, ref, pleaseWaitDlg).ds;
+ }
+
+ public static OsmReader parseDataSetOsm(InputStream source, DataSet ref,
PleaseWaitDialog pleaseWaitDlg) throws SAXException, IOException {
OsmReader osm = new OsmReader();
osm.references = ref == null ? new DataSet() : ref;
@@ -467,6 +482,6 @@
if (o.id 0)
o.id = 0;
- return osm.ds;
+ return osm;
}
}
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Tasks for all of you
Dirk Stöcker writes: http://josm.openstreetmap.de/ticket/1712 Incomplete ways are discarded without notice What should be done? Throw an exception immediately? Load the way anyway, ignoring missing points, and throw an exception after everything has been loaded? In theory, the semantics of this file are as unacceptable as if it wasn't an XML file at all, and so the proper thing to do is throw away the entire contents of the file. In practice, this file may contain valuable data and the best thing to do is select all the ways in error and report an error message. -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Crynwr sells support for free software | PGPok | slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Search and | ?
Dirk Stöcker writes: On Sat, 20 Dec 2008, Russ Nelson wrote: That's exactly the problem. '|' ends up being a string rather than a token. If somebody checks this in, tell me and I'll restore the docs Fixed in r1149. Thanks. I like the way that the Python folks keep the documentation for old revisions online. Maybe we could establish the practice of putting a version number on the documentation pages in the wiki? And whenever a new release is put out, make a copy of the documentation into a new page carrying the version number, and edit it to reflect the changes. Or for that matter, we could write documentation in docbook form, and ship the HTML fork with JOSM. Then they'd have it on hand if they happen to be editing offline. When is the next release planned? -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Crynwr sells support for free software | PGPok | slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Search and | ?
Ævar Arnfjörð Bjarmason writes: * http://josm.openstreetmap.de/ticket/1864 - Search doesn't support regex search on keys and/or values The problem is always the user interface. I can think of several ways to implement regexps: 1) just implement them. Instead of doing a liberal substring search, do a regexp search, always treating their input as a regexp. That has the unhappy effect of forcing regexp character interpretation, which may give them results which differ from the previous behavior (but for the most part would give them the same results). 2) keep the current substring search for unqualified string searches, but use regexps if they supply a colon (to search in K:V) or user: . That has the unhappy effect of not being obvious. 3) use a prefix character to indicate a regexp search, e.g. all regexps must start with ^. Not likely that any literal searches would start with ^. 4) Add it as an option in the Search box: [] use regular expressions * http://josm.openstreetmap.de/ticket/1865 - Implement selection stack M, what do you do if something that was selected got deleted? Regex search would come in particularly handy. I don't know how hard it would be to hack the tokenizer to support it however as regexes could contain characters that are currently considered tokens, such as : and | and . Tokenizer not hard to fix. It already allows quoted strings, which may contain anything but a quote character. -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Crynwr sells support for free software | PGPok | slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Search and | ?
Hi. Should | be used to separate two or terms of a search? Or is OR the only token? I ask because | is not recognized by the tokenizer as a token, and yet http://wiki.openstreetmap.org/wiki/JOSM/Search_function (used to until I changed it) claim that | could be used to separate two or terms of a search. Just wondering: should I fix the code or leave the documentation fixed? -- --my blog is athttp://blog.russnelson.com | Delegislation is a slippery Crynwr sells support for free software | PGPok | slope to prosperity. 521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom. Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter). ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Search and | ?
Ævar Arnfjörð Bjarmason writes:
Just wondering: should I fix the code or leave the documentation fixed?
The code, | should work as OR but doesn't. There's a bug filed for
this (which I didn't find).
Probably mine.
I looked at it for a bit recently but didn't manage to fix it before
getting distracted with other things, but I suspect one of the
tokenizer rules is being too agressive and slurping up foo|bar as a
literal token or something like that. At least that's how it gets
parsed IIRC.
That's exactly the problem. '|' ends up being a string rather than a
token. If somebody checks this in, tell me and I'll restore the docs
to include | as a synonym for OR. I've made other improvements to
the docs. If somebody familiar with the intended operation could give
them a once-over look, I'd appreciate it.
http://wiki.openstreetmap.org/wiki/JOSM/Search_function
nel...@nelson-desktop:~/osm/trunk$ svn diff
Index: src/org/openstreetmap/josm/actions/search/PushbackTokenizer.java
===
--- src/org/openstreetmap/josm/actions/search/PushbackTokenizer.java
(revision 1147)
+++ src/org/openstreetmap/josm/actions/search/PushbackTokenizer.java
(working copy)
@@ -53,6 +53,8 @@
return (;
case ')':
return );
+ case '|':
+ return |;
case '':
s = new StringBuilder( );
for (int nc = search.read(); nc != -1 nc !=
''; nc = search.read())
@@ -69,7 +71,7 @@
return +s.toString();
}
c = (char)next;
- if (c == ' ' || c == '\t' || c == '' || c ==
':' || c == '(' || c == ')') {
+ if (c == ' ' || c == '\t' || c == '' || c ==
':' || c == '(' || c == ')' || c == '|') {
search.unread(next);
if (s.toString().equals(OR))
return |;
--
--my blog is athttp://blog.russnelson.com | Delegislation is a slippery
Crynwr sells support for free software | PGPok | slope to prosperity.
521 Pleasant Valley Rd. | +1 315-323-1241 | Fewer laws, more freedom.
Potsdam, NY 13676-3213 | Sheepdog | (Not a GOP supporter).
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
