including the list of fields being moved in the commit message
> (i.e. the code excerpt above) so that it's clearer what's changing.
ACK
> Some more below:
>
> On Wed, May 11, 2022 at 10:52:41AM -0400, Aaron Conole wrote:
>> During the sweep stage, revalidator will co
)
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2081773
Reported-by: Numan Siddique
Suggested-by: Ilya Maximets
Signed-off-by: Aaron Conole
---
include/openvswitch/flow.h | 2 +-
tests/classifier.at| 27 +++
2 files changed, 28 insertions(+), 1 deletio
te, it would be really cool to get some
OSS-Fuzz runs as a robot for periodic testing. Right now, I don't think
anyone but you / Ben has access to these issues as they pop up. For
example, I can't check the oss-fuzz issue "Permissions Denied."
Acked-by: Aaron Conol
: Always report ODP_FIT_TOO_LITTLE for IGMP.")
Signed-off-by: Aaron Conole
Acked-by: Eelco Chaudron
---
v1->v2: Add unit test for coverage of mcast traffic when not doing snooping
v2->v3: Add a unit test for the non-dummy datapaths as well to demonstrate the
matching issue.
v3-
in ofpacts_pull_openflow_actions__ lib/ofp-actions.c:7820
> #5 0x5409e1 in ofpacts_pull_openflow_instructions lib/ofp-actions.c:8396
> #6 0x5608a8 in ofputil_decode_flow_stats_reply lib/ofp-flow.c:1100
>
> Acked-by: Adrian Moreno
> Signed-off-by: Dumitru Ceara
> ---
Acke
ovs/./include/openvswitch/ofp-actions.h:222:12
> #1 0x66b2cf in ofpacts_put_openflow_actions
> /root/ovs/lib/ofp-actions.c:8861:5
> #2 0x6ffdd1 in ofputil_encode_flow_mod /root/ovs/lib/ofp-flow.c:447:9
> [...]
>
> Signed-off-by: Dumitru Ceara
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
lic121 writes:
> On Mon, Apr 25, 2022 at 08:47:32AM -0400, Aaron Conole wrote:
>> lic121 writes:
>>
>> > Max allowed conntrack entries is configurable with
>> > 'ovs-appctl dpctl/ct-set-maxconns' command. In real scenarios,
>> > this configurati
roto.at
>
> 7. Modified documentation highlighting the change
> utilities/ovs-ofctl.8.in
> NEWS
>
> Signed-off-by: Vasu Dasari
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html
> ---
Same as previous - looks good, but needs a respin due to NEWS
/2020-December/050820.html
> ---
Thanks for the work on this - sorry for the late review.
In general, it looks good. It will need to be rebased for the NEWS
entries, otherwise it applies cleanly still.
Acked-by: Aaron Conole
> v1:
> - Addressed code review comments from Ben Pfaff:
>
yangchang writes:
> If the flow contains protocol types, that the later fragment packets of
> UDP6 and ICMPv6 cannot hit the flow. So the later fragment packets should
> be set next header protocl types, too.
>
> Signed-off-by: yangchang
> ---
How does this change the discussion at:
lic121 writes:
> Max allowed conntrack entries is configurable with
> 'ovs-appctl dpctl/ct-set-maxconns' command. In real scenarios,
> this configuration is expected to survive from host reboot.
>
> Signed-off-by: lic121
> ---
One complication is that there are 2 other conntrack
Eelco Chaudron writes:
> Guess this is a known issue, please check out this patch:
>
> https://patchwork.ozlabs.org/project/openvswitch/patch/20220106180704.2388658-1-acon...@redhat.com/
>
>
> Aaron any update on the v5 patch?
Yes, I'm respinning now and will post by next week
> //Eelco
>
>
>
Paolo Valerio writes:
> Signed-off-by: Paolo Valerio
> ---
> lib/meta-flow.xml |9 +
> 1 file changed, 9 insertions(+)
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/
The github actions API is currently undergoing some kind of outage - and
has been for the last 12-14 hours (from what I can see). This
particular issue seems to impact how we can retrieve results from
various runs. I am working towards a workaround that will let us move
past this.
GitHub is
main vswitchd/ovs-vswitchd.c:129
> #11 0x7fbdfd43eb74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
> #12 0x4072fd in _start (/root/ovs/vswitchd/ovs-vswitchd+0x4072fd)
>
> Signed-off-by: Dumitru Ceara
> ---
Acked-by: Aaron Conole
___
Ilya Maximets writes:
> On 4/6/22 16:53, Aaron Conole wrote:
>> Dumitru Ceara writes:
>>
>>> On 4/5/22 21:20, Aaron Conole wrote:
>>>> Dumitru Ceara writes:
>>>>
>>>>> On 4/5/22 16:41, Aaron Conole wrote:
>>>>>>
Dumitru Ceara writes:
> On 4/5/22 21:20, Aaron Conole wrote:
>> Dumitru Ceara writes:
>>
>>> On 4/5/22 16:41, Aaron Conole wrote:
>>>> Dumitru Ceara writes:
>>>>
>>>>> This is undefined behavior and was reported by UB Sanitizer
Dumitru Ceara writes:
> On 4/5/22 16:41, Aaron Conole wrote:
>> Dumitru Ceara writes:
>>
>>> This is undefined behavior and was reported by UB Sanitizer:
>>> lib/meta-flow.c:3445:16: runtime error: member access within null pointer
>>> of type
ofp-errors.c:253
> #2 0x7d2617 in ofp_print_error_msg lib/ofp-print.c:435
> #3 0x7d3eb7 in ofp_to_string__ lib/ofp-print.c:998
> #4 0x7d47fb in ofp_to_string lib/ofp-print.c:1244
> #5 0x8dcc4b in do_send lib/vconn.c:688
> #6 0x8dca64 in vconn_send lib/vconn.c:671
>
pact representation of the set_field action uses more
> bytes in memory (for the extra alignment). Change the test to use
> dec_ttl instead.
>
> Signed-off-by: Dumitru Ceara
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Eelco Chaudron writes:
> On 4 Apr 2022, at 23:54, Paolo Valerio wrote:
>
>> Aaron Conole writes:
>>
>>> Paolo Valerio writes:
>>>
>>>> The next header contained in the last extension header of the IPv6
>>>> later frags still con
Dumitru Ceara writes:
> This is undefined behavior and was reported by UB Sanitizer:
> lib/meta-flow.c:3445:16: runtime error: member access within null pointer
> of type 'struct vl_mf_field'
> #0 0x6aad0f in mf_get_vl_mff lib/meta-flow.c:3445
> #1 0x6d96d7 in mf_from_oxm_header
b233504033db ("openvswitch: kernel datapath clone action")
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
to the user-provided action list. That
> prevents some code generalization too.
>
> Fixes: 34ae932a4036 ("openvswitch: Make tunnel set action attach a metadata
> dst")
> Link: https://mail.openvswitch.org/pipermail/ovs-dev/2
this we send the kernel a corrected array of sockets the size
> of all CPUs in the system. In the above example we would create a
> corrected array as follows:
> [S0, S1, S1, S2, S2, S3, S3, S4, S4, S5, S5, S0]
>
> This guarantees that regardless of which CPU a packet comes in th
Paolo Valerio writes:
> The next header contained in the last extension header of the IPv6
> later frags still contain the information of the upper layer protocol
> number.
>
> Similarly to what OvS does for IPv4, allow L4 matches for later IPv6
> frags as well by processing later frags and
Paolo Valerio writes:
> The next header contained in the last extension header of the IPv6
> later frags still contain the information of the upper layer protocol
> number.
>
> Similarly to what OvS does for IPv4, allow L4 matches for later IPv6
> frags as well by processing later frags and
penvswitch/ovs/commit/beb75a40fdc295bfd6521b0068b4cd12f6de507c
> Reported-by: Roi Dayan
> Signed-off-by: Ilya Maximets
> Acked-by: Nicolas Dichtel
> Acked-by: Aaron Conole
> Link:
> https://lore.kernel.org/r/20220309222033.3018976-1-i.maxim...@o
ot;)
> Signed-off-by: Ilya Maximets
> ---
Thanks for also adding some input validation.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Mohammad Heib writes:
> IPsec unit tests uses tcpdump to capture and validate the ESP
> traffic so the test must be skipped in environment that don't
> have the tcpdump tool installed.
>
> Signed-off-by: Mohammad Heib
> ---
> tests/system-ipsec.at | 7 ---
> 1 file changed, 4
these two operations are linked, the
ovs_ct_nat_execute() function should always make sure that the
sw_flow_key is updated after a successful call through NAT infrastructure.
Fixes: 5d50aa83e2c8 ("openvswitch: support asymmetric conntrack")
Cc: Dumitru Ceara
Cc: Numan Siddique
Signed-off-by:
Eelco Chaudron writes:
> On 17 Mar 2022, at 13:17, Aaron Conole wrote:
>
>> During NAT, a tuple collision may occur. When this happens, openvswitch
>> will make a second pass through NAT which will perform additional packet
>> modification. This will update the skb da
these two operations are linked, the
ovs_ct_nat_execute() function should always make sure that the
sw_flow_key is updated after a successful call through NAT infrastructure.
Fixes: 5d50aa83e2c8 ("openvswitch: support asymmetric conntrack")
Cc: Dumitru Ceara
Cc: Numan Siddique
Signed-
t;
> Fixes: 28a3f0601727 ("net: openvswitch: IPv6: Add IPv6 extension header
> support")
> Link:
> https://lore.kernel.org/netdev/3adf00c7-fe65-3ef4-b6d7-6d8a0cad8...@nvidia.com
> Link:
> https://github.com/openvswitch/ovs/commit/beb75a40fdc295bfd6521b0068b4cd12f6de507c
&g
CT_DIR_MAX] member in the conn which consists of key and a
> cmap_node for hash lookup. Both keys can now be accessed in the
> following way:
>
> conn->key_node[CT_DIR_{FWD,REV}].key
>
> similarly to what Aaron Conole suggested.
>
> This patch avoids the extra allocation for
Ilya Maximets writes:
> On 2/23/22 19:58, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>>> On 1/6/22 19:07, Aaron Conole wrote:
>>>> This reverts commit c645550bb249 ("odp-util: Always report
>>>> ODP_FIT_TOO_LITTLE for IGMP.")
>
Ilya Maximets writes:
> On 1/6/22 19:07, Aaron Conole wrote:
>> This reverts commit c645550bb249 ("odp-util: Always report
>> ODP_FIT_TOO_LITTLE for IGMP.")
>>
>> Always forcing a slow path action can result in some over-broad
>> flows which swal
Peng He writes:
> In the commit 1df7f7aac8c976690167261fec9a50d832ef9e7e, the packet
> metadata's in_port has been changed from ofp port into odp port,
> however, the odp->flow->in_port is still ofp_port. This patch changes
> the odp->flow->in_port into odp_port.
>
> Fixes: 1df7f7aac8
Hi Michael,
"Phelan, Michael" writes:
> Hi all,
>
> As presented at the OVS conference in December, the AVX-512 CI is coming
> online today to test incoming
> patches to the OVS mailing list with AVX-512 implementations enabled. The CI
> will download and apply
> patches before compiling OVS
ed
> at that point in time. Installing it separately to fix the issue,
> so pip can find compatible versions of packages by backtracking.
>
> Signed-off-by: Ilya Maximets
> ---
Ugh.
Acked-by: Aaron Conole
___
dev mailin
t of
cache misses as at the time of calling ipf_ctx_eq, ipf_list is cache-hot.
On x86_64, this trick saves 2% of CPU usage of ipf processing.
Signed-off-by: Peng He
Co-authored-by: Mike Pattrick
Signed-off-by: Aaron Conole
---
lib/conntrack.c | 9 ---
lib/conntrack.h
Signed-off-by: Aaron Conole
---
NEWS | 4 ++
lib/conntrack-tp.c | 11 +
lib/conntrack-tp.h | 2 +
lib/ct-dpif.c| 56 ++
lib/ct-dpif.h| 9 +
lib/dpctl.c
ot;)
Fixes: e32cd4c6292e ("conntrack: ignore port for ICMP/ICMPv6 NAT.")
Signed-off-by: Paolo Valerio
Acked-by: Eelco Chaudron
Acked-by: Aaron Conole
Signed-off-by: Aaron Conole
---
tests/system-traffic.at | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff
Hello Ilya
Here are a few fixes for master as well as one feature that was
in progress at the time of the 2.17 branch. Request is to apply
to master and 2.17
Regards,
Aaron
The following changes since commit dadd8357f22464232a071fe813c5f6950a5c680c:
ofproto-dpif: Fix issue with
.
This happends when there are multiple CT zones, and frags are
reassembled in ct(zone=X) might be 'stealed' into the ct(zone=Y).
Signed-off-by: Peng He
Acked-by: Mike Pattrick
Signed-off-by: Aaron Conole
---
lib/conntrack.c | 2 +-
lib/ipf.c | 10 --
lib/ipf.h | 1 +
3 files changed
oto-dpif: Restore packet metadata when a
continuation is resumed.")
Signed-off-by: Peng He
Acked-by: Mike Pattrick
Signed-off-by: Aaron Conole
---
ofproto/ofproto-dpif.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 8143dd9
t; Signed-off-by: Wan Junjie
> ---
This is a good idea. Thanks.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Aaron Conole writes:
> we...@ucloud.cn writes:
>
>> From: wenxu
>>
>> Now, the default timeout policy for netdev datapath is hard codeing. In
>> some case show or modify is needed.
>> Add command for get/set default timeout policy. Using like this:
>>
;conntrack: Add support for NAT.")
> Fixes: e32cd4c6292e ("conntrack: ignore port for ICMP/ICMPv6 NAT.")
> Signed-off-by: Paolo Valerio
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
we...@ucloud.cn writes:
> From: wenxu
>
> Now, the default timeout policy for netdev datapath is hard codeing. In
> some case show or modify is needed.
> Add command for get/set default timeout policy. Using like this:
>
> ovs-appctl dpctl/ct-get-default-tp [dp]
> ovs-appctl
e Pattrick
> ---
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Since we're testing serialization, it also makes sense to test
> the opposite operation. Should be useful in the future for
> exploring possible optimizations.
>
> CMD: $ ./tests/ovstest json-string-benchmark
>
> Signed-off-by: Ilya Maximets
&
Peng He writes:
> by using ipf_list's key instead of first frags' metadata can reduce
> quite a lot of cache access as by the time calling ipf_ctx_eq, ipf_list
> is cache-hot.
>
> Signed-off-by: Peng He
> ---
Is there a reason not to just fold this into 1/3? It's strange to
introduce
dpif-netdev: Forwarding optimization for flows with a
> simple match.")
> Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=43498
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
I'm trying to follow the oss-fuzz guide but can't seem to get a
: Always report ODP_FIT_TOO_LITTLE for IGMP.")
Signed-off-by: Aaron Conole
Acked-by: Eelco Chaudron
---
v1->v2: Add unit test for coverage of mcast traffic when not doing snooping
v2->v3: Add a unit test for the non-dummy datapaths as well to demonstrate the
matching issue.
v3-
; Signed-off-by: Ilya Maximets
> ---
LGTM.
Acked-by: Aaron Conole
> lib/odp-util.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index fbdfc7ad8..33867200a 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-uti
Dumitru Ceara writes:
> On 12/21/21 16:44, Aaron Conole wrote:
>> Dumitru Ceara writes:
>>
>>> UB Sanitizer report:
>>> lib/dp-packet.h:297:39: runtime error: applying zero offset to null
>>> pointer
>>> #0 0x7946f5 in dp_packet_t
Dumitru Ceara writes:
> Signed-off-by: Dumitru Ceara
> ---
Acked-by: Aaron Conole
This is awesome!
I need to spend more time with a few of the patches in here.
Thanks for all this work, Dumitru!
___
dev mailing list
d...@openvswitch.org
Dumitru Ceara writes:
> UB Sanitizer report:
> lib/dp-packet.h:297:39: runtime error: applying zero offset to null pointer
> #0 0x7946f5 in dp_packet_tail /root/ovs/./lib/dp-packet.h:297:39
> #1 0x794331 in dp_packet_tailroom /root/ovs/./lib/dp-packet.h:325:49
> #2 0x7942a0
84 ad 04 00 05 46 61 73 74 45 74 68 65 72 6e 65 74 20 31 2f 35 e0
> 91 07 c9 3e 7f 00 00 80
>^
> #0 0x718d63 in lldp_tlv_end lib/lldp/lldp.c:149
> #1 0x7191de in lldp_send lib/lldp/lldp.c:184
> #2 0x484d6c in test_aa_send tests/test-aa.c:238
>
#5 0x4072f7 in main tests/test-ovsdb.c:79
> #6 0x7fa858675b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
> #7 0x4060ed in _start (/root/ovs/tests/test-ovsdb+0x4060ed)
>
> Signed-off-by: Dumitru Ceara
> ---
Acked-by: Aaron Conole
c:396:33: runtime error: left shift of 1 by 31 places
> cannot be represented in type 'int'
> #0 0x571b9f in dpif_netlink_open lib/dpif-netlink.c:396
>
> Signed-off-by: Dumitru Ceara
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
I think this makes a lot of sense
to me.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
nt 1, which is declared to never be null
> #0 0x4df5d8 in frozen_state_equal ofproto/ofproto-dpif-rid.c:159
> #1 0x4dfd27 in recirc_find_equal ofproto/ofproto-dpif-rid.c:179
> [...]
>
> Signed-off-by: Dumitru Ceara
> ---
Acked-by: Aaron Conole
alue. Avoid the undefined
> behavior by casting to 'void *' first.
>
> Signed-off-by: Dumitru Ceara
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
FINDEX) operation, just
> return -ENODEV.
>
> Signed-off-by: Lin Huang
> Test-by: Mike Pattrick
> Reviewed-by: Aaron Conole
> Reviewed-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Ilya Maximets (2):
> Set release date for 2.16.2.
> Prepare for 2.16.3.
>
> NEWS | 6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Ilya Maximets writes:
> Ilya Maximets (2):
> Set release date for 2.14.4.
> Prepare for 2.14.5.
>
> NEWS | 6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Ilya Maximets writes:
> Ilya Maximets (2):
> Set release date for 2.15.3.
> Prepare for 2.15.4.
>
> NEWS | 6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Ilya Maximets writes:
> Ilya Maximets (2):
> Set release date for 2.13.6.
> Prepare for 2.13.7.
>
> NEWS | 6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
e vhost-user ping tests
> reliability.")
> Signed-off-by: David Marchand
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Mike Pattrick writes:
> On Wed, 2021-12-01 at 14:46 +0100, Eelco Chaudron wrote:
>>
>> On 29 Nov 2021, at 22:02, Aaron Conole wrote:
>>
>> > This reverts commit c645550bb249 ("odp-util: Always report
>> > ODP_FIT_TOO_LITTLE for IGMP.")
>&g
Mike Pattrick writes:
> On Wed, 2021-12-01 at 14:46 +0100, Eelco Chaudron wrote:
>>
>> On 29 Nov 2021, at 22:02, Aaron Conole wrote:
>>
>> > This reverts commit c645550bb249 ("odp-util: Always report
>> > ODP_FIT_TOO_LITTLE for IGMP.")
>&g
Greetings,
The second day of the fall conference will be starting at 17:00 UTC. In
case the joining information didn't come through via the EventBrite
email, or in case you lost the joining information, here are the
instructions for joining Day 2.
NOTE: Day 2 uses a different event link /
Greetings,
The fall conference will be starting at 17:00 UTC. In case the
joining information didn't come through via the EventBrite email, or in
case you lost the joining information, here are the instructions for
joining Day 1.
NOTE: Day 2 will use a different event link.
To join, select
Thanks everyone for your interest in the OvS+OVN Fall '21 Conference,
which is taking place on Dec. 7th & 8th, 2021. There is just about 24
hours left until the conference start time, so here are a few reminders
and important announcements.
Please make sure you are registered using the Event
: Always report ODP_FIT_TOO_LITTLE for IGMP.")
Signed-off-by: Aaron Conole
Acked-by: Eelco Chaudron
---
v1->v2: Add unit test for coverage of mcast traffic when not doing snooping
v2->v3: Add a unit test for the non-dummy datapaths as well to demonstrate the
matching issue.
lib/odp
Greetings,
Registration is now open for the Open vSwitch and OVN annual conference,
taking place this year as a virtual event on December 7 and 8, hosted on
the bluejeans platform. To register, please visit:
https://www.eventbrite.com/e/ovsovn-21-conference-registration-217640256867
There are
Maxime Coquelin writes:
> Instead of waiting 10 seconds for testpmd to start, this
> patch makes use of OVS_WAIT_UNTIL() macro to wait for
> the Virtio device readiness notification in ovs-vswitchd
> logs.
>
> Signed-off-by: Maxime Coquelin
> ---
A
as splitting on.
>
> Signed-off-by: Mike Pattrick
> ---
Thanks for the fix. I noticed it when I ran
$ ./utilities/checkpatch.py -f ofproto/ofproto.c
and the line numbers started to drift. With this change, I don't see
that behavior any longer.
Acked-by: Aaron Conole
___
Ilya Maximets writes:
> On 11/17/21 17:58, Aaron Conole wrote:
>> Mike Pattrick writes:
>>
>>> Recently there has been a lot of press about the "trojan source" attack,
>>> where Unicode characters are used to obfuscate the true functionality
submitted version of checkpatch.py when testing).
WDYT, Ilya, Gaëtan?
In either case:
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
@@ def main():
> print("ERROR: Unable to properly setup the mirror: %s." % str(oe))
> try:
> ovsdb.destroy_port(mirror_interface,
> ovsdb.port_bridge(interface))
> +if tap_created is True:
> +_del_taps[sys.platform](mirror_i
Hi Peng,
Peng He writes:
> From: Peng He
>
> ipf_postprocess will emit packets into the datapath pipeline ignoring
> the conntrack context, this might casuse weird issues when a packet
> batch has less space to hold all the fragments belonging to single
> packet.
>
> Given the below ruleest
Eelco Chaudron writes:
> On 9 Nov 2021, at 15:42, Aaron Conole wrote:
>
>> This reverts commit c645550bb249 ("odp-util: Always report
>> ODP_FIT_TOO_LITTLE for IGMP.")
>>
>> Always forcing a slow path action can result in some over-broad
>>
esubmit(,1) in the first flow in table 0
> are never applied. This patch fixes this issue.
>
> Fixes: 5b34f8fc3b38 ("Add a new OVS action check_pkt_larger")
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2018365
> Reported-by: Ihar Hrachyshka
> Signed-off-by: Num
: Always report ODP_FIT_TOO_LITTLE for IGMP.")
Signed-off-by: Aaron Conole
Acked-by: Eelco Chaudron
---
v1: Add test case as requested
lib/odp-util.c | 5 ---
ofproto/ofproto-dpif-xlate.c | 1 -
tests/mcast-snooping.at | 72
3 files ch
Ilya Maximets writes:
> On 11/1/21 15:47, Aaron Conole wrote:
>> This reverts commit c645550bb249 ("odp-util: Always report
>> ODP_FIT_TOO_LITTLE for IGMP.")
>>
>> Always forcing a slow path action can result in some over-broad
>> flows which swal
Hi Peng,
Peng He writes:
> ipf_postprocess will emit packets into the datapath pipeline ignoring
> the conntrack context, this might casuse weird issues when a packet
> batch has less space to contain all the fragments belonging to single
> packet.
>
> Given the below ruleest and consider
: Always report ODP_FIT_TOO_LITTLE for IGMP.")
Signed-off-by: Aaron Conole
---
lib/odp-util.c | 5 -
ofproto/ofproto-dpif-xlate.c | 1 -
2 files changed, 6 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index fbdfc7ad83..0f21ffe639 100644
--- a/lib/odp-util.c
> Category Impact on Throughput
> Kernel datapath- 5%
> Usermode datapath - 16%
> DPDK datapath - 29%
>
> Signed-off-by: Mike Pattrick
> ---
Looks good to me. Thanks for preserving the port teardown as well.
Acked-by: Aaron Conole
> utilities/ovs-tcpd
of docutils package. By forcing the upgrade, we created a broken
situation. Remove the upgrade command and trust pip3.
Signed-off-by: Aaron Conole
Reported-by: Ilya Maximets
---
.ci/linux-prepare.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh
gh. Prepare section still has exceoptions, but at least build seems to
be working.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
| 6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
| 6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
| 6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
| 6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
for 2.12.4.
> Prepare for 2.12.5.
>
> NEWS | 6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Acked-by: Aaron Conole
___
dev mailing list
d...@op
501 - 600 of 2017 matches
Mail list logo
