Re: [ovs-dev] [PATCH] datapath-windows: Update OvsIPv4TunnelKey flags in geneve decap.

m> Thanks for the fix. Acked-by: Nithin Raju <nit...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix potential memory leak while creating conntrack entry

Acked-by: Nithin Raju <nit...@vmware.com<mailto:nit...@vmware.com>> Thanks, -- Nithin R Manager, NSBU On Jun 21, 2017, at 10:08 AM, Sairam Venugopal <vsai...@vmware.com<mailto:vsai...@vmware.com>> wrote: OvsCtAddEntry returns TRUE or FALSE depending on whethe

Re: [ovs-dev] [PATCH] datapath-windows: Add validations for IP_HEADER_LEN

am <r...@vmware.com> Acked-by: Nithin Raju <nit...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Define NAT_ACTION enum correctly

re.com<mailto:r...@vmware.com>> Acked-by: Nithin Raju <nit...@vmware.com<mailto:nit...@vmware.com>> Thanks, -- Nithin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath-windows: use NlAttrGet() in Conntrack.c

Couple of minor fixes that got flagged with a static checker. Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/Conntrack.c| 14 ++ datapath-windows/ovsext/Netlink/Netlink.c | 2 +- datapath-windows/ovsext/Netlink/NetlinkProto.h | 2

Re: [ovs-dev] [PATCH] windows: Broken internal netdevs

Thanks for the fix. Acked-by: Nithin Raju <nit...@vmware.com> From: ovs-dev-boun...@openvswitch.org <ovs-dev-boun...@openvswitch.org> on behalf of Alin Serdean <aserd...@cloudbasesolutions.com> Sent: Friday, February 17,

Re: [ovs-dev] [PATCH 1/4] doc-windows: Remove obsolete documentation

Alin, My suggestion would be to hold off on finalizing the documentation until we squash all the pending bugs. Looks like we are getting there. Thanks, -- Nithin On Feb 4, 2017, at 12:21 AM, Alin Serdean > wrote: Hard

Re: [ovs-dev] [PATCH 4/4] doc-windows: Consolidate switch names in documentation

hi Alin, I second Shashank’s thoughts. I prefer the name “OVS-Extended-Switch”, it makes documentation explicit. I’d prefer to keep it that way. I’m sure that once users are familiar with the documentation, they can pretty much pick whatever name they want. Thanks, -- Nithin On Feb 4, 2017,

Re: [ovs-dev] OVS-Hyper-V-Discovery-Agent Design Document

:00 PM -0800, "Ben Pfaff" <b...@ovn.org<mailto:b...@ovn.org>> wrote: Does this actually call for vswitchd to add ports? Reading it, it looks like the new daemon does that. But I didn't read it carefully enough to understand it in full. On Mon, Nov 28, 2016 at 11:13:21PM +0

Re: [ovs-dev] OVS-Hyper-V-Discovery-Agent Design Document

hi Alin, Thanks for the comments. There has not been a case so far (AFAIK) where vswitchd added ports to OVSDB. This would be a diversion from that. We’ll have to take this up with Ben or Justin to see how they feel. Thanks, -- Nithin On Nov 28, 2016, at 11:18 AM, Alin Serdean

Re: [ovs-dev] [PATCH] datapath-windows: Avoid busy wait in OvsStartIpHelper

Acked-by: Nithin Raju <nit...@vmware.com<mailto:nit...@vmware.com>> Thanks, -- Nithin On Nov 22, 2016, at 9:53 AM, Shashank Ram <r...@vmware.com<mailto:r...@vmware.com>> wrote: Previously, the IP Helper thread would wait for an event but with a timeout of 0, which res

[ovs-dev] [PATCH] datapath-windows: else-if block in OvsExtNetPnPEvent

Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/Switch.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/Switch.c b/datapath-windows/ovsext/Switch.c index 825fa3c..87dbc5e 100644 --- a/datapath-windows/ovsext/Sw

Re: [ovs-dev] [PATCH v2] datapath-windows: Set isActivated flag only on success

Acked-by: Nithin Raju <nit...@vmware.com> Thanks, -- Nithin -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Monday, October 10, 2016 at 3:43 PM To: Shashank Ram <r...@vmware.com>, &q

Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last module number

-Original Message- From: dev on behalf of Guru Shetty Date: Tuesday, September 20, 2016 at 7:40 AM To: Shashank Ram Cc: ovs dev Subject: Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last

Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last module number

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Monday, September 19, 2016 at 4:21 PM To: Shashank Ram <r...@vmware.com>, "dev@openvswitch.org"

Re: [ovs-dev] [PATCH v2] datapath-windows: Add define for last module number

Much better. Thanks for addressing the comments. Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Shashank Ram <r...@vmware.com> Date: Monday, September 19, 2016 at 3:24 PM To: "dev@openvswitch.or

Re: [ovs-dev] [PATCH] datapath-windows: Add define for last module number

Only comment I had was to nuke the OVS_DBG_RESERVED and treat OVS_DBG_LAST itself as the last bit. Basically, we are restricting this to 32 since ŒovsLogLevel¹ is 32 bits. We can probably do: BUILD_ASSERT(OVS_DBG_LAST < 31) BUILD_ASSERT(OVS_DBG_LAST < sizeof ovsLogLevel). Thanks for the

Re: [ovs-dev] [PATCH] datapath-windows: Fix conntrack event handler

Loos good. Can you pls. add the following comment as well: /* Driver intiated messages should have zero seq number */ Acked-by: Nithin Raju <nit...@vmware.com> >>Fix an issue with the OvsReadEventCmdHandler when handling conntrack >>events. Reverting the previous re

[ovs-dev] [PATCH] datapath-windows: update CodingStyle

Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/CodingStyle | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath-windows/CodingStyle b/datapath-windows/CodingStyle index 3550cdb..40873e8 100644 --- a/datapath-windows/CodingStyle +++ b/datapath-windows/Codin

Re: [ovs-dev] [PATCH] Windows: Update the Driver and MSI properties

LGTM. One quick question: > + Is this because we are using NDIS 6.30? Otherwise, we should keep it closer to the OVS version. Acked-by: Nithin Raju <nit...@vmware.com> -- Nithin -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam

Re: [ovs-dev] [PATCH] datapath-windows: Encapsulate packet when src port is tunnel port

Acked-by: Nithin Raju <nit...@vmware.com> >On 9/1/16, 2:54 PM, "Sairam Venugopal" <vsai...@vmware.com> wrote: > >>If a packet arrives on a tunnel port and is again transmitted on a tunnel >>port, the packet needs to be encapsulated. >> >>Eg: &

[ovs-dev] [PATCH v2] datapath-windows: add assert in OvsHashFlow()

Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/Flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index 439fb28..2e8b42b 100644 --- a/datapath-windows/ovsext/Flow.c +++ b/datapath-windows/

[ovs-dev] [PATCH] datapath-windows: add assert in OvsHashFlow()

Also fix a minor indentation issue in User.c Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/Flow.c | 1 + datapath-windows/ovsext/User.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/

Re: [ovs-dev] [PATCH] datapath-windows: remove invalid ASSERT in Flow.c

Ok. Thanks for the review. -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Yin Lin <yinli...@gmail.com> Date: Wednesday, August 31, 2016 at 5:05 PM To: Nithin Raju <nit...@vmware.com> Cc: "dev@openvswitch.org" <dev@openvswitch.org

[ovs-dev] [PATCH] datapath-windows: remove invalid ASSERT in Flow.c

Since the Geneve changes, the key->l2.offset will no longer be 0 when the tunnel key is valid within the OVS flow key. key->l2.offset would be determined by the amount of tunnel options. Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/DpIn

Re: [ovs-dev] [RFC] datapath-windows: Allow validation ports processing

Alin, Do you intend to add them to the vport hash tables? What is the use of doing this? Also, will it not create a collision in the hash table? When the vport gets added from userspace, we should make sure that we don¹t use the validation port as a valid port. -- Nithin -Original

Re: [ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs

h-windows: Fix various Geneve bugs >Signed-off-by: Yin Lin <li...@vmware.com> Acked-by: Nithin Raju <nit...@vmware.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 2/2] Windows: Use NETLINK_NETFILTER instead of NETLINK_GENERIC

Acked-by: Nithin Raju <nit...@vmware.com> One another change that comes to mind is the validation that a socket of type NETLINK_GENERIC does not send a CT command and vice-versa. It should be a small change within Datapath.c and can be done as a incremental patch. -Original Message

Re: [ovs-dev] [PATCH v3 1/2] Windows: Add support for handling protocol (netlink family)

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: Sairam Venugopal <vsai...@vmware.com> Date: Tuesday, July 12, 2016 at 2:41 PM To: Nithin Raju <nit...@vmware.com> Subject: FW: [PATCH v3 1/2] Windows: Add support for handling protocol (netlink family)

Re: [ovs-dev] [PATCH] Windows: Add support for handling protocol (netlink family)

Thanks for doing this. Looks good but for a few cosmetic comments. Also, remember to flip the protocol for nf sockets in userspace to NETLINK_NETFILTER. IIRC, we use NETLINK_GENERIC. Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvs

[ovs-dev] [PATCH] datapath-windows: remove unused 'ovsUserTimestampDelta'

Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/Flow.h | 1 - 1 file changed, 1 deletion(-) diff --git a/datapath-windows/ovsext/Flow.h b/datapath-windows/ovsext/Flow.h index 0744d30..23d252c 100644 --- a/datapath-windows/ovsext/Flow.h +++ b/datapath-windows/

Re: [ovs-dev] [PATCH v5 00/11] Windows: Add support for debugging conntrack from userspace

pting netfilter-netlink messages from userspace and executing the >command. The supported commands include flushing conntrack entries and >dumping them. > >v2: Addresed review comments from Paul Boca <pb...@cloudbasesolutions.com> >v3: Added the ACKED-BY for the ones that were

Re: [ovs-dev] [PATCH v5 10/11] Windows: Add conntrack dump and flush support in userspace

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Friday, July 1, 2016 at 1:49 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [ovs-

Re: [ovs-dev] [PATCH v5 04/11] datapath-windows: Add support for flushing conntrack entries

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Friday, July 1, 2016 at 1:49 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [

Re: [ovs-dev] [PATCH v4 11/11] Windows: Ignore the dpif conversions for windows in netlink-conntrack.c

y be more appropriate :) Looks good otherwise. Acked-by: Nithin Raju <nit...@vmware.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 10/11] Windows: Add conntrack dump and flush support in userspace

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Wednesday, June 29, 2016 at 5:08 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject:

Re: [ovs-dev] [PATCH v4 09/11] datapath-windows: Track the number of conntrack entries

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Wednesday, June 29, 2016 at 5:08 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [

Re: [ovs-dev] [PATCH v4 08/11] datapath-windows: Add support for Conntrack IPCTNL_MSG_CT_GET cmd in Datapath.c

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Wednesday, June 29, 2016 at 5:08 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [

Re: [ovs-dev] [PATCH v4 07/11] datapath-windows: Conntrack - Handle memory allocation failure

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Wednesday, June 29, 2016 at 5:08 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [

Re: [ovs-dev] [PATCH v4 06/11] datapath-windows: Add support for dump-conntrack in datapath

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Wednesday, June 29, 2016 at 5:08 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [

Re: [ovs-dev] [PATCH v4 05/11] datapath-windows: Add support for Conntrack IPCTNL_MSG_CT_DELETE cmd in Datapath.c

Acked-by: Nithin Raju <nit...@vmware.com> >+ > /* Windows kernel datapath extensions to the standard datapath >interface. */ > > /* Version number of the datapath interface extensions. */ >@@ -65,6 +68,8 @@ > #define OVS_WIN_NL_VPORT_FAMILY_ID (NL

Re: [ovs-dev] [PATCH v4 04/11] datapath-windows: Add support for flushing conntrack entries

Looks good but for a few comments. >+static __inline NDIS_STATUS >+OvsCtFlush(UINT16 zone) >+{ >+PLIST_ENTRY link, next; >+POVS_CT_ENTRY entry; >+ >+LOCK_STATE_EX lockState; >+NdisAcquireRWLockWrite(ovsConntrackLockObj, , 0); >+ >+for (int i = 0; i < CT_HASH_TABLE_SIZE; i++) {

Re: [ovs-dev] [PATCH v4 03/11] datapath-windows: Add new NlFillOvsMsgForNfGenMsg method in Netlink.c

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Wednesday, June 29, 2016 at 5:08 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [

Re: [ovs-dev] [PATCH v4 02/11] datapath-windows: Add support for Netfilter netlink message

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Wednesday, June 29, 2016 at 5:08 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [

Re: [ovs-dev] [PATCH v4 01/11] Windows: Add conntrack netfilter netlink definitions to kernel and userspace

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Wednesday, June 29, 2016 at 5:08 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject:

Re: [ovs-dev] [PATCH] datapath-windows: Cleanup conntrack-tcp.c

return CT_UPDATE_INVALID; >>> } >>> >>>-if ((tcp->syn) && dst->state >= CT_DPIF_TCPS_FIN_WAIT_2 && >>>-src->state >= CT_DPIF_TCPS_FIN_WAIT_2) { >>>+if (((tcp_flags & (TCP_SYN|TCP_ACK)) == TCP_SYN) > >Why do we need to include TCP_ACK in the check? We spoke offline. This is a bug fix. Acked-by: Nithin Raju <nit...@vmware.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath-windows: Cleanup conntrack-tcp.c

Looks good but for a comment. Acked-by: Nithin Raju <nit...@vmware.com> >On 6/24/16, 6:14 PM, "Sairam Venugopal" <vsai...@vmware.com> wrote: > >>Update the code to use tcp->flags. This keeps the kernel conntrack-tcp.c >>file in sync with usersp

Re: [ovs-dev] [PATCH v3 9/9] datapath-windows: Add support for Conntrack IPCTNL_MSG_CT_GET cmd in Datapath.c

-Original Message- From: dev on behalf of Sairam Venugopal Date: Friday, June 24, 2016 at 12:03 PM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH v3 9/9] datapath-windows: Add support for Conntrack

Re: [ovs-dev] [PATCH v3 8/9] datapath-windows: Conntrack - Handle memory allocation failure

- Handle memory allocation failure >Return null if Windows fails to allocate memory for the conntrack entry. > >Signed-off-by: Sairam Venugopal <vsai...@vmware.com> >Acked-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com> Acked-by: Nithin Raju <nit...@vmware.com

Re: [ovs-dev] [PATCH v3 7/9] datapath-windows: Add support for dump-conntrack in datapath

Looks good but for a few comments. Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Friday, June 24, 2016 at 12:03 PM To: "dev@openvswitch.org" <dev

Re: [ovs-dev] [PATCH v3 6/9] datapath-windows: Add new NlFillOvsMsgForNfGenMsg method in Netlink.c

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Friday, June 24, 2016 at 12:03 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject:

Re: [ovs-dev] [PATCH v3 5/9] Windows: Add conntrack-flush support in userspace

Just one suggestion, but looks good otherwise. Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sairam Venugopal <vsai...@vmware.com> Date: Friday, June 24, 2016 at 12:03 PM To: "dev@openvswitch.or

Re: [ovs-dev] [PATCH v3 4/9] datapath-windows: Add support for Conntrack IPCTNL_MSG_CT_DELETE cmd in Datapath.c

Looks good but for a couple of suggestions. >/* Windows kernel datapath extensions to the standard datapath interface. >*/ > > /* Version number of the datapath interface extensions. */ >@@ -65,6 +68,7 @@ > #define OVS_WIN_NL_VPORT_FAMILY_ID (NLMSG_MIN_TYPE + 4) > #define

Re: [ovs-dev] [PATCH v3 1/9] Windows: Add netfilter-conntrack header files to Include folder

>On Mon, Jun 27, 2016 at 11:57 AM, Nithin Raju <nit...@vmware.com> wrote: >> Only comment is to add the OVS license on top of each non-empty file. >> Looks like the original code does not have any licence, but it would >>still >> make sense to add a license I thin

Re: [ovs-dev] [PATCH v3 3/9] datapath-windows: Add support for flushing conntrack entries

CTA_ZONE is not defined yet, and I see it is defined in 4/9. Don¹t you have to return anything upon success in OvsCtDeleteCmdHandler(). The operation type is a OVS_TRANSACTION_DEV_OP. See Flow.c for example: https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Flow .c#L301 --

Re: [ovs-dev] [PATCH v3 2/9] datapath-windows: Add support for Netfilter netlink message

A couple of minor comments, but looks good otherwise. Acked-by: Nithin Raju <nit...@vmware.com> >+/* >+ * >-- >- >+ * Returns size of

Re: [ovs-dev] [PATCH v3 1/9] Windows: Add netfilter-conntrack header files to Include folder

Only comment is to add the OVS license on top of each non-empty file. Looks like the original code does not have any licence, but it would still make sense to add a license I think. Looks good otherwise, Acked-by: Nithin Raju <nit...@vmware.com> Ben or Jesse can confirm what the best pr

Re: [ovs-dev] [PATCH] datapath-windows: Conntrack - Fix variable initialization

: [ovs-dev] [PATCH] datapath-windows: Conntrack - Fix >>variable initialization >> >>>Initialize the variable pktMdLabel. >>> >>>Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Never mind my previous oversight. Acked-by: Nithin Raju <nit...@vmware.c

Re: [ovs-dev] [PATCH] datapath-windows: Conntrack - Fix variable initialization

Sai, There¹s not correctness issue with the existing code. There are 2 fields in pktMdLabel, and they are being set in the function. Do you see any correctness issues? -- Nithin -Original Message- From: dev on behalf of Sairam Venugopal

Re: [ovs-dev] [PATCH] FAQ: Update support for NAT and Geneve.

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Jesse Gross <je...@kernel.org> Date: Friday, June 24, 2016 at 2:58 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [ovs-dev] [

Re: [ovs-dev] [PATCH 2/2] datapath-windows: Address minor alignment issues in Stt code.

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Yin Lin <li...@vmware.com> Date: Friday, June 24, 2016 at 2:44 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Cc: Yin Lin <li...@vmwa

Re: [ovs-dev] [PATCH v4] datapath-windows: Add GRE checksum

flags. > >Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> >--- >v4: Account for all memory fragmentation cases >v3: Fix access length and address comments >v2: Initial commit Acked-by: Nithin Raju <nit...@vmware.com> _

Re: [ovs-dev] [PATCH 1/2][PATCH v7] datapath-windows: Add Geneve support

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Yin Lin <li...@vmware.com> Date: Friday, June 17, 2016 at 5:13 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [ovs-dev] [PAT

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

From: Yin Lin <yinli...@gmail.com<mailto:yinli...@gmail.com>> Date: Friday, June 17, 2016 at 5:10 PM To: "aserd...@cloudbasesolutions.com<mailto:aserd...@cloudbasesolutions.com>" <aserd...@cloudbasesolutions.com<mailto:aserd...@cloudbasesolutions.com>>, N

[ovs-dev] [PATCH v4] datapath-windows: use ip proto for tunnel port lookup

. In the vport add code, we make sure that we block tunnel port addition if there's already a tunnel port that uses the same IP protocol type and L4 port number. Signed-off-by: Nithin Raju <nit...@vmware.com> Acked-by: Sairam Venugopal <vsai...@vmware.com> Acked-by: Yin Lin <l

Re: [ovs-dev] [PATCH v3] datapath-windows: use ip proto for tunnel port lookup

>> >>+case IPPROTO_GRE: >[Alin Gabriel Serdean: ] break; >> +default: >[Alin Gabriel Serdean: ] return NULL; >> +break; >> +} >> +return vport; >> +} >> +} >> +return NULL; >> +} >We need to exact match the IP proto.

[ovs-dev] [PATCH] datapath-windows: comment cleanup and indentation

Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/Flow.c | 20 ++-- datapath-windows/ovsext/Vxlan.c | 5 - 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index 2

[ovs-dev] [PATCH] datapath-windows: comment cleanup and indentation

Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/Vxlan.c | 5 - 1 file changed, 5 deletions(-) diff --git a/datapath-windows/ovsext/Vxlan.c b/datapath-windows/ovsext/Vxlan.c index f6a55f0..ddd8d8e 100644 --- a/datapath-windows/ovsext/Vxlan.c +++ b/datapath-w

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

Hi Jesse, Thanks for the comments. My responses inlined. >>> /* Number of packet attributes required to store OVS tunnel key. */ >>>-#define NUM_PKT_ATTR_REQUIRED 3 >>>+#define NUM_PKT_ATTR_REQUIRED 35 >>>+#define TUN_OPT_MAX_LEN 255 >> >> Wouldn¹t it have been better for alignment purposes to

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

une 13, 2016 at 1:39 PM To: "dev@openvswitch.org" <dev@openvswitch.org>, Nithin Raju <nit...@vmware.com> Subject: [PATCH v6] datapath-windows: Add Geneve support >Signed-off-by: Yin Lin <li...@vmware.com> >--- > datapath-windows/automake.mk | 2 + >

Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

Glad we were able to resolve this :) -Original Message- From: Alin Serdean <aserd...@cloudbasesolutions.com> Date: Tuesday, June 14, 2016 at 9:12 AM To: Nithin Raju <nit...@vmware.com>, "dev@openvswitch.org" <dev@openvswitch.org> Subject: RE: [ovs-dev] [PATCH v

[ovs-dev] [PATCH v3] datapath-windows: use ip proto for tunnel port lookup

. In the vport add code, we make sure that we block tunnel port addition if there's already a tunnel port that uses the same IP protocol type and L4 port number. Signed-off-by: Nithin Raju <nit...@vmware.com> Acked-by: Sairam Venugopal <vsai...@vmware.com> Acked-by: Yin Lin <li...@vmw

Re: [ovs-dev] [PATCH] datapath-windows: use ip proto for tunnel port lookup

Hi Alin, Thanks for the review. I¹ve taken care of the extra whitespace and also the dead (placeholder) code. >> --- a/datapath-windows/ovsext/Vport.c > >> +++ b/datapath-windows/ovsext/Vport.c > >> POVS_VPORT_ENTRY > >> +OvsFindTunnelVportByDstPortAndNWProto(POVS_SWITCH_CONTEXT > >>

Re: [ovs-dev] [PATCH v2] datapath-windows: Sample action support.

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Sorin Vinturis <svintu...@cloudbasesolutions.com> Date: Wednesday, June 1, 2016 at 8:50 AM To: "dev@openvswitch.org" <dev@openvswitch.or

Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

>> >>-Mesaj original- >> De la: Nithin Raju [mailto:nit...@vmware.com] >> Trimis: Wednesday, June 8, 2016 10:10 PM >> Către: Alin Serdean <aserd...@cloudbasesolutions.com>; >> dev@openvswitch.org >> Subiect: Re: [ovs-de

Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

> #endif >@@ -299,34 +312,21 @@ OvsDecapGre(POVS_SWITCH_CONTEXT switchContext, > EthHdr *ethHdr; > IPHdr *ipHdr; > GREHdr *greHdr; >-UINT32 tunnelSize = 0, packetLength = 0; >+UINT32 tunnelSize, packetLength; > UINT32 headRoom = 0; > PUINT8 bufferStart; >

Re: [ovs-dev] [PATCH 2/2] [PATCH v5] datapath-windows: Add Geneve support

-Original Message- From: Ben Pfaff <b...@ovn.org> Date: Friday, June 3, 2016 at 11:55 AM To: Nithin Raju <nit...@vmware.com> Cc: Yin Lin <li...@vmware.com>, "dev@openvswitch.org" <dev@openvswitch.org> Subject: Re: [ovs-dev] [PATCH 2/2] [PATCH v5] datapa

[ovs-dev] [PATCH v2] datapath-windows: use ip proto for tunnel port lookup

. In the vport add code, we make sure that we block tunnel port addition if there's already a tunnel port that uses the same IP protocol type and L4 port number. This is required for Geneve port lookups the references to which can find in the patch. Signed-off-by: Nithin Raju <nit...@vmware.

Re: [ovs-dev] [PATCH] datapath-windows: use ip proto for tunnel port lookup

Thanks for the review. From: Yin Lin <yinli...@gmail.com<mailto:yinli...@gmail.com>> Date: Thursday, June 2, 2016 at 3:00 PM To: Nithin Raju <nit...@vmware.com<mailto:nit...@vmware.com>> Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>" <dev

Re: [ovs-dev] [PATCH 2/2] [PATCH v5] datapath-windows: Add Geneve support

Yin, I went ahead and sent out a patch for the updates w.r.t OvsFindTunnelVportByDstPort(). Pls have a look: https://patchwork.ozlabs.org/patch/628483/ I¹ll send out the comments for the remainder of the patch. Thanks, -- Nithin -Original Message- From: dev

[ovs-dev] [PATCH] datapath-windows: use ip proto for tunnel port lookup

. In the vport add code, we make sure that we block tunnel port addition if there's already a tunnel port that uses the same IP protocol type and L4 port number. This is required for Geneve port lookups the references to which can find in the patch. Signed-off-by: Nithin Raju <nit...@vmware.

Re: [ovs-dev] [PATCH 1/2] [PATCH v5] datapath-windows: Move UDP checksum computation to Offload.c

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Yin Lin <li...@vmware.com> Date: Tuesday, May 24, 2016 at 4:28 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Subject: [ovs-dev] [PATC

Re: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE checksum

-Original Message- From: dev on behalf of Alin Serdean Date: Tuesday, May 24, 2016 at 9:14 AM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add GRE checksum >@@ -369,11

Re: [ovs-dev] [PATCH v2 1/3] datapath-windows: Add UDP checksum verifications for VXLAN

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Alin Serdean <aserd...@cloudbasesolutions.com> Date: Tuesday, May 24, 2016 at 9:14 AM To: "dev@openvswitch.org" <dev@openvswitch.org>

[ovs-dev] [PATCH] list.h: Define OVS_LIST_POISON statically

Looks like part of the patch committed in e32c1f7c got left out while moving header files. Signed-off-by: Nithin Raju <nit...@vmware.com> Reported-by: Joe Stringer <j...@ovn.org> --- include/openvswitch/list.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/openvswi

Re: [ovs-dev] [PATCH 2/2] [PATCH v4] datapath-windows: Add Geneve support

dev-boun...@openvswitch.org> on behalf of Nithin Raju <nit...@vmware.com> Date: Tuesday, May 24, 2016 at 9:32 AM To: Yin Lin <li...@vmware.com>, "dev@openvswitch.org" <dev@openvswitch.org> Subject: Re: [ovs-dev] [PATCH 2/2] [PATCH v4] datapath-windows: Add Geneve support

Re: [ovs-dev] [PATCH 2/2] [PATCH v4] datapath-windows: Add Geneve support

Hi Yin, You also need to update datapath-windows/automake.mk to add the new files you added. -Original Message- From: dev on behalf of Yin Lin Date: Friday, May 20, 2016 at 1:57 PM To: "dev@openvswitch.org" Subject:

Re: [ovs-dev] [PATCH 1/2] [PATCH v2] datapath-windows: Move UDP checksum computation to Offload.c

I am assuming that you¹ve run some tests using VXLAN tunnels. Acked-by: Nithin Raju <nit...@vmware.com> Thanks for the patch. -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Yin Lin <li...@vmware.com> Date: Friday, May 20, 2016 at 1:57 PM To: &q

Re: [ovs-dev] [PATCH 3/3] [PATCH v3] Add Geneve support in Windows datapath

-Original Message- From: dev on behalf of Yin Lin Date: Thursday, May 19, 2016 at 2:49 PM To: "dev@openvswitch.org" Cc: Yin Lin Subject: [ovs-dev] [PATCH 3/3] [PATCH v3] Add Geneve support in Windows

Re: [ovs-dev] [PATCH 2/3] [PATCH v1] Move UDP checksum computation to Offload.c

gt; > if (*newNbl == NULL) { We don¹t need to use tunnelSize + OVS_DEFAULT_COPY_SIZE in the partial copy. Just ŒtunnelSize¹ is sufficient. But, not a big deal. Acked-by: Nithin Raju <nit...@vmware.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/3] ovn test: add '-O OpenFlow13' to ovs-ofctl

Yin, Looks like you did a ³git send-email² on a patch that was not yours. It is fine, I¹ll review the remaining 2 in the series. Thanks for breaking it up. -- Nithin -Original Message- From: dev on behalf of Yin Lin Date: Thursday, May

[ovs-dev] [PATCH 1/2] datapath-windows: don't map output buffer in OVS_IOCTL_WRITE

The contract of OVS_IOCTL_WRITE is that write operations will not need the output buffer. Only the input buffer will be used in the IRP. So, better to not map the output buffer at all. Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/Datapath.c | 13 --

[ovs-dev] [PATCH 2/2] datapath-windows: o/p buffer must fit NL error message

which is smaller. Since we are ensuring that output buffer can fit OVS_MESSAGE_ERROR at the top of the ioctl function, there's no need to check for that later. Signed-off-by: Nithin Raju <nit...@vmware.com> --- datapath-windows/ovsext/Datapath.c| 19 -- datapath-windows/

Re: [ovs-dev] [PATCH V2] datapath-windows: Validate netlink packets integrity

Hi Paul, I looked at the change in detail and it is definitely in the right spirit to harden the kernel datapath code. However, I thought a few things could be simplified a little. I will be sending out a couple of simple reviews on top of your patch (that is already submitted). Pls. take a look.

Re: [ovs-dev] [PATCH 1/2] datapath-windows: Add UDP checksum verifications for VXLAN

Thanks Alin for taking this up. A couple of nits but looks great otherwise. Acked-by: Nithin Raju <nit...@vmware.com> > >@@ -287,17 +289,21 @@ OvsDoEncapVxlan(POVS_VPORT_ENTRY vport, > ipHdr->saddr = fwdInfo->srcIpAddr; > ipHdr->daddr = fwdInfo->

Re: [ovs-dev] [PATCH 2/2] datapath-windows: Fix alignment on Offload.c

Acked-by: Nithin Raju <nit...@vmware.com> -Original Message- From: dev <dev-boun...@openvswitch.org> on behalf of Alin Serdean <aserd...@cloudbasesolutions.com> Date: Wednesday, May 18, 2016 at 9:32 AM To: "dev@openvswitch.org" <dev@openvswitch.org> Subje

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

Yin, Thanks for sending the patch for review. A few things before I take a detailed look: 1. Add a version number to the patch, eg. "[PATCH v2] Add Geneve support Š ³ with each iteration. Also, it would be beneficial if you can annotate what changed in v2 compared to previous versions. 2. I see

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

>> >>I am not sure why Windows kernel doesn't compute UDP checksum for all >>tunnels. I added Nithin to the thread to see if he has some idea. My >>wild guess is that it tries to save some computational workload. > >My guess is that it is because VXLAN originally specified that >checksums should

Re: [ovs-dev] [PATCH] datapath-windows: Sample action support.

Hi Sorin, Thanks for this patch, and thanks for the refactoring. One quick comment is that, we can probably move the new code in Random.h to Util.h if you think we are not going to be adding any more functions to Random.h. I am not sure if 2 more functions warrants a new file. Also, I see a typo

Re: [ovs-dev] [PATCH V2] datapath-windows: Validate netlink packets integrity

Just a couple of more comments. -Original Message- From: dev > on behalf of Paul Boca > Date: Wednesday, April 27, 2016 at 1:05 AM To:

  1   2   3   4   5   6   7   8   9   10   >