[ovs-dev] [PATCH branch-2.3 v2 4/5] ofproto: Allow in-place modifications of datapath flows.

nstead of deleting it, it does a put with the MODIFY flag set. This patch is a backport of commit 43b2f13 to branch-2.3. This patch also squashes in commit c56eba3b7ab0 ("ofproto-dpif-upcall: Don't delete modified ukeys."). Signed-off-by: Ethan J. Jackson <et...@nicira.com>

[ovs-dev] [PATCH branch-2.3 v2 1/5] type-props: Avoid a MSVC warning.

mmit makes changes to the macro to prevent that warning. Suggested-by: Ben Pfaff <b...@nicira.com> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com> Acked-by: Ben Pfaff <b...@nicira.com> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/type-props.h | 4 ++-- 1 file chan

[ovs-dev] [PATCH branch-2.3 v2 2/5] type-props: Suppress warnings in newer Clang and GCC.

f them. Reported-by: Joe Stringer <joestrin...@nicira.com> Signed-off-by: Ben Pfaff <b...@nicira.com> Acked-by: Joe Stringer <joestrin...@nicira.com> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/type-props.h| 32 tests/te

[ovs-dev] [PATCH branch-2.3 2/2] ofproto: Allow in-place modifications of datapath flows.

nstead of deleting it, it does a put with the MODIFY flag set. This patch is a backport of commit 43b2f13 to branch-2.3. Signed-off-by: Ethan J. Jackson <et...@nicira.com> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-d

Re: [ovs-dev] [PATCH] dpif-netdev: Fix improper use of CMAP_FOR_EACH.

With the small nits below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 26, 2016, at 9:13 PM, Daniele Di Proietto <diproiet...@vmware.com> > wrote: > > It is ok to iterate a cmap with CMAP_FOR_EACH and remove elements with > cmap_remove(), but having quies

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Remove obsolete special case.

> On Jan 29, 2016, at 4:54 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Fri, Jan 29, 2016 at 03:38:11PM -0800, Jarno Rajahalme wrote: >> Bond recirculation used to insert a special rule that jumped from the >> internal table to table 0 using GOTO_TABLE. Since the int

[ovs-dev] [PATCH] INSTALL.md: Fix shell command line formatting.

Some shell command lines were quited inconsistently from others. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- INSTALL.md | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/INSTALL.md b/INSTALL.md index dc688ad..dd4d965 100644 --- a/INST

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-xlate: Clarify recirculation in do_xlate_actions().

> On Jan 29, 2016, at 5:09 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Fri, Jan 29, 2016 at 03:38:12PM -0800, Jarno Rajahalme wrote: >> Handle implicit recirculation explicitly for each action type, so that >> it is easier to follow what is happening. >> >

[ovs-dev] [PATCH 2/2] ofproto-dpif-xlate: Clarify recirculation in do_xlate_actions().

Handle implicit recirculation explicitly for each action type, so that it is easier to follow what is happening. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 164 +-- 1 file changed, 97 insertions(+), 67 del

[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Remove obsolete special case.

-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 6e928da..1edc1b0 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofprot

Re: [ovs-dev] [PATCH 10/10] Implement "closures".

ength %"PRIuSIZE, + "actions property has bad length %"PRIu32, property->size); return OFPERR_OFPBPC_BAD_LEN; } Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrot

Re: [ovs-dev] [PATCH 04/10] ofproto-macros: Change STRIP_USED and STRIP_UID to shell functions.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > There's no need for these to be macros; shell functions are conceptually > cleaner and make the generated testsuite smaller. > > Also remove conflicting

Re: [ovs-dev] [PATCH 05/10] ofproto-macros: Remove STRIP_DURATION macro.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > It was unused. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > tests/ofproto-macros.at | 1 - > 1 file changed, 1 deletion(-) > > diff

Re: [ovs-dev] [PATCH 01/10] ofproto-dpif-xlate: Do not execute resubmit again after recirculation.

This seems the same that I already reviewed by itself: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > Consider the following flow table: > >table=0 actions=resubmit(,1),2 >table=1 actions=debug

Re: [ovs-dev] [PATCH 08/10] tests: Avoid useless use of cat.

Two notes below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > Commands like "cat file | a" can be rewritten more cheaply as "a < file". > > Signed-off-by: Ben Pfaff <b...@ovn

Re: [ovs-dev] [PATCH 09/10] ofp-actions: Add more detail when formatting unroll_xlate pseudo-action.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > This is helpful for debugging recirculation. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > lib/ofp-actions.c | 6 +++--- > 1 file changed,

Re: [ovs-dev] [PATCH 02/10] tests: Change ADD_OF_PORTS from macro to shell function.

Do we have an issue with the generated testsuite size? Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > This reduces the size of the generated testsuite and makes it possible > to pass arguments that

Re: [ovs-dev] [PATCH 03/10] ofproto-macros: Change STRIP_XIDS from macro to shell function.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > There's no need for this to be a macro; shell functions are conceptually > cleaner and make the generated testsuite smaller. > > Signed-off-by: Ben Pfaf

Re: [ovs-dev] [PATCH 07/10] tests: Fix race in "ofproto-dpif - ofproto-dpif-monitor 1" test.

It seems part of the fix got split to the next patch? Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > This test contained two commands that both read and overwrote > ovs-vswitchd.log, and then expected

Re: [ovs-dev] [PATCH 06/10] tests: Convert dpif-netdev macros to shell functions.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > There's no need for these to be macros; shell functions are conceptually > cleaner and make the generated testsuite smaller. > > Signed-off-by: Ben Pfaf

Re: [ovs-dev] [PATCH 07/10] tests: Fix race in "ofproto-dpif - ofproto-dpif-monitor 1" test.

The test actually fails without the changes in the next patch for these same locations (which I pointed in my response to the next patch). Jarno > On Jan 28, 2016, at 12:37 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > It seems part of the fix got split to the next pa

Re: [ovs-dev] OVS/OVN: conntrack nat

.0/24 > <http://10.0.0.0/24> > actions=dec_ttl(),move:NXM_OF_IP_DST[]->NXM_NX_REG0[],resubmit(,19) > > > Thanks, > Chandra > > On Wed, Jan 27, 2016 at 11:34 AM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: > >> On Jan 26, 2016

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Do not execute resubmit again after recirculation.

I’ll propose more patches to make recirculation handling in do_xlate_actions() more explicit. Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 27, 2016, at 9:16 AM, Ben Pfaff <b...@ovn.org> wrote: > > Consider the following flow table: > >table=0 actions=

Re: [ovs-dev] OVS/OVN: conntrack nat

> On Jan 26, 2016, at 10:25 PM, Chandra Vejendla > wrote: > > Hi Jarno, > > We are trying to install openflow rules to get floating-ips working in OVN > and have a question about DNAT action. > > When a DNAT action is committed, at what stage is the packets DIP

Re: [ovs-dev] Hitless resynchronisation of forwarding state

> On Jan 25, 2016, at 12:40 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Mon, Jan 25, 2016 at 11:24:18AM -0800, Jarno Rajahalme wrote: >>> On Jan 25, 2016, at 2:40 AM, Jan Scheurich <jan.scheur...@ericsson.com> >>> wrote: >>> 1. OpenFlow bundle

Re: [ovs-dev] Hitless resynchronisation of forwarding state

OVS already has the notion of “generation ID” on each flow table entry, in the form of a version range. Overall, I’d rather see the bundle mechanism extended to cover meters and groups (i.e., extend the group and meter tables to support the same version range mechanism). More comments below.

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix recirculation for resubmit to current table.

Thanks for catching this, I’m not sure if I was aware of resubmit to the current table feature when I wrote that. Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 22, 2016, at 3:59 PM, Ben Pfaff <b...@ovn.org> wrote: > > When recirculation defers actions for process

Re: [ovs-dev] [PATCH] FAQ: Explain hash function for select groups.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 25, 2016, at 8:40 AM, Ben Pfaff <b...@ovn.org> wrote: > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > FAQ.md | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/FAQ.m

Re: [ovs-dev] [PATCH] system-traffic: use appropriate nc options for installed version

> On Jan 21, 2016, at 1:19 PM, Joe Stringer wrote: > > On 21 January 2016 at 11:57, Lance Richardson wrote: >> The "conntrack - ICMP related with NAT" test case currently fails >> on systems using the nmap version of nc because this version >> does not

Re: [ovs-dev] [PATCH 40/41] ofproto-dpif-xlate: Put recirc_state, not recirc_id_node, in xlate_in.

irc_id_node, but where would the eventual release of >>> the reference happen? >>> >>> On Wed, Jan 20, 2016 at 04:39:12PM -0800, Jarno Rajahalme wrote: >>>> Maybe ofproto-dpif-upcall.c could be refactored to not need the >>>> recirc_id_node pointe

Re: [ovs-dev] [PATCH 40/41] ofproto-dpif-xlate: Put recirc_state, not recirc_id_node, in xlate_in.

, but > I don't think I fully understand yet. I guess it's pretty easy to make > xlate_in_init() take the reference and pass back the recirc_state > instead of the recirc_id_node, but where would the eventual release of > the reference happen? > > On Wed, Jan 20, 2016 at 04:39:

Re: [ovs-dev] [PATCH 41/41] [RFC] Implement "closures".

Not a full review, but see some comments below, And sorry for not snipping, but I felt like not cutting any context when commenting an RFC patch. Jarno > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > One purpose of OpenFlow packet-in messages is to allow a controller to

Re: [ovs-dev] [PATCH 34/41] ofproto-dpif-rid: Use array instead of ofpbuf for recirc_state stack.

Nice simplification! With one bug fix below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > In my opinion, this makes better sense for the stack, because it's not > a packet or a collection of bytes,

Re: [ovs-dev] [PATCH 34/41] ofproto-dpif-rid: Use array instead of ofpbuf for recirc_state stack.

I see that the next patch fixed this bug, Jarno > On Jan 20, 2016, at 3:49 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > Nice simplification! With one bug fix below: > > Acked-by: Jarno Rajahalme <ja...@ovn.org <mailto:ja...@ovn.org>> > >>

Re: [ovs-dev] [PATCH 35/41] ofproto-dpif-rid: Use separate pointers for actions and action set.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > During translation it makes some sense to concatenate these in a single > array, but in my opinion it's conceptually better to separate the

Re: [ovs-dev] [PATCH 38/41] ofproto-dpif-rid: Use UUID, not pointer, to identify ofprotos for recirc.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > An upcoming commit will make it possible to essentially serialize the > recirculation state into an OpenFlow message. For that purpose, we can't > sens

Re: [ovs-dev] [PATCH 39/41] nx-match: Add functions for raw decoding and encoding of OXM.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > The existing functions either assumed that we were working with NXM > (instead of OXM), or they added or parsed a header before OXM headers. > T

Re: [ovs-dev] [PATCH 40/41] ofproto-dpif-xlate: Put recirc_state, not recirc_id_node, in xlate_in.

for the exceptional cases? Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > This will make it possible, in an upcoming commit, to construct a > recirc_state locally on the stack to pass to xlate_actions(). It

Re: [ovs-dev] [PATCH 40/41] ofproto-dpif-xlate: Put recirc_state, not recirc_id_node, in xlate_in.

ion:"); Jarno > On Jan 20, 2016, at 4:39 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > Maybe ofproto-dpif-upcall.c could be refactored to not need the > recirc_id_node pointer. It is only used for getting the recirc ID and > managing recirc_id_node reference counting.

Re: [ovs-dev] [PATCH 36/41] ofproto-dpif-rid: Don't carry actset_output explicitly in metadata.

This is nice reduction of code duplication as well. Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > Instead reconstruct it using the action set, since we already have the > logic to do that. > > This s

Re: [ovs-dev] [PATCH 37/41] ofproto-dpif-rid: Fix names of recirc_metadata_{hash, equal}().

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > These functions actually hash or compare recirc_state structs, so they > should be named that way; recirc_metadata is only a small subset of > recirc_state. &g

Re: [ovs-dev] [PATCH 14/41] ofp-errors: Add extension error codes for OF1.3+ property errors.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > Upcoming commits will introduce uses of the "property" message formats, > which are used in OF1.3 and especially in OF1.4+, in Nicira extensi

Re: [ovs-dev] [PATCH 20/41] openflow: Remove unused (and not useful) property headers.

One unintentional (?) blank line added, otherwise: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > These are all just copies of the otherwise generic ofp_prop_header or > ofp_prop_experimenter. > &g

Re: [ovs-dev] [PATCH 18/41] ofp-prop: Add helpers for u8, be64/u64, flag, and UUID properties.

Small nits below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > These will have users in upcoming commits. Unlike the previously > added helpers, there isn't any existing code that can immediately >

Re: [ovs-dev] [PATCH 09/41] openflow: Rename OF0.1-1.3 queue property constants.

With a minor function naming question below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > At first glance, OF1.4 queue properties look a lot like those for OF1.0 > to OF1.3, but in fact their diff

Re: [ovs-dev] [PATCH 13/41] ofp-util: Improve function to emit a bitmap property.

With a minor nit below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > The callers had some common code that could be reasonably encapsulated, so > this commit does so. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH 16/41] ofp-prop: Add support for experimenter properties.

With clarifications requested below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > lib/ofp-prop.c | 98 +++

Re: [ovs-dev] [PATCH 12/41] ofp-actions: Append in ofpacts_pull_openflow_actions(), instead of replace.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > An upcoming commit will have a need to parse actions incrementally, so this > change makes that easier to do. > > Signed-off-by: Ben Pfaff <b...@ovn.or

Re: [ovs-dev] [PATCH 15/41] ofp-prop: New module for working with OpenFlow 1.3+ properties.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > Several OpenFlow 1.3+ messages use TLV-based properties that take a > common form. Until now, ofp-util has had some static functions for > dealing with prop

Re: [ovs-dev] [PATCH 19/41] ofp-prop: New function ofpprop_put_zeros().

With the bug fix below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > This will have additional users in later commits. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > lib/ofp-prop.

Re: [ovs-dev] [PATCH 08/41] ofp-print: Improve formatting of queue stat requests and port_mods.

There is still some inconsistency in using ‘=‘ vs. ‘:’ between a key and its value when printing different messages. Is there a reason for this? Nevertheless, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrot

Re: [ovs-dev] [PATCH 10/41] netdev-dummy: Add a dummy queue.

With a question (or two) for clarification below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > Until now it's been pretty hard to properly test any of the queue support, > because the dummy network device

Re: [ovs-dev] [PATCH 11/41] ovs-ofctl: Merge dump_stats_transaction() into dump_transaction().

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > The callers call dump_stats_transaction() for OFPST_* messages and > dump_transaction() for other messages, but the callee can easily > distinguish th

Re: [ovs-dev] [PATCH 17/41] ofp-prop: Add generic functions for working with 16- and 32-bit properties.

With minor questions below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > These will see increasing use in upcoming commits. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > include/openfl

Re: [ovs-dev] [PATCH 01/41] ofproto: Fix memory leak and memory exhaustion bugs in group_mod.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > In handle_group_mod() cases where adding a group failed, nothing freed the > list of buckets, causing a leak. The same was true in every case of > modifying

Re: [ovs-dev] [PATCH 06/41] openflow-1.2: Remove unused struct definition.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > Experimenter stats are handled by code in ofp-msgs, and this struct isn't > good for anything. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --

Re: [ovs-dev] [PATCH 07/41] pinsched: Remove obsolete ofpbuf_trim().

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > This call to ofpbuf_trim() comes from a time when the packets passed to > pinsched came directly from a dpif. For some time now that's no longer > true--now

Re: [ovs-dev] [PATCH 02/41] learning-switch: Use "if"s instead of "switch" to reduce maintenance.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > This code only cares about a very few kinds of OpenFlow messages, and it's > unlikely that it will care about new ones, so replace the "switch" by &

Re: [ovs-dev] [PATCH 05/41] ofp-util: Improve formatting of comment.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > lib/ofp-util.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/o

Re: [ovs-dev] [PATCH 00/41] Implement "closures".

FYI, I’ll review this series, Jarno > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > The purpose of this series is the final patch, which is important for > OVN and should also solve some problems that I've heard of in other > controllers over the years. > > Ben Pfaff

Re: [ovs-dev] [PATCH 03/41] ofp-msgs: Fix definitions of OF1.4 OFPT_GET_ASYNC_REPLY and OFPT_SET_ASYNC.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:26 PM, Ben Pfaff <b...@ovn.org> wrote: > > The structures declared in ofp-msgs.h for messages definitions should not > include an OpenFlow header (its presence is implied), but the definition of > these

Re: [ovs-dev] [PATCH 24/41] ofp-util: Rewrite async config encoding and decoding to be table-driven.

With a small nit below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > (snip) > +struct ofp14_async_prop { > +uint64_t prop_type; > +enum ofputil_async_msg_type oam; > +bool master; > +

Re: [ovs-dev] [PATCH 31/41] openflow: Better abstract handling of packet-in messages.

With two questions for clarification below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > (snip) > diff --git a/lib/ofp-util.c b/lib/ofp-util.c > index 347cb61..48e2e8e 100644 > --- a/lib/ofp-ut

Re: [ovs-dev] [PATCH 23/41] ofp-util: Define struct ofputil_async_cfg to hold async message config.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > This seems a little better than a pair of bare arrays. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > include/openflow/openflow-c

Re: [ovs-dev] [PATCH 33/41] hash: New helper functions hash_bytes32() and hash_bytes64().

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > All of the callers of hash_words() and hash_words64() actually find it > easier to pass in the number of bytes instead of the number of 32-bit > or 64-bit

Re: [ovs-dev] [PATCH 25/41] ofp-util: Fix OF1.4+ version of ofputil_decode_set_async_config().

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > The OF1.0 through OF1.3 "set async config" set the whole configuration, > OF1.4+ only update parts of it piecemeal, but the decoding function al

Re: [ovs-dev] [PATCH 27/41] ofp-print: Decode all async config messages the same way.

Maybe the title should be “ofp-print: Print all async config messages the same way.” instead? Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > We have a single function to decode all of these messages, so ther

Re: [ovs-dev] [PATCH 21/41] openflow: Implement OF1.4+ OFPMP_QUEUE_DESC multipart message.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > OpenFlow 1.0 through 1.3 have a message OFPT_QUEUE_GET_CONFIG_REQUEST and > its corresponding reply, for fetching a description of the queues > configured on

Re: [ovs-dev] [PATCH 32/41] connmgr: Generalize ofproto_packet_in to ofproto_async_msg.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > An upcoming commit will add another kind of asynchronous message that > should be handled in the same way as packet-ins. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH 22/41] ofp-util: New function ofputil_async_msg_type_to_string().

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > An upcoming commit will add another user. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > lib/ofp-print.c | 27 ++-

Re: [ovs-dev] [PATCH 29/41] fail-open: Drop some of the weirder special cases.

I never understood this special case anyway, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > I don't have any real evidence that these special cases make a difference > in real-world cases. The messages for t

Re: [ovs-dev] [PATCH 30/41] pktbuf: Move from 'ofproto' to 'lib'.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > An upcoming commit will use this library from ofp-util instead of ofproto. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > lib/automake.

Re: [ovs-dev] [PATCH 28/41] openflow: Get rid of struct ofp13_packet_in.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > It's actually harder to parse OF1.2/OF1.3 "packet-in" messages when > ofp13_packet_in is involved than when the code just realizes that > ofp13

Re: [ovs-dev] [PATCH 26/41] ofp-util: Add function to encode OFPT_SET_ASYNC messages.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2016, at 11:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > This isn't used yet but it will be in future commits. > > This also looks forward to supporting Open vSwitch extensions to OAM_*, > which will be coming up

Re: [ovs-dev] [PATCH] flow: fix compilation of MINIFLOW_ASSERT

Simon, Thanks for the fix. Pushed to master, Jarno > On Jan 10, 2016, at 9:00 PM, Simon Horman wrote: > > Often MINIFLOW_ASSERT is a no-op and compilation of code that uses > it is optimised out. This patch fixes compilation errors that occur > when that is not

Re: [ovs-dev] [PATCH v3 0/4] Meter implementation for userspace datapath.

> On Jan 11, 2016, at 9:35 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Mon, Dec 21, 2015 at 11:38:33PM -0800, Ben Pfaff wrote: >> On Mon, Nov 30, 2015 at 10:03:11AM -0800, Jarno Rajahalme wrote: >>> >>>> On Nov 29, 2015, at 17:12, Ben Pfaff <b...@ovn

[ovs-dev] [PATCH net-next v6 7/7] openvswitch: Interface with NAT.

/nat. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/uapi/linux/openvswitch.h | 47 net/openvswitch/conntrack.c | 516 +-- net/openvswitch/conntrack.h | 3 +- 3 files changed, 541 insertions(+), 25 deletions(-) diff --git a/i

[ovs-dev] [PATCH net-next v6 6/7] openvswitch: Delay conntrack helper call for new connections.

There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno

[ovs-dev] [PATCH net-next v6 4/7] openvswitch: Find existing conntrack entry after upcall.

hrough NAT using the original ct reference also after the reference is lost after an upcall. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- net/openvswitch/conntrack.c | 111 ++-- 1 file changed, 98 insertions(+), 13 deletions(-) diff --git a

[ovs-dev] [PATCH net-next v6 5/7] openvswitch: Handle NF_REPEAT in conntrack action.

Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH net-next v5 2/8] netfilter: Factor out nf_ct_get_info().

> On Dec 25, 2015, at 4:30 AM, Pablo Neira Ayuso <pa...@netfilter.org> wrote: > > On Wed, Dec 16, 2015 at 04:36:41PM -0800, Jarno Rajahalme wrote: >> Define a new inline function to map conntrack status to enum >> ip_conntrack_info. This removes the need to other

Re: [ovs-dev] [RFC] conntrack: cross zone nat

> On Jan 8, 2016, at 2:03 PM, Joe Stringer wrote: > > On 22 December 2015 at 22:05, Zang MingJie > wrote: >> >> >> On Wed, Dec 23, 2015 at 3:10 AM, Joe Stringer wrote: >>> >>> On 21 December 2015 at 23:52,

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Document revalidator cycle.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 7, 2016, at 4:16 PM, Joe Stringer <j...@ovn.org> wrote: > > Add a series of comments to make it more clear what's happening for > individual ukeys being handled during revalidator dump/sweep cycle. > > Signed-off-

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Don't delete modified ukeys.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 7, 2016, at 11:47 AM, Joe Stringer <j...@ovn.org> wrote: > > If revalidation returns the result UKEY_DELETE, then both the ukey and > its corresponding flow should be deleted. However, if revalidation > returns U

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Use UKEY_DELETE for ukey deletion.

= 0; +} } if (n_ops) { Your call. Either way: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 7, 2016, at 11:47 AM, Joe Stringer <j...@ovn.org> wrote: > > Flows which are deleted during the revalidator "dump" phase ha

Re: [ovs-dev] memory leak in recirc_state?

> On Jan 6, 2016, at 1:21 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Jan 06, 2016 at 01:14:23PM -0800, Jarno Rajahalme wrote: >> >>> On Jan 5, 2016, at 8:24 PM, Ben Pfaff <b...@ovn.org> wrote: >>> >>> Thanks. That was my experience

Re: [ovs-dev] [PATCH] ofproto-dpif-rid: Fix memory leak in recirc_state.

> On Jan 6, 2016, at 3:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Jan 06, 2016 at 01:58:28PM -0800, Jarno Rajahalme wrote: >> From: Ben Pfaff <b...@ovn.org> >> >> recirc_alloc_id__() copies the stack nothing ever freed it. >> >>

[ovs-dev] [PATCH] ofproto-dpif-rid: Fix memory leak in recirc_state.

om> Reported-at: http://openvswitch.org/pipermail/dev/2016-January/064040.html Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-rid.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c

Re: [ovs-dev] memory leak in recirc_state?

> On Jan 5, 2016, at 8:24 PM, Ben Pfaff wrote: > > Thanks. That was my experience also. > > I applied this to master and branch-2.5. Thanks for fixing this. I reviewed the patch and it seems correct to me as well. > I think that branch-2.4 has > the same bug but the backport

Re: [ovs-dev] OVS/OVN: Interface with NAT

you should go find the patches from the patchwork individually, if the bundle is empty. Jarno > Regards > Amitabha > >>> On Dec 16, 2015, at 4:42 PM, Jarno Rajahalme <ja...@ovn.org> wrote: >>> >>> >>> On Dec 16, 2015, at 2:15 PM, Amita

Re: [ovs-dev] [PATCH] match: Add support for matching IGMP fields.

> On Dec 15, 2015, at 5:48 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > >> On Dec 15, 2015, at 5:47 PM, Ben Pfaff <b...@ovn.org <mailto:b...@ovn.org>> >> wrote: >> >> On Mon, Dec 14, 2015 at 04:36:08PM -0800, Jarno Rajahalme wrote:

Re: [ovs-dev] [PATCH] match: Add support for matching IGMP fields.

> On Dec 16, 2015, at 1:22 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > >> On Dec 15, 2015, at 5:48 PM, Jarno Rajahalme <ja...@ovn.org >> <mailto:ja...@ovn.org>> wrote: >> >> >>> On Dec 15, 2015, at 5:47 PM, Ben Pfaff <b...@ovn

Re: [ovs-dev] OVS/OVN: Interface with NAT

> On Dec 16, 2015, at 2:15 PM, Amitabha Biswas wrote: > > Hi Jarno, > > As part of OVN integration in Openstack, I’ve been trying to setup OpenFlow > NAT rules and run the system-test-suite 33: system-traffic.at > :1396 conntrack - simple SNAT.

[ovs-dev] [PATCH net-next v5 7/8] openvswitch: Delay conntrack helper call for new connections.

There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno

[ovs-dev] [PATCH net-next v5 8/8] openvswitch: Interface with NAT.

/nat. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/uapi/linux/openvswitch.h | 47 net/openvswitch/conntrack.c | 516 +-- net/openvswitch/conntrack.h | 3 +- 3 files changed, 541 insertions(+), 25 deletions(-) diff --git a/i

[ovs-dev] [PATCH net-next v5 6/8] openvswitch: Handle NF_REPEAT in conntrack action.

Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH net-next v5 3/8] netfilter: Allow calling into nat helper without skb_dst.

elar <pshe...@nicira.com> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- net/ipv4/netfilter/nf_nat_l3proto_ipv4.c | 30 -- net/ipv6/netfilter/nf_nat_l3proto_ipv6.c | 30 -- 2 files changed, 16 insertions(+), 44 deletions(-)

[ovs-dev] [PATCH net-next v5 0/8] openvswitch: NAT support.

is properly set by the conntrack action. A full test case requires rules for ARP handling not shown here. The flow table above is an OpenFlow table, and the rules therein are translated to kernel flow entries on-demand by ovs-vswitchd. Jarno Rajahalme (8): netfilter: Remove IP_CT_NEW_REPLY

[ovs-dev] [PATCH net-next v5 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +--- net/openv

[ovs-dev] [PATCH net-next v5 5/8] openvswitch: Find existing conntrack entry after upcall.

hrough NAT using the original ct reference also after the reference is lost after an upcall. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- net/openvswitch/conntrack.c | 95 ++--- 1 file changed, 82 insertions(+), 13 deletions(-) diff --git a

<    4   5   6   7   8   9   10   11   12   13   >