Re: [PR] Force redeploy website [parquet-site]

2024-03-05 Thread via GitHub
wgtmac merged PR #45: URL: https://github.com/apache/parquet-site/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Force redeploy website [parquet-site]

2024-03-05 Thread via GitHub
wgtmac commented on PR #45: URL: https://github.com/apache/parquet-site/pull/45#issuecomment-1979956360 Could you also update the asf yaml like https://github.com/apache/parquet-mr/blob/master/.asf.yaml to avoid notifications to dev@ ML? Thanks! -- This is an automated message from the

[PR] Force redeploy website [parquet-site]

2024-03-05 Thread via GitHub
vinooganesh opened a new pull request, #45: URL: https://github.com/apache/parquet-site/pull/45 @wgtmac - apologies, the last PR didn't contain any core website changes so nothing was redeployed. This should fix that. -- This is an automated message from the Apache Git Service. To

Re: [PR] Updating asf Staging [parquet-site]

2024-03-05 Thread via GitHub
wgtmac merged PR #44: URL: https://github.com/apache/parquet-site/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Updating asf Staging [parquet-site]

2024-03-05 Thread via GitHub
vinooganesh commented on PR #44: URL: https://github.com/apache/parquet-site/pull/44#issuecomment-1979940099 @wgtmac one more for you to get us close to done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Updating asf Staging [parquet-site]

2024-03-05 Thread via GitHub
vinooganesh opened a new pull request, #44: URL: https://github.com/apache/parquet-site/pull/44 ASF Docs: https://github.com/apache/infrastructure-asfyaml/blob/main/README.md Iceberg Example: https://github.com/apache/iceberg/blob/main/.asf.yaml -- This is an automated message from

Re: [PR] Dropping go to 1.12 in go.mod [parquet-site]

2024-03-05 Thread via GitHub
vinooganesh commented on PR #43: URL: https://github.com/apache/parquet-site/pull/43#issuecomment-1979908298 Thanks - looks like this fixed staging: https://parquet.staged.apache.org/! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Adding updated doap file [parquet-site]

2024-03-05 Thread via GitHub
wgtmac merged PR #41: URL: https://github.com/apache/parquet-site/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Dropping go to 1.12 in go.mod [parquet-site]

2024-03-05 Thread via GitHub
wgtmac merged PR #43: URL: https://github.com/apache/parquet-site/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Adding updated doap file [parquet-site]

2024-03-05 Thread via GitHub
vinooganesh commented on PR #41: URL: https://github.com/apache/parquet-site/pull/41#issuecomment-1979782097 @wgtmac @shangxinli also this one please! I'll follow up with a full production PR once the staging site build passes -- This is an automated message from the Apache Git

Re: [PR] Dropping go to 1.12 in go.mod [parquet-site]

2024-03-05 Thread via GitHub
vinooganesh commented on PR #43: URL: https://github.com/apache/parquet-site/pull/43#issuecomment-1979780007 @wgtmac could you +1 and merge this too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Dropping go to 1.12 in go.mod [parquet-site]

2024-03-05 Thread via GitHub
vinooganesh opened a new pull request, #43: URL: https://github.com/apache/parquet-site/pull/43 This should fix the build. There was an issue that has to do with missing toolchain here: https://github.com/golang/go/issues/62278 -- This is an automated message from the Apache Git

Re: [PR] Updating Staging [parquet-site]

2024-03-04 Thread via GitHub
vinooganesh commented on PR #40: URL: https://github.com/apache/parquet-site/pull/40#issuecomment-1977909721 Ugh I think staging is hitting this: https://github.com/golang/go/issues/62278 ```go: download go1.23 for linux/amd64: toolchain not available``` -- This is an automated

Re: [PR] Updating Staging [parquet-site]

2024-03-04 Thread via GitHub
vinooganesh commented on PR #40: URL: https://github.com/apache/parquet-site/pull/40#issuecomment-1977811642 @wgtmac - that's a valid point. It's good for situations like this where we have to debug something strange before going to prod

Re: [PR] Updating Staging [parquet-site]

2024-03-04 Thread via GitHub
wgtmac commented on PR #40: URL: https://github.com/apache/parquet-site/pull/40#issuecomment-1977806694 Is it possible to retire the staging site? It does not seem necessary to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add DOAP to staging [parquet-site]

2024-03-04 Thread via GitHub
wgtmac merged PR #42: URL: https://github.com/apache/parquet-site/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Add DOAP to staging [parquet-site]

2024-03-04 Thread via GitHub
vinooganesh opened a new pull request, #42: URL: https://github.com/apache/parquet-site/pull/42 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Updating Staging [parquet-site]

2024-03-04 Thread via GitHub
vinooganesh commented on PR #40: URL: https://github.com/apache/parquet-site/pull/40#issuecomment-1977115694 FYI in case someone finds this later, the URL of staging is https://parquet.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the

[PR] Adding updated doap file [parquet-site]

2024-03-04 Thread via GitHub
vinooganesh opened a new pull request, #41: URL: https://github.com/apache/parquet-site/pull/41 Updating DOAP file to latest parquet release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Updating Staging [parquet-site]

2024-03-01 Thread via GitHub
shangxinli merged PR #40: URL: https://github.com/apache/parquet-site/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Updating Staging [parquet-site]

2024-03-01 Thread via GitHub
shangxinli commented on PR #40: URL: https://github.com/apache/parquet-site/pull/40#issuecomment-1973486947 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Updating README [parquet-site]

2024-03-01 Thread via GitHub
shangxinli merged PR #39: URL: https://github.com/apache/parquet-site/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Updating README [parquet-site]

2024-03-01 Thread via GitHub
shangxinli commented on PR #39: URL: https://github.com/apache/parquet-site/pull/39#issuecomment-1973485657 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Updating README [parquet-site]

2024-03-01 Thread via GitHub
vinooganesh commented on PR #39: URL: https://github.com/apache/parquet-site/pull/39#issuecomment-1973401634 @shangxinli can you +1 and merge? once it's good here, I'll make the change on prod -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Updating Staging [parquet-site]

2024-03-01 Thread via GitHub
vinooganesh commented on PR #40: URL: https://github.com/apache/parquet-site/pull/40#issuecomment-1973400827 @shangxinli can you +1 and merge, once it's good here, I'll make the change on prod -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Updating Staging [parquet-site]

2024-02-27 Thread via GitHub
vinooganesh commented on PR #40: URL: https://github.com/apache/parquet-site/pull/40#issuecomment-1966813570 Yeah haha @wgtmac, that's mostly me being negligent. I'm going to get everything up to date on both staging and production now -- This is an automated message from the Apache Git

Re: [PR] Updating Staging [parquet-site]

2024-02-27 Thread via GitHub
wgtmac commented on PR #40: URL: https://github.com/apache/parquet-site/pull/40#issuecomment-1966791036 IIUC, the staging size is no longer maintained. cc @gszadovszky @shangxinli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Updating README [parquet-site]

2024-02-27 Thread via GitHub
vinooganesh opened a new pull request, #39: URL: https://github.com/apache/parquet-site/pull/39 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Updating docsy to 2bfdac43ca13cb6605f1103581f77ba6e08a6c72 [parquet-site]

2024-02-26 Thread via GitHub
vinooganesh closed pull request #27: Updating docsy to 2bfdac43ca13cb6605f1103581f77ba6e08a6c72 URL: https://github.com/apache/parquet-site/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Update logicaltypes.md [parquet-site]

2024-01-29 Thread via GitHub
wgtmac commented on code in PR #38: URL: https://github.com/apache/parquet-site/pull/38#discussion_r1470597540 ## content/en/docs/File Format/Types/logicaltypes.md: ## @@ -10,4 +10,4 @@ of primitive types to a minimum and reuses parquet's efficient encodings. For example,

Re: [PR] Update logicaltypes.md [parquet-site]

2024-01-29 Thread via GitHub
jasonhorner commented on code in PR #38: URL: https://github.com/apache/parquet-site/pull/38#discussion_r1470502252 ## content/en/docs/File Format/Types/logicaltypes.md: ## @@ -10,4 +10,4 @@ of primitive types to a minimum and reuses parquet's efficient encodings. For

Re: [PR] Update logicaltypes.md [parquet-site]

2024-01-20 Thread via GitHub
wgtmac commented on code in PR #38: URL: https://github.com/apache/parquet-site/pull/38#discussion_r1460506762 ## content/en/docs/File Format/Types/logicaltypes.md: ## @@ -10,4 +10,4 @@ of primitive types to a minimum and reuses parquet's efficient encodings. For example,

[PR] Update logicaltypes.md [parquet-site]

2024-01-19 Thread via GitHub
jasonhorner opened a new pull request, #38: URL: https://github.com/apache/parquet-site/pull/38 Fixing broken link -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Sync site with format release v2.10.0 [parquet-site]

2024-01-14 Thread via GitHub
krylov-krylov commented on code in PR #37: URL: https://github.com/apache/parquet-site/pull/37#discussion_r1451890924 ## content/en/docs/File Format/bloomfilter.md: ## @@ -0,0 +1,335 @@ +--- +title: "Bloom Filter" +linkTitle: "Bloom Filter" +weight: 7 +--- +### Problem

Re: [PR] Sync site with format release v2.10.0 [parquet-site]

2024-01-14 Thread via GitHub
krylov-krylov commented on code in PR #37: URL: https://github.com/apache/parquet-site/pull/37#discussion_r1451890553 ## content/en/docs/File Format/bloomfilter.md: ## @@ -0,0 +1,335 @@ +--- +title: "Bloom Filter" +linkTitle: "Bloom Filter" +weight: 7 +--- +### Problem

Re: [PR] Sync site with format release v2.10.0 [parquet-site]

2024-01-14 Thread via GitHub
shangxinli merged PR #37: URL: https://github.com/apache/parquet-site/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2259: Update site to sync with latest parquet-format [parquet-site]

2024-01-14 Thread via GitHub
wgtmac closed pull request #31: PARQUET-2259: Update site to sync with latest parquet-format URL: https://github.com/apache/parquet-site/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Sync site with format release v2.10.0 [parquet-site]

2024-01-14 Thread via GitHub
wgtmac commented on PR #37: URL: https://github.com/apache/parquet-site/pull/37#issuecomment-1890940974 I have just updated the site, PTAL. @gszadovszky @shangxinli @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] Sync site with format release v2.10.0 [parquet-site]

2024-01-14 Thread via GitHub
wgtmac opened a new pull request, #37: URL: https://github.com/apache/parquet-site/pull/37 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix checksumming.md [parquet-site]

2024-01-13 Thread via GitHub
wgtmac merged PR #35: URL: https://github.com/apache/parquet-site/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac merged PR #224: URL: https://github.com/apache/parquet-format/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac commented on PR #224: URL: https://github.com/apache/parquet-format/pull/224#issuecomment-1841970937 Thanks for the suggestion! @kou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac commented on PR #224: URL: https://github.com/apache/parquet-format/pull/224#issuecomment-1841024568 > @kou Does the file syntax look ok? I copied this from https://github.com/apache/zookeeper/blob/master/.asf.yaml -- This is an automated message from the Apache Git Service.

Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
pitrou commented on PR #224: URL: https://github.com/apache/parquet-format/pull/224#issuecomment-1841021328 @kou Does the file syntax look ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Fix INTERVAL sort order doc in parquet.thrift to be undefined [parquet-format]

2023-12-05 Thread via GitHub
wgtmac merged PR #222: URL: https://github.com/apache/parquet-format/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac commented on PR #224: URL: https://github.com/apache/parquet-format/pull/224#issuecomment-1841016437 PTAL. Thanks! @pitrou @gszadovszky @shangxinli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac opened a new pull request, #224: URL: https://github.com/apache/parquet-format/pull/224 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them

Re: [PR] PARQUET-2407: Add customized .asf.yaml for email notifications [parquet-mr]

2023-12-04 Thread via GitHub
wgtmac merged PR #1232: URL: https://github.com/apache/parquet-mr/pull/1232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2407: Add customized .asf.yaml for email notifications [parquet-mr]

2023-12-04 Thread via GitHub
wgtmac commented on PR #1232: URL: https://github.com/apache/parquet-mr/pull/1232#issuecomment-1839865078 Thanks @gszadovszky @pitrou! I'll merge it to see what happens. If it works as expected, I'll create a PR for parquet-format as well. -- This is an automated message from the Apache

Re: [PR] PARQUET-2408: Fix license header in .gitattributes [parquet-mr]

2023-12-04 Thread via GitHub
Fokko merged PR #1231: URL: https://github.com/apache/parquet-mr/pull/1231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2261: Implement SizeStatistics [parquet-mr]

2023-12-04 Thread via GitHub
shangxinli commented on code in PR #1177: URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1414220467 ## parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java: ## @@ -409,4 +428,14 @@ abstract void writePage( ValuesWriter

Re: [PR] PARQUET-2261: Implement SizeStatistics [parquet-mr]

2023-12-04 Thread via GitHub
shangxinli commented on code in PR #1177: URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1414218649 ## parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java: ## @@ -389,7 +400,14 @@ void writePage() { this.rowsWrittenSoFar +=

Re: [PR] PARQUET-2261: Implement SizeStatistics [parquet-mr]

2023-12-04 Thread via GitHub
shangxinli commented on code in PR #1177: URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1414218649 ## parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java: ## @@ -389,7 +400,14 @@ void writePage() { this.rowsWrittenSoFar +=

Re: [PR] PARQUET-2407: Add customized .asf.yaml for email notifications [parquet-mr]

2023-12-04 Thread via GitHub
wgtmac commented on PR #1232: URL: https://github.com/apache/parquet-mr/pull/1232#issuecomment-1838950498 Per the [discussion on ML](https://lists.apache.org/thread/4x2ob2ojkznfft3czz0gypmtoz7vo9fz), I proposed to create an .asf.yaml file for customizing email notification. Please take a

[PR] PARQUET-2407: Add customized .asf.yaml for email notifications [parquet-mr]

2023-12-04 Thread via GitHub
wgtmac opened a new pull request, #1232: URL: https://github.com/apache/parquet-mr/pull/1232 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references

Re: [PR] PARQUET-2408: Fix license header in .gitattributes [parquet-mr]

2023-12-04 Thread via GitHub
wgtmac commented on PR #1231: URL: https://github.com/apache/parquet-mr/pull/1231#issuecomment-1838934525 PTAL @amousavigourabi @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] PARQUET-2408: Fix license header in .gitattributes [parquet-mr]

2023-12-04 Thread via GitHub
wgtmac opened a new pull request, #1231: URL: https://github.com/apache/parquet-mr/pull/1231 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references

Re: [PR] PARQUET-1822: Avoid requiring Hadoop installation for reading/writing [parquet-mr]

2023-12-04 Thread via GitHub
drealeed commented on PR #: URL: https://github.com/apache/parquet-mr/pull/#issuecomment-1838584976 @amousavigourabi , that's actually what I did and it's working for us now. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] PARQUET-2405: Include fallback CodecFactory implementation [parquet-mr]

2023-12-04 Thread via GitHub
amousavigourabi opened a new pull request, #1230: URL: https://github.com/apache/parquet-mr/pull/1230 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references

[PR] PARQUET-2406: Clean up valueOf calls where possible [parquet-mr]

2023-12-04 Thread via GitHub
amousavigourabi opened a new pull request, #1229: URL: https://github.com/apache/parquet-mr/pull/1229 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references

Re: [PR] PARQUET-2393: Make `ColumnIOCreatorVisitor` static [parquet-mr]

2023-12-04 Thread via GitHub
Fokko merged PR #1216: URL: https://github.com/apache/parquet-mr/pull/1216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2401: Synchronize on final fields [parquet-mr]

2023-12-04 Thread via GitHub
Fokko merged PR #1224: URL: https://github.com/apache/parquet-mr/pull/1224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2392: Remove StringBuilder in `LogicalTypeAnnotation` [parquet-mr]

2023-12-04 Thread via GitHub
Fokko merged PR #1215: URL: https://github.com/apache/parquet-mr/pull/1215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2394: Use `computeIfAbsent` in `MessageColumnIO` [parquet-mr]

2023-12-04 Thread via GitHub
Fokko merged PR #1217: URL: https://github.com/apache/parquet-mr/pull/1217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-1647: [Java][Parquet] Implement FLOAT16 logical type [parquet-mr]

2023-12-03 Thread via GitHub
wgtmac commented on PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1838002383 BTW, it would be good to add an interoperability test to read parquet files from here: https://github.com/apache/parquet-testing/commit/da467dac2f095b979af37bcf40fa0d1dee5ff652. You

Re: [PR] PARQUET-2395: Prefer `singletonList` over `asList` [parquet-mr]

2023-12-03 Thread via GitHub
wgtmac commented on PR #1218: URL: https://github.com/apache/parquet-mr/pull/1218#issuecomment-1837995639 Thanks for the explanation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] PARQUET-2395: Prefer `singletonList` over `asList` [parquet-mr]

2023-12-03 Thread via GitHub
Fokko commented on PR #1218: URL: https://github.com/apache/parquet-mr/pull/1218#issuecomment-1837993837 Thanks for the review @wgtmac, @zhangjiashen and @amousavigourabi  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] PARQUET-2395: Prefer `singletonList` over `asList` [parquet-mr]

2023-12-03 Thread via GitHub
Fokko merged PR #1218: URL: https://github.com/apache/parquet-mr/pull/1218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2395: Prefer `singletonList` over `asList` [parquet-mr]

2023-12-03 Thread via GitHub
Fokko commented on PR #1218: URL: https://github.com/apache/parquet-mr/pull/1218#issuecomment-1837993326 @wgtmac Two things: - `singletonList` is completely immutable, while with `asList` you can still mutate the reference. - `singletonList` is not backed by an array, reducing the

Re: [PR] PARQUET-2344: Bump to Thrift 0.19.0 [parquet-mr]

2023-12-03 Thread via GitHub
wgtmac commented on code in PR #1192: URL: https://github.com/apache/parquet-mr/pull/1192#discussion_r141345 ## pom.xml: ## @@ -619,6 +622,9 @@ true true + +

Re: [PR] PARQUET-2396: Refactor `ColumnIndexBuilder` [parquet-mr]

2023-12-03 Thread via GitHub
Fokko merged PR #1219: URL: https://github.com/apache/parquet-mr/pull/1219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2391: Remove unnecessary unboxing [parquet-mr]

2023-12-03 Thread via GitHub
Fokko commented on PR #1214: URL: https://github.com/apache/parquet-mr/pull/1214#issuecomment-1837969587 Thanks for the review @wgtmac & @amousavigourabi  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] PARQUET-1647: [Java][Parquet] Implement FLOAT16 logical type [parquet-mr]

2023-12-03 Thread via GitHub
zhangjiashen commented on code in PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1413455235 ## pom.xml: ## @@ -596,6 +597,9 @@ org.apache.parquet.arrow.schema.SchemaMapping + +

Re: [PR] PARQUET-2391: Remove unnecessary unboxing [parquet-mr]

2023-12-03 Thread via GitHub
Fokko merged PR #1214: URL: https://github.com/apache/parquet-mr/pull/1214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-12-03 Thread via GitHub
wgtmac merged PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2390: Replace anonymous functions with lambdas [parquet-mr]

2023-12-03 Thread via GitHub
Fokko commented on PR #1213: URL: https://github.com/apache/parquet-mr/pull/1213#issuecomment-1837879063 Thanks for the review @wgtmac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] PARQUET-2390: Replace anonymous functions with lambdas [parquet-mr]

2023-12-03 Thread via GitHub
Fokko merged PR #1213: URL: https://github.com/apache/parquet-mr/pull/1213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2400: Update Spotless command in PR prompt to include plugins [parquet-mr]

2023-12-03 Thread via GitHub
wgtmac merged PR #1223: URL: https://github.com/apache/parquet-mr/pull/1223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-1647: [Java][Parquet] Implement FLOAT16 logical type [parquet-mr]

2023-12-03 Thread via GitHub
wgtmac commented on code in PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1413353347 ## pom.xml: ## @@ -596,6 +597,9 @@ org.apache.parquet.arrow.schema.SchemaMapping + + org.apache.parquet.io.api.Binary

Re: [PR] PARQUET-1647: [Java][Parquet] Implement FLOAT16 logical type [parquet-mr]

2023-12-03 Thread via GitHub
zhangjiashen commented on PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1837800275 > Could you please rebase it? Rebased, can you help merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] PARQUET-2389: Remove redundant initializers [parquet-mr]

2023-12-03 Thread via GitHub
Fokko commented on PR #1212: URL: https://github.com/apache/parquet-mr/pull/1212#issuecomment-1837791938 Thanks for the review @wgtmac and @amousavigourabi  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] PARQUET-2389: Remove redundant initializers [parquet-mr]

2023-12-03 Thread via GitHub
Fokko merged PR #1212: URL: https://github.com/apache/parquet-mr/pull/1212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2388: Deprecate `CHARSETS` on `PlainValuesWriter` [parquet-mr]

2023-12-03 Thread via GitHub
Fokko merged PR #1211: URL: https://github.com/apache/parquet-mr/pull/1211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump actions/setup-java from 3 to 4 [parquet-mr]

2023-12-03 Thread via GitHub
Fokko merged PR #1225: URL: https://github.com/apache/parquet-mr/pull/1225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2387: Simplify `hasFieldsIgnored` expression [parquet-mr]

2023-12-03 Thread via GitHub
Fokko commented on PR #1210: URL: https://github.com/apache/parquet-mr/pull/1210#issuecomment-1837786670 Thanks @wgtmac  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] PARQUET-2387: Simplify `hasFieldsIgnored` expression [parquet-mr]

2023-12-03 Thread via GitHub
Fokko merged PR #1210: URL: https://github.com/apache/parquet-mr/pull/1210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Bump actions/setup-java from 3 to 4 [parquet-format]

2023-12-03 Thread via GitHub
dependabot[bot] opened a new pull request, #223: URL: https://github.com/apache/parquet-format/pull/223 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. Release notes Sourced from https://github.com/actions/setup-java/releases;>actions/setup-java's

Re: [PR] PARQUET-2399: Use deprecated tag in Javadoc [parquet-mr]

2023-12-02 Thread via GitHub
Fokko merged PR #1222: URL: https://github.com/apache/parquet-mr/pull/1222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 [parquet-mr]

2023-12-02 Thread via GitHub
dependabot[bot] opened a new pull request, #1228: URL: https://github.com/apache/parquet-mr/pull/1228 Bumps [org.codehaus.mojo:build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin) from 3.4.0 to 3.5.0. Release notes Sourced from

[PR] Bump org.codehaus.mojo:buildnumber-maven-plugin from 3.1.0 to 3.2.0 [parquet-mr]

2023-12-02 Thread via GitHub
dependabot[bot] opened a new pull request, #1227: URL: https://github.com/apache/parquet-mr/pull/1227 Bumps [org.codehaus.mojo:buildnumber-maven-plugin](https://github.com/mojohaus/buildnumber-maven-plugin) from 3.1.0 to 3.2.0. Release notes Sourced from

[PR] Bump com.google.api.grpc:proto-google-common-protos from 2.28.0 to 2.29.0 [parquet-mr]

2023-12-02 Thread via GitHub
dependabot[bot] opened a new pull request, #1226: URL: https://github.com/apache/parquet-mr/pull/1226 Bumps [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) from 2.28.0 to 2.29.0. Release notes Sourced from

[PR] Bump actions/setup-java from 3 to 4 [parquet-mr]

2023-12-02 Thread via GitHub
dependabot[bot] opened a new pull request, #1225: URL: https://github.com/apache/parquet-mr/pull/1225 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. Release notes Sourced from https://github.com/actions/setup-java/releases;>actions/setup-java's

[PR] MINOR: Fix INTERVAL sort order doc in parquet.thrift to be undefined [parquet-format]

2023-12-01 Thread via GitHub
Jefffrey opened a new pull request, #222: URL: https://github.com/apache/parquet-format/pull/222 Fixing parquet.thrift doc of sort order for INTERVAL to reflect change made by https://github.com/apache/parquet-format/commit/c6d306daad4910d21927b8b4447dc6e9fae6c714 Figured this is

[PR] PARQUET-2401: Synchronize on final fields [parquet-mr]

2023-12-01 Thread via GitHub
amousavigourabi opened a new pull request, #1224: URL: https://github.com/apache/parquet-mr/pull/1224 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references

Re: [PR] PARQUET-1822: Avoid requiring Hadoop installation for reading/writing [parquet-mr]

2023-12-01 Thread via GitHub
amousavigourabi commented on PR #: URL: https://github.com/apache/parquet-mr/pull/#issuecomment-1836931968 > Our project needs this feature as well, is there a date for the next major release? @drealeed if you just need to be able to drop the Hadoop Path dependency, you

Re: [PR] PARQUET-1822: Avoid requiring Hadoop installation for reading/writing [parquet-mr]

2023-12-01 Thread via GitHub
drealeed commented on PR #: URL: https://github.com/apache/parquet-mr/pull/#issuecomment-1836333591 Our project needs this feature as well, is there a date for the next major release? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] PARQUET-2387: Simplify `hasFieldsIgnored` expression [parquet-mr]

2023-11-30 Thread via GitHub
Fokko commented on code in PR #1210: URL: https://github.com/apache/parquet-mr/pull/1210#discussion_r1410732198 ## parquet-thrift/src/main/java/org/apache/parquet/thrift/BufferedProtocolReadToWrite.java: ## @@ -369,7 +369,7 @@ public String toDebugString() { ThriftField

Re: [PR] Bump com.fasterxml.jackson.core:jackson-databind from 2.15.2 to 2.16.0 [parquet-mr]

2023-11-30 Thread via GitHub
Fokko merged PR #1205: URL: https://github.com/apache/parquet-mr/pull/1205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PARQUET-2392: Remove StringBuilder in `LogicalTypeAnnotation` [parquet-mr]

2023-11-30 Thread via GitHub
Fokko commented on PR #1215: URL: https://github.com/apache/parquet-mr/pull/1215#issuecomment-1833844311 @zhangjiashen Thanks for the review, appreciate it! I don't think there are any negative performance implications since the compile will just optimize it to a single concatenation.

Re: [PR] PARQUET-2171: Support Hadoop vectored IO [parquet-mr]

2023-11-30 Thread via GitHub
steveloughran commented on code in PR #1139: URL: https://github.com/apache/parquet-mr/pull/1139#discussion_r1410699415 ## parquet-hadoop/README.md: ## @@ -501,3 +501,11 @@ If `false`, key material is stored in separate new files, created in the same fo **Description:**

<    1   2   3   4   5   6   7   8   9   10   >