[GitHub] [pdfbox] rombert opened a new pull request, #165: PDFBOX-5687 - PDFBox 3.0 OSGi bundle requires sun.java2d.cmm.kcms package

2023-09-27 Thread via GitHub
rombert opened a new pull request, #165: URL: https://github.com/apache/pdfbox/pull/165 Disable generating Import-Package statements for "Class.forName" calls completely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] PDFBOX-5687 - PDFBox 3.0 OSGi bundle requires sun.java2d.cmm.kcms package [pdfbox]

2023-10-09 Thread via GitHub
rombert commented on PR #165: URL: https://github.com/apache/pdfbox/pull/165#issuecomment-1752925580 Closed with a different solution, see Jira issue for details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] PDFBOX-5687 - PDFBox 3.0 OSGi bundle requires sun.java2d.cmm.kcms package [pdfbox]

2023-10-09 Thread via GitHub
rombert closed pull request #165: PDFBOX-5687 - PDFBox 3.0 OSGi bundle requires sun.java2d.cmm.kcms package URL: https://github.com/apache/pdfbox/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pdfbox-docs] Jonahmm opened a new pull request, #15: Add color methods info to migration guide

2023-08-21 Thread via GitHub
Jonahmm opened a new pull request, #15: URL: https://github.com/apache/pdfbox-docs/pull/15 This caught me out while migrating as the `float` overloads compile with `int` values, meaning the error only surfaces at runtime. Hopefully including it here will help others. Feel free to

[GitHub] [pdfbox-docs] ascheja opened a new pull request, #14: Fix artifactId for pdfbox-io

2023-08-21 Thread via GitHub
ascheja opened a new pull request, #14: URL: https://github.com/apache/pdfbox-docs/pull/14 Was changed in PDFBOX-5608, also see https://github.com/apache/pdfbox/commit/e0f5999b16df7bead1cd705ebe6791bc4aefb76e. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pdfbox-docs] lehmi commented on pull request #14: Fix artifactId for pdfbox-io

2023-08-21 Thread via GitHub
lehmi commented on PR #14: URL: https://github.com/apache/pdfbox-docs/pull/14#issuecomment-1686577758 Thanks for the input -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pdfbox-docs] lehmi commented on pull request #15: Add color methods info to migration guide

2023-08-21 Thread via GitHub
lehmi commented on PR #15: URL: https://github.com/apache/pdfbox-docs/pull/15#issuecomment-1686576939 Thanks for the input -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pdfbox-docs] lehmi merged pull request #14: Fix artifactId for pdfbox-io

2023-08-21 Thread via GitHub
lehmi merged PR #14: URL: https://github.com/apache/pdfbox-docs/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pdfbox-docs] lehmi merged pull request #15: Add color methods info to migration guide

2023-08-21 Thread via GitHub
lehmi merged PR #15: URL: https://github.com/apache/pdfbox-docs/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pdfbox] asfgit closed pull request #152: FontBox: Add a method to view composite glyph components

2023-01-23 Thread via GitHub
asfgit closed pull request #152: FontBox: Add a method to view composite glyph components URL: https://github.com/apache/pdfbox/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pdfbox] knazarenkov commented on a diff in pull request #151: PDResource font cache improvement

2023-01-24 Thread via GitHub
knazarenkov commented on code in PR #151: URL: https://github.com/apache/pdfbox/pull/151#discussion_r1085534915 ## pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDResources.java: ## @@ -95,6 +96,24 @@ public PDResources(COSDictionary resourceDictionary, ResourceCache

[GitHub] [pdfbox] Toparvion commented on pull request #152: FontBox: Add a method to view composite glyph components

2023-01-25 Thread via GitHub
Toparvion commented on PR #152: URL: https://github.com/apache/pdfbox/pull/152#issuecomment-1404452451 ✅ The PR is closed as its content was relocated by @lehmi into Apache SVN within [revision 1906970](https://svn.apache.org/viewvc?view=revision=1906970). -- This is an automated

[GitHub] [pdfbox] lehmi commented on a diff in pull request #153: PDFBOX-4189: Add a method to get GSUB data for specific script tag

2023-01-26 Thread via GitHub
lehmi commented on code in PR #153: URL: https://github.com/apache/pdfbox/pull/153#discussion_r1088628537 ## fontbox/src/main/java/org/apache/fontbox/ttf/gsub/DefaultGsubWorker.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [pdfbox] asfgit closed pull request #153: PDFBOX-4189: Add a method to get GSUB data for specific script tag

2023-01-29 Thread via GitHub
asfgit closed pull request #153: PDFBOX-4189: Add a method to get GSUB data for specific script tag URL: https://github.com/apache/pdfbox/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pdfbox] Toparvion commented on pull request #153: PDFBOX-4189: Add a method to get GSUB data for specific script tag

2023-01-30 Thread via GitHub
Toparvion commented on PR #153: URL: https://github.com/apache/pdfbox/pull/153#issuecomment-1408525920 ✅ The fix has been [integrated](https://svn.apache.org/viewvc?view=revision=1907078) into Apache Git repository by @lehmi within issue

[GitHub] [pdfbox] knazarenkov commented on pull request #151: PDResource font cache improvement

2023-01-30 Thread via GitHub
knazarenkov commented on PR #151: URL: https://github.com/apache/pdfbox/pull/151#issuecomment-1408528343 @THausherr @lehmi Any updates on reviewing PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pdfbox] Toparvion commented on a diff in pull request #153: PDFBOX-4189: Add a method to get GSUB data for specific script tag

2023-01-27 Thread via GitHub
Toparvion commented on code in PR #153: URL: https://github.com/apache/pdfbox/pull/153#discussion_r1089665713 ## fontbox/src/main/java/org/apache/fontbox/ttf/gsub/DefaultGsubWorker.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [pdfbox] Toparvion commented on a diff in pull request #153: PDFBOX-4189: Add a method to get GSUB data for specific script tag

2023-01-27 Thread via GitHub
Toparvion commented on code in PR #153: URL: https://github.com/apache/pdfbox/pull/153#discussion_r1083583024 ## fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java: ## @@ -701,6 +703,42 @@ public GsubData getGsubData() return gsubData; } +

[GitHub] [pdfbox-docs] Toparvion opened a new pull request, #11: Add a how-to section for IntelliJ IDEA users

2023-01-22 Thread via GitHub
Toparvion opened a new pull request, #11: URL: https://github.com/apache/pdfbox-docs/pull/11 This PR appends _Eclipse Formatter_ section of [Coding Conevtions](https://pdfbox.apache.org/codingconventions.html) page with a short description of how to make use of

[GitHub] [pdfbox] Toparvion opened a new pull request, #153: PDFBOX-4189: Add a method to get GSUB data for specific script tag

2023-01-21 Thread via GitHub
Toparvion opened a new pull request, #153: URL: https://github.com/apache/pdfbox/pull/153 This is a proposal for overcoming current GSUB table handling limitation of FontBox library. It is currently not possible to read GSUB table data for any language other than Bengali. This PR

[GitHub] [pdfbox] asfgit closed pull request #150: better deviceCMYK profile

2023-01-22 Thread via GitHub
asfgit closed pull request #150: better deviceCMYK profile URL: https://github.com/apache/pdfbox/pull/150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pdfbox-docs] lehmi commented on pull request #8: Updated Maven example to use version 2.0.24

2023-01-22 Thread via GitHub
lehmi commented on PR #8: URL: https://github.com/apache/pdfbox-docs/pull/8#issuecomment-1399536939 Sorry for not commenting on your PR. Meanwhile the change is outdated and the file in question was updated after releasing 2.0.27 -- This is an automated message from the Apache Git

[GitHub] [pdfbox-docs] lehmi closed pull request #8: Updated Maven example to use version 2.0.24

2023-01-22 Thread via GitHub
lehmi closed pull request #8: Updated Maven example to use version 2.0.24 URL: https://github.com/apache/pdfbox-docs/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pdfbox-docs] lehmi merged pull request #10: Link changed

2023-01-22 Thread via GitHub
lehmi merged PR #10: URL: https://github.com/apache/pdfbox-docs/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pdfbox] lehmi commented on a diff in pull request #151: PDResource font cache improvement

2023-01-22 Thread via GitHub
lehmi commented on code in PR #151: URL: https://github.com/apache/pdfbox/pull/151#discussion_r1083493142 ## pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDResources.java: ## @@ -95,6 +96,24 @@ public PDResources(COSDictionary resourceDictionary, ResourceCache resourceCache

[GitHub] [pdfbox-docs] lehmi commented on pull request #11: Add a how-to section for IntelliJ IDEA users

2023-01-22 Thread via GitHub
lehmi commented on PR #11: URL: https://github.com/apache/pdfbox-docs/pull/11#issuecomment-1399535902 I've pushed the changes to the website -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pdfbox-docs] lehmi commented on pull request #10: Link changed

2023-01-22 Thread via GitHub
lehmi commented on PR #10: URL: https://github.com/apache/pdfbox-docs/pull/10#issuecomment-1399538261 I've pushed the changes to the website. Thanks for the contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pdfbox-docs] lehmi merged pull request #11: Add a how-to section for IntelliJ IDEA users

2023-01-22 Thread via GitHub
lehmi merged PR #11: URL: https://github.com/apache/pdfbox-docs/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pdfbox] Toparvion commented on a diff in pull request #153: PDFBOX-4189: Add a method to get GSUB data for specific script tag

2023-01-22 Thread via GitHub
Toparvion commented on code in PR #153: URL: https://github.com/apache/pdfbox/pull/153#discussion_r1083583024 ## fontbox/src/main/java/org/apache/fontbox/ttf/GlyphSubstitutionTable.java: ## @@ -701,6 +703,42 @@ public GsubData getGsubData() return gsubData; } +

[GitHub] [pdfbox-docs] Toparvion commented on pull request #11: Add a how-to section for IntelliJ IDEA users

2023-01-22 Thread via GitHub
Toparvion commented on PR #11: URL: https://github.com/apache/pdfbox-docs/pull/11#issuecomment-1399669409 @lehmi , thank you for accepting this PR! I've also noted there are several `checkstyle.xml` files in the repository, and they also can be leveraged by IntellidJ IDEA users to

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

2023-03-08 Thread via GitHub
THausherr commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1460102180 Re the latest ContentStreamWriter.java change, I was wondering if we could overload all methods but when I put a log here ``` else if( o instanceof Operator) {

[GitHub] [pdfbox] lehmi commented on pull request #107: potential memory leaks and small performance improvements

2023-03-08 Thread via GitHub
lehmi commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1460488068 Java tries to match the calling type of the parameter with the method signature but it doesn't do any automatic up-casting to find a more specific match before calling it. Saying

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

2023-03-12 Thread via GitHub
THausherr commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1465128114 Good find, fixed. Not a bug, operators really aren't written in object streams. Probably copied from other code. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

2023-03-11 Thread via GitHub
THausherr commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1464999224 typos fixed, thanks. I think it's just debug output. Re my misunderstanding about overloading: I understand now that I have to see this "at compile time", it's not dynamic. Maybe I had

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-03-12 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1465123288 Hi, @THausherr! The second parameter of the COSWriterObjectStream.writeObject method is of type Object. But you always send COSBase type (you can change Object type to COSBase for line

[GitHub] [pdfbox] xzel23 opened a new pull request, #157: Fix log issues

2023-03-17 Thread via GitHub
xzel23 opened a new pull request, #157: URL: https://github.com/apache/pdfbox/pull/157 I fixed some smaller problems with logging in trunk: - GlyphRenderer conditions and logging calls did not match leading to unnecessary string formatting when log level is debug - BidiTest logger was

[GitHub] [pdfbox] xzel23 opened a new pull request, #158: small code cleanups

2023-03-17 Thread via GitHub
xzel23 opened a new pull request, #158: URL: https://github.com/apache/pdfbox/pull/158 - in some places, unnecessary explicit boxing/unboxing was done - I replaced some XXX.valueOf(String) calls with the corresponding XXX.parseXXX(String) calls. XXX.valueOf() always returns a boxed

[GitHub] [pdfbox] THausherr commented on pull request #159: fix unnecessary boxing/unboxing

2023-03-19 Thread via GitHub
THausherr commented on PR #159: URL: https://github.com/apache/pdfbox/pull/159#issuecomment-1475578744 Please close this one (I can close it through the commit message but forgot, twice) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pdfbox] xzel23 commented on pull request #157: Fix log issues

2023-03-17 Thread via GitHub
xzel23 commented on PR #157: URL: https://github.com/apache/pdfbox/pull/157#issuecomment-1474484847 created [PDFBOX-5572](https://issues.apache.org/jira/browse/PDFBOX-5572) for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pdfbox] digital2real opened a new pull request, #161: pdfbox cli : fix support import:xfdf

2023-03-23 Thread via GitHub
digital2real opened a new pull request, #161: URL: https://github.com/apache/pdfbox/pull/161 This will fix this error when using **pdfbox cli** with action **import:xfdf** : ``` picocli.CommandLine$ExecutionException: Parsed command (org.apache.pdfbox.tools.ImportXFDF@78dd667e)

[GitHub] [pdfbox] THausherr commented on pull request #161: pdfbox cli : fix support import:xfdf

2023-03-23 Thread via GitHub
THausherr commented on PR #161: URL: https://github.com/apache/pdfbox/pull/161#issuecomment-1482202492 Done, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pdfbox] asfgit closed pull request #161: pdfbox cli : fix support import:xfdf

2023-03-23 Thread via GitHub
asfgit closed pull request #161: pdfbox cli : fix support import:xfdf URL: https://github.com/apache/pdfbox/pull/161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pdfbox] SaptarshiSarkar12 commented on pull request #160: Fixed some README issues

2023-03-22 Thread via GitHub
SaptarshiSarkar12 commented on PR #160: URL: https://github.com/apache/pdfbox/pull/160#issuecomment-1479032662 @THausherr Please let me know why pull requests are not accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pdfbox] SaptarshiSarkar12 opened a new pull request, #160: Fixed some README issues

2023-03-21 Thread via GitHub
SaptarshiSarkar12 opened a new pull request, #160: URL: https://github.com/apache/pdfbox/pull/160 I have fixed some problems in Readme file, by adding code blocks and direct link to LICENSE.txt for better navigation and accessibility. -- This is an automated message from the Apache Git

[GitHub] [pdfbox] SaptarshiSarkar12 commented on pull request #160: Fixed some README issues

2023-03-21 Thread via GitHub
SaptarshiSarkar12 commented on PR #160: URL: https://github.com/apache/pdfbox/pull/160#issuecomment-1478914996 @THausherr Please review this Pull Request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pdfbox] SaptarshiSarkar12 commented on pull request #160: Fixed some README issues

2023-03-22 Thread via GitHub
SaptarshiSarkar12 commented on PR #160: URL: https://github.com/apache/pdfbox/pull/160#issuecomment-1479111492 Okay I understood. Thank you for explaining me @THausherr ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pdfbox] asfgit closed pull request #160: Fixed some README issues

2023-03-22 Thread via GitHub
asfgit closed pull request #160: Fixed some README issues URL: https://github.com/apache/pdfbox/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pdfbox] THausherr commented on pull request #160: Fixed some README issues

2023-03-22 Thread via GitHub
THausherr commented on PR #160: URL: https://github.com/apache/pdfbox/pull/160#issuecomment-1479023356 Thanks, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pdfbox] SaptarshiSarkar12 commented on pull request #160: Fixed some README issues

2023-03-22 Thread via GitHub
SaptarshiSarkar12 commented on PR #160: URL: https://github.com/apache/pdfbox/pull/160#issuecomment-1479031498 > Thanks, fixed. Welcome @THausherr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pdfbox] THausherr commented on pull request #160: Fixed some README issues

2023-03-22 Thread via GitHub
THausherr commented on PR #160: URL: https://github.com/apache/pdfbox/pull/160#issuecomment-1479052014 Your changes were accepted. PRs aren't merged directly because this is a read-only mirror to an svn repository. The "official" road is to create a JIRA ticket and to attach a patch. But

[GitHub] [pdfbox] xzel23 closed pull request #159: fix unnecessary boxing/unboxing

2023-03-20 Thread via GitHub
xzel23 closed pull request #159: fix unnecessary boxing/unboxing URL: https://github.com/apache/pdfbox/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pdfbox] xzel23 commented on pull request #157: Fix log issues

2023-03-18 Thread via GitHub
xzel23 commented on PR #157: URL: https://github.com/apache/pdfbox/pull/157#issuecomment-1474770208 Has been applied in SVN by Tilmann Hausherr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pdfbox] xzel23 closed pull request #157: Fix log issues

2023-03-18 Thread via GitHub
xzel23 closed pull request #157: Fix log issues URL: https://github.com/apache/pdfbox/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pdfbox] xzel23 commented on pull request #158: small code cleanups

2023-03-18 Thread via GitHub
xzel23 commented on PR #158: URL: https://github.com/apache/pdfbox/pull/158#issuecomment-1474775181 I will split this up into smaller chunks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pdfbox] xzel23 closed pull request #158: small code cleanups

2023-03-18 Thread via GitHub
xzel23 closed pull request #158: small code cleanups URL: https://github.com/apache/pdfbox/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pdfbox] xzel23 opened a new pull request, #159: fix unnecessary boxing/unboxing

2023-03-18 Thread via GitHub
xzel23 opened a new pull request, #159: URL: https://github.com/apache/pdfbox/pull/159 Most of the changes make the code just more readable and the compiler does auto(un)boxing where necessary. Replacing `Boolean.valueOf()` and `Float.valueOf()` on the other hand completely avoids a

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-03-11 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1464946362 Hi, @THausherr! As I understand, java tries to find a method with the same parameter type or parental type. If you will put Object as parameter then java will use

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-03-11 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1464949026 ![image](https://user-images.githubusercontent.com/67366451/224496506-92e0f9a1-8310-4493-a1ac-6ad225c41b78.png) -- This is an automated message from the Apache Git Service. To

[GitHub] [pdfbox] asfgit closed pull request #154: PDFBOX-4531: Reverse the order of decomposed Arabic letters

2023-02-25 Thread via GitHub
asfgit closed pull request #154: PDFBOX-4531: Reverse the order of decomposed Arabic letters URL: https://github.com/apache/pdfbox/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pdfbox] komedani opened a new pull request, #156: PDFBOX-4531: Reverse the order of decomposed Arabic/Hebrew letters

2023-02-22 Thread via GitHub
komedani opened a new pull request, #156: URL: https://github.com/apache/pdfbox/pull/156 Please see [PDFBOX-4531](https://issues.apache.org/jira/browse/PDFBOX-4531) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pdfbox] komedani closed pull request #156: PDFBOX-4531: Reverse the order of decomposed Arabic/Hebrew letters

2023-02-26 Thread via GitHub
komedani closed pull request #156: PDFBOX-4531: Reverse the order of decomposed Arabic/Hebrew letters URL: https://github.com/apache/pdfbox/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pdfbox] noureldin-eg opened a new pull request, #154: PDFBOX-4531: Reverse the order of decomposed Arabic letters

2023-02-19 Thread via GitHub
noureldin-eg opened a new pull request, #154: URL: https://github.com/apache/pdfbox/pull/154 Please see [PDFBOX-4531](https://issues.apache.org/jira/browse/PDFBOX-4531) and the comments below. - Any composed letters or word ligatures are stored in logical order and should be

[GitHub] [pdfbox] noureldin-eg opened a new pull request, #155: PDFBOX-5487: Remove all space characters if contained within the adjacent letters

2023-02-19 Thread via GitHub
noureldin-eg opened a new pull request, #155: URL: https://github.com/apache/pdfbox/pull/155 Please see [PDFBOX-5487](https://issues.apache.org/jira/browse/PDFBOX-5487) and the comments below. In the [PDF attached in the Jira

[GitHub] [pdfbox] mslowiak commented on pull request #151: PDResource font cache improvement

2023-02-19 Thread via GitHub
mslowiak commented on PR #151: URL: https://github.com/apache/pdfbox/pull/151#issuecomment-1436031000 @lehmi, @THausherr - Is there any ETA when `2.0.28` will be released with this fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-02-28 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1448831195 Hi, @THausherr ! Several possible performance improvements. Inside GlyphSubstitutionTable.readScriptList method we create a scriptTables variable. Then we fill it in loop. We then

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

2023-02-28 Thread via GitHub
THausherr commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1449313244 > Hi, @THausherr ! Several possible performance improvements. Inside GlyphSubstitutionTable.readScriptList method we create a scriptTables variable. Then we fill it in loop. We then use

[GitHub] [pdfbox] lehmi commented on pull request #107: potential memory leaks and small performance improvements

2023-02-28 Thread via GitHub
lehmi commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1449434280 There is still some room for improvement. The classes ScriptRecord and LangSysRecord are obsolete as they are only used to transport two values to the next line and aren't used any more. --

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

2023-02-28 Thread via GitHub
THausherr commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1449477685 @lehmi Indeed, thanks! Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pdfbox] Etienne-Gautier opened a new pull request, #162: Avoid division by 0 in shading function interpolation

2023-04-28 Thread via GitHub
Etienne-Gautier opened a new pull request, #162: URL: https://github.com/apache/pdfbox/pull/162 I am seeing a case of division by `0f` (producing a NaN) when trying to evaluate a gradient with a specific type 3 color function. I believe pdfbox isn't complying with the following

[GitHub] [pdfbox] myroch opened a new pull request, #163: PDFBOX-5591: Parsing of XMP metadata without optional xmpmeta element

2023-04-28 Thread via GitHub
myroch opened a new pull request, #163: URL: https://github.com/apache/pdfbox/pull/163 As per XMP Specification is the xmpmeta element optional: The sections below describe the high-level structure of XMP data in an XMP Packet: - The outermost element is optionally an

[GitHub] [pdfbox] Etienne-Gautier commented on a diff in pull request #162: Avoid division by 0 in shading function interpolation

2023-04-28 Thread via GitHub
Etienne-Gautier commented on code in PR #162: URL: https://github.com/apache/pdfbox/pull/162#discussion_r1179980026 ## pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunction.java: ## @@ -348,6 +348,9 @@ else if (x > rangeMax) */ protected float

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-04-26 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1523556089 Hi, @THausherr! I found several issues for pdfbox. 1 PDColorspace and PDSpecialColorSpace have the same implementation of getCOSObject method (inheritance) 2

[GitHub] [pdfbox] Etienne-Gautier commented on a diff in pull request #162: Avoid division by 0 in shading function interpolation

2023-04-30 Thread via GitHub
Etienne-Gautier commented on code in PR #162: URL: https://github.com/apache/pdfbox/pull/162#discussion_r1179980026 ## pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunction.java: ## @@ -348,6 +348,9 @@ else if (x > rangeMax) */ protected float

[GitHub] [pdfbox] THausherr commented on pull request #162: Avoid division by 0 in shading function interpolation

2023-05-01 Thread via GitHub
THausherr commented on PR #162: URL: https://github.com/apache/pdfbox/pull/162#issuecomment-1529780845 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pdfbox] THausherr commented on pull request #162: Avoid division by 0 in shading function interpolation

2023-05-01 Thread via GitHub
THausherr commented on PR #162: URL: https://github.com/apache/pdfbox/pull/162#issuecomment-1529771945 I found a file where the change does make a difference in rendering [PDFJS-3096.pdf](https://github.com/apache/pdfbox/files/11365859/PDFJS-3096.pdf) (the "back" key now appears

[GitHub] [pdfbox] asfgit closed pull request #162: Avoid division by 0 in shading function interpolation

2023-05-01 Thread via GitHub
asfgit closed pull request #162: Avoid division by 0 in shading function interpolation URL: https://github.com/apache/pdfbox/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pdfbox] THausherr commented on pull request #162: Avoid division by 0 in shading function interpolation

2023-05-01 Thread via GitHub
THausherr commented on PR #162: URL: https://github.com/apache/pdfbox/pull/162#issuecomment-1529587228 Thanks https://issues.apache.org/jira/browse/PDFBOX-5593 (Will test and commit later) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

2023-04-30 Thread via GitHub
THausherr commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1529374910 Thanks, all fixed. Amusingly, I had a personal comment in the PDSpecialColorSpace class ("//TODO why is this needed? Super method is identical") and the file is from 2016. I'm keeping the

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-05-02 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1531222910 Hi, @THausherr ! These changes also available for line 159 (PDSeparation.toRGBImage). -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pdfbox] lehmi commented on pull request #107: potential memory leaks and small performance improvements

2023-04-02 Thread via GitHub
lehmi commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1493295759 @valerybokov thanks for the pointer. I've fixed the buggy condition and replaced the and- with an or-operator including some brackets. Checking nextThreeBytes[0] two times was intented.

[GitHub] [pdfbox] lehmi commented on pull request #107: potential memory leaks and small performance improvements

2023-04-02 Thread via GitHub
lehmi commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1493308105 @valerybokov thanks for being persistent. Yes, there were still some missing brackets, I've added them and IMHO everything should be fine now -- This is an automated message from the Apache

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-04-02 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1493288760 Hi, @lehmi ! I saw your commit "PDFBOX-5178: add LF-combinations to checkForEndOfString..." (https://github.com/apache/pdfbox/commit/86b957ad44b4b23015def8c1319be49450370a3a). As I

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-04-02 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1493299810 @lehmi , as I see, > @valerybokov thanks for the pointer. I've fixed the buggy condition and replaced the and- with an or-operator including some brackets. Checking

[GitHub] [pdfbox] lehmi commented on pull request #151: PDResource font cache improvement

2023-02-05 Thread via GitHub
lehmi commented on PR #151: URL: https://github.com/apache/pdfbox/pull/151#issuecomment-1417632563 I've opened a JIRA ticket, see https://issues.apache.org/jira/browse/PDFBOX-5564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pdfbox] asfgit closed pull request #151: PDResource font cache improvement

2023-02-05 Thread via GitHub
asfgit closed pull request #151: PDResource font cache improvement URL: https://github.com/apache/pdfbox/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

2023-07-02 Thread via GitHub
THausherr commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1616746649 Thanks, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pdfbox] lehmi commented on pull request #164: New tests for `COSName.writePDF`

2023-07-08 Thread via GitHub
lehmi commented on PR #164: URL: https://github.com/apache/pdfbox/pull/164#issuecomment-1626938838 Your is a valid test, but it won't increase out test coverage as that method in question is covered by other tests already. -- This is an automated message from the Apache Git

[GitHub] [pdfbox] christianAppl closed pull request #86: PDFBOX-4952 PDF compression - object stream creation

2023-05-22 Thread via GitHub
christianAppl closed pull request #86: PDFBOX-4952 PDF compression - object stream creation URL: https://github.com/apache/pdfbox/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-06-25 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1605995006 Hi, @lehmi! Have a question about your commit PDFBOX-5551: replace malformed (sub)stream with an empty one, DRY git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1910585

[GitHub] [pdfbox] lehmi commented on pull request #107: potential memory leaks and small performance improvements

2023-06-25 Thread via GitHub
lehmi commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1606020608 > Hi, @lehmi! Have a question about your commit PDFBOX-5551: replace malformed (sub)stream with an empty one, DRY git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1910585

[GitHub] [pdfbox] lehmi commented on pull request #107: potential memory leaks and small performance improvements

2023-06-25 Thread via GitHub
lehmi commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1606085188 > > > Hi, @lehmi! Have a question about your commit PDFBOX-5551: replace malformed (sub)stream with an empty one, DRY git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1910585

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-06-25 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1606024808 > > Hi, @lehmi! Have a question about your commit PDFBOX-5551: replace malformed (sub)stream with an empty one, DRY git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1910585

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-06-25 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1606049748 > > Hi, @lehmi! Have a question about your commit PDFBOX-5551: replace malformed (sub)stream with an empty one, DRY git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1910585

[GitHub] [pdfbox] Deee92 opened a new pull request, #164: New tests for `COSName.writePDF`

2023-06-29 Thread via GitHub
Deee92 opened a new pull request, #164: URL: https://github.com/apache/pdfbox/pull/164 Hello! I tried a few command-line tools on some PDF documents, and found that

[GitHub] [pdfbox] Deee92 commented on pull request #164: New tests for `COSName.writePDF`

2023-07-01 Thread via GitHub
Deee92 commented on PR #164: URL: https://github.com/apache/pdfbox/pull/164#issuecomment-1615926985 Hi @THausherr, that's a fair point! However, the integer parameters (`47`, `84`, `112`, `121`, `101`) with which `OutputStream.write(int)` is called within

[GitHub] [pdfbox] THausherr commented on pull request #164: New tests for `COSName.writePDF`

2023-07-01 Thread via GitHub
THausherr commented on PR #164: URL: https://github.com/apache/pdfbox/pull/164#issuecomment-1615847933 I don't see how this improves test coverage; at most, this shows an interesting example on how to use mockito. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2023-07-02 Thread via GitHub
valerybokov commented on PR #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1616657543 Hi, @THauserr! The comment to the PDColor.toRGB method says "throws IllegalStateException if this color value is a pattern." I checked several color spaces and found that they either

[GitHub] [pdfbox-docs] jochenberger opened a new pull request, #13: Fix a typo

2023-06-28 Thread via GitHub
jochenberger opened a new pull request, #13: URL: https://github.com/apache/pdfbox-docs/pull/13 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pdfbox-docs] THausherr merged pull request #13: Fix a typo

2023-06-28 Thread via GitHub
THausherr merged PR #13: URL: https://github.com/apache/pdfbox-docs/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pdfbox-docs] THausherr merged pull request #5: remove jbig2 version from dependencies

2023-06-28 Thread via GitHub
THausherr merged PR #5: URL: https://github.com/apache/pdfbox-docs/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >