Github user twdsilva commented on the pull request:
https://github.com/apache/phoenix/pull/133#issuecomment-159137696
@samarthjain @JamesRTaylor
Thanks for the review, I will make the remaining changes on commit.
---
If your project is set up for it, you can reply to this email
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45692528
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1268,19 +1312,19 @@ public MutationState
createIndex(CreateIndex
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/133#issuecomment-159119469
+1. This is fantastic work, Thomas! Other than a few minor nits and
comments, this looks great!
---
If your project is set up for it, you can reply to this email a
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45684755
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableRef.java ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45683895
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj) {
if (o
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45683493
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1268,19 +1312,19 @@ public MutationState
createIndex(CreateIn
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45683372
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1137,7 +1181,7 @@ public MutationState createIndex(CreateIndex
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45682394
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj) {
i
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45682143
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj) {
if
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45681971
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj) {
if
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45681958
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj) {
if (o
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45679822
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/transactions/RecreateTableIT.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Softwar
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45679601
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableRef.java ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Founda
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45679547
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj) {
i
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45679482
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/ServerUtil.java ---
@@ -66,7 +67,9 @@ public static IOException createIOException(String msg,
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45678935
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -0,0 +1,497 @@
+/*
+ * Licensed to the Ap
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45678844
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -0,0 +1,497 @@
+/*
+ * Licensed to the Ap
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45678756
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -0,0 +1,497 @@
+/*
+ * Licensed to the Ap
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45678362
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/execute/PartialCommitIT.java ---
@@ -241,6 +260,12 @@ private void testPartialCommit(List
stateme
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45678083
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj) {
if
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45677974
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/transactions/RecreateTableIT.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Sof
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45677835
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/transactions/RecreateTableIT.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Sof
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45677707
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
---
@@ -209,13 +212,34 @@ private static boolean isEmptyKeyValue(PTable table
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45677553
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/ServerUtil.java ---
@@ -66,7 +67,9 @@ public static IOException createIOException(String msg
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45677421
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/query/ParallelIteratorsSplitTest.java
---
@@ -455,4 +455,4 @@ public boolean useRoundRobinItera
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45677015
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/TestLocalTableState.java
---
@@ -23,9 +23,10 @@
import java.util.List;
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/133
PHOENIX-1674 Snapshot isolation transaction support through Tephra
@JamesRTaylor @samarthjain
Final PR with all feedback
You can merge this pull request into a Git repository by running:
Github user twdsilva closed the pull request at:
https://github.com/apache/phoenix/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45663610
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1222,7 +1228,7 @@ public void createTable(RpcControll
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45663558
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTableInterface.java
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache S
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45663414
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -301,28 +476,80 @@ public void remove() {
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45663399
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -153,6 +344,15 @@ public void join(MutationState newMutationState)
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45662694
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java ---
@@ -51,6 +51,7 @@
import org.apache.phoenix.iterate.SequenceResu
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45548701
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1222,7 +1228,7 @@ public void createTable(RpcCont
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45538919
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTableInterface.java
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apach
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45538874
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -301,28 +476,80 @@ public void remove() {
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45538848
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -153,6 +344,15 @@ public void join(MutationState newMutationSta
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45538575
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java ---
@@ -51,6 +51,7 @@
import org.apache.phoenix.iterate.SequenceR
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/131#issuecomment-158572388
FYI, @twdsilva broke this up into two separate pulls because GitHub wasn't
show the diff for all files. The tests are over in
https://github.com/apache/phoenix/pul
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/131
PHOENIX-1674 Snapshot isolation transaction support through Tephra
PR without tests.
@JamesRTaylor @samarthjain
You can merge this pull request into a Git repository by running:
$
Github user twdsilva closed the pull request at:
https://github.com/apache/phoenix/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/130#discussion_r45503300
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java ---
@@ -45,19 +45,24 @@
private final boolean localIndex;
p
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/130#discussion_r45427745
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -415,24 +425,47 @@ private long getClientTimeStamp() {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/130#discussion_r45427356
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -0,0 +1,515 @@
+/*
+ * Licensed to the Ap
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/130#discussion_r45427307
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -0,0 +1,515 @@
+/*
+ * Licensed to the Ap
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/130#discussion_r45427160
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -415,24 +425,47 @@ private long getClientTimeStamp() {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/130#discussion_r45426178
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java ---
@@ -45,19 +45,24 @@
private final boolean localIndex;
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/130#issuecomment-158249482
The check in TableRef.equals() isn't complete. It should be something like
this:
if (((table.getName() == null && other.table.getName() != null)
||(tabl
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/130#discussion_r45425593
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
---
@@ -258,7 +264,18 @@ public SQLException newException(SQLExcept
Github user twdsilva commented on the pull request:
https://github.com/apache/phoenix/pull/130#issuecomment-158247567
For the last few files that aren't showing up in the diff view , you can
view the diffs here
https://patch-diff.githubusercontent.com/raw/apache/phoenix/pull/130.pa
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/130
PHOENIX-1674 Snapshot isolation transaction support through Tephra
@samarthjain @JamesRTaylor
Closed https://github.com/apache/phoenix/pull/129 since its missing some
files.
I added the
Github user twdsilva closed the pull request at:
https://github.com/apache/phoenix/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45417506
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -101,7 +105,7 @@ else if (SchemaUtil.isPKColumn(column)) {
publ
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45416912
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java ---
@@ -175,7 +176,9 @@ private void createTable(Connection conn, Stri
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45370189
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -135,230 +154,282 @@ public void tearDown() throws Ex
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45368191
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -570,6 +946,97 @@ public void rollback(PhoenixConnection conne
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45367376
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -570,6 +946,97 @@ public void rollback(PhoenixConnection conne
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45367035
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -90,44 +108,217 @@
*/
public class MutationState im
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45366989
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -90,44 +108,217 @@
*/
public class MutationState im
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45366823
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -90,44 +108,217 @@
*/
public class MutationState im
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45365843
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -135,230 +154,282 @@ public void tearDown() throws Ex
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45308492
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java
---
@@ -99,18 +105,38 @@
private PMetaData m
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45308170
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java ---
@@ -175,7 +176,9 @@ private void createTable(Connection conn,
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45308074
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java ---
@@ -175,7 +176,9 @@ private void createTable(Connection conn, S
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/129#issuecomment-157971369
I can't find PhoenixTransactionalIndexer. Did your latest pull forget to
add new files? Or maybe I'm just missing it? FYI, I remember there are a few
bits of comme
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307979
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java ---
@@ -175,7 +176,9 @@ private void createTable(Connection conn,
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307901
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,6 +115,7 @@ public boolean equals(Object obj) {
if
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307861
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -101,7 +105,7 @@ else if (SchemaUtil.isPKColumn(column)) {
p
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307631
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java ---
@@ -175,7 +176,9 @@ private void createTable(Connection conn, S
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307398
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -410,149 +642,293 @@ private static long
calculateMutationSiz
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307359
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -410,149 +642,293 @@ private static long
calculateMutationSiz
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307321
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -301,28 +476,81 @@ public void remove() {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307287
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java ---
@@ -223,23 +223,25 @@ public final ResultIterator iterator(final
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307260
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java
---
@@ -73,6 +73,7 @@
public static final long MIN_S
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307224
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1249,7 +1255,6 @@ public void createTable(RpcCont
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307183
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -236,13 +239,14 @@ protected RegionScanner ge
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45306913
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -135,230 +154,282 @@ public void tearDown() throw
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45302322
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -135,230 +154,282 @@ public void tearDown() throw
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45290664
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -135,230 +154,282 @@ public void tearDown() throws Ex
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45289517
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -135,230 +154,282 @@ public void tearDown() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45289488
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -135,230 +154,282 @@ public void tearDown() throws
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/129
PHOENIX-1674 Snapshot isolation transaction support through Tephra
@JamesRTaylor @samarthjain
PR will code review feedback.
You can merge this pull request into a Git repository by run
Github user twdsilva closed the pull request at:
https://github.com/apache/phoenix/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/128
PHOENIX-1674 Snapshot isolation transaction support through Tephra
Closed https://github.com/apache/phoenix/pull/127 and created this PR with
code review feedback changes.
You can merge this pull
Github user twdsilva closed the pull request at:
https://github.com/apache/phoenix/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r45142836
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1498,30 +1542,61 @@ private PTable
createTableInternal(CreateTab
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r45111544
--- Diff: pom.xml ---
@@ -98,7 +98,7 @@
1.2
1.0
1.1.8
-12.0.1
+13.0.1
--- End diff --
Yes, it's l
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r45111059
--- Diff: pom.xml ---
@@ -98,7 +98,7 @@
1.2
1.0
1.1.8
-12.0.1
+13.0.1
--- End diff --
Guava 13.0.1 se
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44991806
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ---
@@ -450,7 +463,7 @@ private void closeStatements() throws SQLExcepti
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44861647
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -415,24 +425,47 @@ private long getClientTimeStamp() {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853168
--- Diff: pom.xml ---
@@ -98,7 +98,7 @@
1.2
1.0
1.1.8
-12.0.1
+13.0.1
--- End diff --
Is updating
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853354
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/tx/TransactionIT.java
---
@@ -0,0 +1,478 @@
+/*
--- End diff --
Minor nit: The hea
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853305
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/txn/TxWriteFailureIT.java
---
@@ -0,0 +1,198 @@
+package org.apache.phoenix.end2
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853313
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/transactions/RecreateTableIT.java
---
@@ -0,0 +1,45 @@
+package org.apache.phoenix.transaction
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853416
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/tx/UpdateCacheIT.java
---
@@ -0,0 +1,122 @@
+package org.apache.phoenix.tx;
+
+import s
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853409
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/tx/UpdateCacheIT.java
---
@@ -0,0 +1,122 @@
+package org.apache.phoenix.tx;
--- End diff --
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853408
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/tx/TxPointInTimeQueryIT.java ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software F
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853223
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/StatsCollectorWithSplitsAndMultiCFIT.java
---
@@ -176,7 +176,7 @@ public void testSplitUp
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853283
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/txn/RollbackIT.java
---
@@ -0,0 +1,145 @@
+package org.apache.phoenix.end2end.in
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853201
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/txn/MutableRollbackIT.java
---
@@ -0,0 +1,506 @@
+package org.apache.phoenix.end
1 - 100 of 141 matches
Mail list logo
