[jira] [Commented] (PHOENIX-3263) Allow comma before CONSTRAINT to be optional

2016-09-22 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514561#comment-15514561 ] James Taylor commented on PHOENIX-3263: --- +1. Thanks, [~lomoree]. I committed this on your behalf.

[jira] [Commented] (PHOENIX-3263) Allow comma before CONSTRAINT to be optional

2016-09-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514535#comment-15514535 ] Hadoop QA commented on PHOENIX-3263: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-3263) Allow comma before CONSTRAINT to be optional

2016-09-22 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513709#comment-15513709 ] James Taylor commented on PHOENIX-3263: --- [~lomoree] - would you mind attaching a patch file so we

[jira] [Commented] (PHOENIX-3263) Allow comma before CONSTRAINT to be optional

2016-09-13 Thread Maryann Xue (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488424#comment-15488424 ] Maryann Xue commented on PHOENIX-3263: -- Thanks for you response, [~lomoree]! But you won't be able

[jira] [Commented] (PHOENIX-3263) Allow comma before CONSTRAINT to be optional

2016-09-13 Thread Eric Lomore (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488400#comment-15488400 ] Eric Lomore commented on PHOENIX-3263: -- Thanks! This makes a lot more sense now, still getting used

[jira] [Commented] (PHOENIX-3263) Allow comma before CONSTRAINT to be optional

2016-09-13 Thread Maryann Xue (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487974#comment-15487974 ] Maryann Xue commented on PHOENIX-3263: -- Hey, [~lomoree], in Calcite-Phoenix we are no longer using

[jira] [Commented] (PHOENIX-3263) Allow comma before CONSTRAINT to be optional

2016-09-13 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487914#comment-15487914 ] James Taylor commented on PHOENIX-3263: --- [~lomoree] - I don't completely understand this because

[jira] [Commented] (PHOENIX-3263) Allow comma before CONSTRAINT to be optional

2016-09-13 Thread Eric Lomore (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487831#comment-15487831 ] Eric Lomore commented on PHOENIX-3263: -- At the moment, Phoenix supports both comma and no comma in