[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-11 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/1#discussion_r14834867 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java --- @@ -47,6 +51,21 @@ public MutationPlan compile(final

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-11 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/1#discussion_r14834896 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java --- @@ -282,7 +286,7 @@ public Expression visitLeave

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-11 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/1#discussion_r14834954 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/IndexStatementRewriter.java --- @@ -96,6 +96,12 @@ public ParseNode visit

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-11 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/1#discussion_r14850777 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java --- @@ -366,6 +384,21 @@ private RegionScanner

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-12 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/1#discussion_r14853783 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java --- @@ -100,7 +109,7 @@ public static void serializeIntoScan

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/1#discussion_r14858124 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/SkipRangeParallelIteratorRegionSplitter.java --- @@ -54,7 +55,8 @@ protected

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/1#issuecomment-48839233 bq. Cleanest might be to just implement a simple ParallelIteratorRegionSplitter for use when a local index is used that just returns all regions: I will add new

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread chrajeshbabu
GitHub user chrajeshbabu opened a pull request: https://github.com/apache/phoenix/pull/3 PHOENIX-933 Local index support to Phoenix Updated pull request after resolving conflicts and handling James review comments. You can merge this pull request into a Git repository by running

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-14 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/3#issuecomment-48945719 bq. Just add the check to disable creating local indexes on a table with immutable rows and then let's check this in. Changed pull request to disallow local

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-14 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14897879 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java --- @@ -169,6 +170,7 @@ SQLViewTypeFunction

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-14 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14898287 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java --- @@ -140,7 +142,14 @@ public boolean apply

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-14 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14898383 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java --- @@ -140,7 +142,14 @@ public boolean apply

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-14 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/3#issuecomment-48949296 Resolved the conflicts after PHOENIX-1002 also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/77#issuecomment-96276745 Thanks @JamesRTaylor @samarthjain I have addressed the review comments and added to pull request. If it's ok I will commit this tomorrow morning IST and work

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29103983 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java --- @@ -0,0 +1,217 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29103995 --- Diff: phoenix-core/src/main/antlr3/PhoenixSQL.g --- @@ -114,6 +114,15 @@ tokens ASYNC='async'; SAMPLING='sampling'; UNION

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-24 Thread chrajeshbabu
GitHub user chrajeshbabu opened a pull request: https://github.com/apache/phoenix/pull/77 PHOENIX-538 Support UDFs Patch to support UDFs. It mainly includes - create temporary/permanent function query parsing - storing function info - dynamically loading udf jars

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29098669 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -700,6 +1007,29 @@ private PTable loadTable

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29098659 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/GlobalCache.java --- @@ -157,4 +159,18 @@ public TenantCache getChildTenantCache

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29098664 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/CreateFunctionCompiler.java --- @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29098873 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java --- @@ -0,0 +1,217 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29098680 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java --- @@ -289,24 +289,6 @@ public void testNegativeCountStar() throws

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/77#issuecomment-96145601 Thanks Samarth for reviews. Will update patch addressing the comments. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29098678 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java --- @@ -0,0 +1,217 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29098894 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java --- @@ -0,0 +1,217 @@ +/* + * Licensed

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-25 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/77#discussion_r29098632 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java --- @@ -383,6 +448,85 @@ protected TableRef createTableRef

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-28 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/77#issuecomment-96969719 It's committed. Hence closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] phoenix pull request: PHOENIX-538 Support UDFs

2015-04-28 Thread chrajeshbabu
Github user chrajeshbabu closed the pull request at: https://github.com/apache/phoenix/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2015-04-28 Thread chrajeshbabu
Github user chrajeshbabu closed the pull request at: https://github.com/apache/phoenix/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements

2015-11-29 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/135#discussion_r46096442 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -134,7 +143,36 @@ private static void setValues(byte

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements

2015-11-29 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/135#discussion_r46096395 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinIT.java --- @@ -873,7 +873,7 @@ public void initTable() throws Exception

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements

2015-11-29 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/135#discussion_r46096275 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java --- @@ -186,7 +186,9 @@ private void testDeleteRange(boolean autoCommit

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements

2015-11-29 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/135#discussion_r46096413 --- Diff: phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java --- @@ -80,6 +81,9 @@ public Reader

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements

2015-11-29 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/135#discussion_r46096498 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java --- @@ -158,6 +162,10 @@ public

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements

2015-11-25 Thread chrajeshbabu
GitHub user chrajeshbabu opened a pull request: https://github.com/apache/phoenix/pull/135 PHOENIX-1734 Local index improvements Patch supports storing local indexing data in the same data table. 1) Removed code used HBase internals in balancer, split and merge. 2) Create

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements

2015-11-29 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/135#discussion_r46111214 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java --- @@ -158,6 +162,10 @@ public

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements

2015-11-29 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/135#discussion_r46111265 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -134,7 +143,36 @@ private static void setValues(byte

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-03-29 Thread chrajeshbabu
GitHub user chrajeshbabu opened a pull request: https://github.com/apache/phoenix/pull/156 PHOENIX-2628 Ensure split when iterating through results handled corr… The patch fixes issues with splits and merges while scanning local indexes. You can merge this pull request

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58632305 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java --- @@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58638946 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java --- @@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58638911 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java --- @@ -402,8 +405,8 @@ private RegionScanner

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58639358 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -107,8 +127,37 @@ public synchronized void close

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58640276 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -121,8 +170,21 @@ public synchronized void initScanner

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58640818 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java --- @@ -556,35 +564,55 @@ private static String toString(List

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58641031 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java --- @@ -326,11 +325,12 @@ private static void

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58640990 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java --- @@ -465,7 +465,14 @@ private static String toString(List

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58641009 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java --- @@ -465,7 +465,14 @@ private static String toString(List

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58637933 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -107,8 +127,37 @@ public synchronized void close

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58639845 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -80,13 +94,19

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58639989 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -107,8 +127,37 @@ public synchronized void close

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58640455 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java --- @@ -556,35 +564,55 @@ private static String toString(List

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58638568 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java --- @@ -423,7 +426,14 @@ private RegionScanner

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58639974 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -107,8 +127,37 @@ public synchronized void close

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58639956 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -107,8 +127,37 @@ public synchronized void close

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58642188 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java --- @@ -107,8 +127,37 @@ public synchronized void close

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-05 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58642550 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java --- @@ -556,35 +564,55 @@ private static String toString(List

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-08 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/156#issuecomment-207582047 @JamesRTaylor Thanks for the review. Committed the changes handling the review comments. Refactored the code and added code comments where ever possible

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-08 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r59077866 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java --- @@ -402,8 +405,8 @@ private RegionScanner

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-08 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r59078097 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ChunkedResultIterator.java --- @@ -56,6 +57,7 @@ private final MutationState

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-08 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r59077569 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java --- @@ -337,6 +384,22 @@ public boolean nextRaw

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-04 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58485551 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java --- @@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-04 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r58485360 --- Diff: phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java --- @@ -157,6 +162,7 @@ public Reader

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-20 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/168#discussion_r64123637 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2455,6 +2409,19 @@ public Void call() throws

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-20 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/168#discussion_r64123714 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java --- @@ -187,13 +186,13 @@ public void initTable() throws Exception

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-16 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/168#discussion_r63463302 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java --- @@ -187,13 +186,13 @@ public void initTable() throws Exception

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-16 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/168#discussion_r63463482 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -861,7 +871,12 @@ public Put buildUpdateMutation

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-16 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/168#discussion_r63463618 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java --- @@ -116,7 +117,10 @@ public void write

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-16 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/168#discussion_r63463623 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java --- @@ -160,6 +163,9 @@ public void preBatchMutate

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-16 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/168#discussion_r63463584 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -1016,7 +1016,7 @@ private MutationState

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-16 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/168#discussion_r63463350 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java --- @@ -202,7 +207,10 @@ protected

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-16 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/168#discussion_r63463462 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTable.java --- @@ -297,4 +297,28 @@ public boolean checkAndDelete(byte[] row

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-16 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/168#issuecomment-219617896 James as we discussed I have made a patch working with older versions of HBase first and handled review comments here. Will create new pull request

[GitHub] phoenix pull request: PHOENIX-1734 Local index improvements(Rajesh...

2016-05-10 Thread chrajeshbabu
GitHub user chrajeshbabu opened a pull request: https://github.com/apache/phoenix/pull/168 PHOENIX-1734 Local index improvements(Rajeshbabu) This is the patch for new implementation of local index where we store local index data in the separate column families in the same table

[GitHub] phoenix issue #202: PHOENIX-3193 Tracing UI cleanup

2016-09-08 Thread chrajeshbabu
Github user chrajeshbabu commented on the issue: https://github.com/apache/phoenix/pull/202 @AyolaJayamaha we want these improvements and cleanup to be in 4.8.1 version. Any other things pending here? Is it ready for commit? --- If your project is set up for it, you can reply

[GitHub] phoenix issue #193: Improvements to Phoenix Web App

2016-08-26 Thread chrajeshbabu
Github user chrajeshbabu commented on the issue: https://github.com/apache/phoenix/pull/193 @AyolaJayamaha Currently we are trying to get the webapp related files form target directory in org.apache.phoenix.tracingwebapp.http.Main. Because of this we cannot use the runnable jar

[GitHub] phoenix issue #202: PHOENIX-3193 Tracing UI cleanup

2016-08-29 Thread chrajeshbabu
Github user chrajeshbabu commented on the issue: https://github.com/apache/phoenix/pull/202 Here are couple of issues found one while starting traceserver and one while getting the results in UI. Currently the eclipse jetty version used is 8.1.7.v20120910 From main pom.xml

[GitHub] phoenix pull request #211: PHOENIX-3254 IndexId Sequence is incremented even...

2016-09-28 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/211#discussion_r80916280 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1499,6 +1502,53 @@ public void createTable

[GitHub] phoenix pull request #211: PHOENIX-3254 IndexId Sequence is incremented even...

2016-09-28 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/211#discussion_r80925250 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -1445,6 +1445,9 @@ public MetaDataResponse call

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83827883 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java --- @@ -167,50 +180,152 @@ private void printHelpAndExit(Options

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83795678 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java --- @@ -568,4 +580,52 @@ public void testAsyncCreatedDate

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83827393 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java --- @@ -167,50 +180,152 @@ private void printHelpAndExit(Options

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83824633 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java --- @@ -85,7 +102,7 @@ private static final Option

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83832270 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -305,16 +305,27 @@ TENANT_ID

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83792475 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForPartialBuildIT.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83792778 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForPartialBuildIT.java --- @@ -0,0 +1,264 @@ +/* + * Licensed

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83793514 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForPartialBuildWithNamespaceEnabled.java --- @@ -0,0 +1,71

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83793592 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/OrderByIT.java --- @@ -500,14 +500,12 @@ public void testOrderByWithExpression() throws

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83795010 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java --- @@ -216,6 +219,15 @@ public void testIndexCreateDrop

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-10-18 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r83795282 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java --- @@ -568,4 +580,52 @@ public void testAsyncCreatedDate

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-11-30 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r90192895 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForPartialBuildIT.java --- @@ -217,39 +223,47 @@ public void testSecondaryIndex

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-11-30 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r90188400 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -305,16 +305,27 @@ TENANT_ID

[GitHub] phoenix pull request #210: PHOENIX-2890 Extend IndexTool to allow incrementa...

2016-11-30 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r90192647 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java --- @@ -167,50 +180,152 @@ private void printHelpAndExit(Options

[GitHub] phoenix issue #238: PHOENIX-3690 Support declaring default values in Phoenix...

2017-04-02 Thread chrajeshbabu
Github user chrajeshbabu commented on the issue: https://github.com/apache/phoenix/pull/238 +1 Kevin. Thanks for the update. Will commit it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have