a PR from you : )
>
>
>
> *Von: *Adam Rossi
> *Datum: *Dienstag, 25. August 2020 um 15:45
> *An: *Julian Feinauer
> *Cc: *"dev@plc4x.apache.org"
> *Betreff: *Re: Leaking nioEventLoopGroup threads
>
>
>
> Juilan,
>
>
>
> My apologies - you
Also thanks to you, Stefano, indeed for the nice community work you do!
Julian
Von: Stefano Bossi
Datum: Dienstag, 25. August 2020 um 20:20
An: , Adam Rossi , Julian Feinauer
Betreff: Re: Leaking nioEventLoopGroup threads
Yupiii !!!
good news !!!
Regards,
S.
On 25/08/2020 15:45, Adam
Yupiii !!!
good news !!!
Regards,
S.
On 25/08/2020 15:45, Adam Rossi wrote:
> Juilan,
>
> My apologies - your fix did indeed work. The issue is that
> PooledPlcDriverManager does not seem to be calling the close method on the
> connection. Switching back to PlcDriverManager from PooledPlcDriver
you already digged into the code you can try to fix it yourself of
course, I would be more than happy to get a PR from you : )
Von: Adam Rossi
Datum: Dienstag, 25. August 2020 um 15:45
An: Julian Feinauer
Cc: "dev@plc4x.apache.org"
Betreff: Re: Leaking nioEventLoopGroup threads
J
Juilan,
My apologies - your fix did indeed work. The issue is that
PooledPlcDriverManager does not seem to be calling the close method on the
connection. Switching back to PlcDriverManager from PooledPlcDriverManager
results in your new log comments showing up in the log, and more
importantly no m
Thanks Stefano. I just created an issue in Jira. Regards, Adam
On Tue, Aug 25, 2020 at 6:51 AM Stefano Bossi
wrote:
> Hi Adam,
>
> it's much better to not forget your problem if you open a new ticket on
> Jira.
>
> here is the link: https://issues.apache.org/jira/projects/PLC4X/summary
>
> You s
Hi Adam,
it's much better to not forget your problem if you open a new ticket on
Jira.
here is the link: https://issues.apache.org/jira/projects/PLC4X/summary
You should open an account a copy your mail in there.
Just a suggestion to keep the things in order.
Thanks,
S.
On 24/08/2020 17:26,
Julian, thank you so much for your attention on this. Your code changes
look good but unfortunately I am still experiencing the problem.
Here is some log output from my program. You can see that the close is
called on the DefaultNettyPlcConnection, but I do not see the output from
your code modifi
Yes thanks !
This will be very important for my stability test too!
Let's see if Adam confirm the patch !
Thanks,
Stefano
On 24/08/2020 11:35, Christofer Dutz wrote:
> Thanks Julian for that quick fix.
>
> Chris
>
>
> Am 24.08.20, 10:39 schrieb "Julian Feinauer" :
>
> Hi,
>
> short f
Thanks Julian for that quick fix.
Chris
Am 24.08.20, 10:39 schrieb "Julian Feinauer" :
Hi,
short feedback. I looked into the code and indeed it seems that we had a
bug there which could lead tot he socket leak you described.
I pushed a fix in the branch:
https://github.com/
Hi,
short feedback. I looked into the code and indeed it seems that we had a bug
there which could lead tot he socket leak you described.
I pushed a fix in the branch:
https://github.com/apache/plc4x/tree/bugfix/close-eventloop-after-channel
Would you mind taking a look and testing this with y
Perhaps, some related questions:
- You are using Linux for your Tests?
- Do you close all Connections properly?
Normally the `PlcConnection.close()` method should close the EventLoop.
Julian
Am 24.08.20, 08:23 schrieb "Julian Feinauer" :
Hi Adam,
I will have a look today!
Do we h
Hi Adam,
I will have a look today!
Do we have a Jira Issue for it already?
Julian
Am 24.08.20, 07:38 schrieb "Christofer Dutz" :
Hi Adam,
of course that's unfortunate ... also I will not be able to address this
issue soon as I have to work on the tasks of my research project.
I
Hi Adam,
of course that's unfortunate ... also I will not be able to address this issue
soon as I have to work on the tasks of my research project.
I have one more month to work on this and I'm months behind schedule because I
have been doing free support way too much lately.
I really hope Juli
Thanks, I did test with 0.8.0-SNAPSHOT and see the same behavior. In every
plcConnection a nioEventLoopGroup thread is created and does not ever seem
to be destroyed.
I wish I understood the io.netty.channel.EventLoopGroup class better to be
more helpful here. Would an example program that reprodu
Hi Adam,
the Apache SNAPSHOT repo is at:
https://repository.apache.org/content/repositories/snapshots
Adding this to your pom should help:
apache-snapshots
https://repository.apache.org/content/repositories/snapshots
false
true
Sure thing. Is 0.8.0-snapshot hosted anywhere or is that something that needs
to be built? Regards Adam
> On Aug 23, 2020, at 12:31 PM, Christofer Dutz
> wrote:
>
> Hmm ...
>
> Could you possibly give 0.8.0-SNAPSHOT a try? or 0.6.x? ... 0.7.0 was
> the first of the new generation driv
Hmm ...
Could you possibly give 0.8.0-SNAPSHOT a try? or 0.6.x? ... 0.7.0 was the
first of the new generation drivers. We're maintaining the 0.6 branch and
working hard on making the new generation drivers 100% production ready.
Chris
Am 23.08.20, 18:06 schrieb "Adam Rossi" :
This
This is the latest 0.7.0 release from Maven.
Regards Adam
> On Aug 23, 2020, at 11:56 AM, Christofer Dutz
> wrote:
>
> Hi Adam,
>
> which version of PLC4X are you using? I know we had similar reports some time
> ago, but had thought we had fixed them
>
> Chris
>
>
>
> Am 23.08.20, 16
Hi Adam,
which version of PLC4X are you using? I know we had similar reports some time
ago, but had thought we had fixed them
Chris
Am 23.08.20, 16:40 schrieb "Adam Rossi" :
Howdy. I am seeing a persistent thread being created for every
plcConnection connect which looks like the fol
Howdy. I am seeing a persistent thread being created for every
plcConnection connect which looks like the following:
Name: nioEventLoopGroup-11-1
State: RUNNABLE
Total blocked: 0 Total waited: 0
Stack trace:
java.base@13.0.2/sun.nio.ch.EPoll.wait(Native Method)
java.base@13.0.2
/sun.nio.ch.EPoll
21 matches
Mail list logo
