[GitHub] merlimat commented on a change in pull request #666: Added documentation on how to start the standalone service with Docker

2017-08-10 Thread git
merlimat commented on a change in pull request #666: Added documentation on how to start the standalone service with Docker URL: https://github.com/apache/incubator-pulsar/pull/666#discussion_r132488932 ## File path: site/docs/latest/getting-started/docker.md ## @@ -0,0

[GitHub] maskit commented on issue #672: Support setting private key content in athenz client plugin

2017-08-10 Thread git
maskit commented on issue #672: Support setting private key content in athenz client plugin URL: https://github.com/apache/incubator-pulsar/pull/672#issuecomment-321582633 I don't know much about athenz but why is this needed? What would be the benefits? If we provide multiple ways

[GitHub] maskit commented on issue #638: Dead link on Getting started

2017-08-10 Thread git
maskit commented on issue #638: Dead link on Getting started URL: https://github.com/apache/incubator-pulsar/issues/638#issuecomment-321588197 Fix confirmed, thanks. This is an automated message from the Apache Git Service.

[GitHub] rdhabalia commented on a change in pull request #666: Added documentation on how to start the standalone service with Docker

2017-08-10 Thread git
rdhabalia commented on a change in pull request #666: Added documentation on how to start the standalone service with Docker URL: https://github.com/apache/incubator-pulsar/pull/666#discussion_r132374595 ## File path: site/docs/latest/getting-started/docker.md ## @@ -0,0

[GitHub] merlimat closed pull request #668: Fix Python package version

2017-08-10 Thread git
merlimat closed pull request #668: Fix Python package version URL: https://github.com/apache/incubator-pulsar/pull/668 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] merlimat commented on issue #666: Added documentation on how to start the standalone service with Docker

2017-08-10 Thread git
merlimat commented on issue #666: Added documentation on how to start the standalone service with Docker URL: https://github.com/apache/incubator-pulsar/pull/666#issuecomment-321615429 retest this please This is an

[GitHub] rdhabalia commented on issue #634: PIP-3 : Introduce message-dispatch rate limiting

2017-08-10 Thread git
rdhabalia commented on issue #634: PIP-3 : Introduce message-dispatch rate limiting URL: https://github.com/apache/incubator-pulsar/pull/634#issuecomment-321617192 @merlimat I addressed all the comments. This is an

[GitHub] merlimat opened a new issue #674: Assertion failure in RocksDB when opening the index db

2017-08-10 Thread git
merlimat opened a new issue #674: Assertion failure in RocksDB when opening the index db URL: https://github.com/apache/incubator-pulsar/issues/674 In some cases, the bookie from the standalone pulsar service is crashing on startup. ``` 2017-08-10 13:03:51,646 - INFO -

[GitHub] merlimat commented on issue #674: Assertion failure in RocksDB when opening the index db

2017-08-10 Thread git
merlimat commented on issue #674: Assertion failure in RocksDB when opening the index db URL: https://github.com/apache/incubator-pulsar/issues/674#issuecomment-321675966 Created facebook/rocksdb#2717 This is an automated

Re: Committer info in commits

2017-08-10 Thread Matteo Merli
Hi Masakazu, > Look at the second commit. The commit is made by GitHub < nore...@github.com> I think that this happens when the author of the commit is pushing the "merge" button on its own commit (after having received +1s from other committers).. In this case: > commit

[GitHub] merlimat opened a new issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic

2017-08-10 Thread git
merlimat opened a new issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic URL: https://github.com/apache/incubator-pulsar/issues/635 As seen in

Re: Rebase and merge

2017-08-10 Thread Matteo Merli
I am ok in having rebased pull-requests and to allow the "Rebase & Merge" option in github. That can be helpful in cases in which there are multiple logical (though related) commits for which you want to keep separation. For most cases (eg: PRs comments and incremental fixes on the PR) I think the

[DISCUSS] Planning for next release 1.20.0-incubating

2017-08-10 Thread Matteo Merli
Since the first release is out, I'd like to get started on the discussion for the next one :) I propose to try to keep a monthly cadence for releases so that we can quickly iterate over new feature and bug fixes, and avoid having to create to many patch releases in between, which can be time

[PROPOSAL] Move github notifications to a separate mailing list

2017-08-10 Thread Matteo Merli
As you have surely noticed already, all the github notifications are being sent to this mailing list (dev@pulsar.incubator.apache.org). This results in a big amount of mails sent to the list (one for each comment made on issues or PRs and also when commits are pushed to the PRs). I would propose

Re: [PROPOSAL] Move github notifications to a separate mailing list

2017-08-10 Thread Dave Fisher
Commits@ exists. Let's use that. If another name like notifications@ is preferred then ask Infra to change the name. Either way make sure it is set to reply-to dev@. Regards, Dave Sent from my iPhone > On Aug 10, 2017, at 3:35 PM, Matteo Merli wrote: > > As you have

[GitHub] msb-at-yahoo commented on issue #672: Support setting private key content in athenz client plugin

2017-08-10 Thread git
msb-at-yahoo commented on issue #672: Support setting private key content in athenz client plugin URL: https://github.com/apache/incubator-pulsar/pull/672#issuecomment-321704775 what about getting rid of the privateKeyPath field, and during init load the content of the file if

[GitHub] hrsakai commented on issue #672: Support setting private key content in athenz client plugin

2017-08-10 Thread git
hrsakai commented on issue #672: Support setting private key content in athenz client plugin URL: https://github.com/apache/incubator-pulsar/pull/672#issuecomment-321609624 In case of PCF, we should not deploy private key as a file in terms of security and auto scale, we should set

[GitHub] merlimat commented on a change in pull request #666: Added documentation on how to start the standalone service with Docker

2017-08-10 Thread git
merlimat commented on a change in pull request #666: Added documentation on how to start the standalone service with Docker URL: https://github.com/apache/incubator-pulsar/pull/666#discussion_r132488932 ## File path: site/docs/latest/getting-started/docker.md ## @@ -0,0

[GitHub] merlimat closed pull request #670: Don't run Javadoc and Swagger builds on regular mvn package

2017-08-10 Thread git
merlimat closed pull request #670: Don't run Javadoc and Swagger builds on regular mvn package URL: https://github.com/apache/incubator-pulsar/pull/670 This is an automated message from the Apache Git Service. To respond

[GitHub] maskit commented on issue #671: Should authParamsString for Authentication support another format ?

2017-08-10 Thread git
maskit commented on issue #671: Should authParamsString for Authentication support another format ? URL: https://github.com/apache/incubator-pulsar/issues/671#issuecomment-321577504 I think the entire parameter value should be parsed on plugins side. Then plugins can choose any format

[GitHub] merlimat closed pull request #676: remove topicName-dataProvider from testIncrementPartitionsOfTopic test

2017-08-10 Thread git
merlimat closed pull request #676: remove topicName-dataProvider from testIncrementPartitionsOfTopic test URL: https://github.com/apache/incubator-pulsar/pull/676 This is an automated message from the Apache Git Service.

[GitHub] rdhabalia commented on issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic

2017-08-10 Thread git
rdhabalia commented on issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic URL: https://github.com/apache/incubator-pulsar/issues/635#issuecomment-321716697 Actually, even in last build, test is not failed due to assertion error but it failed with

[GitHub] merlimat opened a new pull request #675: Interrupt the Python consumer when receiving SIGINT

2017-08-10 Thread git
merlimat opened a new pull request #675: Interrupt the Python consumer when receiving SIGINT URL: https://github.com/apache/incubator-pulsar/pull/675 ### Motivation When a Python consumer is blocked on a `consumer.receive()` call, it will ignore the SIGINT from a `Ctrl-C`

[GitHub] merlimat closed pull request #666: Added documentation on how to start the standalone service with Docker

2017-08-10 Thread git
merlimat closed pull request #666: Added documentation on how to start the standalone service with Docker URL: https://github.com/apache/incubator-pulsar/pull/666 This is an automated message from the Apache Git Service.

[GitHub] merlimat commented on issue #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ?

2017-08-10 Thread git
merlimat commented on issue #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ? URL: https://github.com/apache/incubator-pulsar/pull/673#issuecomment-321709106 ping @jai1 This is an automated

[GitHub] merlimat commented on issue #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ?

2017-08-10 Thread git
merlimat commented on issue #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ? URL: https://github.com/apache/incubator-pulsar/pull/673#issuecomment-321709114 retest this please This is an

Re: [DISCUSS] Planning for next release 1.20.0-incubating

2017-08-10 Thread Joe F
I can fill in for one release Joe On Aug 10, 2017 3:14 PM, "Matteo Merli" wrote: > Since the first release is out, I'd like to get started on the discussion > for the next one :) > > I propose to try to keep a monthly cadence for releases so that we can > quickly iterate

[GitHub] merlimat commented on issue #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ?

2017-08-10 Thread git
merlimat commented on issue #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ? URL: https://github.com/apache/incubator-pulsar/pull/673#issuecomment-321709114 retest this please This is an

[GitHub] maskit commented on issue #672: Support setting private key content in athenz client plugin

2017-08-10 Thread git
maskit commented on issue #672: Support setting private key content in athenz client plugin URL: https://github.com/apache/incubator-pulsar/pull/672#issuecomment-321729113 OK, that makes sense. Since it's just a plugin I don't object introducing its own unique way, however, it sounds like

[GitHub] merlimat commented on issue #672: Support setting private key content in athenz client plugin

2017-08-10 Thread git
merlimat commented on issue #672: Support setting private key content in athenz client plugin URL: https://github.com/apache/incubator-pulsar/pull/672#issuecomment-321729674 > How about adding support for URL schemes (e.g. file:, data:, env:, exec:) to privateKeyPath config param? If we

[GitHub] merlimat commented on issue #672: Support setting private key content in athenz client plugin

2017-08-10 Thread git
merlimat commented on issue #672: Support setting private key content in athenz client plugin URL: https://github.com/apache/incubator-pulsar/pull/672#issuecomment-321729674 > How about adding support for URL schemes (e.g. file:, data:, env:, exec:) to privateKeyPath config param? If we

Re: Committer info in commits

2017-08-10 Thread Masakazu Kitajo
On Fri, Aug 11, 2017 at 6:38 AM, Matteo Merli wrote: > Hi Masakazu, > > > Look at the second commit. The commit is made by GitHub < > nore...@github.com> > > I think that this happens when the author of the commit is pushing the > "merge" button on its own commit (after

Re: Committer info in commits

2017-08-10 Thread Dave Fisher
Seems to me you could do an experiment and see. If it is not to the podling's liking then ask Infra to fix. Regards, Dave Sent from my iPhone > On Aug 10, 2017, at 9:48 PM, Masakazu Kitajo wrote: > >> On Fri, Aug 11, 2017 at 6:38 AM, Matteo Merli wrote: