[jira] [Commented] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker

2013-04-01 Thread JAkub Scholz (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618691#comment-13618691 ] JAkub Scholz commented on QPID-4676: Hi Robbie, I tested your commit and it seems to

Requested inclusions for 0.22

2013-04-01 Thread Gordon Sim
I'd like to merge the following fixes from trunk to the 0.22 release branch. They are all entirely confined to the 1.0 codepaths and are relatively well contained within that and of low risk[1]. QPID-4674: Detect asynchronous connection close, session end and link detach,

[jira] [Commented] (QPID-4683) [Java Broker] QPID-4657 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618721#comment-13618721 ] Robbie Gemmell commented on QPID-4683: -- Some remaining change that can be done in this

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-04-01 Thread Gordon Sim
On March 27, 2013, 2:56 p.m., Gordon Sim wrote: trunk/qpid/cpp/src/qpid/broker/Broker.h, line 167 https://reviews.apache.org/r/10020/diff/3/?file=274538#file274538line167 I wonder if we could come up with a nicer name... Chug Rolke wrote: How does 'redirect' sound? much

[jira] [Resolved] (QPID-4462) SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN

2013-04-01 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved QPID-4462. --- Resolution: Fixed Looks good to me. At some point we need to properly figure out to what extent we

[jira] [Resolved] (QPID-4681) [Java Broker] QPID-4390 review changes

2013-04-01 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved QPID-4681. --- Resolution: Fixed Change is obviously trivial, but getting it in for 0.22 will avoid causing pain

[jira] [Commented] (QPID-4661) [Java Broker] Add UI into web management console to edit broker attributes

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618762#comment-13618762 ] Justin Ross commented on QPID-4661: --- Reviewed by Robbie. Approved for 0.22.

Re: Request for inclusion into the 0.22 branch

2013-04-01 Thread Robbie Gemmell
FWIW, while I'd like to see the additional testing done first I'd much rather the second change went into RC1 without the test changes than leave it the way it is on the 0.22 branch just now following the original change. Robbie On 27 Mar 2013 21:31, Justin Ross justin.r...@gmail.com wrote: Hi,

[jira] [Commented] (QPID-4682) [Java Broker] QPID-4594 review changes

2013-04-01 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618764#comment-13618764 ] Rob Godfrey commented on QPID-4682: --- General question: I see no changes to documentation

[jira] [Commented] (QPID-4677) [Java Broker] fix incorrect attribute names, group inheritable defaults and add missing ones

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618765#comment-13618765 ] Justin Ross commented on QPID-4677: --- Reviewed by Robbie. Approved for 0.22.

[jira] [Commented] (QPID-4678) [Java Broker] add ACL to restrict new support for broker-level configuration through the management interface

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618767#comment-13618767 ] Justin Ross commented on QPID-4678: --- Reviewed by Robbie. Approved for 0.22.

[jira] [Commented] (QPID-4462) SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618768#comment-13618768 ] Justin Ross commented on QPID-4462: --- Reviewed by Rob. Approved for 0.22.

[jira] [Commented] (QPID-4681) [Java Broker] QPID-4390 review changes

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618769#comment-13618769 ] Justin Ross commented on QPID-4681: --- Reviewed by Rob. Approved for 0.22.

[jira] [Commented] (QPID-4682) [Java Broker] QPID-4594 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618770#comment-13618770 ] Robbie Gemmell commented on QPID-4682: -- On the docs side, basically as there weren't

[jira] [Commented] (QPID-4683) [Java Broker] QPID-4657 review changes

2013-04-01 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618771#comment-13618771 ] Rob Godfrey commented on QPID-4683: --- Looks good... a couple of trivial typos/spelling

Re: Requests for inclusion in 0.22

2013-04-01 Thread Justin Ross
All approved, including 4462 and 4681 from the preview list. Going by the jira comments, 4682 and 4683 are not quite settled yet. Thanks, Justin On Sun, Mar 31, 2013 at 6:40 PM, Robbie Gemmell robbie.gemm...@gmail.com wrote: Hi Justin, I would like to request the following for inclusion in

[jira] [Commented] (QPID-4674) [AMQP 1.0] receiver not notified when link is detached by peer

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618773#comment-13618773 ] Justin Ross commented on QPID-4674: ---

[jira] [Resolved] (QPID-4682) [Java Broker] QPID-4594 review changes

2013-04-01 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved QPID-4682. --- Resolution: Fixed OK - happy for this to go into 0.22. We should have a blocker JIRA for the Java

[jira] [Commented] (QPID-4675) [AMQP 1.0] handle receiving link from direct exchange even with no filter specified

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618777#comment-13618777 ] Justin Ross commented on QPID-4675: --- Approved for 0.22. [AMQP 1.0]

[jira] [Commented] (QPID-4675) [AMQP 1.0] handle receiving link from direct exchange even with no filter specified

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618778#comment-13618778 ] Justin Ross commented on QPID-4675: ---

Re: Requests for inclusion in 0.22

2013-04-01 Thread Robbie Gemmell
Thanks Justin, The ones that have comments from Rob I have either responded to or will simply address the trivial changes for. He said himself on both JIRAs now he was happy to have them merged as is, so can we loop back over these now rather than later? Thanks, Robbie All approved, including

[jira] [Created] (QPID-4684) Remove obsolete options from example qpidd.conf file.

2013-04-01 Thread Alan Conway (JIRA)
Alan Conway created QPID-4684: - Summary: Remove obsolete options from example qpidd.conf file. Key: QPID-4684 URL: https://issues.apache.org/jira/browse/QPID-4684 Project: Qpid Issue Type: Bug

[jira] [Created] (QPID-4685) [Java Broker] update documentation to reflect changes to configuration etc

2013-04-01 Thread Robbie Gemmell (JIRA)
Robbie Gemmell created QPID-4685: Summary: [Java Broker] update documentation to reflect changes to configuration etc Key: QPID-4685 URL: https://issues.apache.org/jira/browse/QPID-4685 Project: Qpid

[jira] [Commented] (QPID-4669) require proton 0.3 or greater

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618783#comment-13618783 ] Justin Ross commented on QPID-4669: --- http://svn.apache.org/r1462214 Approved for 0.22.

[jira] [Created] (QPID-4686) Mention ldconfig in cpp/INSTALL instructions

2013-04-01 Thread Alan Conway (JIRA)
Alan Conway created QPID-4686: - Summary: Mention ldconfig in cpp/INSTALL instructions Key: QPID-4686 URL: https://issues.apache.org/jira/browse/QPID-4686 Project: Qpid Issue Type: Bug

[jira] [Commented] (QPID-4683) [Java Broker] QPID-4657 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618795#comment-13618795 ] Robbie Gemmell commented on QPID-4683: -- Review changes made:

[jira] [Commented] (QPID-4682) [Java Broker] QPID-4594 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618796#comment-13618796 ] Robbie Gemmell commented on QPID-4682: -- Review change made:

[jira] [Resolved] (QPID-4683) [Java Broker] QPID-4657 review changes

2013-04-01 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved QPID-4683. --- Resolution: Fixed Looks good - we should get this merged on to 0.22 [Java Broker]

Re: Requests for inclusion in 0.22

2013-04-01 Thread Robbie Gemmell
Fixes now on trunk for both, and Rob has marked both JIRAs resolved. Robbie On 1 April 2013 14:42, Robbie Gemmell robbie.gemm...@gmail.com wrote: Thanks Justin, The ones that have comments from Rob I have either responded to or will simply address the trivial changes for. He said himself

Request for inclusion in 0.22 - trivial changes.

2013-04-01 Thread Alan Conway
r1463146 | QPID-4686: Mention ldconfig in cpp/INSTALL instructions r1463145 | QPID-4684: Remove obsolete options from example qpidd.conf file. - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands,

[jira] [Commented] (QPID-4640) Deprecate autoconf/automake build system.

2013-04-01 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618799#comment-13618799 ] Alan Conway commented on QPID-4640: --- Minor fixes: r1463146 | QPID-4686: Mention ldconfig

[jira] [Comment Edited] (QPID-4683) [Java Broker] QPID-4657 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618795#comment-13618795 ] Robbie Gemmell edited comment on QPID-4683 at 4/1/13 2:35 PM: --

[jira] [Commented] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618811#comment-13618811 ] Robbie Gemmell commented on QPID-4676: -- Thanks Jakub. I am going to request this for

[jira] [Updated] (QPID-4680) [Java Broker] Persistent NoAck messages leave rows in queue entry table even after dequeue (0-9/0-9/0-9-1 codepath)

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4680: - Fix Version/s: 0.23 Change looks good to me. As discussed I am going to request this for 0.22.

[jira] [Commented] (QPID-3769) NPE in client AMQDestination.equals()

2013-04-01 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618814#comment-13618814 ] Rajith Attapattu commented on QPID-3769: Adjusted the hashcode and equals impl for

[jira] [Commented] (QPID-4682) [Java Broker] QPID-4594 review changes

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618817#comment-13618817 ] Justin Ross commented on QPID-4682: --- Reviewed by Rob. Approved for 0.22.

[jira] [Commented] (QPID-3769) NPE in client AMQDestination.equals()

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618822#comment-13618822 ] Justin Ross commented on QPID-3769: --- Reviewed by Robbie. Approved for 0.22.

[jira] [Commented] (QPID-4684) Remove obsolete options from example qpidd.conf file.

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618825#comment-13618825 ] Justin Ross commented on QPID-4684: ---

[jira] [Commented] (QPID-4661) [Java Broker] Add UI into web management console to edit broker attributes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618828#comment-13618828 ] Robbie Gemmell commented on QPID-4661: -- r1462470 was merged to the 0.22 branch via

[jira] [Comment Edited] (QPID-4677) [Java Broker] fix incorrect attribute names, group inheritable defaults and add missing ones

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618484#comment-13618484 ] Robbie Gemmell edited comment on QPID-4677 at 4/1/13 3:33 PM: --

[jira] [Commented] (QPID-4674) [AMQP 1.0] receiver not notified when link is detached by peer

2013-04-01 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618835#comment-13618835 ] Alan Conway commented on QPID-4674: --- Looks ok to me. [AMQP 1.0]

[jira] [Commented] (QPID-4679) [AMQP 1.0] many aspects of address are silently ignored

2013-04-01 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618847#comment-13618847 ] Alan Conway commented on QPID-4679: --- Looks ok for 0.22 [AMQP 1.0] many

[jira] [Resolved] (QPID-4678) [Java Broker] add ACL to restrict new support for broker-level configuration through the management interface

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-4678. -- Resolution: Fixed [Java Broker] add ACL to restrict new support for broker-level

[jira] [Commented] (QPID-4679) [AMQP 1.0] many aspects of address are silently ignored

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618855#comment-13618855 ] Justin Ross commented on QPID-4679: --- Reviewed by Alan. Approved for 0.22.

[jira] [Commented] (QPID-4680) [Java Broker] Persistent NoAck messages leave rows in queue entry table even after dequeue (0-9/0-9/0-9-1 codepath)

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618858#comment-13618858 ] Justin Ross commented on QPID-4680: --- Reviewed by Robbie. Approved for 0.22.

[jira] [Commented] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618859#comment-13618859 ] Justin Ross commented on QPID-4676: --- Reviewed by Robbie. Approved for 0.22.

[jira] [Commented] (QPID-4680) [Java Broker] Persistent NoAck messages leave rows in queue entry table even after dequeue (0-9/0-9/0-9-1 codepath)

2013-04-01 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618866#comment-13618866 ] Rob Godfrey commented on QPID-4680: --- Merged to 0.22 as r1463179. [Java

[jira] [Updated] (QPID-4681) [Java Broker] QPID-4390 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4681: - Fix Version/s: (was: 0.23) 0.22 [Java Broker] QPID-4390 review

[jira] [Resolved] (QPID-4674) [AMQP 1.0] receiver not notified when link is detached by peer

2013-04-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-4674. -- Resolution: Fixed Fix Version/s: 0.22 Fixed on trunk by http://svn.apache.org/r1462138; merged

[jira] [Resolved] (QPID-4675) [AMQP 1.0] handle receiving link from direct exchange even with no filter specified

2013-04-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-4675. -- Resolution: Fixed Fix Version/s: 0.22 Fixed on trunk by

[jira] [Commented] (QPID-4462) SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618874#comment-13618874 ] Robbie Gemmell commented on QPID-4462: -- r1463063 was merged via

[jira] [Updated] (QPID-4462) [Java Broker] SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4462: - Summary: [Java Broker] SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN

[jira] [Updated] (QPID-4462) [Java Broker] SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4462: - Fix Version/s: (was: 0.23) 0.22 [Java Broker]

[jira] [Resolved] (QPID-4669) require proton 0.3 or greater

2013-04-01 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-4669. -- Resolution: Fixed Fix Version/s: 0.22 Fixed on trunk by http://svn.apache.org/r1462214, merged

[jira] [Updated] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4676: - Fix Version/s: (was: 0.23) 0.22 [Java Broker] SSL Client

[jira] [Commented] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618887#comment-13618887 ] Robbie Gemmell commented on QPID-4676: -- r1463074 was merged via

[jira] [Updated] (QPID-4682) [Java Broker] QPID-4594 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4682: - Fix Version/s: (was: 0.23) 0.22 [Java Broker] QPID-4594 review

[jira] [Commented] (QPID-4683) [Java Broker] QPID-4657 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618896#comment-13618896 ] Robbie Gemmell commented on QPID-4683: -- r1463060 was merged at

[jira] [Updated] (QPID-4683) [Java Broker] QPID-4657 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4683: - Fix Version/s: (was: 0.23) 0.22 [Java Broker] QPID-4657 review

[jira] [Created] (QPID-4687) Add uninstall make target to cmake build

2013-04-01 Thread Alan Conway (JIRA)
Alan Conway created QPID-4687: - Summary: Add uninstall make target to cmake build Key: QPID-4687 URL: https://issues.apache.org/jira/browse/QPID-4687 Project: Qpid Issue Type: Bug

[jira] [Commented] (QPID-4683) [Java Broker] QPID-4657 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618901#comment-13618901 ] Robbie Gemmell commented on QPID-4683: -- Removing the 0.22 fix-for to de-clutter the

[jira] [Commented] (QPID-4594) [Java Broker] Add command line option to start broker in a management mode and options to set JMX and HTTP ports in management mode

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618905#comment-13618905 ] Robbie Gemmell commented on QPID-4594: -- Review was conducted on QPID-4682

[jira] [Resolved] (QPID-4594) [Java Broker] Add command line option to start broker in a management mode and options to set JMX and HTTP ports in management mode

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-4594. -- Resolution: Fixed Fix Version/s: (was: 0.21) 0.22 [Java

Request for 0.22: uninstall target for cmake

2013-04-01 Thread Alan Conway
r1463202 | QPID-4687: Add uninstall make target to cmake build - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4390) Java Broker should allow runtime changes to persisted configuration

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618910#comment-13618910 ] Robbie Gemmell commented on QPID-4390: -- Some review changes were made for 0.22 via

[jira] [Updated] (QPID-4390) Java Broker should allow runtime changes to persisted configuration

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4390: - Fix Version/s: 0.22 Java Broker should allow runtime changes to persisted configuration

[jira] [Commented] (QPID-4681) [Java Broker] QPID-4390 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618913#comment-13618913 ] Robbie Gemmell commented on QPID-4681: -- Removing the 0.22 fix-for to de-clutter the

[jira] [Updated] (QPID-4681) [Java Broker] QPID-4390 review changes

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4681: - Fix Version/s: (was: 0.22) [Java Broker] QPID-4390 review changes

Re: 0.22 release update - release branched and beta available

2013-04-01 Thread Justin Ross
Approved for 0.22. On Thu, Mar 28, 2013 at 2:44 PM, Ken Giusti kgiu...@redhat.com wrote: Hi Justin, The ssl_test on the beta branch is broken - by yours truly. I checked in a fix on trunk yesterday: http://svn.apache.org/viewvc?view=revisionrevision=1461804 merely fixes the test, very

[jira] [Updated] (QPID-3769) NPE in client AMQDestination.equals()

2013-04-01 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3769: --- Fix Version/s: 0.22 NPE in client AMQDestination.equals()

Re: CMake improvements

2013-04-01 Thread Fraser Adams
Thanks Alan, I'll give them a whirl later in the week when I've got my proper IT back. I'm still on holiday with just my iPad until towards the end of the week. The list that you mention is I believe the main set of issues that I'd noticed, though Rob mentioned something previously that related

[jira] [Commented] (QPID-3769) NPE in client AMQDestination.equals()

2013-04-01 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618955#comment-13618955 ] Rajith Attapattu commented on QPID-3769: Ported the relevant changes to 0.22

RE: CMake improvements

2013-04-01 Thread Steve Huston
Just to poke in on this... I guess just mentioning running ldconfig may be OK but it would be nice to have it run automatically as the end of make install, don't know if that's possible or has undesirable consequences. It's not always possible, and not always even desirable. I would be

Re: CMake improvements

2013-04-01 Thread Alan Conway
On 04/01/2013 01:36 PM, Fraser Adams wrote: Thanks Alan, I'll give them a whirl later in the week when I've got my proper IT back. I'm still on holiday with just my iPad until towards the end of the week. The list that you mention is I believe the main set of issues that I'd noticed, though

[jira] [Resolved] (QPID-4688) [Java Broker] update optional BDB store to use version 5.0.73 of BDB JE

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-4688. -- Resolution: Fixed [Java Broker] update optional BDB store to use version 5.0.73 of BDB JE

[jira] [Commented] (QPID-4688) [Java Broker] update optional BDB store to use version 5.0.73 of BDB JE

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618972#comment-13618972 ] Robbie Gemmell commented on QPID-4688: -- FWIW Rob approves this request :) [6:22 pm]

[jira] [Commented] (QPID-4688) [Java Broker] update optional BDB store to use version 5.0.73 of BDB JE

2013-04-01 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618978#comment-13618978 ] Justin Ross commented on QPID-4688: --- Reviewed by Rob. Approved for 0.22.

[jira] [Updated] (QPID-4688) [Java Broker] update optional BDB store to use version 5.0.73 of BDB JE

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4688: - Fix Version/s: (was: 0.23) 0.22 Merged to 0.22 release branch in

[jira] [Comment Edited] (QPID-4688) [Java Broker] update optional BDB store to use version 5.0.73 of BDB JE

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618988#comment-13618988 ] Robbie Gemmell edited comment on QPID-4688 at 4/1/13 6:09 PM: --

[jira] [Commented] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618995#comment-13618995 ] Robbie Gemmell commented on QPID-4676: -- Thanks Jakub, I'll take first thing in the

[jira] [Comment Edited] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618995#comment-13618995 ] Robbie Gemmell edited comment on QPID-4676 at 4/1/13 6:13 PM: --

Review Request: QPID-4640: cmake: set RPATH so installed execuatables run.

2013-04-01 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10223/ --- Review request for qpid, Andrew Stitcher and Steve Huston. Summary (updated)

Re: Review Request: NO-JIRA: Remove unnecessary mention of ldconfig in INSTALL instructions.

2013-04-01 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10223/ --- (Updated April 1, 2013, 7:23 p.m.) Review request for qpid, Andrew Stitcher

Re: CMake improvements

2013-04-01 Thread Alan Conway
On 04/01/2013 01:48 PM, Steve Huston wrote: Just to poke in on this... I guess just mentioning running ldconfig may be OK but it would be nice to have it run automatically as the end of make install, don't know if that's possible or has undesirable consequences. It's not always possible, and

Re: Review Request: NO-JIRA: Remove unnecessary mention of ldconfig in INSTALL instructions.

2013-04-01 Thread Steve Huston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10223/#review18595 --- Ship it! Ship It! - Steve Huston On April 1, 2013, 7:23 p.m.,

RE: CMake improvements

2013-04-01 Thread Steve Huston
Love it - great work Alan! -Original Message- From: Alan Conway [mailto:acon...@redhat.com] Sent: Monday, April 01, 2013 3:29 PM To: Steve Huston Cc: dev@qpid.apache.org; fadams Subject: Re: CMake improvements On 04/01/2013 01:48 PM, Steve Huston wrote: Just to poke in on

Re: CMake improvements

2013-04-01 Thread Rob Godfrey
So, it still fails to compile on Ubuntu if you have the libnss3-dev package installed. The line in falls down on is doing the following: ~/qpid-clean/cpp/build/src$ /usr/bin/c++ -fPIC -fvisibility-inlines-hidden -Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual

[jira] [Created] (QPID-4689) QMF console drops object updates from local broker agent.

2013-04-01 Thread Ken Giusti (JIRA)
Ken Giusti created QPID-4689: Summary: QMF console drops object updates from local broker agent. Key: QPID-4689 URL: https://issues.apache.org/jira/browse/QPID-4689 Project: Qpid Issue Type: Bug

[jira] [Updated] (QPID-4689) QMF console drops object updates from local broker agent.

2013-04-01 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated QPID-4689: - Attachment: qpid-4689.patch proposed patch QMF console drops object updates from local

[jira] [Commented] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619429#comment-13619429 ] Robbie Gemmell commented on QPID-4676: -- ..or a little earlier. The tests looked good

[jira] [Resolved] (QPID-4676) [Java Broker] SSL Client Authentication with username constructed in the same way as on C++ broker

2013-04-01 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-4676. -- Resolution: Fixed [Java Broker] SSL Client Authentication with username constructed in the