[jira] [Updated] (QPID-3688) AMQDestination and children should conform to the JavaBean pattern

2011-12-20 Thread Rajith Attapattu (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3688: --- Attachment: QPID-3688.patch This patch doesn't change the AMQDestination into a Java bean

Re: [jira] [Reopened] (QPID-3625) XASessionImpl Incorrectly sets Session acknowledge mode to AUTO_ACKNOWLEDGE when it should be CLIENT_ACKNOWLEDGE

2011-12-09 Thread Rajith Attapattu
Yes Gordon alerted me to it last evening. Weston and I are looking into it. Rajith On Fri, Dec 9, 2011 at 3:26 AM, Keith Wall (Reopened) (JIRA) j...@apache.org wrote:     [ https://issues.apache.org/jira/browse/QPID-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

[jira] [Commented] (QPID-3625) XASessionImpl Incorrectly sets Session acknowledge mode to AUTO_ACKNOWLEDGE when it should be CLIENT_ACKNOWLEDGE

2011-12-09 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166382#comment-13166382 ] Rajith Attapattu commented on QPID-3625: Keith, after some investigation we've

[jira] [Resolved] (QPID-3625) XASessionImpl Incorrectly sets Session acknowledge mode to AUTO_ACKNOWLEDGE when it should be CLIENT_ACKNOWLEDGE

2011-12-08 Thread Rajith Attapattu (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-3625. Resolution: Fixed Fix Version/s: (was: 0.14) 0.15 This change

Re: Review Request: Add at least basic functionality to add ACL rules dynamically

2011-12-07 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3041/#review3701 --- On 2011-12-07 01:52:53, rajith attapattu wrote

[jira] [Commented] (QPID-3659) Java client mishandles tcp_nodelay when specified as part of the broker URL

2011-12-07 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164636#comment-13164636 ] Rajith Attapattu commented on QPID-3659: It is indeed due to not being quoted

[jira] [Resolved] (QPID-3659) Java client mishandles tcp_nodelay when specified as part of the broker URL

2011-12-07 Thread Rajith Attapattu (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-3659. Resolution: Fixed Assignee: Rajith Attapattu Java client mishandles tcp_nodelay

Re: svn commit: r1210989 - in /qpid/trunk/qpid/cpp: rubygen/ src/ src/qpid/ src/qpid/broker/ src/qpid/client/ src/qpid/cluster/ src/tests/ xml/

2011-12-06 Thread Rajith Attapattu
On Tue, Dec 6, 2011 at 11:02 AM, Alan Conway acon...@redhat.com wrote: On 12/06/2011 10:59 AM, Carl Trieloff wrote: On 12/06/2011 10:56 AM, acon...@apache.org wrote: NOTE 1: If you are using an ACL, the cluster-username must be allowed to publish to the qpid.cluster-credentials exchange.

[jira] [Created] (QPID-3665) Add at least basic functionality to add ACL rules dynamically

2011-12-06 Thread Rajith Attapattu (Created) (JIRA)
Components: C++ Broker Affects Versions: 0.14 Reporter: Rajith Attapattu Assignee: Rajith Attapattu Fix For: 0.15 There have been several requests in the past to provide some sort of functionality to add ACL rules dynamically. Recently QPID-3652 needed a way

Review Request: Add at least basic functionality to add ACL rules dynamically

2011-12-06 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3041/ --- Review request for qpid, Alan Conway, Gordon Sim, and Kim van der Riet. Summary

[jira] [Commented] (QPID-3654) ANONYMOUS SASL mechanism does not work on Java client

2011-11-30 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13160322#comment-13160322 ] Rajith Attapattu commented on QPID-3654: I think this was overdue. Thanks Andrew

Re: 0.14 release update - proposed final RC tomorrow

2011-11-30 Thread Rajith Attapattu
+1 to include this. This error msg was really annoying :) Rajith On Wed, Nov 30, 2011 at 5:14 PM, Robbie Gemmell robbie.gemm...@gmail.com wrote: I would like to request merging the fix for QPID-3582: Client reporting Unable to load custom SASL providers during connection. The client logs out

Re: GIT

2011-11-28 Thread Rajith Attapattu
As Robbie mentioned, most of the git fans are already using git-svn (I'm one of them). So we could perhaps wait for a bit to see how the trial unfolds. My concern is, that not everybody may be ready to use git at this point, so if we switch, then we will be disrupting the work for some folks.

[jira] [Commented] (QPID-3640) When releasing msgs, the JMS client should not mark msgs in the prefetch buffer as redelivered.

2011-11-24 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156879#comment-13156879 ] Rajith Attapattu commented on QPID-3640: Alex, I was about to attach my patch

[jira] [Commented] (QPID-3640) When releasing msgs, the JMS client should not mark msgs in the prefetch buffer as redelivered.

2011-11-24 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156880#comment-13156880 ] Rajith Attapattu commented on QPID-3640: I will be testing this along with the rest

[jira] [Created] (QPID-3640) When releasing msgs, the JMS client should not mark msgs in the prefetch buffer as redelivered.

2011-11-22 Thread Rajith Attapattu (Created) (JIRA)
Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.12, 0.10 Reporter: Rajith Attapattu Assignee: Rajith Attapattu Fix For: 0.15 When releasing messages, for ex when the application calls recover

[jira] [Updated] (QPID-3640) When releasing msgs, the JMS client should not mark msgs in the prefetch buffer as redelivered.

2011-11-22 Thread Rajith Attapattu (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3640: --- Attachment: RecoveryTest.java The test case basically does the following. It tries to receive

[jira] [Commented] (QPID-3640) When releasing msgs, the JMS client should not mark msgs in the prefetch buffer as redelivered.

2011-11-22 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155494#comment-13155494 ] Rajith Attapattu commented on QPID-3640: Note this test depends

Re: How do I contifure clien qpid Timeout for java?

2011-11-18 Thread Rajith Attapattu
You could use -Dqpid.heartbeat=x or use heartbeat as a broker url property. Btw, Please don't use the AMQ** classes. These are internal classes that will not be there going forward. It's better to use the JMS interfaces. Rajith On Fri, Nov 18, 2011 at 11:17 AM, Gaston Quezada

[jira] [Commented] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

2011-11-17 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152096#comment-13152096 ] Rajith Attapattu commented on QPID-2703: Part of the reason is in the java client

[jira] [Commented] (QPID-2703) Transaction Rollback/Recover does not restore consumer credit

2011-11-17 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152129#comment-13152129 ] Rajith Attapattu commented on QPID-2703: I think this is a good short term fix

Re: Request to include QPID-3626 in 0.14

2011-11-17 Thread Rajith Attapattu
On Thu, Nov 17, 2011 at 12:03 PM, Gordon Sim g...@redhat.com wrote: On 11/17/2011 04:57 PM, Ken Giusti wrote: Hi Justin, Would it be possible to include the fix for QPID-3626 in the upcoming rc? https://issues.apache.org/jira/browse/QPID-3626 Without it, any python client that would like

[jira] [Commented] (QPID-3562) the 0-10 client path does not act as expected with asynchronous consumers using a prefetch of 1 on transacted sessions

2011-11-17 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152382#comment-13152382 ] Rajith Attapattu commented on QPID-3562: Thanks for the feedback. I was trying

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

2011-11-17 Thread rajith attapattu
of AMQSession#rejectMessage? I wonder also if this logic sit better in AMQSession#notifyConsumer(). It already rejects messages if the consumer is closed. Could it not also reject messages if the connection is no longer started? rajith attapattu wrote: Keith if you look

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

2011-11-17 Thread rajith attapattu
required for? You are releasing a message you have just received, right? When is that required? rajith attapattu wrote: See the above for an explanation for why this is needed. Gordon Sim wrote: You mean this is here because of the lack of synchronization with the dispatcher thread

Re: Review Request: Sending of completions should be independent of sending message acks

2011-11-17 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2853/#review3325 --- On 2011-11-16 18:31:12, rajith attapattu wrote: --- This is an automatically generated

Re: Review Request: Sending of completions should be independent of sending message acks

2011-11-17 Thread rajith attapattu
it over I think it seems fine due to the processCompletions call in postDeliver(), but its possibly still worth a check. rajith attapattu wrote: Your observation is correct, this deals with messages that were already received by the application. For recover(), we really don't need

Re: Review Request: Sending of completions should be independent of sending message acks

2011-11-17 Thread rajith attapattu
-16 18:31:12, rajith attapattu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2853/ --- (Updated 2011-11-16 18:31:12

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

2011-11-16 Thread rajith attapattu
do the final commit :) - rajith --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2832/#review3294 --- On 2011-11-15 15:36:36, rajith

[jira] [Commented] (QPID-3625) XASessionImpl Incorrectly sets Session acknowledge mode to AUTO_ACKNOWLEDGE when it should be CLIENT_ACKNOWLEDGE

2011-11-16 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151321#comment-13151321 ] Rajith Attapattu commented on QPID-3625: Discussed this issue with Weston and I

[jira] [Commented] (QPID-3562) the 0-10 client path does not act as expected with asynchronous consumers using a prefetch of 1 on transacted sessions

2011-11-16 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151354#comment-13151354 ] Rajith Attapattu commented on QPID-3562: I have the following test case

Review Request: Sending of completions should be independent of sending message acks

2011-11-16 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2853/ --- Review request for qpid, Gordon Sim, Robbie Gemmell, Weston Price, Keith Wall,

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

2011-11-16 Thread rajith attapattu
of AMQSession#rejectMessage? I wonder also if this logic sit better in AMQSession#notifyConsumer(). It already rejects messages if the consumer is closed. Could it not also reject messages if the connection is no longer started? rajith attapattu wrote: Keith if you look

Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

2011-11-15 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2832/ --- Review request for qpid, Gordon Sim, Robbie Gemmell, Weston Price, and Oleksandr

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

2011-11-15 Thread rajith attapattu
for an explanation for why this is needed. - rajith --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2832/#review3264 --- On 2011-11-15 15:36:36, rajith

Re: Review Request: QPID-3604 - If connection is started and stopped, the client may get more messages than required by the prefetch value

2011-11-15 Thread rajith attapattu
as part of the block here? If so are there any lock ordering issues where you could be introducing a deadlock? rajith attapattu wrote: Not that I could think of. The message-delivery-lock is taken to ensure that no messages are being served while we start pulling them out of the queue

[jira] [Commented] (QPID-3610) set TCP_NODELAY true by default in the Java client to improve general performance

2011-11-11 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148507#comment-13148507 ] Rajith Attapattu commented on QPID-3610: Robbie, lets make sure we document

Re: Qpid client Android

2011-11-11 Thread Rajith Attapattu
The upcoming java client work will have this mind (in fact a requirement). The core client will have minimum (if not any) dependencies to facilitate mobile environments. We expect to do something in the 0.16 (release) time frame, if not 0.18 for sure. (We are currently about to release 0.14 and

[jira] [Created] (QPID-3612) Sending of completions should be independent of sending message acks

2011-11-11 Thread Rajith Attapattu (Created) (JIRA)
Components: Java Client Affects Versions: 0.14 Reporter: Rajith Attapattu Assignee: Rajith Attapattu Fix For: 0.15 Message credits are affected by Command Completions and not message-acks. However in the current codebase,these two are intertwined

[jira] [Created] (QPID-3613) Management of message credits should be on a per subscription basis (not on a per session basis)

2011-11-11 Thread Rajith Attapattu (Created) (JIRA)
Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.14 Reporter: Rajith Attapattu Assignee: Rajith Attapattu Fix For: 0.15 We currently calculate credit replenishment at the session level completely

[jira] [Updated] (QPID-3602) Fix Consumer message credit issues in 0-10 codepath

2011-11-11 Thread Rajith Attapattu (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3602: --- Description: Currently there are several issues related to message credits. 1. QPID-2604

[jira] [Created] (QPID-3604) If the connection is stopped the client should release all it's messages in the prefetch buffer

2011-11-09 Thread Rajith Attapattu (Created) (JIRA)
Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.14 Reporter: Rajith Attapattu Assignee: Rajith Attapattu Fix For: 0.15 When connection.stop() is called, the JMS client should release all it's

[jira] [Updated] (QPID-3602) Fix Consumer message credit issues in 0-10 codepath

2011-11-09 Thread Rajith Attapattu (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3602: --- Description: Currently there are several issues related to message credits. 1. QPID-2604

Release notes for the Java client

2011-11-08 Thread Rajith Attapattu
Hi Robbie (and co), I noticed at least one behavioural changes that warrants a prominent release note. I've added a comment in QPID-3583 to cover the change of acking behaviour for the AUTO_ACK case. See [1] Could you guys help with some of the changes made in the failover side. I'd let you

Re: TCP_NODELAY default value

2011-11-08 Thread Rajith Attapattu
TCP_NODELAY makes a considerable improvement in synchronous cases (sync pub, sync ack etc) and small tx cases and we generally recommend that as a tuning option to our users/customers. The reason for making TCP_NODELAY false by default is based on the assumption that in most cases people will

Potential blockers for 0.14

2011-11-03 Thread Rajith Attapattu
Hi All, Pavel has raised QPID-3575, where connections are not being closed properly when session exceptions are raised via exception listeners. He has also observed that, explicit closing of the session (after receiving the exception) as a workaround doesn't work either. We should investigate

[jira] [Commented] (QPID-3536) Topic Session Rollback/Recover does not work when using ADDR address destinations

2011-11-01 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141344#comment-13141344 ] Rajith Attapattu commented on QPID-3536: For Topics we need to figure out

Re: Java 0-10 client prefetch issues

2011-10-31 Thread Rajith Attapattu
On Mon, Oct 31, 2011 at 9:18 AM, Robbie Gemmell robbie.gemm...@gmail.com wrote: Hi all, Over the weekend I made a change to the 0-10 Java client so that using prefetch=1 with transacted sessions and an OnMessage() listener would result in the client only getting 1 message at a time, by moving

Re: Java 0-10 client prefetch issues

2011-10-31 Thread Rajith Attapattu
really makes any difference to asynchronous consumers. I'm fine with the current change you've made. Lets actually look at this credit issue in more detail after the release. Robbie On 31 October 2011 15:19, Rajith Attapattu rajit...@gmail.com wrote: On Mon, Oct 31, 2011 at 9:18 AM, Robbie

Re: Address node type resolution issues

2011-10-20 Thread Rajith Attapattu
that everybody feels is appropriate and desirable. Rajith Cheers, Rob On 17 October 2011 23:09, Robbie Gemmell robbie.gemm...@gmail.com wrote: On 17 October 2011 20:58, Rajith Attapattu rajit...@gmail.com wrote: On Mon, Oct 17, 2011 at 12:39 PM, Robbie Gemmell robbie.gemm...@gmail.com wrote: On 17

Re: Address node type resolution issues

2011-10-20 Thread Rajith Attapattu
On Thu, Oct 20, 2011 at 12:38 PM, Robbie Gemmell robbie.gemm...@gmail.com wrote: On 20 October 2011 16:36, Rajith Attapattu rajit...@gmail.com wrote: On Thu, Oct 20, 2011 at 6:05 AM, Rob Godfrey rob.j.godf...@gmail.com wrote: Sorry for being a little late responding to this thread... Stepping

[jira] [Commented] (QPID-3532) Fix the blocking of JMS operations when failover happens

2011-10-20 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131835#comment-13131835 ] Rajith Attapattu commented on QPID-3532: What kind of testing has been done

[jira] [Commented] (QPID-3532) Fix the blocking of JMS operations when failover happens

2011-10-20 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131926#comment-13131926 ] Rajith Attapattu commented on QPID-3532: Robbie, thanks for the quick response. I

[jira] [Commented] (QPID-3532) Fix the blocking of JMS operations when failover happens

2011-10-20 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13132078#comment-13132078 ] Rajith Attapattu commented on QPID-3532: Cool, go for it ! Fix

Re: Address node type resolution issues

2011-10-17 Thread Rajith Attapattu
On Mon, Oct 17, 2011 at 5:54 AM, Robbie Gemmell robbie.gemm...@gmail.com wrote: Why do we resolve Address node types? This question arose during review of proposed updates to the Address syntax implementation for the Java client, but ultimately looks to be a wider question for all the clients

Re: Address node type resolution issues

2011-10-17 Thread Rajith Attapattu
On Mon, Oct 17, 2011 at 12:39 PM, Robbie Gemmell robbie.gemm...@gmail.com wrote: On 17 October 2011 16:01, Rajith Attapattu rajit...@gmail.com wrote: On Mon, Oct 17, 2011 at 5:54 AM, Robbie Gemmell robbie.gemm...@gmail.com wrote: Why do we resolve Address node types? This question arose during

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread rajith attapattu
--- On 2011-10-12 21:09:40, rajith attapattu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2364

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread rajith attapattu
of mutating operations we currently have in our Destination implementations is rather incorrect (and also creates scope for thread safety issues). rajith attapattu wrote: First up, thanks for taking the time to look at the patches. I appreciate it. As for the testing situation I

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread rajith attapattu
of mutating operations we currently have in our Destination implementations is rather incorrect (and also creates scope for thread safety issues). rajith attapattu wrote: First up, thanks for taking the time to look at the patches. I appreciate it. As for the testing situation I

Re: Review Request: QPID-3401 changes to the core client

2011-10-14 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2364/#review2584 --- On 2011-10-12 21:09:40, rajith attapattu wrote

Re: Review Request: QPID-3401 New class structure for address refactoring

2011-10-14 Thread rajith attapattu
generated e-mail. To reply, visit: https://reviews.apache.org/r/2366/#review2549 --- On 2011-10-12 21:02:31, rajith attapattu wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: QPID-3401 New class structure for address refactoring

2011-10-14 Thread rajith attapattu
: https://reviews.apache.org/r/2366/#review2551 --- On 2011-10-12 21:02:31, rajith attapattu wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request: QPID-3401 New class structure for address refactoring

2011-10-14 Thread rajith attapattu
-mail. To reply, visit: https://reviews.apache.org/r/2366/#review2589 --- On 2011-10-12 21:02:31, rajith attapattu wrote: --- This is an automatically generated e-mail. To reply

[jira] [Commented] (QPID-3538) ADDR address format not supported for topic. and queue. entries in JNDI properties

2011-10-13 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126878#comment-13126878 ] Rajith Attapattu commented on QPID-3538: I could look at this along with the work I

[jira] [Updated] (QPID-3401) Refactor address resolution code

2011-10-12 Thread Rajith Attapattu (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3401: --- Attachment: class_diagram.png Class diagram that describes the new address implementation

[jira] [Commented] (QPID-3401) Refactor address resolution code

2011-10-12 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125876#comment-13125876 ] Rajith Attapattu commented on QPID-3401: The following set of patches aims

Review Request: QPID-3401 New class structure for address refactoring

2011-10-12 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2366/ --- Review request for qpid, Gordon Sim, Robbie Gemmell, Weston Price, and Keith

[jira] [Updated] (QPID-3401) Refactor address resolution code

2011-10-12 Thread Rajith Attapattu (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3401: --- Attachment: QPID-3401.patch QPID-3401-systests.patch The systests patch

Re: Review Request: QPID-3401 changes to the core client

2011-10-12 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2364/ --- (Updated 2011-10-12 21:09:40.553855) Review request for qpid, Gordon Sim,

[jira] [Commented] (QPID-3527) Messages may not acknowledged immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client

2011-10-05 Thread Rajith Attapattu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121309#comment-13121309 ] Rajith Attapattu commented on QPID-3527: Actually acknowledgement happens in two

Re: Failover

2011-09-29 Thread Rajith Attapattu
On Thu, Sep 22, 2011 at 12:19 PM, Oleksandr Rudyy oru...@gmail.com wrote: Thanks Rajith for your commentaries. I have discussed them with Robbie, our comments inline. Qpid Java Client Failover Policy 1. Qpid client failover basic principles.

Re: Failover

2011-09-29 Thread Rajith Attapattu
On Thu, Sep 29, 2011 at 12:02 PM, Oleksandr Rudyy oru...@gmail.com wrote: Rajith, Thanks a lot for your feedback. Could you also have a look into the Failover Behaviour WIKI we created to summarize the failover behaviour? Alex nice work to get the wiki page up and running. I added my

Re: [CONF] Apache Qpid System Properties

2011-09-28 Thread Rajith Attapattu
Hi Keith, The system properties are documented here http://qpid.apache.org/books/0.12/Programming-In-Apache-Qpid/html/ch03s06.html It would be nice if you can add them here as well. These docs are version controlled and is released along with the code/binaries. So if you are planning any

Re: Failover

2011-09-19 Thread Rajith Attapattu
Thanks for posting the write up. Comments inline. On Fri, Sep 16, 2011 at 12:26 PM, Oleksandr Rudyy oru...@gmail.com wrote: Hi all, Me and Robbie created the following draft of Failover Policy for Qpid Java Client. Could you please comment on it? Qpid Java Client Failover Policy 1. Qpid

Re: Review Request: QPID-3415 CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL mechanisms).

2011-09-16 Thread rajith attapattu
) Review request for qpid and rajith attapattu. Summary --- This patch changes the 0-10 code path to create the SASL callback handler using the CallbackHandlerRegistry. This allows the 0-10 code path to support SASL mechanisms requiring other callback handlers, such as CRAM-MD5-HASHED

[jira] [Commented] (QPID-3462) Failover is not transparent when using CLIENT_ACK mode

2011-09-16 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106874#comment-13106874 ] Rajith Attapattu commented on QPID-3462: When considering Failover with respect

[jira] [Issue Comment Edited] (QPID-3462) Failover is not transparent when using CLIENT_ACK mode

2011-09-16 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106874#comment-13106874 ] Rajith Attapattu edited comment on QPID-3462 at 9/16/11 10:35 PM

Re: Failover

2011-09-15 Thread Rajith Attapattu
The issues highlighted by Robbie are pretty much the problem areas that I have identified as well (along with a few more). All in all the failover code is the Achilles heel in the JMS client and most of the stability issues, deadlocks and race conditions are around this area. I've been collecting

[jira] [Commented] (QPID-3473) [Java] Replace use of MINA IO with IO layer developed for the Java 0-10 client

2011-09-07 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13098960#comment-13098960 ] Rajith Attapattu commented on QPID-3473: Thanks for taking care of this, makes my

[jira] [Commented] (QPID-3473) [Java] Replace use of MINA IO with IO layer developed for the Java 0-10 client

2011-09-07 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13099087#comment-13099087 ] Rajith Attapattu commented on QPID-3473: Yes I understood that part. I think

[jira] [Commented] (QPID-3415) CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL mechanisms).

2011-09-06 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13098067#comment-13098067 ] Rajith Attapattu commented on QPID-3415: Robbie, Quick comment to say that I am

Re: Review Request: QPID-3415 CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL mechanisms).

2011-09-06 Thread rajith attapattu
://reviews.apache.org/r/1608/ --- (Updated 2011-08-22 08:58:27) Review request for qpid and rajith attapattu. Summary --- This patch changes the 0-10 code path to create the SASL callback handler using the CallbackHandlerRegistry

[jira] [Commented] (QPID-3415) CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL mechanisms).

2011-09-06 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13098242#comment-13098242 ] Rajith Attapattu commented on QPID-3415: I would also want to test this patch

[jira] [Commented] (QPID-3415) CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL mechanisms).

2011-09-06 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13098263#comment-13098263 ] Rajith Attapattu commented on QPID-3415: I forgot to mention that this patch seems

[jira] [Created] (QPID-3466) The toString() method for JMSDestination and JMSReplyTo is not formatted properly according to the destination syntax.

2011-09-04 Thread Rajith Attapattu (JIRA)
: https://issues.apache.org/jira/browse/QPID-3466 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.12, 0.10 Reporter: Rajith Attapattu Assignee: Rajith Attapattu Priority: Minor Fix For: 0.14

[jira] [Commented] (QPID-3373) Java client: connectionFactory.createConnection method should not rewrite stored credentials

2011-09-01 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13095720#comment-13095720 ] Rajith Attapattu commented on QPID-3373: Alex, I applied your patch and tested

[jira] [Created] (QPID-3462) Failover is not transparent when using CLIENT_ACK mode

2011-09-01 Thread Rajith Attapattu (JIRA)
Client Affects Versions: 0.12, 0.10 Reporter: Rajith Attapattu Assignee: Rajith Attapattu Fix For: 0.14 If a session is using CLIENT_ACK mode fails over to another broker, and calls acknowledge on a message it received before failover, the client throws

[jira] [Created] (QPID-3461) A SessionException is thrown (instead of a JMSException) when an error occurs during a commit.

2011-08-31 Thread Rajith Attapattu (JIRA)
Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.12, 0.10 Reporter: Rajith Attapattu Assignee: Rajith Attapattu Fix For: 0.14 If the broker throws a session level exception, during or just before

[jira] [Commented] (QPID-3461) A SessionException is thrown (instead of a JMSException) when an error occurs during a commit.

2011-08-31 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13094988#comment-13094988 ] Rajith Attapattu commented on QPID-3461: An easy way to reproduce the issue

[jira] [Updated] (QPID-3461) A SessionException is thrown (instead of a JMSException) when an error occurs during a commit.

2011-08-31 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3461: --- Attachment: TxFailover.java Attaching a reproducer created by Siddhesh Poyarekar. To run

[jira] [Updated] (QPID-3395) Parsing exception of JNDI file should not be swallowed in Java library

2011-08-30 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3395: --- Fix Version/s: (was: 0.12) 0.14 Parsing exception of JNDI file should

[jira] [Resolved] (QPID-3395) Parsing exception of JNDI file should not be swallowed in Java library

2011-08-30 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-3395. Resolution: Fixed Assignee: Rajith Attapattu Applied Pavel's patch with minor

[jira] [Resolved] (QPID-3373) Java client: connectionFactory.createConnection method should not rewrite stored credentials

2011-08-30 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-3373. Resolution: Fixed Fix Version/s: 0.14 Assignee: Rajith Attapattu Fixed

[jira] [Commented] (QPID-3415) CRAM-MD5-HASHED not supported by 0-10 protocol (+ no suppport for custom SASL mechanisms).

2011-08-25 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091084#comment-13091084 ] Rajith Attapattu commented on QPID-3415: Keith, I just skimmed through the patch

Re: Welcome Keith as committer

2011-08-17 Thread Rajith Attapattu
Welcome Keith ! Regards, Rajith On Wed, Aug 17, 2011 at 3:22 PM, Robbie Gemmell robbie.gemm...@gmail.com wrote: Welcome, Keith :) Robbie On 17 August 2011 18:22, Carl Trieloff cctriel...@redhat.com wrote: Keith has been nominated and voted onto Qpid as a committer and has accepted.

Re: Packaging Qpid

2011-08-15 Thread Rajith Attapattu
We had a contributor who did build ubuntu packages for Qpid. However I am not sure about the current status and a bit of googling found the following link http://ubuntuforums.org/showthread.php?t=1785914 From searching the mailing lists for the contributor of ubuntu packages I found Mike Owens.

Re: IPv6 support for Java for 0.14?

2011-08-11 Thread Rajith Attapattu
On Thu, Aug 11, 2011 at 10:59 AM, Andrew Stitcher astitc...@redhat.com wrote: I've been spending much of my time in the past few weeks getting support for IPv6 in to the C++ and python code bases, and I expect to get it in the code base in the next few days (unless someone can see a problem not

Re: Review Request: IPv6 support for C++ (Windows and Linux) client/broker and python

2011-08-10 Thread rajith attapattu
On 2011-08-10 14:15:46, Gordon Sim wrote: As you have noted the python client doesn't support the AMQP 0-10 defined url scheme. The c++ messaging API consequently supports the form of url used by python in addition. That code is in src/qpid/cpp/amqp_0_10/SimpleUrlParser.cpp and would

[jira] [Created] (QPID-3401) Refactor address resolution code

2011-08-09 Thread Rajith Attapattu (JIRA)
Attapattu Assignee: Rajith Attapattu Fix For: 0.14 After some thought it seems that the following JIRA's would benefit from some reworking of the address resolution code as the original design had a few flaws based on incorrect understanding of the address syntax. QPID-3265

[jira] [Commented] (QPID-3381) Allow the AMQP 0-10 routing key to be retrieved via the message properties

2011-08-03 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079018#comment-13079018 ] Rajith Attapattu commented on QPID-3381: I forgot to account for the method name

<    1   2   3   4   5   6   7   8   9   10   >