Re: Review Request: Added SystemInfo::isLocalHost to check if a host name refers to the local host.

2012-05-07 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/ --- (Updated 2012-05-07 14:34:06.921280) Review request for qpid, Andrew Stitcher

Re: Review Request: Added SystemInfo::isLocalHost to check if a host name refers to the local host.

2012-05-07 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/#review7639 --- Picky little comment follows!

Re: Review Request: Added SystemInfo::isLocalHost to check if a host name refers to the local host.

2012-05-07 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/ --- (Updated 2012-05-07 17:00:08.238194) Review request for qpid, Andrew Stitcher

Re: Review Request: Added SystemInfo::isLocalHost to check if a host name refers to the local host.

2012-05-07 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/#review7647 --- Ship it! - Andrew On 2012-05-07 17:00:08, Alan Conway wrote:

Review Request: Added SystemInfo::isLocalHost to check if a host name refers to the local host.

2012-05-03 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/ --- Review request for qpid, Andrew Stitcher and Steve Huston. Summary ---

Re: Review Request: Added SystemInfo::isLocalHost to check if a host name refers to the local host.

2012-05-03 Thread Alan Conway
On 2012-05-03 16:17:15, Andrew Stitcher wrote: I'm concerned that using a simple IP address approach to avoiding connecting to yourself also stops you testing (or deploying) using multiple brokers on the same host. Good point, I'll use host:port - no changed needed in isLocalHost

Re: Review Request: Added SystemInfo::isLocalHost to check if a host name refers to the local host.

2012-05-03 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/ --- (Updated 2012-05-03 18:07:53.067617) Review request for qpid, Andrew Stitcher

Re: Review Request: Added SystemInfo::isLocalHost to check if a host name refers to the local host.

2012-05-03 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4992/#review7510 --- /trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp