[GitHub] qpid-jms pull request #26: QPIDJMS-430 Lock-Free FifoMessageQueue

2018-11-14 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/qpid-jms/pull/26 QPIDJMS-430 Lock-Free FifoMessageQueue You can merge this pull request into a Git repository by running: $ git pull https://github.com/franz1981/qpid-jms lock_free_fifo_q Alternatively

[GitHub] qpid-jms pull request #21: add [openjdk11] to Travis build matrix

2018-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/21 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #25: [QPIDJMS-426] Update to proton-j 0.30.0

2018-11-12 Thread sebthom
Github user sebthom closed the pull request at: https://github.com/apache/qpid-jms/pull/25 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #25: [QPIDJMS-426] Update to proton-j 0.30.0

2018-11-12 Thread sebthom
GitHub user sebthom opened a pull request: https://github.com/apache/qpid-jms/pull/25 [QPIDJMS-426] Update to proton-j 0.30.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sebthom/qpid-jms patch-1 Alternatively you can review

[GitHub] qpid-jms pull request #24: [QPIDJMS-424] Update to Netty 4.1.31 and netty-tc...

2018-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/24 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #24: [QPIDJMS-424] Update to Netty 4.1.31 and netty-tc...

2018-11-07 Thread sebthom
GitHub user sebthom opened a pull request: https://github.com/apache/qpid-jms/pull/24 [QPIDJMS-424] Update to Netty 4.1.31 and netty-tcnative 2.0.19 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sebthom/qpid-jms patch-1

[GitHub] qpid-jms pull request #23: QPIDJMS-423 onConnectionEstablished(): log only m...

2018-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/23 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #23: onConnectionEstablished(): log only main broker U...

2018-10-25 Thread benoitdevos
GitHub user benoitdevos opened a pull request: https://github.com/apache/qpid-jms/pull/23 onConnectionEstablished(): log only main broker URI part. This commit changes a little bit the logging info in the onConnectionEstablished() method. URI query params do not need to be logged.

[GitHub] qpid-jms pull request #22: QPIDJMS-417 Reduce GC pressure while using BytesM...

2018-10-10 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/qpid-jms/pull/22 QPIDJMS-417 Reduce GC pressure while using BytesMessage Using directly ByteBuf-based streams allows to avoid unnecessary creations of intermediate instances to operate on the underline

[GitHub] qpid-jms pull request #21: add [openjdk11] to Travis build matrix

2018-10-03 Thread sullis
GitHub user sullis opened a pull request: https://github.com/apache/qpid-jms/pull/21 add [openjdk11] to Travis build matrix You can merge this pull request into a Git repository by running: $ git pull https://github.com/sullis/qpid-jms travis-openjdk11 Alternatively you can

[GitHub] qpid-jms pull request #19: Save allocation of new promise on each writeAndFl...

2018-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/19 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #:

2018-07-03 Thread franz1981
Github user franz1981 commented on the pull request: https://github.com/apache/qpid-jms/commit/c66d888114021da31d9032c841c08903dd31cc89#commitcomment-29578801 In qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/ProviderFuture.java: In

[GitHub] qpid-jms pull request #:

2018-07-03 Thread franz1981
Github user franz1981 commented on the pull request: https://github.com/apache/qpid-jms/commit/7750a1c27589261b197d7b746506e19d8771b145#commitcomment-29578656 In qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpProvider.java: In

[GitHub] qpid-jms pull request #20: Issue QPIDJMS-400: Add missing OSGI resolution:=o...

2018-07-02 Thread Alex-Vol-SV
GitHub user Alex-Vol-SV opened a pull request: https://github.com/apache/qpid-jms/pull/20 Issue QPIDJMS-400: Add missing OSGI resolution:=optional to native tr… …ansports The packages io.netty.channel.epoll and io.netty.channel.kqueue need to be marked as optional

[GitHub] qpid-jms pull request #19: Save allocation of new promise on each writeAndFl...

2018-06-24 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/qpid-jms/pull/19 Save allocation of new promise on each writeAndFlush Using a void promise on Netty writeAndFlush is possible to save the allocation of a new one on each call. You can merge this pull request

[GitHub] qpid-jms pull request #18: QPIDJMS-375: Added transport.ws.authorizationHead...

2018-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/18 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #18: QPIDJMS-375: Added transport.ws.authorizationHead...

2018-04-05 Thread mibo
GitHub user mibo opened a pull request: https://github.com/apache/qpid-jms/pull/18 QPIDJMS-375: Added transport.ws.authorizationHeader option As described in the JIRA item: https://issues.apache.org/jira/browse/QPIDJMS-375 According tests will follow (however the

[GitHub] qpid-jms pull request #17: QPIDJMS-374: Use getRawQuery to avoid double enco...

2018-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/17 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #17: QPIDJMS-374: Use getRawQuery to avoid double enco...

2018-03-29 Thread mibo
GitHub user mibo opened a pull request: https://github.com/apache/qpid-jms/pull/17 QPIDJMS-374: Use getRawQuery to avoid double encoding You can merge this pull request into a Git repository by running: $ git pull https://github.com/mibo/qpid-jms master Alternatively you can

[GitHub] qpid-jms pull request #16: QPIDJMS-372: [SASL] [XOAUTH2] Make access token v...

2018-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/16 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #16: QPIDJMS-372: [SASL] [XOAUTH2] Make access token v...

2018-03-27 Thread k-wall
GitHub user k-wall opened a pull request: https://github.com/apache/qpid-jms/pull/16 QPIDJMS-372: [SASL] [XOAUTH2] Make access token validation comply wit… Makes the client's validation of OAUTH-2 access tokens RFC-6749 compliant. You can merge this pull request into a Git

[GitHub] qpid-jms pull request #15: QPIDJMS-340 - fix maven-assembly-plugin compatibi...

2017-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/15 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #15: QPIDJMS-340 - fix maven-assembly-plugin compatibi...

2017-10-13 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/qpid-jms/pull/15 QPIDJMS-340 - fix maven-assembly-plugin compatibility Set targLongFileMode to posix for handling long file names You can merge this pull request into a Git repository by running: $ git pull

[GitHub] qpid-jms pull request #14: QPIDJMS-339 - update documentation for new transp...

2017-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/14 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #14: QPIDJMS-339 - update documentation for new transp...

2017-10-13 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/qpid-jms/pull/14 QPIDJMS-339 - update documentation for new transport settings Update documentation for keystore and truststore settings You can merge this pull request into a Git repository by running: $

[GitHub] qpid-jms pull request #13: QPIDJMS-338 - Support setting keyStoreType and tr...

2017-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/13 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #13: QPIDJMS-338 - Support setting keyStoreType and tr...

2017-10-12 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/qpid-jms/pull/13 QPIDJMS-338 - Support setting keyStoreType and trustStoreType Qpid JMS now support setting the keyStoreType and trustStoreType to different formats You can merge this pull request into a Git

[GitHub] qpid-jms pull request #12: QPIDJMS-315: Add support for Netty KQueue transpo...

2017-08-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-jms pull request #12: QPIDJMS-315: Add support for Netty KQueue transpo...

2017-08-24 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/qpid-jms/pull/12 QPIDJMS-315: Add support for Netty KQueue transport Add KQueue support Also add safer epoll and kqueue env check to protect from lib loading failure (as found in apache activemq

[GitHub] qpid-jms pull request #11: QPIDJMS-315: Add support for Netty KQueue transpo...

2017-08-24 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/qpid-jms/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] qpid-jms pull request #11: QPIDJMS-315: Add support for Netty KQueue transpo...

2017-08-24 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/qpid-jms/pull/11 QPIDJMS-315: Add support for Netty KQueue transport Add KQueue support Also add safer epoll and kqueue env check to protect from lib loading failure (as found in apache activemq

[GitHub] qpid-jms pull request #9: QPIDJMS-294: Ensure that SASL mechanism has comple...

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-25 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r129354263 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128809457 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run() }

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128810019 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java --- @@ -137,7 +142,9 @@ private void

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128807526 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128808271 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128803960 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run() }

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128801781 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run() }

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128800956 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run() }

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128788568 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SaslGssApiIntegrationTest.java --- @@ -0,0 +1,185 @@ +/* + * + *

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128788434 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SaslGssApiIntegrationTest.java --- @@ -0,0 +1,185 @@ +/* + * + *

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128785321 --- Diff: qpid-jms-client/src/main/resources/login.config --- @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128775727 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128775211 --- Diff: qpid-jms-client/pom.xml --- @@ -93,6 +93,19 @@ hamcrest-all test + + org.apache.hadoop +

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128775254 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128774185 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java --- @@ -137,7 +142,9 @@ private void handleSaslStep()

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128755403 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SaslGssApiIntegrationTest.java --- @@ -0,0 +1,185 @@ +/* + * + *

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128747741 --- Diff: qpid-jms-client/src/main/resources/login.config --- @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128750540 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run() }

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128754495 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run() }

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128754756 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SaslGssApiIntegrationTest.java --- @@ -0,0 +1,185 @@ +/* + * + *

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128754720 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SaslGssApiIntegrationTest.java --- @@ -0,0 +1,185 @@ +/* + * + *

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128749340 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java --- @@ -495,6 +512,169 @@ public void run() }

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128727012 --- Diff: qpid-jms-client/pom.xml --- @@ -93,6 +93,19 @@ hamcrest-all test + + org.apache.hadoop +

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128752547 --- Diff: qpid-jms-client/src/test/resources/minikdc-krb5.conf --- @@ -0,0 +1,26 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128726699 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java --- @@ -137,7 +142,9 @@ private void

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128749066 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SaslIntegrationTest.java --- @@ -54,6 +54,7 @@ private static final

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128748789 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-21 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/10#discussion_r128747005 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/GssapiMechanism.java --- @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache

[GitHub] qpid-jms pull request #10: [QPIDJMS-303] implement sasl gssapi (kerberos) me...

2017-07-20 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/qpid-jms/pull/10 [QPIDJMS-303] implement sasl gssapi (kerberos) mechanism Using the current username or configured url prams the current kerberos credential is propagated via sasl gssapi mechanism. the default

[GitHub] qpid-jms pull request #9: QPIDJMS-294: Ensure that SASL mechanism has comple...

2017-07-13 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/9#discussion_r127257588 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/sasl/CramMD5MechanismTest.java --- @@ -85,4 +115,21 @@ public String getName() {

[GitHub] qpid-jms pull request #9: QPIDJMS-294: Ensure that SASL mechanism has comple...

2017-07-13 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/9#discussion_r127257712 --- Diff: qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/CramMD5Mechanism.java --- @@ -86,6 +86,14 @@ public String getName() { }

[GitHub] qpid-jms pull request #9: QPIDJMS-294: Ensure that SASL mechanism has comple...

2017-07-13 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/9#discussion_r127257449 --- Diff: qpid-jms-client/src/test/java/org/apache/qpid/jms/sasl/AbstractScramSHAMechanismTestBase.java --- @@ -137,4 +139,25 @@ public void

[GitHub] qpid-jms pull request #9: QPIDJMS-294: Ensure that SASL mechanism has comple...

2017-07-13 Thread k-wall
GitHub user k-wall opened a pull request: https://github.com/apache/qpid-jms/pull/9 QPIDJMS-294: Ensure that SASL mechanism has completed before allowing… … authentication to complete successfully This change allows the SCRAM mechanisms to ensure that server final

[GitHub] qpid-jms pull request #8: QPIDJMS-298 Add coverage report uploading to codec...

2017-07-11 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-jms/pull/8 QPIDJMS-298 Add coverage report uploading to codecov.io in .travis.yml You can review the report at https://codecov.io/gh/msgqe/qpid-jms/branch/codecov. There is also this nice feature of

[GitHub] qpid-jms pull request #7: Client+Server class additions - updated 5/15/17

2017-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-jms pull request #7: Client+Server class additions - updated

2017-05-11 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/7#discussion_r116052679 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Client.java --- @@ -0,0 +1,106 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #7: Client+Server class additions - updated

2017-05-11 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/7#discussion_r116064745 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Server.java --- @@ -0,0 +1,94 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #7: Client+Server class additions - updated

2017-05-11 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/7#discussion_r116048356 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Client.java --- @@ -0,0 +1,106 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #7: Client+Server class additions - updated

2017-05-11 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/7#discussion_r116053494 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Client.java --- @@ -0,0 +1,106 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #7: Client+Server class additions - updated

2017-05-11 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/7#discussion_r116057472 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Client.java --- @@ -0,0 +1,106 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #7: Client+Server class additions - updated

2017-05-11 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/7#discussion_r116069936 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Server.java --- @@ -0,0 +1,94 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #7: Client+Server class additions - updated

2017-05-11 Thread ageannopoulos
GitHub user ageannopoulos opened a pull request: https://github.com/apache/qpid-jms/pull/7 Client+Server class additions - updated I made these classes more simplified but still demonstrative of JMS message interpretation, added the licenses, and cleaned up code. I also

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-11 Thread ageannopoulos
Github user ageannopoulos closed the pull request at: https://github.com/apache/qpid-jms/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-09 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/6#discussion_r115542360 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Server.java --- @@ -0,0 +1,119 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-09 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/6#discussion_r115541734 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Server.java --- @@ -0,0 +1,119 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-09 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/6#discussion_r115540310 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Server.java --- @@ -0,0 +1,119 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-09 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/6#discussion_r115537587 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Client.java --- @@ -0,0 +1,204 @@ + +package org.apache.qpid.jms.example;

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-09 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/6#discussion_r115537215 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Client.java --- @@ -0,0 +1,204 @@ + --- End diff -- This new file

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-09 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/6#discussion_r115538757 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Client.java --- @@ -0,0 +1,204 @@ + +package org.apache.qpid.jms.example;

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-09 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/6#discussion_r115539336 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Client.java --- @@ -0,0 +1,204 @@ + +package org.apache.qpid.jms.example;

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-09 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-jms/pull/6#discussion_r115540862 --- Diff: qpid-jms-examples/src/main/java/org/apache/qpid/jms/example/Server.java --- @@ -0,0 +1,119 @@ +/* + * + * Licensed to the Apache

[GitHub] qpid-jms pull request #6: Added two new example classes, Client and Server.

2017-05-09 Thread ageannopoulos
GitHub user ageannopoulos opened a pull request: https://github.com/apache/qpid-jms/pull/6 Added two new example classes, Client and Server. These classes allow the user to input some messages, which can be sent to the server, manipulated, and then returned to the client. You can

[GitHub] qpid-jms pull request #5: Make it possible to choose type of acknowledge for...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-jms pull request #5: Make it possible to choose type of acknowledge for...

2017-03-18 Thread fjollberg
GitHub user fjollberg opened a pull request: https://github.com/apache/qpid-jms/pull/5 Make it possible to choose type of acknowledge for redeliveries [QPIDJMS-274] This is left here as a base for discussion. I want to be able to choose the acknowledge type for messages rejected

[GitHub] qpid-jms pull request #:

2017-01-13 Thread addoula88
Github user addoula88 commented on the pull request: https://github.com/apache/qpid-jms/commit/368dce70b8625b27e57137e71153554ff58fc384#commitcomment-20469817 In qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnectionFactory.java: In

[GitHub] qpid-jms pull request #:

2017-01-13 Thread addoula88
Github user addoula88 commented on the pull request: https://github.com/apache/qpid-jms/commit/368dce70b8625b27e57137e71153554ff58fc384#commitcomment-20469819 In qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnectionFactory.java: In

[GitHub] qpid-jms pull request #:

2016-11-09 Thread gemmellr
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-jms/commit/9b187287403fda5eebb2da7fff3c11a192575985#commitcomment-19759059 Please ask such questions on the users list (see https://qpid.apache.org/discussion.html) in future rather than by comment on

[GitHub] qpid-jms pull request #:

2016-11-09 Thread pl89
Github user pl89 commented on the pull request: https://github.com/apache/qpid-jms/commit/9b187287403fda5eebb2da7fff3c11a192575985#commitcomment-19758647 @gemmellr I'm not sure I understand this commit, could you please explain? If I call: `

[GitHub] qpid-jms pull request #4: QPIDJMS-164: Provide OSGi metadata for qpid-jms-cl...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-jms/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-jms pull request #4: Provide OSGi metadata for qpid-jms-client

2016-09-19 Thread ctron
GitHub user ctron opened a pull request: https://github.com/apache/qpid-jms/pull/4 Provide OSGi metadata for qpid-jms-client This change adds the maven-bundle-plugin to the parent project and activates it in the qpid-jms-client project, generating OSGi meta data for the

[GitHub] qpid-jms pull request #2: Implements QPIDJMS-164 - Provide an OSGi bundle fo...

2016-09-02 Thread chirino
Github user chirino closed the pull request at: https://github.com/apache/qpid-jms/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-jms pull request #3: Add default policy and imeout to override the "har...

2016-07-25 Thread intelradoux
GitHub user intelradoux opened a pull request: https://github.com/apache/qpid-jms/pull/3 Add default policy and imeout to override the "hard coded" value consumerBuilder I got an issue with a broker that do not support "NEVER" as expiration policy. (if timeout is set as 0 it will

[GitHub] qpid-jms pull request: Implements QPIDJMS-164 - Provide an OSGi bu...

2016-03-31 Thread tabish121
Github user tabish121 commented on the pull request: https://github.com/apache/qpid-jms/pull/2#issuecomment-204055703 I did add the BND plugin to proton-j recently in order to generate bundle information in the next release, a review from someone more versed in OSGi would be good.

[GitHub] qpid-jms pull request: Implements QPIDJMS-164 - Provide an OSGi bu...

2016-03-31 Thread chirino
Github user chirino commented on the pull request: https://github.com/apache/qpid-jms/pull/2#issuecomment-204042552 So some of the issues then you have to take on is make sure your internal dependencies work well add mixed versions. For example will your lib work well with the Netty

[GitHub] qpid-jms pull request: Implements QPIDJMS-164 - Provide an OSGi bu...

2016-03-31 Thread gemmellr
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-jms/pull/2#issuecomment-203999771 I rather dislike the uber bundle approach. Tim already did a little groundwork previously on updating our various dependencies to ensure they do/will provide osgi

[GitHub] qpid-jms pull request: Implements QPIDJMS-164 - Provide an OSGi bu...

2016-03-30 Thread chirino
GitHub user chirino opened a pull request: https://github.com/apache/qpid-jms/pull/2 Implements QPIDJMS-164 - Provide an OSGi bundle for the Qpid JMS client You can merge this pull request into a Git repository by running: $ git pull https://github.com/chirino/qpid-jms master

Re: [GitHub] qpid-jms pull request: QPIDJMS-31: trivial README change, testing ...

2015-02-27 Thread Robbie Gemmell
Testing response via email On 27 February 2015 at 17:24, gemmellr g...@git.apache.org wrote: Github user gemmellr commented on the pull request: https://github.com/apache/qpid-jms/pull/1#issuecomment-76433601 Testing comment via GitHub --- If your project is set up for it, you

  1   2   >