Re: Review Request 68083: RANGER-2167 - Upgrade to Apache parent pom version 20

2018-07-31 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68083/#review206702 --- Ship it! Ship It! - Velmurugan Periasamy On July 27, 2018

Re: Review Request 68096: RANGER-2168: Add service admin user through service config

2018-08-01 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68096/#review206746 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 1, 2018

Re: Review Request 68170: RANGER-2172: Fixing minor issue with the no. of characters read using sscanf

2018-08-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68170/#review206820 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 2, 2018, 7

Re: Review Request 68185: RANGER-2168: Add service admin user through service config

2018-08-03 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68185/#review206845 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 3, 2018

Re: Review Request 68228: Unit Test cases to cover policy operations from service admin user

2018-08-06 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68228/#review206883 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 6, 2018

Re: Review Request 68228: Unit Test cases to cover policy operations from service admin user

2018-08-07 Thread Velmurugan Periasamy
T:1046 Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 'rs'.. ``` - Velmurugan Periasamy On Aug. 7, 2018, 7:26 a.m., Nikhil P wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 68191: RANGER-2182 : Handle upgrade scenario since atlas-service def is added with new resources for relationship

2018-08-08 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68191/#review206987 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 8, 2018

Re: Review Request 68269: RANGER-2184 : Update RangerAtlas authorization to authorize add/update/remove of relationships

2018-08-08 Thread Velmurugan Periasamy
llowed(AtlasTypeAccessRequest) in RangerAtlasAuthorizer overrides a method whose erasure is the same as another method, yet neither overrides the other ``` - Velmurugan Periasamy On Aug. 8, 2018, 4:47 p.m., Nixon Rodrigues wrote: > > ---

Re: Review Request 68209: RANGER-2183: Use INodeAttribute information to authorize HDFS access

2018-08-09 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68209/#review207050 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 4, 2018, 6

Re: Review Request 68292: RANGER-2187 : External Group search fails on Ranger UI when installed with postgres

2018-08-10 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68292/#review207104 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 10, 2018

Re: Review Request 68293: RANGER-2114 : Internal Exception: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'content' at row 1

2018-08-10 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68293/#review207105 --- Ship it! Ship It! - Velmurugan Periasamy On Aug. 10, 2018

Re: Review Request 68290: RANGER-2185:when user has access to some of Hive databases, execute command 'show databases' will show the access databases

2018-08-11 Thread Velmurugan Periasamy
Hive specific items should not be brought into common plugin classes. - Velmurugan Periasamy On Aug. 10, 2018, 11:14 a.m., dhomme wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Assign a JIRA to me

2018-08-11 Thread Velmurugan Periasamy
Hi ­ thank you for your interest in contributing to Ranger. Could you please share your Apache JIRA ID? I searched with your email and could not find it. From: pengquan Reply-To: "dev@ranger.apache.org" , pengquan Date: Friday, August 10, 2018 at 2:45 AM To: "dev@ranger.apache.org" Subject:

Re: Review Request 68211: RANGER-2157 Add NiFi Registry service definition and NiFiRegistryClient

2018-09-10 Thread Velmurugan Periasamy
ves in the same package. [INFO] PMD Failure: org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java:24 Rule:ImportFromSamePackage Priority:3 No need to import a type that lives in the same package. ``` - Velmurugan Periasamy On Sept. 3, 2018, 12:

Re: Review Request 68211: RANGER-2157 Add NiFi Registry service definition and NiFiRegistryClient

2018-09-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68211/#review208629 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 13, 2018

Re: Review Request 68715: RANGER-2226 - Define explicit (test) dependency on json-smart in the Knox agent

2018-09-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68715/#review208631 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 14, 2018

Re: Review Request 68738: RANGER-2186: Part II - check for NPE when incrementing service-specific policy and tag versions after update transaction is committed

2018-09-17 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68738/#review208686 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 17, 2018

Re: Atlas version

2018-09-18 Thread Velmurugan Periasamy
Thank you Colm. My suggestion is to release Ranger 1.2.0 with Atlas version 1.1.0 (which just got released). Master can continue tracking Atlas 2.0.0-SNAPSHOT, and 1.1+ lines can be updated to Atlas 1.1.0. Thoughts? From: Colm O hEigeartaigh Sent:

Re: Atlas version

2018-09-18 Thread Velmurugan Periasamy
Thanks. Filed https://issues.apache.org/jira/browse/RANGER-2228 I will work on the release. From: Colm O hEigeartaigh Sent: Tuesday, September 18, 2018 12:08 PM To: Velmurugan Periasamy Cc: dev@ranger.apache.org Subject: Re: Atlas version Sure, that

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-20 Thread Velmurugan Periasamy
oved license. - Velmurugan Periasamy On Sept. 19, 2018, 9 p.m., Csaba Koncz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 68681: RANGER-2213 Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.90.

2018-09-20 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68681/#review208829 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 11, 2018

Review Request 68824: Update Atlas Version

2018-09-24 Thread Velmurugan Periasamy
/jira/browse/RANGER-2230 Repository: ranger Description --- RANGER-2230 Update Atlas Version Diffs - pom.xml 9b0bc9a Diff: https://reviews.apache.org/r/68824/diff/1/ Testing --- Passed all unit tests. Thanks, Velmurugan Periasamy

Release preparation for Apache Ranger 1.2.0 (Re: Atlas version)

2018-09-24 Thread Velmurugan Periasamy
22)%20AND%20fixVersion%20=%201.2.0> Tentatively Ranger 1.2.0 can be targeted for next week. Thank you, Vel > On Sep 18, 2018, at 3:59 PM, Velmurugan Periasamy wrote: > > Thanks. Filed https://issues.apache.org/jira/browse/RANGER-2228 > >

Re: Review Request 68707: RANGER-2210:Ranger support for Apache Kafka 2.0.0

2018-09-25 Thread Velmurugan Periasamy
1.0.0 1.0.0 1.0.0 2.3.0 error: patch failed: pom.xml:183 error: pom.xml: patch does not apply ``` - Velmurugan Periasamy On Sept. 13, 2018, 12:46 a.m., Ramesh Mani wrote: > > -

Re: Review Request 68629: RANGER-2208 Code improvement to fetch User/Group information and Service Config details

2018-09-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68629/#review209020 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 5, 2018

Re: Review Request 68707: RANGER-2210:Ranger support for Apache Kafka 2.0.0

2018-09-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68707/#review209022 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 25, 2018

Re: Review Request 68796: KNOX-2231 - Upgrade to Knox 1.1.0

2018-09-26 Thread Velmurugan Periasamy
or: while searching for: 4.12 1.0.0 1.0.0 1.0.0 2.3.0 1.10 ${project.basedir}/../lib/local error: patch failed: pom.xml:187 error: pom.xml: patch does not apply ``` - Velmurugan Periasamy On Sept. 21, 20

[VOTE] Apache Ranger Release 1.2.0-rc1

2018-09-27 Thread Velmurugan Periasamy
Hello Rangers: Thank you for your contribution to Apache Ranger community. Apache Ranger 1.2.0 release candidate #1 is now available for a vote within dev community. Links to RC1 release artifacts are given below. Kindly request all Rangers (Dev's & PMC members) to review and vote on this rele

Re: Review Request 68796: RANGER-2231 - Upgrade to Knox 1.1.0

2018-09-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68796/#review209083 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 26, 2018

[RESULT] [VOTE] Apache Ranger Release 1.2.0-rc1

2018-10-02 Thread Velmurugan Periasamy
member(s): +1 Abhay Kulkarni +1 Colm O hEigeartaigh +1 Madhanmohan Neethiraj +1 Ramesh Mani +1 Selvamohan Neethiraj +1 Velmurugan Periasamy Six +1 votes from the following non-PPMC member(s): +1 Koji Kawamura +1 Mehul Parikh +1 Nixon Rodrigues +1 Peng Jianhua +1 Pradeep Agrawal +1 Sailaja Polavarapu

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-02 Thread Velmurugan Periasamy
/ServiceUtil.java Line 859 (original), 859 (patched) <https://reviews.apache.org/r/68871/#comment293446> Better to use equalsIgnoreCase ? - Velmurugan Periasamy On Sept. 28, 2018, 3:20 a.m., Qiang Zhang wrote: > > --- > This is a

Re: Review Request 68894: RANGER-2239 - Update to surefire 2.21.0

2018-10-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68894/#review209153 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 2, 2018, 8

Re: Review Request 68864: RANGER-2237 Upgrade Kylin version to 2.5.0

2018-10-02 Thread Velmurugan Periasamy
1.0.0 1.0.0 2.3.0 1.10 ${project.basedir}/../lib/local 1.2.17 error: patch failed: pom.xml:188 error: pom.xml: patch does not apply ``` - Velmurugan Periasamy On Sept. 27, 2018, 7:19 a.m., Qiang Zh

Re: [RESULT] [VOTE] Apache Ranger Release 1.2.0-rc1

2018-10-02 Thread Velmurugan Periasamy
Updated vote count. Sorry for missing a vote from Dilli. Seven +1 votes from the following PPMC member(s): +1 Abhay Kulkarni +1 Colm O hEigeartaigh +1 Dilli Arumugam +1 Madhanmohan Neethiraj +1 Ramesh Mani +1 Selvamohan Neethiraj +1 Velmurugan Periasamy Six +1 votes from the following non-PPMC

Re: Review Request 65950: Add support to allow clients to access resource permissions stored in Ranger

2018-10-02 Thread Velmurugan Periasamy
ResourceACLs'. [INFO] PMD Failure: org.apache.ranger.authorization.hbase.HBaseRangerAuthorizationTest:1007 Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 'userPermission'.. ``` - Velmurugan Periasamy On Sept. 26, 2018, 10:40 p.m., Ankit Singhal wrote: > >

Re: Review Request 67697: RANGER-2140: Upgrade spring and guava libraries

2018-10-02 Thread Velmurugan Periasamy
e the description in RR and JIRA. For spring version upgrade, please create a new JIRA. Thanks. - Velmurugan Periasamy On June 25, 2018, 10:26 a.m., Pradeep Agrawal wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 68849: RANGER-2235 Modify the login session detail page as a modal.

2018-10-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68849/#review209163 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 26, 2018

Review Request 68925: RANGER-2241: Fix release build scripts to conform to latest Apache release guidelines - Part 2 - Remove sha1 and mds

2018-10-04 Thread Velmurugan Periasamy
Thanks, Velmurugan Periasamy

CVE update - fixed in Apache Ranger 1.2.0

2018-10-04 Thread Velmurugan Periasamy
. Thank you, Velmurugan Periasamy

Re: Review Request 68908: Perform graceful terminate with retries before doing forceful kill for usersync and tagsync

2018-10-04 Thread Velmurugan Periasamy
-services.sh Lines 124 (patched) <https://reviews.apache.org/r/68908/#comment293550> Can you please make sure this is merged in ranger-1 line branches? - Velmurugan Periasamy On Oct. 3, 2018, 6:43 a.m., bhavik patel wrote: > > ---

Re: Review Request 68855: RANGER-2222: Apache RangerKafkaPlugin support to handle Kafka Cluster as a new resource

2018-10-05 Thread Velmurugan Periasamy
java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java Lines 207 (patched) <https://reviews.apache.org/r/68855/#comment293570> Same as above. - Velmurugan Periasamy On Oct. 5, 2018, 3:43 p.m., Ramesh Mani wrote: > >

Re: Review Request 65950: Add support to allow clients to access resource permissions stored in Ranger

2018-10-05 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65950/#review209281 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 4, 2018

Re: Review Request 68855: RANGER-2222: Apache RangerKafkaPlugin support to handle Kafka Cluster as a new resource

2018-10-08 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68855/#review209316 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 5, 2018

Re: Review Request 67697: RANGER-2140: Upgrade spring and guava libraries

2018-10-08 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67697/#review209327 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 8, 2018, 7

Re: Review Request 68952: RANGER-2243: Provide option to ranger builds to specifically build a single plugin

2018-10-08 Thread Velmurugan Periasamy
tps://reviews.apache.org/r/68952/#comment293650> This is a good option. Can you please make sure this is ported to 1.x lines as well? Thanks. - Velmurugan Periasamy On Oct. 8, 2018, 8:16 p.m., Sailaja Polavarapu wrote: > > ---

Re: Review Request 68974: RANGER-2245: Exclude Jetty libraries

2018-10-10 Thread Velmurugan Periasamy
(patched) <https://reviews.apache.org/r/68974/#comment293807> Could you please make sure this is merged in 1.x branches as well? Thanks. - Velmurugan Periasamy On Oct. 10, 2018, 2:12 p.m., Pradeep Agrawal wrote: > > ---

Re: Review Request 68864: RANGER-2237 Upgrade Kylin version to 2.5.0

2018-10-10 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68864/#review209411 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 8, 2018, 1

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-10 Thread Velmurugan Periasamy
/ranger/common/ServiceUtil.java Line 859 (original), 859 (patched) <https://reviews.apache.org/r/68871/#comment293809> Could you please make sure that this is merged into 1.x branches as well? Thank you. - Velmurugan Periasamy On Oct. 8, 2018, 2:08 a.m., Qiang Zhang

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-10 Thread Velmurugan Periasamy
tps://reviews.apache.org/r/68770/#comment293810> Could you please make sure this is merged in 1.x branches? Thanks. - Velmurugan Periasamy On Oct. 4, 2018, 7:50 p.m., Csaba Koncz wrote: > > --- > This is an automatically gener

Re: Review Request 68997: RANGER-2242: JiSQL utility is failing Oracle UDF

2018-10-11 Thread Velmurugan Periasamy
/Jisql.java Lines 432 (patched) <https://reviews.apache.org/r/68997/#comment293886> Could you please make sure that this is merged into 1.x lines? Thanks. - Velmurugan Periasamy On Oct. 11, 2018, 4:49 p.m., Abhay Kulkarni

Re: Review Request 68942: RANGER-2207: Allow resources to appear in column mask policies without being visible in access policies

2018-10-12 Thread Velmurugan Periasamy
/ranger/plugin/errors/ValidationErrorCode.java Lines 66 (patched) <https://reviews.apache.org/r/68942/#comment293967> Could you please make sure to merge this in 1.x lines (ranger-1, ranger-1.2, ranger-1.1, ranger-1.0)? Thank you. - Velmurugan Periasamy On Oct. 10, 2018, 6:48 p.m.,

Re: Review Request 69040: RANGER-2229 : Perform graceful terminate with retries before doing forceful kill for usersync and tagsync

2018-10-16 Thread Velmurugan Periasamy
-services.sh Line 84 (original), 84 (patched) <https://reviews.apache.org/r/69040/#comment294148> Could you please make sure that this is merged in 1.x lines? Thanks. - Velmurugan Periasamy On Oct. 16, 2018, 8:39 a.m., bhavik patel

Re: Review Request 69027: RANGER-2250-Service configs fields are not showing for atlas service form page

2018-10-16 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69027/#review209651 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 16, 2018

Re: Review Request 69065: RANGER-2256 - Grammatical error in UI

2018-10-17 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69065/#review209702 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 17, 2018

Re: Review Request 69051: RANGER-2252:Permission "Kafka Admin" should not be part of Topic resource in Ranger Kafka resource definition

2018-10-17 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69051/#review209703 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 16, 2018

Re: Review Request 68983: RANGER-2247: Ranger Plugin for HDFS throws StringIndexOutOfBounds exception when policy resource is "\"

2018-10-17 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68983/#review209711 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 12, 2018

Re: Review Request 69112: RANGER-2259 : Need to provide appropriate permisssions for unix-auth files.

2018-10-22 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69112/#review209846 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 22, 2018

Re: Review Request 69083: RANGER-2251 : Need to provide options for making java heap size memory configurable in Ranger services.

2018-10-22 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69083/#review209847 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 22, 2018

Re: Review Request 69111: RANGER-2260: Atlas servicedef version change patch should update atlas access type def for tag def also.

2018-10-22 Thread Velmurugan Periasamy
[INFO] PMD Failure: org.apache.ranger.patch.PatchForAtlasServiceDefUpdate_J10013:230 Rule:UnusedFormalParameter Priority:3 Avoid unused method parameters such as 'prefix'.. ``` - Velmurugan Periasamy On Oct. 22, 2018, 9:04 a.m., Prade

Re: Review Request 69117: Improvement of export to excel from report listing page for Oracle database

2018-10-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69117/#review209917 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 22, 2018

Re: Review Request 69126: RANGER-2263: Removed unnecessary explicit dependency for apache commons compress jar in Ranger

2018-10-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69126/#review209933 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 23, 2018

Re: Review Request 69134: RANGER-2264:Kafka default policies for new resources are not showing up in UI when upgrade is done from older version

2018-10-24 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69134/#review210015 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 24, 2018

Re: Ranger mvn build parameters...

2018-10-25 Thread Velmurugan Periasamy
I am able to build locally using the below command (no change) even after RANGER-2243. mvn clean compile package install assembly:assembly Could it be related to maven version? I am using maven 3.3.9 and it is picking up the right maven-assembly-plugin (2.2-beta-5) specified in pom.xml. Not su

Re: Review Request 69189: Implement best coding practices for validating user input

2018-10-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69189/#review210093 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 26, 2018

Re: Review Request 69187: RANGER-2268: Optimize policy and tags migration to new schema

2018-10-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69187/#review210097 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 26, 2018

Re: Review Request 69198: RANGER-2270: Restrict tag module access to unprivileged users

2018-10-29 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69198/#review210163 --- Ship it! Ship It! - Velmurugan Periasamy On Oct. 29, 2018

Re: Review Request 69228: Allow service admin and delegated admin user to view list of users and groups though they have 'USER' role

2018-11-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69228/#review210283 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 2, 2018, 1

Re: Review Request 69238: RANGER-2275: Make db_setup retry delay configurable

2018-11-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69238/#review210282 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 2, 2018, 6

Re: Review Request 69231: RANGER-2074: Update netty version in ranger - ranger-0.7 branch

2018-11-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69231/#review210284 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 1, 2018, 6

Re: Review Request 69253: RANGER-2278 Unable to delete user if he has references in new ref tables

2018-11-05 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69253/#review210328 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 5, 2018, 2

Re: Review Request 69259: RANGER-2279: Reduce the time spent changing passwords during Ranger Admin install

2018-11-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69259/#review210538 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 12, 2018

Re: Review Request 69328: RANGER-2283 : User is getting total count of groups even if he is assigned to one group due to which pagination is breaking

2018-11-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69328/#review210542 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 14, 2018

Re: Review Request 69347: RANGER-2286: Ranger install may be prevented by leftover DB entry

2018-11-15 Thread Velmurugan Periasamy
schema all of these places have the same logic. 2] Should this 10 min be made configurable? - Velmurugan Periasamy On Nov. 15, 2018, 1:43 p.m., Pradeep Agrawal wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 69319: RANGER-2049: Added support for doAs for Ranger REST APIs with Kerberized mode

2018-11-15 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69319/#review210593 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 15, 2018

Re: Review Request 69370: RANGER-2284: Unable to build image using docker

2018-11-19 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69370/#review210687 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 16, 2018

Re: Review Request 69347: RANGER-2286: Ranger install may be prevented by leftover DB entry

2018-11-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69347/#review210759 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 20, 2018

Re: Review Request 69446: RANGER-2292 Test case fix for RANGER-2276

2018-11-26 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69446/#review210861 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 26, 2018

Re: Review Request 69518: RANGER-2305:When Audit spooling to local filesystem is enabled, log files of the component have show a wrong error message

2018-12-10 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69518/#review211163 --- Ship it! Ship It! - Velmurugan Periasamy On Dec. 7, 2018

FW: Subject: [NOTICE] Mandatory relocation of Apache git repositories on git-wip-us.apache.org

2018-12-10 Thread Velmurugan Periasamy
Rangers: Please see below. I propose to move ranger repos over to gitbox (from git-wip-us.apache.org ) during the first phase (voluntary coordination). Please share your thoughts. Once there is agreement in dev list, I can open INFRA ticket to complete the move.

Re: Review Request 69509: RANGER-2304 : Need to add property dfs.permissions.ContentSummary.subAccess when enabling Ranger HDFS plugin manually.

2018-12-12 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69509/#review211229 --- Ship it! Ship It! - Velmurugan Periasamy On Dec. 5, 2018

Re: Review Request 69526: RANGER-2308: User role user should not able to access usersync audit report if it does not have permissions on the audit module.

2018-12-12 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69526/#review211245 --- Ship it! Ship It! - Velmurugan Periasamy On Dec. 10, 2018

Re: Review Request 69468: RANGER-2295: Set specific Ranger version in patches status entry table

2018-12-12 Thread Velmurugan Periasamy
tps://reviews.apache.org/r/69468/#comment296180> Is it enough to consider only localhost? - Velmurugan Periasamy On Nov. 28, 2018, 10:19 a.m., Pradeep Agrawal wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 69453: RANGER-2291: Make optimized db schema script idempotent for all DB Flavors

2018-12-12 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69453/#review211247 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 28, 2018

Re: Review Request 69468: RANGER-2295: Set specific Ranger version in patches status entry table

2018-12-13 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69468/#review211309 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 28, 2018

Re: Subject: [NOTICE] Mandatory relocation of Apache git repositories on git-wip-us.apache.org

2018-12-17 Thread Velmurugan Periasamy
> > +1 > > > > On 12/10/18, 1:22 PM, "Abhay Kulkarni" > wrote: > > > > +1 > > > > On 12/10/18, 12:06 PM, "Velmurugan Periasamy" > wrote: > > > > >Rangers: > > > > > >Please se

Re: Review Request 69565: Improve group search on policy edit page

2018-12-17 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69565/#review211364 --- Ship it! Ship It! - Velmurugan Periasamy On Dec. 13, 2018

Re: Subject: [NOTICE] Mandatory relocation of Apache git repositories on git-wip-us.apache.org

2018-12-17 Thread Velmurugan Periasamy
Migration has been completed. New target URL(s): - https://gitbox.apache.org/repos/asf/ranger.git - https://github.com/apache/ranger > On Dec 17, 2018, at 2:47 PM, Velmurugan Periasamy wrote: > > Hello Rangers: > > Thank you for your responses. Since there is agreement

Re: Review Request 69630: RANGER-2313: tagsync fails to authenticate with ranger in kerberized cluster when using ranger-tagsync-update.sh script

2018-12-24 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69630/#review211527 --- Ship it! Ship It! - Velmurugan Periasamy On Dec. 24, 2018

Re: Review Request 69630: RANGER-2313: tagsync fails to authenticate with ranger in kerberized cluster when using ranger-tagsync-update.sh script

2018-12-28 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69630/#review211571 --- Ship it! Ship It! - Velmurugan Periasamy On Dec. 28, 2018

Re: Subject: [NOTICE] Mandatory relocation of Apache git repositories on git-wip-us.apache.org

2019-01-02 Thread Velmurugan Periasamy
gt; On Dec 17, 2018, at 3:27 PM, Velmurugan Periasamy wrote: > > Migration has been completed. > > New target URL(s): > - https://gitbox.apache.org/repos/asf/ranger.git > - https://github.com/apache/ranger > > > >> On De

Re: Review Request 68620: RANGER-2206: Add Policy Validity Period and Override as search filters and add distinguishing icons in policy listing page

2019-01-02 Thread Velmurugan Periasamy
es/xa.css... ``` - Velmurugan Periasamy On Sept. 4, 2018, 2:35 p.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 69067: RANGER-2255 JavaScript tests for UI loading

2019-01-02 Thread Velmurugan Periasamy
vperiasamy/git/tlp-ranger/master/ranger/security-admin/target/security-admin-web-2.0.0-SNAPSHOT/tests/karma-dev.conf.js does not exist! [INFO] ``` - Velmurugan Periasamy On Oct. 22, 2018, 8:34 p.m., Csaba Koncz wrote: > > --- > This

Re: Review Request 68685: RANGER-2216: Ranger Audit UI lacks the feature to search the audits using Policy Id

2019-01-02 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68685/#review211617 --- Ship it! Ship It! - Velmurugan Periasamy On Sept. 11, 2018

Re: Review Request 69626: RANGER-2312 Internal users should have permission to modify their personal information in User Profile page.

2019-01-02 Thread Velmurugan Periasamy
Line 211 (original), 211 (patched) <https://reviews.apache.org/r/69626/#comment296971> Auditor role users should not be able to update. Please check this. - Velmurugan Periasamy On Dec. 22, 2018, 3:59 a.m., Qiang Zhang

Re: Review Request 69659: RANGER-2318 - homepage has a wrong git URL

2019-01-03 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69659/#review211655 --- Ship it! Ship It! - Velmurugan Periasamy On Jan. 3, 2019

Re: Review Request 69549: RANGER-2234 : Cannot add or update a child row, a foreign key constraint fails when installing ranger-admin

2019-01-22 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69549/#review212220 --- Ship it! Ship It! - Velmurugan Periasamy On Dec. 12, 2018

Re: Review Request 69730: RANGER-2320: Make db schema patches script idempotent for all DB Flavors

2019-01-22 Thread Velmurugan Periasamy
(original), 29 (patched) <https://reviews.apache.org/r/69730/#comment297935> Could you please rebase this patch? It has conflict with https://reviews.apache.org/r/69549/ I believe. - Velmurugan Periasamy On Jan. 12, 2019, 8:56 a.m., Pradeep Agrawal

Re: Review Request 69677: RANGER-2287: Improve and optimize db_setup.py file code

2019-01-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69677/#review212238 --- Ship it! Ship It! - Velmurugan Periasamy On Jan. 22, 2019

Re: Review Request 69730: RANGER-2320: Make db schema patches script idempotent for all DB Flavors

2019-01-23 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69730/#review212239 --- Ship it! Ship It! - Velmurugan Periasamy On Jan. 23, 2019

Re: Review Request 69853: RANGER-2327: Update Ranger db schema to use common sequence name

2019-01-29 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69853/#review212414 --- Ship it! Ship It! - Velmurugan Periasamy On Jan. 29, 2019

<    1   2   3   4   5   6   7   8   9   10   >