Re: Review Request 50464: RANGER-1124: Good coding practices in Ranger recommended by static code analysis

2016-07-27 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50464/ --- (Updated July 28, 2016, 2:29 a.m.) Review request for ranger, Madhan Neethiraj

Re: Review Request 50464: RANGER-1124: Good coding practices in Ranger recommended by static code analysis

2016-07-27 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50464/#review143880 --- agents-audit/src/main/java/org/apache/ranger/audit/provider/Audit

Re: Review Request 50465: Code changes to avoid potential NPEs and good coding practices in agents-common, tagsync and ranger-tools modules

2016-07-27 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50465/#review143877 --- Ship it! Ship It! - Madhan Neethiraj On July 26, 2016, 9:47

Re: Review Request 50511: RANGER-1124:Code changes to avoid potential NPEs and good coding practices in security-admin, kms, credentialbuilder, jisql, agent-installer, emeddedwebserver

2016-07-27 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50511/#review143827 --- credentialbuilder/src/main/java/org/apache/ranger/credentialapi/C

Re: Review Request 50533: RANGER-1126 : Authorization checks for non existent file/directory should not be recursive in Ranger Hive authorizer

2016-07-27 Thread Sushanth Sowmyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50533/#review143835 --- Ship it! Looks good to me +1 - Sushanth Sowmyan On July 27,

[jira] [Commented] (RANGER-1126) Authorization checks for non existent file/directory should not be recursive in Ranger Hive authorizer

2016-07-27 Thread Ramesh Mani (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396445#comment-15396445 ] Ramesh Mani commented on RANGER-1126: - commit link : http://git-wip-us.apache.org/re

Re: Review Request 50533: RANGER-1126 : Authorization checks for non existent file/directory should not be recursive in Ranger Hive authorizer

2016-07-27 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50533/#review143823 --- Ship it! Ship It! - Madhan Neethiraj On July 27, 2016, 9:25

Review Request 50533: RANGER-1126 : Authorization checks for non existent file/directory should not be recursive in Ranger Hive authorizer

2016-07-27 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50533/ --- Review request for ranger, Madhan Neethiraj and Sushanth Sowmyan. Repository: r

[jira] [Updated] (RANGER-1126) Authorization checks for non existent file/directory should not be recursive in Ranger Hive authorizer

2016-07-27 Thread Ramesh Mani (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Mani updated RANGER-1126: Attachment: RANGER-1126.patch > Authorization checks for non existent file/directory should not be

Review Request 50511: RANGER-1124:Code changes to avoid potential NPEs and good coding practices in security-admin, kms, credentialbuilder, jisql, agent-installer, emeddedwebserver

2016-07-27 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50511/ --- Review request for ranger. Bugs: RANGER-1124 https://issues.apache.org/jira

[jira] [Updated] (RANGER-1123) keyadmin user is not able to make getservice call using rest api service/public/v2/api/service/name

2016-07-27 Thread Velmurugan Periasamy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Velmurugan Periasamy updated RANGER-1123: - Fix Version/s: (was: 0.6.0) 0.7.0 > keyadmin user is not a

[jira] [Commented] (RANGER-1123) keyadmin user is not able to make getservice call using rest api service/public/v2/api/service/name

2016-07-27 Thread Velmurugan Periasamy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395872#comment-15395872 ] Velmurugan Periasamy commented on RANGER-1123: -- Patch committed in master -

Re: Review Request 50501: keyadmin user is not able to make getservice call using rest api service/public/v2/api/service/name

2016-07-27 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50501/#review143733 --- Ship it! Ship It! - Velmurugan Periasamy On July 27, 2016, 1

Re: Review Request 50471: Update Ranger tagsync should handle entity status field in Atlas notifications

2016-07-27 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50471/#review143731 --- Ship it! Ship It! - Madhan Neethiraj On July 27, 2016, 10:59

Review Request 50501: keyadmin user is not able to make getservice call using rest api service/public/v2/api/service/name

2016-07-27 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50501/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan

[jira] [Updated] (RANGER-1123) keyadmin user is not able to make getservice call using rest api service/public/v2/api/service/name

2016-07-27 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1123: - Attachment: RANGER-1123.patch > keyadmin user is not able to make getservice call using rest api

Re: Review Request 50471: Update Ranger tagsync should handle entity status field in Atlas notifications

2016-07-27 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50471/ --- (Updated July 27, 2016, 10:59 a.m.) Review request for ranger and Madhan Neethi

[jira] [Commented] (RANGER-1127) Ranger HA: Handle scenarios for request with X-Forwarded-Server

2016-07-27 Thread Gautam Borad (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395240#comment-15395240 ] Gautam Borad commented on RANGER-1127: -- Committed to master : https://github.com/ap

Re: Review Request 50486: Ranger HA: Handle scenarios for request with X-Forwarded-Server

2016-07-27 Thread Selvamohan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50486/#review143702 --- Ship it! Ship It! - Selvamohan Neethiraj On July 27, 2016, 4

Re: Review Request 50486: Ranger HA: Handle scenarios for request with X-Forwarded-Server

2016-07-27 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50486/#review143701 --- Ship it! Ship It! - Gautam Borad On July 27, 2016, 8:24 a.m.

Review Request 50486: Ranger HA: Handle scenarios for request with X-Forwarded-Server

2016-07-27 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50486/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan

[jira] [Updated] (RANGER-1127) Ranger HA: Handle scenarios for request with X-Forwarded-Server

2016-07-27 Thread Ankita Sinha (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Sinha updated RANGER-1127: - Attachment: RANGER-1127.patch > Ranger HA: Handle scenarios for request with X-Forwarded-Server >

[jira] [Created] (RANGER-1127) Ranger HA: Handle scenarios for request with X-Forwarded-Server

2016-07-27 Thread Ankita Sinha (JIRA)
Ankita Sinha created RANGER-1127: Summary: Ranger HA: Handle scenarios for request with X-Forwarded-Server Key: RANGER-1127 URL: https://issues.apache.org/jira/browse/RANGER-1127 Project: Ranger

[jira] [Assigned] (RANGER-1126) Authorization checks for non existent file/directory should not be recursive in Ranger Hive authorizer

2016-07-27 Thread Ramesh Mani (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Mani reassigned RANGER-1126: --- Assignee: Ramesh Mani > Authorization checks for non existent file/directory should not be r