Sub-project named RocketMQ-JMS has been started

[zhangke]

Hi folks,


We have started a sub-project of RMQ named RocketMQ-JMS at the address 
https://github.com/rocketmq/rocketmq-jms. Our target is to support JMS2.0 
Specification using RMQ as a JMS Provider.  JMS is a protocol used widely in 
java world, providing another low latency and high available implement is a 
valuable and exciting thing.


As there a implement following parts of JMS1.1 Spec has been running stably 
in production environment for about a year, we decide to evolve upon that 
version in the beginning. But along with going deep into more JMS 2.0 details, 
we have divergent opinion about releasing a few versions supporting essential 
JMS features earlier or releasing a milestone version supporting protocol 
fully.  We already have a small discussion in github issue: 
https://github.com/rocketmq/rocketmq-jms/issues/1 . I really appreciate  you 
could give us some opinions.


 Thanks!


 Rick Zhang
 Architect
 ThoughtWorks

[GitHub] incubator-rocketmq issue #37: [ROCKETMQ-38] Some unit tests for rocketmq-rem...

[shroman]

Github user shroman commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/37
  
A suggestion: how about renaming this JIRA issue? This issue is for 
RemotingCommand, _'some'_ is very vague.
We can end up with many more _'some'_ tests in future :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

答复: Rocketmq-Console Deploy Plan

[宋 永忠]

HI:

I am involved in the project is rocketmq-console-ng. Involved in the design 
of the project pre-project planning,

 In the QQ group discussed and decided to services framework to use 
spring-boot + bootstrap +angularjs.

 We have redesigned the UI on this project (thanks to QQ group in 深圳-乌鸦  
contribution code).

Also add a Dashboard module. Some key metrics are shown in the module.




发件人: 唐杰 
发送时间: 2017年1月13日 16:53:09
收件人: dev@rocketmq.incubator.apache.org
主题: Rocketmq-Console Deploy Plan

Hi~
This week we start the rocketmq-console-ng (
https://github.com/rocketmq/rocketmq-console-ng).

We discuss in QQ Groups,and decide to use spring-boot + bootstrap +
angularjs to implements it.
here is the deploy plan(roadmap):
https://github.com/rocketmq/rocketmq-console-ng/blob/master/README.md


Most features have been implemented, but there is still many things to
improve.(for example : UI)
Some feature like (can't show producerList) need to change
incubator-rocketmq's code.In this case we need the committer's help.we will
submit a issue and discuss how to sovle it.

this week we merged one pull request.
https://github.com/rocketmq/rocketmq-console-ng/pull/2

This is just the beginning.we want to make it easy to use.make more and
more people like it,  join us to contribute to this project together.

This is the demo of our project : http://120.55.113.35:8080/index.html

If you have any suggestions please contact us!

[GitHub] incubator-rocketmq pull request #39: [ROCKETMQ-45]Delete hanged consume queu...

[zhouxinyu]

Github user zhouxinyu commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/39#discussion_r95979009
  
--- Diff: 
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -397,11 +397,21 @@ public int deleteExpiredFileByOffset(long offset, int 
unitSize) {
 log.info("physic min offset " + offset + ", logics 
in current mappedFile max offset "
 + maxOffsetInLogicQueue + ", delete it");
 }
+} else if (!mappedFile.isAvailable()) { // Handle hanged 
file.
--- End diff --

Another thing, can we just mark `destroy=true` in `else if` section and 
next `if` will destroy it ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会�� 成选择了不�...

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/41
  
@tain198127 Could you follow other PR[1] style at first

[1] https://github.com/apache/incubator-rocketmq/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #28: [ROCKETMQ-27]Add store commitlog path online

[lizhanhui]

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/28
  
OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...

[wu-sheng]

Github user wu-sheng commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/38
  
@zhouxinyu , just did it manually. It's crazy


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #33: [ROCKETMQ-37] Log output information is...

[lizhanhui]

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/33#discussion_r95966853
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java ---
@@ -53,8 +53,9 @@ public MQClientInstance 
getAndCreateMQClientInstance(final ClientConfig clientCo
 MQClientInstance prev = 
this.factoryTable.putIfAbsent(clientId, instance);
 if (prev != null) {
 instance = prev;
-} else {
 log.warn("Previous MQClientInstance has created for 
clientId:[{}]", clientId);
+} else {
+log.info("new MQClientInstance has created for 
clientId:[{}]", clientId);
--- End diff --

It will be best if using active tune here.  Something like, Returned 
previous MQClientInstance for clientId: ..., Created new MQClientInstance for 
clientId: ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

[zhouxinyu]

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/39
  
I checked ConsumeQueue#correctMinOffset, and you are right this method 
won't work as expected in this situation.

Please @vintagewang @vongosling help review this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #39: [ROCKETMQ-45]Delete hanged consume queu...

[zhouxinyu]

Github user zhouxinyu commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/39#discussion_r95964644
  
--- Diff: 
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -397,11 +397,21 @@ public int deleteExpiredFileByOffset(long offset, int 
unitSize) {
 log.info("physic min offset " + offset + ", logics 
in current mappedFile max offset "
 + maxOffsetInLogicQueue + ", delete it");
 }
+} else if (!mappedFile.isAvailable()) { // Handle hanged 
file.
--- End diff --

When MappedFile has been `shutdown`, no more new holder appear, so the 
`RefCount` will to be 0 soon, so I think maybe it's more graceful :)..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...

[wu-sheng]

Github user wu-sheng commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/38
  
Ok, I will sync this change to my pull requests. And check later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...

[zhouxinyu]

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/38
  
@wu-sheng , sorry for my fault, I made some changes in intelliJ graph 
config page which doesn't reflect to the style file, anyway, I have updated the 
code style file, please check it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Rocketmq-Console

[宋 永忠]

HI:


 I am involved in the project is rocketmq-console-ng. Involved in the 
design of the project pre-project planning,

 In the QQ group discussed and decided to technical framework and a 
function of finishing.

Rocketmq-console-ng is in didapinchegit rocket-console project on the basis 
of optimization and improvement.

 We have redesigned the UI on this project (thanks to QQ group in 深圳-乌鸦  
contribution code).  Replacing the now popular service framework and front-end 
display framework.

Also add a Dashboard module. Some key metrics are shown in the module.



   The project address is

  https://github.com/rocketmq/rocketmq-console-ng).


here is the deploy plan(roadmap):
https://github.com/rocketmq/rocketmq-console-ng/blob/master/README.md


dome:
http://120.55.113.35:8080/index.html

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

[lizhanhui]

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/39
  
> what's the appearance/effect of this BUG?

Reported bug description is consume queue files cannot be automatically 
deleted and took up large portion of disk.

> IMO, it's ok when ConsumeQueue-MappedFile hold failed, this file will be 
released by the last holder, while the empty mapped file will retain in 
MappedFileQueue, but the min consume queue offset will be corrected.

ConsumeQueue#correctMinOffset will not work as expected if consume queue 
file hanged.  Double check the source code to figure out.

> It seems that the only problem is the hanged consume queue only can be 
deleted when restart the broker.

Not only this one. As correcting min offset is also affected, consumer 
client probably experiences long term of "commit log being deleted." before 
consuming progress catches up. There should be additional potential issues. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...

[wu-sheng]

Github user wu-sheng commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/38
  
@zhouxinyu , All travis-ci passed. Why style is still not correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #36: [ROCKETMQ-43] Remove NoWhitespaceBefore...

[wu-sheng]

Github user wu-sheng commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/36#discussion_r95957982
  
--- Diff: 
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -194,7 +197,7 @@ public static void initCommand() {
 private static void initLogback() throws JoranException {
 String rocketmqHome = 
System.getProperty(MixAll.ROCKETMQ_HOME_PROPERTY, 
System.getenv(MixAll.ROCKETMQ_HOME_ENV));
 
-LoggerContext lc = (LoggerContext) 
LoggerFactory.getILoggerFactory();
+LoggerContext lc = 
(LoggerContext)LoggerFactory.getILoggerFactory();
--- End diff --

This file 
https://github.com/apache/incubator-rocketmq/blob/master/style/rmq_codeStyle.xml
 is used. 
In your website doc, just mention about import, but no style-file name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #8: [ROCKETMQ-32] Improve concision - Reuse local v...

[zhouxinyu]

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/8
  
It seems ok, thanks @naughtybear .

Please @vongosling @lizhanhui help review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #28: [ROCKETMQ-27]Add store commitlog path online

[zhouxinyu]

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/28
  
Hi, @lizhanhui , Let's handle this PR in RocketMQ-4.1.0 as a new feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Rocketmq-Console Deploy Plan

[唐杰]

Hi~
This week we start the rocketmq-console-ng (
https://github.com/rocketmq/rocketmq-console-ng).

We discuss in QQ Groups,and decide to use spring-boot + bootstrap +
angularjs to implements it.
here is the deploy plan(roadmap):
https://github.com/rocketmq/rocketmq-console-ng/blob/master/README.md


Most features have been implemented, but there is still many things to
improve.(for example : UI)
Some feature like (can't show producerList) need to change
incubator-rocketmq's code.In this case we need the committer's help.we will
submit a issue and discuss how to sovle it.

this week we merged one pull request.
https://github.com/rocketmq/rocketmq-console-ng/pull/2

This is just the beginning.we want to make it easy to use.make more and
more people like it,  join us to contribute to this project together.

This is the demo of our project : http://120.55.113.35:8080/index.html

If you have any suggestions please contact us!

[GitHub] incubator-rocketmq issue #38: [ROCKETMQ-44] Refactor to avoid duplicated cod...

[wu-sheng]

Github user wu-sheng commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/38
  
@zhouxinyu, seems your style cause this. My intelliJ config is like this:

https://cloud.githubusercontent.com/assets/5441976/21923724/a13662ee-d9b0-11e6-938e-7628f637e7dc.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #33: [ROCKETMQ-37] Log output information is not ac...

[zhouxinyu]

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/33
  
It seems ok, thanks @a2888409 

Please @vongosling @lizhanhui help review this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #36: [ROCKETMQ-43] Remove NoWhitespaceBefore...

[zhouxinyu]

Github user zhouxinyu commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/36#discussion_r95956604
  
--- Diff: 
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -194,7 +197,7 @@ public static void initCommand() {
 private static void initLogback() throws JoranException {
 String rocketmqHome = 
System.getProperty(MixAll.ROCKETMQ_HOME_PROPERTY, 
System.getenv(MixAll.ROCKETMQ_HOME_ENV));
 
-LoggerContext lc = (LoggerContext) 
LoggerFactory.getILoggerFactory();
+LoggerContext lc = 
(LoggerContext)LoggerFactory.getILoggerFactory();
--- End diff --

Also please follow the RocketMQ 
[code-style](http://rocketmq.incubator.apache.org/docs/code-guidelines/)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #40: [ROCKETMQ-40]Ack mode support for consume conc...

[Jaskey]

Github user Jaskey commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/40
  
@zhouxinyu confict has been resolved. please review.

Of course we can discuss the details. Please provide a comment box or 
disucss post for this so that we can follow.

But the commited code should be working fine for some cases , at least for 
my case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会�� 成选择了不�...

[zhouxinyu]

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/41
  
Hi @tain198127, could you please use English in the pr title and commit 
logs?

Also please refer to 
[here](http://rocketmq.apache.org/docs/code-guidelines/) and 
[here](http://rocketmq.apache.org/docs/pull-request/) before send a pull 
request to RocketMQ.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #39: [ROCKETMQ-45]Delete hanged consume queu...

[zhouxinyu]

Github user zhouxinyu commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/39#discussion_r95955059
  
--- Diff: 
store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java ---
@@ -397,11 +397,21 @@ public int deleteExpiredFileByOffset(long offset, int 
unitSize) {
 log.info("physic min offset " + offset + ", logics 
in current mappedFile max offset "
 + maxOffsetInLogicQueue + ", delete it");
 }
+} else if (!mappedFile.isAvailable()) { // Handle hanged 
file.
--- End diff --

I think it's better to add `RefCount` to the if condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #39: [ROCKETMQ-45]Delete hanged consume queue files

[zhouxinyu]

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/39
  
Hi, @lizhanhui , what's the appearance/effect of this BUG?

Let's start from the next round.

IMO, it's ok when ConsumeQueue-MappedFile hold failed, this file will be 
released by the last holder, while the empty mapped file will retain in 
MappedFileQueue, but the min consume queue offset will be corrected.

It seems that the only problem is the hanged consume queue only can be 
deleted when restart the broker.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---