Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130544050
--- Diff:
client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java ---
@@ -27,16 +28,19 @@
public static final String
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/126#discussion_r130558354
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1110,7 +1110,7 @@ private boolean isTheBatchFull(int
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r133344416
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -76,6 +86,24
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/147
While consumeThreadMin is specified by a range,why not add consumeThreadMax
to a range too?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/145
[ROCKETMQ-264] Fix unit test cost too long and exception in unit test
When run mvn test , it cost too much time and some times there is exception
in unit test and the test result is pass
Github user lindzh closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lindzh closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/126#discussion_r132622123
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -45,19 +47,22 @@ public void init() throws Exception
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132393089
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -225,10 +225,13 @@ public void start
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/141#discussion_r132391646
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -70,24 +76,28 @@ public static
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r124972804
--- Diff:
client/src/test/java/org/apache/rocketmq/client/log/ClientLogTest.java ---
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/129
[ROCKETMQ-239]fix query message by time and fix get queue offset by time
When using queryMessageByTime or searchOffsetByTime or resetOffsetByTime ,
DefaultMessageStore return offset
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
+1
Great! This is indeed buggy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/126#discussion_r124758258
--- Diff:
test/src/test/java/org/apache/rocketmq/test/client/consumer/pull/PullSizeTest.java
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/99
Very pleased to see your contribution.But could you please create an issue
at
https://issues.apache.org/jira/browse/ROCKETMQ/?selectedTab=com.atlassian.jira.jira-projects-plugin:issues
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
Thanks for vsair's advice to get more familiar with the apache way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/97
fix consumeTimestamp and wrong consumeTimestamp exception message
When I want to consume message,I use the following code,
```
consumer.setConsumeFromWhere
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/10
add batch broadcast arc and schedule example document
Add batch message,broadcast receving,simple message and ordered message
example.
and add deploy and architecture document
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/141#discussion_r130553480
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -61,7 +68,7 @@ public static MQProducer
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/143
Thanks for contribution. As force delete may cause message lost,how about
add a warnning in command help? And also add a monitor disk usage tool command
for check.
---
If your project
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/150
Thanks for contribution.
Please add a jira issue and modify the pr title to make it complete
---
If your project is set up for it, you can reply to this email and have your
reply
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r116140905
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/logback/RocketmqLogbackAppender.java
---
@@ -0,0 +1,184
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r116141459
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/log4j2/RocketmqLog4j2Appender.java
---
@@ -0,0 +1,232
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/101
readme has ben removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/101
@lizhanhui ,When we print the log to rocketmq provided for big data
processing, developers usually need to write their own appender.I think this is
very ordinary.Why not provide them
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/101
[ROCKETMQ-194] log appender support
As Rocketmq is widely used,A log appender is also necessary.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user lindzh closed the pull request at:
https://github.com/apache/incubator-rocketmq-externals/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/21
moved to rocketmq
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r116638805
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r116641020
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r116641839
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/22
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/120#discussion_r123936939
--- Diff: client/pom.xml ---
@@ -37,13 +37,31 @@
${project.groupId}
rocketmq-common
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/126
[ROCKETMQ-231] fix pull consumer pull result size
When using PullConsumer pull message by default result size is 32,and
messages is more than 32 in a queue,but broker always returns 31
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/117#discussion_r120603647
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
---
@@ -39,7 +39,7 @@
public
Github user lindzh closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user lindzh reopened a pull request:
https://github.com/apache/incubator-rocketmq/pull/120
[ROCKETMQ-224] add rocketmq client log4j2 logging support
When using RocketMQ client,we can only using logback or log4j for logging.
If we using log4j2,there is no client log.
You
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/120
[ROCKETMQ-224] add rocketmq client log4j2 logging support
When using RocketMQ client,we can only using logback or log4j for logging.
If we using log4j2,there is no client log.
You can
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/21
add log appender support
As Rocketmq is widely used,a log appender is also needed
You can merge this pull request into a Git repository by running:
$ git pull https
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/170
No Code change,and this pr will close.
---
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/168
Fix System.out.printf throws UnknownFormatConversionException
### What is the purpose of the change
When using mqadmin command printmsg to print retry topic msgs,it throw
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/169
[ROCKETMQ-292]Delete system.exit in MQAdminStartup
### What is the purpose of the change
When using MQAdminStartup in a java process,some args problem may cause
MQAdminStartup
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/148
Agree,there is no need to add unit test for this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r135431420
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -97,54 +110,46 @@ public MessageExtBrokerInner
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r135436434
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -43,15 +43,24 @@
private SocketAddress
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r135436908
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -76,6 +86,24
Github user lindzh closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/145
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/158#discussion_r135681629
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java ---
@@ -257,4 +268,28 @@ public static Options
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/158
After merge develop branch,all checks will pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134974332
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -201,177 +229,143 @@ public void
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134974719
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/BrokerControllerTest.java ---
@@ -37,16 +37,14 @@
*/
@Test
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134975634
--- Diff:
client/src/test/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsitentHashTest.java
---
@@ -92,9 +92,9
52 matches
Mail list logo
