Re: [Discuss] Start release process 0.9.3

FWIW, I agree with Harbs. Enough time has passed and changes have been made that it is time to try making Jewel dependent on Basic so we can see in code (not words) what the problems are with doing that. My 2 cents, -Alex On 9/2/18, 3:10 PM, "Carlos Rovira" wrote: Hi, I'm

Re: royale-extras and the royale-typedefs Maven build

Hi Harbs, Can you take the patched google_maps_api_v3_11.js from a local royale-typedefs build or maybe from apacheroyaleci and commit it to royale-extras? I don't want to deal with the technicalities of whether I can commit to royale-extras from my employer's perspective. Then you should

Re: [Discuss] Start release process 0.9.3

Hi, I'm mostly done...well, there' still lots of things to do...but, I must cut on a point. Harbs, for my experience, I had to rewrite many things in the copied code from Basic (as I predicted). If you find a class in Jewel called XYZ.as. that class will share some percentage of code with

Re: [Discuss] Start release process 0.9.3

Harbs, In case of conflicts with Networks I did the same. If you can invest time on finishing this up - that would be better for me. Because I will be able to invest my time later for making release itself. Thanks, Piotr On Sun, Sep 2, 2018, 11:37 PM Harbs wrote: > FYI, there were a lot of

Re: [Discuss] Start release process 0.9.3

FYI, there were a lot of conflicts in Network related to AMF. I Made the assumption that the code in develop was the most up-to-date code. I’m not sure my assumption was correct. Those who worked on the code, please check my merges there… Thanks, Harbs > On Sep 3, 2018, at 12:34 AM, Harbs

Re: [Discuss] Start release process 0.9.3

I’m done for the night and I pushed what I’ve done so far. Currently everything builds with the exception of Jewel. Jewel List code is not compatible with the view changes done by Alex. I will work on resolving that in the morning if no-one gets to it before me. I made Jewel dependent on Basic

Re: [Discuss] Start release process 0.9.3

Cool! Let's wait than what Harbs gives us with his merge effort. Thanks, Piotr On Sun, Sep 2, 2018, 10:41 PM Carlos Rovira wrote: > Hi Piotr, > I reduced my list to only make some final touches in ComboBox and DateField > popups (responsive/classic visuals) that I should finish in the next few

Re: [Discuss] Start release process 0.9.3

Hi Piotr, I reduced my list to only make some final touches in ComboBox and DateField popups (responsive/classic visuals) that I should finish in the next few hours. Other points two points I want to address will be left out of this release. So I can focus on release by tomorrow morning El

Re: [Discuss] Start release process 0.9.3

Carlos, Do you think you will finish in the next 1-2 days those changes and make stop till release or better switch to branch with new features ? Thanks, Piotr niedz., 2 wrz 2018 o 21:41 Carlos Rovira napisał(a): > One more reason, is that I'm now making changes. Making such update over >

Re: [Discuss] Start release process 0.9.3

One more reason, is that I'm now making changes. Making such update over develop could make get stuck with some important work I already didn't stabilize to commit. El dom., 2 sept. 2018 a las 21:39, Carlos Rovira () escribió: > Hi Harbs, > > I insist that is better, to push to the branch so I

Re: [Discuss] Start release process 0.9.3

Hi Harbs, I insist that is better, to push to the branch so I can compare between develop and your branch. otherwise will be more difficult for me to get differences and patch them. Once I make the fixes, that is pretty sure I'll have to do, I can merge it directly or wait to others that would

Re: Increased size of the framework

Ok, I was not aware of what artifact is really as I didn't see it never. Only talk about what you report thanks El dom., 2 sept. 2018 a las 21:27, Piotr Zarzycki (< piotrzarzyck...@gmail.com>) escribió: > How are you going to remove it ? It is not present in the repository. It > appears after

Re: [Discuss] Start release process 0.9.3

Hi Harbs, I will wait for your branch and take a look into that as well. Thanks, Piotr niedz., 2 wrz 2018 o 20:36 Harbs napisał(a): > I hope to be able to push tonight. > > I’m pretty close, but there’s still some issues with the merge. > > Once I push, you can look at what I did and comment.

Re: Increased size of the framework

How are you going to remove it ? It is not present in the repository. It appears after build. niedz., 2 wrz 2018 o 20:09 Carlos Rovira napisał(a): > So, I think it's ok to remove it right? > > thanks for take a look > > Carlos > > El dom., 2 sept. 2018 a las 15:09, Yishay Weiss () > escribió: >

Re: [Discuss] Start release process 0.9.3

I hope to be able to push tonight. I’m pretty close, but there’s still some issues with the merge. Once I push, you can look at what I did and comment. :-) Harbs > On Sep 2, 2018, at 9:12 PM, Carlos Rovira wrote: > > Ok Harbs, > > I'll prefer, you say here you have it ok. So me and others

Re: [Discuss] Start release process 0.9.3

Ok Harbs, I'll prefer, you say here you have it ok. So me and others could build localy and test as most projects as possible, to detect that all is ok. As I said there's code on Jewel changed that will not work in the current state, and I think I'm the only one that knows what's working and what

Re: Increased size of the framework

So, I think it's ok to remove it right? thanks for take a look Carlos El dom., 2 sept. 2018 a las 15:09, Yishay Weiss () escribió: > I think it happens when the JVM crashes for whatever reason (we’ve had > some out of memory problems). It shouldn’t be there if the build was > successful. > > >

Re: [Discuss] Start release process 0.9.3

I’m working on a new merge. I’m moving some classes back to Basic to reduce the number of conflicts. Let’s see if my attempt works any better. If it works well, I’ll push my branch when it’s done… On my first attempt to merge, I see lots of conflicts related to AMF. I’m not sure which is the

Re: [Discuss] Start release process 0.9.3

The problem is than far beyond the merge problems, code was changed in some classes (at least in Jewel I see changes), to get compiling. This make more difficult to be confident with the actual code I integration branch since we must to know what code is the latest, and see if code was not changed

Re: [Discuss] Start release process 0.9.3

HI Piotr, sorry about that, I can't never imagine that a normal var in maven (i.e: ${someVar}), would break something else in the other side of the world (i.e: lexUnit test). It's like if we insert a private var someVar:String in AS3 and this break a build. This one is very difficult, and I

RE: Increased size of the framework

I think it happens when the JVM crashes for whatever reason (we’ve had some out of memory problems). It shouldn’t be there if the build was successful. From: Piotr Zarzycki Sent: Sunday, September 2, 2018 2:36:01 PM To: dev@royale.apache.org Subject: Re:

Re: [Discuss] Start release process 0.9.3

I meant here DataContainerView and DataContainerBase missing methods there. Thanks, Piotr niedz., 2 wrz 2018 o 14:24 Harbs napisał(a): > I’m not sure what you are referring to. Do you mean the merge conflicts? > > I’m pretty sure there is more than one class which has conflicts. Carlos > is

Re: [Discuss] Start release process 0.9.3

I’m not sure what you are referring to. Do you mean the merge conflicts? I’m pretty sure there is more than one class which has conflicts. Carlos is right that there could be lot of classes which need resolution, but I’m not sure what the right answer is. We might need to go through all the

Re: [Discuss] Start release process 0.9.3

Hi Carlos, Please let's do not make such drastical steps. It looks like Harbs found where the issue is. Let's make the changes and see whether it is working. Harbs can you do this? Thanks, Piotr On Sun, Sep 2, 2018, 12:42 PM Harbs wrote: > To tell you the truth, I don’t understand exactly

Jenkins build is back to normal : royale-asjs #1264

See

Jenkins build is back to normal : royale-asjs_jsonly #1453

See

Re: [Discuss] Start release process 0.9.3

To tell you the truth, I don’t understand exactly how the tokens are working, but the $ prefix definitely breaks it. I’m guessing the brackets is an XML construct recognized as a variable in things like E4X. Harbs > On Sep 2, 2018, at 1:30 PM, Carlos Rovira wrote: > > Hi Habs, > > El dom.,

RE: Increased size of the framework

Looks like it’s a dump file [1] https://fileinfo.com/extension/mdmp From: Piotr Zarzycki Sent: Friday, August 24, 2018 10:10:42 AM To: dev@royale.apache.org Subject: Increased size of the framework Hi Carlos, I just looked into the downloaded latest build

Re: [Discuss] Start release process 0.9.3

El dom., 2 sept. 2018 a las 12:22, Harbs () escribió: > It looks like the merge from MXRoyale has problems. > > DataContainerView has none of the changes that were done in MXRoyale > (among other things) > > DataContainerView got all the methods that were originally in > DataContainerBase, but

Re: [Discuss] Start release process 0.9.3

El dom., 2 sept. 2018 a las 11:59, Harbs () escribió: > Now that I’m able to compile, I started testing the current state… > > Why was DataContainerBase changed? > > DataContainerBase.removeAllItemRenderers no longer exists. > DataItemRendererFactoryForArrayList.dataProviderChangeHandler calls >

Re: [Discuss] Start release process 0.9.3

Hi Habs, El dom., 2 sept. 2018 a las 11:42, Harbs () escribió: > I found the problem. > > Carlos, I don’t know why you changed the tokens in the config files, but > changing them made them unrecognized and caused the FlexUnit tests to fail. > > I thought the tokens you refer was not correctly

Re: [Discuss] Start release process 0.9.3

It looks like the merge from MXRoyale has problems. DataContainerView has none of the changes that were done in MXRoyale (among other things) DataContainerView got all the methods that were originally in DataContainerBase, but those changes did not survive the merge… Fun, fun… ;-) Harbs >

Re: [Discuss] Start release process 0.9.3

Now that I’m able to compile, I started testing the current state… Why was DataContainerBase changed? DataContainerBase.removeAllItemRenderers no longer exists. DataItemRendererFactoryForArrayList.dataProviderChangeHandler calls dataGroup.removeAllItemRenderers() on a List which now fails with

Re: [Discuss] Start release process 0.9.3

I found the problem. Carlos, I don’t know why you changed the tokens in the config files, but changing them made them unrecognized and caused the FlexUnit tests to fail. I reverted those changes. I don’t know what effects these changes had on the Maven build. Harbs > On Sep 2, 2018, at

Re: [Discuss] Start release process 0.9.3

Both the develop branch and the merge branch are failing while building Basic. The tests are failing: The revert-refactor branch (which I have been mostly using lately) compiles with no issues. [echo] Compiling FlexUnitRoyaleApplication.swf [echo] ROYALE_HOME: /Apache/royale-asjs