[jira] [Commented] (S2GRAPH-243) Limit bug on 'graph/getEdges'
[ https://issues.apache.org/jira/browse/S2GRAPH-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676271#comment-16676271 ] Heewon Jung commented on S2GRAPH-243: - [~steamshon] I using hbase 1.2.0. and cdh version is 5.12.0. > Limit bug on 'graph/getEdges' > -- > > Key: S2GRAPH-243 > URL: https://issues.apache.org/jira/browse/S2GRAPH-243 > Project: S2Graph > Issue Type: Bug > Components: s2core >Affects Versions: 0.2.0 >Reporter: Daewon Jeong >Priority: Minor > > A limit bug was reported in the getEdges API in the following link. > link: > [https://lists.apache.org/thread.html/57ca77109bf321fcff7be616b5e07eb320f5dfcd81e700ba77e6ffd2@%3Cusers.s2graph.apache.org%3E] > Bug Description: > Using version 0.2.0 > Enter data as example.sh > Three "friends" in "Elmo" (offset: 0, limit: 3) => Only two results are > displayed. > > If offset is 0, 2 results are returned. > [image > link|https://user-images.githubusercontent.com/1182522/47141766-5e456d80-d2fc-11e8-8324-69493e82baa5.png] > > If offset is 1, 3 results are returned. > [image > link|https://user-images.githubusercontent.com/1182522/47141759-5be31380-d2fc-11e8-9b73-1d51ae0dbc14.png] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (S2GRAPH-243) Limit bug on 'graph/getEdges'
[ https://issues.apache.org/jira/browse/S2GRAPH-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676242#comment-16676242 ] DOYUNG YOON commented on S2GRAPH-243: - [~Heewon] I thought this issue was simple to fix at the first time and created https://github.com/apache/incubator-s2graph/pull/187. I created the unit test to test example.sh, and it passed. I was about to merge this PR but found that actually there is a bug on ColumnPaginationFilter, HBASE-20565. I think If you are using HBase version less than 1.2.6.1, then this PR would fix the initial bug, but if you are using a higher version, then I need some more time to debug to see whether our hbase client(Asynchbase) has a bug or HBase server has a bug. Can you please let me know what version of HBase are you using? > Limit bug on 'graph/getEdges' > -- > > Key: S2GRAPH-243 > URL: https://issues.apache.org/jira/browse/S2GRAPH-243 > Project: S2Graph > Issue Type: Bug > Components: s2core >Affects Versions: 0.2.0 >Reporter: Daewon Jeong >Priority: Minor > > A limit bug was reported in the getEdges API in the following link. > link: > [https://lists.apache.org/thread.html/57ca77109bf321fcff7be616b5e07eb320f5dfcd81e700ba77e6ffd2@%3Cusers.s2graph.apache.org%3E] > Bug Description: > Using version 0.2.0 > Enter data as example.sh > Three "friends" in "Elmo" (offset: 0, limit: 3) => Only two results are > displayed. > > If offset is 0, 2 results are returned. > [image > link|https://user-images.githubusercontent.com/1182522/47141766-5e456d80-d2fc-11e8-8324-69493e82baa5.png] > > If offset is 1, 3 results are returned. > [image > link|https://user-images.githubusercontent.com/1182522/47141759-5be31380-d2fc-11e8-9b73-1d51ae0dbc14.png] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [DISCUSS]: asking about future of s2graph
Hi, Thank you for Justin. I opened discussion on the @private. https://lists.apache.org/thread.html/e2562a2eb8eb68e204d8a76ab1a5e3dc571fe8889cf0723d50d48750@%3Cprivate.s2graph.apache.org%3E If there are no PPMC objections, is it the next step to let our mentor add committers? Thanks, Hwansung 2018년 11월 6일 (화) 오전 5:39, Justin Mclean 님이 작성: > Hi, > > Here is the original discussion [1] on the private list (over 2 years > ago!). I'm surprised these people have kept on with the project. While not > as formal as what some projects do (having a formal VOTE thread), it's up > to each PPMC to decide (and hopefully document) on how to appoint > committers and it looks like the consensus was to add the people discussed. > I suggest you have a discussion on the @private list and if there's no PPMC > objections (seem unlikely) just go ahead and add them as committers perhaps > with an apology for taking so long. > > Thanks, > Justin > > 1. > https://lists.apache.org/thread.html/1160237c8961daa72f45fd87b2b3c3b3185ba8bbb2c05f7982ea0d02@%3Cprivate.s2graph.apache.org%3E > >
Re: [DISCUSS]: asking about future of s2graph
Hi, Here is the original discussion [1] on the private list (over 2 years ago!). I'm surprised these people have kept on with the project. While not as formal as what some projects do (having a formal VOTE thread), it's up to each PPMC to decide (and hopefully document) on how to appoint committers and it looks like the consensus was to add the people discussed. I suggest you have a discussion on the @private list and if there's no PPMC objections (seem unlikely) just go ahead and add them as committers perhaps with an apology for taking so long. Thanks, Justin 1. https://lists.apache.org/thread.html/1160237c8961daa72f45fd87b2b3c3b3185ba8bbb2c05f7982ea0d02@%3Cprivate.s2graph.apache.org%3E
Re: [DISCUSS]: asking about future of s2graph
HI, > I think there are two candidates for the conditions. When discussion potential candidates it best to do so on the private list. What happens if you mention someone publicly and then not vote them in? > In the previous mailing issue, there was a thread to add Hyunsung Jo as > committer, but no action was taken after Voting. Your mentors/PPMC need to add the person the the projects roster, help get their account set up, make sure they have signed an ICLA and welcome them to the community. > We do not know how to do it because we have no experience in adding > committers. Your mentors can help here. Thanks, Justin
HTTP interface integration and unfinished project (s2rest_netty) removal.
S2Graph's main web interface is based on Play! Framework. Key features provided include: - admin api - read/write api (include graph traverse) and known issues: 1. The `s2rest_netty` project is experimental and supports only `graph traverse` API. 2. `s2rest_play` based on Play! Framework. Play! Framework is full stack framework, so it has a lot of dependencies that s2graph does not need. There is also a conflict with byte buddy for patching asynchbase. 3. `GraphQL` is still in the experimental phase and does not yet provide all the functionality. I suggest removing `s2rest_play` and `s2rest_netty` to solve the above problem. Akka HTTP is a stable phase, and the GraphQL web interface is built on Akka HTTP. It would be nice if a full-featured Web Interface would be provided by connecting an existing Web Interface to an implemented GraphQL server. Thank you for your feedback. reference: https://richardimaoka.github.io/blog/hello-world-http-bench/
