Re: HTTP interface integration and unfinished project (s2rest_netty) removal.
I've looked at the features that are available to remove the Play! Framework. I have written my comments for each function groups. - The Admin and Create APIs have yet to integrate many functions into the Play! controller code, so code separation must be preceded in order to move functionality. - The API with the `withWait` postfix of the Edge/Vertex creation API is an API that tells the client whether the request is applied correctly. This is a duplicate API that exists for backward compatibility. - Management routes are suggested to unify API routes with prefixes such as `/admin/?` or `/managment/?`. - Server health_check or Counter related features are not available anymore, so I suggest you exclude them. ## Edge creation ### List of APIs to leave POST/graphs/edges/insert POST/graphs/edges/insertBulk POST/graphs/edges/delete POST/graphs/edges/deleteAll POST/graphs/edges/deleteAllWithOutWait POST/graphs/edges/update POST/graphs/edges/increment POST/graphs/edges/incrementCount POST/graphs/edges/bulk ### List of APIs that should be removed POST/graphs/edges/deleteWithWait POST/graphs/edges/updateWithWait POST/graphs/edges/incrementWithWait POST/graphs/edges/bulkWithWait POST/graphs/edges/insertWithWait ## Edge query ### List of APIs to leave POST/graphs/getEdges POST/graphs/checkEdges ### List of APIs that should be removed POST/graphs/getEdgesGrouped POST/graphs/getEdgesGroupedExcluded POST/graphs/getEdgesGroupedExcludedFormatted GET /graphs/getEdge/:srcId/:tgtId/:labelName/:direction POST/graphs/getEdgesExcluded POST/graphs/getEdgesExcluded/grouped POST/graphs/getEdges/grouped ## Vertex related ### List of APIs to leave POST/graphs/getVertices POST/graphs/vertices/insert POST/graphs/vertices/delete POST/graphs/vertices/deleteAll ### List of APIs that should be removed POST/graphs/vertices/insert/:serviceName/:columnName POST/graphs/vertices/delete/:serviceName/:columnName POST/graphs/vertices/deleteAll/:serviceName/:columnName POST/graphs/vertices/insertWithWait POST/graphs/vertices/deleteWithWait ## Vertex related ### List of APIs to leave POST/graphs/createService GET /graphs/getService/:serviceName GET /graphs/getLabels/:serviceName POST/graphs/createLabel POST/graphs/addIndex GET /graphs/getLabel/:labelName PUT /graphs/deleteLabelReally/:labelName POST/graphs/addProp/:labelName POST/graphs/createServiceColumn PUT /graphs/deleteServiceColumn/:serviceName/:columnName POST/graphs/addServiceColumnProp/:serviceName/:columnName POST/graphs/addServiceColumnProps/:serviceName/:columnName GET /graphs/getServiceColumn/:serviceName/:columnName POST/graphs/createHTable GET /admin/labels/:serviceName POST/graphs/copyLabel/:oldLabelName/:newLabelName POST/graphs/renameLabel/:oldLabelName/:newLabelName POST/graphs/swapLabels/:leftLabelName/:rightLabelName POST/graphs/updateHTable/:labelName/:newHTableName PUT /graphs/loadCache ## Experiment related ### List of API to leave POST/graphs/experiment/:accessToken/:experimentName/:uuid POST/graphs/experiments ## publish (deprecated) ### List of APIs that should be removed POST/publish/:topic POST/publishOnly/:topic Health Check(deprecated) ### List of APIs that should be removed GET /health_check.html PUT /health_check/:isHealthy ## Counter related (deprecated) ### List of APIs that should be removed POST/counter/v1/:service/:action GET /counter/v1/:service/:action PUT /counter/v1/:service/:action PUT /counter/v1/:service/:action/prepare DELETE /counter/v1/:service/:action GET /counter/v1/:service/:action/ranking DELETE /counter/v1/:service/:action/ranking GET /counter/v1/:service/:action/:item PUT /counter/v1/:service/:action/:item POST/counter/v1/mget I look forward to feedback.
Re: Integrate s2graph documents into projects
I believe that the only reason current document resides on the gitbook was that person who wrote the documentation(me) did not know another way. If we can reference other project and find out the better way, I would be happy to help. I agree that maintaining documentation on the same repository as source code would be better way, but I do not know how to start. It would be great if you can show around how we can do this. On Wed, Nov 7, 2018 at 12:23 PM daewon wrote: > How to use s2grpah can be found in the repository's README.md file and in > the Gitbook (https://steamshon.gitbooks.io/s2graph-book/content/) > > I think there are some problems with how to use s2graph. > 1. The README.md file does not describe all the APIs. > ex) Absence of admin API description > > 2. The Gitbook does not support changes based on the release version. > ex) No description for new API: Vertex search query > > For these reasons, I think it would be nice if the documentation source is > in the same repository as the code source. > > I've looked at a similar example, and Python seems to be using it this way. > ex) https://github.com/python/cpython/tree/master/Doc > > I think s2graph is better to manage documents like Python in the source > code repository. > > I look forward to feedback. >
Integrate s2graph documents into projects
How to use s2grpah can be found in the repository's README.md file and in the Gitbook (https://steamshon.gitbooks.io/s2graph-book/content/) I think there are some problems with how to use s2graph. 1. The README.md file does not describe all the APIs. ex) Absence of admin API description 2. The Gitbook does not support changes based on the release version. ex) No description for new API: Vertex search query For these reasons, I think it would be nice if the documentation source is in the same repository as the code source. I've looked at a similar example, and Python seems to be using it this way. ex) https://github.com/python/cpython/tree/master/Doc I think s2graph is better to manage documents like Python in the source code repository. I look forward to feedback.
Re: HTTP interface integration and unfinished project (s2rest_netty) removal.
Thank you for your feedback. I want to integrate the HTTP interface with minimal code changes. To do this, i will take a little look at the list of tasks needed and create an issue through JIRA. 2018년 11월 6일 (화) 오후 6:25, DO YUNG YOON 님이 작성: > Hi deawon. > > Thanks for bringing this issue up. > > I agree with your suggestions since I got pretty frustrated when I was > working on S2GRAPH-243(I modify one line of code and had to re-package > project since dev mode on s2rest_play is not working because of classpath > issue). > > I am more than happy to work on this since the current dev environment has > been broken. > > > > On Mon, Nov 5, 2018 at 6:15 PM daewon wrote: > > > S2Graph's main web interface is based on Play! Framework. > > > > Key features provided include: > > - admin api > > - read/write api (include graph traverse) > > > > and known issues: > > 1. The `s2rest_netty` project is experimental and supports only `graph > > traverse` API. > > 2. `s2rest_play` based on Play! Framework. > > Play! Framework is full stack framework, so it has a lot of > > dependencies that s2graph does not need. > > There is also a conflict with byte buddy for patching asynchbase. > > 3. `GraphQL` is still in the experimental phase and does not yet > provide > > all the functionality. > > > > I suggest removing `s2rest_play` and `s2rest_netty` to solve the above > > problem. > > > > Akka HTTP is a stable phase, and the GraphQL web interface is built on > Akka > > HTTP. > > It would be nice if a full-featured Web Interface would be provided by > > connecting an existing Web Interface to an implemented GraphQL server. > > > > Thank you for your feedback. > > > > reference: https://richardimaoka.github.io/blog/hello-world-http-bench/ > > >
Re: HTTP interface integration and unfinished project (s2rest_netty) removal.
Hi deawon. Thanks for bringing this issue up. I agree with your suggestions since I got pretty frustrated when I was working on S2GRAPH-243(I modify one line of code and had to re-package project since dev mode on s2rest_play is not working because of classpath issue). I am more than happy to work on this since the current dev environment has been broken. On Mon, Nov 5, 2018 at 6:15 PM daewon wrote: > S2Graph's main web interface is based on Play! Framework. > > Key features provided include: > - admin api > - read/write api (include graph traverse) > > and known issues: > 1. The `s2rest_netty` project is experimental and supports only `graph > traverse` API. > 2. `s2rest_play` based on Play! Framework. > Play! Framework is full stack framework, so it has a lot of > dependencies that s2graph does not need. > There is also a conflict with byte buddy for patching asynchbase. > 3. `GraphQL` is still in the experimental phase and does not yet provide > all the functionality. > > I suggest removing `s2rest_play` and `s2rest_netty` to solve the above > problem. > > Akka HTTP is a stable phase, and the GraphQL web interface is built on Akka > HTTP. > It would be nice if a full-featured Web Interface would be provided by > connecting an existing Web Interface to an implemented GraphQL server. > > Thank you for your feedback. > > reference: https://richardimaoka.github.io/blog/hello-world-http-bench/ >
Re: Podling Report Reminder - November 2018
Thanks for signing off Sergio On Sat, Nov 3, 2018 at 11:07 AM Sergio Fernández wrote: > signed-off, thanks! > > On Fri, Nov 2, 2018, 11:36 DO YUNG YOON > > I noticed that the report has not been on wiki, so I just moved what > > deawon wrote here to https://wiki.apache.org/incubator/November2018 > > > > > > On Fri, Oct 26, 2018 at 12:08 AM Sergio Fernández > > wrote: > > > > > LGTM > > > > > > The only tooic I may extend it a bit would be the graduation: It's been > > > almost three years incubating. I don't see how the podling could > graduate > > > given the current shape. Should be discuss alternatives? I'd love to > see > > > that captured in the report. > > > > > > > > > On Thu, Oct 25, 2018, 03:01 daewon wrote: > > > > > > > Hi folks. > > > > > > > > Here I try to write the report for. > > > > > > > > Please feel free to comment. > > > > > > > > -- > > > > > > > > S2Graph > > > > > > > > S2Graph is a distributed and scalable OLTP graph database built on > > Apache > > > > HBase to support fast traversal of extremely large graphs. > > > > > > > > S2Graph has been incubating since 2015-11-29. > > > > > > > > Three most important issues to address in the move towards > graduation: > > > > > > > > 1. Make a third release. > > > > 2. Attract more users and contributors. > > > > 3. Build the developer community in both size and diversity. > > > > > > > > Any issues that the Incubator PMC (IPMC) or ASF Board wish/need to > > > beaware > > > > of? > > > > > > > > None > > > > > > > > How has the community developed since the last report? > > > > > > > > * In ACNA 2018, we announced S2Graph as the title of the Apache > > > > S2Graph(incubating) with the build data management platform and > > audience > > > > targeting online application system using Graph Database. > > > > - > > > > > > > > > > https://apachecon.dukecon.org/acna/2018/#/scheduledEvent/835a6adcab1ce83a0 > > > > > > > > * There were some questions from the community about the > introduction > > > of > > > > S2Graph. > > > > > > > > How has the project developed since the last report? > > > > > > > > * We have received some inquiries from the community and created an > > > issue > > > > that does not solve it yet. > > > > - 5 issues are created and 0 of them are resolved since the last > > > > report(Sep 2018). > > > > > > > > How would you assess the podling's maturity? > > > > Please feel free to add your own commentary. > > > > > > > > [ ] Initial setup > > > > [ ] Working towards first release > > > > [X] Community building > > > > [ ] Nearing graduation > > > > [ ] Other: > > > > > > > > Date of last release: > > > > > > > > 2017-08-26 > > > > > > > > When were the last committers or PPMC members elected? > > > > > > > > None > > > > > > > > Signed-off-by: > > > > > > > > [ ](s2graph) Andrew Purtell > > > > Comments: > > > > [ ](s2graph) Seetharam Venkatesh > > > > Comments: > > > > [ ](s2graph) Sergio Fernández > > > > Comments: > > > > > > > > > >
