Review Request 64097: SENTRY-2072: log4j2 dependencies brought by Hive 2 are causing conflicts with Sentry log4j

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64097/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2072

Re: Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63974/#review191762 --- Ship it! Looks good. - kalyan kumar kalvagadda On Nov. 21,

Re: Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63985/#review191746 --- Ship it! looks good - kalyan kumar kalvagadda On Nov. 22,

Re: Review Request 63985: SENTRY-2056: Display test-patch.py output on the standard console to see progress on Jenkins

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63985/#review191744 --- || visible in terminal || visible in file || existing

Re: Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63974/#review191686 --- Code looks good overall. I have some questions/clarifications

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63878/#review191657 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 21,

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

> On Nov. 16, 2017, 10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/PermissionsMigrationToolCommon.java > > Lines 236 (patched) > >

Review Request 63996: SENTRY-2059: Fix the tests to use transaction listeners for handling HMS Notifications.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63996/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2059

Re: Review Request 63993: SENTRY-2046: Create a full snapshot if AUTHZ_PATHS_SNAPSHOT_ID is empty, even if HMS and Sentry Notifications are in sync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191615 ---

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/ --- (Updated Nov. 21, 2017, 12:27 a.m.) Review request for sentry, Na Li and

Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2034

Re: Review Request 63928: SENTRY-2054: Unit tests must create temporary files under the Maven target directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63928/#review191438 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 17,

Re: Review Request 63925: SENTRY-1640: Implement HMS Notification barrier on the HMS plugin side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63925/#review191394 --- Fix it, then Ship it! please fix the minor comment and push

Re: Review Request 63896: SENTRY-2052: Reduce TestSentryStore time by setting transaction retries to 1 and other refactors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/#review191364 ---

Re: Review Request 63886: SENTRY-2047: isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63886/#review191272 --- Ship it! make sure that tests pass. - kalyan kumar kalvagadda

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63856/#review191252 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 16,

Re: Review Request 63762: [solr] SENTRY-2042 Support file based Sentry provider for Solr plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63762/#review190951 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 13,

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63647/#review190589 --- What is the issue we are observing when this id is not set? -

Re: Review Request 63335: SENTRY-2018: Remove SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/ --- (Updated Nov. 9, 2017, 2:58 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 63646: SENTRY-2035: Metrics should move to destination atomically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63646/#review190382 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 7,

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review190372 --- Ship it! Plesae address the one last comment that I have and

Re: Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop to use SentryMetastorePostEventListenerNotificationLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/ --- (Updated Nov. 7, 2017, 6:17 p.m.) Review request for sentry, Alexander

Re: Review Request 63509: SENTRY-2028: Avoid datanucleus to create/update database schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63509/ --- (Updated Nov. 3, 2017, 10:52 p.m.) Review request for sentry, Alexander

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review190068 --- There are couple of missing pieces 1. AuditLogger does not

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/Admin.java > > Lines 26 (patched) > > > > > > Here name Admin

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/Admin.java > > Lines 26 (patched) > > > > > > Here name Admin

Re: Review Request 63488: SENTRY-2029: Unit test fails consistently for org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63488/#review190027 --- Ship it! Look's like adeeper issue. please proceed with the

Review Request 63509: SENTRY-2028: Avoid datanucleus to create/update database schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63509/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, Na Li, and Sergio

Re: Review Request 63488: SENTRY-2029: Unit test fails consistently for org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63488/#review189956 --- Let's not revert it the change. let's try to figure the root

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review189849 --- Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 1,

Review Request 63335: SENTRY-2018: Remove SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63335/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2018

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/#review189823 --- These are my comments in initial pass. I'm still reviewing the

Re: Review Request 63424: SENTRY-2024: Specify Char Set for AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63424/#review189827 --- Your description here is not in-line with the comments in jira.

Re: Review Request 63433: SENTRY-2026: Bump Hadoop version from 2.7.2 to 2.7.4

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63433/#review189759 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 30,

Re: Review Request 63308: SENTRY-2020: Fix testConsumeCycleWithInsufficientPrivileges test failure in kafka e2e tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63308/ --- (Updated Oct. 26, 2017, 5:26 p.m.) Review request for sentry, Colm O

Re: Review Request 63308: SENTRY-2020: Fix testConsumeCycleWithInsufficientPrivileges test failure in kafka e2e tests.

> On Oct. 26, 2017, 3:21 p.m., Sergio Pena wrote: > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java > > Lines 209 (patched) > > > > > > typo:

Re: Review Request 63309: SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63309/ --- (Updated Oct. 26, 2017, 2:03 p.m.) Review request for sentry, Colm O

Review Request 63309: SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63309/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2017

Review Request 63308: SENTRY-2020: Fix testConsumeCycleWithInsufficientPrivileges test failure in kafka e2e tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63308/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2020

Re: Review Request 63185: SENTRY-2013 - Align the SentryGenericServiceClient and SentryPolicyServiceClient a bit more closely

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63185/#review188994 --- Ship it! Looks good to me. There is a kafka test failure which

Review Request 63178: SENTRY-1989: Bump Kafka version from 0.9 to 0.11

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63178/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-1989

Re: Review Request 63046: SENTRY-1980: Move the hive-authz2 HMS client filtering implementation into the sentry-binding-hive module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63046/#review188781 --- Ship it! Looks good to me. You brought the classes from the

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63160/#review188735 --- I'm fine with bumping up the jetty version but the only concern

Re: Review Request 51445: SENTRY-1453: Enable passing sentry client cache configs from kafka conf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51445/#review188587 --- Ship it! Ship It! - kalyan kumar kalvagadda On Aug. 30,

Re: Review Request 63047: SENTRY-1994: Bump Shiro dependency version to 1.4.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63047/#review188302 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 16,

Re: Review Request 63069: SENTRY-1996 - Rename Sqoop SentryAuthorizationHander

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63069/#review188299 --- Fix it, then Ship it! Please adddress the commit comment and

Re: Review Request 62902: SENTRY-1978: Move the hive-authz2 grant/revoke implementation into the sentry-binding-hive module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62902/#review188197 --- Ship it! Segio, I'm good with the changes. It's just

Re: Review Request 62951: SENTRY-1231: Sentry doesn't secure index location uri, when do "CREATE INDEX LOCATION ''/uri"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62951/#review188149 ---

Re: Review Request 62983: SENTRY-1986: Fix NPE on createGrantTask from SentryHiveAuthorizationTaskFactoryImpl.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62983/#review188145 ---

Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62979/#review188143 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 16,

Re: Review Request 62992: SENTRY-1990: Use same hadoop.version to hadoop-aws dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62992/#review188133 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 13,

Re: Review Request 62950: SENTRY-1981: Bump codehale metrics version to latest 3.0.2 version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62950/#review187864 --- Ship it! Ship It! - kalyan kumar kalvagadda On Oct. 12,

<    1   2   3   4   5