Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207566 --- Ship it! Ship It! - Na Li On Aug. 17, 2018, 9:47 p.m.,

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207564 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207563 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207562 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Aug. 17, 2018, 9:47 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 8:18 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 255 (patched) > > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207544 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 8:18 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 255 (patched) > > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207538 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207532 --- Ship it! Ship It! - Sergio Pena On Aug. 17, 2018, 7:01

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Aug. 17, 2018, 7:01 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 5:12 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > > Lines 135 (patched) > > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:01 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 266 (patched) > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:01 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 244 (patched) > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:01 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 244 (patched) > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207513 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:01 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 244 (patched) > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207504 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:01 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > > Lines 23 (patched) > > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:01 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 250-258 (patched) > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:01 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 244 (patched) > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:01 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 244 (patched) > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207496 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Aug. 17, 2018, 2:01 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Aug. 17, 2018, 1:08 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Aug. 17, 2018, 1:07 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Aug. 17, 2018, 1:03 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 16, 2018, 8:26 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java > > Line 588 (original), 588 (patched) > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 17, 2018, 3:20 a.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > > Lines 144 (patched) > > > > > > I

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207474 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 16, 2018, 8:18 p.m., Sergio Pena wrote: > > What's the expected performance improvement we're getting with this? Have > > you run tests to check how much time we're saving? > > Arjun Mishra wrote: > Hey Sergio I did benchmark tests, see first comment in the ticket: >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 16, 2018, 8:26 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java > > Line 588 (original), 588 (patched) > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 16, 2018, 8:26 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java > > Line 588 (original), 588 (patched) > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

> On Aug. 16, 2018, 8:18 p.m., Sergio Pena wrote: > > What's the expected performance improvement we're getting with this? Have > > you run tests to check how much time we're saving? Hey Sergio I did benchmark tests, see first comment in the ticket:

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207432 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207430 --- What's the expected performance improvement we're getting with

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles() and update SentryGenericPolicyProcessor to retrieve roles to group mapping in a single transaction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Aug. 16, 2018, 7:55 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Aug. 15, 2018, 7:37 p.m., Na Li wrote: > > Should you update list_sentry_roles_by_group in > > SentryGenericPolicyProcessor.java as well? so it takes only one transaction > > to list roles by group when group is null or a list of group names. New patch should reflect that. Thanks. -

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Aug. 16, 2018, 7:55 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review207346 --- Should you update list_sentry_roles_by_group in

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Aug. 15, 2018, 12:26 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Jan. 4, 2018, 12:26 a.m.) Review request for sentry, Alexander

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 19, 2017, 9:22 p.m., Steve Moist wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 263 (patched) > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 19, 2017, 9:22 p.m., Steve Moist wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Lines 263 (patched) > > > > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194180 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194174 --- Ship it! Ship It! - Vadim Spector On Dec. 19, 2017, 8:04

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Dec. 19, 2017, 8:04 p.m.) Review request for sentry, Alexander

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > >

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194080 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194079 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Dec. 18, 2017, 4:36 p.m.) Review request for sentry, Alexander

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- (Updated Dec. 18, 2017, 4:34 p.m.) Review request for sentry, Alexander

Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar