Re: Review Request 67747: SENTRY-2282: Remove hive-authzv2 binding and tests modules completely

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67747/#review205425 --- Did you make sure to see of these tests can be moved to

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67646/#review205426 ---

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205423 ---

Re: Review Request 67747: SENTRY-2282: Remove hive-authzv2 binding and tests modules completely

> On June 27, 2018, 12:55 p.m., kalyan kumar kalvagadda wrote: > > Did you make sure to see of these tests can be moved to sentry-binding-hive? Yes, I did. There are no new tests, so it is safely to remove. - Sergio --- This is an

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

> On June 27, 2018, 1:08 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 230 (patched) > > > >

Re: Review Request 67747: SENTRY-2282: Remove hive-authzv2 binding and tests modules completely

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67747/#review205441 --- was the hive-authz copied from hive-authzv2? If not, it is better

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

> On June 27, 2018, 1:08 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 230 (patched) > > > >

Re: Review Request 67747: SENTRY-2282: Remove hive-authzv2 binding and tests modules completely

> On June 27, 2018, 3:18 p.m., Na Li wrote: > > was the hive-authz copied from hive-authzv2? If not, it is better to save > > hive-authzv2 in a backup branch just in case, and then remove it. All the hive-authzv2 is already on hive-authz. The copy on on branch-2 too, so there is no need to

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/#review205452 ---

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

> On June 27, 2018, 12:50 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHmsEvent.java > > Lines 224-233 (patched) > > > > > > As

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

> On June 27, 2018, 1:08 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 232-234 (patched) > >

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67646/#review205447 --- Ship it! - kalyan kumar kalvagadda On June 19, 2018, 3:25

Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER task for Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67745/ --- (Updated June 27, 2018, 4:30 p.m.) Review request for sentry, kalyan kumar

Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/#review205448 --- sentry-dist/src/license/THIRD-PARTY.properties Line 32

Re: Review Request 67747: SENTRY-2282: Remove hive-authzv2 binding and tests modules completely

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67747/#review205449 --- Ship it! Ship It! - Na Li On June 26, 2018, 6:47 p.m.,

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/ --- (Updated June 27, 2018, 4:49 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/ --- (Updated June 27, 2018, 3:57 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER task for Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67745/#review205450 --- Ship it! Ship It! - Sergio Pena On June 27, 2018, 4:30

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205451 ---

Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER task for Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67745/ --- (Updated June 27, 2018, 5:34 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/#review205455 ---

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205465 --- Ship it! Ship It! - Sergio Pena On June 27, 2018, 7:13

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 5 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > > Lines 311 (patched) > > > > > > Sergio,

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/#review205471 --- sentry-dist/src/license/THIRD-PARTY.properties Line 32

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:15 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4729 (patched) > > > > > > I

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:13 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryPrivilegesResponse.java > > Lines 59 (patched) > > > > > >

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 5:43 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > > Lines 312 (patched) > > > > > > Also we

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 5 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > > Lines 311 (patched) > > > > > > Sergio,

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:15 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4729 (patched) > > > > > > I

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/ --- (Updated June 27, 2018, 7:33 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/#review205454 ---

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/ --- (Updated June 27, 2018, 7:13 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER task for Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67745/#review205467 ---

Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER task for Hive

> On June 27, 2018, 7:18 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > > Lines 391 (patched) > > > > > > this is

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/#review205453 ---

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:15 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4729 (patched) > > > > > > I

Re: Review Request 67745: SENTRY-2273: Create the SHOW GRANT USER task for Hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67745/#review205466 ---

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 5:43 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > > Lines 312 (patched) > > > > > > Also we

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:15 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4729 (patched) > > > > > > I

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

> On June 27, 2018, 6:15 p.m., Arjun Mishra wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4729 (patched) > > > > > > I

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

> On June 27, 2018, 12:50 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHmsEvent.java > > Lines 224-233 (patched) > > > > > > As

Re: Review Request 67759: SENTRY-2284: Add two client API to get all roles or users privileges mapping

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67759/#review205482 --- Ship it! Ship It! - Na Li On June 27, 2018, 7:33 p.m.,

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

> On June 27, 2018, 12:50 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHmsEvent.java > > Lines 224-233 (patched) > > > > > > As

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/ --- (Updated June 27, 2018, 10:05 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205486 --- Ship it! Ship It! - kalyan kumar kalvagadda On June 27,

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205480 ---

Re: Review Request 67749: SENTRY-2280: The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/ --- (Updated June 27, 2018, 10:29 p.m.) Review request for sentry, Arjun Mishra,