Organizing JIRAs as subtasks for ABAC and FGP

It is rather difficult to navigate multiple JIRAs associated with ABAC and FGP. I wold suggest moving all jiras as subtask of two uber-jiras - one for FGP and one for ABAC. What do you think? - Alex

Re: Sentry Release Schedule for FGP and ABAC

s and then > start > > re-reveiwing with it as we merge it back into master when we get to the > end. > > > > Does this sound good to the community? > > > > > On Apr 30, 2018, at 6:35 PM, Alexander Kolbasov > > wrote: > > > > > > Steph

Re: Sentry Release Schedule for FGP and ABAC

re regular force pushes on the feature branch? This may be destructive for developers who have work in progress, but if they are Ok with it it may work. > > On Tue, May 1, 2018 at 11:32 AM, Alexander Kolbasov > wrote: > >> One aspect we should consider is git history - workin

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

read if you modify the if statement above: ```if (...) { return true; } // handle the more complicated case ``` - Alexander Kolbasov On May 17, 2018, 1:28 a.m., Na Li wrote: > > --- >

Re: Thoughts on using lombok?

Brian, This seems interesting. How does it interplay with IntelliJ/Eclipse ability to find all usages of the method - will we still be able to find all references to constructors/getters/setters e.t.c. ? > On May 24, 2018, at 12:54 PM, Brian Towles wrote: > > Howdy all, > > I was wondering w

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

/hdfs/PathDeltaRetriever.java Line 20 (original), 20 (patched) <https://reviews.apache.org/r/67846/#comment288761> Shouldn't this be done automatically by the shading plugin? - Alexander Kolbasov On July 6, 2018, 7:06 p.m., Steve

Arjun Mishra - New Apache Sentry Committer

It is my pleasure to introduce a new Apache Sentry committer who is very familiar to people on this list - Arjun Mishra! Welcome Arjun! - Alex

Re: VOTE] Release Sentry version 2.0.1

+1. - Alex On Thu, Aug 16, 2018 at 3:43 AM Colm O hEigeartaigh wrote: > +1. > > Colm. > > On Tue, Aug 14, 2018 at 9:23 PM, Na Li > wrote: > > > +1 > > > > On Tue, Aug 14, 2018 at 2:58 PM, Kalyan Kumar Kalvagadda < > > kkal...@cloudera.com.invalid> wrote: > > > > > Hello all, > > > > > > > > >

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

://reviews.apache.org/r/68488/#comment291383> Typo? "Provider manager *what*" sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java Lines 24 (patched) <https://reviews.apache.org/r/68488/#comment291384> Is this file coming from somewhere? - Alexander Kolbasov O

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 29, 2018, 8:29 p.m., Steve Moist wrote: > > lombok.config > > Lines 1 (patched) > > > > > > In introducing lombok into sentry. Will the configs for the existing > > sl4j need to be updated or modified? > >

Re: Review Request 68831: SENTRY-2417: fix LocalGroupMappingService INI format class docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68831/#review208979 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 24, 2018

Re: [ANNOUNCE] Apache Sentry 2.1.0 released

Fantastic! Thank you Lina for doing the release! > On Oct 2, 2018, at 08:57, Na Li wrote: > > The Apache Sentry team is happy to announce the release of version 2.1.0. > Apache Sentry is a system to enforce fine grained role based authorization > to data and metadata stored on a Hadoop cluster.

[DISCUSS] Updated design document for Sentry HA

Hi folks, I uploaded an updated proposal for Sentry HA design to https://issues.apache.org/jira/browse/SENTRY-872. The major change is the discussion of possible Active/Active model for Sentry HA. Please take a look and provide your feedback. Thanks, - Alex Kolbasov.

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

ache.org/r/52138/#comment217707> Please add comment explaining what this variable means. - Alexander Kolbasov On Sept. 21, 2016, 11:47 p.m., Hao Hao wrote: > > --- > This is an automa

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52150/#review149960 --- Ship it! Thank you for cleaning this up! - Alexander Kolbasov

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

ent218084> Please add a comment explaining what happens when the max is reached. - Alexander Kolbasov On Sept. 23, 2016, 6:15 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

/sentry/service/thrift/HMSFollower.java (lines 238 - 257) <https://reviews.apache.org/r/52138/#comment218202> I think that we should set currentEventId to eventIDBefore. - Alexander Kolbasov On Sept. 23, 2016, 6:15 a.m., Hao Hao

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

) method since it will prevent it from ever running again. - Alexander Kolbasov On Sept. 23, 2016, 6:15 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review151302 --- - Alexander Kolbasov On Oct. 4, 2016, 5:42 a.m., Hao Hao wrote

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 23, 2016, 4:41 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > lines 239-257 > > <https://reviews.apache.org/r/52138/diff/3/?file=1509069#file1509069line239>

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 24, 2016, 11:59 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > lines 215-216 > > <https://reviews.apache.org/r/52138/diff/3/?file=1509069#file1509069line215> >

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

whether we need it at all - why not just continue retrying (possibly sleeping a bit after each try)? - Alexander Kolbasov On Oct. 4, 2016, 5:42 a.m., Hao Hao wrote: > > --- > This is an automatically generated e

Re: Review Request 45859: SENTRY-1120: Show role / privileges info in Sentry Service Webpage

t mechanisms. - Alexander Kolbasov On Oct. 4, 2016, 10:23 p.m., Li Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

[DISCUSS] Changing transaction isolation level used by Sentry

I think it is worth some discussion in the list. I think that the default read-committed isolation level used by Sentry is not sufficient - please see https://issues.apache.org/jira/browse/SENTRY-1486. So the proposal is to change it to repeatable-read. Does anyone have objections to it? - Alex

Re: Review Request 45859: SENTRY-1120: Show role / privileges info in Sentry Service Webpage

/sentry/provider/db/service/thrift/SentryAdminServlet.java (line 92) <https://reviews.apache.org/r/45859/#comment220049> Since you are going to the trouble of disabling cache it makes sense to disable it for different browsers and proxies. - Alexander Kolbasov On Oct. 7, 2016, 12:26 a.

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

andler.java (line 178) <https://reviews.apache.org/r/52526/#comment220574> Why is the logic repeated here? - Alexander Kolbasov On Oct. 7, 2016, 12:30 a.m., Li Li wrote: > > ---

Who is consuming CommitContext?

There is a bunch of Sentry code that generates a thing called CommitContext. I am wondering who is actually consuming this context? It is sent in the Thrift reply. public class CommitContext { private final String serverUUID; private final long sequenceId; public CommitContext(UUID serverU

Question about SentryStore/DelegateSentryStore

There is some strangeness in the way SentryStore/DelegateSentryStore is implemented. DelegateSentryStore implements SentryStoreLayer interface, but SentryStore doesn't. It looks like SentryStore should implement this as well. Any thoughts on this?

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

ecific word to see whether any of these happened. - Alexander Kolbasov On Oct. 12, 2016, 7:15 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> (Updated Oct. 12, 2016, 7:15 a.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Li Li, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > --- > > SENTRY-1463: Ensure HMS point-in-time snapshot consistency >

Re: Review Request 52888: NPE in log4j.properties parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52888/#review152713 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 14, 2016, 4

Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be reoved

53980 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestNotificationHandlerInvoker.java 6a2f48f39246efbb5d7e80b4562ea19240dfd8b6 Diff: https://reviews.apache.org/r/52916/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 51848: Apply Checkstyle changes to the core

deviation between trunk and sentry-ha branch where there are a lot of changes happening. The style changes are very useful but they cause quite complicated merges. I think that we should consider delaying these changes until we merge sentry HA branch into trunk. - Alexander Kolbasov On Sept. 13

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

his variable. - Alexander Kolbasov On Oct. 14, 2016, 2:48 a.m., Colin Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

[DISCUSS] Datanucleus versions

While trying to reproduce scenario described by Colin Ma in https://issues.apache.org/jira/browse/SENTRY-1422 I made an attempt to use the same version of datanucleus parts as is used by Sentry and discovered a few interesting things: 1. Inconsistency between javax.jdo - Sentry uses Apache jav

Review Request 53038: SENTRY-1507

/pom.xml f70c5c326a4cf3e98fab60dd9c74f8d2144ea4a3 Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

/51449/#comment223088> I am not sure that it is a good idea to ignore interrupts - someone may try to shut down the daemon and we shouldn't prevent this. I think we should return either the original exception here or Interru

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

would be the commit message? The current one is a duplicate of the information in the JIRA - I think it should be enough to reference JIRA. - Alexander Kolbasov On Oct. 20, 2016, 3:46 a.m., Colin Ma wrote: > > --- > This is an auto

Re: Apache Sentry in Maven Central

Thanks Colm! On Tue, Oct 25, 2016 at 9:46 AM Lenni Kuff wrote: > Excellent, thanks Colm. > > On Tue, Oct 25, 2016 at 9:13 AM, Colm O hEigeartaigh > wrote: > > > Hi all, > > > > I've uploaded the Sentry artifacts for 1.7.0 to the Maven staging repo > and > > will promote them to Maven Central un

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

t; Why did you change the text? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java (line 88) <https://reviews.apache.org/r/51449/#comment223364> Please add comments for new configuration parameters - Alexander Kolbasov On Oct. 25, 2016,

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

changes mixed up. - Alexander Kolbasov On Oct. 25, 2016, 3 a.m., Colin Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53038: SENTRY-1507

/sentry-tests-solr/pom.xml a60b4eed4dde6c182b061681305013b3bd548cc3 sentry-tests/sentry-tests-sqoop/pom.xml f70c5c326a4cf3e98fab60dd9c74f8d2144ea4a3 Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53038: SENTRY-1507

-tests-solr/pom.xml 2f802ab101327edb7f0cbcd08bce24c2f37f59e1 sentry-tests/sentry-tests-sqoop/pom.xml c494b5a1404b13868f43f387eee6953557482975 Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53038: SENTRY-1507

-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryAdminServlet.java Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

> On Oct. 26, 2016, 4:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java, > > line 107 > > <https://reviews.apache.org/r/51449/diff/5/?file=1544817#file154481

Re: Review Request 53038: SENTRY-1507

/sentry-tests-solr/pom.xml a60b4eed4dde6c182b061681305013b3bd548cc3 sentry-tests/sentry-tests-sqoop/pom.xml f70c5c326a4cf3e98fab60dd9c74f8d2144ea4a3 Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53038: SENTRY-1507

/sentry-tests-solr/pom.xml a60b4eed4dde6c182b061681305013b3bd548cc3 sentry-tests/sentry-tests-sqoop/pom.xml f70c5c326a4cf3e98fab60dd9c74f8d2144ea4a3 Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153930 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 26, 2016, 8

Broken e2e tests in master?

I was looking at test failures from my patch and the failures seem to be quite unrelated. A lot of e2e tests failed because there were too many failures like Unable to finalize edits file /tmp/1477513681071-0/dfs/name2/current/edits_inprogress_001 For example here you can see thes

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be reoved

.java 8b3599fd9cb4dd80700c6bf405d35db16a72e3d7 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestNotificationHandlerInvoker.java 6a2f48f39246efbb5d7e80b4562ea19240dfd8b6 Diff: https://reviews.apache.org/r/52916/diff/ Testing --- Thanks, Alex

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

in/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java (line 160) <https://reviews.apache.org/r/52526/#comment221822> This comment isn't very clear. It needs a bit more context. - Alexander Kolbasov On Oct. 27, 2016, 4:41 p.m., Li Li wrote: > >

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

/r/52526/#comment223844> What does "function" mean here? Please add comment explaining what this max retry means - is it per connection attempt or for lifetime? Also please add a comment explaining what happens after retries. ALternatively you may put a big block comm

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

; This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52526/ > --- > > (Updated Oct. 27, 2016, 4:41 p.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and

Re: Apache Sentry in Maven Central

Great, thanks Colm! On Wed, Nov 2, 2016 at 3:00 AM Colm O hEigeartaigh wrote: > It's available in Maven Central now: > http://repo1.maven.org/maven2/org/apache/sentry/ > > Colm. > > On Tue, Oct 25, 2016 at 11:18 PM, Alexander Kolbasov > wrote: > > > Thanks Co

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

voker.java 6a2f48f39246efbb5d7e80b4562ea19240dfd8b6 Diff: https://reviews.apache.org/r/52916/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52916/#review154680 --- On Nov. 3, 2016, 3:58 a.m., Alexander Kolbasov wrote: > > ---

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

ws.apache.org/r/52916/#review154821 --- On Nov. 3, 2016, 3:58 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

his is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52526/ > --- > > (Updated Nov. 2, 2016, 6:08 p.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravy

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

another one will close already reconnected client and try to connect it again which isn't good, - Alexander Kolbasov On Nov. 4, 2016, 6:26 p.m., Li Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

e88> > > > > Make it void here since we are not returning anything? Same thing for > > the rest of APIs. > > Alexander Kolbasov wrote: > I had to do it this way because of the way Mockito works - it needs an > object returned. This only affects testig pa

Review Request 53514: SENTRY-1522: Port SENTRY-1505 to sentry-ha_redesign branch

/53514/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 53520: SENTRY-1517: SentryStore shoud actually use function getMSentryRole to get roles

/apache/sentry/provider/db/service/persistent/TestSentryStore.java 66f05841b7fb009278c50d3e6c90e79063623c65 Diff: https://reviews.apache.org/r/53520/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

/apache/sentry/service/thrift/RetryClientInvocationHandler.java (line 97) <https://reviews.apache.org/r/52526/#comment225300> Adding 'continue' above will get rid of this check - Alexander Kolbasov On Nov. 5, 2016, 1:29 a.m., Li Li wrote: > > --

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

don't have time to address them, please ship as is and we'll address them later. - Alexander Kolbasov On Nov. 5, 2016, 1:29 a.m., Li Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

> > (Updated Nov. 9, 2016, 3:37 a.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > --- > > Since currently non pool model is used for sentr

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52526/#review155403 --- Ship it! Ship It! - Alexander Kolbasov On Nov. 9, 2016, 3

[DISCUSS] Changing role <-> priv relationship from M:N to 1:N

Hello, I would like to start a discussion about the relationship model between roles and permissions in Sentry. Currently it uses N:M model where a single permission may belong to multiple roles and a single role can have multiple permissions. Given that all permission manipulations are always ha

Re: [DISCUSS] Changing role <-> priv relationship from M:N to 1:N

> > On Wed, Nov 9, 2016 at 2:11 PM, Alexander Kolbasov > wrote: > >> Hello, >> >> I would like to start a discussion about the relationship model between >> roles and permissions in Sentry. Currently it uses N:M model where a single >> permission may

Review Request 53869: SENTRY-1523: sentry-dist is missing dependency on mysql connector

, Alexander Kolbasov

Review Request 53870: SENTRY-1524: sentry-dist is missing dependency on sentry-hdfs-dist

, Alexander Kolbasov

Review Request 53872: SENTRY-1525: Provide script to run Sentry directly from the repo

Tirukkovalur, and Vadim Spector. Repository: sentry Description --- SENTRY-1525: Provide script to run Sentry directly from the repo Diffs - bin/run_sentry.sh PRE-CREATION Diff: https://reviews.apache.org/r/53872/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

3d0a6ab0b514cb9fbead4b8e527f7cb84865ce28 Diff: https://reviews.apache.org/r/53905/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53905/#review156357 --- On Nov. 18, 2016, 10:50 p.m., Alexander Kolbasov wrote: > > --- >

Review Request 53920: SENTRY-1534: Oracle supports serializable instead of repeatable-read

ec47909ab3098a890019bc19179786a2c5d7d87c sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 742798dca6b3ad8c9b9eee1eea5380001d1d0cd9 Diff: https://reviews.apache.org/r/53920/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 53921: SENTRY-1533: Sentry console metrics reporting interval should be configurable

ff06582708ac73d969e1bbdfcec7b672bc9c65c5 Diff: https://reviews.apache.org/r/53921/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53920: SENTRY-1534: Oracle supports serializable instead of repeatable-read

above. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53920/#review156683 --- On Nov. 19, 2016, 1:45 a.m., Alexander Kolbasov wrot

Re: Review Request 53921: SENTRY-1533: Sentry console metrics reporting interval should be configurable

/provider/db/service/thrift/SentryPolicyStoreProcessor.java ff06582708ac73d969e1bbdfcec7b672bc9c65c5 Diff: https://reviews.apache.org/r/53921/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53921: SENTRY-1533: Sentry console metrics reporting interval should be configurable

/provider/db/service/thrift/SentryPolicyStoreProcessor.java ff06582708ac73d969e1bbdfcec7b672bc9c65c5 Diff: https://reviews.apache.org/r/53921/diff/ Testing --- Thanks, Alexander Kolbasov

Alternative Sentry CLI

I'd like to have a useful Sentry CLI that is simple enough to send various Thrift requests to the running Sentry server, so I wrote one. It is work in progress, so a bunch of functionality is missing. Kerberos isn't supported at all. The tool and its documentation are available from https://github

Re: Review Request 53920: SENTRY-1534: Oracle supports serializable instead of repeatable-read

/53920/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53520: SENTRY-1517: SentryStore shoud actually use function getMSentryRole to get roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53520/#review157507 --- On Nov. 15, 2016, 1:15 a.m., Alexander Kolbasov wrote: > >

Re: Review Request 53520: SENTRY-1517: SentryStore shoud actually use function getMSentryRole to get roles

, Alexander Kolbasov

Re: Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

/sentry/provider/db/service/persistent/TransactionManager.java 3d0a6ab0b514cb9fbead4b8e527f7cb84865ce28 Diff: https://reviews.apache.org/r/53905/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry directly from the repo

directly from the repo Diffs (updated) - bin/run_sentry.sh PRE-CREATION Diff: https://reviews.apache.org/r/53872/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry directly from the repo

e it in the first place (and this requires mvn install first). - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53872/#review157096 -------

Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

f773a4443e81c5cde3aca0056a2e33d528bf4ec9 Diff: https://reviews.apache.org/r/54338/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Show groups for a given role

Hi Jan, You may check my new sentry command-line tool at https://github.com/akolb1/sentrytool . You can easily do it with this tool: sentrytool group list -v Caveat - it doesn’t work in Kerberos setup. I am not sure whether there is a more “official” way

Review Request 54409: SENTRY-1476: SentryStore is subject to JDQL injection

/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

here. I guess the check should be for the original privilege instead. And the message probably should be something like "grant option is not specified" - Alexander Kolbasov On Dec. 6, 2016, 11:05 p.m., kalyan kumar kalvagadda wrote: > > -

Re: Review Request 54464: SENTRY-1557: getRolesForGroups(), getRolesForUsers() does too many trips to the the DB

/sentry/provider/db/service/persistent/SentryStore.java (line 1258) <https://reviews.apache.org/r/54464/#comment229171> It is neat, but does it actually work? - Alexander Kolbasov On Dec. 7, 2016, 2:39 a.m., Vamsee Yarlagadda

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

y, visit: https://reviews.apache.org/r/54338/#review158055 ------- On Dec. 3, 2016, 6:52 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

der --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review158054 --- On Dec. 3, 2016, 6:52 a.m., Alexander Kolbasov wrote: > > --

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

/SentryStore.java f773a4443e81c5cde3aca0056a2e33d528bf4ec9 Diff: https://reviews.apache.org/r/54338/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 54532: SENTRY-378: Changed usages of SentryAccessDeniedException to SentryConfigurationException when retrieving Sentry version information in SentryStore

? - Alexander Kolbasov On Dec. 8, 2016, 1:07 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

/sentry/provider/db/service/persistent/SentryStore.java (line 1607) <https://reviews.apache.org/r/54526/#comment229355> So this is just the rename - right? The point is that getDbName is never NULL. Or did you intend to check for the actual __NULL__ string here? - Alexander Kolbasov

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

this is fixed we don't need fromNULLCol() anymore. - Alexander Kolbasov On Dec. 8, 2016, 8:47 a.m., Vamsee Yarlagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

- > > (Updated Dec. 8, 2016, 8:47 a.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar > kalvagadda. > > > Repository: sentry > > > Description > --- > > Only sets the fields in TSentryPrivilege that are set i

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

> On Dec. 8, 2016, 9:32 p.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1607 > > <https://reviews.apache.org/r/54526/diff/1/?file=1579704#file1579704line1

Re: Review Request 54464: SENTRY-1557: getRolesForGroups(), getRolesForUsers() does too many trips to the the DB

each item in tRoles is in the {roleName{1,2,3}}set. In practice your test does test for this condition, but it is not generalizable for a set of roles. - Alexander Kolbasov On Dec. 8, 2016, 7:47 a.m., Vamsee Yarlagadda wrote: > > --

Re: Review Request 54464: SENTRY-1557: getRolesForGroups(), getRolesForUsers() does too many trips to the the DB

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54464/#review158619 --- Ship it! Ship It! - Alexander Kolbasov On Dec. 9, 2016, 1

<    1   2   3   4   5   6   7   8   9   10   >