Re: SQL changes for SENTRY-1726

The major problem with read-modify-write approach is that it is difficult to handle the case with two writers trying to update the value at the same time. If you handle this by adding new rows and having the ID as the primary key, one writer will succeed and another will fail because the key

Re: Review Request 59031: SENTRY-1714 MetastorePlugin.java should quetly return from renameAuthzObject() when both paths are null

/sentry/binding/metastore/SentryMetastorePostEventListener.java Lines 416 (patched) <https://reviews.apache.org/r/59031/#comment247397> What should happen of one of them is null - either old path or new path? - Alexander Kolbasov On May 5, 2017, 9:38 p.m., kalyan kumar kalvagadda

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

iew175920 --- On May 24, 2017, 7:49 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 59510: SENTRY-1774 HMSFollower should always depend on persisted information to decide is full snapshot is needed

ovider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 103 (original), 101 (patched) <https://reviews.apache.org/r/59510/#comment249330> This return is redundand now - Alexander Kolbasov On May 24, 2017, 1:36 a.m., kalya

Re: Review Request 59424: SENTRY-1736 Generic service client should support Kerberos(Continuation Fix)

another JIRA for subsequent changes. - Alexander Kolbasov On May 19, 2017, 11:27 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59793: SENTRY-1780: FullUpdateInitializer does not kill the threads whenever getFullHMSSnapshot throws an...

he caller can't do anything useful with it. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59793/#review176892 -----

Re: Review Request 59167: SENTRY-1580: Provide pooled client connection model with HA

Diff: https://reviews.apache.org/r/59167/diff/9/ Changes: https://reviews.apache.org/r/59167/diff/8-9/ Testing --- I used the interactive shell to test failover across two different servers. Thanks, Alexander Kolbasov

Re: Optimizing Sentry to HDFS protocol

change? > Based on > https://stackoverflow.com/questions/9732381/why-thrift-why-not-http-rpcjsongzip, > Thrift has several benefits. Because these structures are not memory-efficient.In your stack overflow article it talks about benefits of Thrift over HTTP. Here we are talking abou

Review Request 60490: SENTRY-1820: Add JSON file reporter for Sentry metrics

, Alexander Kolbasov

Re: Review Request 62231: SENTRY-1946: getPathsUpdatesFrom() got its boolean logic inversed which results in sending two snapshots at the same time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62231/#review185131 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 12, 2017, 1

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

t successfully processed one message but not the rest? How would this message help someone? - Alexander Kolbasov On Sept. 13, 2017, 2:26 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply

Re: [DISCUSS] Allow JDK8 specific features on Sentry 2.0

tain features that makes us > hard to backport, but we haven't had any problem with JDK8 at all. > > On Thu, Aug 31, 2017 at 6:19 PM, Alexander Kolbasov <ak...@cloudera.com> > wrote: > > > Sergio, can you share Apache Hive experience with this issue? > > > &

Re: Review Request 62409: SENTRY-1949: Old full snapshots are never cleaned up

already taking a big hit for taking it, so I wondering if we should consider doing this as part of our existing cleanup thread. - Alexander Kolbasov On Sept. 19, 2017, 2:51 p.m., Sergio Pena wrote: > > --- > This is an auto

Re: Review Request 62409: SENTRY-1949: Old full snapshots are never cleaned up

try-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 335 (patched) <https://reviews.apache.org/r/62409/#comment262050> I think it makes sense to ignore exception during cleanup. - Alexander Kolbasov On Sept. 19, 2017, 2:51 p.m.,

Review Request 62496: SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system

/62496/diff/1/ Testing --- New unit test written Thanks, Alexander Kolbasov

Re: Review Request 62496: SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system

/service/thrift/TestSentryMetrics.java PRE-CREATION Diff: https://reviews.apache.org/r/62496/diff/2/ Changes: https://reviews.apache.org/r/62496/diff/1-2/ Testing --- New unit test written Thanks, Alexander Kolbasov

Re: Review Request 62411: SENTRY-1958: Bump to Hive version 2.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62411/#review185922 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 21, 2017

Re: Review Request 62411: SENTRY-1958: Bump to Hive version 2.0

/sentry/binding/metastore/SentryMetastorePostEventListener.java Lines 22 (patched) <https://reviews.apache.org/r/62411/#comment262127> This class isn't used in 2.0 so there is no need to do anything special with it. - Alexander Kolbasov On Sept. 19, 2017, 3:10 p.m., Sergio Pena

Re: Review Request 62261: SENTRY-1937 Optimize performance for listing sentry roles by group name

nder --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62261/#review185339 --- On Sept. 13, 2017, 3:49 a.m., Alexander Kolb

Re: Review Request 62496: SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system

/3/ Changes: https://reviews.apache.org/r/62496/diff/2-3/ Testing --- New unit test written Thanks, Alexander Kolbasov

Re: Review Request 62393: SENTRY-1943: Update Guava to 14.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62393/#review185630 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 18, 2017

Re: Proposal to have sentry 1.9 release.

; > -Kalyan > > On Thu, Oct 5, 2017 at 5:52 PM, Alexander Kolbasov <ak...@cloudera.com> > wrote: > > > Sergio - what is the state of HMS notifications in Hive1? Do they even > > exist there? > > > > Kalyan - I am not sure that the new Sentry architec

Re: Review Request 62496: SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system

org/r/62496/#review186848 --- On Sept. 22, 2017, 6:28 p.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 62496: SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system

prefix as well to be clear what this file is. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62496/#review185997 --- On Sept

Re: Proposal to have sentry 1.9 release.

-Kalyan > > > > > -Kalyan > > On Thu, Oct 5, 2017 at 3:02 PM, Alexander Kolbasov <ak...@cloudera.com> > wrote: > > > The major reason why we wanted to move to Sentry 2.0 was the dependency > on > > Hive version. Sentry HA completely relies on HMS notifica

Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout when it is ready to serve requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62979/#review188141 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 16, 2017, 3

Re: Review Request 63047: SENTRY-1994: Bump Shiro dependency version to 1.4.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63047/#review188220 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 16, 2017, 9

Re: Review Request 63048: SENTRY-1995: Bump Derby dependency version to 10.13.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63048/#review188221 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 16, 2017, 9

Re: Review Request 62942: Bump the minimum java version to 8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62942/#review188032 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 13, 2017, 6

Re: Review Request 62990: SENTRY-1988: Bump slf4j version from 1.6.0 to 1.7.25 (latest version)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62990/#review188046 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 13, 2017, 9

Re: Review Request 62942: Bump the minimum java version to 8

- Alexander Kolbasov On Oct. 12, 2017, 6:16 p.m., Sergio Pena wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62950: SENTRY-1981: Bump codehale metrics version to latest 3.0.2 version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62950/#review187863 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 12, 2017, 8

Re: Review Request 62953: SENTRY-1983: Several commit/rollback errors happen in oracle12c-r1 due to current isolation level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62953/#review187896 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 12, 2017, 10

Re: Review Request 63026: SENTRY-1979 - Consolidate code for converting Hive privilege objects to Strings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63026/#review188187 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 16, 2017, 11

Re: Review Request 62983: SENTRY-1986: Fix NPE on createGrantTask from SentryHiveAuthorizationTaskFactoryImpl.java

tially expensive and should be removed. - Alexander Kolbasov On Oct. 13, 2017, 6:10 p.m., Sergio Pena wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Proposal to release Sentry 2.0.0

Kalyan, Thank you for pushing forward 2.0 release! > On Oct 13, 2017, at 7:20 AM, Kalyan Kumar Kalvagadda > wrote: > > Hello all, > > We need to release sentry HA functionality so that community can start > using it. In this regard I proposed to have a sentry 1.9.0

Re: Review Request 62195: SENTRY-1934: SQL Index name is too long for Oracle 11.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62195/#review185023 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 8, 2017, 9

Re: Review Request 62192: SENTRY-1932: Improve logging for HMSPath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62192/#review185033 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 8, 2017, 10

Re: Review Request 62194: SENTRY-1933: hive-authz2 build fails because SentryJSONAlterPartitionMessage is not compatible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62194/#review185034 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 8, 2017, 9

Re: Review Request 61986: SENTRY-1907 Potential memory optimization when handling big full snapshots.

/61986/diff/1-2/ Testing --- Thanks, Alexander Kolbasov

Review Request 61988: SENTRY-1903 TransactionManager shows retried transactions starting from 0

/provider/db/service/persistent/TransactionManager.java 0a9f3a7cfd2790fa9b0a9b15323ea4a4c53184c3 Diff: https://reviews.apache.org/r/61988/diff/1/ Testing --- Thanks, Alexander Kolbasov

Review Request 61986: SENTRY-1907 Potential memory optimization when handling big full snapshots.

/main/java/org/apache/sentry/hdfs/PathImageRetriever.java f1e67ca6e343e4e5dd0c3377c4c6beb19544e3eb Diff: https://reviews.apache.org/r/61986/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 61983: SENTRY-1906: Sentry clients to retry connections to server with delay to avoid failing fast

re you handling InterruptedException here? - Alexander Kolbasov On Aug. 30, 2017, 1:29 a.m., Vamsee Yarlagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61983: SENTRY-1906: Sentry clients to retry connections to server with delay to avoid failing fast

> On Aug. 30, 2017, 5:36 p.m., Alexander Kolbasov wrote: > > My concern with this change is that we will delay normal client failover by > > 3 seconds. Can we initially retry without delay and then delay if it failed? > > Vamsee Yarlagadda wrote: > This will not

Re: Review Request 61973: SENTRY-1888: Sentry might not fetch all HMS duplicated events IDs when requested

not very bad, but if we store the sha1 hash of the last event in the cache we don't have to go to sentryStore at all under normal circumstances - Alexander Kolbasov On Aug. 29, 2017, 6:41 p.m., Sergio Pena wrote: > > --- > This is a

Re: Review Request 61983: SENTRY-1906: Sentry clients to retry connections to server with delay to avoid failing fast

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61983/#review184198 --- Ship it! Ship It! - Alexander Kolbasov On Aug. 30, 2017, 7

Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

7deccb064fd75b39af779796d9e95caf9c718b32 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java f56384a99e128b3e9880cbc5692107d61f2f500f Diff: https://reviews.apache.org/r/62007/diff/1/ Testing --- Thanks, Alexander Kolbasov

Blog entry for Sentry 1.8 release

Sergio - would you like to write a blog entry for the 1.8 release? I think others can help by pointing out major things that were added in 1.8 that they know about. - Alex.

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62221/#review185100 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 11, 2017, 6

Re: Review Request 62221: SENTRY-1938: Sentry logs to provide more relevant information

ne 313 (original), 314 (patched) <https://reviews.apache.org/r/62221/#comment261310> Here it is not persisted, so the message is wrong. - Alexander Kolbasov On Sept. 11, 2017, 3:32 p.m., Arjun Mishra wrote: > > --- > Thi

Re: Review Request 62219: SENTRY-1941: Add log4j2.properties file to sentry-hive-tests-v2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62219/#review185089 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 11, 2017, 2

Review Request 62075: SENTRY-1917: Sentry should work around HIVE-16994

--- Thanks, Alexander Kolbasov

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

n(true) This will express the meaning better IMO. - Alexander Kolbasov On Sept. 5, 2017, 9:11 p.m., Sergio Pena wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 62101: SENTRY-1916 Sentry should not store paths outside of the prefix

a8d70c11c879828d16f44df2168853a5b709c8f7 Diff: https://reviews.apache.org/r/62101/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

pache/sentry/service/thrift/SentryServiceFactory.java Line 22 (original), 21 (patched) <https://reviews.apache.org/r/62107/#comment260786> How do these changes relate to the issue you are fixing? Are you trying to sneak in some other change? - Alexa

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184824 ------- On Sept. 7, 2017, 8:06 a.m., Alexander Kolbasov wrote: > > --- > This is an au

Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6 Diff: https://reviews.apache.org/r/62146/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

--- Thanks, Alexander Kolbasov

Re: Review Request 62177: SENTRY-1931: NameNode only gets full snapshot once

/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java Lines 89 (patched) <https://reviews.apache.org/r/62177/#comment261099> Nit: why do we need to set it if the value is the same? So shouldn't it be `<=` ? - Alexander Kolbasov On Sept. 7, 2017, 10:23 p.m., Sergio P

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

kely that we have duplicate strings at different levels of a tree. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62112/#review184713 ------- On Sept. 6, 2017, 6:48 p.m., Alexander Kolbasov wrote: > >

Re: Review Request 62136: SENTRY-1928: HMSFollower should close HMS connections when an error to HMS occurs

-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 191 (original), 191 (patched) <https://reviews.apache.org/r/62136/#comment260957> Since we are not doing anything fancy now, should we just remove this and have a simple catch-all? - Alexander Kolbasov On S

Re: Review Request 62261: SENTRY-1937 Optimize performance for listing sentry roles by group name

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62261/#review185252 ------- On Sept. 12, 2017, 11:26 p.m., Alexander Kolbasov wrote: > > -

Re: Review Request 62261: SENTRY-1937 Optimize performance for listing sentry roles by group name

/62261/diff/1-2/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 62261: SENTRY-1937 Optimize performance for listing sentry roles by group name

0339#file1820339line1800> > > > > Looks like in the old code, 'groupName == null' was supported, and > > getAllRoles(pm) was returned in that case. I don't think it happening here > > anymore? > > Alexander Kolbasov wrote: > We never call it with groupName =

Re: Review Request 62261: SENTRY-1937 Optimize performance for listing sentry roles by group name

0339#file1820339line1800> > > > > Looks like in the old code, 'groupName == null' was supported, and > > getAllRoles(pm) was returned in that case. I don't think it happening here > > anymore? > > Alexander Kolbasov wrote: > We never call it with groupName == nul

Review Request 62261: SENTRY-1937 Optimize performance for listing sentry roles by group name

/apache/sentry/provider/db/service/persistent/SentryStore.java 01a7c830f548d41062fb3bbd0a81f71514585aa5 Diff: https://reviews.apache.org/r/62261/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 62261: SENTRY-1937 Optimize performance for listing sentry roles by group name

--- Thanks, Alexander Kolbasov

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

/sentry/provider/db/service/model/package.jdo Line 122 (original) <https://reviews.apache.org/r/61793/#comment261165> This change makes package.jdo inconsistent with sql scripts which do use these fields as keys and the goal was to make these consistent. - Alexander Kolbasov On Sept. 1, 2

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

vider-db/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java Lines 53 (patched) <https://reviews.apache.org/r/62107/#comment261162> This part isn;t thread safe since it does non-atomic read/modify/write - Alexander Kolb

Review Request 62229: SENTRY-1940 Sentry should time out threads waiting for notifications

/org/apache/sentry/service/thrift/TestCounterWait.java e4846d9aea5ef9882fc655de9ec38c5795bde896 Diff: https://reviews.apache.org/r/62229/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged

d4feb380fa0f3bd5f237609a107295a2d23eae3b Diff: https://reviews.apache.org/r/62146/diff/2/ Changes: https://reviews.apache.org/r/62146/diff/1-2/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

a helper singleton class where parties can register (by name) and say - hey, I am busy, hey, I am available - using a simple map from name to atomic value. This way we do not require all these plumbing changes (which may be useful for other purposes but that's another story). - Alexander Kolbasov

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

sit: https://reviews.apache.org/r/62112/#review184689 --- On Sept. 6, 2017, 6:48 p.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 62112: SENTRY-1915 Sentry is doing a lot of work to convert list of paths to HMSPaths structure

://reviews.apache.org/r/62112/#review184689 --- On Sept. 6, 2017, 7:19 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Sentry CLI

I put current code for sentry CLI into akolb-cli branch. So far it supports Hive privileges only. It would be great of some can add support for Solr/Kafka privilege model as well. Any volunteers? - Alex

Re: Review Request 61858: SENTRY-1898: Sentry no longer supports creating more than ~15 partitions at once

-SENTRY-1569.oracle.sql Line 17 (original), 17 (patched) <https://reviews.apache.org/r/61858/#comment259723> Would VARCHAR2 work here? - Alexander Kolbasov On Aug. 23, 2017, 7:46 p.m., Na Li wrote: > > --- > This is a

Review Request 61862: SENTRY-1822 Allow multiple Sentry reporters.

/SentryMetrics.java 32a0664bda1156a089406c59fef8f07c807850f4 Diff: https://reviews.apache.org/r/61862/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 61858: SENTRY-1898: Sentry no longer supports creating more than ~15 partitions at once

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61858/#review183671 --- Ship it! Ship It! - Alexander Kolbasov On Aug. 23, 2017, 7

Re: Review Request 61889: SENTRY-1895: Sentry should handle the case of multiple notifications with the same ID

name to reflect the fact that this is not an ID but hash. Also, please add comment explaining what this is and why it is using CHAR(40) - Alexander Kolbasov On Aug. 24, 2017, 4:59 p.m., Sergio Pena wrote: > > --- > This is an automatically

Re: Review Request 61793: SENTRY-1894: Update field size in package.jdo for dataNucleus to match size in sql

` ADD UNIQUE `SENTRY_DB_PRIV_PRIV_NAME_UNIQ` (`SERVER_NAME`,`DB_NAME`,`TABLE_NAME`,`COLUMN_NAME`,`URI`(250),`ACTION`,`WITH_GRANT_OPTION`); Does it match your changes? - Alexander Kolbasov On Aug. 25, 2017, 7:25 p.m., Na Li wrote

Re: Review Request 61889: SENTRY-1895: Sentry should handle the case of multiple notifications with the same ID

sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java Line 138 (original), 147 (patched) <https://reviews.apache.org/r/61889/#comment259946> Since hashCode incorporates the rest we can just return true here - Alexander Kolbasov On Aug. 25, 20

Re: Review Request 61827: SENTRY-1892: Reduce memory consumption of HMSPath and TPathEntry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61827/#review183649 --- Ship it! Ship It! - Alexander Kolbasov On Aug. 23, 2017, 7

Re: Review Request 61827: SENTRY-1892: Reduce memory consumption of HMSPath and TPathEntry

> On Aug. 23, 2017, 6:35 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 537 (patched) > > <https://reviews.apache.org/r/61827/diff/1/?file=1801885#file1801885line541> > > > >

Re: Review Request 61827: SENTRY-1892: Reduce memory consumption of HMSPath and TPathEntry

/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Lines 537 (patched) <https://reviews.apache.org/r/61827/#comment259698> Looks like most callers just care whether size() != 0, so you may have even simpler isEmpty() function. - Alexander Kolbasov On Aug. 22, 2017, 11:

Re: Review Request 62044: SENTRY-1913: Incorrect constraints on AUTHZ_PATHS_MAPPING.AUTHZ_OBJ_NAME

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62044/#review184402 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 1, 2017, 10

Re: [DISCUSSION] Move to JDK8 and Datanucleus 4

+1 for both. I would be still against actually allowing Java 8 specific code since people may want to backport fixes to old releases which might still use Java 7. Allowing Java-8 exclusive features may make this process complicated. Lambdas are cute, but we can do without them for a while. It

Draft of the quarterly ASF report for Apache Sentry

Here is the draft of the quarterly Apache Sentry ASF report. Please let me know if you have any comments or issues with it. Thanks, - Alex. ## Description: Apache Sentry is a highly modular system for providing fine grained role based authorization to both data and metadata stored on an Apache

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

e.org/r/61863/ > ------- > > (Updated Aug. 31, 2017, 9:55 p.m.) > > > Review request for sentry, Alexander Kolbasov, Vamsee Yarlagadda, and Vadim > Spector. > > > Repository: sentry > > > Des

Re: Review Request 61973: SENTRY-1888: Sentry might not fetch all HMS duplicated events IDs when requested

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61973/#review184333 --- Ship it! Ship It! - Alexander Kolbasov On Aug. 31, 2017, 6

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

/62007/diff/2/ Changes: https://reviews.apache.org/r/62007/diff/1-2/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 62007: SENTRY-1909 Improvements for memory usage when full path snapshot is sent from Sentry to NN

g, Set> is not compatible with Map<String, Collection>. Here we know exactly that we are using sets but interfaces require collections. I don't know how to work around this. - Alexander --- This is an automatically g

[DISCUSS] Who is using Sentry outside of Cloudera distribution?

I'd like to get a feel on when and how Apache Sentry is used outside of Cloudera distribution, so if anyone is using Apache Sentry not within the CDH ecosystem, I would appreciate if you share your experience. Thanks, - ALex

Re: Proposal to have sentry 1.9 release.

The major reason why we wanted to move to Sentry 2.0 was the dependency on Hive version. Sentry HA completely relies on HMS notifications which are not available in Hive 1, more over it relies on fixes that are only available in Hive 2.4. Sentry 1 should work with Hive 1, so we can't make Sentry

Re: Do Sentry sync-up meetings exist?

e ASF team. > > Colm. > > On Wed, Oct 4, 2017 at 1:15 AM, Alexander Kolbasov <ak...@cloudera.com> > wrote: > >> Sravya used to have meetings over hangout, it was attended by Colin Ma and >> some other folks. It is definitely a good idea if there is an i

Re: Do Sentry sync-up meetings exist?

gt; wrote: > > Sasha, should we add this information about Slack rooms here and how to > request an invitation? > http://sentry.apache.org/community/get_involved.html > > On Wed, Oct 4, 2017 at 5:19 PM, Alexander Kolbasov <ak...@cloudera.com> > wrote: > >> It is ht

Re: Review Request 62745: SENTRY-1210 - Refactor the SentryShellSolr and SentryShellKafka

va/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java Lines 117 (patched) <https://reviews.apache.org/r/62745/#comment263989> Ditto. - Alexander Kolbasov On Oct. 3, 2017, 10:41 a.m., Colm O hEigea

Re: Do Sentry sync-up meetings exist?

Sravya used to have meetings over hangout, it was attended by Colin Ma and some other folks. It is definitely a good idea if there is an interest. Also a reminder that we have a slack room for discussions. On Tue, Oct 3, 2017 at 2:50 PM, Sergio Pena wrote: > Hi All, >

Re: Code consolidation query

Interesting - both were introduced by Colin Ma. I definitely agree that we do not need two duplicates of the same similar functionality. The exception part is interesting - the validator throws unchecked exceptions. The version in SentryServiceUtil is used only in import policy code path where

Re: questions on sentry

Hi Chen, Apache Sentry goal is to provide security features for other Apache products - mainly Apache {Hive, Impala, Solr, Kafka}. It doesn't provide HDFS access protections. - Alex. On Wed, Oct 18, 2017 at 12:05 PM, Chen Song wrote: > I have a few questions on Sentry.

Re: questions on sentry

Hi Chen, Apache Sentry goal is to provide security features for other Apache products - mainly Apache {Hive, Impala, Solr, Kafka}. It doesn't provide HDFS access protections. - Alex. On Wed, Oct 18, 2017 at 12:05 PM, Chen Song wrote: > I have a few questions on Sentry.

<    1   2   3   4   5   6   7   8   >