ervice/thrift/HMSFollower.java
<https://reviews.apache.org/r/56191/#comment235537>
what is the reason for removing the retry logic?
- kalyan kumar kalvagadda
On Feb. 2, 2017, 6:34 p.m., Vamsee Yarl
rically checking the connection status of these
client connections and update the connection state in the client object and
also try to re-connect.
That we don't have to estabish the connections when the client API's are
called.
- kalyan kumar kalvagadda
On Feb. 1, 2017, 9:11 p.m., k
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56191/#review164029
---
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Feb. 2, 2017
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.oracle.sql
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-872.postgres.sql
Diff: https://reviews.apache.org/r/56200/diff/
Testing
---
Thanks,
kalyan kumar kalvagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56411/#review164706
---
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Feb. 8, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56454/#review164760
---
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Feb. 8, 2017
/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql
0da95673d3e2467a0912cec6451b7d6aef1f5309
Diff: https://reviews.apache.org/r/56200/diff/
Testing
---
Thanks,
kalyan kumar kalvagadda
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
(line 2277)
<https://reviews.apache.org/r/56356/#comment236454>
query.execute can return null.
- kalyan kumar kalvagadda
On Feb. 7, 2017, 2:14
---
I have tested the code using java client which use the client implementations.
Thanks,
kalyan kumar kalvagadda
://reviews.apache.org/r/56134/diff/
Testing
---
I have tested the code using java client which use the client implementations.
Thanks,
kalyan kumar kalvagadda
/SentryServiceClientTransportDefaultImpl.java
(line 153)
<https://reviews.apache.org/r/56134/#comment235353>
This part of the code is not new. I have them from a different class. What
do you mean by implicit loop?
- kalyan kumar kalvagadda
On Jan. 31, 2017, 8:39 p.m., kalyan
ve optimized this now.
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54947/#review162570
---
On Feb. 16, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54947/#review165734
---
- kalyan kumar kalvagadda
On Feb. 16, 2017, 5:04 p.m., kalyan
/
Testing
---
Thanks,
kalyan kumar kalvagadda
-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
2dc8af8c54c5ee59c618926438f4aa91b35fd13f
Diff: https://reviews.apache.org/r/56954/diff/
Testing
---
Thanks,
kalyan kumar kalvagadda
kumar kalvagadda
against db2, postgres, musql, oracle and derby databases.
Also ran SchemaToll test for deby.
Thanks,
kalyan kumar kalvagadda
/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql
f0c8cfb4174189fe270597c2525579b534778831
Diff: https://reviews.apache.org/r/56709/diff/
Testing
---
Tested the scrips against db2, postgres, musql, oracle and derby databases.
Also ran SchemaToll test for deby.
Thanks,
kalyan kumar kalvagadda
kumar kalvagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55246/#review165891
---
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Feb. 3, 2017
where the server name OR action
feilds are just whitespace characters it would return failure.
This can not be done with isNullOrEmpty.
- kalyan kumar kalvagadda
On Jan. 5, 2017, 4:50 p.m., kalyan kumar kalvagadda
the scrips against db2, postgres, musql, oracle and derby databases.
Also ran SchemaToll test for deby.
Thanks,
kalyan kumar kalvagadda
sed as well. Please
confirm
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56709/#review166277
-------
On Feb. 28, 2
/
Testing
---
Thanks,
kalyan kumar kalvagadda
eviews.apache.org/r/54454/#review160612
---
On Feb. 28, 2017, 12:58 a.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
Verfied the changes using sentry thrift client.
Thanks,
kalyan kumar kalvagadda
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/54454/#review162568
---
On Feb. 28, 2017, 12:58 a.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automati
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54454/#review160654
---
On Feb. 28, 2017, 12:58 a.m., kalyan kumar k
ode to me sure of
it.
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54454/#review159250
---
On Feb. 28, 2017, 12
/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
2dc8af8
Diff: https://reviews.apache.org/r/56954/diff/
Testing
---
Thanks,
kalyan kumar kalvagadda
: https://reviews.apache.org/r/54798/diff/
Testing
---
I have performed tests using Sentrytool Client.
Thanks,
kalyan kumar kalvagadda
/tests/e2e/hdfs/TestHDFSIntegrationBase.java
0239388
Diff: https://reviews.apache.org/r/54798/diff/
Testing
---
I have performed tests using Sentrytool Client.
Thanks,
kalyan kumar kalvagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57065/#review167146
---
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Feb. 25
the same with Sentry thrift client.
Run unit test cases of TestSentryStore.
Thanks,
kalyan kumar kalvagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54947/#review167142
---
- kalyan kumar kalvagadda
On Feb. 28, 2017, 9:30 p.m., kalyan
he character and collation as well. e.g. `PERM_CHANGE`
> > VARCHAR(4000) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL
>
> kalyan kumar kalvagadda wrote:
> There are certain tables like MAUTHZPATHSMAPPING_PATHS amd
> AUTHZ_PATHS_MAPPING, where this is not followed. I feel, it sh
for deby.
Thanks,
kalyan kumar kalvagadda
/provider/db/service/thrift/validator/RevokePrivilegeRequestValidator.java
PRE-CREATION
Diff: https://reviews.apache.org/r/54454/diff/7/
Changes: https://reviews.apache.org/r/54454/diff/6-7/
Testing
---
Verfied the changes using sentry thrift client.
Thanks,
kalyan kumar kalvagadda
/SentryPolicyServiceClientDefaultImpl.java
2dc8af8
Diff: https://reviews.apache.org/r/56954/diff/
Testing
---
Thanks,
kalyan kumar kalvagadda
://reviews.apache.org/r/54798/diff/
Testing
---
I have performed tests using Sentrytool Client.
Thanks,
kalyan kumar kalvagadda
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56954/#review166838
---
On Feb. 27, 2017, 11:53 p.m., kalyan kumar kalvagadda wrote:
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54525/#review158541
---
Ship it!
Looks good
- kalyan kumar kalvagadda
On Dec. 8
see if were are properly updating/removing the privialges
stroed in sentry store when the Authorizable entities are altered/droped.
- kalyan kumar kalvagadda
On Dec. 8, 2016, 9:02 a.m., Vamsee Yarlagadda wrote:
>
> ---
> Thi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/#review158155
---
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Dec. 3, 2016
://reviews.apache.org/r/54798/diff/
Testing
---
I have performed tests using Sentrytool Client.
Thanks,
kalyan kumar kalvagadda
/
Testing
---
I have done unit tests using sentry cli thrift client.
Thanks,
kalyan kumar kalvagadda
://reviews.apache.org/media/uploaded/files/2016/12/14/4c275619-1d37-42a0-a64b-c0e0752a8a63__SENTRY-1547.002.patch
Thanks,
kalyan kumar kalvagadda
s an invalid input. Should be addressed.
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54445/#review158238
-----------
O
/files/2016/12/14/88c4a123-316d-4ef4-8670-ad38d260f8cb__SENTRY-1547.002.patch
Thanks,
kalyan kumar kalvagadda
://reviews.apache.org/r/54454/diff/
Testing
---
Verfied the changes using sentry thrift client.
Thanks,
kalyan kumar kalvagadda
I thought creates a
template file and let lets update it.
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54454/#review158278
---
I will probably publish complete diff and appropriately docuement just for
review.
- kalyan kumar kalvagadda
On Dec. 14, 2016, 10:38 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generated
jetty.
- kalyan kumar kalvagadda
On Jan. 11, 2017, 1:35 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
oracle documentation says they support it.
- kalyan kumar kalvagadda
On Jan. 5, 2017, 9:04 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
(lines 1080 - 1083)
<https://reviews.apache.org/r/54454/#comment231767>
There is no string funtion that can perform a null check for you. Best way
is to do perform a null check.
- kalyan kumar kalvagadda
On Jan. 5, 2017
/sentry/provider/db/service/model/MSentryPermChange.java
(line 49)
<https://reviews.apache.org/r/54729/#comment231928>
Will this function be used?
- kalyan kumar kalvagadda
On Dec. 14, 2016, 2:35 a.m., Hao Hao
> (Updated Dec. 14, 2016, 2:35 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and
> Vamsee Yarlagadda.
>
>
> Repository: sentry
>
>
> Description
> ---
>
> Create schema for storing HMS path change and S
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52795/#review160747
---
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Dec. 20
make sure that user who is performing this is authorized to do
perform it.
Should we be doing similar check here?
- kalyan kumar kalvagadda
On Jan. 6, 2017, 1:37 a.m., Hao Hao wrote:
>
> ---
> This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54525/#review160422
---
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Jan. 3, 2017
apache/sentry/service/thrift/SentryService.java
(line 170)
<https://reviews.apache.org/r/52795/#comment231016>
Should have else block to start SentryMetastorePostEventListener thread.
- kalyan kumar kalvagadda
On Dec. 20, 2016, 12:21 a.m., H
/54454/diff/
Testing
---
Verfied the changes using sentry thrift client.
Thanks,
kalyan kumar kalvagadda
our we rather not do any code changes.
- kalyan kumar kalvagadda
On Dec. 16, 2016, 9:17 p.m., Vamsee Yarlagadda wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
the scenarios mentioned in description.
Also tested the same with Sentry thrift client.
Run unit test cases of TestSentryStore.
Thanks,
kalyan kumar kalvagadda
kumar kalvagadda
generated e-mail. To reply, visit:
https://reviews.apache.org/r/56954/#review168685
-----------
On March 22, 2017, 11:05 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> Thi
exception meesage.
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56954/#review168858
---
On March 22, 2017, 11:05 p.m.,
662752#file1662752line57>
> >
> > could you, please, add javadoc on thread safety of this class?
>
> kalyan kumar kalvagadda wrote:
> Thrift clients are not thread safe. The client object could be shared
> used by multiple threads running at client side. All the pub
/TestPoolClientInvocationHandler.java
7292387
Diff: https://reviews.apache.org/r/57901/diff/2/
Changes: https://reviews.apache.org/r/57901/diff/1-2/
Testing
---
Thanks,
kalyan kumar kalvagadda
,
kalyan kumar kalvagadda
/58164/diff/2/
Changes: https://reviews.apache.org/r/58164/diff/1-2/
Testing
---
Thanks,
kalyan kumar kalvagadda
-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql
db010bcd7792c9370478a2061e22d14bb78e3184
Diff: https://reviews.apache.org/r/58164/diff/3/
Changes: https://reviews.apache.org/r/58164/diff/2-3/
Testing
---
Thanks,
kalyan kumar kalvagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58164/#review170983
---
- kalyan kumar kalvagadda
On April 4, 2017, 5:05 p.m., kalyan
constriant
inline, I had comment asking to have it outside for the same reason.
- kalyan kumar
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58267/#review171381
e not looked at the logic in namenode plug-in. If we can change that
logic to handle monotonically increasing change ID's, that is best way to go.
- kalyan kumar kalvagadda
On April 10, 2017, 7:54 p.m., Lei Xu wrote:
>
> ---
> Thi
we let Hao commit in her changes which are blocking
the HA functinoality.
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58267/#review171451
-----------
ntion
most of the Exception classes have these constrcutors defined. If not now, they
can be used later.
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57901/#review170070
; >
> > Please add some comments to this utility class.
This was existing file. I just moved it to another location. I will anyway add
javadoc for this class.
- kalyan kumar
---
This is an automatically gen
/thrift/TestPoolClientInvocationHandler.java
7292387
Diff: https://reviews.apache.org/r/57901/diff/3/
Changes: https://reviews.apache.org/r/57901/diff/2-3/
Testing
---
Thanks,
kalyan kumar kalvagadda
-provider-db/src/test/java/org/apache/sentry/service/thrift/TestPoolClientInvocationHandler.java
7292387
Diff: https://reviews.apache.org/r/57901/diff/2/
Testing
---
Thanks,
kalyan kumar kalvagadda
that the actual issues is addressed.
Thanks,
kalyan kumar kalvagadda
s/sentry-upgrade-db2-1.7.0-to-1.8.0.sql
> 5376c166659b3e8e373c8c20818f5b1290af90c9
>
>
> Diff: https://reviews.apache.org/r/58164/diff/7/
>
>
> Testing
> ---
>
> I have tested it against derby, oracle, postgres, mysql and db2.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Diff: https://reviews.apache.org/r/58164/diff/6/
Changes: https://reviews.apache.org/r/58164/diff/5-6/
Testing
---
Thanks,
kalyan kumar kalvagadda
, mysql and db2.
Thanks,
kalyan kumar kalvagadda
-to-1.8.0.sql
db010bcd7792c9370478a2061e22d14bb78e3184
Diff: https://reviews.apache.org/r/58164/diff/5/
Changes: https://reviews.apache.org/r/58164/diff/4-5/
Testing
---
Thanks,
kalyan kumar kalvagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58412/#review172041
---
- kalyan kumar kalvagadda
On April 13, 2017, 6:58 a.m., Hao Hao
thrift/HMSFollower.java
Line 394 (original), 384 (patched)
<https://reviews.apache.org/r/58412/#comment245104>
When a view is created, location will be empty. Such events should be
ignored instead of throwing exceptions.
- kalyan kumar kalvagadda
On April 13, 2017, 6:58 a.m., H
/
Changes: https://reviews.apache.org/r/57901/diff/3-4/
Testing
---
Thanks,
kalyan kumar kalvagadda
I agree with Sergio but I'm not sure if current plan is to release HA
functionality.
If we plan to make it a release, we need to make sure sentry HA works with
one of the versions of Hive where
1. Notification log implementation has the functionality that sentry
needs.
2. Supports
://reviews.apache.org/r/58536/diff/1/
Testing
---
Thanks,
kalyan kumar kalvagadda
Hello Avinash,
If I may ask. What is the need to develop new Sentry Binding and Authorizer.
There is a generic sentry plug-in to handle generic cases.
If you can elaborate your case. It might help people to suggest you if you
could re-use existing plug-in's.
-Kalyan
-Kalyan
On Thu, Apr
ched)
<https://reviews.apache.org/r/58221/#comment245044>
curly braces be in the same line. This comments applies couple of places
below. Make sure you correct it.
- kalyan kumar kalvagadda
On April 14, 2017, 3:41
truction -
> > they never change so there is no need to do it on every connect
Will make that change.
- kalyan kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57901/#review172044
---
/sentry/service/thrift/HMSFollower.java
Lines 74 (patched)
<https://reviews.apache.org/r/58481/#comment245336>
SENTRY-1587 is addressing this issue. There is no need to make this change
again.
- kalyan kumar kalvagadda
On April 18, 2017, 4:29 a.m., Na Li
/provider/db/service/thrift/validator/RevokePrivilegeRequestValidator.java
PRE-CREATION
Diff: https://reviews.apache.org/r/54454/diff/8/
Changes: https://reviews.apache.org/r/54454/diff/7-8/
Testing
---
Verfied the changes using sentry thrift client.
Thanks,
kalyan kumar kalvagadda
> On March 2, 2017, 5:40 p.m., kalyan kumar kalvagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
> > Lines 287 (patched)
> > <https://reviews.apache.org/r/57220/diff/2/?file=1652981#file1652981lin
hen up till we see ValueEvent object(e) which meets below condition
.getValue() > value
- kalyan kumar kalvagadda
On March 3, 2017, 3:08 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mai
/db/service/thrift/validator/RevokePrivilegeRequestValidator.java
PRE-CREATION
Diff: https://reviews.apache.org/r/54454/diff/9/
Changes: https://reviews.apache.org/r/54454/diff/8-9/
Testing
---
Verfied the changes using sentry thrift client.
Thanks,
kalyan kumar kalvagadda
To reply, visit:
> https://reviews.apache.org/r/57219/
> ---
>
> (Updated March 3, 2017, 3:08 a.m.)
>
>
> Review request for sentry, Misha Dmitriev, Lei Xu, Hao Hao, kalyan kumar
> kalvagadda, Mat Crocke
the scenarios mentioned in description.
Also tested the same with Sentry thrift client.
Run unit test cases of TestSentryStore.
Thanks,
kalyan kumar kalvagadda
1 - 100 of 842 matches
Mail list logo
