Re: 回复: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

2018-03-07 Thread Mohammad Asif Siddiqui
Thanks YangBo and Cuiyihua for the suggestion. We will move the frontend configurations to the app.conf and add the frontend starting guide in the main Readme, so from here on there will be only 1 Readme and 1 conf which can be used by both frontend and service-center. Coming back to

?????? [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

2018-03-07 Thread Sure
Suggestion: merge these configures in SC app.conf, and move the frontend readme into main readme. -- -- ??: "Yang Bo"; : 2018??3??8??(??) 3:36 ??: "dev"; : Re: [VOTE] Release

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1

2018-03-07 Thread Yang Bo
Hi Asif, For the first issue, It's OK that we leave it as is in this release. But in the long run, it's still better to put the configurations together(the frontend.conf file). On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi YangBo, > > Thanks for

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1

2018-03-07 Thread Mohammad Asif Siddiqui
Hi YangBo, Thanks for your vote. We will fix the 2nd and 3rd Issue. For 1st Issue I would like to clear that the hardcode values are in js files which can be modifies easily afterwards in the release, which we have already mentioned in our Readme over here [1] [1]

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1

2018-03-07 Thread Yang Bo
-1 Binding Vote. Below Checks Done: 1. Verified the md5sum, sha1sum and GPG signature for source and binary release packages. 2. Verified the service-center linux release using Java Chassis BMI sample. 3. Verified the frontend on both windows and linux. 4. Checked the bundled files, no fonts and

RE: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1

2018-03-07 Thread Sukesh A C
+1 Binding Vote. Below Checks Done: 1. Verify the file signature. 2. Verified windows release for service center using java chassis demo. 3. Ran the Service-Center and Frontend, verified basic functionality of service center and frontend. Thanks, Sukesh. -Original Message-

[GitHub] coveralls commented on issue #575: [SCB-369] Extract info from spectator measurement

2018-03-07 Thread GitBox
coveralls commented on issue #575: [SCB-369] Extract info from spectator measurement URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/575#issuecomment-371080516 [![Coverage

[GitHub] wujimin commented on a change in pull request #575: [SCB-369] Extract info from spectator measurement

2018-03-07 Thread GitBox
wujimin commented on a change in pull request #575: [SCB-369] Extract info from spectator measurement URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/575#discussion_r173049020 ## File path:

[GitHub] coveralls commented on issue #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
coveralls commented on issue #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#issuecomment-371065084 [![Coverage

?????? Supportting groovy on edge service

2018-03-07 Thread bismy
Maybe we first need to give the business model for this use case or we can just give a integration of groovy in edge and it's not a big deal. And edge service may be deployed many instances and how to manage dynamic uploading means many security concerns. --

[GitHub] WillemJiang commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
WillemJiang commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r173032038 ## File path:

[VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1

2018-03-07 Thread Mohammad Asif Siddiqui
Hi All, This is a call for Vote to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1 (second release candidate). Release Notes : https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate :

[GitHub] zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172820941 ## File path:

[GitHub] gupadhyaya commented on issue #298: Some questions about PACT broker in SC

2018-03-07 Thread GitBox
gupadhyaya commented on issue #298: Some questions about PACT broker in SC URL: https://github.com/apache/incubator-servicecomb-service-center/issues/298#issuecomment-371140880 @little-cui @asifdxtreme 1. No, there is no example to show the broker feature with the 3rd party pact

[GitHub] asifdxtreme closed pull request #299: SCB-317 Merge frontend & service-center release

2018-03-07 Thread GitBox
asifdxtreme closed pull request #299: SCB-317 Merge frontend & service-center release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/299 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] zhengyangyong commented on issue #572: [SCB-370] Improve latency and max precision

2018-03-07 Thread GitBox
zhengyangyong commented on issue #572: [SCB-370] Improve latency and max precision URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/572#issuecomment-371125337 ???MonitorRegistry??MetricsUtils.convertMeasurements 1./metrics

[GitHub] zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172825837 ## File path:

[GitHub] zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172825692 ## File path:

[GitHub] zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172825629 ## File path:

[GitHub] zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172825108 ## File path:

[GitHub] asifdxtreme commented on issue #299: SCB-317 Merge frontend & service-center release

2018-03-07 Thread GitBox
asifdxtreme commented on issue #299: SCB-317 Merge frontend & service-center release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/299#issuecomment-371120106 @WillemJiang for source release we download it from github using tag, and then we sign it So

[GitHub] zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
zhengyangyong commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172820941 ## File path:

[GitHub] codecov-io commented on issue #299: SCB-317 Merge frontend & service-center release

2018-03-07 Thread GitBox
codecov-io commented on issue #299: SCB-317 Merge frontend & service-center release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/299#issuecomment-371108976 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/299?src=pr=h1)

[GitHub] coveralls commented on issue #299: SCB-317 Merge frontend & service-center release

2018-03-07 Thread GitBox
coveralls commented on issue #299: SCB-317 Merge frontend & service-center release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/299#issuecomment-371108925 [![Coverage

[GitHub] asifdxtreme opened a new pull request #299: SCB-317 Merge frontend & service-center release

2018-03-07 Thread GitBox
asifdxtreme opened a new pull request #299: SCB-317 Merge frontend & service-center release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/299 Signed-off-by: asifdxtreme Follow this checklist to help us incorporate your

[GitHub] coveralls commented on issue #577: [SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side

2018-03-07 Thread GitBox
coveralls commented on issue #577: [SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/577#issuecomment-371106161 [![Coverage

[GitHub] wujimin commented on a change in pull request #575: [SCB-369] Extract info from spectator measurement

2018-03-07 Thread GitBox
wujimin commented on a change in pull request #575: [SCB-369] Extract info from spectator measurement URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/575#discussion_r172802250 ## File path:

[GitHub] yhs0092 opened a new pull request #577: SCB-352 refactor QpsControllerManager, support operation level qps controll on provider side

2018-03-07 Thread GitBox
yhs0092 opened a new pull request #577: SCB-352 refactor QpsControllerManager, support operation level qps controll on provider side URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/577 Follow this checklist to help us incorporate your contribution quickly and

[GitHub] WillemJiang commented on issue #145: when mvn package -DskipTests -Pdocker -Pdemo can't find saga-persistence-jpa:jar:0.0.3-SNAPSHOT

2018-03-07 Thread GitBox
WillemJiang commented on issue #145: when mvn package -DskipTests -Pdocker -Pdemo can't find saga-persistence-jpa:jar:0.0.3-SNAPSHOT URL: https://github.com/apache/incubator-servicecomb-saga/issues/145#issuecomment-371097193 The bug should fix, @eumji025 Could you verify it and reopen

[GitHub] WillemJiang closed pull request #573: [SCB-368] supports openssl engine for ssl communication

2018-03-07 Thread GitBox
WillemJiang closed pull request #573: [SCB-368] supports openssl engine for ssl communication URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/573 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] WillemJiang commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
WillemJiang commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172798474 ## File path:

[GitHub] WillemJiang closed pull request #146: [SCB-346] Add saga-persistence back

2018-03-07 Thread GitBox
WillemJiang closed pull request #146: [SCB-346] Add saga-persistence back URL: https://github.com/apache/incubator-servicecomb-saga/pull/146 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] coveralls commented on issue #575: [SCB-369] Extract info from spectator measurement

2018-03-07 Thread GitBox
coveralls commented on issue #575: [SCB-369] Extract info from spectator measurement URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/575#issuecomment-371080516 [![Coverage

[GitHub] wujimin commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
wujimin commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172777876 ## File path:

[GitHub] wujimin commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
wujimin commented on a change in pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172777044 ## File path:

[GitHub] mt-monster opened a new issue #576: ??????RegistryUtils??????

2018-03-07 Thread GitBox
mt-monster opened a new issue #576: ??RegistryUtils?? URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/576 BeanUtils??RegistryUtils???serviceRegistryBean???Bean?Bean??

[GitHub] wujimin opened a new pull request #575: Extract info from spectator measurement

2018-03-07 Thread GitBox
wujimin opened a new pull request #575: Extract info from spectator measurement URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/575 ![image](https://user-images.githubusercontent.com/16874843/37082878-b0d9ad16-2228-11e8-8ac2-0ce060c2a43c.png)

[GitHub] coveralls commented on issue #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
coveralls commented on issue #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#issuecomment-371065084 [![Coverage

[GitHub] zhengyangyong opened a new pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port

2018-03-07 Thread GitBox
zhengyangyong opened a new pull request #574: [SCB-372] support user set metrics prometheus exporter address not only port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574 ? port Signed-off-by: zhengyangyong Follow this