[GitHub] little-cui closed pull request #268: [SCB-260] Update NOTICE

2018-02-02 Thread GitBox
little-cui closed pull request #268: [SCB-260] Update NOTICE URL: https://github.com/apache/incubator-servicecomb-service-center/pull/268 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

Re: [Discussion] Security concerns of Saga pack

2018-02-02 Thread Willem Jiang
Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Fri, Feb 2, 2018 at 4:44 PM, Eric Lee wrote: > Currently, there are two known security concerns in Saga pack: > > *1.

[GitHub] little-cui closed pull request #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
little-cui closed pull request #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/270 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] seanyinx commented on a change in pull request #122: SCB-239 omega stateless

2018-02-02 Thread GitBox
seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165662755 ## File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxConsistentService.java

[GitHub] seanyinx commented on a change in pull request #122: SCB-239 omega stateless

2018-02-02 Thread GitBox
seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165665944 ## File path:

[GitHub] seanyinx commented on a change in pull request #122: SCB-239 omega stateless

2018-02-02 Thread GitBox
seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165667413 ## File path: alpha/alpha-core/src/test/java/org/apache/servicecomb/saga/alpha/core/TxConsistentServiceTest.java

[GitHub] little-cui closed pull request #269: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
little-cui closed pull request #269: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/269 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] asifdxtreme opened a new pull request #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
asifdxtreme opened a new pull request #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/270 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure

[GitHub] coveralls commented on issue #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
coveralls commented on issue #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/270#issuecomment-362588694 [![Coverage

Re: [Discussion] Security concerns of Saga pack

2018-02-02 Thread Zheng Feng
Does the user view the transaction events through the restful service of the alpha server ? I think we need an authentication mechanism rather than the tenant or application id. The gPRC looks like to support the SSL/TLS. 2018-02-02 21:04 GMT+08:00 Willem Jiang : > Willem

[GitHub] coveralls commented on issue #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
coveralls commented on issue #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/270#issuecomment-362588694 [![Coverage

[GitHub] codecov-io commented on issue #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
codecov-io commented on issue #270: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/270#issuecomment-362588647 #

[GitHub] coveralls commented on issue #271: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
coveralls commented on issue #271: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/271#issuecomment-362609022 [![Coverage

[GitHub] seanyinx commented on a change in pull request #122: SCB-239 omega stateless

2018-02-02 Thread GitBox
seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165664465 ## File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxEvent.java ## @@

[GitHub] seanyinx commented on a change in pull request #122: SCB-239 omega stateless

2018-02-02 Thread GitBox
seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165667611 ## File path:

[GitHub] coveralls commented on issue #273: SCB-317 Update the cors license

2018-02-02 Thread GitBox
coveralls commented on issue #273: SCB-317 Update the cors license URL: https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648705 [![Coverage Status](https://coveralls.io/builds/15348223/badge)](https://coveralls.io/builds/15348223) Coverage

[GitHub] codecov-io commented on issue #273: SCB-317 Update the cors license

2018-02-02 Thread GitBox
codecov-io commented on issue #273: SCB-317 Update the cors license URL: https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648774 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=h1) Report > Merging

[GitHub] seanyinx commented on a change in pull request #122: SCB-239 omega stateless

2018-02-02 Thread GitBox
seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165667051 ## File path: alpha/alpha-server/src/main/resources/schema-postgresql.sql ## @@ -30,3 +31,15 @@ CREATE

[GitHub] seanyinx commented on a change in pull request #122: SCB-239 omega stateless

2018-02-02 Thread GitBox
seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165664602 ## File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxEvent.java ## @@

[GitHub] asifdxtreme opened a new pull request #272: SCB-317 Use CDN Servers to resolve front-end dependencies

2018-02-02 Thread GitBox
asifdxtreme opened a new pull request #272: SCB-317 Use CDN Servers to resolve front-end dependencies URL: https://github.com/apache/incubator-servicecomb-service-center/pull/272 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure

[GitHub] asifdxtreme opened a new pull request #273: SCB-317 Update the cors license

2018-02-02 Thread GitBox
asifdxtreme opened a new pull request #273: SCB-317 Update the cors license URL: https://github.com/apache/incubator-servicecomb-service-center/pull/273 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[GitHub] codecov-io commented on issue #272: SCB-317 Use CDN Servers to resolve front-end dependencies

2018-02-02 Thread GitBox
codecov-io commented on issue #272: SCB-317 Use CDN Servers to resolve front-end dependencies URL: https://github.com/apache/incubator-servicecomb-service-center/pull/272#issuecomment-362645164 #

[GitHub] coveralls commented on issue #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto?

2018-02-02 Thread GitBox
coveralls commented on issue #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#issuecomment-362558547 [![Coverage

[GitHub] coveralls commented on issue #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto?

2018-02-02 Thread GitBox
coveralls commented on issue #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#issuecomment-362558547 [![Coverage

[GitHub] little-cui opened a new pull request #274: SCB-317 Use the ServiceComb/paas-lager.

2018-02-02 Thread GitBox
little-cui opened a new pull request #274: SCB-317 Use the ServiceComb/paas-lager. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/274 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] codecov-io commented on issue #273: SCB-317 Update the cors license

2018-02-02 Thread GitBox
codecov-io commented on issue #273: SCB-317 Update the cors license URL: https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648774 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/273?src=pr=h1) Report > Merging

[GitHub] coveralls commented on issue #273: SCB-317 Update the cors license

2018-02-02 Thread GitBox
coveralls commented on issue #273: SCB-317 Update the cors license URL: https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648705 [![Coverage Status](https://coveralls.io/builds/15356336/badge)](https://coveralls.io/builds/15356336) Coverage

Re: [TO ALL]About Metrics publish style

2018-02-02 Thread wjm wjm
1.min is usless, and spectator already removed min support 2.here statistic mixed statistic and stage, why? 3.we will publish common raw data like spring cloud from maybe by /metrics 4.we will publish our metrics model maybe by /metrics/servicecomb 2018-02-03 10:12 GMT+08:00 郑扬勇

[GitHub] WillemJiang closed pull request #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto?

2018-02-02 Thread GitBox
WillemJiang closed pull request #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/546 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] WillemJiang closed pull request #547: [SCB-320] remove custom metrics service

2018-02-02 Thread GitBox
WillemJiang closed pull request #547: [SCB-320] remove custom metrics service URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/547 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] little-cui closed pull request #271: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
little-cui closed pull request #271: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/271 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] codecov-io commented on issue #274: SCB-317 Use the ServiceComb/paas-lager.

2018-02-02 Thread GitBox
codecov-io commented on issue #274: SCB-317 Use the ServiceComb/paas-lager. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/274#issuecomment-362783913 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/274?src=pr=h1) Report >

[GitHub] coveralls commented on issue #274: SCB-317 Use the ServiceComb/paas-lager.

2018-02-02 Thread GitBox
coveralls commented on issue #274: SCB-317 Use the ServiceComb/paas-lager. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/274#issuecomment-362783873 [![Coverage Status](https://coveralls.io/builds/15356169/badge)](https://coveralls.io/builds/15356169)

?????? [TO ALL]About Metrics publish style

2018-02-02 Thread ??????
Hi wjm: 1.OK 2.So we need add a new tag stage like : servicecomb.invocation(statistic=latency.average,stage=execution,type=producer,operation=,transport=rest,status=200) servicecomb.invocation(statistic=latency.max,stage=execution,type=producer,operation=,transport=rest,status=200)

[GitHub] coveralls commented on issue #273: SCB-317 Update the cors license

2018-02-02 Thread GitBox
coveralls commented on issue #273: SCB-317 Update the cors license URL: https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362648705 [![Coverage Status](https://coveralls.io/builds/15356329/badge)](https://coveralls.io/builds/15356329) Coverage

[GitHub] asifdxtreme commented on issue #272: SCB-317 Use CDN Servers to resolve front-end dependencies

2018-02-02 Thread GitBox
asifdxtreme commented on issue #272: SCB-317 Use CDN Servers to resolve front-end dependencies URL: https://github.com/apache/incubator-servicecomb-service-center/pull/272#issuecomment-362785641 This PR removes all the bower_components which were earlier added to the code to make the

[GitHub] asifdxtreme commented on issue #273: SCB-317 Update the cors license

2018-02-02 Thread GitBox
asifdxtreme commented on issue #273: SCB-317 Update the cors license URL: https://github.com/apache/incubator-servicecomb-service-center/pull/273#issuecomment-362785354 @WillemJiang Thanks for the suggestion, I have removed the ASl header and added a comment that original code was

[GitHub] coveralls commented on issue #547: [SCB-320] remove custom metrics service

2018-02-02 Thread GitBox
coveralls commented on issue #547: [SCB-320] remove custom metrics service URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/547#issuecomment-362763016 [![Coverage Status](https://coveralls.io/builds/15354758/badge)](https://coveralls.io/builds/15354758)

[GitHub] WillemJiang commented on a change in pull request #273: SCB-317 Update the cors license

2018-02-02 Thread GitBox
WillemJiang commented on a change in pull request #273: SCB-317 Update the cors license URL: https://github.com/apache/incubator-servicecomb-service-center/pull/273#discussion_r165797883 ## File path: server/interceptor/cors/cors.go ## @@ -14,6 +14,28 @@ * See the

[GitHub] coveralls commented on issue #548: [SCB-326] Remove custom EventBus an replace with Already Exists EventManager

2018-02-02 Thread GitBox
coveralls commented on issue #548: [SCB-326] Remove custom EventBus an replace with Already Exists EventManager URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-362765697 [![Coverage

[GitHub] zhengyangyong opened a new pull request #548: [SCB-326] Remove custom EventBus an replace with Already Exists EventManager

2018-02-02 Thread GitBox
zhengyangyong opened a new pull request #548: [SCB-326] Remove custom EventBus an replace with Already Exists EventManager URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548 ?google EventBus because it is good enough Signed-off-by: zhengyangyong

[GitHub] wujimin commented on a change in pull request #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto?

2018-02-02 Thread GitBox
wujimin commented on a change in pull request #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#discussion_r165800125 ## File path:

[GitHub] zhengyangyong opened a new pull request #547: [SCB-320] remove custom metrics service

2018-02-02 Thread GitBox
zhengyangyong opened a new pull request #547: [SCB-320] remove custom metrics service URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/547 ?ism later Signed-off-by: zhengyangyong Follow this checklist to help us incorporate

[GitHub] jeho0815 commented on a change in pull request #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto?

2018-02-02 Thread GitBox
jeho0815 commented on a change in pull request #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#discussion_r165799469 ## File path:

[TO ALL]About Metrics publish style

2018-02-02 Thread ??????
Hello everyone: Considering we need support user custom metrics better,we must publish metrics data as a more friendly style. Before we direct publish RegistryMetric model and support convert it into plain key value style like : servicecomb.instance.system.cpu.load

[GitHub] jeho0815 opened a new pull request #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto?

2018-02-02 Thread GitBox
jeho0815 opened a new pull request #546: SCB-315 Config Center module can't get config by DynamicPropertyFacto? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/546 ?ry.getInstance().getStringProperty, so has to use ConcurrentCompositeConfiguration Follow this

[GitHub] coveralls commented on issue #269: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
coveralls commented on issue #269: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/269#issuecomment-362558642 [![Coverage

[GitHub] little-cui opened a new pull request #269: SCB-317 Prepare the release for Service-Center-1.0.0-m1

2018-02-02 Thread GitBox
little-cui opened a new pull request #269: SCB-317 Prepare the release for Service-Center-1.0.0-m1 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/269 (cherry picked from commit b16e646) Follow this checklist to help us incorporate your contribution quickly

[GitHub] coveralls commented on issue #267: SCB-321 Support report trace data

2018-02-02 Thread GitBox
coveralls commented on issue #267: SCB-321 Support report trace data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/267#issuecomment-362264980 [![Coverage Status](https://coveralls.io/builds/15340437/badge)](https://coveralls.io/builds/15340437)

[GitHub] coveralls commented on issue #267: SCB-321 Support report trace data

2018-02-02 Thread GitBox
coveralls commented on issue #267: SCB-321 Support report trace data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/267#issuecomment-362264980 [![Coverage Status](https://coveralls.io/builds/15340664/badge)](https://coveralls.io/builds/15340664)

[GitHub] WillemJiang closed pull request #545: [SCB-260] Clarify original copyright of some files

2018-02-02 Thread GitBox
WillemJiang closed pull request #545: [SCB-260] Clarify original copyright of some files URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/545 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] zhengyangyong closed pull request #540: [SCB-320] Feature adjustment for 1.0.0-m1 publish

2018-02-02 Thread GitBox
zhengyangyong closed pull request #540: [SCB-320] Feature adjustment for 1.0.0-m1 publish URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/540 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] zhengyangyong commented on issue #540: [SCB-320] Feature adjustment for 1.0.0-m1 publish

2018-02-02 Thread GitBox
zhengyangyong commented on issue #540: [SCB-320] Feature adjustment for 1.0.0-m1 publish URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/540#issuecomment-362530385 This PR will split to three smaller PR

[GitHub] little-cui closed pull request #267: SCB-321 Support report trace data

2018-02-02 Thread GitBox
little-cui closed pull request #267: SCB-321 Support report trace data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/267 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] coveralls commented on issue #541: [SCB-314] Support custom rest transport server compress and max header ?

2018-02-02 Thread GitBox
coveralls commented on issue #541: [SCB-314] Support custom rest transport server compress and max header ? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/541#issuecomment-361843381 [![Coverage