Re: Dynamic configuration support

2017-12-15 Thread Willem Jiang
Hi Bo, It's a good feature to support user to change the configuration dynamically from a configure server. Please let us know your research result and made a proposal in the community. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese)

Re: Clean up the license header

2017-12-15 Thread Jean-Baptiste Onofré
Understood. Thanks for the update. Regards JB On 12/15/2017 04:34 PM, Willem Jiang wrote: Change the package name could cause some trouble for the user to update their code. As we are using the vender neutral package name already, it could save us time to still use the io.servicecomb, but I

Re: Clean up the license header

2017-12-15 Thread Willem Jiang
Change the package name could cause some trouble for the user to update their code. As we are using the vender neutral package name already, it could save us time to still use the io.servicecomb, but I think it should be OK we can update the groupid to org.apache.servicecomb. Willem Jiang

refactor/rewrite service registry module in Java Chassis

2017-12-19 Thread Eric Lee
Hi, all We plan to refactor/rewrite the service registry module in Java Chassis. This module is mainly responsible for the interaction between service center and the microservices developed by Java Chassis, namely, client side implementation for service registration and discovery. The analysis of

Re: Clean up the license header

2017-12-12 Thread Jean-Baptiste Onofré
Hi, Good one. I will take a look on the other legal (NOTICE, DISCLAIMER, LICENSE files + package names etc). Regards JB On 12/12/2017 01:23 PM, Willem Jiang wrote: Hi, As we are moving to Apache repo, we need to updated the code header with ASL headers. I just had quick check with

[GitHub] wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

2018-05-04 Thread GitBox
wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r186154112 ## File path:

[GitHub] wenj91 opened a new pull request #184: (#182 )update the length of field serviceName from varchar(16) to varchar(36)

2018-05-04 Thread GitBox
wenj91 opened a new pull request #184: (#182 )update the length of field serviceName from varchar(16) to varchar(36) URL: https://github.com/apache/incubator-servicecomb-saga/pull/184 (#182 )update the length of field serviceName from varchar(16) to varchar(36) Follow this checklist

[GitHub] wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

2018-05-04 Thread GitBox
wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r186153321 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-04 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186251016 ## File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperHandler.java

[GitHub] coveralls commented on issue #690: [SCB-529] producer download file from byte[]

2018-05-04 Thread GitBox
coveralls commented on issue #690: [SCB-529] producer download file from byte[] URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/690#issuecomment-386776381 [![Coverage Status](https://coveralls.io/builds/16846112/badge)](https://coveralls.io/builds/16846112)

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-04 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186250923 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-04 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186250938 ## File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperHandler.java

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-04 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186251088 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-04 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186251045 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-04 Thread GitBox
wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186251122 ## File path:

[GitHub] wenj91 closed issue #182: ERROR: value too long for type character varying(16)

2018-05-04 Thread GitBox
wenj91 closed issue #182: ERROR: value too long for type character varying(16) URL: https://github.com/apache/incubator-servicecomb-saga/issues/182 This is an automated message from the Apache Git Service. To respond to the

[GitHub] WillemJiang commented on issue #184: SCB-545 (#182 )update the length of field serviceName from varchar(16) to varchar(36)

2018-05-04 Thread GitBox
WillemJiang commented on issue #184: SCB-545 (#182 )update the length of field serviceName from varchar(16) to varchar(36) URL: https://github.com/apache/incubator-servicecomb-saga/pull/184#issuecomment-386762049 Thanks for the help @wenj91.

[GitHub] WillemJiang closed pull request #184: SCB-545 (#182 )update the length of field serviceName from varchar(16) to varchar(36)

2018-05-04 Thread GitBox
WillemJiang closed pull request #184: SCB-545 (#182 )update the length of field serviceName from varchar(16) to varchar(36) URL: https://github.com/apache/incubator-servicecomb-saga/pull/184 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] zhengyangyong commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes

2018-05-06 Thread GitBox
zhengyangyong commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77#discussion_r186284440 ## File path: _users/cn/develop-with-transparent-rpc.md ## @@ -130,6 +137,10

[GitHub] WillemJiang closed pull request #77: Add Notes for providers and fix FAQ mistakes

2018-05-06 Thread GitBox
WillemJiang closed pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mt-monster opened a new pull request #692: [SCB-543]optimize registry procedure

2018-05-06 Thread GitBox
mt-monster opened a new pull request #692: [SCB-543]optimize registry procedure URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] wujimin commented on issue #690: [SCB-529] producer download file from byte[]

2018-05-06 Thread GitBox
wujimin commented on issue #690: [SCB-529] producer download file from byte[] URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/690#issuecomment-386955750 infact, maybe it's not a good practic 1.if byte[] come from file, then return file is better 2.if byte[]

[GitHub] hank-whu commented on issue #685: 怎样平滑关闭Client?

2018-05-07 Thread GitBox
hank-whu commented on issue #685: 怎样平滑关闭Client? URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/685#issuecomment-386971260 不行的,还是有线程没被正确关闭 ```java Non-finished threads: Thread[transport-vert.x-eventloop-thread-3,5,main] at

Re: About java-chassis documents improvements

2018-05-07 Thread Willem Jiang
Hi Liubao, It's quite important that we have a good document of user guide, it could save us lots of time to answer the question from user. As ASF is vendor neutral, we need to remove the CSE related contents before contribute the ServiceComb Java Chassis. I think we could link the gitbook in

Re: [Discussion]Java Chassis Support Gracefully Shutdown

2018-05-07 Thread Yang Bo
Yes, I'll send an email of all the status of ongoing issues by tomorrow. We can discuss this then. On Mon, May 7, 2018 at 5:34 PM, Zen Lin wrote: > Hi YanBo, > > I think which release version can conclude the graceful shutdown is just > another topic, > but task

[GitHub] little-cui opened a new pull request #340: Update beego version 1.8.0

2018-05-07 Thread GitBox
little-cui opened a new pull request #340: Update beego version 1.8.0 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/340 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] JokerLoveAllen closed issue #183: Can i use feign and saga in project ?

2018-05-07 Thread GitBox
JokerLoveAllen closed issue #183: Can i use feign and saga in project ? URL: https://github.com/apache/incubator-servicecomb-saga/issues/183 This is an automated message from the Apache Git Service. To respond to the

[Discussion]Java Chassis Support Gracefully Shutdown

2018-05-07 Thread ??????
Hi, All: We did not implement gracefully shutdown yet: // ??kill -9 {pid}?? // 1. ?? // TODO if (applicationContext instanceof AbstractApplicationContext) {

Re: [Discussion]Java Chassis Support Gracefully Shutdown

2018-05-07 Thread Zen Lin
Hi Zhengyangyong, You are a sharpshooter, thanks. Hi Yangbo, Yeah, agree with you, thanks. Best Regards, --- Zen Lin zenlintechnofr...@gmail.com Focused on Micro Service and Apache ServiceComb 2018-05-07 17:45 GMT+08:00 郑扬勇 : > Done! JIRA link :

?????? [Discussion]Java Chassis Support Gracefully Shutdown

2018-05-07 Thread ??????
Done! JIRA link : https://issues.apache.org/jira/browse/SCB-548 Best Regards! YangYongZheng -- -- ??: "willem.jiang"; : 2018??5??7??(??) 5:21 ??: "dev"; : Re:

[GitHub] little-cui closed pull request #339: SCB-544 Convenient store extension

2018-05-07 Thread GitBox
little-cui closed pull request #339: SCB-544 Convenient store extension URL: https://github.com/apache/incubator-servicecomb-service-center/pull/339 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

Re: [Discussion]Java Chassis Support Gracefully Shutdown

2018-05-07 Thread Willem Jiang
Yeah, Let's put it into our 1.0.0-m2 release plan. Yangyong, do you mind create a JIRA for it? We can keep track it in our release plan. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Mon, May 7,

Re: About java-chassis documents improvements

2018-05-07 Thread Zen Lin
Hi Liubao, I think It could be very nice of you to move the comprehensive of CSE version to Apache ServiceComb. To the current users, most of them are Chinese, of course, they need doc in Chinese, As a opensource project, I think it is better to try our best to translate the doc to English, As

About java-chassis documents improvements

2018-05-07 Thread bismy
Hi all, ServiceComb-java-chassis documents now is developed in https://github.com/apache/incubator-servicecomb-website and hosted in http://servicecomb.incubator.apache.org. And we have a comprehensive docs originally for Huawei CSE and want to contribute them to ServiceComb-java-chassis.

[GitHub] coveralls commented on issue #691: [SCB-546] refactor the schemas registry logic

2018-05-05 Thread GitBox
coveralls commented on issue #691: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/691#issuecomment-386793069 [![Coverage Status](https://coveralls.io/builds/16847301/badge)](https://coveralls.io/builds/16847301)

[GitHub] coveralls commented on issue #691: [SCB-546] refactor the schemas registry logic

2018-05-05 Thread GitBox
coveralls commented on issue #691: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/691#issuecomment-386793068 [![Coverage Status](https://coveralls.io/builds/16847300/badge)](https://coveralls.io/builds/16847300)

[GitHub] marknewmail commented on issue #329: 建议新增mac版的release

2018-05-05 Thread GitBox
marknewmail commented on issue #329: 建议新增mac版的release URL: https://github.com/apache/incubator-servicecomb-service-center/issues/329#issuecomment-386797433 1、frontend在mac docker 脚本问题不少,sed -i "" 2、./frontend >start-sc-frontend.log 2>&1 &会直接退出,直接./frontend能启动,但进UI页面会报502

[GitHub] jeho0815 opened a new pull request #691: [SCB-546] refactor the schemas registry logic

2018-05-05 Thread GitBox
jeho0815 opened a new pull request #691: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/691 use the servicecenter new schemas interface to refactor the schema registry logic. 1、use schema summary to compare the

[GitHub] WillemJiang commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+

2018-05-05 Thread GitBox
WillemJiang commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+ URL: https://github.com/apache/incubator-servicecomb-saga/issues/76#issuecomment-386790662 @kenail2002 I just verified the build with JDK10.0.1 and submitted a quick fix for it. Now you

[GitHub] kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+

2018-05-05 Thread GitBox
kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+ URL: https://github.com/apache/incubator-servicecomb-saga/issues/76#issuecomment-386792750 --- T E S T S

[GitHub] kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+

2018-05-05 Thread GitBox
kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+ URL: https://github.com/apache/incubator-servicecomb-saga/issues/76#issuecomment-386792750 --- T E S T S

[GitHub] marknewmail commented on issue #334: 服务下线后,注册中心还是提示UP状态

2018-05-05 Thread GitBox
marknewmail commented on issue #334: 服务下线后,注册中心还是提示UP状态 URL: https://github.com/apache/incubator-servicecomb-service-center/issues/334#issuecomment-386796982 ![image](https://user-images.githubusercontent.com/6514521/39662536-6d115cc8-5095-11e8-925c-17d9cb79c251.png)

[GitHub] marknewmail commented on issue #334: 服务下线后,注册中心还是提示UP状态

2018-05-05 Thread GitBox
marknewmail commented on issue #334: 服务下线后,注册中心还是提示UP状态 URL: https://github.com/apache/incubator-servicecomb-service-center/issues/334#issuecomment-386796961 Instances为1时,直接kill,Instances数量会变成0,但状态还是up.再重启后,Instances不增加 This

[GitHub] jeho0815 closed pull request #691: [SCB-546] refactor the schemas registry logic

2018-05-05 Thread GitBox
jeho0815 closed pull request #691: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/691 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jeho0815 opened a new pull request #691: [SCB-546] refactor the schemas registry logic

2018-05-05 Thread GitBox
jeho0815 opened a new pull request #691: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/691 use the servicecenter new schemas interface to refactor the schema registry logic. 1、use schema summary to compare the

[GitHub] kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+

2018-05-05 Thread GitBox
kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+ URL: https://github.com/apache/incubator-servicecomb-saga/issues/76#issuecomment-386792750 --- T E S T S

[GitHub] kenail2002 closed issue #76: JDK9 not supported when unit testing while doc showing JDK8+

2018-05-05 Thread GitBox
kenail2002 closed issue #76: JDK9 not supported when unit testing while doc showing JDK8+ URL: https://github.com/apache/incubator-servicecomb-saga/issues/76 This is an automated message from the Apache Git Service. To

[GitHub] kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+

2018-05-05 Thread GitBox
kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+ URL: https://github.com/apache/incubator-servicecomb-saga/issues/76#issuecomment-386803185 Since it is not issue of JDK supporting, the issue closed.

[GitHub] kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+

2018-05-05 Thread GitBox
kenail2002 commented on issue #76: JDK9 not supported when unit testing while doc showing JDK8+ URL: https://github.com/apache/incubator-servicecomb-saga/issues/76#issuecomment-386792903 same unit error on JDK8. This is an

[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis

2018-05-07 Thread GitBox
coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126 [![Coverage Status](https://coveralls.io/builds/16866004/badge)](https://coveralls.io/builds/16866004)

[GitHub] codecov-io commented on issue #340: Update beego version 1.8.0

2018-05-07 Thread GitBox
codecov-io commented on issue #340: Update beego version 1.8.0 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/340#issuecomment-387036709 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/340?src=pr=h1) Report > :exclamation:

[GitHub] little-cui commented on issue #334: 服务下线后,注册中心还是提示UP状态

2018-05-07 Thread GitBox
little-cui commented on issue #334: 服务下线后,注册中心还是提示UP状态 URL: https://github.com/apache/incubator-servicecomb-service-center/issues/334#issuecomment-387063971 @marknewmail 这个问题我已经了解,下个版本修复 This is an automated message from the

[GitHub] little-cui closed pull request #340: Update beego version 1.8.0

2018-05-07 Thread GitBox
little-cui closed pull request #340: Update beego version 1.8.0 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/340 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] WillemJiang commented on issue #183: Can i use feign and saga in project ?

2018-05-04 Thread GitBox
WillemJiang commented on issue #183: Can i use feign and saga in project ? URL: https://github.com/apache/incubator-servicecomb-saga/issues/183#issuecomment-386542714 Hi, I don't think this is a related issue, but I will try to run the demo myself.

[GitHub] wujimin opened a new pull request #689: [SCB-538] Create SwaggerToClassGenerator

2018-05-04 Thread GitBox
wujimin opened a new pull request #689: [SCB-538] Create SwaggerToClassGenerator URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/689 preparing for create recursive dependency class javassist can create normal dynamic class to classloader but can not create

[GitHub] xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-04 Thread GitBox
xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186033593 ## File path:

[GitHub] WillemJiang commented on issue #182: ERROR: value too long for type character varying(16)

2018-05-04 Thread GitBox
WillemJiang commented on issue #182: ERROR: value too long for type character varying(16) URL: https://github.com/apache/incubator-servicecomb-saga/issues/182#issuecomment-386550256 I just checked the

[GitHub] xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

2018-05-04 Thread GitBox
xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r18607 ## File path:

[GitHub] zhengyangyong commented on issue #686: 怎样修改日志级别?

2018-05-03 Thread GitBox
zhengyangyong commented on issue #686: 怎样修改日志级别? URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/686#issuecomment-386498168 Found is log implement issue , PR : https://github.com/hank-whu/rpc-benchmark/pull/14

[GitHub] zhengyangyong commented on issue #685: 怎样平滑关闭Client?

2018-05-04 Thread GitBox
zhengyangyong commented on issue #685: 怎样平滑关闭Client? URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/685#issuecomment-386518420 I think you can try this step: ```java //this code will Unregister microservice instance from ServiceCenter

[GitHub] yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC

2018-05-04 Thread GitBox
yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC URL: https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r186001444 ## File path:

[GitHub] yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC

2018-05-04 Thread GitBox
yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC URL: https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r186001438 ## File path:

[GitHub] wuzunqian opened a new pull request #185: [Scb 245]: add acceptance test for dubbo demo

2018-05-07 Thread GitBox
wuzunqian opened a new pull request #185: [Scb 245]: add acceptance test for dubbo demo URL: https://github.com/apache/incubator-servicecomb-saga/pull/185 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

2018-05-07 Thread GitBox
Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r186434879 ## File path:

[GitHub] coveralls commented on issue #185: [Scb 245]: add acceptance test for dubbo demo

2018-05-07 Thread GitBox
coveralls commented on issue #185: [Scb 245]: add acceptance test for dubbo demo URL: https://github.com/apache/incubator-servicecomb-saga/pull/185#issuecomment-387092891 [![Coverage Status](https://coveralls.io/builds/16866908/badge)](https://coveralls.io/builds/16866908)

[GitHub] coveralls commented on issue #185: [Scb 245]: add acceptance test for dubbo demo

2018-05-07 Thread GitBox
coveralls commented on issue #185: [Scb 245]: add acceptance test for dubbo demo URL: https://github.com/apache/incubator-servicecomb-saga/pull/185#issuecomment-387092892 [![Coverage Status](https://coveralls.io/builds/16866908/badge)](https://coveralls.io/builds/16866908)

[GitHub] coveralls commented on issue #190: SCB-573 Split the docker-compose file for debugging easily

2018-05-13 Thread GitBox
coveralls commented on issue #190: SCB-573 Split the docker-compose file for debugging easily URL: https://github.com/apache/incubator-servicecomb-saga/pull/190#issuecomment-388244167 [![Coverage

?????? [Discussion]About service instances discovery reliable problems

2018-05-14 Thread bismy
When service center all instances stoped and then started. This is normal when we are doing maintenance. e.g. upgrading -- -- ??: "wjm wjm"; : 2018??5??14??(??) 12:36 ??: "dev";

Re: [Discussion]About service instances discovery reliable problems

2018-05-14 Thread wjm wjm
it's a problem, but why business use gray release, but we reject to the solution? 2018年5月14日星期一,bismy 写道: > When service center all instances stoped and then started. This is normal > when we are doing maintenance. e.g. upgrading > > > > > -- 原始邮件

[GitHub] WillemJiang closed pull request #190: SCB-573 Split the docker-compose file for debugging easily

2018-05-14 Thread GitBox
WillemJiang closed pull request #190: SCB-573 Split the docker-compose file for debugging easily URL: https://github.com/apache/incubator-servicecomb-saga/pull/190 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] wujimin closed pull request #699: [SCB-532] Support recursive dependency

2018-05-14 Thread GitBox
wujimin closed pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] wujimin commented on a change in pull request #699: [SCB-532] Support recursive dependency

2018-05-14 Thread GitBox
wujimin commented on a change in pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187951742 ## File path:

[GitHub] WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency

2018-05-14 Thread GitBox
WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187901718 ## File path:

[GitHub] WillemJiang closed pull request #188: [SCB-569] Add document for enabling SSL

2018-05-14 Thread GitBox
WillemJiang closed pull request #188: [SCB-569] Add document for enabling SSL URL: https://github.com/apache/incubator-servicecomb-saga/pull/188 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] wujimin opened a new pull request #701: [SCB-534] remove generate generic class from swagger related comments…

2018-05-14 Thread GitBox
wujimin opened a new pull request #701: [SCB-534] remove generate generic class from swagger related comments… URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/701 unnecessary to generate generic class from swagger: in normal process: already have related

[GitHub] yhs0092 opened a new pull request #702: [SCB-580] fix response of the upload file too large

2018-05-14 Thread GitBox
yhs0092 opened a new pull request #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a

[GitHub] coveralls commented on issue #702: [SCB-580] fix response of the upload file too large

2018-05-14 Thread GitBox
coveralls commented on issue #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702#issuecomment-36098 [![Coverage

[GitHub] coveralls commented on issue #701: [SCB-534] remove generate generic class from swagger related comments…

2018-05-14 Thread GitBox
coveralls commented on issue #701: [SCB-534] remove generate generic class from swagger related comments… URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/701#issuecomment-388833613 [![Coverage

[GitHub] wujimin commented on a change in pull request #349: SCB-491 Fix the broken links for China Region

2018-05-14 Thread GitBox
wujimin commented on a change in pull request #349: SCB-491 Fix the broken links for China Region URL: https://github.com/apache/incubator-servicecomb-service-center/pull/349#discussion_r188138576 ## File path: frontend/app/index.html ## @@ -64,16 +64,16 @@

[GitHub] wujimin commented on a change in pull request #702: [SCB-580] fix response of the upload file too large

2018-05-14 Thread GitBox
wujimin commented on a change in pull request #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702#discussion_r188139854 ## File path:

[GitHub] coveralls commented on issue #703: [SCB-531] change demo to test schema without x-java-interface declared.

2018-05-14 Thread GitBox
coveralls commented on issue #703: [SCB-531] change demo to test schema without x-java-interface declared. URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/703#issuecomment-389017372 [![Coverage

[GitHub] WillemJiang commented on a change in pull request #185: [SCB-245]: add acceptance test for dubbo demo

2018-05-14 Thread GitBox
WillemJiang commented on a change in pull request #185: [SCB-245]: add acceptance test for dubbo demo URL: https://github.com/apache/incubator-servicecomb-saga/pull/185#discussion_r188157504 ## File path:

[GitHub] wujimin opened a new pull request #703: [SCB-531] change demo to test schema without x-java-interface declared.

2018-05-14 Thread GitBox
wujimin opened a new pull request #703: [SCB-531] change demo to test schema without x-java-interface declared. URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/703 This is an automated message from

[GitHub] yhs0092 commented on a change in pull request #702: [SCB-580] fix response of the upload file too large

2018-05-14 Thread GitBox
yhs0092 commented on a change in pull request #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702#discussion_r188167573 ## File path:

[GitHub] coveralls commented on issue #702: [SCB-580] fix response of the upload file too large

2018-05-14 Thread GitBox
coveralls commented on issue #702: [SCB-580] fix response of the upload file too large URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/702#issuecomment-36098 [![Coverage

Re: 答复: [VOTE] Move github notifications to maillist "comm...@servicecomb.apache.org"

2018-05-15 Thread Kirin Wang
Hi all: I am happy to announce that the apache serviceComb community have already approved to move github notifications to maillist " comm...@servicecomb.apache.org" 。 +1 binding: 2(Willem Jiang, Wu Jimin) +1 non-binding: 4 (Zenlin ,Yangyong zheng, Yang Bo, Bin Ma) 2018-05-13

Re: [Discussion]Java Chassis Support Gracefully Shutdown

2018-05-07 Thread Willem Jiang
Normally, we just keep on eye on the outstanding issues which we need to finish in this release by go through the JIRA. As we have the fix version on task, it could be easy for us to pick them up and find out their status. If there are any other feature or bug fix need to be finished, we'd better

Re: About java-chassis documents improvements

2018-05-07 Thread Willem Jiang
Document is a good start point for the people to get to know the project. We definitely need lots of help from the community. Let's start it now, break the task into smaller one and ask help in the community. Willem Jiang Blog: http://willemjiang.blogspot.com (English)

?????? [Discussion]What Java Chassis need to do for support Gracefully Shutdown

2018-05-09 Thread ??????
Hi all: I had make some improvement base on current mechanism and PR is here : https://github.com/apache/incubator-servicecomb-java-chassis/pull/693 , I think it is enough. When user call system.exit(0),these three works will do: 1.Unregister microservice instance from Service Center:

Re: [Discussion]What Java Chassis need to do for support Gracefully Shutdown

2018-05-09 Thread Willem Jiang
Oh, let me make it clear. As Liubao said, we have two place to do the shutdown work. "Now java-chassis doing the following: 1. A shutdown hook for spring context shutdown and unregistered from service center 2. A shutdown hook waiting for all invocations to finish" My suggestion is unify the

[GitHub] coveralls commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
coveralls commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674520 [![Coverage

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

2018-05-09 Thread Willem Jiang
Hi JB, As GitBox also post some comments and PR request which could be only part of commits? I'm not sure if it is OK to keep them in the commits mailing list. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo:

[GitHub] codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674481 #

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

2018-05-09 Thread GitBox
coveralls commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923 [![Coverage Status](https://coveralls.io/builds/16899128/badge)](https://coveralls.io/builds/16899128)

[GitHub] coveralls commented on issue #678: [SCB-506]服务治理相关的需要事件上报

2018-05-08 Thread GitBox
coveralls commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-384615018 [![Coverage Status](https://coveralls.io/builds/16897188/badge)](https://coveralls.io/builds/16897188) Coverage decreased

[GitHub] coveralls commented on issue #691: [SCB-546] refactor the schemas registry logic

2018-05-09 Thread GitBox
coveralls commented on issue #691: [SCB-546] refactor the schemas registry logic URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/691#issuecomment-386793069 [![Coverage Status](https://coveralls.io/builds/16900703/badge)](https://coveralls.io/builds/16900703)

[GitHub] little-cui opened a new pull request #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
little-cui opened a new pull request #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346 Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data

2018-05-09 Thread GitBox
codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674481 #

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

2018-05-09 Thread Jean-Baptiste Onofré
The suggestion was more a kind of "umbrella" mailing list receiving any message related to commit/code activity. Regards JB On 09/05/2018 11:21, Willem Jiang wrote: Hi JB, As GitBox also post some comments and PR request which could be only part of commits? I'm not sure if it is OK to keep

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

2018-05-09 Thread kirin wang
Hi Jean-Baptiste: Thank you for your suggestion, If Apache projects already have the common practice, we can also follow it~

  1   2   3   4   5   6   7   8   9   10   >