Hi Craig,
Very appreciated your checking and voting which help this release move ahead.
Juan Pan
panj...@apache.org
Juan Pan(Trista), Apache ShardingSphere
On 11/18/2019 15:01，Craig Russell wrote：
+1
I checked:
[ x] Download links are valid.
[x ] Checksums and PGP signatures are valid.
+1
I checked:
[ x] Download links are valid.
[x ] Checksums and PGP signatures are valid.
[ x] DISCLAIMER is included.
[ x] Source code artifacts have correct names matching the current release.
[x ] Built mvn clean install from source
Craig
> On Nov 11, 2019, at 2:40 AM, Juan Pan wrote:
Thanks Craig,
Waiting for your good or bad news. :)
Juan Pan
panj...@apache.org
Juan Pan(Trista), Apache ShardingSphere
On 11/18/2019 11:07，Craig Russell wrote：
The problem was using --recv-keys with the KEYS file instead of the correct
option --import wrote:
Craig
I think that may be
The problem was using --recv-keys with the KEYS file instead of the correct
option --import On Nov 17, 2019, at 6:52 PM, Sheng Wu wrote:
>
> Craig
>
> I think that may be caused by Juan used to regenerate the KEY from last
> round, right? Juan.
> I manually re-import in every time recheck
Craig
I think that may be caused by Juan used to regenerate the KEY from last
round, right? Juan.
I manually re-import in every time recheck your new round.
That should be the reason.
Sheng Wu 吴晟
Twitter, wusheng1108
Juan Pan 于2019年11月18日周一 上午10:24写道：
> Hi Craig,
>
>
> Thanks for your reply
Hi Craig,
Thanks for your reply and checking.
Firstly, PGP PUBLIC KEY BLOCK of key ID C8ADAD3A which exists in `KEYS-FILE`[1]
is correct.
Secondly, key ID C8ADAD3A is not https://keyserver.pgp.com/, for there is no
search result of my email, i.e panj...@apache.org .
How about trying
Hi Craig,
I generally compared the KEYS, it is the same as My local KEYS which I used to
check 4.0.0-RC3.
--
Yi Yang(Sion)
Apache ShardingSphere
At 2019-11-18 09:02:30, "Craig Russell" wrote:
>I'm having trouble downloading the public key from the KEYS file.
>
>Does this KEYS file look
Hi Craig
I just tried to re-download and re-import the file
https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS.
My GPG Keychain App shows nothing changed from last import.
Sheng Wu 吴晟
Twitter, wusheng1108
Craig Russell 于2019年11月18日周一 上午9:40写道：
> Hi Sheng,
>
> My
Hi Sheng,
My understanding is that downloading from the keys server is only done if the
public key is not available locally.
Does the KEYS file that you imported from match the KEYS-2 file that I imported
from below?
Craig
> On Nov 17, 2019, at 5:21 PM, Sheng Wu wrote:
>
> Hi Craig
>
> I
+1
I checked list:
[X] Download links are valid.
[X] Checksums and PGP signatures are valid.
[X] DISCLAIMER is included.
[X] Source code artifacts have correct names matching the current release.
[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[X] All files have license
Thanks Willem,
Mentor' vote gives us more confidence.
Although 72 hours passed, i would like to give other mentors and PPMCs more
time to check. Please notice, next Monday in Beijing time is the deadline for
this vote, i plead your check and vote, so that we can move ahead well in
incubator
+1. (binding)
Checked the release candidate of source and binary, the signatures and
sha are OK.
License and Notice file looks good to me.
DISCLAIMER are in the kits.
There is on binary files in the source release kit.
The release kits has incubating in the name .
Can build the binary from source
Hi
I want to vote for this release, but I don't know how to finish the checklist
work. Do we have some reference documents.
[ ] Download links are valid. (It is OK, I can download and verify the links.)
[ ] Checksums and PGP signatures are valid. (Sorry, I don't know how to finish
this
+1,
I check the following
[X] Download links are valid.
[X] DISCLAIMER is included.
[X] Source code artifacts have correct names matching the current release.
[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[X] No compiled archives bundled in source archive.
On 11/14/2019
Same thing for sunbufu.
As a committer, please check all items from check list and make sure every
thing is ok. Please do not just leave a word without voting.
Thank you.
--
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Sheng Wu 于2019年11月14日周四 上午10:00写道：
> Guangyuan Wang
Guangyuan Wang
Please notice, as a committer, even your vote is PPMC(counted) vote for
release, but you should write which steps you have run with the +1.
The mail you posted looks like a copy of Chen QingYang.
As a committer and on the way toward PPMC, you should learn the ASF
requirement for
> +1,
>Looks good to me.
> I checked:
>
> [X] Download links are valid.
> [X] Checksums and PGP signatures are valid.
> [X] DISCLAIMER is included.
> [X] Source code artifacts have correct names matching the current release.
> [X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
+1,
I checked:
[X] Download links are valid.
[X] Checksums and PGP signatures are valid.
[X] DISCLAIMER is included.
[X] Source code artifacts have correct names matching the current release.
[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[X] All files have license
LGTM.
+1,
I checked:
[X] Download links are valid.
[X] Checksums and PGP signatures are valid.
[X] DISCLAIMER is included.
[X] Source code artifacts have correct names matching the current release.
[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[X] All files have
+1,
I checked:
[X] Download links are valid.
[X] Checksums and PGP signatures are valid.
[X] DISCLAIMER is included.
[X] Source code artifacts have correct names matching the current release.
[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[X] All files have license
Yes, there are milestone info in the release notes[1], just search
MILESTONE to find them.
[1]
https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md
--
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Sheng Wu 于2019年11月13日周三 上午11:52写道：
> I guess so,
I guess so, but my point is, you didn't mention it in changelog file.
>From my understanding, all information should be hosted in ASF INFRA, which
excludes the GitHub milestone list as an optional one.
And most important is, a milestone could be changed after your release.
Sheng Wu 吴晟
Apache
Yep, there are many issues fixed and features developed, some of which are
trivial. Based on that, we’d like to summarize, thus it seems to `ignore` some
change log, does anyone have some suggestions?
Juan Pan
panj...@apache.org
Juan Pan(Trista), Apache ShardingSphere
On 11/13/2019
The release notes has all change logs in milestone[1] which in the end of
each release version, because change logs in milestone is too big, so we
just summary some important issues.
[1] https://github.com/apache/incubator-shardingsphere/milestone/8
--
Liang Zhang (John)
Apache
+1
The issues mentioned before have been fixed.
asc sign checked and based on apache mail.
NOTICE, LICENSE, and DISCLAIMER exist.
sha512 is there
compiling works
A tiny issue,
The changelog seems to ignore many fixes and code changes.
Such as bugfix #3401[1] never shows up in a changelog.
The
tory method 'encryptDataSource' threw
> exception;
> > nested exception is java.sql.SQLDataException: Cannot determine value
> type
> > from string 'NO'
> > at
> >
> org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInsta
impleInstantiationStrategy.java:185)
> at
> org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:622)
> ... 119 common frames omitted
>
>
>
> --原始邮件--
> 发件人:"Juan Pan" 发送时间:2019年11月11日(星期一
Hi Brian,
This thread is for checking and voting for Release 4.0.0-RC3, you need to go
through the check list and cast your vote. Notice: 4.0.0-RC3 has not been
released until now. Did the exception you mentioned happen when you did
checking?
Juan Pan
panj...@apache.org
Juan Pan(Trista),
+1,
I checked:
[X] Download links are valid.
[X] Checksums and PGP signatures are valid.
[X] DISCLAIMER is included.
[X] Source code artifacts have correct names matching the current release.
[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[X] All files have license
+1,
I checked:
[X] Download links are valid.
[X] Checksums and PGP signatures are valid.
[X] DISCLAIMER is included.
[X] Source code artifacts have correct names matching the current release.
[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[X] All files have license
+1,
I checked:
[X] Download links are valid.
[X] Checksums and PGP signatures are valid.
[X] DISCLAIMER is included.
[X] Source code artifacts have correct names matching the current release.
[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
[X] All files have license
Hi everyone,
With the help and effort of our community, the previous issues were fixed
already. I am glad to invite everyone to move on to check and vote for our
4.0.0-RC3 ROUND 4.
Release notes:
https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md
The release
32 matches
Mail list logo
