Re: Returning same status code as fetched (issue1811042)

2010-07-26 Thread anupama . dutta
LGTM. http://codereview.appspot.com/1811042/diff/37001/38001 File common/conf/shindig.properties (right): http://codereview.appspot.com/1811042/diff/37001/38001#newcode145 common/conf/shindig.properties:145: # Remap internal server errors received from the server being proxied to Rephrase as:

RE: Returning same status code as fetched (issue1811042)

2010-07-26 Thread VU, Thi Thu Thuy
...@googlegroups.com; kuntal.l...@gmail.com Cc: re...@codereview.appspotmail.com Subject: Re: Returning same status code as fetched (issue1811042) LGTM. http://codereview.appspot.com/1811042/diff/37001/38001 File common/conf/shindig.properties (right): http://codereview.appspot.com/1811042/diff/37001/38001

RE: Returning same status code as fetched (issue1811042)

2010-07-26 Thread VU, Thi Thu Thuy
-remai...@shindig.apache.org; cool-shindig-committ...@googlegroups.com; kuntal.l...@gmail.com; anupama.du...@gmail.com; re...@codereview.appspotmail.com Subject: RE: Returning same status code as fetched (issue1811042) 0612452548 -Original Message- From: anupama.du...@gmail.com

Re: Returning same status code as fetched (issue1811042)

2010-07-15 Thread gagan . goku
On 2010/07/15 05:29:40, gagan.goku wrote: On 2010/07/15 05:27:09, gagan.goku wrote: reverting ProxyingContentRewriter Comments addressed. And to emphasize how important http status codes are, Rietveld is throwing 500 Server Error when i try to Publish+Mail comments. On 2010/07/14

Re: Returning same status code as fetched (issue1811042)

2010-07-14 Thread johnfargo
http://codereview.appspot.com/1811042/diff/23001/24002 File main/java/org/apache/shindig/gadgets/uri/UriUtils.java (left): http://codereview.appspot.com/1811042/diff/23001/24002#oldcode129 main/java/org/apache/shindig/gadgets/uri/UriUtils.java:129: resp.sendError(HttpResponse.SC_BAD_GATEWAY);

Re: Returning same status code as fetched (issue1811042)

2010-07-14 Thread gagan . goku
reverting ProxyingContentRewriter http://codereview.appspot.com/1811042/show

Re: Returning same status code as fetched (issue1811042)

2010-07-13 Thread gagan . goku
http://codereview.appspot.com/1811042/diff/6001/7001 File main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java (right): http://codereview.appspot.com/1811042/diff/6001/7001#newcode89 main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:89: // In case of errors where we want

Re: Returning same status code as fetched (issue1811042)

2010-07-13 Thread gagan . goku
addressing comments http://codereview.appspot.com/1811042/show

Re: Returning same status code as fetched (issue1811042)

2010-07-13 Thread kuntal . loya
http://codereview.appspot.com/1811042/diff/16001/17001 File main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java (right): http://codereview.appspot.com/1811042/diff/16001/17001#newcode88 main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:88: if (errorResponse != null) { if

Re: Returning same status code as fetched (issue1811042)

2010-07-13 Thread gagan . goku
addressing comments http://codereview.appspot.com/1811042/show

Re: Returning same status code as fetched (issue1811042)

2010-07-13 Thread gagan . goku
http://codereview.appspot.com/1811042/diff/16001/17001 File main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java (right): http://codereview.appspot.com/1811042/diff/16001/17001#newcode88 main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:88: if (errorResponse != null) { On

Re: Returning same status code as fetched (issue1811042)

2010-07-12 Thread gagan . goku
On 2010/07/12 09:27:19, gagan.goku wrote: fixing tests Comment addressed. http://codereview.appspot.com/1811042/show