[
https://issues.apache.org/jira/browse/SLING-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-9928:
---
Assignee: Carsten Ziegeler
> Sling el-api embeds vulnerable version of el-api
>
[
https://issues.apache.org/jira/browse/SLING-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-9928.
-
Resolution: Fixed
Thanks for the PR, its applied
> Sling el-api embeds vulnerable
[
https://issues.apache.org/jira/browse/SLING-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-9928:
Fix Version/s: Scripting EL API Wrapper 1.0.4
> Sling el-api embeds vulnerable version of
cziegeler merged pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-scripting-el-api/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/SLING-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237905#comment-17237905
]
Akanksha Jain commented on SLING-9928:
--
As per
sonarcloud[bot] commented on pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-el-api/pull/2#issuecomment-732687848
Kudos, SonarCloud Quality Gate passed!
akankshajain18 opened a new pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-scripting-el-api/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Akanksha Jain created SLING-9928:
Summary: Sling el-api embeds vulnerable version of el-api
Key: SLING-9928
URL: https://issues.apache.org/jira/browse/SLING-9928
Project: Sling
Issue Type:
cmrockwell commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r529057232
##
File path: src/main/java/org/apache/sling/junit/tests/TestReferenceJTest.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the
sonarcloud[bot] commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732479510
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=5=false=BUG)
sonarcloud[bot] removed a comment on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732459882
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=5=false=BUG)
cmrockwell commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r529033933
##
File path: src/main/java/org/apache/sling/junit/impl/AnnotationsProcessor.java
##
@@ -64,25 +67,32 @@ private void
sonarcloud[bot] commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732459882
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=5=false=BUG)
sonarcloud[bot] removed a comment on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732452820
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=5=false=BUG)
sonarcloud[bot] commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732452820
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=5=false=BUG)
sonarcloud[bot] removed a comment on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732412012
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=5=false=BUG)
cmrockwell commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r529025065
##
File path: src/main/java/org/apache/sling/junit/annotations/TestReference.java
##
@@ -39,6 +38,12 @@
*/
String
sonarcloud[bot] commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732412012
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=5=false=BUG)
cmrockwell commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732340006
> > Tests for the @TestReference(String filter) are run via
SlingAnnotationsTestRunner [0]
>
> IIUC this means those tests are not executed
[
https://issues.apache.org/jira/browse/SLING-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-9925.
---
Resolution: Invalid
> ArrayIndexOutOfBoundsException in AbstractSlingFilterChain
>
[
https://issues.apache.org/jira/browse/SLING-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237502#comment-17237502
]
A. J. David Bosschaert commented on SLING-9927:
---
PR:
[
https://issues.apache.org/jira/browse/SLING-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert reassigned SLING-9927:
-
Assignee: A. J. David Bosschaert (was: David Bosschaert)
> Allow
jsedding commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r528819333
##
File path: src/main/java/org/apache/sling/junit/impl/AnnotationsProcessor.java
##
@@ -64,25 +67,32 @@ private void
jsedding commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r528798628
##
File path: src/main/java/org/apache/sling/junit/ServiceGetter.java
##
@@ -15,7 +15,7 @@
* limitations under the License.
*/
[
https://issues.apache.org/jira/browse/SLING-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237442#comment-17237442
]
Karl Pauls commented on SLING-9927:
---
[~bosschaert], the problem is in the used Felix util
cmrockwell commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732228610
@bdelacretaz Thanks for reviewing and providing your thoughts. By full blown
IT tests, do you mean something that implements TeleporterRule.Customizer?
Radu Cotescu created SLING-9927:
---
Summary: Allow java.* imports to be defined, in line with OSGi R7
Key: SLING-9927
URL: https://issues.apache.org/jira/browse/SLING-9927
Project: Sling
Issue
cmrockwell commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r528773456
##
File path: src/main/java/org/apache/sling/junit/ServiceGetter.java
##
@@ -15,7 +15,7 @@
* limitations under the License.
jsedding commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r528755102
##
File path: src/main/java/org/apache/sling/junit/ServiceGetter.java
##
@@ -15,7 +15,7 @@
* limitations under the License.
*/
Carsten Ziegeler created SLING-9926:
---
Summary: Wrong PID if configuration is in a nested folder
Key: SLING-9926
URL: https://issues.apache.org/jira/browse/SLING-9926
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237372#comment-17237372
]
Carsten Ziegeler commented on SLING-9925:
-
Reading the servlet spec and taking the reference
[
https://issues.apache.org/jira/browse/SLING-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-9924.
---
Resolution: Fixed
> Feature Model Converter Maven Plugin does not consult
[
https://issues.apache.org/jira/browse/SLING-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237354#comment-17237354
]
Carsten Ziegeler edited comment on SLING-9925 at 11/23/20, 1:30 PM:
akankshajain18 commented on pull request #24:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#issuecomment-732160224
Hi All
Thank you for all the insightful reviews.
I have updated the PR.
Important changes:
1. use of copyOnWriteArrayList
akankshajain18 commented on pull request #24:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#issuecomment-732158446
> > @wimsymons
> > The initial thought was changing the query itself.
> > But as the number path will increase, we need to append
[
https://issues.apache.org/jira/browse/SLING-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237354#comment-17237354
]
Carsten Ziegeler edited comment on SLING-9925 at 11/23/20, 1:10 PM:
[
https://issues.apache.org/jira/browse/SLING-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237354#comment-17237354
]
Carsten Ziegeler commented on SLING-9925:
-
This sounds like an abuse in the invocation pattern.
Karl Pauls created SLING-9925:
-
Summary: ArrayIndexOutOfBoundsException in AbstractSlingFilterChain
Key: SLING-9925
URL: https://issues.apache.org/jira/browse/SLING-9925
Project: Sling
Issue
rombert commented on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732118808
@akankshajain18 - you can push to the original PR, I don't see how that will
cause problems and you will need to squash at the end anyway. You can
A. J. David Bosschaert created SLING-9924:
-
Summary: Feature Model Converter Maven Plugin does not consult
remote repositories to resolve artifacts
Key: SLING-9924
URL:
sonarcloud[bot] removed a comment on pull request #24:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#issuecomment-723828608
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #24:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#issuecomment-732117959
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732117231
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] removed a comment on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732099892
Kudos, SonarCloud Quality Gate passed!
akankshajain18 edited a comment on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732109346
Hi @rombert
I am working on older PR only.
This is a dummy PR for my testing purpose related to code coverage, bugs,
and
akankshajain18 commented on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732109346
Hi @rombert
I am working on older PR only.
This is a dummy PR for my testing purpose related to code coverage, bugs,
and
sonarcloud[bot] commented on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732099892
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] removed a comment on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732048379
Kudos, SonarCloud Quality Gate passed!
[
https://issues.apache.org/jira/browse/SLING-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-9921.
-
Resolution: Fixed
Added in
[
https://issues.apache.org/jira/browse/SLING-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-9921:
---
Assignee: Carsten Ziegeler
> service.pid and service.factoryPid should be ignored
bdelacretaz commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732048957
> Tests for the @TestReference(String filter) are run via
SlingAnnotationsTestRunner [0]
IIUC this means those tests are not executed
sonarcloud[bot] commented on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732048379
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] removed a comment on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732011180
Kudos, SonarCloud Quality Gate passed!
rombert commented on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732046566
Hi @akankshajain18 . You opened a new PR but #24 is still open. I think it
would be beneficial to keep the whole discussion in the previous PR,
wimsymons commented on pull request #24:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/24#issuecomment-732011752
> @wimsymons
> The initial thought was changing the query itself.
> But as the number path will increase, we need to append ISDESCENDANTNODE
sonarcloud[bot] commented on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-732011180
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] removed a comment on pull request #30:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/30#issuecomment-731761217
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/12#issuecomment-732002149
Kudos, SonarCloud Quality Gate passed!
cziegeler closed pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cziegeler commented on pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/2#issuecomment-732000881
Closing as the related issue has been closed time ago
This is an
cziegeler merged pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/12
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/SLING-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-9922:
---
Component/s: Scripting
> scriptingbundle-maven-plugin: Move "metadata" mojo to another
cziegeler opened a new pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/12
This is an automated message from the Apache Git Service.
To respond to the message,
Konrad Windszus created SLING-9923:
--
Summary: htl-maven-plugin: Generate "extends" and "requires" files
automatically
Key: SLING-9923
URL: https://issues.apache.org/jira/browse/SLING-9923
Project:
64 matches
Mail list logo