sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-commons-scheduler/pull/6#issuecomment-1318160824
SonarCloud Quality Gate failed. [![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-11662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635165#comment-17635165
]
Carsten Ziegeler commented on SLING-11662:
--
[~stefanegli] I updated the branch with a potential
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634573#comment-17634573
]
Andreas Schaefer edited comment on SLING-11458 at 11/16/22 10:02 PM:
-
anban02 commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1317580002
I just made some adjustments to my code and trimmed it down so it is easier
to read and doesn't do this hard to understand Collection-Modification.
I
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1317564869
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1317563831
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1317551314
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1317545896
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1317543909
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1317408886
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#issuecomment-1317404545
SonarCloud Quality Gate failed. [![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634922#comment-17634922
]
Andreas Bannasch commented on SLING-10110:
--
[~rombert] I just created the pull-request. I'll
Kronnox commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024239524
##
src/main/java/org/apache/sling/testing/Constants.java:
##
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
anban02 opened a new pull request, #26:
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26
Hello everyone
about a year ago I opened the Issue
[SLING-10110](https://issues.apache.org/jira/projects/SLING/issues/SLING-10110?filter=allopenissues).
Now after a
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634915#comment-17634915
]
Robert Munteanu commented on SLING-10110:
-
[~SonglessHill] - sounds good!
> Sling Dynamic
joerghoh commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024218984
##
src/main/java/org/apache/sling/testing/Constants.java:
##
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634899#comment-17634899
]
Andreas Bannasch edited comment on SLING-10110 at 11/16/22 4:12 PM:
bdelacretaz commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024211896
##
src/main/java/org/apache/sling/testing/Constants.java:
##
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634899#comment-17634899
]
Andreas Bannasch edited comment on SLING-10110 at 11/16/22 4:00 PM:
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634899#comment-17634899
]
Andreas Bannasch edited comment on SLING-10110 at 11/16/22 3:50 PM:
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634899#comment-17634899
]
Andreas Bannasch commented on SLING-10110:
--
I tried to add the functionality myself and wrote
Kronnox commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024175976
##
src/main/java/org/apache/sling/testing/Constants.java:
##
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
Kronnox commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024158765
##
src/test/java/org/apache/sling/testing/CustomUserAgentInterceptorTest.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software
bdelacretaz commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024142834
##
src/main/java/org/apache/sling/testing/Constants.java:
##
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
sonarcloud[bot] commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#issuecomment-1317177157
SonarCloud Quality Gate failed. [![Quality Gate
bdelacretaz commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#issuecomment-1317151894
Thanks for this! I've made a few minor comments but it generally looks good
to me.
--
This is an automated message from the Apache Git Service.
To
bdelacretaz commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024113483
##
src/test/java/org/apache/sling/testing/CustomUserAgentInterceptorTest.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache
bdelacretaz commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024111918
##
src/main/java/org/apache/sling/testing/clients/util/UserAgent.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software
joerghoh commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024110803
##
src/main/java/org/apache/sling/testing/Constants.java:
##
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
bdelacretaz commented on code in PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1024107734
##
src/main/java/org/apache/sling/testing/Constants.java:
##
@@ -37,4 +37,9 @@ public class Constants {
* Http Context Attributes
[
https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634849#comment-17634849
]
Carsten Ziegeler edited comment on SLING-11678 at 11/16/22 2:10 PM:
[
https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634849#comment-17634849
]
Carsten Ziegeler commented on SLING-11678:
--
times change :)
There are two things: deploying a
[
https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634842#comment-17634842
]
Konrad Windszus commented on SLING-11678:
-
To quote from
sonarcloud[bot] commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#issuecomment-1316948817
SonarCloud Quality Gate failed. [![Quality Gate
Kronnox opened a new pull request, #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41
Instead of the current User-Agent `JAVA` that is used on all SlingClient
requests a more descriptive one (`sling-testing-client/`) is used
instead.
Furthermore
[
https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634796#comment-17634796
]
Carsten Ziegeler commented on SLING-11678:
--
Agreed, looks like we could really drop this
[
https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634789#comment-17634789
]
Robert Munteanu commented on SLING-11678:
-
If we use the Webconsole REST API to install the
[
https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634780#comment-17634780
]
Konrad Windszus commented on SLING-11678:
-
For me this functionality should have less dependency
[
https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634762#comment-17634762
]
Carsten Ziegeler commented on SLING-11678:
--
The answer is easy, back then no OSGi Http
[
https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634758#comment-17634758
]
Robert Munteanu commented on SLING-11678:
-
[~kwin] - I think [~cziegeler] would know best as he
[
https://issues.apache.org/jira/browse/SLING-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634716#comment-17634716
]
Konrad Windszus commented on SLING-11678:
-
[~rombert] WDYT? Any particular reason why you
Konrad Windszus created SLING-11678:
---
Summary: Protect the Tooling Support Install servlet
Key: SLING-11678
URL: https://issues.apache.org/jira/browse/SLING-11678
Project: Sling
Issue
42 matches
Mail list logo
