[
https://issues.apache.org/jira/browse/SLING-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-11729:
Description:
The SPI from https://jackrabbit.apache.org/filevault/validation.html
Konrad Windszus created SLING-11729:
---
Summary: Add FileVault validator for repoinit files contained in
serialized OSGi configs
Key: SLING-11729
URL: https://issues.apache.org/jira/browse/SLING-11729
[
https://issues.apache.org/jira/browse/SLING-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646469#comment-17646469
]
Konrad Windszus edited comment on SLING-9572 at 12/13/22 7:35 AM:
--
[
https://issues.apache.org/jira/browse/SLING-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646469#comment-17646469
]
Konrad Windszus edited comment on SLING-9572 at 12/13/22 7:28 AM:
--
[
https://issues.apache.org/jira/browse/SLING-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646469#comment-17646469
]
Konrad Windszus edited comment on SLING-9572 at 12/13/22 7:25 AM:
--
[
https://issues.apache.org/jira/browse/SLING-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646469#comment-17646469
]
Konrad Windszus edited comment on SLING-9572 at 12/13/22 7:20 AM:
--
[
https://issues.apache.org/jira/browse/SLING-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646469#comment-17646469
]
Konrad Windszus commented on SLING-9572:
[~dklco] Can you link the discussion thread, which
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646459#comment-17646459
]
Andreas Bannasch commented on SLING-10110:
--
[~joerghoh], as [~rombert] mentioned it is not
kwin commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/30#issuecomment-1347824131
> but not always right
What makes you think that the tool is wrong here? This is IMHO breaking
binary compatibility according to
cziegeler commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/30#issuecomment-1347814439
This clearly shows that tooling is great but not always right; we can
override the baseline check for this case, get the release out and then remove
the override.
sonarcloud[bot] commented on PR #95:
URL: https://github.com/apache/sling-whiteboard/pull/95#issuecomment-1347775043
Kudos, SonarCloud Quality Gate passed! [ from 6.5.2 to 6.5.3.
Changelog
Sourced from https://github.com/ljharb/qs/blob/main/CHANGELOG.md;>qs's
changelog.
6.5.3
[
https://issues.apache.org/jira/browse/SLING-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646356#comment-17646356
]
Eric Norman commented on SLING-11726:
-
PR #19 contains the proposed changes for review and feedback
rombert commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1347337452
@Kronnox - please open a new Sling Jira issue, SLING-11679 is already used
for the testing clients and is closed.
@joerghoh - you cut the testing clients
sonarcloud[bot] commented on PR #19:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/19#issuecomment-1347321650
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1346827483
SonarCloud Quality Gate failed. [![Quality Gate
joerghoh commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1346678080
thanks @anban02 for your contribution, I merged it now. Let's discuss the
release over in SLING-10110.
--
This is an automated message from the Apache Git
joerghoh merged PR #26:
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646149#comment-17646149
]
Robert Munteanu commented on SLING-10110:
-
[~joerghoh] - you can't assign this to Andreas as-is,
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646144#comment-17646144
]
Joerg Hoh commented on SLING-10110:
---
[~SonglessHill] can you please assign this ticket to yourself (if
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1346632296
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1346600577
SonarCloud Quality Gate failed. [![Quality Gate
anban02 commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#discussion_r1045877563
##
src/test/java/org/apache/sling/dynamicinclude/util/RequestHelperUtilTest.java:
##
@@ -0,0 +1,143 @@
+/*-
+ * Licensed to the Apache
anban02 commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1346569617
I just updated the code but now that it is less code and because of the
change in the IncludeTagFilter to make it call the Util-Class I don't have the
joerghoh commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#discussion_r1045852720
##
src/test/java/org/apache/sling/dynamicinclude/util/RequestHelperUtilTest.java:
##
@@ -0,0 +1,143 @@
+/*-
+ * Licensed to the Apache
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1346538564
SonarCloud Quality Gate failed. [![Quality Gate
oliverlietz commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/30#issuecomment-1346481778
@cziegeler, That is what I tried before:
```
@ConsumerType
public interface ErrorHandler extends
org.apache.sling.api.servlets.ErrorHandler {
}
cziegeler commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/30#issuecomment-1346429069
We really should avoid major version changes to API as this will break
users. I assume one way out is to let the engine error handler extend the api
error handler
sonarcloud[bot] commented on PR #46:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/46#issuecomment-1346351759
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz reassigned SLING-11728:
Assignee: Oliver Lietz
> Remove bi-directional dependencies between Engine and Servlets
[
https://issues.apache.org/jira/browse/SLING-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646047#comment-17646047
]
Oliver Lietz commented on SLING-11728:
--
PRs for Option 2:
# API:
oliverlietz opened a new pull request, #46:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/46
…vlets Resolver
copy ErrorHandler from org.apache.sling.engine.servlets to
org.apache.sling.api.servlets
--
This is an automated message from the Apache Git Service.
To
oliverlietz opened a new pull request, #30:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/30
…vlets Resolver
* switch from org.apache.sling.engine.servlets.ErrorHandler to
org.apache.sling.api.servlets.ErrorHandler
* remove
oliverlietz opened a new pull request, #32:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/32
…vlets Resolver
* switch from org.apache.sling.engine.servlets.ErrorHandler to
org.apache.sling.api.servlets.ErrorHandler
* update to Sling Bundle Parent 49
Oliver Lietz created SLING-11728:
Summary: Remove bi-directional dependencies between Engine and
Servlets Resolver
Key: SLING-11728
URL: https://issues.apache.org/jira/browse/SLING-11728
Project:
35 matches
Mail list logo
