Re: [jdk bug] for those of you on Mac running JDK 1.8

Fixed now via https://issues.apache.org/jira/browse/SLING-8202 . > On 7. Jan 2019, at 14:45, Konrad Windszus wrote: > > Tried to do this with >

Re: [jdk bug] for those of you on Mac running JDK 1.8

Tried to do this with https://github.com/apache/sling-org-apache-sling-api/commit/63caf8de12b6187698a2f0f1ed2225f8315e9ce4 . Unfortunately the seed job does not seem to pick that up:

Re: [jdk bug] for those of you on Mac running JDK 1.8

IMHO no need to enforce building with Java 11. It is just that you need Java 9 or newer to circumvent that bug. But you can use Java 11 as well if you want to, but I don't see a reason to enforce that right now. > On 7. Jan 2019, at 14:11, Julian Reschke wrote: > > On 2019-01-07 09:18, Konrad

Re: [jdk bug] for those of you on Mac running JDK 1.8

On 2019-01-07 09:18, Konrad Windszus wrote: I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640

Re: [jdk bug] for those of you on Mac running JDK 1.8

Hi Konrad, > On 7 Jan 2019, at 11:40, Konrad Windszus wrote: > > or should I create a .sling-module.xml for the API module setting an explicit > property via I find this approach cleaner and easier to document - setting maven.javadoc.skip to true sounds nicer than a check for a JENKINS_*

Re: [jdk bug] for those of you on Mac running JDK 1.8

Below is my env, I have a newer revision (191). Maybe it's related to that? Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) Maven home: /home/cziegeler/Developer/Tools/apache-maven-3.5.4 Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:

Re: [jdk bug] for those of you on Mac running JDK 1.8

Now Jenkins build fails as well. Didn't really think of it... Any preference on how to disable this for Jenkins? Should I just check the existence of any of these environment variables: https://stackoverflow.com/a/14242750 or should I create a

Re: [jdk bug] for those of you on Mac running JDK 1.8

Now that’s weird. Before opening the JDK bug I chatted to Robert and asked him to run a build on his system: $ mvn -v Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00) Maven home: /usr/share/java/maven Java version: 1.8.0_181, vendor: Oracle Corporation,

Re: [jdk bug] for those of you on Mac running JDK 1.8

Thanks for the confirmation. Always activated the profile now in https://github.com/apache/sling-org-apache-sling-api/commit/62da4e295a799f3c784a10f23079ec2224929b1e. > On 7. Jan 2019, at 11:17, Carsten Ziegeler wrote: > > I get the same error with Windows. > > > Regards > > Carsten > > >

Re: [jdk bug] for those of you on Mac running JDK 1.8

Done. As always, somebody has to review my update and publish it… :) > On 7 Jan 2019, at 09:03, Konrad Windszus wrote: > > @Radu: Can you update the JDK bug with that information? I unfortunately > cannot comment on that.

Re: [jdk bug] for those of you on Mac running JDK 1.8

I get the same error with Windows. Regards Carsten Konrad Windszus wrote Can anyone check on Windows? Then I would always enable that profile! On 7. Jan 2019, at 10:13, Carsten Ziegeler wrote: FWIW I get the same error with Ubuntu and Java8 Regards Carsten Konrad Windszus wrote I

Re: [jdk bug] for those of you on Mac running JDK 1.8

Can anyone check on Windows? Then I would always enable that profile! > On 7. Jan 2019, at 10:13, Carsten Ziegeler wrote: > > FWIW I get the same error with Ubuntu and Java8 > > > Regards > > Carsten > > > Konrad Windszus wrote >> I enforced now JDK9 or newer on Macs for Sling API in >>

Re: [jdk bug] for those of you on Mac running JDK 1.8

On Mon, Jan 7, 2019 at 9:18 AM Konrad Windszus wrote: > > I enforced now JDK9 or newer on Macs for Sling API > in > https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 > >

Re: [jdk bug] for those of you on Mac running JDK 1.8

FWIW I get the same error with Ubuntu and Java8 Regards Carsten Konrad Windszus wrote I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640

Re: [jdk bug] for those of you on Mac running JDK 1.8

I enforced now JDK9 or newer on Macs for Sling API in https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 . We can extend to other operating

Re: [jdk bug] for those of you on Mac running JDK 1.8

I did some more tests, and the problem is the class https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/spi/resource/provider/ResolveContext.java

Re: [jdk bug] for those of you on Mac running JDK 1.8

Since this does not seem to affect all cases where the IntelliJ null annotations are used I would recommend we enforce building with Java 9+ only for the Sling API part for Mac OS X for now. We can extend to other operating systems if this reliably fails for them as well. WDYT? > On 18. Dec

Re: [jdk bug] for those of you on Mac running JDK 1.8

On 2018-12-18 17:35, Konrad Windszus wrote: We can still put it in a dedicated profile which is only active on a Mac. I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place). Konrad I've seen at least

Re: [jdk bug] for those of you on Mac running JDK 1.8

We can still put it in a dedicated profile which is only active on a Mac. I would volunteer to add it to the parent pom since a lot of modules are affected (as the IntelliJ Null annotations are used all over the place). Konrad > On 18. Dec 2018, at 17:03, Robert Munteanu wrote: > > It's worth

Re: [jdk bug] for those of you on Mac running JDK 1.8

It's worth noting that it only affects Mac builds so far, so enforcing Java 9 might be a step too far. Robert On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote: > I think due to that we should enforce building with at least Java 9. > WDYT? > > > On 18. Dec 2018, at 16:54, Konrad Windszus

Re: [jdk bug] for those of you on Mac running JDK 1.8

I think due to that we should enforce building with at least Java 9. WDYT? > On 18. Dec 2018, at 16:54, Konrad Windszus wrote: > > Thanks a lot for that. Observed that as well but haven't had the time to > investigate. I fear though that Oracle will no longer fix stuff in JDK 8. > Konrad > >>

Re: [jdk bug] for those of you on Mac running JDK 1.8

Thanks a lot for that. Observed that as well but haven't had the time to investigate. I fear though that Oracle will no longer fix stuff in JDK 8. Konrad > On 18. Dec 2018, at 16:51, Radu Cotescu wrote: > > Hi, > > I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one cannot build the