[jira] [Assigned] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer reassigned SLING-12053: Assignee: Andreas Schaefer > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement > Reporter: Andreas Schaefer > Assignee: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770495#comment-17770495 ] Andreas Schaefer commented on SLING-12053: -- I suggested a version check in the garaphql-java grade.build: Import-Package: !android.os.*,!com.google.*,!org.checkerframework.*,!javax.annotation.*,!graphql.com.google.*,!org.antlr.*,!graphql.org.antlr.*,!sun.misc.*,org.slf4j;version="[1.7,3.0)",* That would allow to use SLF4J version 1.7 and newer and would allow us to keep using it. This is my discussion with graphs-java: [https://github.com/graphql-java/graphql-java/issues/3339] > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770244#comment-17770244 ] Andreas Schaefer commented on SLING-12053: -- When I took Sling GraphQL Core 0.0.25-SNAPSHOT and upgraded to graphql-java 21.1 it broke the build. There are several issues with it: * It introduced a dependency to android.os (was fixed in the meantime) * upgraded to SLF4J to 2.0.x which breaks our build (I tested it by downgrading to 1.7.25 and that still works) I will check if graphql-java can contain a dependency range of SLF4J of 1.7 to 3.0 instead of 2.0 to 3.0 to allow use to upgrade. > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement > Reporter: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
Andreas Schaefer created SLING-12053: Summary: Upgrade Sling GraphQL Core to Graphql-Java 21.x Key: SLING-12053 URL: https://issues.apache.org/jira/browse/SLING-12053 Project: Sling Issue Type: Improvement Reporter: Andreas Schaefer There is an upgrade from graphql-java of 21.x and that has (according to them) breaking changes. As upgrading takes time I wanted to start the process early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12027) GraphQL core fails to build with Java 17
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768921#comment-17768921 ] Andreas Schaefer commented on SLING-12027: -- [~radu] Does not do the trick. I upgraded to the latest Engine, Servlets Resolver and some more and it still breaks the same way. It actually makes it even rose because now additional IT tests fail. > GraphQL core fails to build with Java 17 > > > Key: SLING-12027 > URL: https://issues.apache.org/jira/browse/SLING-12027 > Project: Sling > Issue Type: Bug > Components: GraphQL >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > 1. Mockito fails to create mocks, probably due to old version > 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [RESULT] [VOTE] Release Apache Sling GraphQL Core version 0.0.24
Hi This is still push is still pending. Can a PMC do it for me as I cannot. Cheers - Andy > On Sep 19, 2023, at 12:49 PM, Andreas Schaefer > wrote: > > Can a PMC push the release to > https://dist.apache.org/repos/dist/release/sling/. I will finish the rest > afterwards.
[jira] [Commented] (SLING-12027) GraphQL core fails to build with Java 17
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767252#comment-17767252 ] Andreas Schaefer commented on SLING-12027: -- I found the cause of the issue. During the handling of the error the DefaultErrorHandlerServlet.service() (line 70) is trying to find the error code but it is not found. So it seems there is a disconnect between when that error code is set in SlingServletResolver.handleError() line 387 and when it is looked up. > GraphQL core fails to build with Java 17 > > > Key: SLING-12027 > URL: https://issues.apache.org/jira/browse/SLING-12027 > Project: Sling > Issue Type: Bug > Components: GraphQL >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > 1. Mockito fails to create mocks, probably due to old version > 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12027) GraphQL core fails to build with Java 17
[
https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767199#comment-17767199
]
Andreas Schaefer commented on SLING-12027:
--
Here are some excerpts of the output:
a) Where the invalid query is discovered:
Caused by: org.apache.sling.api.resource.ResourceNotFoundException: Resource at
'/graphql/two.gql/persisted' not found: No resource found
at
org.apache.sling.servlets.get.impl.DefaultGetServlet.doGet(DefaultGetServlet.java:288)
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
at
org.apache.sling.graphql.core.schema.DefaultSchemaProvider.getSchema(DefaultSchemaProvider.java:67)
at
org.apache.sling.graphql.core.schema.RankedSchemaProviders.getSchema(RankedSchemaProviders.java:58)
at
org.apache.sling.graphql.core.engine.DefaultQueryExecutor.prepareSchemaDefinition(DefaultQueryExecutor.java:339)
... 61 more
org.apache.sling.graphql.core[org.apache.sling.graphql.core.servlet.GraphQLServlet]
: Is Query Valid: 'false'
org.apache.sling.graphql.core[org.apache.sling.graphql.core.servlet.GraphQLServlet]
: Invalid GraphQL query: Schema provider failed
b) Looking for sling/nonexisting
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path '/apps/sling/nonexisting'
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl]
: Resource null /apps/sling/nonexisting
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.ResourceResolverImpl]
: getResourceInternal: Cannot resolve path '/apps/sling/nonexisting' to a
resource
c) Looking for sling/servlet/errorhandler
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path '/apps/sling/servlet/errorhandler'
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl]
: Resource null /apps/sling/servlet/errorhandler
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.ResourceResolverImpl]
: getResourceInternal: Cannot resolve path '/apps/sling/servlet/errorhandler'
to a resource
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path '/apps/sling/servlet/errorhandler'
org.apache.sling.servlets.resolver[org.apache.sling.servlets.resolver.internal.SlingServletResolver]
: Accepting servlet at '/apps/sling/servlet/errorhandler.servlet' as there are
no configured execution paths.
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path
'/apps/sling/servlet/errorhandler.servlet'
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl]
: Resource null /apps/sling/servlet/errorhandler.servlet
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.ResourceResolverImpl]
: getResourceInternal: Cannot resolve path
'/apps/sling/servlet/errorhandler.servlet' to a resource
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path '/libs/sling/servlet/errorhandler'
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl]
: Resolved Synthetic /libs/sling/servlet/errorhandler
d) Writing out the Internal Server Error:
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array
HeapByteBuffer@5a63afc1[p=0,l=50,c=512,r=50]=\{<<<>>>\x00\x00\x00\x00\x00\x00\x00\x00\x00...\x00\x00\x00\x00\x00\x00\x00})
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array)
s=OPEN,api=BLOCKING,sc=false,e=null aggregated !flush
DirectByteBuffer@fd5949f[p=0,l=50,c=32768,r=50]=\{<<<>>>\x00\x00\x00\x00\x00\x00\x00\x00\x00...\x00\x00\x00\x00\x00\x00\x00}
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array
HeapByteBuffer@fd4c2d3[p=0,l=1,c=512,r=1]=\{<<<\n>>>!DOCTYPE
...\x00\x00\x00\x00\x00\x00\x00})
...
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array
HeapByteBuffer@516d7550[p=0,l=1,c=512,r=1]=\{<<< >>>00tle>PE
...\x00\x00\x00\x00\x00\x00\x00})
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array)
s=OPEN,api=BLOCKING,sc=false,e=null aggregated !flush
DirectByteBuffer@fd5949f[p=0,l=76,c=32768,r=76]=\{<<
[jira] [Commented] (SLING-12027) GraphQL core fails to build with Java 17
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767174#comment-17767174 ] Andreas Schaefer commented on SLING-12027: -- The current PR for this ticket is: [https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38] Looking at the failure in the GraphQLServletIT.testPersistingInvalidQueries() is that the GraphQLServlet.doPostPersistedQuery() is failing the query validation and sets the Response Error Code to SC_BAD_REQUEST. That said in the output I see that after looking for 'sling/nonexisting' and then 'sling/servlet/errorhandler' is failing. After that I see that the org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] is writing an Internal Server Error which is then returned to the client. So this is not a GraphQL issue but rather a testing setup issue. > GraphQL core fails to build with Java 17 > > > Key: SLING-12027 > URL: https://issues.apache.org/jira/browse/SLING-12027 > Project: Sling > Issue Type: Bug > Components: GraphQL >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > 1. Mockito fails to create mocks, probably due to old version > 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
SLING-12027: GraphQLServletIT.testPersistingInvalidQueries() failure
Hi I was asked to review PR: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38 and I cannot debug the issue. So from the output I see this: - GraphQLServlet.doPostPersistedQuery() fails because the Query validation returns false - Response.setError BAD REQUEST - SlingServletResolver tries to find /libs/sling/servlet/errorhandler/default.servlet and fails - org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput writes a Internal Server Error - IT Test receives a 500 response status code I am not versed in the handling of the Error Handler and if that is causing the issue. What I see is that even though the BAD Request is set as Error the code is still returning the Server Error instead. So this is not a GraphQL issue but rather a testing issue. Any help is appreciated. - Andy
[RESULT] [VOTE] Release Apache Sling GraphQL Core version 0.0.24
Hi Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Joerg Hoh, Robert Munteanu +1 (non binding): none Can a PMC push the release to https://dist.apache.org/repos/dist/release/sling/. I will finish the rest afterwards. Cheers - Andy
Re: Vote on latest Sling GraphQL Core release 0.0.24
Hi Robert I will do that next time. Regarding Java 17 - I saw your updated the Wiki page related to that but I did not have time to check it out yet. I will try to solve this ASAP but Pax Exam so far is not cooperating. Cheers - Andy > On Sep 19, 2023, at 2:33 AM, Robert Munteanu wrote: > > Hi Andy, > > On Mon, 2023-09-18 at 09:53 -0700, Andreas Schaefer wrote: >> Hi >> >> I need one more vote to release Sling GraphQL Core 0.0.24. This has >> an important update to handle fields with the same simple name aka >> name. Right now previous fields are dropped and so I moved that to a >> Multi Value Map to avoid it and to make FQNs the unique field name. >> > > I voted on the release, thanks for the reminder. A couple of notes: > > - I find it easier to reply to the original [VOTE] email when sending > reminders, this way everyone has the context ( staging repository, > changelog, etc ) > - When bundles don't build on Java 17 I usually leave the voting to > others because I have to adjust my validation tooling for that bundle > in question. It would be great if the next version of the GraphQL > bundle would work on Java 17. I created a PR which is almost complete > [1], please look into it when you have time. > > Thanks, > Robert > > > [1]: > https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38
Vote on latest Sling GraphQL Core release 0.0.24
Hi I need one more vote to release Sling GraphQL Core 0.0.24. This has an important update to handle fields with the same simple name aka name. Right now previous fields are dropped and so I moved that to a Multi Value Map to avoid it and to make FQNs the unique field name. Cheers - Andy
[VOTE] Release Apache Sling GraphQL Core 0.0.24
Hi, We solved 1 issues in this release: https://issues.apache.org/jira/browse/SLING-12014 There are still some outstanding issues: https://issues.apache.org/jira/browse/SLING-10901 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2781 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2781 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Cheers - Andy
[jira] [Updated] (SLING-10901) Allow terminating a GraphQL query after a configured timeout
[ https://issues.apache.org/jira/browse/SLING-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-10901: - Fix Version/s: GraphQL Core 0.0.26 (was: GraphQL Core 0.0.24) > Allow terminating a GraphQL query after a configured timeout > > > Key: SLING-10901 > URL: https://issues.apache.org/jira/browse/SLING-10901 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > Since expensive GraphQL queries could lead to a DoS attack, it would be worth > allowing a system administrator to configure the maximum execution time of a > query. When a long running query is interrupted, the returned error should be > transparent for the GraphQL engine, so that the client knows exactly why the > query failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12014) GraphQL Core needs to support additional fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-12014: - Fix Version/s: GraphQL Core 0.0.24 > GraphQL Core needs to support additional fields from GraphQL Java > - > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement > Reporter: Andreas Schaefer > Assignee: Andreas Schaefer >Priority: Major > Fix For: GraphQL Core 0.0.24 > > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12014) GraphQL Core needs to support additional fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-12014. -- Resolution: Fixed PR was merged into master > GraphQL Core needs to support additional fields from GraphQL Java > - > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement > Reporter: Andreas Schaefer > Assignee: Andreas Schaefer >Priority: Major > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12014) GraphQL Core needs to support additional fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer closed SLING-12014. > GraphQL Core needs to support additional fields from GraphQL Java > - > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement > Reporter: Andreas Schaefer > Assignee: Andreas Schaefer >Priority: Major > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12014) GraphQL Core needs to Support Addition Fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760638#comment-17760638 ] Andreas Schaefer commented on SLING-12014: -- Create a PR for this enhancements: [https://github.com/apache/sling-org-apache-sling-graphql-core/pull/37] > GraphQL Core needs to Support Addition Fields from GraphQL Java > --- > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement > Reporter: Andreas Schaefer > Assignee: Andreas Schaefer >Priority: Major > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12014) GraphQL Core needs to Support Addition Fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer reassigned SLING-12014: Assignee: Andreas Schaefer > GraphQL Core needs to Support Addition Fields from GraphQL Java > --- > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement > Reporter: Andreas Schaefer > Assignee: Andreas Schaefer >Priority: Major > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer reassigned SLING-11458:
Assignee: Andreas Schaefer (was: Radu Cotescu)
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12014) GraphQL Core needs to Support Addition Fields from GraphQL Java
Andreas Schaefer created SLING-12014: Summary: GraphQL Core needs to Support Addition Fields from GraphQL Java Key: SLING-12014 URL: https://issues.apache.org/jira/browse/SLING-12014 Project: Sling Issue Type: Improvement Reporter: Andreas Schaefer There is a need to have additional fields from the GraphQL Java's Selected Field. For example there is a need to separate fields with the same name but different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Engine 2.15.6
+1 (non-binding) - Andy > On Aug 15, 2023, at 6:26 AM, Radu Cotescu wrote: > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353543=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2778/ > > You can use this UNIX script to download the release and verify the > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2778 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754179#comment-17754179
]
Andreas Schaefer commented on SLING-11458:
--
The Servlet Writer should not be closed inside the GraphQL Servlet as it was
originally.
Because the GraphQL Servlet is used with a redirect and when it is closed
prematurely the calling servlet is causing an exception (as mentioned in the
ticket) that the writer was already closed. The fix could also be that there is
not exception raised when the writer is closed again which it should if you
asked me but that is not how it works right now.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[ANN] Apache Sling GraphQL Core 0.0.22 Released
The Apache Sling team is pleased to announce the release of Apache Sling GraphQL Core version 0.0.22 Apache Sling is a web framework that uses a Java Content Repository, such as Apache Jackrabbit, to store and manage content. Sling applications use either scripts or Java servlets, selected based on simple name conventions, to process HTTP requests in a RESTful way. This release addresses an issue with the GraphQL’s Inlined Fragments that were deprecated in version 20.1 and replaced with Object Type Names. This release is available from http://sling.apache.org/site/downloads.cgi Building from verified sources is recommended, but convenience binaries are also available via Maven: org.apache.sling org.apache.sling.graphql.core/artifactId> 0.0.22 Enjoy! -The Sling team
Re: [RESULT] [VOTE] Release Apache Sling GraphQL Core 0.0.22
Hi Can any PMC push the artifact to https://dist.apache.org/repos/dist/release/sling/ ? I need to have this release out as soon as possible - Thanks > On Jul 26, 2023, at 12:31 AM, Andreas Schaefer > wrote: > > Hi, > > I finishing the release of GraphQL that Radu created for me as my travel > computer cannot sign a release. > > The vote has passed with the following result : > > +1 (binding): Robert Munteanu, Casten Ziegler, Joerg Hoh, Daniel Klco > +1 (non binding): Andreas Schaefer > > Can a PMC push this release to > https://dist.apache.org/repos/dist/release/sling/ ? > > I will finish the release afterwards. > > Thanks - Andy
[RESULT] [VOTE] Release Apache Sling GraphQL Core 0.0.22
Hi, I finishing the release of GraphQL that Radu created for me as my travel computer cannot sign a release. The vote has passed with the following result : +1 (binding): Robert Munteanu, Casten Ziegler, Joerg Hoh, Daniel Klco +1 (non binding): Andreas Schaefer Can a PMC push this release to https://dist.apache.org/repos/dist/release/sling/ ? I will finish the release afterwards. Thanks - Andy
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.22
I am sorry to be a little pushy here but this is an important release to upgrade to the latest GraphQL-java because of security vulnerabilities in v15.0. The previous release failed to address an issue with Inlined Fragments which are dropped by graphql-java but it can be resolved with the Object Type Names which are not exposed in this release 0.0.22. Thanks - Andy > On Jul 20, 2023, at 9:49 AM, Radu Cotescu wrote: > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12353082 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2772/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2772 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.22
+1 (non-binding) Thank to Radu for cutting the release for me due to my travel. - Andy > On Jul 20, 2023, at 9:49 AM, Radu Cotescu wrote: > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12353082 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2772/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2772 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu
More Sling GraphQL Core Jenkins Wows
Hi After limiting the Jenkins build to JDK 11 to release a fix required for the last release the build is still failing with a pretty weird issue: https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/4/pipeline/ It cannot download the JAR file: Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not transfer artifact commons-lang:commons-lang:pom:2.3 from/to central (https://repo.maven.apache.org/maven2): Connection reset at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed (ArtifactTransportListener.java:44) at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run (BasicRepositoryConnector.java:417) Right before that the build could download the commons-lang POM file w/o any issues so I am not sure what is going on. - Andy
Re: CI Build issue for GraphQL Core
Hi Robert Yeah, looks like it but the fix mentioned there is not working with GraphQL. I am running into the same problem with the Pax Exam tests but I also running into OSGi based unit test failures. GraphQL Core is not using sling-mock-oak but rather the OAK version that comes with sling-mock.junit4. That said I did upgrade the used Oak version in that module to 1.52.0 and it still did not work. - Andy > On Jul 19, 2023, at 10:44 AM, Robert Munteanu wrote: > > On Wed, 2023-07-19 at 10:40 +0200, Andreas Schaefer wrote: >> After some back and forth I saw that the Pax Exam container fails due >> to issues with java.security.acl.Group class not found issue: >> >> org.apache.sling.jcr.base[org.apache.sling.jcr.oak.server.internal.O >> akSlingRepositoryManager] : Exception in a >> SlingRepositoryInitializer, SlingRepository service registration >> aborted >> java.lang.NoClassDefFoundError: java/security/acl/Group >> at java.base/java.lang.ClassLoader.defineClass1(Native >> Method) >> at >> java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012) > > This seems to be > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690#CommonIssueswhenbuildingwithnewerJDKs(11or17)-OldversionofOak(%3C1.26)pulledinviaSling-Mock-Oak > > Robert
Re: CI Build issue for GraphQL Core
After some back and forth I saw that the Pax Exam container fails due to issues with java.security.acl.Group class not found issue: org.apache.sling.jcr.base[org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager] : Exception in a SlingRepositoryInitializer, SlingRepository service registration aborted java.lang.NoClassDefFoundError: java/security/acl/Group at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012) There are other issues but I think that is the main one. GraphQL Core is using org.apache.sling.testing.sling-mock.junit4 and so I tried to use a newer version of oak-jcr (1.52.0) but that did not solve the issue. Any idea on how to fix this? - Andy > On Jul 18, 2023, at 4:00 PM, Andreas Schaefer > wrote: > > I tried to upgrade a few dependencies but eventually I am running into the > issue on Java 17 that the pax-exam is not able to find the Sling service (in > time). > > Upgrading the pax-exam to 4.3.15 lead to an issue where it is not able to > find org.sl4j.LoggerFactory: > > java.rmi.ServerError: Error occurred in server thread; nested exception is: > java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory > at > org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:168) > … > Caused by: java.rmi.ServerError: Error occurred in server thread; nested > exception is: > java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory > … > Caused by: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory > at > org.ops4j.pax.swissbox.tracker.ServiceLookup.(ServiceLookup.java:41) > ... > Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory > … > > Any idea on how to fix that? > > - Andy > > >> On Jul 18, 2023, at 10:46 AM, Andreas Schaefer >> wrote: >> >> Hi Robert >> >> My problem is not there yet but I updated the wiki page with the issue and >> my discovery so far. >> >> When I upgrade to Mockito-Inline 5.2.0 the compilation issue goes away but >> the pax-exam IT tests are time out when looking up Sling services. >> >> In the past when I tried to upgrade Pax-Exam I ran into other issues so I >> don’t think upgrading would work but I don’t know. >> >> - Andy >> >>> On Jul 18, 2023, at 9:59 AM, Robert Munteanu wrote: >>> >>> Hi Andy, >>> >>> On Tue, 2023-07-18 at 09:47 +0200, Andreas Schaefer wrote: >>>> Hi >>>> >>>> For my latest PR for Sling GraphQL Core I am running into CI build >>>> issues on Java 17: >>>> >>>> https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/3/pipeline >>>> >>>> Any idea on how to resolve this? >>> >>> [1] gathers the problem patterns we saw when migrating builds to Java >>> 11/17, maybe your problem is already listed? >>> >>> Thanks, >>> Robert >>> >>> [1]: >>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690 >> >
Re: CI Build issue for GraphQL Core
I tried to upgrade a few dependencies but eventually I am running into the issue on Java 17 that the pax-exam is not able to find the Sling service (in time). Upgrading the pax-exam to 4.3.15 lead to an issue where it is not able to find org.sl4j.LoggerFactory: java.rmi.ServerError: Error occurred in server thread; nested exception is: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory at org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:168) … Caused by: java.rmi.ServerError: Error occurred in server thread; nested exception is: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory … Caused by: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory at org.ops4j.pax.swissbox.tracker.ServiceLookup.(ServiceLookup.java:41) ... Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory … Any idea on how to fix that? - Andy > On Jul 18, 2023, at 10:46 AM, Andreas Schaefer > wrote: > > Hi Robert > > My problem is not there yet but I updated the wiki page with the issue and my > discovery so far. > > When I upgrade to Mockito-Inline 5.2.0 the compilation issue goes away but > the pax-exam IT tests are time out when looking up Sling services. > > In the past when I tried to upgrade Pax-Exam I ran into other issues so I > don’t think upgrading would work but I don’t know. > > - Andy > >> On Jul 18, 2023, at 9:59 AM, Robert Munteanu wrote: >> >> Hi Andy, >> >> On Tue, 2023-07-18 at 09:47 +0200, Andreas Schaefer wrote: >>> Hi >>> >>> For my latest PR for Sling GraphQL Core I am running into CI build >>> issues on Java 17: >>> >>> https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/3/pipeline >>> >>> Any idea on how to resolve this? >> >> [1] gathers the problem patterns we saw when migrating builds to Java >> 11/17, maybe your problem is already listed? >> >> Thanks, >> Robert >> >> [1]: >> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690 >
Re: CI Build issue for GraphQL Core
Hi Robert My problem is not there yet but I updated the wiki page with the issue and my discovery so far. When I upgrade to Mockito-Inline 5.2.0 the compilation issue goes away but the pax-exam IT tests are time out when looking up Sling services. In the past when I tried to upgrade Pax-Exam I ran into other issues so I don’t think upgrading would work but I don’t know. - Andy > On Jul 18, 2023, at 9:59 AM, Robert Munteanu wrote: > > Hi Andy, > > On Tue, 2023-07-18 at 09:47 +0200, Andreas Schaefer wrote: >> Hi >> >> For my latest PR for Sling GraphQL Core I am running into CI build >> issues on Java 17: >> >> https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/3/pipeline >> >> Any idea on how to resolve this? > > [1] gathers the problem patterns we saw when migrating builds to Java > 11/17, maybe your problem is already listed? > > Thanks, > Robert > > [1]: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690
CI Build issue for GraphQL Core
Hi For my latest PR for Sling GraphQL Core I am running into CI build issues on Java 17: https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/3/pipeline Any idea on how to resolve this? Cheers - Andy
[jira] [Commented] (SLING-11920) Expose Object Type Names in Selected Field
[
https://issues.apache.org/jira/browse/SLING-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741219#comment-17741219
]
Andreas Schaefer commented on SLING-11920:
--
I created a PR
[https://github.com/apache/sling-org-apache-sling-graphql-core/pull/36] that
exposed the Object Type Names to the User.
There is also some cleanup and additional tests to verify the proper handling
of Object Type Names.
> Expose Object Type Names in Selected Field
> --
>
> Key: SLING-11920
> URL: https://issues.apache.org/jira/browse/SLING-11920
> Project: Sling
> Issue Type: Bug
>Affects Versions: GraphQL Core 0.0.20
> Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Critical
> Fix For: GraphQL Core 0.0.22
>
>
> Intermediary fields are not exposed as Selected Fields in Graphql-java and so
> it was added as list of Object Type Name.
> Now for handling '... on ' we need to expose these Object Type
> Names so that a client can deal with them.
> If we have a query where we have a inline fragments
> ([https://graphql.org/learn/queries/#inline-fragments]) like:
> {code:java}
> {
>image {
> ... on ImageRef {
> type{code}
> Then in the graphql-java 15.0 there is an inlined field called *ImageRef* but
> that is now gone in 20.1. Instead we have a list of Object Type Names in a
> field and in our example *type* would have Objet Type Names:
> {*}["ImageRef"]{*}. So for a client to obtain the type of the inlined
> fragments this data must be exposed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11920) Expose Object Type Names in Selected Field
[
https://issues.apache.org/jira/browse/SLING-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer updated SLING-11920:
-
Description:
Intermediary fields are not exposed as Selected Fields in Graphql-java and so
it was added as list of Object Type Name.
Now for handling '... on ' we need to expose these Object Type
Names so that a client can deal with them.
If we have a query where we have a inline fragments
([https://graphql.org/learn/queries/#inline-fragments]) like:
{code:java}
{
image {
... on ImageRef {
type{code}
Then in the graphql-java 15.0 there is an inlined field called *ImageRef* but
that is now gone in 20.1. Instead we have a list of Object Type Names in a
field and in our example *type* would have Objet Type Names:
{*}["ImageRef"]{*}. So for a client to obtain the type of the inlined fragments
this data must be exposed.
was:
Intermediary fields are not exposed as Selected Fields in Graphql-java and so
it was added as list of Object Type Name.
Now for handling '... on ' we need to expose these Object Type
Names so that a client can deal with them.
> Expose Object Type Names in Selected Field
> --
>
> Key: SLING-11920
> URL: https://issues.apache.org/jira/browse/SLING-11920
> Project: Sling
> Issue Type: Bug
>Affects Versions: GraphQL Core 0.0.20
> Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Critical
> Fix For: GraphQL Core 0.0.22
>
>
> Intermediary fields are not exposed as Selected Fields in Graphql-java and so
> it was added as list of Object Type Name.
> Now for handling '... on ' we need to expose these Object Type
> Names so that a client can deal with them.
> If we have a query where we have a inline fragments
> ([https://graphql.org/learn/queries/#inline-fragments]) like:
> {code:java}
> {
>image {
> ... on ImageRef {
> type{code}
> Then in the graphql-java 15.0 there is an inlined field called *ImageRef* but
> that is now gone in 20.1. Instead we have a list of Object Type Names in a
> field and in our example *type* would have Objet Type Names:
> {*}["ImageRef"]{*}. So for a client to obtain the type of the inlined
> fragments this data must be exposed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11920) Expose Object Type Names in Selected Field
[ https://issues.apache.org/jira/browse/SLING-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738806#comment-17738806 ] Andreas Schaefer commented on SLING-11920: -- This is a follow up of SLING-10900 and the release of Sling GraphQL Core 0.0.20 > Expose Object Type Names in Selected Field > -- > > Key: SLING-11920 > URL: https://issues.apache.org/jira/browse/SLING-11920 > Project: Sling > Issue Type: Bug >Affects Versions: GraphQL Core 0.0.20 > Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Critical > Fix For: GraphQL Core 0.0.22 > > > Intermediary fields are not exposed as Selected Fields in Graphql-java and so > it was added as list of Object Type Name. > Now for handling '... on ' we need to expose these Object Type > Names so that a client can deal with them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11920) Expose Object Type Names in Selected Field
Andreas Schaefer created SLING-11920: Summary: Expose Object Type Names in Selected Field Key: SLING-11920 URL: https://issues.apache.org/jira/browse/SLING-11920 Project: Sling Issue Type: Bug Affects Versions: GraphQL Core 0.0.20 Reporter: Andreas Schaefer Assignee: Andreas Schaefer Fix For: GraphQL Core 0.0.22 Intermediary fields are not exposed as Selected Fields in Graphql-java and so it was added as list of Object Type Name. Now for handling '... on ' we need to expose these Object Type Names so that a client can deal with them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling GraphQL Core 0.0.20
Hi The vote passed with the following result: +1 (binding): Radu Cotescu, Robert Munteanu, Stefan Seifert Can a PMC push the release to https://dist.apache.org/repos/dist/release/sling/ for me? Cheers - Andy Schaefer
Sling GrsphQL CORE 0.0.20 Release ?
Hi Back in 3/31/23 I wrote an email for a Vote (https://lists.apache.org/thread/w3fc01lr5b4nmyx0ftpsk9sjvtb5dvnd) to release Apache Sling GraphQL Core 0.0.20 that bumps the usage of graphql-java to the latest 20.1 with a fix to be used in Sling. The issue here is that the previous version used version 15 which contains a security vulnerability which is fixed in 20.1. Unfortunately I only got 2 Up Votes. So what shall I do next? Cancel the vote? Cancel the Vote and try again? Let me know how to proceed. Thanks - Andy
Sling PaxExam Test Issues
Hi I am running into some temporary issues with Sling PaxExam 3.0.0 due to ‘Authentication Support service missing’. When I try to upgrade to Sling PaxExam 3.10 I run into this issue which I do not understand: [ERROR] com.madplanet.wfx.it.WfxWorkloadIT Time elapsed: 3.424 s <<< ERROR! org.ops4j.pax.exam.TestContainerException: java.rmi.ServerError: Error occurred in server thread; nested exception is: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory at org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:168) at org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.setUp(EagerSingleStagedReactor.java:86) at org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.beforeClass(EagerSingleStagedReactor.java:136) at org.ops4j.pax.exam.spi.reactors.ReactorManager.beforeClass(ReactorManager.java:457) at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:97) at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138) at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451) Caused by: java.rmi.ServerError: Error occurred in server thread; nested exception is: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:388) at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200) at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196) at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:562) at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:796) at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:677) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:676) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) at java.rmi/sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:303) at java.rmi/sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:279) at java.rmi/sun.rmi.server.UnicastRef.invoke(UnicastRef.java:164) at java.rmi/java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:217) at java.rmi/java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.java:162) at com.sun.proxy.$Proxy15.setBundleStartLevel(Unknown Source) at org.ops4j.pax.exam.forked.ForkedTestContainer.installAndStartBundles(ForkedTestContainer.java:298) at org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:165) ... 13 more Caused by: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory at org.ops4j.pax.swissbox.tracker.ServiceLookup.(ServiceLookup.java:41) at org.ops4j.pax.swissbox.framework.RemoteFrameworkImpl.setBundleStartLevel(RemoteFrameworkImpl.java:190) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:359) at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200) at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196) at
Release of GraphQL Core 0.0.20
Hi Last Friday I started a Vote for the release of Sling Graphql Core 0.0.20 which contains the upgrade to graphql-java version 20.1. I have two up votes so far and need one more to release it. This release does not impact Sling releases as this is not part of Sling Starter package. Thanks - Andy Schaefer
Re: Release Apache Sling GraphQL Core 0.0.18
Hi After some back and forth I figured out: - Maven was using a different GPG Key - My Apache GPG Key had a sub key which might have caused issues I verified that when I signed a maven file that the .asc file has the right fingerprint (gpg ). So I redid the release and verified on my laptop that the signature was good. Hope that works now. - Andy > On Mar 31, 2023, at 7:42 AM, Radu Cotescu wrote: > > Hi Andy, > >> On 31 Mar 2023, at 11:06, Stefan Seifert >> wrote: >> >> i tried multiple times yesterday and today to validate the new release, but >> the GPG validation is still failing for me, although i've downloaded the >> updated KEYS [1] file in the same way it worked for all the other keys. > > Same issue like Stefan and I’m using the Committer CLI tool [2] to verify > releases. This always downloads the KEYS file before verifying. Here’s the > output: > >> Signature org.apache.sling.graphql.core-0.0.18-javadoc.jar.asc was not >> generated with any of the known keys. > > > Therefore I guess you need to cancel this release as well. I could start the > release for you, if you want, until you can figure out what went wrong with > your GPG setup. Just let me know (either by replying here or by actually > cancelling the previous release threads). > > Thanks, > Radu > > [2] - https://github.com/apache/sling-org-apache-sling-committer-cli
[VOTE] Release Apache Sling GraphQL Core 0.0.20
Hi, We solved 1 issues in this release: https://issues.apache.org/jira/browse/SLING-10900 There are still 1 outstanding issue: https://issues.apache.org/jira/browse/SLING-10901 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2734 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2734 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. NOTE: I am on a new computer and lost my original GPG Key. I issued and uploaded a new GPG Key and updated it on my Apache ID but that might take some time to update in Apache Sling Release Keys page. Thanks - Andy
[jira] [Updated] (SLING-10901) Allow terminating a GraphQL query after a configured timeout
[ https://issues.apache.org/jira/browse/SLING-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-10901: - Fix Version/s: GraphQL Core 0.0.22 (was: GraphQL Core 0.0.20) > Allow terminating a GraphQL query after a configured timeout > > > Key: SLING-10901 > URL: https://issues.apache.org/jira/browse/SLING-10901 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.22 > > > Since expensive GraphQL queries could lead to a DoS attack, it would be worth > allowing a system administrator to configure the maximum execution time of a > query. When a long running query is interrupted, the returned error should be > transparent for the GraphQL engine, so that the client knows exactly why the > query failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10900) Update graphql-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer updated SLING-10900:
-
Fix Version/s: GraphQL Core 0.0.20
(was: GraphQL Core 0.0.18)
> Update graphql-java to version 17
> -
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.20
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [CANCELLED][VOTE] Release Apache Sling Graphql Core version 0.0.16
I missed the part of replying to the original email to cancel it. > On Mar 27, 2023, at 12:47 PM, Andreas Schaefer > wrote: > > > Hi, > > We solved N issues in this release: > > https://issues.apache.org/jira/browse/SLING-10900 > > NOTE: this was tested with AEM 6.6 > > There are still some outstanding issues: none > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2730 > > https://repository.apache.org/content/repositories/orgapachesling-[YOUR > REPOSITORY ID]/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2730 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
Re: [CANCELLED][VOTE] Release Apache Sling GraphQL Core 0.0.18
> On Mar 28, 2023, at 1:44 PM, Andreas Schaefer wrote: > > Hi, > > We solved 1 issues in this release: > > https://issues.apache.org/jira/browse/SLING-10900 > > There are still 1 outstanding issue: > > https://issues.apache.org/jira/browse/SLING-10901 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2733 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2733 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > NOTE: I am on a new computer and lost my original GPG Key. I issued and > uploaded a new GPG Key and updated it on my Apache ID but that might take > some time to update in Apache Sling Release Keys page. > > Thanks - Andy >
Re: [VOTE] Release Apache Sling Graphql Core version 0.0.16
Hi Robert I did cancel the vote on 3/28 but it seems I did not make it into the mailing list. I resent it to clarify it. Thanks - Andy > On Mar 31, 2023, at 6:21 AM, Robert Munteanu wrote: > > Hi Andreas, > > Is this vote cancelled? I see that you started a new one for version > 0.0.18. If so, please make sure to follow the process from [1]. > > Thanks! > > Robert > > [1]: > https://sling.apache.org/documentation/development/release-management.html#canceling-the-release-1 > > On Mon, 2023-03-27 at 12:47 -0700, Andreas Schaefer wrote: >> >> Hi, >> >> We solved N issues in this release: >> >> https://issues.apache.org/jira/browse/SLING-10900 >> >> NOTE: this was tested with AEM 6.6 >> >> There are still some outstanding issues: none >> >> Staging repository: >> https://repository.apache.org/content/repositories/orgapachesling-2730 >> >> https://repository.apache.org/content/repositories/orgapachesling-[YOUR >> REPOSITORY ID]/ >> >> You can use this UNIX script to download the release and verify the >> signatures: >> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD >> >> Usage: >> sh check_staged_release.sh 2730 /tmp/sling-staging >> >> Please vote to approve this release: >> >> [ ] +1 Approve the release >> [ ] 0 Don't care >> [ ] -1 Don't release, because ... >> >> This majority vote is open for at least 72 hours. >> >
[VOTE][CANCELLED] Release Apache Sling Graphql Core version 0.0.16
Hi I set this email out on 3/28/23 but I seems it did not make it into the mailing list. I created the release of GraphQL Core 0.0.16 on the wrong branch and so I cancel this vote and redo this on 0.0.18 while fixing all the issues raised by Stefan. Thanks - Andy
Release Apache Sling GraphQL Core 0.0.18
Hi I created a new release of GraphQL Core v 0.0.18 and put it up to a vote but so far nobody responded. This is an important release for AEM to fix a security issue in graphql-java:https://nvd.nist.gov/vuln/detail/CVE-2022-37734 Thanks - Andy
Re: PGP Keys Issue
Hi Julian Thanks, looks right to me. - Andy > On Mar 29, 2023, at 12:31 PM, Julian Sedding wrote: > > Hi Andy > > I have added your new key to the end of the KEYS file. Can you please > verify that I added the correct one? > > Regards > Julian > > On Wed, Mar 29, 2023 at 6:01 PM Andreas Schaefer > wrote: >> >> Thanks Konrad for the clarification. I am not a PMC member (AFAIK) and so I >> cannot update that file. >> >> - Andy >> >>> On Mar 29, 2023, at 8:22 AM, Konrad Windszus wrote: >>> >>> Yes, the steps are outlined in >>> https://sling.apache.org/documentation/development/release-management.html#appendix-a-creating-and-registering-your-pgp-key >>> as mentioned by Julian. >>> You have to manually update the KEYS file in SVN! >>> >>> Konrad >>> >>>> On 29. Mar 2023, at 16:52, Andreas Schaefer >>>> wrote: >>>> >>>> Thanks Julian for the response. >>>> >>>> If you are referring to the setup of the encrypted Maven password my LDAP >>>> password has not changed nor the Maven master password. >>>> >>>> That said this page https://dist.apache.org/repos/dist/release/sling/KEYS >>>> is still showing the old LDAP GPG fingerprint even though I have changed >>>> that in my Apache ID (https://id.apache.org/details/andysch). >>>> >>>> Do I need to change this somewhere else? >>>> >>>> Thanks - Andy >>>> >>>>> On Mar 29, 2023, at 12:06 AM, Julian Sedding wrote: >>>>> >>>>> Hi Andreas >>>>> >>>>> Have you followed these steps: >>>>> https://sling.apache.org/documentation/development/release-management.html#appendix-a-creating-and-registering-your-pgp-key-1 >>>>> >>>>> Regards >>>>> Julian >>>>> >>>>> On Tue, Mar 28, 2023 at 7:44 PM Andreas Schaefer >>>>> wrote: >>>>>> >>>>>> I think I found the solution - waiting until >>>>>> https://dist.apache.org/repos/dist/release/sling/KEYS updates with my >>>>>> new key. >>>>>> >>>>>>> On Mar 28, 2023, at 9:33 AM, Andreas Schaefer >>>>>>> wrote: >>>>>>> >>>>>>> Hi >>>>>>> >>>>>>> I moved to a new computer and did not do much work on Apache. When I >>>>>>> prepared for the release of GrpahQL Core 0.0.16 I realized that I did >>>>>>> not have a PGP Key and so I created a new PGP Key using ‘GPG Keychain’ >>>>>>> and published that key. >>>>>>> >>>>>>> On the Sling Release Key server >>>>>>> (https://dist.apache.org/repos/dist/release/sling/KEYS) there is still >>>>>>> my old PGP Key listed (49EC C3FC FD4C DF49 F308 DEC2 7493 91D1 63EF >>>>>>> CDEF) but not the new one. >>>>>>> >>>>>>> I can find that old key but I don’t have the private key part anymore. >>>>>>> How to I swap the old key with the new one for Sling Releases? >>>>>>> >>>>>>> Thanks - Andy >>>>>> >>>> >>> >>
Re: PGP Keys Issue
Thanks Konrad for the clarification. I am not a PMC member (AFAIK) and so I cannot update that file. - Andy > On Mar 29, 2023, at 8:22 AM, Konrad Windszus wrote: > > Yes, the steps are outlined in > https://sling.apache.org/documentation/development/release-management.html#appendix-a-creating-and-registering-your-pgp-key > as mentioned by Julian. > You have to manually update the KEYS file in SVN! > > Konrad > >> On 29. Mar 2023, at 16:52, Andreas Schaefer wrote: >> >> Thanks Julian for the response. >> >> If you are referring to the setup of the encrypted Maven password my LDAP >> password has not changed nor the Maven master password. >> >> That said this page https://dist.apache.org/repos/dist/release/sling/KEYS is >> still showing the old LDAP GPG fingerprint even though I have changed that >> in my Apache ID (https://id.apache.org/details/andysch). >> >> Do I need to change this somewhere else? >> >> Thanks - Andy >> >>> On Mar 29, 2023, at 12:06 AM, Julian Sedding wrote: >>> >>> Hi Andreas >>> >>> Have you followed these steps: >>> https://sling.apache.org/documentation/development/release-management.html#appendix-a-creating-and-registering-your-pgp-key-1 >>> >>> Regards >>> Julian >>> >>> On Tue, Mar 28, 2023 at 7:44 PM Andreas Schaefer >>> wrote: >>>> >>>> I think I found the solution - waiting until >>>> https://dist.apache.org/repos/dist/release/sling/KEYS updates with my new >>>> key. >>>> >>>>> On Mar 28, 2023, at 9:33 AM, Andreas Schaefer >>>>> wrote: >>>>> >>>>> Hi >>>>> >>>>> I moved to a new computer and did not do much work on Apache. When I >>>>> prepared for the release of GrpahQL Core 0.0.16 I realized that I did not >>>>> have a PGP Key and so I created a new PGP Key using ‘GPG Keychain’ and >>>>> published that key. >>>>> >>>>> On the Sling Release Key server >>>>> (https://dist.apache.org/repos/dist/release/sling/KEYS) there is still my >>>>> old PGP Key listed (49EC C3FC FD4C DF49 F308 DEC2 7493 91D1 63EF CDEF) >>>>> but not the new one. >>>>> >>>>> I can find that old key but I don’t have the private key part anymore. >>>>> How to I swap the old key with the new one for Sling Releases? >>>>> >>>>> Thanks - Andy >>>> >> >
Re: PGP Keys Issue
Thanks Julian for the response. If you are referring to the setup of the encrypted Maven password my LDAP password has not changed nor the Maven master password. That said this page https://dist.apache.org/repos/dist/release/sling/KEYS is still showing the old LDAP GPG fingerprint even though I have changed that in my Apache ID (https://id.apache.org/details/andysch). Do I need to change this somewhere else? Thanks - Andy > On Mar 29, 2023, at 12:06 AM, Julian Sedding wrote: > > Hi Andreas > > Have you followed these steps: > https://sling.apache.org/documentation/development/release-management.html#appendix-a-creating-and-registering-your-pgp-key-1 > > Regards > Julian > > On Tue, Mar 28, 2023 at 7:44 PM Andreas Schaefer > wrote: >> >> I think I found the solution - waiting until >> https://dist.apache.org/repos/dist/release/sling/KEYS updates with my new >> key. >> >>> On Mar 28, 2023, at 9:33 AM, Andreas Schaefer >>> wrote: >>> >>> Hi >>> >>> I moved to a new computer and did not do much work on Apache. When I >>> prepared for the release of GrpahQL Core 0.0.16 I realized that I did not >>> have a PGP Key and so I created a new PGP Key using ‘GPG Keychain’ and >>> published that key. >>> >>> On the Sling Release Key server >>> (https://dist.apache.org/repos/dist/release/sling/KEYS) there is still my >>> old PGP Key listed (49EC C3FC FD4C DF49 F308 DEC2 7493 91D1 63EF CDEF) but >>> not the new one. >>> >>> I can find that old key but I don’t have the private key part anymore. How >>> to I swap the old key with the new one for Sling Releases? >>> >>> Thanks - Andy >>
[VOTE] Release Apache Sling GraphQL Core 0.0.18
Hi, We solved 1 issues in this release: https://issues.apache.org/jira/browse/SLING-10900 There are still 1 outstanding issue: https://issues.apache.org/jira/browse/SLING-10901 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2733 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2733 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. NOTE: I am on a new computer and lost my original GPG Key. I issued and uploaded a new GPG Key and updated it on my Apache ID but that might take some time to update in Apache Sling Release Keys page. Thanks - Andy
[VOTE][CANCELLED] Release Apache Sling Graphql Core version 0.0.16
Hi I created the release of GraphQL Core 0.0.16 on the wrong branch and so I cancel this vote and redo this on 0.0.18 while fixing all the issues raised by Stefan. Thanks - Andy
[jira] [Updated] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer updated SLING-10900:
-
Fix Version/s: GraphQL Core 0.0.18
(was: GraphQL Core 0.0.16)
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.18
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-10901) Allow terminating a GraphQL query after a configured timeout
[ https://issues.apache.org/jira/browse/SLING-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-10901: - Fix Version/s: GraphQL Core 0.0.20 (was: GraphQL Core 0.0.18) > Allow terminating a GraphQL query after a configured timeout > > > Key: SLING-10901 > URL: https://issues.apache.org/jira/browse/SLING-10901 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.20 > > > Since expensive GraphQL queries could lead to a DoS attack, it would be worth > allowing a system administrator to configure the maximum execution time of a > query. When a long running query is interrupted, the returned error should be > transparent for the GraphQL engine, so that the client knows exactly why the > query failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: PGP Keys Issue
I think I found the solution - waiting until https://dist.apache.org/repos/dist/release/sling/KEYS updates with my new key. > On Mar 28, 2023, at 9:33 AM, Andreas Schaefer > wrote: > > Hi > > I moved to a new computer and did not do much work on Apache. When I prepared > for the release of GrpahQL Core 0.0.16 I realized that I did not have a PGP > Key and so I created a new PGP Key using ‘GPG Keychain’ and published that > key. > > On the Sling Release Key server > (https://dist.apache.org/repos/dist/release/sling/KEYS) there is still my old > PGP Key listed (49EC C3FC FD4C DF49 F308 DEC2 7493 91D1 63EF CDEF) but not > the new one. > > I can find that old key but I don’t have the private key part anymore. How to > I swap the old key with the new one for Sling Releases? > > Thanks - Andy
PGP Keys Issue
Hi I moved to a new computer and did not do much work on Apache. When I prepared for the release of GrpahQL Core 0.0.16 I realized that I did not have a PGP Key and so I created a new PGP Key using ‘GPG Keychain’ and published that key. On the Sling Release Key server (https://dist.apache.org/repos/dist/release/sling/KEYS) there is still my old PGP Key listed (49EC C3FC FD4C DF49 F308 DEC2 7493 91D1 63EF CDEF) but not the new one. I can find that old key but I don’t have the private key part anymore. How to I swap the old key with the new one for Sling Releases? Thanks - Andy
[jira] [Updated] (SLING-10901) Allow terminating a GraphQL query after a configured timeout
[ https://issues.apache.org/jira/browse/SLING-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-10901: - Fix Version/s: GraphQL Core 0.0.18 (was: GraphQL Core 0.0.16) > Allow terminating a GraphQL query after a configured timeout > > > Key: SLING-10901 > URL: https://issues.apache.org/jira/browse/SLING-10901 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.18 > > > Since expensive GraphQL queries could lead to a DoS attack, it would be worth > allowing a system administrator to configure the maximum execution time of a > query. When a long running query is interrupted, the returned error should be > transparent for the GraphQL engine, so that the client knows exactly why the > query failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer resolved SLING-10900.
--
Resolution: Fixed
Upgraded to graphql-java 20.1 (latest release) as there are nearly no changes
needed from 17 to 20
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[VOTE] Release Apache Sling Graphql Core version 0.0.16
Hi, We solved N issues in this release: https://issues.apache.org/jira/browse/SLING-10900 NOTE: this was tested with AEM 6.6 There are still some outstanding issues: none Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2730 https://repository.apache.org/content/repositories/orgapachesling-[YOUR REPOSITORY ID]/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2730 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705660#comment-17705660
]
Andreas Schaefer commented on SLING-10900:
--
After graphql-java released 20.1 with the necessary fixes to make it work in an
OSGi environment I updated the code to move to version 20.1 and start the
release process.
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695824#comment-17695824
]
Andreas Schaefer edited comment on SLING-10900 at 3/2/23 5:06 PM:
--
After some help from the graphql-java team I was able to find a solution to
prevent the class loading issue by reverting back to the original class
loading. Branch
[https://github.com/apache/sling-org-apache-sling-graphql-core/tree/issue/SLING-10900-200]
does contain that fix.
That said this will still fail the Jenkins test as the graphql-java 20.0 is not
a valid Feature Model bundle. I hope that somewhere in April graphql-java team
will release 20.1 which should have all the fixes in place.
I also closed the PR 3099 as all the Jenkins test failed and there is no reason
anymore to go with 19.x.
was (Author: schaefa):
After some help from the graphql-java team I was able to find a solution to
prevent the class loading issue by reverting back to the original class
loading. Branch
[https://github.com/apache/sling-org-apache-sling-graphql-core/tree/issue/SLING-10900-200]
does contain that fix.
That said this will still fail the Jenkins test as the graphql-java 20.0 is not
a valid Feature Model bundle. I hope that somewhere in April graphql-java team
will release 20.1 which should have all the fixes in place.
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695824#comment-17695824
]
Andreas Schaefer commented on SLING-10900:
--
After some help from the graphql-java team I was able to find a solution to
prevent the class loading issue by reverting back to the original class
loading. Branch
[https://github.com/apache/sling-org-apache-sling-graphql-core/tree/issue/SLING-10900-200]
does contain that fix.
That said this will still fail the Jenkins test as the graphql-java 20.0 is not
a valid Feature Model bundle. I hope that somewhere in April graphql-java team
will release 20.1 which should have all the fixes in place.
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Issue with JarFile and Manifest.mf order
Hi While dealing with upgrading graphql-java I encountered a rather bizarre issue with bundles. The class ‘AbstractBundleRequestMojo` has a check on line 159 where it uses a JarFile.getManifest() but that only returns the MANIFEST.MF when it is the first entry in the JAR file. That eventually loads to a problem that graphql-java is not installed during the deployment inside a Feature Model. That said when AEM is started and I have all these unresolved issues regarding graphql-java and installation of graphql-java through the OSGi Console does indeed install it. If Felix allows an OSGi bundle to be install with a MANIFEST.MF entry not being the first entry why is Sling then requiring it? Cheers - Andy
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694235#comment-17694235
]
Andreas Schaefer commented on SLING-10900:
--
After testing with AEM this is the current state:
# graphql-java 20.0 leads to class loading issues with GenericConnection
(pagination) which is not only a Sling issue
# graphql-java 17.4, 18.3, 19.3 and 20.0 all contained an import of sun.misc
and the MANIFEST.MF is not the first entry
## Both of these issues are fixed and accepted on 20.x
## There is a pending PR for 19.x with the back port of these fixes
([https://github.com/graphql-java/graphql-java/pull/3099])
# graphql-java 19.3 works just fine with Sling Graphql Core but not when used
in a Feature Model environment
As the issue with class loading seems to be bigger issue so as of now 19.3
seems to be the best target to upgrade to.
I created a PR:
[https://github.com/apache/sling-org-apache-sling-graphql-core/pull/34] that
contains the fixes for the upgrade as well as the adjustments to the tests.
That anyone who wants to use this version inside any Feature Model systems need
to use the fixed version which can be found in here:
[https://github.com/schaefa/graphql-java/tree/issue/manifest-mf.order.19x]. Use
the mentioned above process on created the Graphql-java bundle but with
RELEASE_VERISON of 19.4 or 19.4-SNAPSHOT and then use that then.
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691777#comment-17691777
]
Andreas Schaefer commented on SLING-10900:
--
All graphql-java version newer that 17.4 have an issue with the released JAR
file as the MANIFEST.MF entry is not the first one in the JAR file making it
not deploy when using a Feature Model.
I create a branch on Sling Graphql Core *issue/SLING-10900-201* that allows to
test it with the latest fixes in graphql-java. These are the instructions.
# Checkout my branch: **issue/manifest-mf.order** from Github:
https://github.com/schaefa/graphql-java/tree/issue/manifest-mf.order
# Go to its folder
# Change to Java 11
# Set release version with: `export RELEASE_VERSION="20.1-SNAPSHOT"`
# Build with: `./gradlew clean publishToMavenLocal -x
signGraphqlJavaPublication`
# Copy the folder **com/graphql-java/graphql-java/20.1-SNAPSHOT** from your
local .m2 repository to a folder **respository** inside the Sling Graphql Core
## Make sure all the sub folders are created or copied to there to (this is
the path to the JAR file:
`respository/com/graphql-java/graphql-java/20.1-SNAPSHOT/graphql-java-20.1-SNAPSHOT.jar`)
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Pax Error with graphql-java 20.9
Hi I ran into a build issue with Sling Graphql Core when I use graphql-java 20.0 (the current released version). Even though that release will not be usable in an OSGi container the latest code will have the same issue. The problem is that Pax together with Graphql-java cannot find the GenericConnection class. This works in 17.4 though. When I use the code in AEM to test graphql I don’t encounter issue with that class. Error: java.util.concurrent.CompletionException: java.lang.NoClassDefFoundError: org/apache/sling/graphql/helpers/GenericConnection at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:331) at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:346) at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:870) at java.base/java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:883) … Caused by: java.lang.NoClassDefFoundError: org/apache/sling/graphql/helpers/GenericConnection at graphql.schema.PropertyFetchingImpl.getPropertyValue(PropertyFetchingImpl.java:114) at graphql.schema.PropertyDataFetcherHelper.getPropertyValue(PropertyDataFetcherHelper.java:22) at graphql.schema.PropertyDataFetcher.getImpl(PropertyDataFetcher.java:131) ... Caused by: java.lang.ClassNotFoundException: org.apache.sling.graphql.helpers.GenericConnection not found by graphql-java [209] at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1597) at org.apache.felix.framework.BundleWiringImpl.access$300(BundleWiringImpl.java:79) at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1982) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) ... 91 more I am not a Pax expert and so I am stuck here. The failing code can be found in branch: issue/SLING-10900-200 on module sling-org-apache-sling-graphql-core Cheers - Andy
Re: Upgrade graphgql-java to 17.4
Hi Just an updated on the development of moving to a newer version of grqphql-java: Testing with Sling Graphql Core and AEM I did test graphql-java 17.4 and 20.0 and both versions seems to work just fine even though 20.0 does lead to a PAX testing issue in Sling Graphql Core but I think that’s not a big issue. There are a few issues that I am working out with the graphql-java team: - sun.misc is imported in the bundle (resolved) - MANIFEST.MF is not 1st entry in the JAR file (work in progresss) Cheers - Andy > On Feb 3, 2023, at 10:25 AM, Andreas Schaefer > wrote: > > Right now I am having issues with the SelectionSetWrapper and > SelectedFieldWrapper. The way graphql-java is providing the > DataFetchingFieldSelectionSet is quite different and I am not sure how to > handle it. > > The big difference is that there are no sub fields anymore and also no > InlineFragment vs Field. The Inline Fragment is not part of the Object Type > and a field name with different object types are combined into one. This > means I need to handle Object Types either in the caller to create one > SelectedFieldWrapper for each type or change the entire logic and make the > Sling Graphql Core work similar to graphql-java. > > I will start without changing Sling and then see if it works out. > > - Andy > >> On Feb 3, 2023, at 9:03 AM, Radu Cotescu wrote: >> >> Hi Andy, >> >>> On 3 Feb 2023, at 16:40, Andreas Schaefer wrote: >>> >>> Hi >>> >>> I am tasked with upgrading grqaphql-java for AEM to at least 17.4 because >>> of a vulnerability https://nvd.nist.gov/vuln/detail/CVE-2022-37734 >>> >>> I saw that Radu created a ticket for upgrading to graphql-java 17: >>> https://github.com/graphql-java/graphql-java/releases/tag/v17.0 >>> >>> I assigned that ticket to me and will see what needs to be done to make >>> this work in Sling as well as in AEM. >>> >>> Let me know if you have any objections or already worked on it. >>> >>> Thanks - Andy Schaefer >> >> No objections on my side. I started looking into this [0], but didn’t get to >> commit anything. I remember I had issues with dynamically registering our >> Sling directives [1], but I had to switch to a different task and forgot >> about [0]. >> >> Thanks, >> Radu >> >> [0] - https://issues.apache.org/jira/browse/SLING-10900 >> [1] - >> https://github.com/apache/sling-org-apache-sling-graphql-core/blob/0b1c1dd72ed04324ea84d2227c3223ec65b0b21e/src/main/java/org/apache/sling/graphql/core/directives/Directives.java >> >
Re: Upgrade graphgql-java to 17.4
Right now I am having issues with the SelectionSetWrapper and SelectedFieldWrapper. The way graphql-java is providing the DataFetchingFieldSelectionSet is quite different and I am not sure how to handle it. The big difference is that there are no sub fields anymore and also no InlineFragment vs Field. The Inline Fragment is not part of the Object Type and a field name with different object types are combined into one. This means I need to handle Object Types either in the caller to create one SelectedFieldWrapper for each type or change the entire logic and make the Sling Graphql Core work similar to graphql-java. I will start without changing Sling and then see if it works out. - Andy > On Feb 3, 2023, at 9:03 AM, Radu Cotescu wrote: > > Hi Andy, > >> On 3 Feb 2023, at 16:40, Andreas Schaefer wrote: >> >> Hi >> >> I am tasked with upgrading grqaphql-java for AEM to at least 17.4 because of >> a vulnerability https://nvd.nist.gov/vuln/detail/CVE-2022-37734 >> >> I saw that Radu created a ticket for upgrading to graphql-java 17: >> https://github.com/graphql-java/graphql-java/releases/tag/v17.0 >> >> I assigned that ticket to me and will see what needs to be done to make this >> work in Sling as well as in AEM. >> >> Let me know if you have any objections or already worked on it. >> >> Thanks - Andy Schaefer > > No objections on my side. I started looking into this [0], but didn’t get to > commit anything. I remember I had issues with dynamically registering our > Sling directives [1], but I had to switch to a different task and forgot > about [0]. > > Thanks, > Radu > > [0] - https://issues.apache.org/jira/browse/SLING-10900 > [1] - > https://github.com/apache/sling-org-apache-sling-graphql-core/blob/0b1c1dd72ed04324ea84d2227c3223ec65b0b21e/src/main/java/org/apache/sling/graphql/core/directives/Directives.java >
Upgrade graphgql-java to 17.4
Hi I am tasked with upgrading grqaphql-java for AEM to at least 17.4 because of a vulnerability https://nvd.nist.gov/vuln/detail/CVE-2022-37734 I saw that Radu created a ticket for upgrading to graphql-java 17: https://github.com/graphql-java/graphql-java/releases/tag/v17.0 I assigned that ticket to me and will see what needs to be done to make this work in Sling as well as in AEM. Let me know if you have any objections or already worked on it. Thanks - Andy Schaefer
[jira] [Assigned] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer reassigned SLING-10900:
Assignee: Andreas Schaefer (was: Radu Cotescu)
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637398#comment-17637398
]
Andreas Schaefer commented on SLING-11458:
--
[~radu] I don't mind fixing the issue upstream or does not throw an exception
when someone calls flush / close on an already closed writer. That said I don't
understand why the writer needs to be closed in the GraphQLServlet? This was
not happening before.
Is there a reason why the Servlet Writer needs to be closed? Otherwise we
should keep the Writer open.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634573#comment-17634573
]
Andreas Schaefer edited comment on SLING-11458 at 11/16/22 10:02 PM:
-
The problem here is that the Johnzon's JsonWriter is closing the enclosed
Servlet Print Writer which then will cause the WriterAlreadyClosedException
when the Rewriter Response wants to flush the Print Writer.
If we would not use the JsonWriter we would not have this issue because the
PrintWriter is not bound to the try-block.
was (Author: schaefa):
The problem here is that the Johnson's JsonWriter is closing the enclosed
Servlet Print Writer which then will cause the WriterAlreadyClosedException
when the Rewriter Response wants to flush the Print Writer.
If we would not use the JsonWriter we would not have this issue because the
PrintWriter is not bound to the try-block.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634573#comment-17634573
]
Andreas Schaefer commented on SLING-11458:
--
The problem here is that the Johnson's JsonWriter is closing the enclosed
Servlet Print Writer which then will cause the WriterAlreadyClosedException
when the Rewriter Response wants to flush the Print Writer.
If we would not use the JsonWriter we would not have this issue because the
PrintWriter is not bound to the try-block.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634524#comment-17634524
]
Andreas Schaefer commented on SLING-11458:
--
[~radu] Do you know if anything was done regarding this issue?
I think the discussion you mentioned is not related to this issue as this is a
problem because the Servlet Writer is closed because of the Json Writer leaving
the try block and so specific to the GraphQL Servlet.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
XSSAPI.encodeForHTMLAttr() does not handle code injection
Hi When I use XSSAPI.encodeForHTMLAttr() with this value: /content/dam/test-folder/">.html The resulting html tag will be closed on the tag is injected. I would assume that a method like this will not allow the HTML Attribute to be closed let alone to close the tag altogether. Is there a way to fix that within the Sling XSS suite ? Is that a shortcoming / bug ? Thanks - Andy
[jira] [Commented] (SLING-11486) Allow to use a Writer that check for close as used in Response Context Support
[ https://issues.apache.org/jira/browse/SLING-11486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569618#comment-17569618 ] Andreas Schaefer commented on SLING-11486: -- PR for this ticket can be found here: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/8 > Allow to use a Writer that check for close as used in Response Context Support > -- > > Key: SLING-11486 > URL: https://issues.apache.org/jira/browse/SLING-11486 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Servlet Helpers 1.4.2 >Reporter: Andreas Schaefer > Assignee: Andreas Schaefer >Priority: Major > Fix For: Servlet Helpers 1.4.4 > > Time Spent: 10m > Remaining Estimate: 0h > > A problem with testing GraphQL is that the Unit test does not fail when the > Writer was closed during the invocation. So the Mock Servlet Http Response > should provide a Writer that checks if the writer was already closed to mimic > the actual behavior. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11486) Allow to use a Writer that check for close as used in Response Context Support
Andreas Schaefer created SLING-11486: Summary: Allow to use a Writer that check for close as used in Response Context Support Key: SLING-11486 URL: https://issues.apache.org/jira/browse/SLING-11486 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Servlet Helpers 1.4.2 Reporter: Andreas Schaefer Assignee: Andreas Schaefer Fix For: Servlet Helpers 1.4.4 A problem with testing GraphQL is that the Unit test does not fail when the Writer was closed during the invocation. So the Mock Servlet Http Response should provide a Writer that checks if the writer was already closed to mimic the actual behavior. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Mock Sling Http Servlet Response Writer does not check if already closed
Hi I wanted to add a test to the GraphQLServlet to make sure that the closure of the Writer is causing a test failure but the Response Content Support does not support that. So I wanted to suggest a flag on the Mock Sling Http Servlet Response that would allow to use the same Delete Print Writer that is used in the Sling Http Servlet Response Impl. This was it would not make tests fails that does not care about it but allows a tester to make sure a writer is not accidentally closed. Any objects? - Andy
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567402#comment-17567402
]
Andreas Schaefer commented on SLING-11458:
--
I encountered that issue in AEM when using the AEM GraphiQL UI:
15.07.2022 13:36:29.907 *ERROR* [127.0.0.1 [1657917208499] POST
/content/cq:graphql/as-conf-1/endpoint.json HTTP/1.1]
org.apache.sling.engine.impl.SlingRequestProcessorImpl Writer has already been
closed.
org.apache.sling.engine.impl.SlingHttpServletResponseImpl$WriterAlreadyClosedException:
null
at
org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.checkClosed(SlingHttpServletResponseImpl.java:191)
[org.apache.sling.engine:2.9.0]
at
org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.flush(SlingHttpServletResponseImpl.java:228)
[org.apache.sling.engine:2.9.0]
at
org.apache.sling.rewriter.impl.RewriterResponse.flushBuffer(RewriterResponse.java:126)
[org.apache.sling.rewriter:1.3.2]
at
org.apache.sling.engine.impl.request.SlingRequestDispatcher.forward(SlingRequestDispatcher.java:151)
[org.apache.sling.engine:2.9.0]
at
com.day.cq.wcm.core.impl.WCMComponentFilter$ForwardRequestDispatcher.forward(WCMComponentFilter.java:503)
[com.day.cq.wcm.cq-wcm-core:5.14.46]
at
com.adobe.aem.graphql.sites.adapters.sling.SlingGraphQLForwardingServlet.forwardRequest(SlingGraphQLForwardingServlet.java:80)
[com.adobe.aem.graphql.sling-adapter:0.1.42]
at
com.adobe.aem.graphql.sites.adapters.sling.SlingGraphQLForwardingServlet.doPost(SlingGraphQLForwardingServlet.java:67)
[com.adobe.aem.graphql.sling-adapter:0.1.42]
It does not affect the output but it is pretty noisy.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.6
>
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer updated SLING-11458:
-
Description:
The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
{{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
such [closes the
Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
This causes a "Writer has already been closed" Exception when {{flush()}} is
called.
This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
fix as now the JsonWriter is closed when existing the try-catch block.
I will undo it and prevent the premature closure as this is causing issues like
when the call to this servlet is made through a dispatcher.
was:
The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
{{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
such [closes the
Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
This causes a "Writer has already been closed" Exception when {{flush()}} is
called.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
> Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.6
>
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer reassigned SLING-11458:
Assignee: Andreas Schaefer (was: Bertrand Delacretaz)
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.6
>
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
Andreas Schaefer created SLING-11458:
Summary: Regress - "Writer has already been closed" exception in
GraphQLServlet
Key: SLING-11458
URL: https://issues.apache.org/jira/browse/SLING-11458
Project: Sling
Issue Type: Bug
Components: GraphQL
Affects Versions: GraphQL Core 0.0.4
Reporter: Evgeny Tugarev
Assignee: Bertrand Delacretaz
Fix For: GraphQL Core 0.0.6
The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
{{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
such [closes the
Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
This causes a "Writer has already been closed" Exception when {{flush()}} is
called.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-11427. -- Resolution: Fixed A fix was created in PR #24, approved and merged into master > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > Time Spent: 2.5h > Remaining Estimate: 0h > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Repo-Init: register Namespace with a trailing hashtag (#)
I created a simple solution to allow for a hashtag inside the URI with: register namespace (foo2) http://test.com/v/1.0\# <http://test.com/v/1.0%5C#> The PR link is: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24 <https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24> - Andy > On Jun 29, 2022, at 10:26 AM, Andreas Schaefer > wrote: > > I created a ticket for it: https://issues.apache.org/jira/browse/SLING-11427 > <https://issues.apache.org/jira/browse/SLING-11427> > > - Andy > >> On Jun 28, 2022, at 1:46 PM, Eric Norman wrote: >> >> Hi Andy, >> >> I agree that it looks like the grammar for parsing the namespace value is >> too strict. It should accept any string that is a valid URI. >> >> Can you open up a bug report with your findings? >> >> If you need a temporary workaround, you may also register a namespace using >> the "register nodetypes" instruction with CND syntax that looks something >> like this: >> >> register nodetypes >> <<=== >> http://ns.adobe.com/xap/1.0/sType/Dimensions#'> >> ===>> >> >> >> Regards, >> -Eric >> >> >> On Mon, Jun 27, 2022 at 4:43 PM Andreas Schaefer >> wrote: >> >>> Hi >>> >>> I wanted to register namespaces with the Repo-Init and it works except for >>> namespaces with a trailing hashtag like: >>> >>> "register namespace (stDim) http://ns.adobe.com/xap/1.0/sType/Dimensions# >>> ”, >>> >>> Fails with: >>> >>> 7.06.2022 16:12:41.019 *ERROR* [Apache Sling Repository Startup Thread #1] >>> com.adobe.granite.repository.impl.SlingRepositoryManager Exception in a >>> SlingRepositoryInitializer, SlingRepository service registration aborted >>> org.apache.sling.repoinit.parser.RepoInitParsingException: Encountered "" >>> at line 14, column 1._Was expecting one of:_ >>> at >>> org.apache.sling.repoinit.parser.impl.RepoInitParserService.parse(RepoInitParserService.java:45) >>> [org.apache.sling.repoinit.parser:1.6.14] >>> at >>> org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.processRepository(RepositoryInitializerFactory.java:127) >>> [org.apache.sling.jcr.repoinit:1.1.39.T20220426093723-a4cd7db] >>> at >>> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.executeRepositoryInitializers(AbstractSlingRepositoryManager.java:627) >>> [org.apache.sling.jcr.base:3.1.10] >>> at >>> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAndRegisterRepositoryService(AbstractSlingRepositoryManager.java:575) >>> [org.apache.sling.jcr.base:3.1.10] >>> at >>> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager.java:96) >>> [org.apache.sling.jcr.base:3.1.10] >>> at >>> org.apache.sling.jcr.base.AbstractSlingRepositoryManager$4.run(AbstractSlingRepositoryManager.java:544) >>> [org.apache.sling.jcr.base:3.1.10] >>> Caused by: org.apache.sling.repoinit.parser.impl.ParseException: >>> Encountered "" at line 14, column 1._Was expecting one of:_ >>> at >>> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.generateParseException(RepoInitParserImpl.java:4888) >>> [org.apache.sling.repoinit.parser:1.6.14] >>> at >>> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.jj_consume_token(RepoInitParserImpl.java:4770) >>> [org.apache.sling.repoinit.parser:1.6.14] >>> at >>> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.registerNamespaceStatement(RepoInitParserImpl.java:1590) >>> [org.apache.sling.repoinit.parser:1.6.14] >>> at >>> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.parse(RepoInitParserImpl.java:69) >>> [org.apache.sling.repoinit.parser:1.6.14] >>> at >>> org.apache.sling.repoinit.parser.impl.RepoInitParserService.parse(RepoInitParserService.java:43) >>> [org.apache.sling.repoinit.parser:1.6.14] >>> >>> AEM has many of these namespaces registered out of the box so I should be >>> able to add one of them. >>> >>> I tried to escape it with \ but that did not work either. >>> >>> - Andy >
[jira] [Commented] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560684#comment-17560684 ] Andreas Schaefer commented on SLING-11427: -- I created a simple 'fix' for that on this PR: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24 > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560672#comment-17560672 ] Andreas Schaefer commented on SLING-11427: -- Adding this line to the end of test-40.txt: register namespace (foo2) uri:some-uri/V/1.0/test# Is missing the output: RegisterNamespace (foo2) uri:some-uri/V/1.0/test# Adding this: register namespace (foo2) uri:some-uri/V/1.0/test\# is yielding a parser exception: Caused by: org.apache.sling.repoinit.parser.impl.TokenMgrError: Lexical error at line 4, column 50. Encountered: "\\" (92), after : "" at org.apache.sling.repoinit.parser.impl.RepoInitParserImplTokenManager.getNextToken(RepoInitParserImplTokenManager.java:1200) I am not a Javacc expert and so my attempts to rectify this issue failed. > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Repo-Init: register Namespace with a trailing hashtag (#)
I created a ticket for it: https://issues.apache.org/jira/browse/SLING-11427 <https://issues.apache.org/jira/browse/SLING-11427> - Andy > On Jun 28, 2022, at 1:46 PM, Eric Norman wrote: > > Hi Andy, > > I agree that it looks like the grammar for parsing the namespace value is > too strict. It should accept any string that is a valid URI. > > Can you open up a bug report with your findings? > > If you need a temporary workaround, you may also register a namespace using > the "register nodetypes" instruction with CND syntax that looks something > like this: > > register nodetypes > <<=== >http://ns.adobe.com/xap/1.0/sType/Dimensions#'> > ===>> > > > Regards, > -Eric > > > On Mon, Jun 27, 2022 at 4:43 PM Andreas Schaefer > wrote: > >> Hi >> >> I wanted to register namespaces with the Repo-Init and it works except for >> namespaces with a trailing hashtag like: >> >> "register namespace (stDim) http://ns.adobe.com/xap/1.0/sType/Dimensions# >> ”, >> >> Fails with: >> >> 7.06.2022 16:12:41.019 *ERROR* [Apache Sling Repository Startup Thread #1] >> com.adobe.granite.repository.impl.SlingRepositoryManager Exception in a >> SlingRepositoryInitializer, SlingRepository service registration aborted >> org.apache.sling.repoinit.parser.RepoInitParsingException: Encountered "" >> at line 14, column 1._Was expecting one of:_ >>at >> org.apache.sling.repoinit.parser.impl.RepoInitParserService.parse(RepoInitParserService.java:45) >> [org.apache.sling.repoinit.parser:1.6.14] >>at >> org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.processRepository(RepositoryInitializerFactory.java:127) >> [org.apache.sling.jcr.repoinit:1.1.39.T20220426093723-a4cd7db] >>at >> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.executeRepositoryInitializers(AbstractSlingRepositoryManager.java:627) >> [org.apache.sling.jcr.base:3.1.10] >>at >> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAndRegisterRepositoryService(AbstractSlingRepositoryManager.java:575) >> [org.apache.sling.jcr.base:3.1.10] >>at >> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager.java:96) >> [org.apache.sling.jcr.base:3.1.10] >>at >> org.apache.sling.jcr.base.AbstractSlingRepositoryManager$4.run(AbstractSlingRepositoryManager.java:544) >> [org.apache.sling.jcr.base:3.1.10] >> Caused by: org.apache.sling.repoinit.parser.impl.ParseException: >> Encountered "" at line 14, column 1._Was expecting one of:_ >>at >> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.generateParseException(RepoInitParserImpl.java:4888) >> [org.apache.sling.repoinit.parser:1.6.14] >>at >> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.jj_consume_token(RepoInitParserImpl.java:4770) >> [org.apache.sling.repoinit.parser:1.6.14] >>at >> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.registerNamespaceStatement(RepoInitParserImpl.java:1590) >> [org.apache.sling.repoinit.parser:1.6.14] >>at >> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.parse(RepoInitParserImpl.java:69) >> [org.apache.sling.repoinit.parser:1.6.14] >>at >> org.apache.sling.repoinit.parser.impl.RepoInitParserService.parse(RepoInitParserService.java:43) >> [org.apache.sling.repoinit.parser:1.6.14] >> >> AEM has many of these namespaces registered out of the box so I should be >> able to add one of them. >> >> I tried to escape it with \ but that did not work either. >> >> - Andy
[jira] [Updated] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-11427: - Description: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] was: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (\#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-11427: - Description: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (\\#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] was: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (\\#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-11427: - Description: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] was: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (\\#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-11427: - Description: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (\#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] was: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag: register namespace (stDim) http://ns.adobe.com/xap/1.0/sType/Dimensions\# > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (\#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
Andreas Schaefer created SLING-11427: Summary: Registering a Namespace does not allow Hashtag in the URI Key: SLING-11427 URL: https://issues.apache.org/jira/browse/SLING-11427 Project: Sling Issue Type: Bug Components: Repoinit Affects Versions: Repoinit Parser 1.6.4 Reporter: Andreas Schaefer Fix For: Repoinit Parser 1.6.16 Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag: register namespace (stDim) http://ns.adobe.com/xap/1.0/sType/Dimensions\# -- This message was sent by Atlassian Jira (v8.20.10#820010)
Repo-Init: register Namespace with a trailing hashtag (#)
Hi I wanted to register namespaces with the Repo-Init and it works except for namespaces with a trailing hashtag like: "register namespace (stDim) http://ns.adobe.com/xap/1.0/sType/Dimensions#”, Fails with: 7.06.2022 16:12:41.019 *ERROR* [Apache Sling Repository Startup Thread #1] com.adobe.granite.repository.impl.SlingRepositoryManager Exception in a SlingRepositoryInitializer, SlingRepository service registration aborted org.apache.sling.repoinit.parser.RepoInitParsingException: Encountered "" at line 14, column 1._Was expecting one of:_ at org.apache.sling.repoinit.parser.impl.RepoInitParserService.parse(RepoInitParserService.java:45) [org.apache.sling.repoinit.parser:1.6.14] at org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.processRepository(RepositoryInitializerFactory.java:127) [org.apache.sling.jcr.repoinit:1.1.39.T20220426093723-a4cd7db] at org.apache.sling.jcr.base.AbstractSlingRepositoryManager.executeRepositoryInitializers(AbstractSlingRepositoryManager.java:627) [org.apache.sling.jcr.base:3.1.10] at org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAndRegisterRepositoryService(AbstractSlingRepositoryManager.java:575) [org.apache.sling.jcr.base:3.1.10] at org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager.java:96) [org.apache.sling.jcr.base:3.1.10] at org.apache.sling.jcr.base.AbstractSlingRepositoryManager$4.run(AbstractSlingRepositoryManager.java:544) [org.apache.sling.jcr.base:3.1.10] Caused by: org.apache.sling.repoinit.parser.impl.ParseException: Encountered "" at line 14, column 1._Was expecting one of:_ at org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.generateParseException(RepoInitParserImpl.java:4888) [org.apache.sling.repoinit.parser:1.6.14] at org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.jj_consume_token(RepoInitParserImpl.java:4770) [org.apache.sling.repoinit.parser:1.6.14] at org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.registerNamespaceStatement(RepoInitParserImpl.java:1590) [org.apache.sling.repoinit.parser:1.6.14] at org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.parse(RepoInitParserImpl.java:69) [org.apache.sling.repoinit.parser:1.6.14] at org.apache.sling.repoinit.parser.impl.RepoInitParserService.parse(RepoInitParserService.java:43) [org.apache.sling.repoinit.parser:1.6.14] AEM has many of these namespaces registered out of the box so I should be able to add one of them. I tried to escape it with \ but that did not work either. - Andy
Re: Maven Archetypes
Hi team Looking at the Project Archetype I see that I did not add support for FMs. So I was wondering if that would be something you might be interested. I was thinking to keep the current code / layout around with Bundle and Content Package(s) but add support for FMs and FARs. This would require: - Add a ‘far’ module that creates a FM and FAR like the All does - Migrate the rest to be able to generate FMs and convert if needed - Added a Bundle Content Module for the traditional and FM version - Use the post processing to remove unwanted modules or parts of them - Use kickstart to test the deployment of the FM / FAR module Cheers - Andy > On Oct 8, 2021, at 12:34 PM, Andreas Schaefer > wrote: > > Hi > > I did not work on the Project Archetype for a while but I am going to have a > look into it with respect to FMs. > There were some suggestions on how to improve it a while back and I will try > to find them again. > > Cheers - Andy > >> On Oct 8, 2021, at 8:01 AM, Robert Munteanu wrote: >> >> On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote: >>> Hi >>> >>>> Shall we mark those archetypes as deprecated for now? >>> Yes. I can make that update to the site (if no one objects). It makes >>> sense to deprecate broken archetypes, at least temporarily. These >>> provide an initial starting point for developers looking to try the >>> framework, so I think they should not only work properly but also >>> have good documentation if possible. I also understand resource >>> constraints. >> >> +1 from me. >>> >>> >>>> I would be in favour of just maintaing the sling-project-archetype >>>> and >>>> making sure that a) it works and b) is a reasonable starting point >>>> for >>>> Sling-based apps. >>> >>> FYI. I used sling-project-archetype two days ago. It worked well for >>> me. It provided a reasonable starting basis for my new project. >> >> Good to know, thanks. >> Robert >
Re: Maven Archetypes
Hi I did not work on the Project Archetype for a while but I am going to have a look into it with respect to FMs. There were some suggestions on how to improve it a while back and I will try to find them again. Cheers - Andy > On Oct 8, 2021, at 8:01 AM, Robert Munteanu wrote: > > On Fri, 2021-10-08 at 08:44 -0400, Cris Rockwell wrote: >> Hi >> >>> Shall we mark those archetypes as deprecated for now? >> Yes. I can make that update to the site (if no one objects). It makes >> sense to deprecate broken archetypes, at least temporarily. These >> provide an initial starting point for developers looking to try the >> framework, so I think they should not only work properly but also >> have good documentation if possible. I also understand resource >> constraints. > > +1 from me. >> >> >>> I would be in favour of just maintaing the sling-project-archetype >>> and >>> making sure that a) it works and b) is a reasonable starting point >>> for >>> Sling-based apps. >> >> FYI. I used sling-project-archetype two days ago. It worked well for >> me. It provided a reasonable starting basis for my new project. > > Good to know, thanks. > Robert
